]> git.lizzy.rs Git - dragonfireclient.git/blobdiff - src/nodedef.cpp
Add Block Formspec Hack
[dragonfireclient.git] / src / nodedef.cpp
index e547e31b131db5b74375ade37727940e9268ec82..540ed6086a081a7c6edc1b345caf111f1943c5f2 100644 (file)
@@ -21,9 +21,9 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 
 #include "itemdef.h"
 #ifndef SERVER
-#include "mesh.h"
-#include "shader.h"
-#include "client.h"
+#include "client/mesh.h"
+#include "client/shader.h"
+#include "client/client.h"
 #include "client/renderingengine.h"
 #include "client/tile.h"
 #include <IMeshManipulator.h>
@@ -38,6 +38,8 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "gamedef.h"
 #include "mapnode.h"
 #include <fstream> // Used in applyTextureOverrides()
+#include <algorithm>
+#include <cmath>
 
 /*
        NodeBox
@@ -59,12 +61,20 @@ void NodeBox::reset()
        connect_left.clear();
        connect_back.clear();
        connect_right.clear();
+       disconnected_top.clear();
+       disconnected_bottom.clear();
+       disconnected_front.clear();
+       disconnected_left.clear();
+       disconnected_back.clear();
+       disconnected_right.clear();
+       disconnected.clear();
+       disconnected_sides.clear();
 }
 
 void NodeBox::serialize(std::ostream &os, u16 protocol_version) const
 {
        // Protocol >= 36
-       int version = 4;
+       const u8 version = 6;
        writeU8(os, version);
 
        switch (type) {
@@ -74,19 +84,19 @@ void NodeBox::serialize(std::ostream &os, u16 protocol_version) const
 
                writeU16(os, fixed.size());
                for (const aabb3f &nodebox : fixed) {
-                       writeV3F1000(os, nodebox.MinEdge);
-                       writeV3F1000(os, nodebox.MaxEdge);
+                       writeV3F32(os, nodebox.MinEdge);
+                       writeV3F32(os, nodebox.MaxEdge);
                }
                break;
        case NODEBOX_WALLMOUNTED:
                writeU8(os, type);
 
-               writeV3F1000(os, wall_top.MinEdge);
-               writeV3F1000(os, wall_top.MaxEdge);
-               writeV3F1000(os, wall_bottom.MinEdge);
-               writeV3F1000(os, wall_bottom.MaxEdge);
-               writeV3F1000(os, wall_side.MinEdge);
-               writeV3F1000(os, wall_side.MaxEdge);
+               writeV3F32(os, wall_top.MinEdge);
+               writeV3F32(os, wall_top.MaxEdge);
+               writeV3F32(os, wall_bottom.MinEdge);
+               writeV3F32(os, wall_bottom.MaxEdge);
+               writeV3F32(os, wall_side.MinEdge);
+               writeV3F32(os, wall_side.MaxEdge);
                break;
        case NODEBOX_CONNECTED:
                writeU8(os, type);
@@ -94,8 +104,8 @@ void NodeBox::serialize(std::ostream &os, u16 protocol_version) const
 #define WRITEBOX(box) \
                writeU16(os, (box).size()); \
                for (const aabb3f &i: (box)) { \
-                       writeV3F1000(os, i.MinEdge); \
-                       writeV3F1000(os, i.MaxEdge); \
+                       writeV3F32(os, i.MinEdge); \
+                       writeV3F32(os, i.MaxEdge); \
                };
 
                WRITEBOX(fixed);
@@ -105,6 +115,14 @@ void NodeBox::serialize(std::ostream &os, u16 protocol_version) const
                WRITEBOX(connect_left);
                WRITEBOX(connect_back);
                WRITEBOX(connect_right);
+               WRITEBOX(disconnected_top);
+               WRITEBOX(disconnected_bottom);
+               WRITEBOX(disconnected_front);
+               WRITEBOX(disconnected_left);
+               WRITEBOX(disconnected_back);
+               WRITEBOX(disconnected_right);
+               WRITEBOX(disconnected);
+               WRITEBOX(disconnected_sides);
                break;
        default:
                writeU8(os, type);
@@ -115,7 +133,7 @@ void NodeBox::serialize(std::ostream &os, u16 protocol_version) const
 void NodeBox::deSerialize(std::istream &is)
 {
        int version = readU8(is);
-       if (version < 4)
+       if (version < 6)
                throw SerializationError("unsupported NodeBox version");
 
        reset();
@@ -128,19 +146,19 @@ void NodeBox::deSerialize(std::istream &is)
                while(fixed_count--)
                {
                        aabb3f box;
-                       box.MinEdge = readV3F1000(is);
-                       box.MaxEdge = readV3F1000(is);
+                       box.MinEdge = readV3F32(is);
+                       box.MaxEdge = readV3F32(is);
                        fixed.push_back(box);
                }
        }
        else if(type == NODEBOX_WALLMOUNTED)
        {
-               wall_top.MinEdge = readV3F1000(is);
-               wall_top.MaxEdge = readV3F1000(is);
-               wall_bottom.MinEdge = readV3F1000(is);
-               wall_bottom.MaxEdge = readV3F1000(is);
-               wall_side.MinEdge = readV3F1000(is);
-               wall_side.MaxEdge = readV3F1000(is);
+               wall_top.MinEdge = readV3F32(is);
+               wall_top.MaxEdge = readV3F32(is);
+               wall_bottom.MinEdge = readV3F32(is);
+               wall_bottom.MaxEdge = readV3F32(is);
+               wall_side.MinEdge = readV3F32(is);
+               wall_side.MaxEdge = readV3F32(is);
        }
        else if (type == NODEBOX_CONNECTED)
        {
@@ -148,8 +166,8 @@ void NodeBox::deSerialize(std::istream &is)
                count = readU16(is); \
                (box).reserve(count); \
                while (count--) { \
-                       v3f min = readV3F1000(is); \
-                       v3f max = readV3F1000(is); \
+                       v3f min = readV3F32(is); \
+                       v3f max = readV3F32(is); \
                        (box).emplace_back(min, max); }; }
 
                u16 count;
@@ -161,6 +179,14 @@ void NodeBox::deSerialize(std::istream &is)
                READBOXES(connect_left);
                READBOXES(connect_back);
                READBOXES(connect_right);
+               READBOXES(disconnected_top);
+               READBOXES(disconnected_bottom);
+               READBOXES(disconnected_front);
+               READBOXES(disconnected_left);
+               READBOXES(disconnected_back);
+               READBOXES(disconnected_right);
+               READBOXES(disconnected);
+               READBOXES(disconnected_sides);
        }
 }
 
@@ -168,60 +194,72 @@ void NodeBox::deSerialize(std::istream &is)
        TileDef
 */
 
+#define TILE_FLAG_BACKFACE_CULLING     (1 << 0)
+#define TILE_FLAG_TILEABLE_HORIZONTAL  (1 << 1)
+#define TILE_FLAG_TILEABLE_VERTICAL    (1 << 2)
+#define TILE_FLAG_HAS_COLOR    (1 << 3)
+#define TILE_FLAG_HAS_SCALE    (1 << 4)
+#define TILE_FLAG_HAS_ALIGN_STYLE      (1 << 5)
+
 void TileDef::serialize(std::ostream &os, u16 protocol_version) const
 {
        // protocol_version >= 36
-       u8 version = 5;
+       u8 version = 6;
        writeU8(os, version);
 
        os << serializeString(name);
        animation.serialize(os, version);
-       writeU8(os, backface_culling);
-       writeU8(os, tileable_horizontal);
-       writeU8(os, tileable_vertical);
-       writeU8(os, has_color);
+       bool has_scale = scale > 0;
+       u16 flags = 0;
+       if (backface_culling)
+               flags |= TILE_FLAG_BACKFACE_CULLING;
+       if (tileable_horizontal)
+               flags |= TILE_FLAG_TILEABLE_HORIZONTAL;
+       if (tileable_vertical)
+               flags |= TILE_FLAG_TILEABLE_VERTICAL;
+       if (has_color)
+               flags |= TILE_FLAG_HAS_COLOR;
+       if (has_scale)
+               flags |= TILE_FLAG_HAS_SCALE;
+       if (align_style != ALIGN_STYLE_NODE)
+               flags |= TILE_FLAG_HAS_ALIGN_STYLE;
+       writeU16(os, flags);
        if (has_color) {
                writeU8(os, color.getRed());
                writeU8(os, color.getGreen());
                writeU8(os, color.getBlue());
        }
+       if (has_scale)
+               writeU8(os, scale);
+       if (align_style != ALIGN_STYLE_NODE)
+               writeU8(os, align_style);
 }
 
 void TileDef::deSerialize(std::istream &is, u8 contentfeatures_version,
        NodeDrawType drawtype)
 {
        int version = readU8(is);
+       if (version < 6)
+               throw SerializationError("unsupported TileDef version");
        name = deSerializeString(is);
        animation.deSerialize(is, version);
-       backface_culling = readU8(is);
-       tileable_horizontal = readU8(is);
-       tileable_vertical = readU8(is);
-       has_color = readU8(is);
+       u16 flags = readU16(is);
+       backface_culling = flags & TILE_FLAG_BACKFACE_CULLING;
+       tileable_horizontal = flags & TILE_FLAG_TILEABLE_HORIZONTAL;
+       tileable_vertical = flags & TILE_FLAG_TILEABLE_VERTICAL;
+       has_color = flags & TILE_FLAG_HAS_COLOR;
+       bool has_scale = flags & TILE_FLAG_HAS_SCALE;
+       bool has_align_style = flags & TILE_FLAG_HAS_ALIGN_STYLE;
        if (has_color) {
                color.setRed(readU8(is));
                color.setGreen(readU8(is));
                color.setBlue(readU8(is));
        }
-}
-
-
-/*
-       SimpleSoundSpec serialization
-*/
-
-static void serializeSimpleSoundSpec(const SimpleSoundSpec &ss,
-               std::ostream &os, u8 version)
-{
-       os<<serializeString(ss.name);
-       writeF1000(os, ss.gain);
-       writeF1000(os, ss.pitch);
-}
-static void deSerializeSimpleSoundSpec(SimpleSoundSpec &ss,
-               std::istream &is, u8 version)
-{
-       ss.name = deSerializeString(is);
-       ss.gain = readF1000(is);
-       ss.pitch = readF1000(is);
+       scale = has_scale ? readU8(is) : 0;
+       if (has_align_style)
+               align_style = static_cast<AlignStyle>(readU8(is));
+       else
+               align_style = ALIGN_STYLE_NODE;
 }
 
 void TextureSettings::readSettings()
@@ -234,7 +272,10 @@ void TextureSettings::readSettings()
        bool smooth_lighting           = g_settings->getBool("smooth_lighting");
        enable_mesh_cache              = g_settings->getBool("enable_mesh_cache");
        enable_minimap                 = g_settings->getBool("enable_minimap");
+       node_texture_size              = g_settings->getU16("texture_min_size");
        std::string leaves_style_str   = g_settings->get("leaves_style");
+       std::string world_aligned_mode_str = g_settings->get("world_aligned_mode");
+       std::string autoscale_mode_str = g_settings->get("autoscale_mode");
 
        // Mesh cache is not supported in combination with smooth lighting
        if (smooth_lighting)
@@ -249,6 +290,22 @@ void TextureSettings::readSettings()
        } else {
                leaves_style = LEAVES_OPAQUE;
        }
+
+       if (world_aligned_mode_str == "enable")
+               world_aligned_mode = WORLDALIGN_ENABLE;
+       else if (world_aligned_mode_str == "force_solid")
+               world_aligned_mode = WORLDALIGN_FORCE;
+       else if (world_aligned_mode_str == "force_nodebox")
+               world_aligned_mode = WORLDALIGN_FORCE_NODEBOX;
+       else
+               world_aligned_mode = WORLDALIGN_DISABLE;
+
+       if (autoscale_mode_str == "enable")
+               autoscale_mode = AUTOSCALE_ENABLE;
+       else if (autoscale_mode_str == "force")
+               autoscale_mode = AUTOSCALE_FORCE;
+       else
+               autoscale_mode = AUTOSCALE_DISABLE;
 }
 
 /*
@@ -260,13 +317,25 @@ ContentFeatures::ContentFeatures()
        reset();
 }
 
+ContentFeatures::~ContentFeatures()
+{
+#ifndef SERVER
+       for (u16 j = 0; j < 6; j++) {
+               delete tiles[j].layers[0].frames;
+               delete tiles[j].layers[1].frames;
+       }
+       for (u16 j = 0; j < CF_SPECIAL_COUNT; j++)
+               delete special_tiles[j].layers[0].frames;
+#endif
+}
+
 void ContentFeatures::reset()
 {
        /*
                Cached stuff
        */
 #ifndef SERVER
-       solidness = 2;
+       solidness = 0;
        visual_solidness = 0;
        backface_culling = true;
 
@@ -311,9 +380,12 @@ void ContentFeatures::reset()
        floodable = false;
        rightclickable = true;
        leveled = 0;
+       leveled_max = LEVELED_MAX;
        liquid_type = LIQUID_NONE;
        liquid_alternative_flowing = "";
+       liquid_alternative_flowing_id = CONTENT_IGNORE;
        liquid_alternative_source = "";
+       liquid_alternative_source_id = CONTENT_IGNORE;
        liquid_viscosity = 0;
        liquid_renewable = true;
        liquid_range = LIQUID_LEVEL_MAX+1;
@@ -340,8 +412,7 @@ void ContentFeatures::reset()
 
 void ContentFeatures::serialize(std::ostream &os, u16 protocol_version) const
 {
-       // protocol_version >= 36
-       u8 version = 12;
+       const u8 version = CONTENTFEATURES_VERSION;
        writeU8(os, version);
 
        // general
@@ -357,7 +428,7 @@ void ContentFeatures::serialize(std::ostream &os, u16 protocol_version) const
        // visual
        writeU8(os, drawtype);
        os << serializeString(mesh);
-       writeF1000(os, visual_scale);
+       writeF32(os, visual_scale);
        writeU8(os, 6);
        for (const TileDef &td : tiledef)
                td.serialize(os, protocol_version);
@@ -377,10 +448,7 @@ void ContentFeatures::serialize(std::ostream &os, u16 protocol_version) const
        writeU16(os, connects_to_ids.size());
        for (u16 connects_to_id : connects_to_ids)
                writeU16(os, connects_to_id);
-       writeU8(os, post_effect_color.getAlpha());
-       writeU8(os, post_effect_color.getRed());
-       writeU8(os, post_effect_color.getGreen());
-       writeU8(os, post_effect_color.getBlue());
+       writeARGB8(os, post_effect_color);
        writeU8(os, leveled);
 
        // lighting
@@ -416,15 +484,16 @@ void ContentFeatures::serialize(std::ostream &os, u16 protocol_version) const
        collision_box.serialize(os, protocol_version);
 
        // sound
-       serializeSimpleSoundSpec(sound_footstep, os, version);
-       serializeSimpleSoundSpec(sound_dig, os, version);
-       serializeSimpleSoundSpec(sound_dug, os, version);
+       sound_footstep.serialize(os, version);
+       sound_dig.serialize(os, version);
+       sound_dug.serialize(os, version);
 
        // legacy
        writeU8(os, legacy_facedir_simple);
        writeU8(os, legacy_wallmounted);
 
        os << serializeString(node_dig_prediction);
+       writeU8(os, leveled_max);
 }
 
 void ContentFeatures::correctAlpha(TileDef *tiles, int length)
@@ -445,8 +514,8 @@ void ContentFeatures::correctAlpha(TileDef *tiles, int length)
 void ContentFeatures::deSerialize(std::istream &is)
 {
        // version detection
-       int version = readU8(is);
-       if (version < 12)
+       const u8 version = readU8(is);
+       if (version < CONTENTFEATURES_VERSION)
                throw SerializationError("unsupported ContentFeatures version");
 
        // general
@@ -464,7 +533,7 @@ void ContentFeatures::deSerialize(std::istream &is)
        // visual
        drawtype = (enum NodeDrawType) readU8(is);
        mesh = deSerializeString(is);
-       visual_scale = readF1000(is);
+       visual_scale = readF32(is);
        if (readU8(is) != 6)
                throw SerializationError("unsupported tile count");
        for (TileDef &td : tiledef)
@@ -485,11 +554,8 @@ void ContentFeatures::deSerialize(std::istream &is)
        u16 connects_to_size = readU16(is);
        connects_to_ids.clear();
        for (u16 i = 0; i < connects_to_size; i++)
-               connects_to_ids.insert(readU16(is));
-       post_effect_color.setAlpha(readU8(is));
-       post_effect_color.setRed(readU8(is));
-       post_effect_color.setGreen(readU8(is));
-       post_effect_color.setBlue(readU8(is));
+               connects_to_ids.push_back(readU16(is));
+       post_effect_color = readARGB8(is);
        leveled = readU8(is);
 
        // lighting-related
@@ -526,9 +592,9 @@ void ContentFeatures::deSerialize(std::istream &is)
        collision_box.deSerialize(is);
 
        // sounds
-       deSerializeSimpleSoundSpec(sound_footstep, is, version);
-       deSerializeSimpleSoundSpec(sound_dig, is, version);
-       deSerializeSimpleSoundSpec(sound_dug, is, version);
+       sound_footstep.deSerialize(is, version);
+       sound_dig.deSerialize(is, version);
+       sound_dug.deSerialize(is, version);
 
        // read legacy properties
        legacy_facedir_simple = readU8(is);
@@ -536,81 +602,117 @@ void ContentFeatures::deSerialize(std::istream &is)
 
        try {
                node_dig_prediction = deSerializeString(is);
+               u8 tmp_leveled_max = readU8(is);
+               if (is.eof()) /* readU8 doesn't throw exceptions so we have to do this */
+                       throw SerializationError("");
+               leveled_max = tmp_leveled_max;
        } catch(SerializationError &e) {};
 }
 
 #ifndef SERVER
-void ContentFeatures::fillTileAttribs(ITextureSource *tsrc, TileLayer *tile,
-               TileDef *tiledef, u32 shader_id, bool use_normal_texture,
-               bool backface_culling, u8 material_type)
+static void fillTileAttribs(ITextureSource *tsrc, TileLayer *layer,
+               const TileSpec &tile, const TileDef &tiledef, video::SColor color,
+               u8 material_type, u32 shader_id, bool backface_culling,
+               const TextureSettings &tsettings)
 {
-       tile->shader_id     = shader_id;
-       tile->texture       = tsrc->getTextureForMesh(tiledef->name, &tile->texture_id);
-       tile->material_type = material_type;
+       layer->shader_id     = shader_id;
+       layer->texture       = tsrc->getTextureForMesh(tiledef.name, &layer->texture_id);
+       layer->material_type = material_type;
+
+       bool has_scale = tiledef.scale > 0;
+       bool use_autoscale = tsettings.autoscale_mode == AUTOSCALE_FORCE ||
+               (tsettings.autoscale_mode == AUTOSCALE_ENABLE && !has_scale);
+       if (use_autoscale && layer->texture) {
+               auto texture_size = layer->texture->getOriginalSize();
+               float base_size = tsettings.node_texture_size;
+               float size = std::fmin(texture_size.Width, texture_size.Height);
+               layer->scale = std::fmax(base_size, size) / base_size;
+       } else if (has_scale) {
+               layer->scale = tiledef.scale;
+       } else {
+               layer->scale = 1;
+       }
+       if (!tile.world_aligned)
+               layer->scale = 1;
 
        // Normal texture and shader flags texture
-       if (use_normal_texture) {
-               tile->normal_texture = tsrc->getNormalTexture(tiledef->name);
+       if (tsettings.use_normal_texture) {
+               layer->normal_texture = tsrc->getNormalTexture(tiledef.name);
        }
-       tile->flags_texture = tsrc->getShaderFlagsTexture(tile->normal_texture ? true : false);
+       layer->flags_texture = tsrc->getShaderFlagsTexture(layer->normal_texture ? true : false);
 
        // Material flags
-       tile->material_flags = 0;
+       layer->material_flags = 0;
        if (backface_culling)
-               tile->material_flags |= MATERIAL_FLAG_BACKFACE_CULLING;
-       if (tiledef->animation.type != TAT_NONE)
-               tile->material_flags |= MATERIAL_FLAG_ANIMATION;
-       if (tiledef->tileable_horizontal)
-               tile->material_flags |= MATERIAL_FLAG_TILEABLE_HORIZONTAL;
-       if (tiledef->tileable_vertical)
-               tile->material_flags |= MATERIAL_FLAG_TILEABLE_VERTICAL;
+               layer->material_flags |= MATERIAL_FLAG_BACKFACE_CULLING;
+       if (tiledef.animation.type != TAT_NONE)
+               layer->material_flags |= MATERIAL_FLAG_ANIMATION;
+       if (tiledef.tileable_horizontal)
+               layer->material_flags |= MATERIAL_FLAG_TILEABLE_HORIZONTAL;
+       if (tiledef.tileable_vertical)
+               layer->material_flags |= MATERIAL_FLAG_TILEABLE_VERTICAL;
 
        // Color
-       tile->has_color = tiledef->has_color;
-       if (tiledef->has_color)
-               tile->color = tiledef->color;
+       layer->has_color = tiledef.has_color;
+       if (tiledef.has_color)
+               layer->color = tiledef.color;
        else
-               tile->color = color;
+               layer->color = color;
 
        // Animation parameters
        int frame_count = 1;
-       if (tile->material_flags & MATERIAL_FLAG_ANIMATION) {
+       if (layer->material_flags & MATERIAL_FLAG_ANIMATION) {
                int frame_length_ms;
-               tiledef->animation.determineParams(tile->texture->getOriginalSize(),
+               tiledef.animation.determineParams(layer->texture->getOriginalSize(),
                                &frame_count, &frame_length_ms, NULL);
-               tile->animation_frame_count = frame_count;
-               tile->animation_frame_length_ms = frame_length_ms;
+               layer->animation_frame_count = frame_count;
+               layer->animation_frame_length_ms = frame_length_ms;
        }
 
        if (frame_count == 1) {
-               tile->material_flags &= ~MATERIAL_FLAG_ANIMATION;
+               layer->material_flags &= ~MATERIAL_FLAG_ANIMATION;
        } else {
                std::ostringstream os(std::ios::binary);
-               if (!tile->frames) {
-                       tile->frames = std::make_shared<std::vector<FrameSpec>>();
+               if (!layer->frames) {
+                       layer->frames = new std::vector<FrameSpec>();
                }
-               tile->frames->resize(frame_count);
+               layer->frames->resize(frame_count);
 
                for (int i = 0; i < frame_count; i++) {
 
                        FrameSpec frame;
 
                        os.str("");
-                       os << tiledef->name;
-                       tiledef->animation.getTextureModifer(os,
-                                       tile->texture->getOriginalSize(), i);
+                       os << tiledef.name;
+                       tiledef.animation.getTextureModifer(os,
+                                       layer->texture->getOriginalSize(), i);
 
                        frame.texture = tsrc->getTextureForMesh(os.str(), &frame.texture_id);
-                       if (tile->normal_texture)
+                       if (layer->normal_texture)
                                frame.normal_texture = tsrc->getNormalTexture(os.str());
-                       frame.flags_texture = tile->flags_texture;
-                       (*tile->frames)[i] = frame;
+                       frame.flags_texture = layer->flags_texture;
+                       (*layer->frames)[i] = frame;
                }
        }
 }
 #endif
 
 #ifndef SERVER
+bool isWorldAligned(AlignStyle style, WorldAlignMode mode, NodeDrawType drawtype)
+{
+       if (style == ALIGN_STYLE_WORLD)
+               return true;
+       if (mode == WORLDALIGN_DISABLE)
+               return false;
+       if (style == ALIGN_STYLE_USER_DEFINED)
+               return true;
+       if (drawtype == NDT_NORMAL)
+               return mode >= WORLDALIGN_FORCE;
+       if (drawtype == NDT_NODEBOX)
+               return mode >= WORLDALIGN_FORCE_NODEBOX;
+       return false;
+}
+
 void ContentFeatures::updateTextures(ITextureSource *tsrc, IShaderSource *shdsrc,
        scene::IMeshManipulator *meshmanip, Client *client, const TextureSettings &tsettings)
 {
@@ -717,6 +819,8 @@ void ContentFeatures::updateTextures(ITextureSource *tsrc, IShaderSource *shdsrc
                        material_type = TILE_MATERIAL_WAVING_PLANTS;
                else if (waving == 2)
                        material_type = TILE_MATERIAL_WAVING_LEAVES;
+               else if (waving == 3)
+                       material_type = TILE_MATERIAL_WAVING_LIQUID_BASIC;
                break;
        case NDT_TORCHLIKE:
        case NDT_SIGNLIKE:
@@ -734,8 +838,14 @@ void ContentFeatures::updateTextures(ITextureSource *tsrc, IShaderSource *shdsrc
                correctAlpha(tdef, 6);
                correctAlpha(tdef_overlay, 6);
                correctAlpha(tdef_spec, CF_SPECIAL_COUNT);
-               material_type = (alpha == 255) ?
-                       TILE_MATERIAL_LIQUID_OPAQUE : TILE_MATERIAL_LIQUID_TRANSPARENT;
+
+               if (waving == 3) {
+                       material_type = (alpha == 255) ? TILE_MATERIAL_WAVING_LIQUID_OPAQUE :
+                               TILE_MATERIAL_WAVING_LIQUID_TRANSPARENT;
+               } else {
+                       material_type = (alpha == 255) ? TILE_MATERIAL_LIQUID_OPAQUE :
+                               TILE_MATERIAL_LIQUID_TRANSPARENT;
+               }
        }
 
        u32 tile_shader = shdsrc->getShader("nodes_shader", material_type, drawtype);
@@ -750,13 +860,15 @@ void ContentFeatures::updateTextures(ITextureSource *tsrc, IShaderSource *shdsrc
 
        // Tiles (fill in f->tiles[])
        for (u16 j = 0; j < 6; j++) {
-               fillTileAttribs(tsrc, &tiles[j].layers[0], &tdef[j], tile_shader,
-                       tsettings.use_normal_texture,
-                       tdef[j].backface_culling, material_type);
+               tiles[j].world_aligned = isWorldAligned(tdef[j].align_style,
+                               tsettings.world_aligned_mode, drawtype);
+               fillTileAttribs(tsrc, &tiles[j].layers[0], tiles[j], tdef[j],
+                               color, material_type, tile_shader,
+                               tdef[j].backface_culling, tsettings);
                if (!tdef_overlay[j].name.empty())
-                       fillTileAttribs(tsrc, &tiles[j].layers[1], &tdef_overlay[j],
-                               overlay_shader, tsettings.use_normal_texture,
-                               tdef[j].backface_culling, overlay_material);
+                       fillTileAttribs(tsrc, &tiles[j].layers[1], tiles[j], tdef_overlay[j],
+                                       color, overlay_material, overlay_shader,
+                                       tdef[j].backface_culling, tsettings);
        }
 
        u8 special_material = material_type;
@@ -769,11 +881,10 @@ void ContentFeatures::updateTextures(ITextureSource *tsrc, IShaderSource *shdsrc
        u32 special_shader = shdsrc->getShader("nodes_shader", special_material, drawtype);
 
        // Special tiles (fill in f->special_tiles[])
-       for (u16 j = 0; j < CF_SPECIAL_COUNT; j++) {
-               fillTileAttribs(tsrc, &special_tiles[j].layers[0], &tdef_spec[j],
-                       special_shader, tsettings.use_normal_texture,
-                       tdef_spec[j].backface_culling, special_material);
-       }
+       for (u16 j = 0; j < CF_SPECIAL_COUNT; j++)
+               fillTileAttribs(tsrc, &special_tiles[j].layers[0], special_tiles[j], tdef_spec[j],
+                               color, special_material, special_shader,
+                               tdef_spec[j].backface_culling, tsettings);
 
        if (param_type_2 == CPT2_COLOR ||
                        param_type_2 == CPT2_COLORED_FACEDIR ||
@@ -790,18 +901,6 @@ void ContentFeatures::updateTextures(ITextureSource *tsrc, IShaderSource *shdsrc
                        recalculateBoundingBox(mesh_ptr[0]);
                        meshmanip->recalculateNormals(mesh_ptr[0], true, false);
                }
-       } else if ((drawtype == NDT_NODEBOX) &&
-                       ((node_box.type == NODEBOX_REGULAR) ||
-                       (node_box.type == NODEBOX_FIXED)) &&
-                       (!node_box.fixed.empty())) {
-               //Convert regular nodebox nodes to meshnodes
-               //Change the drawtype and apply scale
-               drawtype = NDT_MESH;
-               mesh_ptr[0] = convertNodeboxesToMesh(node_box.fixed);
-               v3f scale = v3f(1.0, 1.0, 1.0) * visual_scale;
-               scaleMesh(mesh_ptr[0], scale);
-               recalculateBoundingBox(mesh_ptr[0]);
-               meshmanip->recalculateNormals(mesh_ptr[0], true, false);
        }
 
        //Cache 6dfacedir and wallmounted rotated clones of meshes
@@ -832,97 +931,19 @@ void ContentFeatures::updateTextures(ITextureSource *tsrc, IShaderSource *shdsrc
 #endif
 
 /*
-       CNodeDefManager
+       NodeDefManager
 */
 
-class CNodeDefManager: public IWritableNodeDefManager {
-public:
-       CNodeDefManager();
-       virtual ~CNodeDefManager();
-       void clear();
-
-       inline virtual const ContentFeatures& get(content_t c) const;
-       inline virtual const ContentFeatures& get(const MapNode &n) const;
-       virtual bool getId(const std::string &name, content_t &result) const;
-       virtual content_t getId(const std::string &name) const;
-       virtual bool getIds(const std::string &name, std::set<content_t> &result) const;
-       virtual const ContentFeatures& get(const std::string &name) const;
-       content_t allocateId();
-       virtual content_t set(const std::string &name, const ContentFeatures &def);
-       virtual content_t allocateDummy(const std::string &name);
-       virtual void removeNode(const std::string &name);
-       virtual void updateAliases(IItemDefManager *idef);
-       virtual void applyTextureOverrides(const std::string &override_filepath);
-       virtual void updateTextures(IGameDef *gamedef,
-               void (*progress_cbk)(void *progress_args, u32 progress, u32 max_progress),
-               void *progress_cbk_args);
-       void serialize(std::ostream &os, u16 protocol_version) const;
-       void deSerialize(std::istream &is);
-
-       inline virtual void setNodeRegistrationStatus(bool completed);
-
-       virtual void pendNodeResolve(NodeResolver *nr);
-       virtual bool cancelNodeResolveCallback(NodeResolver *nr);
-       virtual void runNodeResolveCallbacks();
-       virtual void resetNodeResolveState();
-       virtual void mapNodeboxConnections();
-       virtual bool nodeboxConnects(MapNode from, MapNode to, u8 connect_face);
-       virtual core::aabbox3d<s16> getSelectionBoxIntUnion() const
-       {
-               return m_selection_box_int_union;
-       }
-
-private:
-       void addNameIdMapping(content_t i, std::string name);
-       /*!
-        * Recalculates m_selection_box_int_union based on
-        * m_selection_box_union.
-        */
-       void fixSelectionBoxIntUnion();
-
-       // Features indexed by id
-       std::vector<ContentFeatures> m_content_features;
-
-       // A mapping for fast converting back and forth between names and ids
-       NameIdMapping m_name_id_mapping;
-
-       // Like m_name_id_mapping, but only from names to ids, and includes
-       // item aliases too. Updated by updateAliases()
-       // Note: Not serialized.
-
-       std::unordered_map<std::string, content_t> m_name_id_mapping_with_aliases;
-
-       // A mapping from groups to a list of content_ts (and their levels)
-       // that belong to it.  Necessary for a direct lookup in getIds().
-       // Note: Not serialized.
-       std::unordered_map<std::string, GroupItems> m_group_to_items;
 
-       // Next possibly free id
-       content_t m_next_id;
 
-       // NodeResolvers to callback once node registration has ended
-       std::vector<NodeResolver *> m_pending_resolve_callbacks;
 
-       // True when all nodes have been registered
-       bool m_node_registration_complete;
-
-       //! The union of all nodes' selection boxes.
-       aabb3f m_selection_box_union;
-       /*!
-        * The smallest box in node coordinates that
-        * contains all nodes' selection boxes.
-        */
-       core::aabbox3d<s16> m_selection_box_int_union;
-};
-
-
-CNodeDefManager::CNodeDefManager()
+NodeDefManager::NodeDefManager()
 {
        clear();
 }
 
 
-CNodeDefManager::~CNodeDefManager()
+NodeDefManager::~NodeDefManager()
 {
 #ifndef SERVER
        for (ContentFeatures &f : m_content_features) {
@@ -935,7 +956,7 @@ CNodeDefManager::~CNodeDefManager()
 }
 
 
-void CNodeDefManager::clear()
+void NodeDefManager::clear()
 {
        m_content_features.clear();
        m_name_id_mapping.clear();
@@ -1004,20 +1025,7 @@ void CNodeDefManager::clear()
 }
 
 
-inline const ContentFeatures& CNodeDefManager::get(content_t c) const
-{
-       return c < m_content_features.size()
-                       ? m_content_features[c] : m_content_features[CONTENT_UNKNOWN];
-}
-
-
-inline const ContentFeatures& CNodeDefManager::get(const MapNode &n) const
-{
-       return get(n.getContent());
-}
-
-
-bool CNodeDefManager::getId(const std::string &name, content_t &result) const
+bool NodeDefManager::getId(const std::string &name, content_t &result) const
 {
        std::unordered_map<std::string, content_t>::const_iterator
                i = m_name_id_mapping_with_aliases.find(name);
@@ -1028,7 +1036,7 @@ bool CNodeDefManager::getId(const std::string &name, content_t &result) const
 }
 
 
-content_t CNodeDefManager::getId(const std::string &name) const
+content_t NodeDefManager::getId(const std::string &name) const
 {
        content_t id = CONTENT_IGNORE;
        getId(name, id);
@@ -1036,35 +1044,32 @@ content_t CNodeDefManager::getId(const std::string &name) const
 }
 
 
-bool CNodeDefManager::getIds(const std::string &name,
-               std::set<content_t> &result) const
+bool NodeDefManager::getIds(const std::string &name,
+               std::vector<content_t> &result) const
 {
        //TimeTaker t("getIds", NULL, PRECISION_MICRO);
        if (name.substr(0,6) != "group:") {
                content_t id = CONTENT_IGNORE;
                bool exists = getId(name, id);
                if (exists)
-                       result.insert(id);
+                       result.push_back(id);
                return exists;
        }
        std::string group = name.substr(6);
 
-       std::unordered_map<std::string, GroupItems>::const_iterator
+       std::unordered_map<std::string, std::vector<content_t>>::const_iterator
                i = m_group_to_items.find(group);
        if (i == m_group_to_items.end())
                return true;
 
-       const GroupItems &items = i->second;
-       for (const auto &item : items) {
-               if (item.second != 0)
-                       result.insert(item.first);
-       }
+       const std::vector<content_t> &items = i->second;
+       result.insert(result.end(), items.begin(), items.end());
        //printf("getIds: %dus\n", t.stop());
        return true;
 }
 
 
-const ContentFeatures& CNodeDefManager::get(const std::string &name) const
+const ContentFeatures& NodeDefManager::get(const std::string &name) const
 {
        content_t id = CONTENT_UNKNOWN;
        getId(name, id);
@@ -1073,7 +1078,7 @@ const ContentFeatures& CNodeDefManager::get(const std::string &name) const
 
 
 // returns CONTENT_IGNORE if no free ID found
-content_t CNodeDefManager::allocateId()
+content_t NodeDefManager::allocateId()
 {
        for (content_t id = m_next_id;
                        id >= m_next_id; // overflow?
@@ -1175,13 +1180,21 @@ void getNodeBoxUnion(const NodeBox &nodebox, const ContentFeatures &features,
                }
                case NODEBOX_CONNECTED: {
                        // Add all possible connected boxes
-                       boxVectorUnion(nodebox.fixed,          box_union);
-                       boxVectorUnion(nodebox.connect_top,    box_union);
-                       boxVectorUnion(nodebox.connect_bottom, box_union);
-                       boxVectorUnion(nodebox.connect_front,  box_union);
-                       boxVectorUnion(nodebox.connect_left,   box_union);
-                       boxVectorUnion(nodebox.connect_back,   box_union);
-                       boxVectorUnion(nodebox.connect_right,  box_union);
+                       boxVectorUnion(nodebox.fixed,               box_union);
+                       boxVectorUnion(nodebox.connect_top,         box_union);
+                       boxVectorUnion(nodebox.connect_bottom,      box_union);
+                       boxVectorUnion(nodebox.connect_front,       box_union);
+                       boxVectorUnion(nodebox.connect_left,        box_union);
+                       boxVectorUnion(nodebox.connect_back,        box_union);
+                       boxVectorUnion(nodebox.connect_right,       box_union);
+                       boxVectorUnion(nodebox.disconnected_top,    box_union);
+                       boxVectorUnion(nodebox.disconnected_bottom, box_union);
+                       boxVectorUnion(nodebox.disconnected_front,  box_union);
+                       boxVectorUnion(nodebox.disconnected_left,   box_union);
+                       boxVectorUnion(nodebox.disconnected_back,   box_union);
+                       boxVectorUnion(nodebox.disconnected_right,  box_union);
+                       boxVectorUnion(nodebox.disconnected,        box_union);
+                       boxVectorUnion(nodebox.disconnected_sides,  box_union);
                        break;
                }
                default: {
@@ -1193,7 +1206,7 @@ void getNodeBoxUnion(const NodeBox &nodebox, const ContentFeatures &features,
 }
 
 
-inline void CNodeDefManager::fixSelectionBoxIntUnion()
+inline void NodeDefManager::fixSelectionBoxIntUnion()
 {
        m_selection_box_int_union.MinEdge.X = floorf(
                m_selection_box_union.MinEdge.X / BS + 0.5f);
@@ -1210,22 +1223,52 @@ inline void CNodeDefManager::fixSelectionBoxIntUnion()
 }
 
 
+void NodeDefManager::eraseIdFromGroups(content_t id)
+{
+       // For all groups in m_group_to_items...
+       for (auto iter_groups = m_group_to_items.begin();
+                       iter_groups != m_group_to_items.end();) {
+               // Get the group items vector.
+               std::vector<content_t> &items = iter_groups->second;
+
+               // Remove any occurence of the id in the group items vector.
+               items.erase(std::remove(items.begin(), items.end(), id), items.end());
+
+               // If group is empty, erase its vector from the map.
+               if (items.empty())
+                       iter_groups = m_group_to_items.erase(iter_groups);
+               else
+                       ++iter_groups;
+       }
+}
+
+
 // IWritableNodeDefManager
-content_t CNodeDefManager::set(const std::string &name, const ContentFeatures &def)
+content_t NodeDefManager::set(const std::string &name, const ContentFeatures &d)
 {
+       ContentFeatures def = d;
+       
        // Pre-conditions
        assert(name != "");
+       assert(name != "ignore");
        assert(name == def.name);
 
-       // Don't allow redefining ignore (but allow air and unknown)
-       if (name == "ignore") {
-               warningstream << "NodeDefManager: Ignoring "
-                       "CONTENT_IGNORE redefinition"<<std::endl;
-               return CONTENT_IGNORE;
-       }
-
        content_t id = CONTENT_IGNORE;
-       if (!m_name_id_mapping.getId(name, id)) { // ignore aliases
+       
+       if (m_name_id_mapping.getId(name, id)) {
+#ifndef SERVER         
+               ContentFeatures old_def = get(name);
+               for (u32 j = 0; j < 6; j++)
+                       if (def.tiledef[j].name.empty())
+                               def.tiledef[j] = old_def.tiledef[j];
+               for (u32 j = 0; j < 6; j++)
+                       if (def.tiledef_overlay[j].name.empty())
+                               def.tiledef_overlay[j] = old_def.tiledef_overlay[j];
+               for (u32 j = 0; j < CF_SPECIAL_COUNT; j++)
+                       if (def.tiledef_special[j].name.empty())
+                               def.tiledef_special[j] = old_def.tiledef_special[j];
+#endif
+       } else {
                // Get new id
                id = allocateId();
                if (id == CONTENT_IGNORE) {
@@ -1236,32 +1279,29 @@ content_t CNodeDefManager::set(const std::string &name, const ContentFeatures &d
                assert(id != CONTENT_IGNORE);
                addNameIdMapping(id, name);
        }
+
+       // If there is already ContentFeatures registered for this id, clear old groups
+       if (id < m_content_features.size())
+               eraseIdFromGroups(id);
+
        m_content_features[id] = def;
        verbosestream << "NodeDefManager: registering content id \"" << id
                << "\": name=\"" << def.name << "\""<<std::endl;
 
        getNodeBoxUnion(def.selection_box, def, &m_selection_box_union);
        fixSelectionBoxIntUnion();
+
        // Add this content to the list of all groups it belongs to
-       // FIXME: This should remove a node from groups it no longer
-       // belongs to when a node is re-registered
        for (const auto &group : def.groups) {
                const std::string &group_name = group.first;
-
-               std::unordered_map<std::string, GroupItems>::iterator
-                       j = m_group_to_items.find(group_name);
-               if (j == m_group_to_items.end()) {
-                       m_group_to_items[group_name].emplace_back(id, group.second);
-               } else {
-                       GroupItems &items = j->second;
-                       items.emplace_back(id, group.second);
-               }
+               m_group_to_items[group_name].push_back(id);
        }
+
        return id;
 }
 
 
-content_t CNodeDefManager::allocateDummy(const std::string &name)
+content_t NodeDefManager::allocateDummy(const std::string &name)
 {
        assert(name != "");     // Pre-condition
        ContentFeatures f;
@@ -1270,7 +1310,7 @@ content_t CNodeDefManager::allocateDummy(const std::string &name)
 }
 
 
-void CNodeDefManager::removeNode(const std::string &name)
+void NodeDefManager::removeNode(const std::string &name)
 {
        // Pre-condition
        assert(name != "");
@@ -1282,28 +1322,11 @@ void CNodeDefManager::removeNode(const std::string &name)
                m_name_id_mapping_with_aliases.erase(name);
        }
 
-       // Erase node content from all groups it belongs to
-       for (std::unordered_map<std::string, GroupItems>::iterator iter_groups =
-                       m_group_to_items.begin(); iter_groups != m_group_to_items.end();) {
-               GroupItems &items = iter_groups->second;
-               for (GroupItems::iterator iter_groupitems = items.begin();
-                               iter_groupitems != items.end();) {
-                       if (iter_groupitems->first == id)
-                               items.erase(iter_groupitems++);
-                       else
-                               ++iter_groupitems;
-               }
-
-               // Check if group is empty
-               if (items.empty())
-                       m_group_to_items.erase(iter_groups++);
-               else
-                       ++iter_groups;
-       }
+       eraseIdFromGroups(id);
 }
 
 
-void CNodeDefManager::updateAliases(IItemDefManager *idef)
+void NodeDefManager::updateAliases(IItemDefManager *idef)
 {
        std::set<std::string> all;
        idef->getAll(all);
@@ -1318,66 +1341,44 @@ void CNodeDefManager::updateAliases(IItemDefManager *idef)
        }
 }
 
-void CNodeDefManager::applyTextureOverrides(const std::string &override_filepath)
+void NodeDefManager::applyTextureOverrides(const std::vector<TextureOverride> &overrides)
 {
-       infostream << "CNodeDefManager::applyTextureOverrides(): Applying "
-               "overrides to textures from " << override_filepath << std::endl;
-
-       std::ifstream infile(override_filepath.c_str());
-       std::string line;
-       int line_c = 0;
-       while (std::getline(infile, line)) {
-               line_c++;
-               if (trim(line).empty())
-                       continue;
-               std::vector<std::string> splitted = str_split(line, ' ');
-               if (splitted.size() != 3) {
-                       errorstream << override_filepath
-                               << ":" << line_c << " Could not apply texture override \""
-                               << line << "\": Syntax error" << std::endl;
-                       continue;
-               }
+       infostream << "NodeDefManager::applyTextureOverrides(): Applying "
+               "overrides to textures" << std::endl;
 
+       for (const TextureOverride& texture_override : overrides) {
                content_t id;
-               if (!getId(splitted[0], id))
+               if (!getId(texture_override.id, id))
                        continue; // Ignore unknown node
 
                ContentFeatures &nodedef = m_content_features[id];
 
-               if (splitted[1] == "top")
-                       nodedef.tiledef[0].name = splitted[2];
-               else if (splitted[1] == "bottom")
-                       nodedef.tiledef[1].name = splitted[2];
-               else if (splitted[1] == "right")
-                       nodedef.tiledef[2].name = splitted[2];
-               else if (splitted[1] == "left")
-                       nodedef.tiledef[3].name = splitted[2];
-               else if (splitted[1] == "back")
-                       nodedef.tiledef[4].name = splitted[2];
-               else if (splitted[1] == "front")
-                       nodedef.tiledef[5].name = splitted[2];
-               else if (splitted[1] == "all" || splitted[1] == "*")
-                       for (TileDef &i : nodedef.tiledef)
-                               i.name = splitted[2];
-               else if (splitted[1] == "sides")
-                       for (int i = 2; i < 6; i++)
-                               nodedef.tiledef[i].name = splitted[2];
-               else {
-                       errorstream << override_filepath
-                               << ":" << line_c << " Could not apply texture override \""
-                               << line << "\": Unknown node side \""
-                               << splitted[1] << "\"" << std::endl;
-                       continue;
-               }
+               if (texture_override.hasTarget(OverrideTarget::TOP))
+                       nodedef.tiledef[0].name = texture_override.texture;
+
+               if (texture_override.hasTarget(OverrideTarget::BOTTOM))
+                       nodedef.tiledef[1].name = texture_override.texture;
+
+               if (texture_override.hasTarget(OverrideTarget::RIGHT))
+                       nodedef.tiledef[2].name = texture_override.texture;
+
+               if (texture_override.hasTarget(OverrideTarget::LEFT))
+                       nodedef.tiledef[3].name = texture_override.texture;
+
+               if (texture_override.hasTarget(OverrideTarget::BACK))
+                       nodedef.tiledef[4].name = texture_override.texture;
+
+               if (texture_override.hasTarget(OverrideTarget::FRONT))
+                       nodedef.tiledef[5].name = texture_override.texture;
        }
 }
 
-void CNodeDefManager::updateTextures(IGameDef *gamedef,
+void NodeDefManager::updateTextures(IGameDef *gamedef,
        void (*progress_callback)(void *progress_args, u32 progress, u32 max_progress),
        void *progress_callback_args)
 {
 #ifndef SERVER
-       infostream << "CNodeDefManager::updateTextures(): Updating "
+       infostream << "NodeDefManager::updateTextures(): Updating "
                "textures in node definitions" << std::endl;
 
        Client *client = (Client *)gamedef;
@@ -1398,7 +1399,7 @@ void CNodeDefManager::updateTextures(IGameDef *gamedef,
 #endif
 }
 
-void CNodeDefManager::serialize(std::ostream &os, u16 protocol_version) const
+void NodeDefManager::serialize(std::ostream &os, u16 protocol_version) const
 {
        writeU8(os, 1); // version
        u16 count = 0;
@@ -1427,7 +1428,7 @@ void CNodeDefManager::serialize(std::ostream &os, u16 protocol_version) const
 }
 
 
-void CNodeDefManager::deSerialize(std::istream &is)
+void NodeDefManager::deSerialize(std::istream &is)
 {
        clear();
        int version = readU8(is);
@@ -1469,33 +1470,32 @@ void CNodeDefManager::deSerialize(std::istream &is)
                        m_content_features.resize((u32)(i) + 1);
                m_content_features[i] = f;
                addNameIdMapping(i, f.name);
-               verbosestream << "deserialized " << f.name << std::endl;
+               TRACESTREAM(<< "NodeDef: deserialized " << f.name << std::endl);
 
                getNodeBoxUnion(f.selection_box, f, &m_selection_box_union);
                fixSelectionBoxIntUnion();
        }
+
+       // Since liquid_alternative_flowing_id and liquid_alternative_source_id
+       // are not sent, resolve them client-side too.
+       resolveCrossrefs();
 }
 
 
-void CNodeDefManager::addNameIdMapping(content_t i, std::string name)
+void NodeDefManager::addNameIdMapping(content_t i, std::string name)
 {
        m_name_id_mapping.set(i, name);
        m_name_id_mapping_with_aliases.insert(std::make_pair(name, i));
 }
 
 
-IWritableNodeDefManager *createNodeDefManager()
+NodeDefManager *createNodeDefManager()
 {
-       return new CNodeDefManager();
+       return new NodeDefManager();
 }
 
-inline void CNodeDefManager::setNodeRegistrationStatus(bool completed)
-{
-       m_node_registration_complete = completed;
-}
 
-
-void CNodeDefManager::pendNodeResolve(NodeResolver *nr)
+void NodeDefManager::pendNodeResolve(NodeResolver *nr) const
 {
        nr->m_ndef = this;
        if (m_node_registration_complete)
@@ -1505,7 +1505,7 @@ void CNodeDefManager::pendNodeResolve(NodeResolver *nr)
 }
 
 
-bool CNodeDefManager::cancelNodeResolveCallback(NodeResolver *nr)
+bool NodeDefManager::cancelNodeResolveCallback(NodeResolver *nr) const
 {
        size_t len = m_pending_resolve_callbacks.size();
        for (size_t i = 0; i != len; i++) {
@@ -1522,7 +1522,7 @@ bool CNodeDefManager::cancelNodeResolveCallback(NodeResolver *nr)
 }
 
 
-void CNodeDefManager::runNodeResolveCallbacks()
+void NodeDefManager::runNodeResolveCallbacks()
 {
        for (size_t i = 0; i != m_pending_resolve_callbacks.size(); i++) {
                NodeResolver *nr = m_pending_resolve_callbacks[i];
@@ -1533,26 +1533,39 @@ void CNodeDefManager::runNodeResolveCallbacks()
 }
 
 
-void CNodeDefManager::resetNodeResolveState()
+void NodeDefManager::resetNodeResolveState()
 {
        m_node_registration_complete = false;
        m_pending_resolve_callbacks.clear();
 }
 
-void CNodeDefManager::mapNodeboxConnections()
+static void removeDupes(std::vector<content_t> &list)
+{
+       std::sort(list.begin(), list.end());
+       auto new_end = std::unique(list.begin(), list.end());
+       list.erase(new_end, list.end());
+}
+
+void NodeDefManager::resolveCrossrefs()
 {
        for (ContentFeatures &f : m_content_features) {
+               if (f.liquid_type != LIQUID_NONE) {
+                       f.liquid_alternative_flowing_id = getId(f.liquid_alternative_flowing);
+                       f.liquid_alternative_source_id = getId(f.liquid_alternative_source);
+                       continue;
+               }
                if (f.drawtype != NDT_NODEBOX || f.node_box.type != NODEBOX_CONNECTED)
                        continue;
 
-               for (std::vector<std::string>::const_iterator it = f.connects_to.begin();
-                               it != f.connects_to.end(); ++it) {
-                       getIds(*it, f.connects_to_ids);
+               for (const std::string &name : f.connects_to) {
+                       getIds(name, f.connects_to_ids);
                }
+               removeDupes(f.connects_to_ids);
        }
 }
 
-bool CNodeDefManager::nodeboxConnects(MapNode from, MapNode to, u8 connect_face)
+bool NodeDefManager::nodeboxConnects(MapNode from, MapNode to,
+       u8 connect_face) const
 {
        const ContentFeatures &f1 = get(from);
 
@@ -1560,14 +1573,14 @@ bool CNodeDefManager::nodeboxConnects(MapNode from, MapNode to, u8 connect_face)
                return false;
 
        // lookup target in connected set
-       if (f1.connects_to_ids.find(to.param0) == f1.connects_to_ids.end())
+       if (!CONTAINS(f1.connects_to_ids, to.param0))
                return false;
 
        const ContentFeatures &f2 = get(to);
 
        if ((f2.drawtype == NDT_NODEBOX) && (f2.node_box.type == NODEBOX_CONNECTED))
                // ignores actually looking if back connection exists
-               return (f2.connects_to_ids.find(from.param0) != f2.connects_to_ids.end());
+               return CONTAINS(f2.connects_to_ids, from.param0);
 
        // does to node declare usable faces?
        if (f2.connect_sides > 0) {
@@ -1613,6 +1626,18 @@ NodeResolver::~NodeResolver()
 }
 
 
+void NodeResolver::cloneTo(NodeResolver *res) const
+{
+       FATAL_ERROR_IF(!m_resolve_done, "NodeResolver can only be cloned"
+               " after resolving has completed");
+       /* We don't actually do anything significant. Since the node resolving has
+        * already completed, the class that called us will already have the
+        * resolved IDs in its data structures (which it copies on its own) */
+       res->m_ndef = m_ndef;
+       res->m_resolve_done = true;
+}
+
+
 void NodeResolver::nodeResolveInternal()
 {
        m_nodenames_idx   = 0;
@@ -1627,7 +1652,7 @@ void NodeResolver::nodeResolveInternal()
 
 
 bool NodeResolver::getIdFromNrBacklog(content_t *result_out,
-       const std::string &node_alt, content_t c_fallback)
+       const std::string &node_alt, content_t c_fallback, bool error_on_fallback)
 {
        if (m_nodenames_idx == m_nodenames.size()) {
                *result_out = c_fallback;
@@ -1645,8 +1670,9 @@ bool NodeResolver::getIdFromNrBacklog(content_t *result_out,
        }
 
        if (!success) {
-               errorstream << "NodeResolver: failed to resolve node name '" << name
-                       << "'." << std::endl;
+               if (error_on_fallback)
+                       errorstream << "NodeResolver: failed to resolve node name '" << name
+                               << "'." << std::endl;
                c = c_fallback;
        }
 
@@ -1686,11 +1712,7 @@ bool NodeResolver::getIdsFromNrBacklog(std::vector<content_t> *result_out,
                                success = false;
                        }
                } else {
-                       std::set<content_t> cids;
-                       std::set<content_t>::iterator it;
-                       m_ndef->getIds(name, cids);
-                       for (it = cids.begin(); it != cids.end(); ++it)
-                               result_out->push_back(*it);
+                       m_ndef->getIds(name, *result_out);
                }
        }