]> git.lizzy.rs Git - dragonfireclient.git/blobdiff - src/nodedef.cpp
Pass ContentFeatures as reference to read_content_features (#10464)
[dragonfireclient.git] / src / nodedef.cpp
index cb841e544732ca4c3f600d2802477665e25453b9..3a5934cf3ac448dce0b76dffffe3337202f74638 100644 (file)
@@ -207,7 +207,7 @@ void TileDef::serialize(std::ostream &os, u16 protocol_version) const
        u8 version = 6;
        writeU8(os, version);
 
-       os << serializeString(name);
+       os << serializeString16(name);
        animation.serialize(os, version);
        bool has_scale = scale > 0;
        u16 flags = 0;
@@ -241,7 +241,7 @@ void TileDef::deSerialize(std::istream &is, u8 contentfeatures_version,
        int version = readU8(is);
        if (version < 6)
                throw SerializationError("unsupported TileDef version");
-       name = deSerializeString(is);
+       name = deSerializeString16(is);
        animation.deSerialize(is, version);
        u16 flags = readU16(is);
        backface_culling = flags & TILE_FLAG_BACKFACE_CULLING;
@@ -317,6 +317,18 @@ ContentFeatures::ContentFeatures()
        reset();
 }
 
+ContentFeatures::~ContentFeatures()
+{
+#ifndef SERVER
+       for (u16 j = 0; j < 6; j++) {
+               delete tiles[j].layers[0].frames;
+               delete tiles[j].layers[1].frames;
+       }
+       for (u16 j = 0; j < CF_SPECIAL_COUNT; j++)
+               delete special_tiles[j].layers[0].frames;
+#endif
+}
+
 void ContentFeatures::reset()
 {
        /*
@@ -404,10 +416,10 @@ void ContentFeatures::serialize(std::ostream &os, u16 protocol_version) const
        writeU8(os, version);
 
        // general
-       os << serializeString(name);
+       os << serializeString16(name);
        writeU16(os, groups.size());
        for (const auto &group : groups) {
-               os << serializeString(group.first);
+               os << serializeString16(group.first);
                writeS16(os, group.second);
        }
        writeU8(os, param_type);
@@ -415,7 +427,7 @@ void ContentFeatures::serialize(std::ostream &os, u16 protocol_version) const
 
        // visual
        writeU8(os, drawtype);
-       os << serializeString(mesh);
+       os << serializeString16(mesh);
        writeF32(os, visual_scale);
        writeU8(os, 6);
        for (const TileDef &td : tiledef)
@@ -430,7 +442,7 @@ void ContentFeatures::serialize(std::ostream &os, u16 protocol_version) const
        writeU8(os, color.getRed());
        writeU8(os, color.getGreen());
        writeU8(os, color.getBlue());
-       os << serializeString(palette_name);
+       os << serializeString16(palette_name);
        writeU8(os, waving);
        writeU8(os, connect_sides);
        writeU16(os, connects_to_ids.size());
@@ -458,8 +470,8 @@ void ContentFeatures::serialize(std::ostream &os, u16 protocol_version) const
 
        // liquid
        writeU8(os, liquid_type);
-       os << serializeString(liquid_alternative_flowing);
-       os << serializeString(liquid_alternative_source);
+       os << serializeString16(liquid_alternative_flowing);
+       os << serializeString16(liquid_alternative_source);
        writeU8(os, liquid_viscosity);
        writeU8(os, liquid_renewable);
        writeU8(os, liquid_range);
@@ -480,7 +492,7 @@ void ContentFeatures::serialize(std::ostream &os, u16 protocol_version) const
        writeU8(os, legacy_facedir_simple);
        writeU8(os, legacy_wallmounted);
 
-       os << serializeString(node_dig_prediction);
+       os << serializeString16(node_dig_prediction);
        writeU8(os, leveled_max);
 }
 
@@ -507,11 +519,11 @@ void ContentFeatures::deSerialize(std::istream &is)
                throw SerializationError("unsupported ContentFeatures version");
 
        // general
-       name = deSerializeString(is);
+       name = deSerializeString16(is);
        groups.clear();
        u32 groups_size = readU16(is);
        for (u32 i = 0; i < groups_size; i++) {
-               std::string name = deSerializeString(is);
+               std::string name = deSerializeString16(is);
                int value = readS16(is);
                groups[name] = value;
        }
@@ -520,7 +532,7 @@ void ContentFeatures::deSerialize(std::istream &is)
 
        // visual
        drawtype = (enum NodeDrawType) readU8(is);
-       mesh = deSerializeString(is);
+       mesh = deSerializeString16(is);
        visual_scale = readF32(is);
        if (readU8(is) != 6)
                throw SerializationError("unsupported tile count");
@@ -536,7 +548,7 @@ void ContentFeatures::deSerialize(std::istream &is)
        color.setRed(readU8(is));
        color.setGreen(readU8(is));
        color.setBlue(readU8(is));
-       palette_name = deSerializeString(is);
+       palette_name = deSerializeString16(is);
        waving = readU8(is);
        connect_sides = readU8(is);
        u16 connects_to_size = readU16(is);
@@ -566,8 +578,8 @@ void ContentFeatures::deSerialize(std::istream &is)
 
        // liquid
        liquid_type = (enum LiquidType) readU8(is);
-       liquid_alternative_flowing = deSerializeString(is);
-       liquid_alternative_source = deSerializeString(is);
+       liquid_alternative_flowing = deSerializeString16(is);
+       liquid_alternative_source = deSerializeString16(is);
        liquid_viscosity = readU8(is);
        liquid_renewable = readU8(is);
        liquid_range = readU8(is);
@@ -589,7 +601,7 @@ void ContentFeatures::deSerialize(std::istream &is)
        legacy_wallmounted = readU8(is);
 
        try {
-               node_dig_prediction = deSerializeString(is);
+               node_dig_prediction = deSerializeString16(is);
                u8 tmp_leveled_max = readU8(is);
                if (is.eof()) /* readU8 doesn't throw exceptions so we have to do this */
                        throw SerializationError("");
@@ -608,8 +620,9 @@ static void fillTileAttribs(ITextureSource *tsrc, TileLayer *layer,
        layer->material_type = material_type;
 
        bool has_scale = tiledef.scale > 0;
-       if (((tsettings.autoscale_mode == AUTOSCALE_ENABLE) && !has_scale) ||
-                       (tsettings.autoscale_mode == AUTOSCALE_FORCE)) {
+       bool use_autoscale = tsettings.autoscale_mode == AUTOSCALE_FORCE ||
+               (tsettings.autoscale_mode == AUTOSCALE_ENABLE && !has_scale);
+       if (use_autoscale && layer->texture) {
                auto texture_size = layer->texture->getOriginalSize();
                float base_size = tsettings.node_texture_size;
                float size = std::fmin(texture_size.Width, texture_size.Height);
@@ -661,7 +674,7 @@ static void fillTileAttribs(ITextureSource *tsrc, TileLayer *layer,
        } else {
                std::ostringstream os(std::ios::binary);
                if (!layer->frames) {
-                       layer->frames = std::make_shared<std::vector<FrameSpec>>();
+                       layer->frames = new std::vector<FrameSpec>();
                }
                layer->frames->resize(frame_count);
 
@@ -682,9 +695,54 @@ static void fillTileAttribs(ITextureSource *tsrc, TileLayer *layer,
                }
        }
 }
-#endif
 
-#ifndef SERVER
+bool ContentFeatures::textureAlphaCheck(ITextureSource *tsrc, const TileDef *tiles, int length)
+{
+       video::IVideoDriver *driver = RenderingEngine::get_video_driver();
+       static thread_local bool long_warning_printed = false;
+       std::set<std::string> seen;
+       for (int i = 0; i < length; i++) {
+               if (seen.find(tiles[i].name) != seen.end())
+                       continue;
+               seen.insert(tiles[i].name);
+
+               // Load the texture and see if there's any transparent pixels
+               video::ITexture *texture = tsrc->getTexture(tiles[i].name);
+               video::IImage *image = driver->createImage(texture,
+                       core::position2d<s32>(0, 0), texture->getOriginalSize());
+               if (!image)
+                       continue;
+               core::dimension2d<u32> dim = image->getDimension();
+               bool ok = true;
+               for (u16 x = 0; x < dim.Width; x++) {
+                       for (u16 y = 0; y < dim.Height; y++) {
+                               if (image->getPixel(x, y).getAlpha() < 255) {
+                                       ok = false;
+                                       goto break_loop;
+                               }
+                       }
+               }
+
+break_loop:
+               image->drop();
+               if (!ok) {
+                       warningstream << "Texture \"" << tiles[i].name << "\" of "
+                               << name << " has transparent pixels, assuming "
+                               "use_texture_alpha = true." << std::endl;
+                       if (!long_warning_printed) {
+                               warningstream << "  This warning can be a false-positive if "
+                                       "unused pixels in the texture are transparent. However if "
+                                       "it is meant to be transparent, you *MUST* update the "
+                                       "nodedef and set use_texture_alpha = true! This compatibility "
+                                       "code will be removed in a few releases." << std::endl;
+                               long_warning_printed = true;
+                       }
+                       return true;
+               }
+       }
+       return false;
+}
+
 bool isWorldAligned(AlignStyle style, WorldAlignMode mode, NodeDrawType drawtype)
 {
        if (style == ALIGN_STYLE_WORLD)
@@ -801,13 +859,19 @@ void ContentFeatures::updateTextures(ITextureSource *tsrc, IShaderSource *shdsrc
                break;
        case NDT_MESH:
        case NDT_NODEBOX:
+               if (alpha == 255 && textureAlphaCheck(tsrc, tdef, 6))
+                       alpha = 0;
+
                solidness = 0;
                if (waving == 1)
                        material_type = TILE_MATERIAL_WAVING_PLANTS;
                else if (waving == 2)
                        material_type = TILE_MATERIAL_WAVING_LEAVES;
                else if (waving == 3)
-                       material_type = TILE_MATERIAL_WAVING_LIQUID_BASIC;
+                       material_type = (alpha == 255) ? TILE_MATERIAL_WAVING_LIQUID_OPAQUE :
+                               TILE_MATERIAL_WAVING_LIQUID_BASIC;
+               else if (alpha == 255)
+                       material_type = TILE_MATERIAL_OPAQUE;
                break;
        case NDT_TORCHLIKE:
        case NDT_SIGNLIKE:
@@ -1324,6 +1388,7 @@ void NodeDefManager::applyTextureOverrides(const std::vector<TextureOverride> &o
 
                ContentFeatures &nodedef = m_content_features[id];
 
+               // Override tiles
                if (texture_override.hasTarget(OverrideTarget::TOP))
                        nodedef.tiledef[0].name = texture_override.texture;
 
@@ -1341,6 +1406,26 @@ void NodeDefManager::applyTextureOverrides(const std::vector<TextureOverride> &o
 
                if (texture_override.hasTarget(OverrideTarget::FRONT))
                        nodedef.tiledef[5].name = texture_override.texture;
+
+
+               // Override special tiles, if applicable
+               if (texture_override.hasTarget(OverrideTarget::SPECIAL_1))
+                       nodedef.tiledef_special[0].name = texture_override.texture;
+
+               if (texture_override.hasTarget(OverrideTarget::SPECIAL_2))
+                       nodedef.tiledef_special[1].name = texture_override.texture;
+
+               if (texture_override.hasTarget(OverrideTarget::SPECIAL_3))
+                       nodedef.tiledef_special[2].name = texture_override.texture;
+
+               if (texture_override.hasTarget(OverrideTarget::SPECIAL_4))
+                       nodedef.tiledef_special[3].name = texture_override.texture;
+
+               if (texture_override.hasTarget(OverrideTarget::SPECIAL_5))
+                       nodedef.tiledef_special[4].name = texture_override.texture;
+
+               if (texture_override.hasTarget(OverrideTarget::SPECIAL_6))
+                       nodedef.tiledef_special[5].name = texture_override.texture;
        }
 }
 
@@ -1387,7 +1472,7 @@ void NodeDefManager::serialize(std::ostream &os, u16 protocol_version) const
                // strict version incompatibilities
                std::ostringstream wrapper_os(std::ios::binary);
                f->serialize(wrapper_os, protocol_version);
-               os2<<serializeString(wrapper_os.str());
+               os2<<serializeString16(wrapper_os.str());
 
                // must not overflow
                u16 next = count + 1;
@@ -1395,7 +1480,7 @@ void NodeDefManager::serialize(std::ostream &os, u16 protocol_version) const
                count++;
        }
        writeU16(os, count);
-       os << serializeLongString(os2.str());
+       os << serializeString32(os2.str());
 }
 
 
@@ -1406,13 +1491,13 @@ void NodeDefManager::deSerialize(std::istream &is)
        if (version != 1)
                throw SerializationError("unsupported NodeDefinitionManager version");
        u16 count = readU16(is);
-       std::istringstream is2(deSerializeLongString(is), std::ios::binary);
+       std::istringstream is2(deSerializeString32(is), std::ios::binary);
        ContentFeatures f;
        for (u16 n = 0; n < count; n++) {
                u16 i = readU16(is2);
 
                // Read it from the string wrapper
-               std::string wrapper = deSerializeString(is2);
+               std::string wrapper = deSerializeString16(is2);
                std::istringstream wrapper_is(wrapper, std::ios::binary);
                f.deSerialize(wrapper_is);