Cpp11 initializers 2 (#5999)

[minetest.git] / src / network / networkpacket.cpp

diff --git a/src/network/networkpacket.cpp b/src/network/networkpacket.cpp
index 2b308f334e2f94211cd9e86d36bd833d9917724d..f7a6499ddbcbe032f4b33ddc8a9d50b75f61077e 100644 (file)
--- a/src/network/networkpacket.cpp
+++ b/src/network/networkpacket.cpp
@@ -63,7 +63,7 @@ void NetworkPacket::putRawPacket(u8 *data, u32 datasize, u16 peer_id)
        m_data = std::vector<u8>(&data[2], &data[2 + m_datasize]);
 }
 
-char* NetworkPacket::getString(u32 from_offset)
+const char* NetworkPacket::getString(u32 from_offset)
 {
        checkReadOffset(from_offset, 0);
 
@@ -77,7 +77,7 @@ void NetworkPacket::putRawString(const char* src, u32 len)
                m_data.resize(m_datasize);
        }
 
-       if (m_datasize == 0)
+       if (len == 0)
                return;
 
        memcpy(&m_data[m_read_offset], src, len);
@@ -105,7 +105,7 @@ NetworkPacket& NetworkPacket::operator>>(std::string& dst)
        return *this;
 }
 
-NetworkPacket& NetworkPacket::operator<<(std::string src)
+NetworkPacket& NetworkPacket::operator<<(const std::string &src)
 {
        u16 msgsize = src.size();
        if (msgsize > STRING_MAX_LEN) {
@@ -119,7 +119,7 @@ NetworkPacket& NetworkPacket::operator<<(std::string src)
        return *this;
 }
 
-void NetworkPacket::putLongString(std::string src)
+void NetworkPacket::putLongString(const std::string &src)
 {
        u32 msgsize = src.size();
        if (msgsize > LONG_STRING_MAX_LEN) {
@@ -155,7 +155,7 @@ NetworkPacket& NetworkPacket::operator>>(std::wstring& dst)
        return *this;
 }
 
-NetworkPacket& NetworkPacket::operator<<(std::wstring src)
+NetworkPacket& NetworkPacket::operator<<(const std::wstring &src)
 {
        u16 msgsize = src.size();
        if (msgsize > WIDE_STRING_MAX_LEN) {