use rustc_front::hir::*;
use reexport::*;
use rustc_front::util::{is_comparison_binop, binop_to_string};
-use syntax::codemap::{Span, Spanned};
+use syntax::codemap::{Span, Spanned, ExpnFormat};
use rustc_front::intravisit::FnKind;
use rustc::middle::ty;
use rustc::middle::const_eval::ConstVal::Float;
use rustc::middle::const_eval::eval_const_expr_partial;
use rustc::middle::const_eval::EvalHint::ExprTypeChecked;
-use utils::{get_item_name, match_path, snippet, get_parent_expr, span_lint, walk_ptrs_ty,
- is_integer_literal};
-use utils::span_help_and_lint;
+use utils::{get_item_name, match_path, snippet, get_parent_expr, span_lint};
+use utils::{span_help_and_lint, walk_ptrs_ty, is_integer_literal};
/// **What it does:** This lint checks for function arguments and let bindings denoted as `ref`. It is `Warn` by default.
///
impl LateLintPass for UsedUnderscoreBinding {
fn check_expr(&mut self, cx: &LateContext, expr: &Expr) {
+ if in_attributes_expansion(cx, expr) { // Don't lint things expanded by #[derive(...)], etc
+ return;
+ }
let needs_lint = match expr.node {
ExprPath(_, ref path) => {
let ident = path.segments.last()
.identifier;
ident.name.as_str().chars().next() == Some('_') //starts with '_'
&& ident.name.as_str().chars().skip(1).next() != Some('_') //doesn't start with "__"
- && ident.name != ident.unhygienic_name //not in macro
+ && ident.name != ident.unhygienic_name //not in bang macro
&& is_used(cx, expr)
},
ExprField(_, spanned) => {
}
}
+/// Heuristic to see if an expression is used. Should be compatible with `unused_variables`'s idea
+/// of what it means for an expression to be "used".
fn is_used(cx: &LateContext, expr: &Expr) -> bool {
if let Some(ref parent) = get_parent_expr(cx, expr) {
match parent.node {
true
}
}
+
+/// Test whether an expression is in a macro expansion (e.g. something generated by #[derive(...)]
+/// or the like)
+fn in_attributes_expansion(cx: &LateContext, expr: &Expr) -> bool {
+ cx.sess().codemap().with_expn_info(expr.span.expn_id, |info_opt| {
+ info_opt.map_or(false, |info| {
+ match info.callee.format {
+ ExpnFormat::MacroAttribute(_) => true,
+ _ => false,
+ }
+ })
+ })
+}