]> git.lizzy.rs Git - dragonfireclient.git/blobdiff - src/mapgen_valleys.cpp
Add on_flood() callback.
[dragonfireclient.git] / src / mapgen_valleys.cpp
index 44083d9d34af7d21c93c002c7df9e818cc46bfda..32a32eb88fd16e57819d6afd59e3d415cec66810 100644 (file)
@@ -37,7 +37,6 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "settings.h" // For g_settings
 #include "emerge.h"
 #include "dungeongen.h"
-#include "treegen.h"
 #include "mg_biome.h"
 #include "mg_ore.h"
 #include "mg_decoration.h"
@@ -64,59 +63,39 @@ static FlagDesc flagdesc_mapgen_valleys[] = {
 ///////////////////////////////////////////////////////////////////////////////
 
 
-MapgenValleys::MapgenValleys(int mapgenid, MapgenParams *params, EmergeManager *emerge)
-       : Mapgen(mapgenid, params, emerge)
+MapgenValleys::MapgenValleys(int mapgenid, MapgenValleysParams *params, EmergeManager *emerge)
+       : MapgenBasic(mapgenid, params, emerge)
 {
-       this->m_emerge = emerge;
-       this->bmgr     = emerge->biomemgr;
+       // NOTE: MapgenValleys has a hard dependency on BiomeGenOriginal
+       this->m_bgen = (BiomeGenOriginal *)biomegen;
 
-       //// amount of elements to skip for the next index
-       //// for noise/height/biome maps (not vmanip)
-       this->ystride = csize.X;
-       this->zstride = csize.X * (csize.Y + 2);
-       // 1-down overgeneration
-       this->zstride_1d = csize.X * (csize.Y + 1);
-
-       this->heightmap = new s16[csize.X * csize.Z];
-
-       this->map_gen_limit = MYMIN(MAX_MAP_GENERATION_LIMIT,
-                       g_settings->getU16("map_generation_limit"));
-
-       MapgenValleysParams *sp = (MapgenValleysParams *)params->sparams;
        BiomeParamsOriginal *bp = (BiomeParamsOriginal *)params->bparams;
 
-       this->spflags            = sp->spflags;
-       this->altitude_chill     = sp->altitude_chill;
-       this->large_cave_depth   = sp->large_cave_depth;
-       this->lava_features_lim  = rangelim(sp->lava_features, 0, 10);
-       this->massive_cave_depth = sp->massive_cave_depth;
-       this->river_depth_bed    = sp->river_depth + 1.f;
-       this->river_size_factor  = sp->river_size / 100.f;
-       this->water_features_lim = rangelim(sp->water_features, 0, 10);
-       this->cave_width         = sp->cave_width;
+       this->spflags            = params->spflags;
+       this->altitude_chill     = params->altitude_chill;
+       this->large_cave_depth   = params->large_cave_depth;
+       this->lava_features_lim  = rangelim(params->lava_features, 0, 10);
+       this->massive_cave_depth = params->massive_cave_depth;
+       this->river_depth_bed    = params->river_depth + 1.f;
+       this->river_size_factor  = params->river_size / 100.f;
+       this->water_features_lim = rangelim(params->water_features, 0, 10);
+       this->cave_width         = params->cave_width;
 
        //// 2D Terrain noise
-       noise_filler_depth       = new Noise(&sp->np_filler_depth,       seed, csize.X, csize.Z);
-       noise_inter_valley_slope = new Noise(&sp->np_inter_valley_slope, seed, csize.X, csize.Z);
-       noise_rivers             = new Noise(&sp->np_rivers,             seed, csize.X, csize.Z);
-       noise_terrain_height     = new Noise(&sp->np_terrain_height,     seed, csize.X, csize.Z);
-       noise_valley_depth       = new Noise(&sp->np_valley_depth,       seed, csize.X, csize.Z);
-       noise_valley_profile     = new Noise(&sp->np_valley_profile,     seed, csize.X, csize.Z);
+       noise_filler_depth       = new Noise(&params->np_filler_depth,       seed, csize.X, csize.Z);
+       noise_inter_valley_slope = new Noise(&params->np_inter_valley_slope, seed, csize.X, csize.Z);
+       noise_rivers             = new Noise(&params->np_rivers,             seed, csize.X, csize.Z);
+       noise_terrain_height     = new Noise(&params->np_terrain_height,     seed, csize.X, csize.Z);
+       noise_valley_depth       = new Noise(&params->np_valley_depth,       seed, csize.X, csize.Z);
+       noise_valley_profile     = new Noise(&params->np_valley_profile,     seed, csize.X, csize.Z);
 
        //// 3D Terrain noise
        // 1-up 1-down overgeneration
-       noise_inter_valley_fill = new Noise(&sp->np_inter_valley_fill, seed, csize.X, csize.Y + 2, csize.Z);
+       noise_inter_valley_fill = new Noise(&params->np_inter_valley_fill, seed, csize.X, csize.Y + 2, csize.Z);
        // 1-down overgeneraion
-       noise_cave1             = new Noise(&sp->np_cave1,             seed, csize.X, csize.Y + 1, csize.Z);
-       noise_cave2             = new Noise(&sp->np_cave2,             seed, csize.X, csize.Y + 1, csize.Z);
-       noise_massive_caves     = new Noise(&sp->np_massive_caves,     seed, csize.X, csize.Y + 1, csize.Z);
-
-       //// Initialize biome generator
-       // NOTE: valleys mapgen can only use BiomeGenOriginal
-       biomegen = emerge->biomemgr->createBiomeGen(
-               BIOMEGEN_ORIGINAL, params->bparams, csize);
-       biomemap = biomegen->biomemap;
-       m_bgen = (BiomeGenOriginal *)biomegen;
+       noise_cave1             = new Noise(&params->np_cave1,             seed, csize.X, csize.Y + 1, csize.Z);
+       noise_cave2             = new Noise(&params->np_cave2,             seed, csize.X, csize.Y + 1, csize.Z);
+       noise_massive_caves     = new Noise(&params->np_massive_caves,     seed, csize.X, csize.Y + 1, csize.Z);
 
        this->humid_rivers       = (spflags & MGVALLEYS_HUMID_RIVERS);
        this->use_altitude_chill = (spflags & MGVALLEYS_ALT_CHILL);
@@ -127,34 +106,6 @@ MapgenValleys::MapgenValleys(int mapgenid, MapgenParams *params, EmergeManager *
        this->lava_max_height       = water_level + MYMAX(0, lava_features_lim - 4) * 50;
 
        tcave_cache = new float[csize.Y + 2];
-
-       //// Resolve nodes to be used
-       c_cobble               = ndef->getId("mapgen_cobble");
-       c_desert_stone         = ndef->getId("mapgen_desert_stone");
-       c_dirt                 = ndef->getId("mapgen_dirt");
-       c_lava_source          = ndef->getId("mapgen_lava_source");
-       c_mossycobble          = ndef->getId("mapgen_mossycobble");
-       c_river_water_source   = ndef->getId("mapgen_river_water_source");
-       c_sand                 = ndef->getId("mapgen_sand");
-       c_sandstonebrick       = ndef->getId("mapgen_sandstonebrick");
-       c_sandstone            = ndef->getId("mapgen_sandstone");
-       c_stair_cobble         = ndef->getId("mapgen_stair_cobble");
-       c_stair_sandstonebrick = ndef->getId("mapgen_stair_sandstonebrick");
-       c_stone                = ndef->getId("mapgen_stone");
-       c_water_source         = ndef->getId("mapgen_water_source");
-
-       if (c_mossycobble == CONTENT_IGNORE)
-               c_mossycobble = c_cobble;
-       if (c_river_water_source == CONTENT_IGNORE)
-               c_river_water_source = c_water_source;
-       if (c_sand == CONTENT_IGNORE)
-               c_sand = c_stone;
-       if (c_sandstonebrick == CONTENT_IGNORE)
-               c_sandstonebrick = c_sandstone;
-       if (c_stair_cobble == CONTENT_IGNORE)
-               c_stair_cobble = c_cobble;
-       if (c_stair_sandstonebrick == CONTENT_IGNORE)
-               c_stair_sandstonebrick = c_sandstone;
 }
 
 
@@ -171,9 +122,6 @@ MapgenValleys::~MapgenValleys()
        delete noise_valley_depth;
        delete noise_valley_profile;
 
-       delete biomegen;
-
-       delete[] heightmap;
        delete[] tcave_cache;
 }
 
@@ -188,10 +136,10 @@ MapgenValleysParams::MapgenValleysParams()
        river_depth        = 4;  // How deep to carve river channels.
        river_size         = 5;  // How wide to make rivers.
        water_features     = 0;  // How often water will occur in caves.
-       cave_width         = 0.3;
+       cave_width         = 0.09;
 
-       np_cave1              = NoiseParams(0,     12,   v3f(96,   96,   96),   52534, 4, 0.5,   2.0);
-       np_cave2              = NoiseParams(0,     12,   v3f(96,   96,   96),   10325, 4, 0.5,   2.0);
+       np_cave1              = NoiseParams(0,     12,   v3f(61,   61,   61),   52534, 3, 0.5,   2.0);
+       np_cave2              = NoiseParams(0,     12,   v3f(67,   67,   67),   10325, 3, 0.5,   2.0);
        np_filler_depth       = NoiseParams(0.f,   1.2f, v3f(256,  256,  256),  1605,  3, 0.5f,  2.f);
        np_inter_valley_fill  = NoiseParams(0.f,   1.f,  v3f(256,  512,  256),  1993,  6, 0.8f,  2.f);
        np_inter_valley_slope = NoiseParams(0.5f,  0.5f, v3f(128,  128,  128),  746,   1, 1.f,   2.f);
@@ -283,70 +231,31 @@ void MapgenValleys::makeChunk(BlockMakeData *data)
 
        blockseed = getBlockSeed2(full_node_min, seed);
 
-       // Generate noise maps and base terrain height.
-       calculateNoise();
-
        // Generate biome noises.  Note this must be executed strictly before
        // generateTerrain, because generateTerrain depends on intermediate
        // biome-related noises.
-       biomegen->calcBiomeNoise(node_min);
+       m_bgen->calcBiomeNoise(node_min);
+
+       // Generate noise maps and base terrain height.
+       // Modify heat and humidity maps.
+       calculateNoise();
 
        // Generate base terrain with initial heightmaps
        s16 stone_surface_max_y = generateTerrain();
 
-       // Build biomemap
-       biomegen->getBiomes(heightmap);
+       // Recalculate heightmap
+       updateHeightmap(node_min, node_max);
 
-       // Place biome-specific nodes
+       // Place biome-specific nodes and build biomemap
        MgStoneType stone_type = generateBiomes();
 
        // Cave creation.
        if (flags & MG_CAVES)
-               generateCaves(stone_surface_max_y);
+               generateCaves(stone_surface_max_y, large_cave_depth);
 
        // Dungeon creation
-       if ((flags & MG_DUNGEONS) && node_max.Y < 50 && (stone_surface_max_y >= node_min.Y)) {
-               DungeonParams dp;
-
-               dp.np_rarity  = nparams_dungeon_rarity;
-               dp.np_density = nparams_dungeon_density;
-               dp.np_wetness = nparams_dungeon_wetness;
-               dp.c_water    = c_water_source;
-               if (stone_type == STONE) {
-                       dp.c_cobble = c_cobble;
-                       dp.c_moss   = c_mossycobble;
-                       dp.c_stair  = c_stair_cobble;
-
-                       dp.diagonal_dirs = false;
-                       dp.mossratio     = 3.f;
-                       dp.holesize      = v3s16(1, 2, 1);
-                       dp.roomsize      = v3s16(0, 0, 0);
-                       dp.notifytype    = GENNOTIFY_DUNGEON;
-               } else if (stone_type == DESERT_STONE) {
-                       dp.c_cobble = c_desert_stone;
-                       dp.c_moss   = c_desert_stone;
-                       dp.c_stair  = c_desert_stone;
-
-                       dp.diagonal_dirs = true;
-                       dp.mossratio     = 0.f;
-                       dp.holesize      = v3s16(2, 3, 2);
-                       dp.roomsize      = v3s16(2, 5, 2);
-                       dp.notifytype    = GENNOTIFY_TEMPLE;
-               } else if (stone_type == SANDSTONE) {
-                       dp.c_cobble = c_sandstonebrick;
-                       dp.c_moss   = c_sandstonebrick;
-                       dp.c_stair  = c_sandstonebrick;
-
-                       dp.diagonal_dirs = false;
-                       dp.mossratio     = 0.f;
-                       dp.holesize      = v3s16(2, 2, 2);
-                       dp.roomsize      = v3s16(2, 0, 2);
-                       dp.notifytype    = GENNOTIFY_DUNGEON;
-               }
-
-               DungeonGen dgen(this, &dp);
-               dgen.generate(blockseed, full_node_min, full_node_max);
-       }
+       if ((flags & MG_DUNGEONS) && node_max.Y < 50)
+               generateDungeons(stone_surface_max_y, stone_type);
 
        // Generate the registered decorations
        if (flags & MG_DECORATIONS)
@@ -388,7 +297,6 @@ void MapgenValleys::calculateNoise()
 
        //TimeTaker tcn("actualNoise");
 
-       noise_filler_depth->perlinMap2D(x, z);
        noise_inter_valley_slope->perlinMap2D(x, z);
        noise_rivers->perlinMap2D(x, z);
        noise_terrain_height->perlinMap2D(x, z);
@@ -573,7 +481,6 @@ int MapgenValleys::generateTerrain()
 
        MapNode n_air(CONTENT_AIR);
        MapNode n_river_water(c_river_water_source);
-       MapNode n_sand(c_sand);
        MapNode n_stone(c_stone);
        MapNode n_water(c_water_source);
 
@@ -607,7 +514,7 @@ int MapgenValleys::generateTerrain()
                        }
                }
 
-               u32 index_3d = (z - node_min.Z) * zstride + (x - node_min.X);
+               u32 index_3d = (z - node_min.Z) * zstride_1u1d + (x - node_min.X);
                u32 index_data = vm->m_area.index(x, node_min.Y - 1, z);
 
                // Mapgens concern themselves with stone and water.
@@ -617,10 +524,7 @@ int MapgenValleys::generateTerrain()
                                float surface_delta = (float)y - surface_y;
                                bool river = y + 1 < river_y;
 
-                               if (fabs(surface_delta) <= 0.5f && y > water_level && river) {
-                                       // river bottom
-                                       vm->m_data[index_data] = n_sand;
-                               } else if (slope * fill > surface_delta) {
+                               if (slope * fill > surface_delta) {
                                        // ground
                                        vm->m_data[index_data] = n_stone;
                                        if (y > heightmap[index_2d])
@@ -633,7 +537,7 @@ int MapgenValleys::generateTerrain()
                                } else if (river) {
                                        // river
                                        vm->m_data[index_data] = n_river_water;
-                               } else {
+                               } else {  // air
                                        vm->m_data[index_data] = n_air;
                                }
                        }
@@ -642,10 +546,6 @@ int MapgenValleys::generateTerrain()
                        index_3d += ystride;
                }
 
-               // This happens if we're generating a chunk that doesn't
-               // contain the terrain surface, in which case, we need
-               // to set heightmap to a value outside of the chunk,
-               // to avoid confusing lua mods that use heightmap.
                if (heightmap[index_2d] == -MAX_MAP_GENERATION_LIMIT) {
                        s16 surface_y_int = myround(surface_y);
                        if (surface_y_int > node_max.Y + 1 || surface_y_int < node_min.Y - 1) {
@@ -692,166 +592,7 @@ int MapgenValleys::generateTerrain()
        return surface_max_y;
 }
 
-
-MgStoneType MapgenValleys::generateBiomes()
-{
-       v3s16 em = vm->m_area.getExtent();
-       u32 index = 0;
-       MgStoneType stone_type = STONE;
-
-       for (s16 z = node_min.Z; z <= node_max.Z; z++)
-       for (s16 x = node_min.X; x <= node_max.X; x++, index++) {
-               Biome *biome = NULL;
-               u16 depth_top = 0;
-               u16 base_filler = 0;
-               u16 depth_water_top = 0;
-               u32 vi = vm->m_area.index(x, node_max.Y, z);
-
-               // Check node at base of mapchunk above, either a node of a previously
-               // generated mapchunk or if not, a node of overgenerated base terrain.
-               content_t c_above = vm->m_data[vi + em.X].getContent();
-               bool air_above = c_above == CONTENT_AIR;
-               bool water_above = (c_above == c_water_source || c_above == c_river_water_source);
-
-               // If there is air or water above enable top/filler placement, otherwise force
-               // nplaced to stone level by setting a number exceeding any possible filler depth.
-               u16 nplaced = (air_above || water_above) ? 0 : U16_MAX;
-
-               for (s16 y = node_max.Y; y >= node_min.Y; y--) {
-                       content_t c = vm->m_data[vi].getContent();
-
-                       // Biome is recalculated each time an upper surface is detected while
-                       // working down a column. The selected biome then remains in effect for
-                       // all nodes below until the next surface and biome recalculation.
-                       // Biome is recalculated:
-                       // 1. At the surface of stone below air or water.
-                       // 2. At the surface of water below air.
-                       // 3. When stone or water is detected but biome has not yet been calculated.
-                       if ((c == c_stone && (air_above || water_above || !biome))
-                                       || ((c == c_water_source || c == c_river_water_source)
-                                               && (air_above || !biome))) {
-                               // Both heat and humidity have already been adjusted for altitude.
-                               biome = biomegen->getBiomeAtIndex(index, y);
-
-                               depth_top = biome->depth_top;
-                               base_filler = MYMAX(depth_top
-                                               + biome->depth_filler
-                                               + noise_filler_depth->result[index], 0.f);
-                               depth_water_top = biome->depth_water_top;
-
-                               // Detect stone type for dungeons during every biome calculation.
-                               // This is more efficient than detecting per-node and will not
-                               // miss any desert stone or sandstone biomes.
-                               if (biome->c_stone == c_desert_stone)
-                                       stone_type = DESERT_STONE;
-                               else if (biome->c_stone == c_sandstone)
-                                       stone_type = SANDSTONE;
-                       }
-
-                       if (c == c_stone) {
-                               content_t c_below = vm->m_data[vi - em.X].getContent();
-
-                               // If the node below isn't solid, make this node stone, so that
-                               // any top/filler nodes above are structurally supported.
-                               // This is done by aborting the cycle of top/filler placement
-                               // immediately by forcing nplaced to stone level.
-                               if (c_below == CONTENT_AIR
-                                               || c_below == c_water_source
-                                               || c_below == c_river_water_source)
-                                       nplaced = U16_MAX;
-
-                               if (nplaced < depth_top) {
-                                       vm->m_data[vi] = MapNode(biome->c_top);
-                                       nplaced++;
-                               } else if (nplaced < base_filler) {
-                                       vm->m_data[vi] = MapNode(biome->c_filler);
-                                       nplaced++;
-                               } else {
-                                       vm->m_data[vi] = MapNode(biome->c_stone);
-                               }
-
-                               air_above = false;
-                               water_above = false;
-                       } else if (c == c_water_source) {
-                               vm->m_data[vi] = MapNode((y > (s32)(water_level - depth_water_top))
-                                               ? biome->c_water_top : biome->c_water);
-                               nplaced = 0;  // Enable top/filler placement for next surface
-                               air_above = false;
-                               water_above = true;
-                       } else if (c == c_river_water_source) {
-                               vm->m_data[vi] = MapNode(biome->c_river_water);
-                               nplaced = depth_top;  // Enable filler placement for next surface
-                               air_above = false;
-                               water_above = true;
-                       } else if (c == CONTENT_AIR) {
-                               nplaced = 0;  // Enable top/filler placement for next surface
-                               air_above = true;
-                               water_above = false;
-                       } else {  // Possible various nodes overgenerated from neighbouring mapchunks
-                               nplaced = U16_MAX;  // Disable top/filler placement
-                               air_above = false;
-                               water_above = false;
-                       }
-
-                       vm->m_area.add_y(em, vi, -1);
-               }
-       }
-
-       return stone_type;
-}
-
-
-void MapgenValleys::dustTopNodes()
-{
-       if (node_max.Y < water_level)
-               return;
-
-       v3s16 em = vm->m_area.getExtent();
-       u32 index = 0;
-
-       for (s16 z = node_min.Z; z <= node_max.Z; z++)
-       for (s16 x = node_min.X; x <= node_max.X; x++, index++) {
-               Biome *biome = (Biome *)bmgr->getRaw(biomemap[index]);
-
-               if (biome->c_dust == CONTENT_IGNORE)
-                       continue;
-
-               u32 vi = vm->m_area.index(x, full_node_max.Y, z);
-               content_t c_full_max = vm->m_data[vi].getContent();
-               s16 y_start;
-
-               if (c_full_max == CONTENT_AIR) {
-                       y_start = full_node_max.Y - 1;
-               } else if (c_full_max == CONTENT_IGNORE) {
-                       vi = vm->m_area.index(x, node_max.Y + 1, z);
-                       content_t c_max = vm->m_data[vi].getContent();
-
-                       if (c_max == CONTENT_AIR)
-                               y_start = node_max.Y;
-                       else
-                               continue;
-               } else {
-                       continue;
-               }
-
-               vi = vm->m_area.index(x, y_start, z);
-               for (s16 y = y_start; y >= node_min.Y - 1; y--) {
-                       if (vm->m_data[vi].getContent() != CONTENT_AIR)
-                               break;
-
-                       vm->m_area.add_y(em, vi, -1);
-               }
-
-               content_t c = vm->m_data[vi].getContent();
-               if (!ndef->get(c).buildable_to && c != CONTENT_IGNORE && c != biome->c_dust) {
-                       vm->m_area.add_y(em, vi, 1);
-                       vm->m_data[vi] = MapNode(biome->c_dust);
-               }
-       }
-}
-
-
-void MapgenValleys::generateCaves(s16 max_stone_y)
+void MapgenValleys::generateCaves(s16 max_stone_y, s16 large_cave_depth)
 {
        if (max_stone_y < node_min.Y)
                return;
@@ -873,7 +614,7 @@ void MapgenValleys::generateCaves(s16 max_stone_y)
        const float massive_cave_threshold = 0.6f;
        // mct: 1 = small rare caves, 0.5 1/3rd ground volume, 0 = 1/2 ground volume.
 
-       float yblmin = -map_gen_limit + massive_cave_blend * 1.5f;
+       float yblmin = -mapgen_limit + massive_cave_blend * 1.5f;
        float yblmax = massive_cave_depth - massive_cave_blend * 1.5f;
        bool made_a_big_one = false;
 
@@ -898,11 +639,11 @@ void MapgenValleys::generateCaves(s16 max_stone_y)
 
        // lava_depth varies between one and ten as you approach
        //  the bottom of the world.
-       s16 lava_depth = ceil((lava_max_height - node_min.Y + 1) * 10.f / map_gen_limit);
+       s16 lava_depth = ceil((lava_max_height - node_min.Y + 1) * 10.f / mapgen_limit);
        // This allows random lava spawns to be less common at the surface.
        s16 lava_chance = MYCUBE(lava_features_lim) * lava_depth;
        // water_depth varies between ten and one on the way down.
-       s16 water_depth = ceil((map_gen_limit - abs(node_min.Y) + 1) * 10.f / map_gen_limit);
+       s16 water_depth = ceil((mapgen_limit - abs(node_min.Y) + 1) * 10.f / mapgen_limit);
        // This allows random water spawns to be more common at the surface.
        s16 water_chance = MYCUBE(water_features_lim) * water_depth;
 
@@ -915,8 +656,9 @@ void MapgenValleys::generateCaves(s16 max_stone_y)
        u32 index_2d = 0;
        for (s16 z = node_min.Z; z <= node_max.Z; z++)
        for (s16 x = node_min.X; x <= node_max.X; x++, index_2d++) {
-               Biome *biome = (Biome *)bmgr->getRaw(biomemap[index_2d]);
+               Biome *biome = (Biome *)m_bmgr->getRaw(biomemap[index_2d]);
                bool tunnel_air_above = false;
+               bool is_under_river = false;
                bool underground = false;
                u32 index_data = vm->m_area.index(x, node_max.Y, z);
                u32 index_3d = (z - node_min.Z) * zstride_1d + csize.Y * ystride + (x - node_min.X);
@@ -948,14 +690,13 @@ void MapgenValleys::generateCaves(s16 max_stone_y)
                        }
 
                        content_t c = vm->m_data[index_data].getContent();
+                       // Detect river water to place riverbed nodes in tunnels
+                       if (c == biome->c_river_water)
+                               is_under_river = true;
+
                        float d1 = contour(noise_cave1->result[index_3d]);
                        float d2 = contour(noise_cave2->result[index_3d]);
 
-                       // River water is not set as ground content
-                       // in the default game. This can produce strange results
-                       // when a tunnel undercuts a river. However, that's not for
-                       // the mapgen to correct. Fix it in lua.
-
                        if (d1 * d2 > cave_width && ndef->get(c).is_ground_content) {
                                // in a tunnel
                                vm->m_data[index_data] = n_air;
@@ -968,8 +709,10 @@ void MapgenValleys::generateCaves(s16 max_stone_y)
                                        vm->m_area.add_y(em, j, 1);
 
                                        if (sr > terrain - y) {
-                                               // Put dirt in tunnels near the surface.
-                                               if (underground)
+                                               // Put biome nodes in tunnels near the surface
+                                               if (is_under_river)
+                                                       vm->m_data[index_data] = MapNode(biome->c_riverbed);
+                                               else if (underground)
                                                        vm->m_data[index_data] = MapNode(biome->c_filler);
                                                else
                                                        vm->m_data[index_data] = MapNode(biome->c_top);
@@ -1000,8 +743,10 @@ void MapgenValleys::generateCaves(s16 max_stone_y)
        if (node_max.Y <= large_cave_depth && !made_a_big_one) {
                u32 bruises_count = ps.range(0, 2);
                for (u32 i = 0; i < bruises_count; i++) {
-                       CaveV5 cave(this, &ps);
-                       cave.makeCave(node_min, node_max, max_stone_y);
+                       CavesRandomWalk cave(ndef, &gennotify, seed, water_level,
+                               c_water_source, c_lava_source);
+
+                       cave.makeCave(vm, node_min, node_max, &ps, true, max_stone_y, heightmap);
                }
        }
 }