]> git.lizzy.rs Git - minetest.git/blobdiff - src/mapgen_v7.cpp
Mgv7, mgflat, mgfractal: Tunnel generation code optimisation
[minetest.git] / src / mapgen_v7.cpp
index 640ad10f4a48c143828bb3e871d64886b1cb53e0..069c341199c69b49d9c91e8b7887f825bd0cca1a 100644 (file)
@@ -1,6 +1,7 @@
 /*
 Minetest
-Copyright (C) 2010-2013 kwolekr, Ryan Kwolek <kwolekr@minetest.net>
+Copyright (C) 2010-2015 kwolekr, Ryan Kwolek <kwolekr@minetest.net>
+Copyright (C) 2010-2015 paramat, Matt Gregory
 
 This program is free software; you can redistribute it and/or modify
 it under the terms of the GNU Lesser General Public License as published by
@@ -27,7 +28,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "content_sao.h"
 #include "nodedef.h"
 #include "voxelalgorithms.h"
-#include "profiler.h"
+//#include "profiler.h" // For TimeTaker
 #include "settings.h" // For g_settings
 #include "emerge.h"
 #include "dungeongen.h"
@@ -45,6 +46,7 @@ FlagDesc flagdesc_mapgen_v7[] = {
        {NULL,        0}
 };
 
+
 ///////////////////////////////////////////////////////////////////////////////
 
 
@@ -57,10 +59,13 @@ MapgenV7::MapgenV7(int mapgenid, MapgenParams *params, EmergeManager *emerge)
        //// amount of elements to skip for the next index
        //// for noise/height/biome maps (not vmanip)
        this->ystride = csize.X;
-       this->zstride = csize.X * (csize.Y + 2);
+       // 1-down overgeneration
+       this->zstride_1d = csize.X * (csize.Y + 1);
 
-       this->biomemap  = new u8[csize.X * csize.Z];
-       this->heightmap = new s16[csize.X * csize.Z];
+       this->biomemap        = new u8[csize.X * csize.Z];
+       this->heightmap       = new s16[csize.X * csize.Z];
+       this->heatmap         = NULL;
+       this->humidmap        = NULL;
        this->ridge_heightmap = new s16[csize.X * csize.Z];
 
        MapgenV7Params *sp = (MapgenV7Params *)params->sparams;
@@ -76,14 +81,18 @@ MapgenV7::MapgenV7(int mapgenid, MapgenParams *params, EmergeManager *emerge)
        noise_ridge_uwater    = new Noise(&sp->np_ridge_uwater,    seed, csize.X, csize.Z);
 
        //// 3d terrain noise
+       // 1-up 1-down overgeneration
        noise_mountain = new Noise(&sp->np_mountain, seed, csize.X, csize.Y + 2, csize.Z);
        noise_ridge    = new Noise(&sp->np_ridge,    seed, csize.X, csize.Y + 2, csize.Z);
-       noise_cave1    = new Noise(&sp->np_cave1,    seed, csize.X, csize.Y + 2, csize.Z);
-       noise_cave2    = new Noise(&sp->np_cave2,    seed, csize.X, csize.Y + 2, csize.Z);
+       // 1-down overgeneraion
+       noise_cave1    = new Noise(&sp->np_cave1,    seed, csize.X, csize.Y + 1, csize.Z);
+       noise_cave2    = new Noise(&sp->np_cave2,    seed, csize.X, csize.Y + 1, csize.Z);
 
        //// Biome noise
-       noise_heat     = new Noise(&params->np_biome_heat,     seed, csize.X, csize.Z);
-       noise_humidity = new Noise(&params->np_biome_humidity, seed, csize.X, csize.Z);
+       noise_heat           = new Noise(&params->np_biome_heat,           seed, csize.X, csize.Z);
+       noise_humidity       = new Noise(&params->np_biome_humidity,       seed, csize.X, csize.Z);
+       noise_heat_blend     = new Noise(&params->np_biome_heat_blend,     seed, csize.X, csize.Z);
+       noise_humidity_blend = new Noise(&params->np_biome_humidity_blend, seed, csize.X, csize.Z);
 
        //// Resolve nodes to be used
        INodeDefManager *ndef = emerge->ndef;
@@ -93,6 +102,7 @@ MapgenV7::MapgenV7(int mapgenid, MapgenParams *params, EmergeManager *emerge)
        c_lava_source          = ndef->getId("mapgen_lava_source");
        c_desert_stone         = ndef->getId("mapgen_desert_stone");
        c_ice                  = ndef->getId("mapgen_ice");
+       c_sandstone            = ndef->getId("mapgen_sandstone");
 
        c_cobble               = ndef->getId("mapgen_cobble");
        c_stair_cobble         = ndef->getId("mapgen_stair_cobble");
@@ -107,9 +117,9 @@ MapgenV7::MapgenV7(int mapgenid, MapgenParams *params, EmergeManager *emerge)
        if (c_stair_cobble == CONTENT_IGNORE)
                c_stair_cobble = c_cobble;
        if (c_sandstonebrick == CONTENT_IGNORE)
-               c_sandstonebrick = c_desert_stone;
+               c_sandstonebrick = c_sandstone;
        if (c_stair_sandstonebrick == CONTENT_IGNORE)
-               c_stair_sandstonebrick = c_sandstonebrick;
+               c_stair_sandstonebrick = c_sandstone;
 }
 
 
@@ -129,6 +139,8 @@ MapgenV7::~MapgenV7()
 
        delete noise_heat;
        delete noise_humidity;
+       delete noise_heat_blend;
+       delete noise_humidity_blend;
 
        delete[] ridge_heightmap;
        delete[] heightmap;
@@ -140,17 +152,17 @@ MapgenV7Params::MapgenV7Params()
 {
        spflags = MGV7_MOUNTAINS | MGV7_RIDGES;
 
-       np_terrain_base    = NoiseParams(4,    70,  v3f(300, 300, 300), 82341, 6, 0.7,  2.0);
-       np_terrain_alt     = NoiseParams(4,    25,  v3f(600, 600, 600), 5934,  5, 0.6,  2.0);
-       np_terrain_persist = NoiseParams(0.6,  0.1, v3f(500, 500, 500), 539,   3, 0.6,  2.0);
-       np_height_select   = NoiseParams(-0.5, 1,   v3f(250, 250, 250), 4213,  5, 0.69, 2.0);
-       np_filler_depth    = NoiseParams(0,    1.2, v3f(150, 150, 150), 261,   4, 0.7,  2.0);
-       np_mount_height    = NoiseParams(100,  30,  v3f(500, 500, 500), 72449, 4, 0.6,  2.0);
-       np_ridge_uwater    = NoiseParams(0,    1,   v3f(500, 500, 500), 85039, 4, 0.6,  2.0);
-       np_mountain        = NoiseParams(-0.6, 1,   v3f(250, 350, 250), 5333,  5, 0.68, 2.0);
-       np_ridge           = NoiseParams(0,    1,   v3f(100, 100, 100), 6467,  4, 0.75, 2.0);
-       np_cave1           = NoiseParams(0,    12,  v3f(100, 100, 100), 52534, 4, 0.5,  2.0);
-       np_cave2           = NoiseParams(0,    12,  v3f(100, 100, 100), 10325, 4, 0.5,  2.0);
+       np_terrain_base    = NoiseParams(4,    70,  v3f(600,  600,  600),  82341, 5, 0.6,  2.0);
+       np_terrain_alt     = NoiseParams(4,    25,  v3f(600,  600,  600),  5934,  5, 0.6,  2.0);
+       np_terrain_persist = NoiseParams(0.6,  0.1, v3f(2000, 2000, 2000), 539,   3, 0.6,  2.0);
+       np_height_select   = NoiseParams(-8,   16,  v3f(500,  500,  500),  4213,  6, 0.7,  2.0);
+       np_filler_depth    = NoiseParams(0,    1.2, v3f(150,  150,  150),  261,   3, 0.7,  2.0);
+       np_mount_height    = NoiseParams(256,  112, v3f(1000, 1000, 1000), 72449, 3, 0.6,  2.0);
+       np_ridge_uwater    = NoiseParams(0,    1,   v3f(1000, 1000, 1000), 85039, 5, 0.6,  2.0);
+       np_mountain        = NoiseParams(-0.6, 1,   v3f(250,  350,  250),  5333,  5, 0.63, 2.0);
+       np_ridge           = NoiseParams(0,    1,   v3f(100,  100,  100),  6467,  4, 0.75, 2.0);
+       np_cave1           = NoiseParams(0,    12,  v3f(96,   96,   96),   52534, 4, 0.5,  2.0);
+       np_cave2           = NoiseParams(0,    12,  v3f(96,   96,   96),   10325, 4, 0.5,  2.0);
 }
 
 
@@ -174,7 +186,7 @@ void MapgenV7Params::readParams(const Settings *settings)
 
 void MapgenV7Params::writeParams(Settings *settings) const
 {
-       settings->setFlagStr("mgv7_spflags", spflags, flagdesc_mapgen_v7, (u32)-1);
+       settings->setFlagStr("mgv7_spflags", spflags, flagdesc_mapgen_v7, U32_MAX);
 
        settings->setNoiseParams("mgv7_np_terrain_base",    np_terrain_base);
        settings->setNoiseParams("mgv7_np_terrain_alt",     np_terrain_alt);
@@ -190,10 +202,10 @@ void MapgenV7Params::writeParams(Settings *settings) const
 }
 
 
-///////////////////////////////////////
+///////////////////////////////////////////////////////////////////////////////
 
 
-int MapgenV7::getGroundLevelAtPoint(v2s16 p)
+int MapgenV7::getSpawnLevelAtPoint(v2s16 p)
 {
        // Base terrain calculation
        s16 y = baseTerrainLevelAtPoint(p.X, p.Y);
@@ -201,22 +213,24 @@ int MapgenV7::getGroundLevelAtPoint(v2s16 p)
        // Ridge/river terrain calculation
        float width = 0.2;
        float uwatern = NoisePerlin2D(&noise_ridge_uwater->np, p.X, p.Y, seed) * 2;
-       // actually computing the depth of the ridge is much more expensive;
-       // if inside a river, simply guess
+       // if inside a river this is an unsuitable spawn point
        if (fabs(uwatern) <= width)
-               return water_level - 10;
+               return MAX_MAP_GENERATION_LIMIT;
 
        // Mountain terrain calculation
-       int iters = 128; // don't even bother iterating more than 128 times..
+       int iters = 128;
        while (iters--) {
-               //current point would have been air
-               if (!getMountainTerrainAtPoint(p.X, y, p.Y))
-                       return y;
-
+               if (!getMountainTerrainAtPoint(p.X, y + 1, p.Y)) {  // Air, y is ground level
+                       if (y <= water_level || y > water_level + 16)
+                               return MAX_MAP_GENERATION_LIMIT;  // Unsuitable spawn point
+                       else
+                               return y;
+               }
                y++;
        }
 
-       return y;
+       // Unsuitable spawn point, no ground surface found
+       return MAX_MAP_GENERATION_LIMIT;
 }
 
 
@@ -226,11 +240,11 @@ void MapgenV7::makeChunk(BlockMakeData *data)
        assert(data->vmanip);
        assert(data->nodedef);
        assert(data->blockpos_requested.X >= data->blockpos_min.X &&
-                  data->blockpos_requested.Y >= data->blockpos_min.Y &&
-                  data->blockpos_requested.Z >= data->blockpos_min.Z);
+               data->blockpos_requested.Y >= data->blockpos_min.Y &&
+               data->blockpos_requested.Z >= data->blockpos_min.Z);
        assert(data->blockpos_requested.X <= data->blockpos_max.X &&
-                  data->blockpos_requested.Y <= data->blockpos_max.Y &&
-                  data->blockpos_requested.Z <= data->blockpos_max.Z);
+               data->blockpos_requested.Y <= data->blockpos_max.Y &&
+               data->blockpos_requested.Z <= data->blockpos_max.Z);
 
        this->generating = true;
        this->vm   = data->vmanip;
@@ -260,7 +274,7 @@ void MapgenV7::makeChunk(BlockMakeData *data)
                noise_humidity->result, heightmap, biomemap);
 
        // Actually place the biome-specific nodes
-       bool desert_stone = generateBiomes(noise_heat->result, noise_humidity->result);
+       MgStoneType stone_type = generateBiomes(noise_heat->result, noise_humidity->result);
 
        if (flags & MG_CAVES)
                generateCaves(stone_surface_max_y);
@@ -272,7 +286,17 @@ void MapgenV7::makeChunk(BlockMakeData *data)
                dp.np_density = nparams_dungeon_density;
                dp.np_wetness = nparams_dungeon_wetness;
                dp.c_water    = c_water_source;
-               if (desert_stone) {
+               if (stone_type == STONE) {
+                       dp.c_cobble = c_cobble;
+                       dp.c_moss   = c_mossycobble;
+                       dp.c_stair  = c_stair_cobble;
+
+                       dp.diagonal_dirs = false;
+                       dp.mossratio     = 3.0;
+                       dp.holesize      = v3s16(1, 2, 1);
+                       dp.roomsize      = v3s16(0, 0, 0);
+                       dp.notifytype    = GENNOTIFY_DUNGEON;
+               } else if (stone_type == DESERT_STONE) {
                        dp.c_cobble = c_desert_stone;
                        dp.c_moss   = c_desert_stone;
                        dp.c_stair  = c_desert_stone;
@@ -282,15 +306,15 @@ void MapgenV7::makeChunk(BlockMakeData *data)
                        dp.holesize      = v3s16(2, 3, 2);
                        dp.roomsize      = v3s16(2, 5, 2);
                        dp.notifytype    = GENNOTIFY_TEMPLE;
-               } else {
-                       dp.c_cobble = c_cobble;
-                       dp.c_moss   = c_mossycobble;
-                       dp.c_stair  = c_stair_cobble;
+               } else if (stone_type == SANDSTONE) {
+                       dp.c_cobble = c_sandstonebrick;
+                       dp.c_moss   = c_sandstonebrick;
+                       dp.c_stair  = c_sandstonebrick;
 
                        dp.diagonal_dirs = false;
-                       dp.mossratio     = 3.0;
-                       dp.holesize      = v3s16(1, 2, 1);
-                       dp.roomsize      = v3s16(0, 0, 0);
+                       dp.mossratio     = 0.0;
+                       dp.holesize      = v3s16(2, 2, 2);
+                       dp.roomsize      = v3s16(2, 0, 2);
                        dp.notifytype    = GENNOTIFY_DUNGEON;
                }
 
@@ -299,7 +323,8 @@ void MapgenV7::makeChunk(BlockMakeData *data)
        }
 
        // Generate the registered decorations
-       m_emerge->decomgr->placeAllDecos(this, blockseed, node_min, node_max);
+       if (flags & MG_DECORATIONS)
+               m_emerge->decomgr->placeAllDecos(this, blockseed, node_min, node_max);
 
        // Generate the registered ores
        m_emerge->oremgr->placeAllOres(this, blockseed, node_min, node_max);
@@ -325,9 +350,9 @@ void MapgenV7::makeChunk(BlockMakeData *data)
 void MapgenV7::calculateNoise()
 {
        //TimeTaker t("calculateNoise", NULL, PRECISION_MICRO);
-       int x = node_min.X;
-       int y = node_min.Y - 1;
-       int z = node_min.Z;
+       s16 x = node_min.X;
+       s16 y = node_min.Y - 1;
+       s16 z = node_min.Z;
 
        noise_terrain_persist->perlinMap2D(x, z);
        float *persistmap = noise_terrain_persist->result;
@@ -336,41 +361,47 @@ void MapgenV7::calculateNoise()
        noise_terrain_alt->perlinMap2D(x, z, persistmap);
        noise_height_select->perlinMap2D(x, z);
 
-       if (flags & MG_CAVES) {
-               noise_cave1->perlinMap3D(x, y, z);
-               noise_cave2->perlinMap3D(x, y, z);
-       }
-
        if ((spflags & MGV7_RIDGES) && node_max.Y >= water_level) {
                noise_ridge->perlinMap3D(x, y, z);
                noise_ridge_uwater->perlinMap2D(x, z);
        }
 
-       if ((spflags & MGV7_MOUNTAINS) && node_max.Y >= 0) {
-               noise_mountain->perlinMap3D(x, y, z);
-               noise_mount_height->perlinMap2D(x, z);
-       }
+       // Cave noises are calculated in generateCaves()
+       // only if solid terrain is present in mapchunk
 
-       if (node_max.Y >= water_level) {
-               noise_filler_depth->perlinMap2D(x, z);
-               noise_heat->perlinMap2D(x, z);
-               noise_humidity->perlinMap2D(x, z);
+       // Mountain noises are calculated in generateMountainTerrain()
+       // only if solid terrain surface dips into mapchunk
+
+       noise_filler_depth->perlinMap2D(x, z);
+       noise_heat->perlinMap2D(x, z);
+       noise_humidity->perlinMap2D(x, z);
+       noise_heat_blend->perlinMap2D(x, z);
+       noise_humidity_blend->perlinMap2D(x, z);
+
+       for (s32 i = 0; i < csize.X * csize.Z; i++) {
+               noise_heat->result[i] += noise_heat_blend->result[i];
+               noise_humidity->result[i] += noise_humidity_blend->result[i];
        }
+
+       heatmap = noise_heat->result;
+       humidmap = noise_humidity->result;
        //printf("calculateNoise: %dus\n", t.stop());
 }
 
 
 Biome *MapgenV7::getBiomeAtPoint(v3s16 p)
 {
-       float heat      = NoisePerlin2D(&noise_heat->np, p.X, p.Z, seed);
-       float humidity  = NoisePerlin2D(&noise_humidity->np, p.X, p.Z, seed);
+       float heat = NoisePerlin2D(&noise_heat->np, p.X, p.Z, seed) +
+               NoisePerlin2D(&noise_heat_blend->np, p.X, p.Z, seed);
+       float humidity = NoisePerlin2D(&noise_humidity->np, p.X, p.Z, seed) +
+               NoisePerlin2D(&noise_humidity_blend->np, p.X, p.Z, seed);
        s16 groundlevel = baseTerrainLevelAtPoint(p.X, p.Z);
 
        return bmgr->getBiome(heat, humidity, groundlevel);
 }
 
 //needs to be updated
-float MapgenV7::baseTerrainLevelAtPoint(int x, int z)
+float MapgenV7::baseTerrainLevelAtPoint(s16 x, s16 z)
 {
        float hselect = NoisePerlin2D(&noise_height_select->np, x, z, seed);
        hselect = rangelim(hselect, 0.0, 1.0);
@@ -403,79 +434,52 @@ float MapgenV7::baseTerrainLevelFromMap(int index)
 }
 
 
-bool MapgenV7::getMountainTerrainAtPoint(int x, int y, int z)
+bool MapgenV7::getMountainTerrainAtPoint(s16 x, s16 y, s16 z)
 {
        float mnt_h_n = NoisePerlin2D(&noise_mount_height->np, x, z, seed);
+       float density_gradient = -((float)y / mnt_h_n);
        float mnt_n = NoisePerlin3D(&noise_mountain->np, x, y, z, seed);
-       return mnt_n * mnt_h_n >= (float)y;
+
+       return mnt_n + density_gradient >= 0.0;
 }
 
 
-bool MapgenV7::getMountainTerrainFromMap(int idx_xyz, int idx_xz, int y)
+bool MapgenV7::getMountainTerrainFromMap(int idx_xyz, int idx_xz, s16 y)
 {
        float mounthn = noise_mount_height->result[idx_xz];
+       float density_gradient = -((float)y / mounthn);
        float mountn = noise_mountain->result[idx_xyz];
-       return mountn * mounthn >= (float)y;
-}
-
-
-#if 0
-void MapgenV7::carveRivers() {
-       MapNode n_air(CONTENT_AIR), n_water_source(c_water_source);
-       MapNode n_stone(c_stone);
-       u32 index = 0;
-
-       int river_depth = 4;
 
-       for (s16 z = node_min.Z; z <= node_max.Z; z++)
-       for (s16 x = node_min.X; x <= node_max.X; x++, index++) {
-               float terrain_mod  = noise_terrain_mod->result[index];
-               NoiseParams *np = noise_terrain_river->np;
-               np.persist = noise_terrain_persist->result[index];
-               float terrain_river = NoisePerlin2DNoTxfm(np, x, z, seed);
-               float height = terrain_river * (1 - abs(terrain_mod)) *
-                                               noise_terrain_river->np.scale;
-               height = log(height * height); //log(h^3) is pretty interesting for terrain
-
-               s16 y = heightmap[index];
-               if (height < 1.0 && y > river_depth &&
-                       y - river_depth >= node_min.Y && y <= node_max.Y) {
-
-                       for (s16 ry = y; ry != y - river_depth; ry--) {
-                               u32 vi = vm->m_area.index(x, ry, z);
-                               vm->m_data[vi] = n_air;
-                       }
-
-                       u32 vi = vm->m_area.index(x, y - river_depth, z);
-                       vm->m_data[vi] = n_water_source;
-               }
-       }
+       return mountn + density_gradient >= 0.0;
 }
-#endif
 
 
 int MapgenV7::generateTerrain()
 {
-       int ymax = generateBaseTerrain();
+       s16 stone_surface_min_y;
+       s16 stone_surface_max_y;
+
+       generateBaseTerrain(&stone_surface_min_y, &stone_surface_max_y);
 
-       if (spflags & MGV7_MOUNTAINS)
-               ymax = generateMountainTerrain(ymax);
+       if ((spflags & MGV7_MOUNTAINS) && stone_surface_min_y < node_max.Y)
+               stone_surface_max_y = generateMountainTerrain(stone_surface_max_y);
 
        if (spflags & MGV7_RIDGES)
                generateRidgeTerrain();
 
-       return ymax;
+       return stone_surface_max_y;
 }
 
 
-int MapgenV7::generateBaseTerrain()
+void MapgenV7::generateBaseTerrain(s16 *stone_surface_min_y, s16 *stone_surface_max_y)
 {
        MapNode n_air(CONTENT_AIR);
        MapNode n_stone(c_stone);
        MapNode n_water(c_water_source);
 
-       int stone_surface_max_y = -MAP_GENERATION_LIMIT;
        v3s16 em = vm->m_area.getExtent();
+       s16 surface_min_y = MAX_MAP_GENERATION_LIMIT;
+       s16 surface_max_y = -MAX_MAP_GENERATION_LIMIT;
        u32 index = 0;
 
        for (s16 z = node_min.Z; z <= node_max.Z; z++)
@@ -486,31 +490,35 @@ int MapgenV7::generateBaseTerrain()
                heightmap[index]       = surface_y;
                ridge_heightmap[index] = surface_y;
 
-               if (surface_y > stone_surface_max_y)
-                       stone_surface_max_y = surface_y;
+               if (surface_y < surface_min_y)
+                       surface_min_y = surface_y;
+
+               if (surface_y > surface_max_y)
+                       surface_max_y = surface_y;
 
-               u32 i = vm->m_area.index(x, node_min.Y - 1, z);
+               u32 vi = vm->m_area.index(x, node_min.Y - 1, z);
                for (s16 y = node_min.Y - 1; y <= node_max.Y + 1; y++) {
-                       if (vm->m_data[i].getContent() == CONTENT_IGNORE) {
+                       if (vm->m_data[vi].getContent() == CONTENT_IGNORE) {
                                if (y <= surface_y)
-                                       vm->m_data[i] = n_stone;
+                                       vm->m_data[vi] = n_stone;
                                else if (y <= water_level)
-                                       vm->m_data[i] = n_water;
+                                       vm->m_data[vi] = n_water;
                                else
-                                       vm->m_data[i] = n_air;
+                                       vm->m_data[vi] = n_air;
                        }
-                       vm->m_area.add_y(em, i, 1);
+                       vm->m_area.add_y(em, vi, 1);
                }
        }
 
-       return stone_surface_max_y;
+       *stone_surface_min_y = surface_min_y;
+       *stone_surface_max_y = surface_max_y;
 }
 
 
-int MapgenV7::generateMountainTerrain(int ymax)
+int MapgenV7::generateMountainTerrain(s16 ymax)
 {
-       if (node_max.Y < 0)
-               return ymax;
+       noise_mountain->perlinMap3D(node_min.X, node_min.Y - 1, node_min.Z);
+       noise_mount_height->perlinMap2D(node_min.X, node_min.Z);
 
        MapNode n_stone(c_stone);
        u32 j = 0;
@@ -546,7 +554,7 @@ void MapgenV7::generateRidgeTerrain()
        MapNode n_water(c_water_source);
        MapNode n_air(CONTENT_AIR);
        u32 index = 0;
-       float width = 0.2; // TODO: figure out acceptable perlin noise values
+       float width = 0.2;
 
        for (s16 z = node_min.Z; z <= node_max.Z; z++)
        for (s16 y = node_min.Y - 1; y <= node_max.Y + 1; y++) {
@@ -578,88 +586,100 @@ void MapgenV7::generateRidgeTerrain()
 }
 
 
-bool MapgenV7::generateBiomes(float *heat_map, float *humidity_map)
+MgStoneType MapgenV7::generateBiomes(float *heat_map, float *humidity_map)
 {
-       if (node_max.Y < water_level)
-               return false;
-
        v3s16 em = vm->m_area.getExtent();
        u32 index = 0;
-       bool desert_stone = false;
+       MgStoneType stone_type = STONE;
 
        for (s16 z = node_min.Z; z <= node_max.Z; z++)
        for (s16 x = node_min.X; x <= node_max.X; x++, index++) {
                Biome *biome = NULL;
-               s16 dfiller = 0;
-               s16 y0_top = 0;
-               s16 y0_filler = 0;
-               s16 depth_water_top = 0;
+               u16 depth_top = 0;
+               u16 base_filler = 0;
+               u16 depth_water_top = 0;
+               u32 vi = vm->m_area.index(x, node_max.Y, z);
 
-               s16 nplaced = 0;
-               u32 i = vm->m_area.index(x, node_max.Y, z);
+               // Check node at base of mapchunk above, either a node of a previously
+               // generated mapchunk or if not, a node of overgenerated base terrain.
+               content_t c_above = vm->m_data[vi + em.X].getContent();
+               bool air_above = c_above == CONTENT_AIR;
+               bool water_above = c_above == c_water_source;
 
-               content_t c_above = vm->m_data[i + em.X].getContent();
-               bool have_air = c_above == CONTENT_AIR;
+               // If there is air or water above enable top/filler placement, otherwise force
+               // nplaced to stone level by setting a number exceeding any possible filler depth.
+               u16 nplaced = (air_above || water_above) ? 0 : U16_MAX;
 
                for (s16 y = node_max.Y; y >= node_min.Y; y--) {
-                       content_t c = vm->m_data[i].getContent();
+                       content_t c = vm->m_data[vi].getContent();
 
-                       if (c != CONTENT_IGNORE && c != CONTENT_AIR &&
-                                       (y == node_max.Y || have_air)) {
+                       // Biome is recalculated each time an upper surface is detected while
+                       // working down a column. The selected biome then remains in effect for
+                       // all nodes below until the next surface and biome recalculation.
+                       // Biome is recalculated:
+                       // 1. At the surface of stone below air or water.
+                       // 2. At the surface of water below air.
+                       // 3. When stone or water is detected but biome has not yet been calculated.
+                       if ((c == c_stone && (air_above || water_above || !biome)) ||
+                                       (c == c_water_source && (air_above || !biome))) {
                                biome = bmgr->getBiome(heat_map[index], humidity_map[index], y);
-                               dfiller = biome->depth_filler + noise_filler_depth->result[index];
-                               y0_top = biome->depth_top;
-                               y0_filler = biome->depth_top + dfiller;
+                               depth_top = biome->depth_top;
+                               base_filler = MYMAX(depth_top + biome->depth_filler
+                                               + noise_filler_depth->result[index], 0);
                                depth_water_top = biome->depth_water_top;
 
+                               // Detect stone type for dungeons during every biome calculation.
+                               // This is more efficient than detecting per-node and will not
+                               // miss any desert stone or sandstone biomes.
                                if (biome->c_stone == c_desert_stone)
-                                       desert_stone = true;
+                                       stone_type = DESERT_STONE;
+                               else if (biome->c_stone == c_sandstone)
+                                       stone_type = SANDSTONE;
                        }
 
-                       if (c == c_stone && have_air) {
-                               content_t c_below = vm->m_data[i - em.X].getContent();
-
-                               if (c_below != CONTENT_AIR && c_below != c_water_source) {
-                                       if (nplaced < y0_top) {
-                                               vm->m_data[i] = MapNode(biome->c_top);
-                                               nplaced++;
-                                       } else if (nplaced < y0_filler && nplaced >= y0_top) {
-                                               vm->m_data[i] = MapNode(biome->c_filler);
-                                               nplaced++;
-                                       } else if (c == c_stone) {
-                                               have_air = false;
-                                               nplaced  = 0;
-                                               vm->m_data[i] = MapNode(biome->c_stone);
-                                       } else {
-                                               have_air = false;
-                                               nplaced  = 0;
-                                       }
-                               } else if (c == c_stone) {
-                                       have_air = false;
-                                       nplaced = 0;
-                                       vm->m_data[i] = MapNode(biome->c_stone);
+                       if (c == c_stone) {
+                               content_t c_below = vm->m_data[vi - em.X].getContent();
+
+                               // If the node below isn't solid, make this node stone, so that
+                               // any top/filler nodes above are structurally supported.
+                               // This is done by aborting the cycle of top/filler placement
+                               // immediately by forcing nplaced to stone level.
+                               if (c_below == CONTENT_AIR || c_below == c_water_source)
+                                       nplaced = U16_MAX;
+
+                               if (nplaced < depth_top) {
+                                       vm->m_data[vi] = MapNode(biome->c_top);
+                                       nplaced++;
+                               } else if (nplaced < base_filler) {
+                                       vm->m_data[vi] = MapNode(biome->c_filler);
+                                       nplaced++;
+                               } else {
+                                       vm->m_data[vi] = MapNode(biome->c_stone);
                                }
-                       } else if (c == c_stone) {
-                               have_air = false;
-                               nplaced = 0;
-                               vm->m_data[i] = MapNode(biome->c_stone);
+
+                               air_above = false;
+                               water_above = false;
                        } else if (c == c_water_source) {
-                               have_air = true;
-                               nplaced = 0;
-                               if (y > water_level - depth_water_top)
-                                       vm->m_data[i] = MapNode(biome->c_water_top);
-                               else
-                                       vm->m_data[i] = MapNode(biome->c_water);
+                               vm->m_data[vi] = MapNode((y > (s32)(water_level - depth_water_top)) ?
+                                               biome->c_water_top : biome->c_water);
+                               nplaced = 0;  // Enable top/filler placement for next surface
+                               air_above = false;
+                               water_above = true;
                        } else if (c == CONTENT_AIR) {
-                               have_air = true;
-                               nplaced = 0;
+                               nplaced = 0;  // Enable top/filler placement for next surface
+                               air_above = true;
+                               water_above = false;
+                       } else {  // Possible various nodes overgenerated from neighbouring mapchunks
+                               nplaced = U16_MAX;  // Disable top/filler placement
+                               air_above = false;
+                               water_above = false;
                        }
 
-                       vm->m_area.add_y(em, i, -1);
+                       vm->m_area.add_y(em, vi, -1);
                }
        }
 
-       return desert_stone;
+       return stone_type;
 }
 
 
@@ -713,6 +733,113 @@ void MapgenV7::dustTopNodes()
 }
 
 
+void MapgenV7::generateCaves(s16 max_stone_y)
+{
+       if (max_stone_y < node_min.Y)
+               return;
+
+       noise_cave1->perlinMap3D(node_min.X, node_min.Y - 1, node_min.Z);
+       noise_cave2->perlinMap3D(node_min.X, node_min.Y - 1, node_min.Z);
+
+       v3s16 em = vm->m_area.getExtent();
+       u32 index2d = 0;
+
+       for (s16 z = node_min.Z; z <= node_max.Z; z++)
+       for (s16 x = node_min.X; x <= node_max.X; x++, index2d++) {
+               bool column_is_open = false;  // Is column open to overground
+               bool is_tunnel = false;  // Is tunnel or tunnel floor
+               // Indexes at column top (node_max.Y)
+               u32 vi = vm->m_area.index(x, node_max.Y, z);
+               u32 index3d = (z - node_min.Z) * zstride_1d + csize.Y * ystride +
+                       (x - node_min.X);
+               // Biome of column
+               Biome *biome = (Biome *)bmgr->getRaw(biomemap[index2d]);
+
+               // Don't excavate the overgenerated stone at node_max.Y + 1,
+               // this creates a 'roof' over the tunnel, preventing light in
+               // tunnels at mapchunk borders when generating mapchunks upwards.
+               // This 'roof' is removed when the mapchunk above is generated.
+               for (s16 y = node_max.Y; y >= node_min.Y - 1; y--,
+                               index3d -= ystride,
+                               vm->m_area.add_y(em, vi, -1)) {
+
+                       content_t c = vm->m_data[vi].getContent();
+                       if (c == CONTENT_AIR || c == biome->c_water_top ||
+                                       c == biome->c_water) {
+                               column_is_open = true;
+                               continue;
+                       }
+                       // Ground
+                       float d1 = contour(noise_cave1->result[index3d]);
+                       float d2 = contour(noise_cave2->result[index3d]);
+
+                       if (d1 * d2 > 0.3f && ndef->get(c).is_ground_content) {
+                               // In tunnel and ground content, excavate
+                               vm->m_data[vi] = MapNode(CONTENT_AIR);
+                               is_tunnel = true;
+                       } else {
+                               // Not in tunnel or not ground content
+                               if (is_tunnel && column_is_open &&
+                                               (c == biome->c_filler || c == biome->c_stone))
+                                       // Tunnel entrance floor
+                                       vm->m_data[vi] = MapNode(biome->c_top);
+
+                               column_is_open = false;
+                               is_tunnel = false;
+                       }
+               }
+       }
+
+       if (node_min.Y >= water_level)
+               return;
+
+       PseudoRandom ps(blockseed + 21343);
+       u32 bruises_count = ps.range(0, 2);
+       for (u32 i = 0; i < bruises_count; i++) {
+               CaveV7 cave(this, &ps);
+               cave.makeCave(node_min, node_max, max_stone_y);
+       }
+}
+
+
+///////////////////////////////////////////////////////////////
+
+
+#if 0
+void MapgenV7::carveRivers() {
+       MapNode n_air(CONTENT_AIR), n_water_source(c_water_source);
+       MapNode n_stone(c_stone);
+       u32 index = 0;
+
+       int river_depth = 4;
+
+       for (s16 z = node_min.Z; z <= node_max.Z; z++)
+       for (s16 x = node_min.X; x <= node_max.X; x++, index++) {
+               float terrain_mod  = noise_terrain_mod->result[index];
+               NoiseParams *np = noise_terrain_river->np;
+               np.persist = noise_terrain_persist->result[index];
+               float terrain_river = NoisePerlin2DNoTxfm(np, x, z, seed);
+               float height = terrain_river * (1 - abs(terrain_mod)) *
+                                               noise_terrain_river->np.scale;
+               height = log(height * height); //log(h^3) is pretty interesting for terrain
+
+               s16 y = heightmap[index];
+               if (height < 1.0 && y > river_depth &&
+                       y - river_depth >= node_min.Y && y <= node_max.Y) {
+
+                       for (s16 ry = y; ry != y - river_depth; ry--) {
+                               u32 vi = vm->m_area.index(x, ry, z);
+                               vm->m_data[vi] = n_air;
+                       }
+
+                       u32 vi = vm->m_area.index(x, y - river_depth, z);
+                       vm->m_data[vi] = n_water_source;
+               }
+       }
+}
+#endif
+
+
 #if 0
 void MapgenV7::addTopNodes()
 {
@@ -807,46 +934,3 @@ void MapgenV7::addTopNodes()
        }
 }
 #endif
-
-
-void MapgenV7::generateCaves(int max_stone_y)
-{
-       if (max_stone_y >= node_min.Y) {
-               u32 index   = 0;
-               u32 index2d = 0;
-
-               for (s16 z = node_min.Z; z <= node_max.Z; z++) {
-                       for (s16 y = node_min.Y - 1; y <= node_max.Y + 1; y++) {
-                               u32 i = vm->m_area.index(node_min.X, y, z);
-                               for (s16 x = node_min.X; x <= node_max.X;
-                                               x++, i++, index++, index2d++) {
-                                       float d1 = contour(noise_cave1->result[index]);
-                                       float d2 = contour(noise_cave2->result[index]);
-                                       if (d1 * d2 > 0.3) {
-                                               Biome *biome = (Biome *)bmgr->
-                                                                       getRaw(biomemap[index2d]);
-                                               content_t c = vm->m_data[i].getContent();
-                                               if (!ndef->get(c).is_ground_content ||
-                                                               c == CONTENT_AIR ||
-                                                               (y <= water_level &&
-                                                               c != biome->c_stone &&
-                                                               c != c_stone))
-                                                       continue;
-
-                                               vm->m_data[i] = MapNode(CONTENT_AIR);
-                                       }
-                               }
-                               index2d -= ystride;
-                       }
-                       index2d += ystride;
-               }
-       }
-
-       PseudoRandom ps(blockseed + 21343);
-       u32 bruises_count = (ps.range(1, 4) == 1) ? ps.range(1, 2) : 0;
-       for (u32 i = 0; i < bruises_count; i++) {
-               CaveV7 cave(this, &ps);
-               cave.makeCave(node_min, node_max, max_stone_y);
-       }
-}
-