Fix comments

[dragonfireclient.git] / src / mapgen / mapgen.cpp

diff --git a/src/mapgen/mapgen.cpp b/src/mapgen/mapgen.cpp
index 6ffe0ec1e1a7ebc40f6a5fffa31cfa67e9bec7dd..bdbbc01f76b774bc26074a524babde87391e07ee 100644 (file)
--- a/src/mapgen/mapgen.cpp
+++ b/src/mapgen/mapgen.cpp
@@ -56,7 +56,8 @@ FlagDesc flagdesc_mapgen[] = {
        {"dungeons",    MG_DUNGEONS},
        {"light",       MG_LIGHT},
        {"decorations", MG_DECORATIONS},
-       {NULL,       0}
+       {"biomes",      MG_BIOMES},
+       {NULL,          0}
 };
 
 FlagDesc flagdesc_gennotify[] = {
@@ -147,28 +148,28 @@ const char *Mapgen::getMapgenName(MapgenType mgtype)
 }
 
 
-Mapgen *Mapgen::createMapgen(MapgenType mgtype, int mgid,
-       MapgenParams *params, EmergeManager *emerge)
+Mapgen *Mapgen::createMapgen(MapgenType mgtype, MapgenParams *params,
+       EmergeManager *emerge)
 {
        switch (mgtype) {
        case MAPGEN_CARPATHIAN:
-               return new MapgenCarpathian(mgid, (MapgenCarpathianParams *)params, emerge);
+               return new MapgenCarpathian((MapgenCarpathianParams *)params, emerge);
        case MAPGEN_FLAT:
-               return new MapgenFlat(mgid, (MapgenFlatParams *)params, emerge);
+               return new MapgenFlat((MapgenFlatParams *)params, emerge);
        case MAPGEN_FRACTAL:
-               return new MapgenFractal(mgid, (MapgenFractalParams *)params, emerge);
+               return new MapgenFractal((MapgenFractalParams *)params, emerge);
        case MAPGEN_SINGLENODE:
-               return new MapgenSinglenode(mgid, (MapgenSinglenodeParams *)params, emerge);
+               return new MapgenSinglenode((MapgenSinglenodeParams *)params, emerge);
        case MAPGEN_V5:
-               return new MapgenV5(mgid, (MapgenV5Params *)params, emerge);
+               return new MapgenV5((MapgenV5Params *)params, emerge);
        case MAPGEN_V6:
-               return new MapgenV6(mgid, (MapgenV6Params *)params, emerge);
+               return new MapgenV6((MapgenV6Params *)params, emerge);
        case MAPGEN_V7:
-               return new MapgenV7(mgid, (MapgenV7Params *)params, emerge);
+               return new MapgenV7((MapgenV7Params *)params, emerge);
        case MAPGEN_VALLEYS:
-               return new MapgenValleys(mgid, (MapgenValleysParams *)params, emerge);
+               return new MapgenValleys((MapgenValleysParams *)params, emerge);
        default:
-               return NULL;
+               return nullptr;
        }
 }
 
@@ -193,7 +194,7 @@ MapgenParams *Mapgen::createMapgenParams(MapgenType mgtype)
        case MAPGEN_VALLEYS:
                return new MapgenValleysParams;
        default:
-               return NULL;
+               return nullptr;
        }
 }
 
@@ -654,6 +655,7 @@ void MapgenBasic::generateBiomes()
        for (s16 z = node_min.Z; z <= node_max.Z; z++)
        for (s16 x = node_min.X; x <= node_max.X; x++, index++) {
                Biome *biome = NULL;
+               biome_t water_biome_index = 0;
                u16 depth_top = 0;
                u16 base_filler = 0;
                u16 depth_water_top = 0;
@@ -692,9 +694,15 @@ void MapgenBasic::generateBiomes()
                                // (Re)calculate biome
                                biome = biomegen->getBiomeAtIndex(index, v3s16(x, y, z));
 
+                               // Add biome to biomemap at first stone surface detected
                                if (biomemap[index] == BIOME_NONE && is_stone_surface)
                                        biomemap[index] = biome->index;
 
+                               // Store biome of first water surface detected, as a fallback
+                               // entry for the biomemap.
+                               if (water_biome_index == 0 && is_water_surface)
+                                       water_biome_index = biome->index;
+
                                depth_top = biome->depth_top;
                                base_filler = MYMAX(depth_top +
                                        biome->depth_filler +
@@ -761,6 +769,11 @@ void MapgenBasic::generateBiomes()
 
                        VoxelArea::add_y(em, vi, -1);
                }
+               // If no stone surface detected in mapchunk column and a water surface
+               // biome fallback exists, add it to the biomemap. This avoids water
+               // surface decorations failing in deep water.
+               if (biomemap[index] == BIOME_NONE && water_biome_index != 0)
+                       biomemap[index] = water_biome_index;
        }
 }
 
@@ -780,6 +793,10 @@ void MapgenBasic::dustTopNodes()
                if (biome->c_dust == CONTENT_IGNORE)
                        continue;
 
+               // Check if mapchunk above has generated, if so, drop dust from 16 nodes
+               // above current mapchunk top, above decorations that will extend above
+               // the current mapchunk. If the mapchunk above has not generated, it
+               // will provide this required dust when it does.
                u32 vi = vm->m_area.index(x, full_node_max.Y, z);
                content_t c_full_max = vm->m_data[vi].getContent();
                s16 y_start;
@@ -808,14 +825,15 @@ void MapgenBasic::dustTopNodes()
 
                content_t c = vm->m_data[vi].getContent();
                NodeDrawType dtype = ndef->get(c).drawtype;
-               // Only place on walkable cubic non-liquid nodes
-               // Dust check needed due to vertical overgeneration
+               // Only place on cubic, walkable, non-dust nodes.
+               // Dust check needed due to avoid double layer of dust caused by
+               // dropping dust from 16 nodes above mapchunk top.
                if ((dtype == NDT_NORMAL ||
+                               dtype == NDT_ALLFACES ||
                                dtype == NDT_ALLFACES_OPTIONAL ||
-                               dtype == NDT_GLASSLIKE_FRAMED_OPTIONAL ||
                                dtype == NDT_GLASSLIKE ||
                                dtype == NDT_GLASSLIKE_FRAMED ||
-                               dtype == NDT_ALLFACES) &&
+                               dtype == NDT_GLASSLIKE_FRAMED_OPTIONAL) &&
                                ndef->get(c).walkable && c != biome->c_dust) {
                        VoxelArea::add_y(em, vi, 1);
                        vm->m_data[vi] = MapNode(biome->c_dust);