]> git.lizzy.rs Git - dragonfireclient.git/blobdiff - src/map.cpp
serverpackethandler: Minor log message fixes
[dragonfireclient.git] / src / map.cpp
index ba429f877b5af2b6632023ea678efd5dbb833a68..ef7eddb39ebd57f139dabe02c0f08f4c3c9821c6 100644 (file)
@@ -62,8 +62,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
        Map
 */
 
-Map::Map(std::ostream &dout, IGameDef *gamedef):
-       m_dout(dout),
+Map::Map(IGameDef *gamedef):
        m_gamedef(gamedef),
        m_nodedef(gamedef->ndef())
 {
@@ -144,7 +143,7 @@ bool Map::isNodeUnderground(v3s16 p)
 {
        v3s16 blockpos = getNodeBlockPos(p);
        MapBlock *block = getBlockNoCreateNoEx(blockpos);
-       return block && block->getIsUnderground(); 
+       return block && block->getIsUnderground();
 }
 
 bool Map::isValidPosition(v3s16 p)
@@ -179,7 +178,7 @@ void Map::setNode(v3s16 p, MapNode & n)
        v3s16 blockpos = getNodeBlockPos(p);
        MapBlock *block = getBlockNoCreate(blockpos);
        v3s16 relpos = p - blockpos*MAP_BLOCKSIZE;
-       // Never allow placing CONTENT_IGNORE, it fucks up stuff
+       // Never allow placing CONTENT_IGNORE, it causes problems
        if(n.getContent() == CONTENT_IGNORE){
                bool temp_bool;
                errorstream<<"Map::setNode(): Not allowing to place CONTENT_IGNORE"
@@ -478,6 +477,16 @@ void Map::PrintInfo(std::ostream &out)
 
 #define WATER_DROP_BOOST 4
 
+const static v3s16 liquid_6dirs[6] = {
+       // order: upper before same level before lower
+       v3s16( 0, 1, 0),
+       v3s16( 0, 0, 1),
+       v3s16( 1, 0, 0),
+       v3s16( 0, 0,-1),
+       v3s16(-1, 0, 0),
+       v3s16( 0,-1, 0)
+};
+
 enum NeighborType : u8 {
        NEIGHBOR_UPPER,
        NEIGHBOR_SAME_LEVEL,
@@ -568,7 +577,7 @@ void Map::transformLiquids(std::map<v3s16, MapBlock*> &modified_blocks,
                switch (liquid_type) {
                        case LIQUID_SOURCE:
                                liquid_level = LIQUID_LEVEL_SOURCE;
-                               liquid_kind = m_nodedef->getId(cf.liquid_alternative_flowing);
+                               liquid_kind = cf.liquid_alternative_flowing_id;
                                break;
                        case LIQUID_FLOWING:
                                liquid_level = (n0.param2 & LIQUID_LEVEL_MASK);
@@ -587,7 +596,6 @@ void Map::transformLiquids(std::map<v3s16, MapBlock*> &modified_blocks,
                /*
                        Collect information about the environment
                 */
-               const v3s16 *dirs = g_6dirs;
                NodeNeighbor sources[6]; // surrounding sources
                int num_sources = 0;
                NodeNeighbor flows[6]; // surrounding flowing liquid nodes
@@ -601,16 +609,16 @@ void Map::transformLiquids(std::map<v3s16, MapBlock*> &modified_blocks,
                for (u16 i = 0; i < 6; i++) {
                        NeighborType nt = NEIGHBOR_SAME_LEVEL;
                        switch (i) {
-                               case 1:
+                               case 0:
                                        nt = NEIGHBOR_UPPER;
                                        break;
-                               case 4:
+                               case 5:
                                        nt = NEIGHBOR_LOWER;
                                        break;
                                default:
                                        break;
                        }
-                       v3s16 npos = p0 + dirs[i];
+                       v3s16 npos = p0 + liquid_6dirs[i];
                        NodeNeighbor nb(getNode(npos), nt, npos);
                        const ContentFeatures &cfnb = m_nodedef->get(nb.n);
                        switch (m_nodedef->get(nb.n.getContent()).liquid_type) {
@@ -641,20 +649,24 @@ void Map::transformLiquids(std::map<v3s16, MapBlock*> &modified_blocks,
                                case LIQUID_SOURCE:
                                        // if this node is not (yet) of a liquid type, choose the first liquid type we encounter
                                        if (liquid_kind == CONTENT_AIR)
-                                               liquid_kind = m_nodedef->getId(cfnb.liquid_alternative_flowing);
-                                       if (m_nodedef->getId(cfnb.liquid_alternative_flowing) != liquid_kind) {
+                                               liquid_kind = cfnb.liquid_alternative_flowing_id;
+                                       if (cfnb.liquid_alternative_flowing_id != liquid_kind) {
                                                neutrals[num_neutrals++] = nb;
                                        } else {
                                                // Do not count bottom source, it will screw things up
-                                               if(dirs[i].Y != -1)
+                                               if(nt != NEIGHBOR_LOWER)
                                                        sources[num_sources++] = nb;
                                        }
                                        break;
                                case LIQUID_FLOWING:
-                                       // if this node is not (yet) of a liquid type, choose the first liquid type we encounter
-                                       if (liquid_kind == CONTENT_AIR)
-                                               liquid_kind = m_nodedef->getId(cfnb.liquid_alternative_flowing);
-                                       if (m_nodedef->getId(cfnb.liquid_alternative_flowing) != liquid_kind) {
+                                       if (nb.t != NEIGHBOR_SAME_LEVEL ||
+                                               (nb.n.param2 & LIQUID_FLOW_DOWN_MASK) != LIQUID_FLOW_DOWN_MASK) {
+                                               // if this node is not (yet) of a liquid type, choose the first liquid type we encounter
+                                               // but exclude falling liquids on the same level, they cannot flow here anyway
+                                               if (liquid_kind == CONTENT_AIR)
+                                                       liquid_kind = cfnb.liquid_alternative_flowing_id;
+                                       }
+                                       if (cfnb.liquid_alternative_flowing_id != liquid_kind) {
                                                neutrals[num_neutrals++] = nb;
                                        } else {
                                                flows[num_flows++] = nb;
@@ -680,7 +692,7 @@ void Map::transformLiquids(std::map<v3s16, MapBlock*> &modified_blocks,
                        // liquid_kind will be set to either the flowing alternative of the node (if it's a liquid)
                        // or the flowing alternative of the first of the surrounding sources (if it's air), so
                        // it's perfectly safe to use liquid_kind here to determine the new node content.
-                       new_node_content = m_nodedef->getId(m_nodedef->get(liquid_kind).liquid_alternative_source);
+                       new_node_content = m_nodedef->get(liquid_kind).liquid_alternative_source_id;
                } else if (num_sources >= 1 && sources[0].t != NEIGHBOR_LOWER) {
                        // liquid_kind is set properly, see above
                        max_node_level = new_node_level = LIQUID_LEVEL_MAX;
@@ -761,8 +773,8 @@ void Map::transformLiquids(std::map<v3s16, MapBlock*> &modified_blocks,
                        // set level to last 3 bits, flowing down bit to 4th bit
                        n0.param2 = (flowing_down ? LIQUID_FLOW_DOWN_MASK : 0x00) | (new_node_level & LIQUID_LEVEL_MASK);
                } else {
-                       // set the liquid level and flow bit to 0
-                       n0.param2 = ~(LIQUID_LEVEL_MASK | LIQUID_FLOW_DOWN_MASK);
+                       // set the liquid level and flow bits to 0
+                       n0.param2 &= ~(LIQUID_LEVEL_MASK | LIQUID_FLOW_DOWN_MASK);
                }
 
                // change the node.
@@ -1187,8 +1199,8 @@ bool Map::isBlockOccluded(MapBlock *block, v3s16 cam_pos_nodes)
        ServerMap
 */
 ServerMap::ServerMap(const std::string &savedir, IGameDef *gamedef,
-               EmergeManager *emerge):
-       Map(dout_server, gamedef),
+               EmergeManager *emerge, MetricsBackend *mb):
+       Map(gamedef),
        settings_mgr(g_settings, savedir + DIR_DELIM + "map_meta.txt"),
        m_emerge(emerge)
 {
@@ -1221,6 +1233,8 @@ ServerMap::ServerMap(const std::string &savedir, IGameDef *gamedef,
        m_savedir = savedir;
        m_map_saving_enabled = false;
 
+       m_save_time_counter = mb->addCounter("minetest_core_map_save_time", "Map save time (in nanoseconds)");
+
        try {
                // If directory exists, check contents and load if possible
                if (fs::PathExists(m_savedir)) {
@@ -1285,8 +1299,7 @@ ServerMap::~ServerMap()
                Close database if it was opened
        */
        delete dbase;
-       if (dbase_ro)
-               delete dbase_ro;
+       delete dbase_ro;
 
 #if 0
        /*
@@ -1313,11 +1326,6 @@ u64 ServerMap::getSeed()
        return getMapgenParams()->seed;
 }
 
-s16 ServerMap::getWaterLevel()
-{
-       return getMapgenParams()->water_level;
-}
-
 bool ServerMap::blockpos_over_mapgen_limit(v3s16 p)
 {
        const s16 mapgen_limit_bp = rangelim(
@@ -1718,59 +1726,6 @@ void ServerMap::updateVManip(v3s16 pos)
        vm->m_is_dirty = true;
 }
 
-s16 ServerMap::findGroundLevel(v2s16 p2d)
-{
-#if 0
-       /*
-               Uh, just do something random...
-       */
-       // Find existing map from top to down
-       s16 max=63;
-       s16 min=-64;
-       v3s16 p(p2d.X, max, p2d.Y);
-       for(; p.Y>min; p.Y--)
-       {
-               MapNode n = getNodeNoEx(p);
-               if(n.getContent() != CONTENT_IGNORE)
-                       break;
-       }
-       if(p.Y == min)
-               goto plan_b;
-       // If this node is not air, go to plan b
-       if(getNodeNoEx(p).getContent() != CONTENT_AIR)
-               goto plan_b;
-       // Search existing walkable and return it
-       for(; p.Y>min; p.Y--)
-       {
-               MapNode n = getNodeNoEx(p);
-               if(content_walkable(n.d) && n.getContent() != CONTENT_IGNORE)
-                       return p.Y;
-       }
-
-       // Move to plan b
-plan_b:
-#endif
-
-       /*
-               Determine from map generator noise functions
-       */
-
-       s16 level = m_emerge->getGroundLevelAtPoint(p2d);
-       return level;
-
-       //double level = base_rock_level_2d(m_seed, p2d) + AVERAGE_MUD_AMOUNT;
-       //return (s16)level;
-}
-
-void ServerMap::createDirs(const std::string &path)
-{
-       if (!fs::CreateAllDirs(path)) {
-               m_dout<<"ServerMap: Failed to create directory "
-                               <<"\""<<path<<"\""<<std::endl;
-               throw BaseException("ServerMap failed to create directory");
-       }
-}
-
 void ServerMap::save(ModifiedState save_level)
 {
        if (!m_map_saving_enabled) {
@@ -1778,6 +1733,8 @@ void ServerMap::save(ModifiedState save_level)
                return;
        }
 
+       u64 start_time = porting::getTimeNs();
+
        if(save_level == MOD_STATE_CLEAN)
                infostream<<"ServerMap: Saving whole map, this can take time."
                                <<std::endl;
@@ -1828,14 +1785,17 @@ void ServerMap::save(ModifiedState save_level)
        */
        if(save_level == MOD_STATE_CLEAN
                        || block_count != 0) {
-               infostream<<"ServerMap: Written: "
-                               <<block_count<<" block files"
-                               <<", "<<block_count_all<<" blocks in memory."
-                               <<std::endl;
+               infostream << "ServerMap: Written: "
+                               << block_count << " blocks"
+                               << ", " << block_count_all << " blocks in memory."
+                               << std::endl;
                PrintInfo(infostream); // ServerMap/ClientMap:
                infostream<<"Blocks modified by: "<<std::endl;
                modprofiler.print(infostream);
        }
+
+       auto end_time = porting::getTimeNs();
+       m_save_time_counter->increment(end_time - start_time);
 }
 
 void ServerMap::listAllLoadableBlocks(std::vector<v3s16> &dst)