-// error-pattern:yummy
-#![feature(box_syntax)]
-#![feature(rustc_private)]
-#![allow(unknown_lints, missing_docs_in_private_items)]
-
-extern crate clippy_lints;
-extern crate getopts;
-extern crate rustc;
-extern crate rustc_driver;
-extern crate rustc_errors;
-extern crate rustc_plugin;
-extern crate syntax;
-
-use rustc_driver::{driver, Compilation, CompilerCalls, RustcDefaultCalls};
-use rustc::session::{config, CompileIncomplete, Session};
-use rustc::session::config::{ErrorOutputType, Input};
-use std::collections::HashMap;
-use std::path::PathBuf;
-use std::process::{self, Command};
-use syntax::ast;
-use std::io::{self, Write};
-
-extern crate cargo_metadata;
-
-struct ClippyCompilerCalls {
- default: RustcDefaultCalls,
- run_lints: bool,
-}
-
-impl ClippyCompilerCalls {
- fn new(run_lints: bool) -> Self {
- Self {
- default: RustcDefaultCalls,
- run_lints: run_lints,
- }
- }
-}
-
-impl<'a> CompilerCalls<'a> for ClippyCompilerCalls {
- fn early_callback(
- &mut self,
- matches: &getopts::Matches,
- sopts: &config::Options,
- cfg: &ast::CrateConfig,
- descriptions: &rustc_errors::registry::Registry,
- output: ErrorOutputType,
- ) -> Compilation {
- self.default
- .early_callback(matches, sopts, cfg, descriptions, output)
- }
- fn no_input(
- &mut self,
- matches: &getopts::Matches,
- sopts: &config::Options,
- cfg: &ast::CrateConfig,
- odir: &Option<PathBuf>,
- ofile: &Option<PathBuf>,
- descriptions: &rustc_errors::registry::Registry,
- ) -> Option<(Input, Option<PathBuf>)> {
- self.default
- .no_input(matches, sopts, cfg, odir, ofile, descriptions)
- }
- fn late_callback(
- &mut self,
- matches: &getopts::Matches,
- sess: &Session,
- crate_stores: &rustc::middle::cstore::CrateStore,
- input: &Input,
- odir: &Option<PathBuf>,
- ofile: &Option<PathBuf>,
- ) -> Compilation {
- self.default
- .late_callback(matches, sess, crate_stores, input, odir, ofile)
- }
- fn build_controller(&mut self, sess: &Session, matches: &getopts::Matches) -> driver::CompileController<'a> {
- let mut control = self.default.build_controller(sess, matches);
-
- if self.run_lints {
- let old = std::mem::replace(&mut control.after_parse.callback, box |_| {});
- control.after_parse.callback = Box::new(move |state| {
- {
- let mut registry = rustc_plugin::registry::Registry::new(
- state.session,
- state
- .krate
- .as_ref()
- .expect(
- "at this compilation stage \
- the krate must be parsed",
- )
- .span,
- );
- registry.args_hidden = Some(Vec::new());
- clippy_lints::register_plugins(&mut registry);
-
- let rustc_plugin::registry::Registry {
- early_lint_passes,
- late_lint_passes,
- lint_groups,
- llvm_passes,
- attributes,
- ..
- } = registry;
- let sess = &state.session;
- let mut ls = sess.lint_store.borrow_mut();
- for pass in early_lint_passes {
- ls.register_early_pass(Some(sess), true, pass);
- }
- for pass in late_lint_passes {
- ls.register_late_pass(Some(sess), true, pass);
- }
-
- for (name, to) in lint_groups {
- ls.register_group(Some(sess), true, name, to);
- }
-
- sess.plugin_llvm_passes.borrow_mut().extend(llvm_passes);
- sess.plugin_attributes.borrow_mut().extend(attributes);
- }
- old(state);
- });
- }
-
- control
- }
-}
-
-use std::path::Path;
+use rustc_tools_util::*;
const CARGO_CLIPPY_HELP: &str = r#"Checks a package to catch common mistakes and improve your Rust code.
Common options:
-h, --help Print this message
- --features Features to compile for the package
-V, --version Print version info and exit
- --all Run over all packages in the current workspace
-Other options are the same as `cargo rustc`.
+Other options are the same as `cargo check`.
To allow or deny a lint from the command line you can use `cargo clippy --`
with:
-D --deny OPT Set lint denied
-F --forbid OPT Set lint forbidden
-The feature `cargo-clippy` is automatically defined for convenience. You can use
-it to allow or deny lints from the code, eg.:
+You can use tool lints to allow or deny lints from your code, eg.:
- #[cfg_attr(feature = "cargo-clippy", allow(needless_lifetimes))]
+ #[allow(clippy::needless_lifetimes)]
"#;
-#[allow(print_stdout)]
fn show_help() {
println!("{}", CARGO_CLIPPY_HELP);
}
-#[allow(print_stdout)]
fn show_version() {
- println!("{}", env!("CARGO_PKG_VERSION"));
+ let version_info = rustc_tools_util::get_version_info!();
+ println!("{}", version_info);
}
pub fn main() {
- use std::env;
-
- if env::var("CLIPPY_DOGFOOD").map(|_| true).unwrap_or(false) {
- panic!("yummy");
- }
-
// Check for version and help flags even when invoked as 'cargo-clippy'
if std::env::args().any(|a| a == "--help" || a == "-h") {
show_help();
return;
}
+
if std::env::args().any(|a| a == "--version" || a == "-V") {
show_version();
return;
}
- if "clippy" == std::env::args().nth(1).as_ref().expect("cargo-clippy should be called with at least one argument!") {
- // this arm is executed on the initial call to `cargo clippy`
-
- let manifest_path_arg = std::env::args()
- .skip(2)
- .find(|val| val.starts_with("--manifest-path="));
-
- let mut metadata = if let Ok(metadata) = cargo_metadata::metadata(manifest_path_arg.as_ref().map(AsRef::as_ref))
- {
- metadata
- } else {
- let _ = io::stderr().write_fmt(format_args!("error: Could not obtain cargo metadata.\n"));
- process::exit(101);
- };
-
- let manifest_path = manifest_path_arg.map(|arg| {
- Path::new(&arg["--manifest-path=".len()..])
- .canonicalize()
- .expect("manifest path could not be canonicalized")
- });
-
- let packages = if std::env::args().any(|a| a == "--all") {
- metadata.packages
- } else {
- let package_index = {
- if let Some(manifest_path) = manifest_path {
- metadata.packages.iter().position(|package| {
- let package_manifest_path = Path::new(&package.manifest_path)
- .canonicalize()
- .expect("package manifest path could not be canonicalized");
- package_manifest_path == manifest_path
- })
- } else {
- let package_manifest_paths: HashMap<_, _> = metadata
- .packages
- .iter()
- .enumerate()
- .map(|(i, package)| {
- let package_manifest_path = Path::new(&package.manifest_path)
- .parent()
- .expect("could not find parent directory of package manifest")
- .canonicalize()
- .expect("package directory cannot be canonicalized");
- (package_manifest_path, i)
- })
- .collect();
-
- let current_dir = std::env::current_dir()
- .expect("could not read current directory")
- .canonicalize()
- .expect("current directory cannot be canonicalized");
-
- let mut current_path: &Path = ¤t_dir;
-
- // This gets the most-recent parent (the one that takes the fewest `cd ..`s to
- // reach).
- loop {
- if let Some(&package_index) = package_manifest_paths.get(current_path) {
- break Some(package_index);
- } else {
- // We'll never reach the filesystem root, because to get to this point in the
- // code
- // the call to `cargo_metadata::metadata` must have succeeded. So it's okay to
- // unwrap the current path's parent.
- current_path = current_path
- .parent()
- .unwrap_or_else(|| panic!("could not find parent of path {}", current_path.display()));
- }
- }
- }
- }.expect("could not find matching package");
-
- vec![metadata.packages.remove(package_index)]
- };
-
- for package in packages {
- let manifest_path = package.manifest_path;
-
- for target in package.targets {
- let args = std::env::args()
- .skip(2)
- .filter(|a| a != "--all" && !a.starts_with("--manifest-path="));
-
- let args = std::iter::once(format!("--manifest-path={}", manifest_path)).chain(args);
- if let Some(first) = target.kind.get(0) {
- if target.kind.len() > 1 || first.ends_with("lib") {
- if let Err(code) = process(std::iter::once("--lib".to_owned()).chain(args)) {
- std::process::exit(code);
- }
- } else if ["bin", "example", "test", "bench"].contains(&&**first) {
- if let Err(code) = process(
- vec![format!("--{}", first), target.name]
- .into_iter()
- .chain(args),
- ) {
- std::process::exit(code);
- }
- }
- } else {
- panic!("badly formatted cargo metadata: target::kind is an empty array");
- }
- }
- }
- } else {
- // this arm is executed when cargo-clippy runs `cargo rustc` with the `RUSTC_WRAPPER`
- // env var set to itself
-
- let home = option_env!("RUSTUP_HOME").or(option_env!("MULTIRUST_HOME"));
- let toolchain = option_env!("RUSTUP_TOOLCHAIN").or(option_env!("MULTIRUST_TOOLCHAIN"));
- let sys_root = if let (Some(home), Some(toolchain)) = (home, toolchain) {
- format!("{}/toolchains/{}", home, toolchain)
- } else {
- option_env!("SYSROOT")
- .map(|s| s.to_owned())
- .or_else(|| {
- Command::new("rustc")
- .arg("--print")
- .arg("sysroot")
- .output()
- .ok()
- .and_then(|out| String::from_utf8(out.stdout).ok())
- .map(|s| s.trim().to_owned())
- })
- .expect(
- "need to specify SYSROOT env var during clippy compilation, or use rustup or multirust",
- )
- };
-
- rustc_driver::in_rustc_thread(|| {
- // Setting RUSTC_WRAPPER causes Cargo to pass 'rustc' as the first argument.
- // We're invoking the compiler programatically, so we ignore this/
- let orig_args: Vec<String> = env::args().skip(1).collect();
-
- // this conditional check for the --sysroot flag is there so users can call
- // `cargo-clippy` directly
- // without having to pass --sysroot or anything
- let mut args: Vec<String> = if orig_args.iter().any(|s| s == "--sysroot") {
- orig_args.clone()
- } else {
- orig_args.clone().into_iter()
- .chain(Some("--sysroot".to_owned()))
- .chain(Some(sys_root))
- .collect()
- };
-
- // this check ensures that dependencies are built but not linted and the final
- // crate is
- // linted but not built
- let clippy_enabled = orig_args.iter().any(|s| s == "--emit=metadata");
-
- if clippy_enabled {
- args.extend_from_slice(&["--cfg".to_owned(), r#"feature="cargo-clippy""#.to_owned()]);
- }
-
- let mut ccc = ClippyCompilerCalls::new(clippy_enabled);
- let (result, _) = rustc_driver::run_compiler(&args, &mut ccc, None, None);
- if let Err(CompileIncomplete::Errored(_)) = result {
- std::process::exit(1);
- }
- }).expect("rustc_thread failed");
+ if let Err(code) = process(std::env::args().skip(2)) {
+ std::process::exit(code);
}
}
-fn process<I>(old_args: I) -> Result<(), i32>
+fn process<I>(mut old_args: I) -> Result<(), i32>
where
I: Iterator<Item = String>,
{
- let mut args = vec!["rustc".to_owned()];
+ let mut args = vec!["check".to_owned()];
- let mut found_dashes = false;
- for arg in old_args {
- found_dashes |= arg == "--";
+ for arg in old_args.by_ref() {
+ if arg == "--" {
+ break;
+ }
args.push(arg);
}
- if !found_dashes {
- args.push("--".to_owned());
+
+ let clippy_args: String = old_args.map(|arg| format!("{}__CLIPPY_HACKERY__", arg)).collect();
+
+ let mut path = std::env::current_exe()
+ .expect("current executable path invalid")
+ .with_file_name("clippy-driver");
+ if cfg!(windows) {
+ path.set_extension("exe");
+ }
+
+ let target_dir = std::env::var_os("CLIPPY_DOGFOOD")
+ .map(|_| {
+ std::env::var_os("CARGO_MANIFEST_DIR").map_or_else(
+ || std::ffi::OsString::from("clippy_dogfood"),
+ |d| {
+ std::path::PathBuf::from(d)
+ .join("target")
+ .join("dogfood")
+ .into_os_string()
+ },
+ )
+ })
+ .map(|p| ("CARGO_TARGET_DIR", p));
+
+ // Run the dogfood tests directly on nightly cargo. This is required due
+ // to a bug in rustup.rs when running cargo on custom toolchains. See issue #3118.
+ if std::env::var_os("CLIPPY_DOGFOOD").is_some() && cfg!(windows) {
+ args.insert(0, "+nightly".to_string());
}
- args.push("--emit=metadata".to_owned());
- args.push("--cfg".to_owned());
- args.push(r#"feature="cargo-clippy""#.to_owned());
- let path = std::env::current_exe().expect("current executable path invalid");
let exit_status = std::process::Command::new("cargo")
.args(&args)
.env("RUSTC_WRAPPER", path)
+ .env("CLIPPY_ARGS", clippy_args)
+ .envs(target_dir)
.spawn()
.expect("could not run cargo")
.wait()
projects / rust.git / blobdiff