ExprUseVisitor::Delegate consume only when moving

[rust.git] / src / main.rs

diff --git a/src/main.rs b/src/main.rs
index 6a06ef7437c743dcb0ce3d3e61d2814a189f1aad..6bd4123ddeb45d92917f1dd043fa9d09ecf208de 100644 (file)
--- a/src/main.rs
+++ b/src/main.rs
@@ -1,10 +1,12 @@
 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
+// warn on lints, that are included in `rust-lang/rust`s bootstrap
+#![warn(rust_2018_idioms, unused_lifetimes)]
 
 use rustc_tools_util::VersionInfo;
 use std::env;
+use std::ffi::OsString;
 use std::path::PathBuf;
 use std::process::{self, Command};
-use std::ffi::OsString;
 
 const CARGO_CLIPPY_HELP: &str = r#"Checks a package to catch common mistakes and improve your Rust code.
 
@@ -57,69 +59,45 @@ pub fn main() {
 }
 
 struct ClippyCmd {
-    unstable_options: bool,
-    cmd: &'static str,
+    cargo_subcommand: &'static str,
     args: Vec<String>,
-    clippy_args: String
+    clippy_args: Vec<String>,
 }
 
-impl ClippyCmd
-{
+impl ClippyCmd {
     fn new<I>(mut old_args: I) -> Self
     where
         I: Iterator<Item = String>,
     {
-        let mut cmd = "check";
-        let mut unstable_options = false;
+        let mut cargo_subcommand = "check";
         let mut args = vec![];
 
         for arg in old_args.by_ref() {
             match arg.as_str() {
                 "--fix" => {
-                    cmd = "fix";
+                    cargo_subcommand = "fix";
                     continue;
-                }
+                },
                 "--" => break,
-                // Cover -Zunstable-options and -Z unstable-options
-                s if s.ends_with("unstable-options") => unstable_options = true,
-                _ => {}
+                _ => {},
             }
 
             args.push(arg);
         }
 
-        if cmd == "fix" && !unstable_options {
-            panic!("Usage of `--fix` requires `-Z unstable-options`");
+        let mut clippy_args: Vec<String> = old_args.collect();
+        if cargo_subcommand == "fix" && !clippy_args.iter().any(|arg| arg == "--no-deps") {
+            clippy_args.push("--no-deps".into());
         }
 
-        // Run the dogfood tests directly on nightly cargo. This is required due
-        // to a bug in rustup.rs when running cargo on custom toolchains. See issue #3118.
-        if env::var_os("CLIPPY_DOGFOOD").is_some() && cfg!(windows) {
-            args.insert(0, "+nightly".to_string());
-        }
-
-        let clippy_args: String =
-            old_args
-            .map(|arg| format!("{}__CLIPPY_HACKERY__", arg))
-            .collect();
-
         ClippyCmd {
-            unstable_options,
-            cmd,
+            cargo_subcommand,
             args,
             clippy_args,
         }
     }
 
-    fn path_env(&self) -> &'static str {
-        if self.unstable_options {
-            "RUSTC_WORKSPACE_WRAPPER"
-        } else {
-            "RUSTC_WRAPPER"
-        }
-    }
-
-    fn path(&self) -> PathBuf {
+    fn path() -> PathBuf {
         let mut path = env::current_exe()
             .expect("current executable path invalid")
             .with_file_name("clippy-driver");
@@ -147,27 +125,31 @@ fn target_dir() -> Option<(&'static str, OsString)> {
             .map(|p| ("CARGO_TARGET_DIR", p))
     }
 
-    fn to_std_cmd(self) -> Command {
+    fn into_std_cmd(self) -> Command {
         let mut cmd = Command::new("cargo");
+        let clippy_args: String = self
+            .clippy_args
+            .iter()
+            .map(|arg| format!("{}__CLIPPY_HACKERY__", arg))
+            .collect();
 
-        cmd.env(self.path_env(), self.path())
+        cmd.env("RUSTC_WORKSPACE_WRAPPER", Self::path())
             .envs(ClippyCmd::target_dir())
-            .env("CLIPPY_ARGS", self.clippy_args)
-            .arg(self.cmd)
+            .env("CLIPPY_ARGS", clippy_args)
+            .arg(self.cargo_subcommand)
             .args(&self.args);
 
         cmd
     }
 }
 
-
 fn process<I>(old_args: I) -> Result<(), i32>
 where
     I: Iterator<Item = String>,
 {
     let cmd = ClippyCmd::new(old_args);
 
-    let mut cmd = cmd.to_std_cmd();
+    let mut cmd = cmd.into_std_cmd();
 
     let exit_status = cmd
         .spawn()
@@ -181,3 +163,39 @@ fn process<I>(old_args: I) -> Result<(), i32>
         Err(exit_status.code().unwrap_or(-1))
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use super::ClippyCmd;
+
+    #[test]
+    fn fix() {
+        let args = "cargo clippy --fix".split_whitespace().map(ToString::to_string);
+        let cmd = ClippyCmd::new(args);
+        assert_eq!("fix", cmd.cargo_subcommand);
+        assert!(!cmd.args.iter().any(|arg| arg.ends_with("unstable-options")));
+    }
+
+    #[test]
+    fn fix_implies_no_deps() {
+        let args = "cargo clippy --fix".split_whitespace().map(ToString::to_string);
+        let cmd = ClippyCmd::new(args);
+        assert!(cmd.clippy_args.iter().any(|arg| arg == "--no-deps"));
+    }
+
+    #[test]
+    fn no_deps_not_duplicated_with_fix() {
+        let args = "cargo clippy --fix -- --no-deps"
+            .split_whitespace()
+            .map(ToString::to_string);
+        let cmd = ClippyCmd::new(args);
+        assert_eq!(cmd.clippy_args.iter().filter(|arg| *arg == "--no-deps").count(), 1);
+    }
+
+    #[test]
+    fn check() {
+        let args = "cargo clippy".split_whitespace().map(ToString::to_string);
+        let cmd = ClippyCmd::new(args);
+        assert_eq!("check", cmd.cargo_subcommand);
+    }
+}