Auto merge of #6362 - nico-abram:unnecessary_cast_dot_float_literal, r=ebroto

[rust.git] / src / main.rs

diff --git a/src/main.rs b/src/main.rs
index d82b0a3cf6b8cd199e79688a59c058a0bb097e6e..6739a4cf2245e5e16a7aed73e135edf3d9ab9424 100644 (file)
--- a/src/main.rs
+++ b/src/main.rs
@@ -1,10 +1,12 @@
 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
+// warn on lints, that are included in `rust-lang/rust`s bootstrap
+#![warn(rust_2018_idioms, unused_lifetimes)]
 
 use rustc_tools_util::VersionInfo;
 use std::env;
+use std::ffi::OsString;
 use std::path::PathBuf;
 use std::process::{self, Command};
-use std::ffi::OsString;
 
 const CARGO_CLIPPY_HELP: &str = r#"Checks a package to catch common mistakes and improve your Rust code.
 
@@ -60,11 +62,10 @@ struct ClippyCmd {
     unstable_options: bool,
     cargo_subcommand: &'static str,
     args: Vec<String>,
-    clippy_args: String
+    clippy_args: String,
 }
 
-impl ClippyCmd
-{
+impl ClippyCmd {
     fn new<I>(mut old_args: I) -> Self
     where
         I: Iterator<Item = String>,
@@ -78,11 +79,11 @@ fn new<I>(mut old_args: I) -> Self
                 "--fix" => {
                     cargo_subcommand = "fix";
                     continue;
-                }
+                },
                 "--" => break,
                 // Cover -Zunstable-options and -Z unstable-options
                 s if s.ends_with("unstable-options") => unstable_options = true,
-                _ => {}
+                _ => {},
             }
 
             args.push(arg);
@@ -98,10 +99,7 @@ fn new<I>(mut old_args: I) -> Self
             args.insert(0, "+nightly".to_string());
         }
 
-        let clippy_args: String =
-            old_args
-            .map(|arg| format!("{}__CLIPPY_HACKERY__", arg))
-            .collect();
+        let clippy_args: String = old_args.map(|arg| format!("{}__CLIPPY_HACKERY__", arg)).collect();
 
         ClippyCmd {
             unstable_options,
@@ -119,7 +117,7 @@ fn path_env(&self) -> &'static str {
         }
     }
 
-    fn path(&self) -> PathBuf {
+    fn path() -> PathBuf {
         let mut path = env::current_exe()
             .expect("current executable path invalid")
             .with_file_name("clippy-driver");
@@ -147,10 +145,10 @@ fn target_dir() -> Option<(&'static str, OsString)> {
             .map(|p| ("CARGO_TARGET_DIR", p))
     }
 
-    fn to_std_cmd(self) -> Command {
+    fn into_std_cmd(self) -> Command {
         let mut cmd = Command::new("cargo");
 
-        cmd.env(self.path_env(), self.path())
+        cmd.env(self.path_env(), Self::path())
             .envs(ClippyCmd::target_dir())
             .env("CLIPPY_ARGS", self.clippy_args)
             .arg(self.cargo_subcommand)
@@ -160,14 +158,13 @@ fn to_std_cmd(self) -> Command {
     }
 }
 
-
 fn process<I>(old_args: I) -> Result<(), i32>
 where
     I: Iterator<Item = String>,
 {
     let cmd = ClippyCmd::new(old_args);
 
-    let mut cmd = cmd.to_std_cmd();
+    let mut cmd = cmd.into_std_cmd();
 
     let exit_status = cmd
         .spawn()
@@ -184,7 +181,7 @@ fn process<I>(old_args: I) -> Result<(), i32>
 
 #[cfg(test)]
 mod tests {
-    use super::*;
+    use super::ClippyCmd;
 
     #[test]
     #[should_panic]
@@ -195,11 +192,13 @@ fn fix_without_unstable() {
 
     #[test]
     fn fix_unstable() {
-        let args = "cargo clippy --fix -Zunstable-options".split_whitespace().map(ToString::to_string);
+        let args = "cargo clippy --fix -Zunstable-options"
+            .split_whitespace()
+            .map(ToString::to_string);
         let cmd = ClippyCmd::new(args);
         assert_eq!("fix", cmd.cargo_subcommand);
         assert_eq!("RUSTC_WORKSPACE_WRAPPER", cmd.path_env());
-        assert!(cmd.args.iter().find(|arg| arg.ends_with("unstable-options")).is_some());
+        assert!(cmd.args.iter().any(|arg| arg.ends_with("unstable-options")));
     }
 
     #[test]
@@ -212,7 +211,9 @@ fn check() {
 
     #[test]
     fn check_unstable() {
-        let args = "cargo clippy -Zunstable-options".split_whitespace().map(ToString::to_string);
+        let args = "cargo clippy -Zunstable-options"
+            .split_whitespace()
+            .map(ToString::to_string);
         let cmd = ClippyCmd::new(args);
         assert_eq!("check", cmd.cargo_subcommand);
         assert_eq!("RUSTC_WORKSPACE_WRAPPER", cmd.path_env());