]> git.lizzy.rs Git - rust.git/blobdiff - src/libsyntax/ext/build.rs
Test fixes and rebase problems
[rust.git] / src / libsyntax / ext / build.rs
index 76d9f755d3c9f64a86e1f929721846420be6fe21..aa7e0d0eced8d3877618ae19fdc3d6b474a2d498 100644 (file)
@@ -9,7 +9,7 @@
 // except according to those terms.
 
 use abi::AbiSet;
-use ast::Ident;
+use ast::{P, Ident};
 use ast;
 use ast_util;
 use codemap::{Span, respan, dummy_sp};
@@ -38,31 +38,31 @@ pub trait AstBuilder {
     fn path_all(&self, sp: Span,
                 global: bool,
                 idents: ~[ast::Ident],
-                rp: Option<ast::Lifetime>,
-                types: ~[ast::Ty])
+                lifetimes: OptVec<ast::Lifetime>,
+                types: ~[P<ast::Ty>])
         -> ast::Path;
 
     // types
-    fn ty_mt(&self, ty: ast::Ty, mutbl: ast::Mutability) -> ast::mt;
+    fn ty_mt(&self, ty: P<ast::Ty>, mutbl: ast::Mutability) -> ast::mt;
 
-    fn ty(&self, span: Span, ty: ast::ty_) -> ast::Ty;
-    fn ty_path(&self, ast::Path, Option<OptVec<ast::TyParamBound>>) -> ast::Ty;
-    fn ty_ident(&self, span: Span, idents: ast::Ident) -> ast::Ty;
+    fn ty(&self, span: Span, ty: ast::ty_) -> P<ast::Ty>;
+    fn ty_path(&self, ast::Path, Option<OptVec<ast::TyParamBound>>) -> P<ast::Ty>;
+    fn ty_ident(&self, span: Span, idents: ast::Ident) -> P<ast::Ty>;
 
     fn ty_rptr(&self, span: Span,
-               ty: ast::Ty,
+               ty: P<ast::Ty>,
                lifetime: Option<ast::Lifetime>,
-               mutbl: ast::Mutability) -> ast::Ty;
-    fn ty_uniq(&self, span: Span, ty: ast::Ty) -> ast::Ty;
-    fn ty_box(&self, span: Span, ty: ast::Ty, mutbl: ast::Mutability) -> ast::Ty;
+               mutbl: ast::Mutability) -> P<ast::Ty>;
+    fn ty_uniq(&self, span: Span, ty: P<ast::Ty>) -> P<ast::Ty>;
+    fn ty_box(&self, span: Span, ty: P<ast::Ty>, mutbl: ast::Mutability) -> P<ast::Ty>;
 
-    fn ty_option(&self, ty: ast::Ty) -> ast::Ty;
-    fn ty_infer(&self, sp: Span) -> ast::Ty;
-    fn ty_nil(&self) -> ast::Ty;
+    fn ty_option(&self, ty: P<ast::Ty>) -> P<ast::Ty>;
+    fn ty_infer(&self, sp: Span) -> P<ast::Ty>;
+    fn ty_nil(&self) -> P<ast::Ty>;
 
-    fn ty_vars(&self, ty_params: &OptVec<ast::TyParam>) -> ~[ast::Ty];
-    fn ty_vars_global(&self, ty_params: &OptVec<ast::TyParam>) -> ~[ast::Ty];
-    fn ty_field_imm(&self, span: Span, name: Ident, ty: ast::Ty) -> ast::TypeField;
+    fn ty_vars(&self, ty_params: &OptVec<ast::TyParam>) -> ~[P<ast::Ty>];
+    fn ty_vars_global(&self, ty_params: &OptVec<ast::TyParam>) -> ~[P<ast::Ty>];
+    fn ty_field_imm(&self, span: Span, name: Ident, ty: P<ast::Ty>) -> ast::TypeField;
     fn strip_bounds(&self, bounds: &Generics) -> Generics;
 
     fn typaram(&self, id: ast::Ident, bounds: OptVec<ast::TyParamBound>) -> ast::TyParam;
@@ -78,17 +78,17 @@ fn stmt_let_typed(&self,
                       sp: Span,
                       mutbl: bool,
                       ident: ast::Ident,
-                      typ: ast::Ty,
+                      typ: P<ast::Ty>,
                       ex: @ast::Expr)
                       -> @ast::Stmt;
 
     // blocks
-    fn block(&self, span: Span, stmts: ~[@ast::Stmt], expr: Option<@ast::Expr>) -> ast::Block;
-    fn block_expr(&self, expr: @ast::Expr) -> ast::Block;
+    fn block(&self, span: Span, stmts: ~[@ast::Stmt], expr: Option<@ast::Expr>) -> P<ast::Block>;
+    fn block_expr(&self, expr: @ast::Expr) -> P<ast::Block>;
     fn block_all(&self, span: Span,
                  view_items: ~[ast::view_item],
                  stmts: ~[@ast::Stmt],
-                 expr: Option<@ast::Expr>) -> ast::Block;
+                 expr: Option<@ast::Expr>) -> P<ast::Block>;
 
     // expressions
     fn expr(&self, span: Span, node: ast::Expr_) -> @ast::Expr;
@@ -112,8 +112,8 @@ fn expr_call_global(&self, sp: Span, fn_path: ~[ast::Ident],
     fn expr_method_call(&self, span: Span,
                         expr: @ast::Expr, ident: ast::Ident,
                         args: ~[@ast::Expr]) -> @ast::Expr;
-    fn expr_block(&self, b: ast::Block) -> @ast::Expr;
-    fn expr_cast(&self, sp: Span, expr: @ast::Expr, ty: ast::Ty) -> @ast::Expr;
+    fn expr_block(&self, b: P<ast::Block>) -> @ast::Expr;
+    fn expr_cast(&self, sp: Span, expr: @ast::Expr, ty: P<ast::Ty>) -> @ast::Expr;
 
     fn field_imm(&self, span: Span, name: Ident, e: @ast::Expr) -> ast::Field;
     fn expr_struct(&self, span: Span, path: ast::Path, fields: ~[ast::Field]) -> @ast::Expr;
@@ -159,11 +159,12 @@ fn pat_struct(&self, span: Span,
     fn expr_if(&self, span: Span,
                cond: @ast::Expr, then: @ast::Expr, els: Option<@ast::Expr>) -> @ast::Expr;
 
-    fn lambda_fn_decl(&self, span: Span, fn_decl: ast::fn_decl, blk: ast::Block) -> @ast::Expr;
+    fn lambda_fn_decl(&self, span: Span,
+                      fn_decl: P<ast::fn_decl>, blk: P<ast::Block>) -> @ast::Expr;
 
-    fn lambda(&self, span: Span, ids: ~[ast::Ident], blk: ast::Block) -> @ast::Expr;
-    fn lambda0(&self, span: Span, blk: ast::Block) -> @ast::Expr;
-    fn lambda1(&self, span: Span, blk: ast::Block, ident: ast::Ident) -> @ast::Expr;
+    fn lambda(&self, span: Span, ids: ~[ast::Ident], blk: P<ast::Block>) -> @ast::Expr;
+    fn lambda0(&self, span: Span, blk: P<ast::Block>) -> @ast::Expr;
+    fn lambda1(&self, span: Span, blk: P<ast::Block>, ident: ast::Ident) -> @ast::Expr;
 
     fn lambda_expr(&self, span: Span, ids: ~[ast::Ident], blk: @ast::Expr) -> @ast::Expr;
     fn lambda_expr_0(&self, span: Span, expr: @ast::Expr) -> @ast::Expr;
@@ -177,25 +178,25 @@ fn expr_if(&self, span: Span,
     fn item(&self, span: Span,
             name: Ident, attrs: ~[ast::Attribute], node: ast::item_) -> @ast::item;
 
-    fn arg(&self, span: Span, name: Ident, ty: ast::Ty) -> ast::arg;
+    fn arg(&self, span: Span, name: Ident, ty: P<ast::Ty>) -> ast::arg;
     // XXX unused self
-    fn fn_decl(&self, inputs: ~[ast::arg], output: ast::Ty) -> ast::fn_decl;
+    fn fn_decl(&self, inputs: ~[ast::arg], output: P<ast::Ty>) -> P<ast::fn_decl>;
 
     fn item_fn_poly(&self,
                     span: Span,
                     name: Ident,
                     inputs: ~[ast::arg],
-                    output: ast::Ty,
+                    output: P<ast::Ty>,
                     generics: Generics,
-                    body: ast::Block) -> @ast::item;
+                    body: P<ast::Block>) -> @ast::item;
     fn item_fn(&self,
                span: Span,
                name: Ident,
                inputs: ~[ast::arg],
-               output: ast::Ty,
-               body: ast::Block) -> @ast::item;
+               output: P<ast::Ty>,
+               body: P<ast::Block>) -> @ast::item;
 
-    fn variant(&self, span: Span, name: Ident, tys: ~[ast::Ty]) -> ast::variant;
+    fn variant(&self, span: Span, name: Ident, tys: ~[P<ast::Ty>]) -> ast::variant;
     fn item_enum_poly(&self,
                       span: Span,
                       name: Ident,
@@ -217,9 +218,9 @@ fn item_mod(&self, span: Span,
     fn item_ty_poly(&self,
                     span: Span,
                     name: Ident,
-                    ty: ast::Ty,
+                    ty: P<ast::Ty>,
                     generics: Generics) -> @ast::item;
-    fn item_ty(&self, span: Span, name: Ident, ty: ast::Ty) -> @ast::item;
+    fn item_ty(&self, span: Span, name: Ident, ty: P<ast::Ty>) -> @ast::item;
 
     fn attribute(&self, sp: Span, mi: @ast::MetaItem) -> ast::Attribute;
 
@@ -237,33 +238,33 @@ fn view_use_glob(&self, sp: Span,
 
 impl AstBuilder for @ExtCtxt {
     fn path(&self, span: Span, strs: ~[ast::Ident]) -> ast::Path {
-        self.path_all(span, false, strs, None, ~[])
+        self.path_all(span, false, strs, opt_vec::Empty, ~[])
     }
     fn path_ident(&self, span: Span, id: ast::Ident) -> ast::Path {
         self.path(span, ~[id])
     }
     fn path_global(&self, span: Span, strs: ~[ast::Ident]) -> ast::Path {
-        self.path_all(span, true, strs, None, ~[])
+        self.path_all(span, true, strs, opt_vec::Empty, ~[])
     }
     fn path_all(&self,
                 sp: Span,
                 global: bool,
                 mut idents: ~[ast::Ident],
-                rp: Option<ast::Lifetime>,
-                types: ~[ast::Ty])
+                lifetimes: OptVec<ast::Lifetime>,
+                types: ~[P<ast::Ty>])
                 -> ast::Path {
         let last_identifier = idents.pop();
         let mut segments: ~[ast::PathSegment] = idents.move_iter()
                                                       .map(|ident| {
             ast::PathSegment {
                 identifier: ident,
-                lifetime: None,
+                lifetimes: opt_vec::Empty,
                 types: opt_vec::Empty,
             }
         }).collect();
         segments.push(ast::PathSegment {
             identifier: last_identifier,
-            lifetime: rp,
+            lifetimes: lifetimes,
             types: opt_vec::from(types),
         });
         ast::Path {
@@ -273,23 +274,23 @@ fn path_all(&self,
         }
     }
 
-    fn ty_mt(&self, ty: ast::Ty, mutbl: ast::Mutability) -> ast::mt {
+    fn ty_mt(&self, ty: P<ast::Ty>, mutbl: ast::Mutability) -> ast::mt {
         ast::mt {
-            ty: ~ty,
+            ty: ty,
             mutbl: mutbl
         }
     }
 
-    fn ty(&self, span: Span, ty: ast::ty_) -> ast::Ty {
-        ast::Ty {
+    fn ty(&self, span: Span, ty: ast::ty_) -> P<ast::Ty> {
+        P(ast::Ty {
             id: ast::DUMMY_NODE_ID,
             span: span,
             node: ty
-        }
+        })
     }
 
     fn ty_path(&self, path: ast::Path, bounds: Option<OptVec<ast::TyParamBound>>)
-              -> ast::Ty {
+              -> P<ast::Ty> {
         self.ty(path.span,
                 ast::ty_path(path, bounds, ast::DUMMY_NODE_ID))
     }
@@ -297,28 +298,28 @@ fn ty_path(&self, path: ast::Path, bounds: Option<OptVec<ast::TyParamBound>>)
     // Might need to take bounds as an argument in the future, if you ever want
     // to generate a bounded existential trait type.
     fn ty_ident(&self, span: Span, ident: ast::Ident)
-        -> ast::Ty {
+        -> P<ast::Ty> {
         self.ty_path(self.path_ident(span, ident), None)
     }
 
     fn ty_rptr(&self,
                span: Span,
-               ty: ast::Ty,
+               ty: P<ast::Ty>,
                lifetime: Option<ast::Lifetime>,
                mutbl: ast::Mutability)
-        -> ast::Ty {
+        -> P<ast::Ty> {
         self.ty(span,
                 ast::ty_rptr(lifetime, self.ty_mt(ty, mutbl)))
     }
-    fn ty_uniq(&self, span: Span, ty: ast::Ty) -> ast::Ty {
-        self.ty(span, ast::ty_uniq(self.ty_mt(ty, ast::MutImmutable)))
+    fn ty_uniq(&self, span: Span, ty: P<ast::Ty>) -> P<ast::Ty> {
+        self.ty(span, ast::ty_uniq(ty))
     }
     fn ty_box(&self, span: Span,
-                 ty: ast::Ty, mutbl: ast::Mutability) -> ast::Ty {
+                 ty: P<ast::Ty>, mutbl: ast::Mutability) -> P<ast::Ty> {
         self.ty(span, ast::ty_box(self.ty_mt(ty, mutbl)))
     }
 
-    fn ty_option(&self, ty: ast::Ty) -> ast::Ty {
+    fn ty_option(&self, ty: P<ast::Ty>) -> P<ast::Ty> {
         self.ty_path(
             self.path_all(dummy_sp(),
                           true,
@@ -327,28 +328,28 @@ fn ty_option(&self, ty: ast::Ty) -> ast::Ty {
                               self.ident_of("option"),
                               self.ident_of("Option")
                           ],
-                          None,
+                          opt_vec::Empty,
                           ~[ ty ]), None)
     }
 
-    fn ty_field_imm(&self, span: Span, name: Ident, ty: ast::Ty) -> ast::TypeField {
+    fn ty_field_imm(&self, span: Span, name: Ident, ty: P<ast::Ty>) -> ast::TypeField {
         ast::TypeField {
             ident: name,
-            mt: ast::mt { ty: ~ty, mutbl: ast::MutImmutable },
+            mt: ast::mt { ty: ty, mutbl: ast::MutImmutable },
             span: span,
         }
     }
 
-    fn ty_infer(&self, span: Span) -> ast::Ty {
+    fn ty_infer(&self, span: Span) -> P<ast::Ty> {
         self.ty(span, ast::ty_infer)
     }
 
-    fn ty_nil(&self) -> ast::Ty {
-        ast::Ty {
+    fn ty_nil(&self) -> P<ast::Ty> {
+        P(ast::Ty {
             id: ast::DUMMY_NODE_ID,
             node: ast::ty_nil,
             span: dummy_sp(),
-        }
+        })
     }
 
     fn typaram(&self, id: ast::Ident, bounds: OptVec<ast::TyParamBound>) -> ast::TyParam {
@@ -358,21 +359,21 @@ fn typaram(&self, id: ast::Ident, bounds: OptVec<ast::TyParamBound>) -> ast::TyP
     // these are strange, and probably shouldn't be used outside of
     // pipes. Specifically, the global version possible generates
     // incorrect code.
-    fn ty_vars(&self, ty_params: &OptVec<ast::TyParam>) -> ~[ast::Ty] {
+    fn ty_vars(&self, ty_params: &OptVec<ast::TyParam>) -> ~[P<ast::Ty>] {
         opt_vec::take_vec(
             ty_params.map(|p| self.ty_ident(dummy_sp(), p.ident)))
     }
 
-    fn ty_vars_global(&self, ty_params: &OptVec<ast::TyParam>) -> ~[ast::Ty] {
+    fn ty_vars_global(&self, ty_params: &OptVec<ast::TyParam>) -> ~[P<ast::Ty>] {
         opt_vec::take_vec(
             ty_params.map(|p| self.ty_path(
                 self.path_global(dummy_sp(), ~[p.ident]), None)))
     }
 
     fn strip_bounds(&self, generics: &Generics) -> Generics {
-        let new_params = do generics.ty_params.map |ty_param| {
+        let new_params = generics.ty_params.map(|ty_param| {
             ast::TyParam { bounds: opt_vec::Empty, ..*ty_param }
-        };
+        });
         Generics {
             ty_params: new_params,
             .. (*generics).clone()
@@ -419,7 +420,7 @@ fn stmt_let_typed(&self,
                       sp: Span,
                       mutbl: bool,
                       ident: ast::Ident,
-                      typ: ast::Ty,
+                      typ: P<ast::Ty>,
                       ex: @ast::Expr)
                       -> @ast::Stmt {
         let pat = if mutbl {
@@ -438,26 +439,26 @@ fn stmt_let_typed(&self,
         @respan(sp, ast::StmtDecl(@decl, ast::DUMMY_NODE_ID))
     }
 
-    fn block(&self, span: Span, stmts: ~[@ast::Stmt], expr: Option<@Expr>) -> ast::Block {
+    fn block(&self, span: Span, stmts: ~[@ast::Stmt], expr: Option<@Expr>) -> P<ast::Block> {
         self.block_all(span, ~[], stmts, expr)
     }
 
-    fn block_expr(&self, expr: @ast::Expr) -> ast::Block {
+    fn block_expr(&self, expr: @ast::Expr) -> P<ast::Block> {
         self.block_all(expr.span, ~[], ~[], Some(expr))
     }
     fn block_all(&self,
                  span: Span,
                  view_items: ~[ast::view_item],
                  stmts: ~[@ast::Stmt],
-                 expr: Option<@ast::Expr>) -> ast::Block {
-           ast::Block {
+                 expr: Option<@ast::Expr>) -> P<ast::Block> {
+            P(ast::Block {
                view_items: view_items,
                stmts: stmts,
                expr: expr,
                id: ast::DUMMY_NODE_ID,
                rules: ast::DefaultBlock,
                span: span,
-           }
+            })
     }
 
     fn expr(&self, span: Span, node: ast::Expr_) -> @ast::Expr {
@@ -525,7 +526,7 @@ fn expr_method_call(&self, span: Span,
         self.expr(span,
                   ast::ExprMethodCall(ast::DUMMY_NODE_ID, expr, ident, ~[], args, ast::NoSugar))
     }
-    fn expr_block(&self, b: ast::Block) -> @ast::Expr {
+    fn expr_block(&self, b: P<ast::Block>) -> @ast::Expr {
         self.expr(b.span, ast::ExprBlock(b))
     }
     fn field_imm(&self, span: Span, name: Ident, e: @ast::Expr) -> ast::Field {
@@ -575,7 +576,7 @@ fn expr_str_uniq(&self, sp: Span, s: @str) -> @ast::Expr {
     }
 
 
-    fn expr_cast(&self, sp: Span, expr: @ast::Expr, ty: ast::Ty) -> @ast::Expr {
+    fn expr_cast(&self, sp: Span, expr: @ast::Expr, ty: P<ast::Ty>) -> @ast::Expr {
         self.expr(sp, ast::ExprCast(expr, ty))
     }
 
@@ -605,7 +606,6 @@ fn expr_fail(&self, span: Span, msg: @str) -> @ast::Expr {
             ~[
                 self.ident_of("std"),
                 self.ident_of("rt"),
-                self.ident_of("task"),
                 self.ident_of("begin_unwind"),
             ],
             ~[
@@ -673,23 +673,24 @@ fn expr_if(&self, span: Span,
         self.expr(span, ast::ExprIf(cond, self.block_expr(then), els))
     }
 
-    fn lambda_fn_decl(&self, span: Span, fn_decl: ast::fn_decl, blk: ast::Block) -> @ast::Expr {
+    fn lambda_fn_decl(&self, span: Span,
+                      fn_decl: P<ast::fn_decl>, blk: P<ast::Block>) -> @ast::Expr {
         self.expr(span, ast::ExprFnBlock(fn_decl, blk))
     }
-    fn lambda(&self, span: Span, ids: ~[ast::Ident], blk: ast::Block) -> @ast::Expr {
+    fn lambda(&self, span: Span, ids: ~[ast::Ident], blk: P<ast::Block>) -> @ast::Expr {
         let fn_decl = self.fn_decl(
             ids.map(|id| self.arg(span, *id, self.ty_infer(span))),
             self.ty_infer(span));
 
         self.expr(span, ast::ExprFnBlock(fn_decl, blk))
     }
-    fn lambda0(&self, _span: Span, blk: ast::Block) -> @ast::Expr {
-        let blk_e = self.expr(blk.span, ast::ExprBlock(blk.clone()));
+    fn lambda0(&self, _span: Span, blk: P<ast::Block>) -> @ast::Expr {
+        let blk_e = self.expr(blk.span, ast::ExprBlock(blk));
         quote_expr!(*self, || $blk_e )
     }
 
-    fn lambda1(&self, _span: Span, blk: ast::Block, ident: ast::Ident) -> @ast::Expr {
-        let blk_e = self.expr(blk.span, ast::ExprBlock(blk.clone()));
+    fn lambda1(&self, _span: Span, blk: P<ast::Block>, ident: ast::Ident) -> @ast::Expr {
+        let blk_e = self.expr(blk.span, ast::ExprBlock(blk));
         quote_expr!(*self, |$ident| $blk_e )
     }
 
@@ -713,7 +714,7 @@ fn lambda_stmts_1(&self, span: Span, stmts: ~[@ast::Stmt], ident: ast::Ident) ->
         self.lambda1(span, self.block(span, stmts, None), ident)
     }
 
-    fn arg(&self, span: Span, ident: ast::Ident, ty: ast::Ty) -> ast::arg {
+    fn arg(&self, span: Span, ident: ast::Ident, ty: P<ast::Ty>) -> ast::arg {
         let arg_pat = self.pat_ident(span, ident);
         ast::arg {
             ty: ty,
@@ -723,12 +724,13 @@ fn arg(&self, span: Span, ident: ast::Ident, ty: ast::Ty) -> ast::arg {
     }
 
     // XXX unused self
-    fn fn_decl(&self, inputs: ~[ast::arg], output: ast::Ty) -> ast::fn_decl {
-        ast::fn_decl {
+    fn fn_decl(&self, inputs: ~[ast::arg], output: P<ast::Ty>) -> P<ast::fn_decl> {
+        P(ast::fn_decl {
             inputs: inputs,
             output: output,
             cf: ast::return_val,
-        }
+            variadic: false
+        })
     }
 
     fn item(&self, span: Span,
@@ -747,9 +749,9 @@ fn item_fn_poly(&self,
                     span: Span,
                     name: Ident,
                     inputs: ~[ast::arg],
-                    output: ast::Ty,
+                    output: P<ast::Ty>,
                     generics: Generics,
-                    body: ast::Block) -> @ast::item {
+                    body: P<ast::Block>) -> @ast::item {
         self.item(span,
                   name,
                   ~[],
@@ -764,8 +766,8 @@ fn item_fn(&self,
                span: Span,
                name: Ident,
                inputs: ~[ast::arg],
-               output: ast::Ty,
-               body: ast::Block
+               output: P<ast::Ty>,
+               body: P<ast::Block>
               ) -> @ast::item {
         self.item_fn_poly(
             span,
@@ -776,7 +778,7 @@ fn item_fn(&self,
             body)
     }
 
-    fn variant(&self, span: Span, name: Ident, tys: ~[ast::Ty]) -> ast::variant {
+    fn variant(&self, span: Span, name: Ident, tys: ~[P<ast::Ty>]) -> ast::variant {
         let args = tys.move_iter().map(|ty| {
             ast::variant_arg { ty: ty, id: ast::DUMMY_NODE_ID }
         }).collect();
@@ -843,12 +845,12 @@ fn item_mod(&self, span: Span, name: Ident,
         )
     }
 
-    fn item_ty_poly(&self, span: Span, name: Ident, ty: ast::Ty,
+    fn item_ty_poly(&self, span: Span, name: Ident, ty: P<ast::Ty>,
                     generics: Generics) -> @ast::item {
         self.item(span, name, ~[], ast::item_ty(ty, generics))
     }
 
-    fn item_ty(&self, span: Span, name: Ident, ty: ast::Ty) -> @ast::item {
+    fn item_ty(&self, span: Span, name: Ident, ty: P<ast::Ty>) -> @ast::item {
         self.item_ty_poly(span, name, ty, ast_util::empty_generics())
     }
 
@@ -882,9 +884,9 @@ fn view_use(&self, sp: Span,
 
     fn view_use_list(&self, sp: Span, vis: ast::visibility,
                      path: ~[ast::Ident], imports: &[ast::Ident]) -> ast::view_item {
-        let imports = do imports.map |id| {
+        let imports = imports.map(|id| {
             respan(sp, ast::path_list_ident_ { name: *id, id: ast::DUMMY_NODE_ID })
-        };
+        });
 
         self.view_use(sp, vis,
                       ~[@respan(sp,