use rustc::cfg;
use rustc::ty::subst::Substs;
use rustc::ty::{self, Ty};
-use rustc::traits::{self, Reveal};
+use rustc::traits;
use rustc::hir::map as hir_map;
use util::nodemap::NodeSet;
use lint::{LateContext, LintContext, LintArray};
if def.has_dtor(cx.tcx) {
return;
}
- let param_env = ty::ParamEnv::empty(Reveal::UserFacing);
+ let param_env = ty::ParamEnv::empty();
if !ty.moves_by_default(cx.tcx, param_env, item.span) {
return;
}
}
}
-declare_lint! {
- pub ILLEGAL_FLOATING_POINT_LITERAL_PATTERN,
- Warn,
- "floating-point literals cannot be used in patterns"
-}
-
-/// Checks for floating point literals in patterns.
-#[derive(Clone)]
-pub struct IllegalFloatLiteralPattern;
-
-impl LintPass for IllegalFloatLiteralPattern {
- fn get_lints(&self) -> LintArray {
- lint_array!(ILLEGAL_FLOATING_POINT_LITERAL_PATTERN)
- }
-}
-
-fn fl_lit_check_expr(cx: &EarlyContext, expr: &ast::Expr) {
- use self::ast::{ExprKind, LitKind};
- match expr.node {
- ExprKind::Lit(ref l) => {
- match l.node {
- LitKind::FloatUnsuffixed(..) |
- LitKind::Float(..) => {
- cx.span_lint(ILLEGAL_FLOATING_POINT_LITERAL_PATTERN,
- l.span,
- "floating-point literals cannot be used in patterns");
- },
- _ => (),
- }
- }
- // These may occur in patterns
- // and can maybe contain float literals
- ExprKind::Unary(_, ref f) => fl_lit_check_expr(cx, f),
- // Other kinds of exprs can't occur in patterns so we don't have to check them
- // (ast_validation will emit an error if they occur)
- _ => (),
- }
-}
-
-impl EarlyLintPass for IllegalFloatLiteralPattern {
- fn check_pat(&mut self, cx: &EarlyContext, pat: &ast::Pat) {
- use self::ast::PatKind;
- pat.walk(&mut |p| {
- match p.node {
- // Wildcard patterns and paths are uninteresting for the lint
- PatKind::Wild |
- PatKind::Path(..) => (),
-
- // The walk logic recurses inside these
- PatKind::Ident(..) |
- PatKind::Struct(..) |
- PatKind::Tuple(..) |
- PatKind::TupleStruct(..) |
- PatKind::Ref(..) |
- PatKind::Box(..) |
- PatKind::Paren(..) |
- PatKind::Slice(..) => (),
-
- // Extract the expressions and check them
- PatKind::Lit(ref e) => fl_lit_check_expr(cx, e),
- PatKind::Range(ref st, ref en, _) => {
- fl_lit_check_expr(cx, st);
- fl_lit_check_expr(cx, en);
- },
-
- PatKind::Mac(_) => bug!("lint must run post-expansion"),
- }
- true
- });
- }
-}
-
declare_lint! {
pub UNUSED_DOC_COMMENT,
Warn,
pub struct UnreachablePub;
declare_lint! {
- UNREACHABLE_PUB,
+ pub UNREACHABLE_PUB,
Allow,
"`pub` items not reachable from crate root"
}
self.perform_lint(cx, "item", impl_item.id, &impl_item.vis, impl_item.span, false);
}
}
+
+/// Lint for trait and lifetime bounds that are (accidentally) accepted by the parser, but
+/// ignored later.
+
+pub struct IgnoredGenericBounds;
+
+declare_lint! {
+ IGNORED_GENERIC_BOUNDS,
+ Warn,
+ "these generic bounds are ignored"
+}
+
+impl LintPass for IgnoredGenericBounds {
+ fn get_lints(&self) -> LintArray {
+ lint_array!(IGNORED_GENERIC_BOUNDS)
+ }
+}
+
+impl EarlyLintPass for IgnoredGenericBounds {
+ fn check_item(&mut self, cx: &EarlyContext, item: &ast::Item) {
+ let type_alias_generics = match item.node {
+ ast::ItemKind::Ty(_, ref generics) => generics,
+ _ => return,
+ };
+ // There must not be a where clause
+ if !type_alias_generics.where_clause.predicates.is_empty() {
+ let spans : Vec<_> = type_alias_generics.where_clause.predicates.iter()
+ .map(|pred| pred.span()).collect();
+ cx.span_lint(IGNORED_GENERIC_BOUNDS, spans,
+ "where clauses are ignored in type aliases");
+ }
+ // The parameters must not have bounds
+ for param in type_alias_generics.params.iter() {
+ let spans : Vec<_> = match param {
+ &ast::GenericParam::Lifetime(ref l) => l.bounds.iter().map(|b| b.span).collect(),
+ &ast::GenericParam::Type(ref ty) => ty.bounds.iter().map(|b| b.span()).collect(),
+ };
+ if !spans.is_empty() {
+ cx.span_lint(
+ IGNORED_GENERIC_BOUNDS,
+ spans,
+ "bounds on generic parameters are ignored in type aliases",
+ );
+ }
+ }
+ }
+}