]> git.lizzy.rs Git - dragonfireclient.git/blobdiff - src/guiKeyChangeMenu.cpp
Make use of safe file writing in auth handler (fixes #6576)
[dragonfireclient.git] / src / guiKeyChangeMenu.cpp
index 4569f3d9dcf519cdb55e4ec0dfb363b1b724f7e5..53677a57bfb4a2f6fed7bd42d78658427d7c0cea 100644 (file)
@@ -22,7 +22,6 @@
 #include "guiKeyChangeMenu.h"
 #include "debug.h"
 #include "serialization.h"
-#include "main.h"
 #include <string>
 #include <IGUICheckBox.h>
 #include <IGUIEditBox.h>
 #include "settings.h"
 #include <algorithm>
 
+#include "mainmenumanager.h"  // for g_gamecallback
+
 #define KMaxButtonPerColumns 12
 
+extern MainGameCallback *g_gamecallback;
+
 enum
 {
        GUI_ID_BACK_BUTTON = 101, GUI_ID_ABORT_BUTTON, GUI_ID_SCROLL_BAR,
@@ -47,14 +50,30 @@ enum
        GUI_ID_KEY_FAST_BUTTON,
        GUI_ID_KEY_JUMP_BUTTON,
        GUI_ID_KEY_NOCLIP_BUTTON,
+       GUI_ID_KEY_CINEMATIC_BUTTON,
        GUI_ID_KEY_CHAT_BUTTON,
        GUI_ID_KEY_CMD_BUTTON,
+       GUI_ID_KEY_CMD_LOCAL_BUTTON,
        GUI_ID_KEY_CONSOLE_BUTTON,
        GUI_ID_KEY_SNEAK_BUTTON,
        GUI_ID_KEY_DROP_BUTTON,
        GUI_ID_KEY_INVENTORY_BUTTON,
-       GUI_ID_KEY_DUMP_BUTTON,
+       GUI_ID_KEY_HOTBAR_PREV_BUTTON,
+       GUI_ID_KEY_HOTBAR_NEXT_BUTTON,
+       GUI_ID_KEY_MUTE_BUTTON,
+       GUI_ID_KEY_DEC_VOLUME_BUTTON,
+       GUI_ID_KEY_INC_VOLUME_BUTTON,
        GUI_ID_KEY_RANGE_BUTTON,
+       GUI_ID_KEY_ZOOM_BUTTON,
+       GUI_ID_KEY_CAMERA_BUTTON,
+       GUI_ID_KEY_MINIMAP_BUTTON,
+       GUI_ID_KEY_SCREENSHOT_BUTTON,
+       GUI_ID_KEY_CHATLOG_BUTTON,
+       GUI_ID_KEY_HUD_BUTTON,
+       GUI_ID_KEY_FOG_BUTTON,
+       GUI_ID_KEY_DEC_RANGE_BUTTON,
+       GUI_ID_KEY_INC_RANGE_BUTTON,
+       GUI_ID_KEY_AUTOFWD_BUTTON,
        // other
        GUI_ID_CB_AUX1_DESCENDS,
        GUI_ID_CB_DOUBLETAP_JUMP,
@@ -64,40 +83,40 @@ GUIKeyChangeMenu::GUIKeyChangeMenu(gui::IGUIEnvironment* env,
                                gui::IGUIElement* parent, s32 id, IMenuManager *menumgr) :
 GUIModalMenu(env, parent, id, menumgr)
 {
-       shift_down = false;
-       activeKey = -1;
-       this->key_used_text = NULL;
        init_keys();
-       for(size_t i=0; i<key_settings.size(); i++)
-               this->key_used.push_back(key_settings.at(i)->key);
+       for (key_setting *ks : key_settings)
+               key_used.push_back(ks->key);
 }
 
 GUIKeyChangeMenu::~GUIKeyChangeMenu()
 {
        removeChildren();
+
+       for (key_setting *ks : key_settings) {
+               delete[] ks->button_name;
+               delete ks;
+       }
+       key_settings.clear();
 }
 
 void GUIKeyChangeMenu::removeChildren()
 {
        const core::list<gui::IGUIElement*> &children = getChildren();
        core::list<gui::IGUIElement*> children_copy;
-       for (core::list<gui::IGUIElement*>::ConstIterator i = children.begin(); i
-                != children.end(); i++)
-       {
-               children_copy.push_back(*i);
+       for (gui::IGUIElement*i : children) {
+               children_copy.push_back(i);
        }
-       for (core::list<gui::IGUIElement*>::Iterator i = children_copy.begin(); i
-                != children_copy.end(); i++)
-       {
-               (*i)->remove();
+
+       for (gui::IGUIElement *i : children_copy) {
+               i->remove();
        }
 }
 
 void GUIKeyChangeMenu::regenerateGui(v2u32 screensize)
 {
        removeChildren();
-       v2s32 size(620, 430);
-       
+       v2s32 size(745, 430);
+
        core::rect < s32 > rect(screensize.X / 2 - size.X / 2,
                                                        screensize.Y / 2 - size.Y / 2, screensize.X / 2 + size.X / 2,
                                                        screensize.Y / 2 + size.Y / 2);
@@ -106,13 +125,15 @@ void GUIKeyChangeMenu::regenerateGui(v2u32 screensize)
        recalculateAbsolutePosition(false);
 
        v2s32 topleft(0, 0);
-       changeCtype("");
+
        {
                core::rect < s32 > rect(0, 0, 600, 40);
                rect += topleft + v2s32(25, 3);
                //gui::IGUIStaticText *t =
-               Environment->addStaticText(wgettext("Keybindings. (If this menu screws up, remove stuff from minetest.conf)"),
+               const wchar_t *text = wgettext("Keybindings. (If this menu screws up, remove stuff from minetest.conf)");
+               Environment->addStaticText(text,
                                                                   rect, false, true, this, -1);
+               delete[] text;
                //t->setTextAlignment(gui::EGUIA_CENTER, gui::EGUIA_UPPERLEFT);
        }
 
@@ -124,62 +145,72 @@ void GUIKeyChangeMenu::regenerateGui(v2u32 screensize)
        {
                key_setting *k = key_settings.at(i);
                {
-                       core::rect < s32 > rect(0, 0, 100, 20);
+                       core::rect < s32 > rect(0, 0, 150, 20);
                        rect += topleft + v2s32(offset.X, offset.Y);
                        Environment->addStaticText(k->button_name, rect, false, true, this, -1);
                }
 
                {
                        core::rect < s32 > rect(0, 0, 100, 30);
-                       rect += topleft + v2s32(offset.X + 105, offset.Y - 5);
-                       k->button = Environment->addButton(rect, this, k->id, wgettext(k->key.name()));
+                       rect += topleft + v2s32(offset.X + 120, offset.Y - 5);
+                       const wchar_t *text = wgettext(k->key.name());
+                       k->button = Environment->addButton(rect, this, k->id, text);
+                       delete[] text;
                }
-               if(i + 1 == KMaxButtonPerColumns)
-                       offset = v2s32(250, 60);
-               else
+               if ((i + 1) % KMaxButtonPerColumns == 0) {
+                       offset.X += 230;
+                       offset.Y = 60;
+               } else {
                        offset += v2s32(0, 25);
+               }
        }
-       
+
        {
-               s32 option_x = offset.X + 10;
-               s32 option_y = offset.Y;
+               s32 option_x = offset.X;
+               s32 option_y = offset.Y + 5;
                u32 option_w = 180;
                {
                        core::rect<s32> rect(0, 0, option_w, 30);
                        rect += topleft + v2s32(option_x, option_y);
+                       const wchar_t *text = wgettext("\"Special\" = climb down");
                        Environment->addCheckBox(g_settings->getBool("aux1_descends"), rect, this,
-                                       GUI_ID_CB_AUX1_DESCENDS, wgettext("\"Use\" = climb down"));
+                                       GUI_ID_CB_AUX1_DESCENDS, text);
+                       delete[] text;
                }
                offset += v2s32(0, 25);
        }
 
        {
-               s32 option_x = offset.X + 10;
-               s32 option_y = offset.Y;
-               u32 option_w = 220;
+               s32 option_x = offset.X;
+               s32 option_y = offset.Y + 5;
+               u32 option_w = 280;
                {
                        core::rect<s32> rect(0, 0, option_w, 30);
                        rect += topleft + v2s32(option_x, option_y);
+                       const wchar_t *text = wgettext("Double tap \"jump\" to toggle fly");
                        Environment->addCheckBox(g_settings->getBool("doubletap_jump"), rect, this,
-                                       GUI_ID_CB_DOUBLETAP_JUMP, wgettext("Double tap \"jump\" to toggle fly"));
+                                       GUI_ID_CB_DOUBLETAP_JUMP, text);
+                       delete[] text;
                }
                offset += v2s32(0, 25);
        }
 
        {
                core::rect < s32 > rect(0, 0, 100, 30);
-               rect += topleft + v2s32(size.X - 100 - 20, size.Y - 40);
+               rect += topleft + v2s32(size.X / 2 - 105, size.Y - 40);
+               const wchar_t *text =  wgettext("Save");
                Environment->addButton(rect, this, GUI_ID_BACK_BUTTON,
-                                                          wgettext("Save"));
+                                text);
+               delete[] text;
        }
        {
                core::rect < s32 > rect(0, 0, 100, 30);
-               rect += topleft + v2s32(size.X - 100 - 20 - 100 - 20, size.Y - 40);
+               rect += topleft + v2s32(size.X / 2 + 5, size.Y - 40);
+               const wchar_t *text = wgettext("Cancel");
                Environment->addButton(rect, this, GUI_ID_ABORT_BUTTON,
-                                                          wgettext("Cancel"));
+                               text);
+               delete[] text;
        }
-       changeCtype("C");
-       
 }
 
 void GUIKeyChangeMenu::drawMenu()
@@ -192,7 +223,7 @@ void GUIKeyChangeMenu::drawMenu()
        video::SColor bgcolor(140, 0, 0, 0);
 
        {
-               core::rect < s32 > rect(0, 0, 620, 620);
+               core::rect < s32 > rect(0, 0, 745, 620);
                rect += AbsoluteRect.UpperLeftCorner;
                driver->draw2DRectangle(bgcolor, rect, &AbsoluteClippingRect);
        }
@@ -202,11 +233,10 @@ void GUIKeyChangeMenu::drawMenu()
 
 bool GUIKeyChangeMenu::acceptInput()
 {
-       for(size_t i = 0; i < key_settings.size(); i++)
-       {
-               key_setting *k = key_settings.at(i);
+       for (key_setting *k : key_settings) {
                g_settings->set(k->setting_name, k->key.sym());
        }
+
        {
                gui::IGUIElement *e = getElementFromId(GUI_ID_CB_AUX1_DESCENDS);
                if(e != NULL && e->getType() == gui::EGUIET_CHECK_BOX)
@@ -217,7 +247,11 @@ bool GUIKeyChangeMenu::acceptInput()
                if(e != NULL && e->getType() == gui::EGUIET_CHECK_BOX)
                        g_settings->setBool("doubletap_jump", ((gui::IGUICheckBox*)e)->isChecked());
        }
+
        clearKeyCache();
+
+       g_gamecallback->signalKeyConfigChange();
+
        return true;
 }
 
@@ -225,12 +259,11 @@ bool GUIKeyChangeMenu::resetMenu()
 {
        if (activeKey >= 0)
        {
-               for(size_t i = 0; i < key_settings.size(); i++)
-               {
-                       key_setting *k = key_settings.at(i);
-                       if(k->id == activeKey)
-                       {
-                               k->button->setText(wgettext(k->key.name()));
+               for (key_setting *k : key_settings) {
+                       if (k->id == activeKey) {
+                               const wchar_t *text = wgettext(k->key.name());
+                               k->button->setText(text);
+                               delete[] text;
                                break;
                        }
                }
@@ -242,12 +275,11 @@ bool GUIKeyChangeMenu::resetMenu()
 bool GUIKeyChangeMenu::OnEvent(const SEvent& event)
 {
        if (event.EventType == EET_KEY_INPUT_EVENT && activeKey >= 0
-               && event.KeyInput.PressedDown)
-       {
-               changeCtype("");
+                       && event.KeyInput.PressedDown) {
+
                bool prefer_character = shift_down;
                KeyPress kp(event.KeyInput, prefer_character);
-               
+
                bool shift_went_down = false;
                if(!shift_down &&
                                (event.KeyInput.Key == irr::KEY_SHIFT ||
@@ -266,41 +298,45 @@ bool GUIKeyChangeMenu::OnEvent(const SEvent& event)
                {
                        core::rect < s32 > rect(0, 0, 600, 40);
                        rect += v2s32(0, 0) + v2s32(25, 30);
-                       this->key_used_text = Environment->addStaticText(wgettext("Key already in use"),
-                                                                       rect, false, true, this, -1);
+                       const wchar_t *text = wgettext("Key already in use");
+                       this->key_used_text = Environment->addStaticText(text,
+                                       rect, false, true, this, -1);
+                       delete[] text;
                        //infostream << "Key already in use" << std::endl;
                }
 
                // But go on
                {
-                       key_setting *k=NULL;
-                       for(size_t i = 0; i < key_settings.size(); i++)
-                       {
-                               if(key_settings.at(i)->id == activeKey)
-                               {
-                                       k = key_settings.at(i);
+                       key_setting *k = NULL;
+                       for (key_setting *ks : key_settings) {
+                               if (ks->id == activeKey) {
+                                       k = ks;
                                        break;
                                }
                        }
-                       assert(k);
+                       FATAL_ERROR_IF(k == NULL, "Key setting not found");
                        k->key = kp;
-                       k->button->setText(wgettext(k->key.name()));
+                       const wchar_t *text = wgettext(k->key.name());
+                       k->button->setText(text);
+                       delete[] text;
 
                        this->key_used.push_back(kp);
 
-                       changeCtype("C");
                        // Allow characters made with shift
                        if(shift_went_down){
                                shift_down = true;
                                return false;
-                       }else{
-                               activeKey = -1;
-                               return true;
                        }
+
+                       activeKey = -1;
+                       return true;
                }
-       }
-       if (event.EventType == EET_GUI_EVENT)
-       {
+       } else if (event.EventType == EET_KEY_INPUT_EVENT && activeKey < 0
+                       && event.KeyInput.PressedDown
+                       && event.KeyInput.Key == irr::KEY_ESCAPE) {
+               quitMenu();
+               return true;
+       } else if (event.EventType == EET_GUI_EVENT) {
                if (event.GUIEvent.EventType == gui::EGET_ELEMENT_FOCUS_LOST
                        && isVisible())
                {
@@ -314,12 +350,6 @@ bool GUIKeyChangeMenu::OnEvent(const SEvent& event)
                }
                if (event.GUIEvent.EventType == gui::EGET_BUTTON_CLICKED)
                {
-                       if(event.GUIEvent.Caller->getID() != GUI_ID_BACK_BUTTON &&
-                          event.GUIEvent.Caller->getID() != GUI_ID_ABORT_BUTTON)
-                       {
-                               changeCtype("");
-                       }
-
                        switch (event.GUIEvent.Caller->getID())
                        {
                                case GUI_ID_BACK_BUTTON: //back
@@ -331,37 +361,37 @@ bool GUIKeyChangeMenu::OnEvent(const SEvent& event)
                                        return true;
                                default:
                                        key_setting *k = NULL;
-                                       for(size_t i = 0; i < key_settings.size(); i++)
-                                       {
-                                               if(key_settings.at(i)->id == event.GUIEvent.Caller->getID())
-                                               {
-                                                       k = key_settings.at(i);
+
+                                       for (key_setting *ks : key_settings) {
+                                               if (ks->id == event.GUIEvent.Caller->getID()) {
+                                                       k = ks;
                                                        break;
                                                }
                                        }
-                                       assert(k);
+                                       FATAL_ERROR_IF(k == NULL, "Key setting not found");
 
                                        resetMenu();
                                        shift_down = false;
                                        activeKey = event.GUIEvent.Caller->getID();
-                                       k->button->setText(wgettext("press key"));
+                                       const wchar_t *text = wgettext("press key");
+                                       k->button->setText(text);
+                                       delete[] text;
                                        this->key_used.erase(std::remove(this->key_used.begin(),
                                                        this->key_used.end(), k->key), this->key_used.end());
                                        break;
                        }
                        Environment->setFocus(this);
-                       //Buttons
-                       changeCtype("C");
                }
        }
        return Parent ? Parent->OnEvent(event) : false;
 }
 
-void GUIKeyChangeMenu::add_key(int id, std::string button_name, std::string setting_name)
+void GUIKeyChangeMenu::add_key(int id, const wchar_t *button_name, const std::string &setting_name)
 {
        key_setting *k = new key_setting;
        k->id = id;
-       k->button_name = wgettext(button_name.c_str());
+
+       k->button_name = button_name;
        k->setting_name = setting_name;
        k->key = getKeySetting(k->setting_name.c_str());
        key_settings.push_back(k);
@@ -369,21 +399,38 @@ void GUIKeyChangeMenu::add_key(int id, std::string button_name, std::string sett
 
 void GUIKeyChangeMenu::init_keys()
 {
-       this->add_key(GUI_ID_KEY_FORWARD_BUTTON, gettext("Forward"), "keymap_forward");
-       this->add_key(GUI_ID_KEY_BACKWARD_BUTTON, gettext("Backward"), "keymap_backward");
-       this->add_key(GUI_ID_KEY_LEFT_BUTTON, gettext("Left"), "keymap_left");
-       this->add_key(GUI_ID_KEY_RIGHT_BUTTON, gettext("Right"), "keymap_right");
-       this->add_key(GUI_ID_KEY_USE_BUTTON, gettext("Use"), "keymap_special1");
-       this->add_key(GUI_ID_KEY_JUMP_BUTTON, gettext("Jump"), "keymap_jump");
-       this->add_key(GUI_ID_KEY_SNEAK_BUTTON, gettext("Sneak"), "keymap_sneak");
-       this->add_key(GUI_ID_KEY_DROP_BUTTON, gettext("Drop"), "keymap_drop");
-       this->add_key(GUI_ID_KEY_INVENTORY_BUTTON, gettext("Inventory"), "keymap_inventory");
-       this->add_key(GUI_ID_KEY_CHAT_BUTTON, gettext("Chat"), "keymap_chat");
-       this->add_key(GUI_ID_KEY_CMD_BUTTON, gettext("Command"), "keymap_cmd");
-       this->add_key(GUI_ID_KEY_CONSOLE_BUTTON, gettext("Console"), "keymap_console");
-       this->add_key(GUI_ID_KEY_FLY_BUTTON, gettext("Toggle fly"), "keymap_freemove");
-       this->add_key(GUI_ID_KEY_FAST_BUTTON, gettext("Toggle fast"), "keymap_fastmove");
-       this->add_key(GUI_ID_KEY_NOCLIP_BUTTON, gettext("Toggle noclip"), "keymap_noclip");
-       this->add_key(GUI_ID_KEY_RANGE_BUTTON, gettext("Range select"), "keymap_rangeselect");
-       this->add_key(GUI_ID_KEY_DUMP_BUTTON, gettext("Print stacks"), "keymap_print_debug_stacks");
+       this->add_key(GUI_ID_KEY_FORWARD_BUTTON,   wgettext("Forward"),          "keymap_forward");
+       this->add_key(GUI_ID_KEY_BACKWARD_BUTTON,  wgettext("Backward"),         "keymap_backward");
+       this->add_key(GUI_ID_KEY_LEFT_BUTTON,      wgettext("Left"),             "keymap_left");
+       this->add_key(GUI_ID_KEY_RIGHT_BUTTON,     wgettext("Right"),            "keymap_right");
+       this->add_key(GUI_ID_KEY_USE_BUTTON,       wgettext("Special"),          "keymap_special1");
+       this->add_key(GUI_ID_KEY_JUMP_BUTTON,      wgettext("Jump"),             "keymap_jump");
+       this->add_key(GUI_ID_KEY_SNEAK_BUTTON,     wgettext("Sneak"),            "keymap_sneak");
+       this->add_key(GUI_ID_KEY_DROP_BUTTON,      wgettext("Drop"),             "keymap_drop");
+       this->add_key(GUI_ID_KEY_INVENTORY_BUTTON, wgettext("Inventory"),        "keymap_inventory");
+       this->add_key(GUI_ID_KEY_HOTBAR_PREV_BUTTON,wgettext("Prev. item"),      "keymap_hotbar_previous");
+       this->add_key(GUI_ID_KEY_HOTBAR_NEXT_BUTTON,wgettext("Next item"),       "keymap_hotbar_next");
+       this->add_key(GUI_ID_KEY_ZOOM_BUTTON,      wgettext("Zoom"),             "keymap_zoom");
+       this->add_key(GUI_ID_KEY_CAMERA_BUTTON,    wgettext("Change camera"),    "keymap_camera_mode");
+       this->add_key(GUI_ID_KEY_CINEMATIC_BUTTON, wgettext("Toggle Cinematic"), "keymap_cinematic");
+       this->add_key(GUI_ID_KEY_MINIMAP_BUTTON,   wgettext("Toggle minimap"),   "keymap_minimap");
+       this->add_key(GUI_ID_KEY_FLY_BUTTON,       wgettext("Toggle fly"),       "keymap_freemove");
+       this->add_key(GUI_ID_KEY_FAST_BUTTON,      wgettext("Toggle fast"),      "keymap_fastmove");
+       this->add_key(GUI_ID_KEY_NOCLIP_BUTTON,    wgettext("Toggle noclip"),    "keymap_noclip");
+       this->add_key(GUI_ID_KEY_MUTE_BUTTON,      wgettext("Mute"),             "keymap_mute");
+       this->add_key(GUI_ID_KEY_DEC_VOLUME_BUTTON,wgettext("Dec. volume"),      "keymap_decrease_volume");
+       this->add_key(GUI_ID_KEY_INC_VOLUME_BUTTON,wgettext("Inc. volume"),      "keymap_increase_volume");
+       this->add_key(GUI_ID_KEY_AUTOFWD_BUTTON,   wgettext("Autoforward"),      "keymap_autoforward");
+       this->add_key(GUI_ID_KEY_CHAT_BUTTON,      wgettext("Chat"),             "keymap_chat");
+       this->add_key(GUI_ID_KEY_SCREENSHOT_BUTTON,wgettext("Screenshot"),       "keymap_screenshot");
+       this->add_key(GUI_ID_KEY_RANGE_BUTTON,     wgettext("Range select"),     "keymap_rangeselect");
+       this->add_key(GUI_ID_KEY_DEC_RANGE_BUTTON, wgettext("Dec. range"),       "keymap_decrease_viewing_range_min");
+       this->add_key(GUI_ID_KEY_INC_RANGE_BUTTON, wgettext("Inc. range"),       "keymap_increase_viewing_range_min");
+       this->add_key(GUI_ID_KEY_CONSOLE_BUTTON,   wgettext("Console"),          "keymap_console");
+       this->add_key(GUI_ID_KEY_CMD_BUTTON,       wgettext("Command"),          "keymap_cmd");
+       this->add_key(GUI_ID_KEY_CMD_LOCAL_BUTTON, wgettext("Local command"),    "keymap_cmd_local");
+       this->add_key(GUI_ID_KEY_HUD_BUTTON,       wgettext("Toggle HUD"),       "keymap_toggle_hud");
+       this->add_key(GUI_ID_KEY_CHATLOG_BUTTON,   wgettext("Toggle chat log"),  "keymap_toggle_chat");
+       this->add_key(GUI_ID_KEY_FOG_BUTTON,       wgettext("Toggle fog"),       "keymap_toggle_force_fog_off");
 }
+