]> git.lizzy.rs Git - minetest.git/blobdiff - src/guiFormSpecMenu.h
Remove superfluous pointer null checks
[minetest.git] / src / guiFormSpecMenu.h
index ef230c81c4153d94ec0d51a4a304815e5877b6b3..d08bb4ab59cdbdebed78c896365a7ea2423c3810 100644 (file)
@@ -22,16 +22,17 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #define GUIINVENTORYMENU_HEADER
 
 #include <utility>
+#include <stack>
 
 #include "irrlichttypes_extrabloated.h"
-#include "inventory.h"
 #include "inventorymanager.h"
 #include "modalMenu.h"
 #include "guiTable.h"
 #include "network/networkprotocol.h"
+#include "client/joystick_controller.h"
 #include "util/string.h"
+#include "util/enriched_string.h"
 
-class IGameDef;
 class InventoryManager;
 class ISimpleTextureSource;
 class Client;
@@ -54,12 +55,10 @@ typedef enum {
 
 struct TextDest
 {
-       virtual ~TextDest() {};
+       virtual ~TextDest() {}
        // This is deprecated I guess? -celeron55
-       virtual void gotText(std::wstring text){}
+       virtual void gotText(const std::wstring &text) {}
        virtual void gotText(const StringMap &fields) = 0;
-       virtual void setFormName(std::string formname)
-       { m_formname = formname;};
 
        std::string m_formname;
 };
@@ -70,30 +69,29 @@ class IFormSource
        virtual ~IFormSource(){}
        virtual std::string getForm() = 0;
        // Fill in variables in field text
-       virtual std::string resolveText(std::string str){ return str; }
+       virtual std::string resolveText(const std::string &str) { return str; }
 };
 
 class GUIFormSpecMenu : public GUIModalMenu
 {
        struct ItemSpec
        {
-               ItemSpec()
+               ItemSpec() :
+                       i(-1)
                {
-                       i = -1;
                }
+
                ItemSpec(const InventoryLocation &a_inventoryloc,
                                const std::string &a_listname,
-                               s32 a_i)
-               {
-                       inventoryloc = a_inventoryloc;
-                       listname = a_listname;
-                       i = a_i;
-               }
-               bool isValid() const
+                               s32 a_i) :
+                       inventoryloc(a_inventoryloc),
+                       listname(a_listname),
+                       i(a_i)
                {
-                       return i != -1;
                }
 
+               bool isValid() const { return i != -1; }
+
                InventoryLocation inventoryloc;
                std::string listname;
                s32 i;
@@ -141,9 +139,11 @@ class GUIFormSpecMenu : public GUIModalMenu
        struct ImageDrawSpec
        {
                ImageDrawSpec():
-                       parent_button(NULL)
+                       parent_button(NULL),
+                       clip(false)
                {
                }
+
                ImageDrawSpec(const std::string &a_name,
                                const std::string &a_item_name,
                                gui::IGUIButton *a_parent_button,
@@ -153,9 +153,11 @@ class GUIFormSpecMenu : public GUIModalMenu
                        parent_button(a_parent_button),
                        pos(a_pos),
                        geom(a_geom),
-                       scale(true)
+                       scale(true),
+                       clip(false)
                {
                }
+
                ImageDrawSpec(const std::string &a_name,
                                const std::string &a_item_name,
                                const v2s32 &a_pos, const v2s32 &a_geom):
@@ -164,32 +166,39 @@ class GUIFormSpecMenu : public GUIModalMenu
                        parent_button(NULL),
                        pos(a_pos),
                        geom(a_geom),
-                       scale(true)
+                       scale(true),
+                       clip(false)
                {
                }
+
                ImageDrawSpec(const std::string &a_name,
-                               const v2s32 &a_pos, const v2s32 &a_geom):
+                               const v2s32 &a_pos, const v2s32 &a_geom, bool clip=false):
                        name(a_name),
                        parent_button(NULL),
                        pos(a_pos),
                        geom(a_geom),
-                       scale(true)
+                       scale(true),
+                       clip(clip)
                {
                }
+
                ImageDrawSpec(const std::string &a_name,
                                const v2s32 &a_pos):
                        name(a_name),
                        parent_button(NULL),
                        pos(a_pos),
-                       scale(false)
+                       scale(false),
+                       clip(false)
                {
                }
+
                std::string name;
                std::string item_name;
                gui::IGUIButton *parent_button;
                v2s32 pos;
                v2s32 geom;
                bool scale;
+               bool clip;
        };
 
        struct FieldSpec
@@ -200,14 +209,15 @@ class GUIFormSpecMenu : public GUIModalMenu
                FieldSpec(const std::string &name, const std::wstring &label,
                                const std::wstring &default_text, int id) :
                        fname(name),
-                       fid(id)
+                       flabel(label),
+                       fdefault(unescape_enriched(default_text)),
+                       fid(id),
+                       send(false),
+                       ftype(f_Unknown),
+                       is_exit(false)
                {
-                       flabel = unescape_enriched(label);
-                       fdefault = unescape_enriched(default_text);
-                       send = false;
-                       ftype = f_Unknown;
-                       is_exit = false;
                }
+
                std::string fname;
                std::wstring flabel;
                std::wstring fdefault;
@@ -218,7 +228,8 @@ class GUIFormSpecMenu : public GUIModalMenu
                core::rect<s32> rect;
        };
 
-       struct BoxDrawSpec {
+       struct BoxDrawSpec
+       {
                BoxDrawSpec(v2s32 a_pos, v2s32 a_geom,irr::video::SColor a_color):
                        pos(a_pos),
                        geom(a_geom),
@@ -230,42 +241,46 @@ class GUIFormSpecMenu : public GUIModalMenu
                irr::video::SColor color;
        };
 
-       struct TooltipSpec {
-               TooltipSpec()
-               {
-               }
-               TooltipSpec(std::string a_tooltip, irr::video::SColor a_bgcolor,
+       struct TooltipSpec
+       {
+               TooltipSpec() {}
+               TooltipSpec(const std::string &a_tooltip, irr::video::SColor a_bgcolor,
                                irr::video::SColor a_color):
+                       tooltip(utf8_to_wide(a_tooltip)),
                        bgcolor(a_bgcolor),
                        color(a_color)
                {
-                       tooltip = unescape_enriched(utf8_to_wide(a_tooltip));
                }
+
                std::wstring tooltip;
                irr::video::SColor bgcolor;
                irr::video::SColor color;
        };
 
-       struct StaticTextSpec {
+       struct StaticTextSpec
+       {
                StaticTextSpec():
                        parent_button(NULL)
                {
                }
+
                StaticTextSpec(const std::wstring &a_text,
                                const core::rect<s32> &a_rect):
+                       text(a_text),
                        rect(a_rect),
                        parent_button(NULL)
                {
-                       text = unescape_enriched(a_text);
                }
+
                StaticTextSpec(const std::wstring &a_text,
                                const core::rect<s32> &a_rect,
                                gui::IGUIButton *a_parent_button):
+                       text(a_text),
                        rect(a_rect),
                        parent_button(a_parent_button)
                {
-                       text = unescape_enriched(a_text);
                }
+
                std::wstring text;
                core::rect<s32> rect;
                gui::IGUIButton *parent_button;
@@ -273,20 +288,19 @@ class GUIFormSpecMenu : public GUIModalMenu
 
 public:
        GUIFormSpecMenu(irr::IrrlichtDevice* dev,
+                       JoystickController *joystick,
                        gui::IGUIElement* parent, s32 id,
                        IMenuManager *menumgr,
-                       InventoryManager *invmgr,
-                       IGameDef *gamedef,
+                       Client *client,
                        ISimpleTextureSource *tsrc,
                        IFormSource* fs_src,
                        TextDest* txt_dst,
-                       Client* client,
                        bool remap_dbl_click = true);
 
        ~GUIFormSpecMenu();
 
        void setFormSpec(const std::string &formspec_string,
-                       InventoryLocation current_inventory_location)
+                       const InventoryLocation &current_inventory_location)
        {
                m_formspec_string = formspec_string;
                m_current_inventory_location = current_inventory_location;
@@ -296,18 +310,14 @@ class GUIFormSpecMenu : public GUIModalMenu
        // form_src is deleted by this GUIFormSpecMenu
        void setFormSource(IFormSource *form_src)
        {
-               if (m_form_src != NULL) {
-                       delete m_form_src;
-               }
+               delete m_form_src;
                m_form_src = form_src;
        }
 
        // text_dst is deleted by this GUIFormSpecMenu
        void setTextDest(TextDest *text_dst)
        {
-               if (m_text_dst != NULL) {
-                       delete m_text_dst;
-               }
+               delete m_text_dst;
                m_text_dst = text_dst;
        }
 
@@ -325,7 +335,7 @@ class GUIFormSpecMenu : public GUIModalMenu
        void removeChildren();
        void setInitialFocus();
 
-       void setFocus(std::string &elementname)
+       void setFocus(const std::string &elementname)
        {
                m_focused_element = elementname;
        }
@@ -365,10 +375,11 @@ class GUIFormSpecMenu : public GUIModalMenu
        v2s32 spacing;
        v2s32 imgsize;
        v2s32 offset;
+       v2s32 pos_offset;
+       std::stack<v2s32> container_stack;
 
        irr::IrrlichtDevice* m_device;
        InventoryManager *m_invmgr;
-       IGameDef *m_gamedef;
        ISimpleTextureSource *m_tsrc;
        Client *m_client;
 
@@ -382,6 +393,7 @@ class GUIFormSpecMenu : public GUIModalMenu
        std::vector<ImageDrawSpec> m_images;
        std::vector<ImageDrawSpec> m_itemimages;
        std::vector<BoxDrawSpec> m_boxes;
+       std::unordered_map<std::string, bool> field_close_on_enter;
        std::vector<FieldSpec> m_fields;
        std::vector<StaticTextSpec> m_static_texts;
        std::vector<std::pair<FieldSpec,GUITable*> > m_tables;
@@ -391,8 +403,6 @@ class GUIFormSpecMenu : public GUIModalMenu
        std::vector<std::pair<FieldSpec, std::vector<std::string> > > m_dropdowns;
 
        ItemSpec *m_selected_item;
-       f32 m_timer1;
-       f32 m_timer2;
        u32 m_selected_amount;
        bool m_selected_dragging;
 
@@ -406,8 +416,8 @@ class GUIFormSpecMenu : public GUIModalMenu
        v2s32 m_old_pointer;  // Mouse position after previous mouse event
        gui::IGUIStaticText *m_tooltip_element;
 
-       u32 m_tooltip_show_delay;
-       s32 m_hovered_time;
+       u64 m_tooltip_show_delay;
+       u64 m_hovered_time;
        s32 m_old_tooltip_id;
        std::wstring m_old_tooltip;
 
@@ -419,7 +429,6 @@ class GUIFormSpecMenu : public GUIModalMenu
 
        bool m_bgfullscreen;
        bool m_slotborder;
-       bool m_clipbackground;
        video::SColor m_bgcolor;
        video::SColor m_slotbg_n;
        video::SColor m_slotbg_h;
@@ -428,15 +437,18 @@ class GUIFormSpecMenu : public GUIModalMenu
        video::SColor m_default_tooltip_color;
 
 private:
-       IFormSource      *m_form_src;
-       TextDest         *m_text_dst;
-       unsigned int      m_formspec_version;
-       std::string       m_focused_element;
+       IFormSource        *m_form_src;
+       TextDest           *m_text_dst;
+       unsigned int        m_formspec_version;
+       std::string         m_focused_element;
+       JoystickController *m_joystick;
 
        typedef struct {
                bool explicit_size;
                v2f invsize;
                v2s32 size;
+               v2f32 offset;
+               v2f32 anchor;
                core::rect<s32> rect;
                v2s32 basepos;
                v2u32 screensize;
@@ -444,7 +456,7 @@ class GUIFormSpecMenu : public GUIModalMenu
                GUITable::TableOptions table_options;
                GUITable::TableColumns table_columns;
                // used to restore table selection/scroll/treeview state
-               std::map<std::string, GUITable::DynamicData> table_dyndata;
+               std::unordered_map<std::string, GUITable::DynamicData> table_dyndata;
        } parserData;
 
        typedef struct {
@@ -455,39 +467,54 @@ class GUIFormSpecMenu : public GUIModalMenu
        } fs_key_pendig;
 
        fs_key_pendig current_keys_pending;
-
-       void parseElement(parserData* data,std::string element);
-
-       void parseSize(parserData* data,std::string element);
-       void parseList(parserData* data,std::string element);
-       void parseListRing(parserData* data,std::string element);
-       void parseCheckbox(parserData* data,std::string element);
-       void parseImage(parserData* data,std::string element);
-       void parseItemImage(parserData* data,std::string element);
-       void parseButton(parserData* data,std::string element,std::string typ);
-       void parseBackground(parserData* data,std::string element);
-       void parseTableOptions(parserData* data,std::string element);
-       void parseTableColumns(parserData* data,std::string element);
-       void parseTable(parserData* data,std::string element);
-       void parseTextList(parserData* data,std::string element);
-       void parseDropDown(parserData* data,std::string element);
-       void parsePwdField(parserData* data,std::string element);
-       void parseField(parserData* data,std::string element,std::string type);
+       std::string current_field_enter_pending;
+
+       void parseElement(parserData* data, const std::string &element);
+
+       void parseSize(parserData* data, const std::string &element);
+       void parseContainer(parserData* data, const std::string &element);
+       void parseContainerEnd(parserData* data);
+       void parseList(parserData* data, const std::string &element);
+       void parseListRing(parserData* data, const std::string &element);
+       void parseCheckbox(parserData* data, const std::string &element);
+       void parseImage(parserData* data, const std::string &element);
+       void parseItemImage(parserData* data, const std::string &element);
+       void parseButton(parserData* data, const std::string &element,
+                       const std::string &typ);
+       void parseBackground(parserData* data, const std::string &element);
+       void parseTableOptions(parserData* data, const std::string &element);
+       void parseTableColumns(parserData* data, const std::string &element);
+       void parseTable(parserData* data, const std::string &element);
+       void parseTextList(parserData* data, const std::string &element);
+       void parseDropDown(parserData* data, const std::string &element);
+       void parseFieldCloseOnEnter(parserData *data, const std::string &element);
+       void parsePwdField(parserData* data, const std::string &element);
+       void parseField(parserData* data, const std::string &element, const std::string &type);
        void parseSimpleField(parserData* data,std::vector<std::string> &parts);
        void parseTextArea(parserData* data,std::vector<std::string>& parts,
-                       std::string type);
-       void parseLabel(parserData* data,std::string element);
-       void parseVertLabel(parserData* data,std::string element);
-       void parseImageButton(parserData* data,std::string element,std::string type);
-       void parseItemImageButton(parserData* data,std::string element);
-       void parseTabHeader(parserData* data,std::string element);
-       void parseBox(parserData* data,std::string element);
-       void parseBackgroundColor(parserData* data,std::string element);
-       void parseListColors(parserData* data,std::string element);
-       void parseTooltip(parserData* data,std::string element);
-       bool parseVersionDirect(std::string data);
-       bool parseSizeDirect(parserData* data, std::string element);
-       void parseScrollBar(parserData* data, std::string element);
+                       const std::string &type);
+       void parseLabel(parserData* data, const std::string &element);
+       void parseVertLabel(parserData* data, const std::string &element);
+       void parseImageButton(parserData* data, const std::string &element,
+                       const std::string &type);
+       void parseItemImageButton(parserData* data, const std::string &element);
+       void parseTabHeader(parserData* data, const std::string &element);
+       void parseBox(parserData* data, const std::string &element);
+       void parseBackgroundColor(parserData* data, const std::string &element);
+       void parseListColors(parserData* data, const std::string &element);
+       void parseTooltip(parserData* data, const std::string &element);
+       bool parseVersionDirect(const std::string &data);
+       bool parseSizeDirect(parserData* data, const std::string &element);
+       void parseScrollBar(parserData* data, const std::string &element);
+       bool parsePositionDirect(parserData *data, const std::string &element);
+       void parsePosition(parserData *data, const std::string &element);
+       bool parseAnchorDirect(parserData *data, const std::string &element);
+       void parseAnchor(parserData *data, const std::string &element);
+
+       void tryClose();
+
+       void showTooltip(const std::wstring &text, const irr::video::SColor &color,
+               const irr::video::SColor &bgcolor);
 
        /**
         * check if event is part of a double click
@@ -499,7 +526,7 @@ class GUIFormSpecMenu : public GUIModalMenu
        struct clickpos
        {
                v2s32 pos;
-               s32 time;
+               s64 time;
        };
        clickpos m_doubleclickdetect[2];
 
@@ -526,25 +553,23 @@ class GUIFormSpecMenu : public GUIModalMenu
 class FormspecFormSource: public IFormSource
 {
 public:
-       FormspecFormSource(std::string formspec)
+       FormspecFormSource(const std::string &formspec):
+               m_formspec(formspec)
        {
-               m_formspec = formspec;
        }
 
        ~FormspecFormSource()
-       {}
-
-       void setForm(std::string formspec) {
-               m_formspec = FORMSPEC_VERSION_STRING + formspec;
+       {
        }
 
-       std::string getForm()
+       void setForm(const std::string &formspec)
        {
-               return m_formspec;
+               m_formspec = FORMSPEC_VERSION_STRING + formspec;
        }
 
+       std::string getForm() { return m_formspec; }
+
        std::string m_formspec;
 };
 
 #endif
-