]> git.lizzy.rs Git - dragonfireclient.git/blobdiff - src/guiFormSpecMenu.cpp
New settings tab contain all possible settings
[dragonfireclient.git] / src / guiFormSpecMenu.cpp
index ec829525bdb4787d31af265c2f325d5571667092..c5edb967eaea1f8c10075aaa9c0f34b1357cae91 100644 (file)
@@ -300,7 +300,7 @@ void GUIFormSpecMenu::parseSize(parserData* data,std::string element)
 void GUIFormSpecMenu::parseList(parserData* data,std::string element)
 {
        if (m_gamedef == 0) {
-               errorstream<<"WARNING: invalid use of 'list' with m_gamedef==0"<<std::endl;
+               warningstream<<"invalid use of 'list' with m_gamedef==0"<<std::endl;
                return;
        }
 
@@ -345,13 +345,48 @@ void GUIFormSpecMenu::parseList(parserData* data,std::string element)
                }
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of list without a size[] element"<<std::endl;
+                       warningstream<<"invalid use of list without a size[] element"<<std::endl;
                m_inventorylists.push_back(ListDrawSpec(loc, listname, pos, geom, start_i));
                return;
        }
        errorstream<< "Invalid list element(" << parts.size() << "): '" << element << "'"  << std::endl;
 }
 
+void GUIFormSpecMenu::parseListRing(parserData* data, std::string element)
+{
+       if (m_gamedef == 0) {
+               errorstream << "WARNING: invalid use of 'listring' with m_gamedef==0" << std::endl;
+               return;
+       }
+
+       std::vector<std::string> parts = split(element, ';');
+
+       if (parts.size() == 2) {
+               std::string location = parts[0];
+               std::string listname = parts[1];
+
+               InventoryLocation loc;
+
+               if (location == "context" || location == "current_name")
+                       loc = m_current_inventory_location;
+               else
+                       loc.deSerialize(location);
+
+               m_inventory_rings.push_back(ListRingSpec(loc, listname));
+               return;
+       } else if ((element == "") && (m_inventorylists.size() > 1)) {
+               size_t siz = m_inventorylists.size();
+               // insert the last two inv list elements into the list ring
+               const ListDrawSpec &spa = m_inventorylists[siz - 2];
+               const ListDrawSpec &spb = m_inventorylists[siz - 1];
+               m_inventory_rings.push_back(ListRingSpec(spa.inventoryloc, spa.listname));
+               m_inventory_rings.push_back(ListRingSpec(spb.inventoryloc, spb.listname));
+               return;
+       }
+       errorstream<< "Invalid list ring element(" << parts.size() << ", "
+               << m_inventorylists.size() << "): '" << element << "'"  << std::endl;
+}
+
 void GUIFormSpecMenu::parseCheckbox(parserData* data,std::string element)
 {
        std::vector<std::string> parts = split(element,';');
@@ -490,7 +525,7 @@ void GUIFormSpecMenu::parseImage(parserData* data,std::string element)
                geom.Y = stof(v_geom[1]) * (float)imgsize.Y;
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of image without a size[] element"<<std::endl;
+                       warningstream<<"invalid use of image without a size[] element"<<std::endl;
                m_images.push_back(ImageDrawSpec(name, pos, geom));
                return;
        }
@@ -506,7 +541,7 @@ void GUIFormSpecMenu::parseImage(parserData* data,std::string element)
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of image without a size[] element"<<std::endl;
+                       warningstream<<"invalid use of image without a size[] element"<<std::endl;
                m_images.push_back(ImageDrawSpec(name, pos));
                return;
        }
@@ -536,7 +571,7 @@ void GUIFormSpecMenu::parseItemImage(parserData* data,std::string element)
                geom.Y = stof(v_geom[1]) * (float)imgsize.Y;
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of item_image without a size[] element"<<std::endl;
+                       warningstream<<"invalid use of item_image without a size[] element"<<std::endl;
                m_itemimages.push_back(ImageDrawSpec(name, pos, geom));
                return;
        }
@@ -572,7 +607,7 @@ void GUIFormSpecMenu::parseButton(parserData* data,std::string element,
                                                pos.X + geom.X, pos.Y + m_btn_height);
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of button without a size[] element"<<std::endl;
+                       warningstream<<"invalid use of button without a size[] element"<<std::endl;
 
                label = unescape_string(label);
 
@@ -631,7 +666,7 @@ void GUIFormSpecMenu::parseBackground(parserData* data,std::string element)
                }
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of background without a size[] element"<<std::endl;
+                       warningstream<<"invalid use of background without a size[] element"<<std::endl;
                m_backgrounds.push_back(ImageDrawSpec(name, pos, geom));
                return;
        }
@@ -947,7 +982,7 @@ void GUIFormSpecMenu::parseSimpleField(parserData* data,
        core::rect<s32> rect;
 
        if(data->explicit_size)
-               errorstream<<"WARNING: invalid use of unpositioned \"field\" in inventory"<<std::endl;
+               warningstream<<"invalid use of unpositioned \"field\" in inventory"<<std::endl;
 
        v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
        pos.Y = ((m_fields.size()+2)*60);
@@ -985,6 +1020,7 @@ void GUIFormSpecMenu::parseSimpleField(parserData* data,
                if (g_settings->getBool("freetype")) {
                        e = (gui::IGUIElement *) new gui::intlGUIEditBox(spec.fdefault.c_str(),
                                true, Environment, this, spec.fid, rect);
+                       e->drop();
                } else {
 #else
                {
@@ -1052,7 +1088,7 @@ void GUIFormSpecMenu::parseTextArea(parserData* data,
        core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
        if(!data->explicit_size)
-               errorstream<<"WARNING: invalid use of positioned "<<type<<" without a size[] element"<<std::endl;
+               warningstream<<"invalid use of positioned "<<type<<" without a size[] element"<<std::endl;
 
        if(m_form_src)
                default_val = m_form_src->resolveText(default_val);
@@ -1084,6 +1120,7 @@ void GUIFormSpecMenu::parseTextArea(parserData* data,
                if (g_settings->getBool("freetype")) {
                        e = (gui::IGUIEditBox *) new gui::intlGUIEditBox(spec.fdefault.c_str(),
                                true, Environment, this, spec.fid, rect);
+                       e->drop();
                } else {
 #else
                {
@@ -1158,7 +1195,7 @@ void GUIFormSpecMenu::parseLabel(parserData* data,std::string element)
                pos.Y += (stof(v_pos[1]) + 7.0/30.0) * (float)spacing.Y;
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of label without a size[] element"<<std::endl;
+                       warningstream<<"invalid use of label without a size[] element"<<std::endl;
 
                text = unescape_string(text);
                std::vector<std::string> lines = split(text, '\n');
@@ -1223,7 +1260,7 @@ void GUIFormSpecMenu::parseVertLabel(parserData* data,std::string element)
                //actually text.length() would be correct but adding +1 avoids to break all mods
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of label without a size[] element"<<std::endl;
+                       warningstream<<"invalid use of label without a size[] element"<<std::endl;
 
                std::wstring label = L"";
 
@@ -1289,7 +1326,7 @@ void GUIFormSpecMenu::parseImageButton(parserData* data,std::string element,
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of image_button without a size[] element"<<std::endl;
+                       warningstream<<"invalid use of image_button without a size[] element"<<std::endl;
 
                image_name = unescape_string(image_name);
                pressed_image_name = unescape_string(pressed_image_name);
@@ -1412,9 +1449,8 @@ void GUIFormSpecMenu::parseItemImageButton(parserData* data,std::string element)
 {
 
        if (m_gamedef == 0) {
-               errorstream <<
-                               "WARNING: invalid use of item_image_button with m_gamedef==0"
-                               << std::endl;
+               warningstream << "invalid use of item_image_button with m_gamedef==0"
+                       << std::endl;
                return;
        }
 
@@ -1442,7 +1478,7 @@ void GUIFormSpecMenu::parseItemImageButton(parserData* data,std::string element)
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of item_image_button without a size[] element"<<std::endl;
+                       warningstream<<"invalid use of item_image_button without a size[] element"<<std::endl;
 
                IItemDefManager *idef = m_gamedef->idef();
                ItemStack item;
@@ -1661,6 +1697,11 @@ void GUIFormSpecMenu::parseElement(parserData* data, std::string element)
                return;
        }
 
+       if (type == "listring") {
+               parseListRing(data, description);
+               return;
+       }
+
        if (type == "checkbox") {
                parseCheckbox(data,description);
                return;
@@ -1838,6 +1879,7 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
        m_fields.clear();
        m_boxes.clear();
        m_tooltips.clear();
+       m_inventory_rings.clear();
 
        // Set default values (fits old formspec values)
        m_bgcolor = video::SColor(140,0,0,0);
@@ -2061,7 +2103,7 @@ bool GUIFormSpecMenu::getAndroidUIInput()
        }
 
        for(std::vector<FieldSpec>::iterator iter =  m_fields.begin();
-                       iter != m_fields.end(); iter++) {
+                       iter != m_fields.end(); ++iter) {
 
                if (iter->fname != fieldname) {
                        continue;
@@ -2115,7 +2157,7 @@ void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase)
 
        Inventory *inv = m_invmgr->getInventory(s.inventoryloc);
        if(!inv){
-               infostream<<"GUIFormSpecMenu::drawList(): WARNING: "
+               warningstream<<"GUIFormSpecMenu::drawList(): "
                                <<"The inventory location "
                                <<"\""<<s.inventoryloc.dump()<<"\" doesn't exist"
                                <<std::endl;
@@ -2123,7 +2165,7 @@ void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase)
        }
        InventoryList *ilist = inv->getList(s.listname);
        if(!ilist){
-               infostream<<"GUIFormSpecMenu::drawList(): WARNING: "
+               warningstream<<"GUIFormSpecMenu::drawList(): "
                                <<"The inventory list \""<<s.listname<<"\" @ \""
                                <<s.inventoryloc.dump()<<"\" doesn't exist"
                                <<std::endl;
@@ -2431,7 +2473,7 @@ void GUIFormSpecMenu::drawMenu()
 
                if (id != -1 && delta >= m_tooltip_show_delay) {
                        for(std::vector<FieldSpec>::iterator iter =  m_fields.begin();
-                                       iter != m_fields.end(); iter++) {
+                                       iter != m_fields.end(); ++iter) {
                                if ( (iter->fid == id) && (m_tooltips[iter->fname].tooltip != "") ){
                                        if (m_old_tooltip != m_tooltips[iter->fname].tooltip) {
                                                m_old_tooltip = m_tooltips[iter->fname].tooltip;
@@ -3012,10 +3054,10 @@ bool GUIFormSpecMenu::DoubleClickDetection(const SEvent event)
 
 bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 {
-       if(event.EventType==EET_KEY_INPUT_EVENT) {
+       if (event.EventType==EET_KEY_INPUT_EVENT) {
                KeyPress kp(event.KeyInput);
                if (event.KeyInput.PressedDown && ( (kp == EscapeKey) ||
-                       (kp == getKeySetting("keymap_inventory")) || (kp == CancelKey))) {
+                               (kp == getKeySetting("keymap_inventory")) || (kp == CancelKey))) {
                        if (m_allowclose) {
                                doPause = false;
                                acceptInput(quit_mode_cancel);
@@ -3025,8 +3067,8 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        }
                        return true;
                } else if (m_client != NULL && event.KeyInput.PressedDown &&
-                       (kp == getKeySetting("keymap_screenshot"))) {
-                               m_client->makeScreenshot(m_device);
+                               (kp == getKeySetting("keymap_screenshot"))) {
+                       m_client->makeScreenshot(m_device);
                }
                if (event.KeyInput.PressedDown &&
                        (event.KeyInput.Key==KEY_RETURN ||
@@ -3077,8 +3119,9 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 
                Inventory *inv_selected = NULL;
                Inventory *inv_s = NULL;
+               InventoryList *list_s = NULL;
 
-               if(m_selected_item) {
+               if (m_selected_item) {
                        inv_selected = m_invmgr->getInventory(m_selected_item->inventoryloc);
                        sanity_check(inv_selected);
                        sanity_check(inv_selected->getList(m_selected_item->listname) != NULL);
@@ -3086,35 +3129,35 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 
                u32 s_count = 0;
 
-               if(s.isValid())
+               if (s.isValid())
                do { // breakable
                        inv_s = m_invmgr->getInventory(s.inventoryloc);
 
-                       if(!inv_s) {
-                               errorstream<<"InventoryMenu: The selected inventory location "
-                                               <<"\""<<s.inventoryloc.dump()<<"\" doesn't exist"
-                                               <<std::endl;
+                       if (!inv_s) {
+                               errorstream << "InventoryMenu: The selected inventory location "
+                                               << "\"" << s.inventoryloc.dump() << "\" doesn't exist"
+                                               << std::endl;
                                s.i = -1;  // make it invalid again
                                break;
                        }
 
-                       InventoryList *list = inv_s->getList(s.listname);
-                       if(list == NULL) {
-                               verbosestream<<"InventoryMenu: The selected inventory list \""
-                                               <<s.listname<<"\" does not exist"<<std::endl;
+                       list_s = inv_s->getList(s.listname);
+                       if (list_s == NULL) {
+                               verbosestream << "InventoryMenu: The selected inventory list \""
+                                               << s.listname << "\" does not exist" << std::endl;
                                s.i = -1;  // make it invalid again
                                break;
                        }
 
-                       if((u32)s.i >= list->getSize()) {
-                               infostream<<"InventoryMenu: The selected inventory list \""
-                                               <<s.listname<<"\" is too small (i="<<s.i<<", size="
-                                               <<list->getSize()<<")"<<std::endl;
+                       if ((u32)s.i >= list_s->getSize()) {
+                               infostream << "InventoryMenu: The selected inventory list \""
+                                               << s.listname << "\" is too small (i=" << s.i << ", size="
+                                               << list_s->getSize() << ")" << std::endl;
                                s.i = -1;  // make it invalid again
                                break;
                        }
 
-                       s_count = list->getItem(s.i).count;
+                       s_count = list_s->getItem(s.i).count;
                } while(0);
 
                bool identical = (m_selected_item != NULL) && s.isValid() &&
@@ -3126,25 +3169,29 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                // up/down: 0 = down (press), 1 = up (release), 2 = unknown event, -1 movement
                int button = 0;
                int updown = 2;
-               if(event.MouseInput.Event == EMIE_LMOUSE_PRESSED_DOWN)
+               if (event.MouseInput.Event == EMIE_LMOUSE_PRESSED_DOWN)
                        { button = 0; updown = 0; }
-               else if(event.MouseInput.Event == EMIE_RMOUSE_PRESSED_DOWN)
+               else if (event.MouseInput.Event == EMIE_RMOUSE_PRESSED_DOWN)
                        { button = 1; updown = 0; }
-               else if(event.MouseInput.Event == EMIE_MMOUSE_PRESSED_DOWN)
+               else if (event.MouseInput.Event == EMIE_MMOUSE_PRESSED_DOWN)
                        { button = 2; updown = 0; }
-               else if(event.MouseInput.Event == EMIE_LMOUSE_LEFT_UP)
+               else if (event.MouseInput.Event == EMIE_LMOUSE_LEFT_UP)
                        { button = 0; updown = 1; }
-               else if(event.MouseInput.Event == EMIE_RMOUSE_LEFT_UP)
+               else if (event.MouseInput.Event == EMIE_RMOUSE_LEFT_UP)
                        { button = 1; updown = 1; }
-               else if(event.MouseInput.Event == EMIE_MMOUSE_LEFT_UP)
+               else if (event.MouseInput.Event == EMIE_MMOUSE_LEFT_UP)
                        { button = 2; updown = 1; }
-               else if(event.MouseInput.Event == EMIE_MOUSE_MOVED)
+               else if (event.MouseInput.Event == EMIE_MOUSE_MOVED)
                        { updown = -1;}
 
                // Set this number to a positive value to generate a move action
                // from m_selected_item to s.
                u32 move_amount = 0;
 
+               // Set this number to a positive value to generate a move action
+               // from s to the next inventory ring.
+               u32 shift_move_amount = 0;
+
                // Set this number to a positive value to generate a drop action
                // from m_selected_item.
                u32 drop_amount = 0;
@@ -3152,7 +3199,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                // Set this number to a positive value to generate a craft action at s.
                u32 craft_amount = 0;
 
-               if(updown == 0) {
+               if (updown == 0) {
                        // Some mouse button has been pressed
 
                        //infostream<<"Mouse button "<<button<<" pressed at p=("
@@ -3160,40 +3207,49 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 
                        m_selected_dragging = false;
 
-                       if(s.isValid() && s.listname == "craftpreview") {
+                       if (s.isValid() && s.listname == "craftpreview") {
                                // Craft preview has been clicked: craft
                                craft_amount = (button == 2 ? 10 : 1);
-                       }
-                       else if(m_selected_item == NULL) {
-                               if(s_count != 0) {
-                                       // Non-empty stack has been clicked: select it
+                       } else if (m_selected_item == NULL) {
+                               if (s_count != 0) {
+                                       // Non-empty stack has been clicked: select or shift-move it
                                        m_selected_item = new ItemSpec(s);
 
-                                       if(button == 1)  // right
-                                               m_selected_amount = (s_count + 1) / 2;
-                                       else if(button == 2)  // middle
-                                               m_selected_amount = MYMIN(s_count, 10);
+                                       u32 count;
+                                       if (button == 1)  // right
+                                               count = (s_count + 1) / 2;
+                                       else if (button == 2)  // middle
+                                               count = MYMIN(s_count, 10);
                                        else  // left
-                                               m_selected_amount = s_count;
+                                               count = s_count;
 
-                                       m_selected_dragging = true;
-                                       m_rmouse_auto_place = false;
+                                       if (!event.MouseInput.Shift) {
+                                               // no shift: select item
+                                               m_selected_amount = count;
+                                               m_selected_dragging = true;
+                                               m_rmouse_auto_place = false;
+                                       } else {
+                                               // shift pressed: move item
+                                               if (button != 1)
+                                                       shift_move_amount = count;
+                                               else // count of 1 at left click like after drag & drop
+                                                       shift_move_amount = 1;
+                                       }
                                }
-                       }
-                       else { // m_selected_item != NULL
+                       } else { // m_selected_item != NULL
                                assert(m_selected_amount >= 1);
 
-                               if(s.isValid()) {
+                               if (s.isValid()) {
                                        // Clicked a slot: move
-                                       if(button == 1)  // right
+                                       if (button == 1)  // right
                                                move_amount = 1;
-                                       else if(button == 2)  // middle
+                                       else if (button == 2)  // middle
                                                move_amount = MYMIN(m_selected_amount, 10);
                                        else  // left
                                                move_amount = m_selected_amount;
 
-                                       if(identical) {
-                                               if(move_amount >= m_selected_amount)
+                                       if (identical) {
+                                               if (move_amount >= m_selected_amount)
                                                        m_selected_amount = 0;
                                                else
                                                        m_selected_amount -= move_amount;
@@ -3202,29 +3258,28 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                }
                                else if (!getAbsoluteClippingRect().isPointInside(m_pointer)) {
                                        // Clicked outside of the window: drop
-                                       if(button == 1)  // right
+                                       if (button == 1)  // right
                                                drop_amount = 1;
-                                       else if(button == 2)  // middle
+                                       else if (button == 2)  // middle
                                                drop_amount = MYMIN(m_selected_amount, 10);
                                        else  // left
                                                drop_amount = m_selected_amount;
                                }
                        }
                }
-               else if(updown == 1) {
+               else if (updown == 1) {
                        // Some mouse button has been released
 
                        //infostream<<"Mouse button "<<button<<" released at p=("
                        //      <<p.X<<","<<p.Y<<")"<<std::endl;
 
-                       if(m_selected_item != NULL && m_selected_dragging && s.isValid()) {
-                               if(!identical) {
+                       if (m_selected_item != NULL && m_selected_dragging && s.isValid()) {
+                               if (!identical) {
                                        // Dragged to different slot: move all selected
                                        move_amount = m_selected_amount;
                                }
-                       }
-                       else if(m_selected_item != NULL && m_selected_dragging &&
-                               !(getAbsoluteClippingRect().isPointInside(m_pointer))) {
+                       } else if (m_selected_item != NULL && m_selected_dragging &&
+                                       !(getAbsoluteClippingRect().isPointInside(m_pointer))) {
                                // Dragged outside of window: drop all selected
                                drop_amount = m_selected_amount;
                        }
@@ -3233,14 +3288,13 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        // Keep count of how many times right mouse button has been
                        // clicked. One click is drag without dropping. Click + release
                        // + click changes to drop one item when moved mode
-                       if(button == 1 && m_selected_item != NULL)
+                       if (button == 1 && m_selected_item != NULL)
                                m_rmouse_auto_place = !m_rmouse_auto_place;
-               }
-               else if(updown == -1) {
+               } else if (updown == -1) {
                        // Mouse has been moved and rmb is down and mouse pointer just
                        // entered a new inventory field (checked in the entry-if, this
                        // is the only action here that is generated by mouse movement)
-                       if(m_selected_item != NULL && s.isValid()){
+                       if (m_selected_item != NULL && s.isValid()) {
                                // Move 1 item
                                // TODO: middle mouse to move 10 items might be handy
                                if (m_rmouse_auto_place) {
@@ -3248,7 +3302,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                        // or contains the same item type as what is going to be
                                        // moved
                                        InventoryList *list_from = inv_selected->getList(m_selected_item->listname);
-                                       InventoryList *list_to = inv_s->getList(s.listname);
+                                       InventoryList *list_to = list_s;
                                        assert(list_from && list_to);
                                        ItemStack stack_from = list_from->getItem(m_selected_item->i);
                                        ItemStack stack_to = list_to->getItem(s.i);
@@ -3259,8 +3313,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                }
 
                // Possibly send inventory action to server
-               if(move_amount > 0)
-               {
+               if (move_amount > 0) {
                        // Send IACTION_MOVE
 
                        assert(m_selected_item && m_selected_item->isValid());
@@ -3268,7 +3321,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 
                        assert(inv_selected && inv_s);
                        InventoryList *list_from = inv_selected->getList(m_selected_item->listname);
-                       InventoryList *list_to = inv_s->getList(s.listname);
+                       InventoryList *list_to = list_s;
                        assert(list_from && list_to);
                        ItemStack stack_from = list_from->getItem(m_selected_item->i);
                        ItemStack stack_to = list_to->getItem(s.i);
@@ -3287,7 +3340,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                m_selected_content_guess_inventory = s.inventoryloc;
                        }
                        // Source stack goes fully into destination stack
-                       else if(leftover.empty()) {
+                       else if (leftover.empty()) {
                                m_selected_amount -= move_amount;
                                m_selected_content_guess = ItemStack(); // Clear
                        }
@@ -3298,7 +3351,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                m_selected_content_guess = ItemStack(); // Clear
                        }
 
-                       infostream<<"Handing IACTION_MOVE to manager"<<std::endl;
+                       infostream << "Handing IACTION_MOVE to manager" << std::endl;
                        IMoveAction *a = new IMoveAction();
                        a->count = move_amount;
                        a->from_inv = m_selected_item->inventoryloc;
@@ -3308,8 +3361,68 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        a->to_list = s.listname;
                        a->to_i = s.i;
                        m_invmgr->inventoryAction(a);
-               }
-               else if(drop_amount > 0) {
+               } else if (shift_move_amount > 0) {
+                       u32 mis = m_inventory_rings.size();
+                       u32 i = 0;
+                       for (; i < mis; i++) {
+                               const ListRingSpec &sp = m_inventory_rings[i];
+                               if (sp.inventoryloc == s.inventoryloc
+                                               && sp.listname == s.listname)
+                                       break;
+                       }
+                       do {
+                               if (i >= mis) // if not found
+                                       break;
+                               u32 to_inv_ind = (i + 1) % mis;
+                               const ListRingSpec &to_inv_sp = m_inventory_rings[to_inv_ind];
+                               InventoryList *list_from = list_s;
+                               if (!s.isValid())
+                                       break;
+                               Inventory *inv_to = m_invmgr->getInventory(to_inv_sp.inventoryloc);
+                               if (!inv_to)
+                                       break;
+                               InventoryList *list_to = inv_to->getList(to_inv_sp.listname);
+                               if (!list_to)
+                                       break;
+                               ItemStack stack_from = list_from->getItem(s.i);
+                               assert(shift_move_amount <= stack_from.count);
+                               if (m_client->getProtoVersion() >= 25) {
+                                       infostream << "Handing IACTION_MOVE to manager" << std::endl;
+                                       IMoveAction *a = new IMoveAction();
+                                       a->count = shift_move_amount;
+                                       a->from_inv = s.inventoryloc;
+                                       a->from_list = s.listname;
+                                       a->from_i = s.i;
+                                       a->to_inv = to_inv_sp.inventoryloc;
+                                       a->to_list = to_inv_sp.listname;
+                                       a->move_somewhere = true;
+                                       m_invmgr->inventoryAction(a);
+                               } else {
+                                       // find a place (or more than one) to add the new item
+                                       u32 ilt_size = list_to->getSize();
+                                       ItemStack leftover;
+                                       for (u32 slot_to = 0; slot_to < ilt_size
+                                                       && shift_move_amount > 0; slot_to++) {
+                                               list_to->itemFits(slot_to, stack_from, &leftover);
+                                               if (leftover.count < stack_from.count) {
+                                                       infostream << "Handing IACTION_MOVE to manager" << std::endl;
+                                                       IMoveAction *a = new IMoveAction();
+                                                       a->count = MYMIN(shift_move_amount,
+                                                               (u32) (stack_from.count - leftover.count));
+                                                       shift_move_amount -= a->count;
+                                                       a->from_inv = s.inventoryloc;
+                                                       a->from_list = s.listname;
+                                                       a->from_i = s.i;
+                                                       a->to_inv = to_inv_sp.inventoryloc;
+                                                       a->to_list = to_inv_sp.listname;
+                                                       a->to_i = slot_to;
+                                                       m_invmgr->inventoryAction(a);
+                                                       stack_from = leftover;
+                                               }
+                                       }
+                               }
+                       } while (0);
+               } else if (drop_amount > 0) {
                        m_selected_content_guess = ItemStack(); // Clear
 
                        // Send IACTION_DROP
@@ -3325,15 +3438,14 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        assert(drop_amount > 0 && drop_amount <= m_selected_amount);
                        m_selected_amount -= drop_amount;
 
-                       infostream<<"Handing IACTION_DROP to manager"<<std::endl;
+                       infostream << "Handing IACTION_DROP to manager" << std::endl;
                        IDropAction *a = new IDropAction();
                        a->count = drop_amount;
                        a->from_inv = m_selected_item->inventoryloc;
                        a->from_list = m_selected_item->listname;
                        a->from_i = m_selected_item->i;
                        m_invmgr->inventoryAction(a);
-               }
-               else if(craft_amount > 0) {
+               } else if (craft_amount > 0) {
                        m_selected_content_guess = ItemStack(); // Clear
 
                        // Send IACTION_CRAFT
@@ -3341,7 +3453,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        assert(s.isValid());
                        assert(inv_s);
 
-                       infostream<<"Handing IACTION_CRAFT to manager"<<std::endl;
+                       infostream << "Handing IACTION_CRAFT to manager" << std::endl;
                        ICraftAction *a = new ICraftAction();
                        a->count = craft_amount;
                        a->craft_inv = s.inventoryloc;
@@ -3349,7 +3461,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                }
 
                // If m_selected_amount has been decreased to zero, deselect
-               if(m_selected_amount == 0) {
+               if (m_selected_amount == 0) {
                        delete m_selected_item;
                        m_selected_item = NULL;
                        m_selected_amount = 0;
@@ -3358,12 +3470,12 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                }
                m_old_pointer = m_pointer;
        }
-       if(event.EventType==EET_GUI_EVENT) {
+       if (event.EventType == EET_GUI_EVENT) {
 
-               if(event.GUIEvent.EventType==gui::EGET_TAB_CHANGED
+               if (event.GUIEvent.EventType == gui::EGET_TAB_CHANGED
                                && isVisible()) {
                        // find the element that was clicked
-                       for(unsigned int i=0; i<m_fields.size(); i++) {
+                       for (unsigned int i=0; i<m_fields.size(); i++) {
                                FieldSpec &s = m_fields[i];
                                if ((s.ftype == f_TabHeader) &&
                                                (s.fid == event.GUIEvent.Caller->getID())) {
@@ -3374,16 +3486,16 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                }
                        }
                }
-               if(event.GUIEvent.EventType==gui::EGET_ELEMENT_FOCUS_LOST
+               if (event.GUIEvent.EventType == gui::EGET_ELEMENT_FOCUS_LOST
                                && isVisible()) {
-                       if(!canTakeFocus(event.GUIEvent.Element)) {
+                       if (!canTakeFocus(event.GUIEvent.Element)) {
                                infostream<<"GUIFormSpecMenu: Not allowing focus change."
                                                <<std::endl;
                                // Returning true disables focus change
                                return true;
                        }
                }
-               if((event.GUIEvent.EventType == gui::EGET_BUTTON_CLICKED) ||
+               if ((event.GUIEvent.EventType == gui::EGET_BUTTON_CLICKED) ||
                                (event.GUIEvent.EventType == gui::EGET_CHECKBOX_CHANGED) ||
                                (event.GUIEvent.EventType == gui::EGET_COMBO_BOX_CHANGED) ||
                                (event.GUIEvent.EventType == gui::EGET_SCROLL_BAR_CHANGED)) {
@@ -3402,14 +3514,14 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        }
 
                        // find the element that was clicked
-                       for(u32 i=0; i<m_fields.size(); i++) {
+                       for (u32 i = 0; i < m_fields.size(); i++) {
                                FieldSpec &s = m_fields[i];
                                // if its a button, set the send field so
                                // lua knows which button was pressed
                                if (((s.ftype == f_Button) || (s.ftype == f_CheckBox)) &&
                                                (s.fid == event.GUIEvent.Caller->getID())) {
                                        s.send = true;
-                                       if(s.is_exit) {
+                                       if (s.is_exit) {
                                                if (m_allowclose) {
                                                        acceptInput(quit_mode_accept);
                                                        quitMenu();
@@ -3422,11 +3534,10 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                                s.send = false;
                                                return true;
                                        }
-                               }
-                               else if ((s.ftype == f_DropDown) &&
+                               } else if ((s.ftype == f_DropDown) &&
                                                (s.fid == event.GUIEvent.Caller->getID())) {
                                        // only send the changed dropdown
-                                       for(u32 i=0; i<m_fields.size(); i++) {
+                                       for (u32 i = 0; i < m_fields.size(); i++) {
                                                FieldSpec &s2 = m_fields[i];
                                                if (s2.ftype == f_DropDown) {
                                                        s2.send = false;
@@ -3437,17 +3548,15 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 
                                        // revert configuration to make sure dropdowns are sent on
                                        // regular button click
-                                       for(u32 i=0; i<m_fields.size(); i++) {
+                                       for (u32 i = 0; i < m_fields.size(); i++) {
                                                FieldSpec &s2 = m_fields[i];
                                                if (s2.ftype == f_DropDown) {
                                                        s2.send = true;
                                                }
                                        }
                                        return true;
-                               }
-                               else if ((s.ftype == f_ScrollBar) &&
-                                       (s.fid == event.GUIEvent.Caller->getID()))
-                               {
+                               } else if ((s.ftype == f_ScrollBar) &&
+                                               (s.fid == event.GUIEvent.Caller->getID())) {
                                        s.fdefault = L"Changed";
                                        acceptInput(quit_mode_no);
                                        s.fdefault = L"";
@@ -3455,8 +3564,8 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        }
                }
 
-               if(event.GUIEvent.EventType == gui::EGET_EDITBOX_ENTER) {
-                       if(event.GUIEvent.Caller->getID() > 257) {
+               if (event.GUIEvent.EventType == gui::EGET_EDITBOX_ENTER) {
+                       if (event.GUIEvent.Caller->getID() > 257) {
 
                                if (m_allowclose) {
                                        acceptInput(quit_mode_accept);
@@ -3470,11 +3579,11 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        }
                }
 
-               if(event.GUIEvent.EventType == gui::EGET_TABLE_CHANGED) {
+               if (event.GUIEvent.EventType == gui::EGET_TABLE_CHANGED) {
                        int current_id = event.GUIEvent.Caller->getID();
-                       if(current_id > 257) {
+                       if (current_id > 257) {
                                // find the element that was clicked
-                               for(u32 i=0; i<m_fields.size(); i++) {
+                               for (u32 i = 0; i < m_fields.size(); i++) {
                                        FieldSpec &s = m_fields[i];
                                        // if it's a table, set the send field
                                        // so lua knows which table was changed
@@ -3500,7 +3609,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 std::string GUIFormSpecMenu::getNameByID(s32 id)
 {
        for(std::vector<FieldSpec>::iterator iter =  m_fields.begin();
-                               iter != m_fields.end(); iter++) {
+                               iter != m_fields.end(); ++iter) {
                if (iter->fid == id) {
                        return iter->fname;
                }
@@ -3516,7 +3625,7 @@ std::string GUIFormSpecMenu::getNameByID(s32 id)
 std::wstring GUIFormSpecMenu::getLabelByID(s32 id)
 {
        for(std::vector<FieldSpec>::iterator iter =  m_fields.begin();
-                               iter != m_fields.end(); iter++) {
+                               iter != m_fields.end(); ++iter) {
                if (iter->fid == id) {
                        return iter->flabel;
                }