]> git.lizzy.rs Git - minetest.git/blobdiff - src/guiFormSpecMenu.cpp
dofile error reporting for syntax errors
[minetest.git] / src / guiFormSpecMenu.cpp
index d6a4b4f47e24d8024b7a53bc2b9a3f42fefa29d2..ac230e425280af0e82d967359bbcd3cb7301b1bb 100644 (file)
@@ -37,18 +37,20 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include <IGUITabControl.h>
 #include <IGUIComboBox.h>
 #include "log.h"
-#include "tile.h" // ITextureSource
+#include "client/tile.h" // ITextureSource
 #include "hud.h" // drawItemStack
-#include "hex.h"
-#include "util/string.h"
-#include "util/numeric.h"
 #include "filesys.h"
 #include "gettime.h"
 #include "gettext.h"
 #include "scripting_game.h"
 #include "porting.h"
-#include "main.h"
 #include "settings.h"
+#include "client.h"
+#include "fontengine.h"
+#include "util/hex.h"
+#include "util/numeric.h"
+#include "util/string.h" // for parseColorString()
+#include "guiscalingfilter.h"
 
 #define MY_CHECKPOS(a,b)                                                                                                       \
        if (v_pos.size() != 2) {                                                                                                \
@@ -66,29 +68,37 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 /*
        GUIFormSpecMenu
 */
+static unsigned int font_line_height(gui::IGUIFont *font)
+{
+       return font->getDimension(L"Ay").Height + font->getKerningHeight();
+}
 
 GUIFormSpecMenu::GUIFormSpecMenu(irr::IrrlichtDevice* dev,
                gui::IGUIElement* parent, s32 id, IMenuManager *menumgr,
                InventoryManager *invmgr, IGameDef *gamedef,
                ISimpleTextureSource *tsrc, IFormSource* fsrc, TextDest* tdst,
-               GUIFormSpecMenu** ext_ptr) :
+               Client* client, bool remap_dbl_click) :
        GUIModalMenu(dev->getGUIEnvironment(), parent, id, menumgr),
        m_device(dev),
        m_invmgr(invmgr),
        m_gamedef(gamedef),
        m_tsrc(tsrc),
+       m_client(client),
        m_selected_item(NULL),
        m_selected_amount(0),
        m_selected_dragging(false),
        m_tooltip_element(NULL),
+       m_hovered_time(0),
        m_old_tooltip_id(-1),
+       m_rmouse_auto_place(false),
        m_allowclose(true),
        m_lock(false),
        m_form_src(fsrc),
        m_text_dst(tdst),
-       m_ext_ptr(ext_ptr),
-       m_font(dev->getGUIEnvironment()->getSkin()->getFont()),
-       m_formspec_version(0)
+       m_formspec_version(0),
+       m_focused_element(L""),
+       m_font(NULL),
+       m_remap_dbl_click(remap_dbl_click)
 #ifdef __ANDROID__
        ,m_JavaDialogFieldName(L"")
 #endif
@@ -105,9 +115,6 @@ GUIFormSpecMenu::GUIFormSpecMenu(irr::IrrlichtDevice* dev,
        m_doubleclickdetect[1].pos = v2s32(0, 0);
 
        m_tooltip_show_delay = (u32)g_settings->getS32("tooltip_show_delay");
-
-       m_btn_height = g_settings->getS32("font_size") +2;
-       assert(m_btn_height > 0);
 }
 
 GUIFormSpecMenu::~GUIFormSpecMenu()
@@ -127,11 +134,6 @@ GUIFormSpecMenu::~GUIFormSpecMenu()
        if (m_text_dst != NULL) {
                delete m_text_dst;
        }
-
-       if (m_ext_ptr != NULL) {
-               assert(*m_ext_ptr == this);
-               *m_ext_ptr = NULL;
-       }
 }
 
 void GUIFormSpecMenu::removeChildren()
@@ -234,28 +236,27 @@ GUITable* GUIFormSpecMenu::getTable(std::wstring tablename)
        return 0;
 }
 
-std::vector<std::string> split(const std::string &s, char delim) {
+static std::vector<std::string> split(const std::string &s, char delim)
+{
        std::vector<std::string> tokens;
 
        std::string current = "";
        bool last_was_escape = false;
-       for(unsigned int i=0; i < s.size(); i++) {
+       for (unsigned int i = 0; i < s.size(); i++) {
+               char si = s.c_str()[i];
                if (last_was_escape) {
                        current += '\\';
-                       current += s.c_str()[i];
+                       current += si;
                        last_was_escape = false;
-               }
-               else {
-                       if (s.c_str()[i] == delim) {
+               } else {
+                       if (si == delim) {
                                tokens.push_back(current);
                                current = "";
                                last_was_escape = false;
-                       }
-                       else if (s.c_str()[i] == '\\'){
+                       } else if (si == '\\') {
                                last_was_escape = true;
-                       }
-                       else {
-                               current += s.c_str()[i];
+                       } else {
+                               current += si;
                                last_was_escape = false;
                        }
                }
@@ -273,13 +274,11 @@ void GUIFormSpecMenu::parseSize(parserData* data,std::string element)
        if (((parts.size() == 2) || parts.size() == 3) ||
                ((parts.size() > 3) && (m_formspec_version > FORMSPEC_API_VERSION)))
        {
-               v2f invsize;
-
                if (parts[1].find(';') != std::string::npos)
                        parts[1] = parts[1].substr(0,parts[1].find(';'));
 
-               invsize.X = stof(parts[0]);
-               invsize.Y = stof(parts[1]);
+               data->invsize.X = MYMAX(0, stof(parts[0]));
+               data->invsize.Y = MYMAX(0, stof(parts[1]));
 
                lockSize(false);
                if (parts.size() == 3) {
@@ -288,70 +287,7 @@ void GUIFormSpecMenu::parseSize(parserData* data,std::string element)
                        }
                }
 
-               double cur_scaling = porting::getDisplayDensity() *
-                               g_settings->getFloat("gui_scaling");
-
-               if (m_lock) {
-                       v2u32 current_screensize = m_device->getVideoDriver()->getScreenSize();
-                       v2u32 delta = current_screensize - m_lockscreensize;
-
-                       if (current_screensize.Y > m_lockscreensize.Y)
-                               delta.Y /= 2;
-                       else
-                               delta.Y = 0;
-
-                       if (current_screensize.X > m_lockscreensize.X)
-                               delta.X /= 2;
-                       else
-                               delta.X = 0;
-
-                       offset = v2s32(delta.X,delta.Y);
-
-                       data->screensize = m_lockscreensize;
-
-                       // fixed scaling for fixed size gui elements */
-                       cur_scaling = LEGACY_SCALING;
-               }
-               else {
-                       offset = v2s32(0,0);
-               }
-
-               /* adjust image size to dpi */
-               int y_partition = 15;
-               imgsize = v2s32(data->screensize.Y/y_partition, data->screensize.Y/y_partition);
-               int min_imgsize = DEFAULT_IMGSIZE * cur_scaling;
-               while ((min_imgsize > imgsize.Y) && (y_partition > 1)) {
-                       y_partition--;
-                       imgsize = v2s32(data->screensize.Y/y_partition, data->screensize.Y/y_partition);
-               }
-               assert(y_partition > 0);
-
-               /* adjust spacing to dpi */
-               spacing = v2s32(imgsize.X+(DEFAULT_XSPACING * cur_scaling),
-                               imgsize.Y+(DEFAULT_YSPACING * cur_scaling));
-
-               padding = v2s32(data->screensize.Y/imgsize.Y, data->screensize.Y/imgsize.Y);
-
-               /* adjust padding to dpi */
-               padding = v2s32(
-                               (padding.X/(2.0/3.0)) * cur_scaling,
-                               (padding.X/(2.0/3.0)) * cur_scaling
-                               );
-               data->size = v2s32(
-                       padding.X*2+spacing.X*(invsize.X-1.0)+imgsize.X,
-                       padding.Y*2+spacing.Y*(invsize.Y-1.0)+imgsize.Y + m_btn_height - 5
-               );
-               data->rect = core::rect<s32>(
-                               data->screensize.X/2 - data->size.X/2 + offset.X,
-                               data->screensize.Y/2 - data->size.Y/2 + offset.Y,
-                               data->screensize.X/2 + data->size.X/2 + offset.X,
-                               data->screensize.Y/2 + data->size.Y/2 + offset.Y
-               );
-
-               DesiredRect = data->rect;
-               recalculateAbsolutePosition(false);
-               data->basepos = getBasePos();
-               data->bp_set = 2;
+               data->explicit_size = true;
                return;
        }
        errorstream<< "Invalid size element (" << parts.size() << "): '" << element << "'"  << std::endl;
@@ -404,7 +340,7 @@ void GUIFormSpecMenu::parseList(parserData* data,std::string element)
                        return;
                }
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of list without a size[] element"<<std::endl;
                m_inventorylists.push_back(ListDrawSpec(loc, listname, pos, geom, start_i));
                return;
@@ -416,7 +352,7 @@ void GUIFormSpecMenu::parseCheckbox(parserData* data,std::string element)
 {
        std::vector<std::string> parts = split(element,';');
 
-       if (((parts.size() >= 3) || (parts.size() <= 4)) ||
+       if (((parts.size() >= 3) && (parts.size() <= 4)) ||
                ((parts.size() > 4) && (m_formspec_version > FORMSPEC_API_VERSION)))
        {
                std::vector<std::string> v_pos = split(parts[0],',');
@@ -438,7 +374,7 @@ void GUIFormSpecMenu::parseCheckbox(parserData* data,std::string element)
                if (selected == "true")
                        fselected = true;
 
-               std::wstring wlabel = narrow_to_wide(label.c_str());
+               std::wstring wlabel = narrow_to_wide(label);
 
                core::rect<s32> rect = core::rect<s32>(
                                pos.X, pos.Y + ((imgsize.Y/2) - m_btn_height),
@@ -446,7 +382,7 @@ void GUIFormSpecMenu::parseCheckbox(parserData* data,std::string element)
                                pos.Y + ((imgsize.Y/2) + m_btn_height));
 
                FieldSpec spec(
-                               narrow_to_wide(name.c_str()),
+                               narrow_to_wide(name),
                                wlabel, //Needed for displaying text on MSVC
                                wlabel,
                                258+m_fields.size()
@@ -498,7 +434,7 @@ void GUIFormSpecMenu::parseScrollBar(parserData* data, std::string element)
                                core::rect<s32>(pos.X, pos.Y, pos.X + dim.X, pos.Y + dim.Y);
 
                FieldSpec spec(
-                               narrow_to_wide(name.c_str()),
+                               narrow_to_wide(name),
                                L"",
                                L"",
                                258+m_fields.size()
@@ -520,35 +456,6 @@ void GUIFormSpecMenu::parseScrollBar(parserData* data, std::string element)
                e->setSmallStep(10);
                e->setLargeStep(100);
 
-               if (!m_lock) {
-                       core::rect<s32> relative_rect = e->getRelativePosition();
-
-                       if (!is_horizontal) {
-                               s32 original_width = relative_rect.getWidth();
-                               s32 width = (original_width/(2.0/3.0))
-                                               * porting::getDisplayDensity()
-                                               * g_settings->getFloat("gui_scaling");
-                               e->setRelativePosition(core::rect<s32>(
-                                               relative_rect.UpperLeftCorner.X,
-                                               relative_rect.UpperLeftCorner.Y,
-                                               relative_rect.LowerRightCorner.X + (width - original_width),
-                                               relative_rect.LowerRightCorner.Y
-                                       ));
-                       }
-                       else  {
-                               s32 original_height = relative_rect.getHeight();
-                               s32 height = (original_height/(2.0/3.0))
-                                               * porting::getDisplayDensity()
-                                               * g_settings->getFloat("gui_scaling");
-                               e->setRelativePosition(core::rect<s32>(
-                                               relative_rect.UpperLeftCorner.X,
-                                               relative_rect.UpperLeftCorner.Y,
-                                               relative_rect.LowerRightCorner.X,
-                                               relative_rect.LowerRightCorner.Y + (height - original_height)
-                                       ));
-                       }
-               }
-
                m_scrollbars.push_back(std::pair<FieldSpec,gui::IGUIScrollBar*>(spec,e));
                m_fields.push_back(spec);
                return;
@@ -578,7 +485,7 @@ void GUIFormSpecMenu::parseImage(parserData* data,std::string element)
                geom.X = stof(v_geom[0]) * (float)imgsize.X;
                geom.Y = stof(v_geom[1]) * (float)imgsize.Y;
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of image without a size[] element"<<std::endl;
                m_images.push_back(ImageDrawSpec(name, pos, geom));
                return;
@@ -594,7 +501,7 @@ void GUIFormSpecMenu::parseImage(parserData* data,std::string element)
                pos.X += stof(v_pos[0]) * (float) spacing.X;
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of image without a size[] element"<<std::endl;
                m_images.push_back(ImageDrawSpec(name, pos));
                return;
@@ -624,7 +531,7 @@ void GUIFormSpecMenu::parseItemImage(parserData* data,std::string element)
                geom.X = stof(v_geom[0]) * (float)imgsize.X;
                geom.Y = stof(v_geom[1]) * (float)imgsize.Y;
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of item_image without a size[] element"<<std::endl;
                m_itemimages.push_back(ImageDrawSpec(name, pos, geom));
                return;
@@ -660,15 +567,15 @@ void GUIFormSpecMenu::parseButton(parserData* data,std::string element,
                                core::rect<s32>(pos.X, pos.Y - m_btn_height,
                                                pos.X + geom.X, pos.Y + m_btn_height);
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of button without a size[] element"<<std::endl;
 
                label = unescape_string(label);
 
-               std::wstring wlabel = narrow_to_wide(label.c_str());
+               std::wstring wlabel = narrow_to_wide(label);
 
                FieldSpec spec(
-                       narrow_to_wide(name.c_str()),
+                       narrow_to_wide(name),
                        wlabel,
                        L"",
                        258+m_fields.size()
@@ -719,7 +626,7 @@ void GUIFormSpecMenu::parseBackground(parserData* data,std::string element)
                        }
                }
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of background without a size[] element"<<std::endl;
                m_backgrounds.push_back(ImageDrawSpec(name, pos, geom));
                return;
@@ -790,7 +697,7 @@ void GUIFormSpecMenu::parseTable(parserData* data,std::string element)
 
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
-               std::wstring fname_w = narrow_to_wide(name.c_str());
+               std::wstring fname_w = narrow_to_wide(name);
 
                FieldSpec spec(
                        fname_w,
@@ -864,7 +771,7 @@ void GUIFormSpecMenu::parseTextList(parserData* data,std::string element)
 
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
-               std::wstring fname_w = narrow_to_wide(name.c_str());
+               std::wstring fname_w = narrow_to_wide(name);
 
                FieldSpec spec(
                        fname_w,
@@ -929,7 +836,7 @@ void GUIFormSpecMenu::parseDropDown(parserData* data,std::string element)
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y,
                                pos.X + width, pos.Y + (m_btn_height * 2));
 
-               std::wstring fname_w = narrow_to_wide(name.c_str());
+               std::wstring fname_w = narrow_to_wide(name);
 
                FieldSpec spec(
                        fname_w,
@@ -992,10 +899,10 @@ void GUIFormSpecMenu::parsePwdField(parserData* data,std::string element)
 
                label = unescape_string(label);
 
-               std::wstring wlabel = narrow_to_wide(label.c_str());
+               std::wstring wlabel = narrow_to_wide(label);
 
                FieldSpec spec(
-                       narrow_to_wide(name.c_str()),
+                       narrow_to_wide(name),
                        wlabel,
                        L"",
                        258+m_fields.size()
@@ -1010,8 +917,9 @@ void GUIFormSpecMenu::parsePwdField(parserData* data,std::string element)
 
                if (label.length() >= 1)
                {
-                       rect.UpperLeftCorner.Y -= m_btn_height;
-                       rect.LowerRightCorner.Y = rect.UpperLeftCorner.Y + m_btn_height;
+                       int font_height = g_fontengine->getTextHeight();
+                       rect.UpperLeftCorner.Y -= font_height;
+                       rect.LowerRightCorner.Y = rect.UpperLeftCorner.Y + font_height;
                        Environment->addStaticText(spec.flabel.c_str(), rect, false, true, this, 0);
                }
 
@@ -1040,20 +948,7 @@ void GUIFormSpecMenu::parseSimpleField(parserData* data,
 
        core::rect<s32> rect;
 
-       if(!data->bp_set)
-       {
-               rect = core::rect<s32>(
-                       data->screensize.X/2 - 580/2,
-                       data->screensize.Y/2 - 300/2,
-                       data->screensize.X/2 + 580/2,
-                       data->screensize.Y/2 + 300/2
-               );
-               DesiredRect = rect;
-               recalculateAbsolutePosition(false);
-               data->basepos = getBasePos();
-               data->bp_set = 1;
-       }
-       else if(data->bp_set == 2)
+       if(data->explicit_size)
                errorstream<<"WARNING: invalid use of unpositioned \"field\" in inventory"<<std::endl;
 
        v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
@@ -1070,12 +965,12 @@ void GUIFormSpecMenu::parseSimpleField(parserData* data,
        default_val = unescape_string(default_val);
        label = unescape_string(label);
 
-       std::wstring wlabel = narrow_to_wide(label.c_str());
+       std::wstring wlabel = narrow_to_wide(label);
 
        FieldSpec spec(
-               narrow_to_wide(name.c_str()),
+               narrow_to_wide(name),
                wlabel,
-               narrow_to_wide(default_val.c_str()),
+               narrow_to_wide(default_val),
                258+m_fields.size()
        );
 
@@ -1105,8 +1000,9 @@ void GUIFormSpecMenu::parseSimpleField(parserData* data,
 
                if (label.length() >= 1)
                {
-                       rect.UpperLeftCorner.Y -= m_btn_height;
-                       rect.LowerRightCorner.Y = rect.UpperLeftCorner.Y + m_btn_height;
+                       int font_height = g_fontengine->getTextHeight();
+                       rect.UpperLeftCorner.Y -= font_height;
+                       rect.LowerRightCorner.Y = rect.UpperLeftCorner.Y + font_height;
                        Environment->addStaticText(spec.flabel.c_str(), rect, false, true, this, 0);
                }
        }
@@ -1149,7 +1045,7 @@ void GUIFormSpecMenu::parseTextArea(parserData* data,
 
        core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
-       if(data->bp_set != 2)
+       if(!data->explicit_size)
                errorstream<<"WARNING: invalid use of positioned "<<type<<" without a size[] element"<<std::endl;
 
        if(m_form_src)
@@ -1159,12 +1055,12 @@ void GUIFormSpecMenu::parseTextArea(parserData* data,
        default_val = unescape_string(default_val);
        label = unescape_string(label);
 
-       std::wstring wlabel = narrow_to_wide(label.c_str());
+       std::wstring wlabel = narrow_to_wide(label);
 
        FieldSpec spec(
-               narrow_to_wide(name.c_str()),
+               narrow_to_wide(name),
                wlabel,
-               narrow_to_wide(default_val.c_str()),
+               narrow_to_wide(default_val),
                258+m_fields.size()
        );
 
@@ -1201,8 +1097,9 @@ void GUIFormSpecMenu::parseTextArea(parserData* data,
 
                if (label.length() >= 1)
                {
-                       rect.UpperLeftCorner.Y -= m_btn_height;
-                       rect.LowerRightCorner.Y = rect.UpperLeftCorner.Y + m_btn_height;
+                       int font_height = g_fontengine->getTextHeight();
+                       rect.UpperLeftCorner.Y -= font_height;
+                       rect.LowerRightCorner.Y = rect.UpperLeftCorner.Y + font_height;
                        Environment->addStaticText(spec.flabel.c_str(), rect, false, true, this, 0);
                }
        }
@@ -1242,28 +1139,44 @@ void GUIFormSpecMenu::parseLabel(parserData* data,std::string element)
 
                v2s32 pos = padding;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
-               pos.Y += stof(v_pos[1]) * (float)spacing.Y;
+               pos.Y += (stof(v_pos[1]) + 7.0/30.0) * (float)spacing.Y;
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of label without a size[] element"<<std::endl;
 
                text = unescape_string(text);
-
-               std::wstring wlabel = narrow_to_wide(text.c_str());
-
-               core::rect<s32> rect = core::rect<s32>(
-                               pos.X, pos.Y+((imgsize.Y/2) - m_btn_height),
+               std::vector<std::string> lines = split(text, '\n');
+
+               for (unsigned int i = 0; i != lines.size(); i++) {
+                       // Lines are spaced at the nominal distance of
+                       // 2/5 inventory slot, even if the font doesn't
+                       // quite match that.  This provides consistent
+                       // form layout, at the expense of sometimes
+                       // having sub-optimal spacing for the font.
+                       // We multiply by 2 and then divide by 5, rather
+                       // than multiply by 0.4, to get exact results
+                       // in the integer cases: 0.4 is not exactly
+                       // representable in binary floating point.
+                       s32 posy = pos.Y + ((float)i) * spacing.Y * 2.0 / 5.0;
+                       std::wstring wlabel = narrow_to_wide(lines[i]);
+                       core::rect<s32> rect = core::rect<s32>(
+                               pos.X, posy - m_btn_height,
                                pos.X + m_font->getDimension(wlabel.c_str()).Width,
-                               pos.Y+((imgsize.Y/2) + m_btn_height));
+                               posy + m_btn_height);
+                       FieldSpec spec(
+                               L"",
+                               wlabel,
+                               L"",
+                               258+m_fields.size()
+                       );
+                       gui::IGUIStaticText *e =
+                               Environment->addStaticText(spec.flabel.c_str(),
+                                       rect, false, false, this, spec.fid);
+                       e->setTextAlignment(gui::EGUIA_UPPERLEFT,
+                                               gui::EGUIA_CENTER);
+                       m_fields.push_back(spec);
+               }
 
-               FieldSpec spec(
-                       L"",
-                       wlabel,
-                       L"",
-                       258+m_fields.size()
-               );
-               Environment->addStaticText(spec.flabel.c_str(), rect, false, false, this, spec.fid);
-               m_fields.push_back(spec);
                return;
        }
        errorstream<< "Invalid label element(" << parts.size() << "): '" << element << "'"  << std::endl;
@@ -1288,12 +1201,12 @@ void GUIFormSpecMenu::parseVertLabel(parserData* data,std::string element)
                core::rect<s32> rect = core::rect<s32>(
                                pos.X, pos.Y+((imgsize.Y/2)- m_btn_height),
                                pos.X+15, pos.Y +
-                                       (m_font->getKerningHeight() +
-                                       m_font->getDimension(text.c_str()).Height)
-                                       * (text.length()+1));
+                                       font_line_height(m_font)
+                                       * (text.length()+1)
+                                       +((imgsize.Y/2)- m_btn_height));
                //actually text.length() would be correct but adding +1 avoids to break all mods
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of label without a size[] element"<<std::endl;
 
                std::wstring label = L"";
@@ -1359,19 +1272,19 @@ void GUIFormSpecMenu::parseImageButton(parserData* data,std::string element,
 
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of image_button without a size[] element"<<std::endl;
 
                image_name = unescape_string(image_name);
                pressed_image_name = unescape_string(pressed_image_name);
                label = unescape_string(label);
 
-               std::wstring wlabel = narrow_to_wide(label.c_str());
+               std::wstring wlabel = narrow_to_wide(label);
 
                FieldSpec spec(
-                       narrow_to_wide(name.c_str()),
+                       narrow_to_wide(name),
                        wlabel,
-                       narrow_to_wide(image_name.c_str()),
+                       narrow_to_wide(image_name),
                        258+m_fields.size()
                );
                spec.ftype = f_Button;
@@ -1393,8 +1306,10 @@ void GUIFormSpecMenu::parseImageButton(parserData* data,std::string element,
                }
 
                e->setUseAlphaChannel(true);
-               e->setImage(texture);
-               e->setPressedImage(pressed_texture);
+               e->setImage(guiScalingImageButton(
+                       Environment->getVideoDriver(), texture, geom.X, geom.Y));
+               e->setPressedImage(guiScalingImageButton(
+                       Environment->getVideoDriver(), pressed_texture, geom.X, geom.Y));
                e->setScaleImage(true);
                e->setNotClipped(noclip);
                e->setDrawBorder(drawborder);
@@ -1431,7 +1346,7 @@ void GUIFormSpecMenu::parseTabHeader(parserData* data,std::string element)
                }
 
                FieldSpec spec(
-                       narrow_to_wide(name.c_str()),
+                       narrow_to_wide(name),
                        L"",
                        L"",
                        258+m_fields.size()
@@ -1443,7 +1358,7 @@ void GUIFormSpecMenu::parseTabHeader(parserData* data,std::string element)
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y - m_btn_height * 2;
                v2s32 geom;
-               geom.X = data->screensize.Y;
+               geom.X = DesiredRect.getWidth();
                geom.Y = m_btn_height*2;
 
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X,
@@ -1510,7 +1425,7 @@ void GUIFormSpecMenu::parseItemImageButton(parserData* data,std::string element)
 
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of item_image_button without a size[] element"<<std::endl;
 
                IItemDefManager *idef = m_gamedef->idef();
@@ -1518,16 +1433,16 @@ void GUIFormSpecMenu::parseItemImageButton(parserData* data,std::string element)
                item.deSerialize(item_name, idef);
                video::ITexture *texture = idef->getInventoryTexture(item.getDefinition(idef).name, m_gamedef);
 
-               m_tooltips[narrow_to_wide(name.c_str())] =
-                       TooltipSpec (item.getDefinition(idef).description,
+               m_tooltips[narrow_to_wide(name)] =
+                       TooltipSpec(item.getDefinition(idef).description,
                                                m_default_tooltip_bgcolor,
                                                m_default_tooltip_color);
 
                label = unescape_string(label);
                FieldSpec spec(
-                       narrow_to_wide(name.c_str()),
-                       narrow_to_wide(label.c_str()),
-                       narrow_to_wide(item_name.c_str()),
+                       narrow_to_wide(name),
+                       narrow_to_wide(label),
+                       narrow_to_wide(item_name),
                        258+m_fields.size()
                );
 
@@ -1538,8 +1453,8 @@ void GUIFormSpecMenu::parseItemImageButton(parserData* data,std::string element)
                }
 
                e->setUseAlphaChannel(true);
-               e->setImage(texture);
-               e->setPressedImage(texture);
+               e->setImage(guiScalingImageButton(Environment->getVideoDriver(), texture, geom.X, geom.Y));
+               e->setPressedImage(guiScalingImageButton(Environment->getVideoDriver(), texture, geom.X, geom.Y));
                e->setScaleImage(true);
                spec.ftype = f_Button;
                rect+=data->basepos-padding;
@@ -1573,7 +1488,7 @@ void GUIFormSpecMenu::parseBox(parserData* data,std::string element)
 
                video::SColor tmp_color;
 
-               if (parseColor(parts[2], tmp_color, false)) {
+               if (parseColorString(parts[2], tmp_color, false)) {
                        BoxDrawSpec spec(pos, geom, tmp_color);
 
                        m_boxes.push_back(spec);
@@ -1593,7 +1508,7 @@ void GUIFormSpecMenu::parseBackgroundColor(parserData* data,std::string element)
        if (((parts.size() == 1) || (parts.size() == 2)) ||
                ((parts.size() > 2) && (m_formspec_version > FORMSPEC_API_VERSION)))
        {
-               parseColor(parts[0],m_bgcolor,false);
+               parseColorString(parts[0],m_bgcolor,false);
 
                if (parts.size() == 2) {
                        std::string fullscreen = parts[1];
@@ -1611,20 +1526,20 @@ void GUIFormSpecMenu::parseListColors(parserData* data,std::string element)
        if (((parts.size() == 2) || (parts.size() == 3) || (parts.size() == 5)) ||
                ((parts.size() > 5) && (m_formspec_version > FORMSPEC_API_VERSION)))
        {
-               parseColor(parts[0], m_slotbg_n, false);
-               parseColor(parts[1], m_slotbg_h, false);
+               parseColorString(parts[0], m_slotbg_n, false);
+               parseColorString(parts[1], m_slotbg_h, false);
 
                if (parts.size() >= 3) {
-                       if (parseColor(parts[2], m_slotbordercolor, false)) {
+                       if (parseColorString(parts[2], m_slotbordercolor, false)) {
                                m_slotborder = true;
                        }
                }
                if (parts.size() == 5) {
                        video::SColor tmp_color;
 
-                       if (parseColor(parts[3], tmp_color, false))
+                       if (parseColorString(parts[3], tmp_color, false))
                                m_default_tooltip_bgcolor = tmp_color;
-                       if (parseColor(parts[4], tmp_color, false))
+                       if (parseColorString(parts[4], tmp_color, false))
                                m_default_tooltip_color = tmp_color;
                }
                return;
@@ -1637,13 +1552,15 @@ void GUIFormSpecMenu::parseTooltip(parserData* data, std::string element)
        std::vector<std::string> parts = split(element,';');
        if (parts.size() == 2) {
                std::string name = parts[0];
-               m_tooltips[narrow_to_wide(name.c_str())] = TooltipSpec (parts[1], m_default_tooltip_bgcolor, m_default_tooltip_color);
+               m_tooltips[narrow_to_wide(name)] = TooltipSpec(unescape_string(parts[1]),
+                       m_default_tooltip_bgcolor, m_default_tooltip_color);
                return;
        } else if (parts.size() == 4) {
                std::string name = parts[0];
                video::SColor tmp_color1, tmp_color2;
-               if ( parseColor(parts[2], tmp_color1, false) && parseColor(parts[3], tmp_color2, false) ) {
-                       m_tooltips[narrow_to_wide(name.c_str())] = TooltipSpec (parts[1], tmp_color1, tmp_color2);
+               if ( parseColorString(parts[2], tmp_color1, false) && parseColorString(parts[3], tmp_color2, false) ) {
+                       m_tooltips[narrow_to_wide(name)] = TooltipSpec(unescape_string(parts[1]),
+                               tmp_color1, tmp_color2);
                        return;
                }
        }
@@ -1674,6 +1591,30 @@ bool GUIFormSpecMenu::parseVersionDirect(std::string data)
        return false;
 }
 
+bool GUIFormSpecMenu::parseSizeDirect(parserData* data, std::string element)
+{
+       if (element == "")
+               return false;
+
+       std::vector<std::string> parts = split(element,'[');
+
+       if (parts.size() < 2)
+               return false;
+
+       std::string type = trim(parts[0]);
+       std::string description = trim(parts[1]);
+
+       if (type != "size" && type != "invsize")
+               return false;
+
+       if (type == "invsize")
+               log_deprecated("Deprecated formspec element \"invsize\" is used");
+
+       parseSize(data, description);
+
+       return true;
+}
+
 void GUIFormSpecMenu::parseElement(parserData* data, std::string element)
 {
        //some prechecks
@@ -1699,17 +1640,6 @@ void GUIFormSpecMenu::parseElement(parserData* data, std::string element)
        std::string type = trim(parts[0]);
        std::string description = trim(parts[1]);
 
-       if (type == "size") {
-               parseSize(data,description);
-               return;
-       }
-
-       if (type == "invsize") {
-               log_deprecated("Deprecated formspec element \"invsize\" is used");
-               parseSize(data,description);
-               return;
-       }
-
        if (type == "list") {
                parseList(data,description);
                return;
@@ -1831,8 +1761,6 @@ void GUIFormSpecMenu::parseElement(parserData* data, std::string element)
                <<std::endl;
 }
 
-
-
 void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
 {
        /* useless to regenerate without a screensize */
@@ -1849,6 +1777,10 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
                mydata.table_dyndata[tablename] = table->getDynamicData();
        }
 
+       //set focus
+       if (!m_focused_element.empty())
+               mydata.focused_fieldname = m_focused_element;
+
        //preserve focus
        gui::IGUIElement *focused_element = Environment->getFocus();
        if (focused_element && focused_element->getParent() == this) {
@@ -1878,12 +1810,6 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
        // Base position of contents of form
        mydata.basepos = getBasePos();
 
-       // State of basepos, 0 = not set, 1= set by formspec, 2 = set by size[] element
-       // Used to adjust form size automatically if needed
-       // A proceed button is added if there is no size[] element
-       mydata.bp_set = 0;
-
-
        /* Convert m_init_draw_spec to m_inventorylists */
 
        m_inventorylists.clear();
@@ -1937,13 +1863,131 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
                }
        }
 
+       /* we need size first in order to calculate image scale */
+       mydata.explicit_size = false;
+       for (; i< elements.size(); i++) {
+               if (!parseSizeDirect(&mydata, elements[i])) {
+                       break;
+               }
+       }
+
+       if (mydata.explicit_size) {
+               // compute scaling for specified form size
+               if (m_lock) {
+                       v2u32 current_screensize = m_device->getVideoDriver()->getScreenSize();
+                       v2u32 delta = current_screensize - m_lockscreensize;
+
+                       if (current_screensize.Y > m_lockscreensize.Y)
+                               delta.Y /= 2;
+                       else
+                               delta.Y = 0;
+
+                       if (current_screensize.X > m_lockscreensize.X)
+                               delta.X /= 2;
+                       else
+                               delta.X = 0;
+
+                       offset = v2s32(delta.X,delta.Y);
+
+                       mydata.screensize = m_lockscreensize;
+               } else {
+                       offset = v2s32(0,0);
+               }
+
+               double gui_scaling = g_settings->getFloat("gui_scaling");
+               double screen_dpi = porting::getDisplayDensity() * 96;
+
+               double use_imgsize;
+               if (m_lock) {
+                       // In fixed-size mode, inventory image size
+                       // is 0.53 inch multiplied by the gui_scaling
+                       // config parameter.  This magic size is chosen
+                       // to make the main menu (15.5 inventory images
+                       // wide, including border) just fit into the
+                       // default window (800 pixels wide) at 96 DPI
+                       // and default scaling (1.00).
+                       use_imgsize = 0.5555 * screen_dpi * gui_scaling;
+               } else {
+                       // In variable-size mode, we prefer to make the
+                       // inventory image size 1/15 of screen height,
+                       // multiplied by the gui_scaling config parameter.
+                       // If the preferred size won't fit the whole
+                       // form on the screen, either horizontally or
+                       // vertically, then we scale it down to fit.
+                       // (The magic numbers in the computation of what
+                       // fits arise from the scaling factors in the
+                       // following stanza, including the form border,
+                       // help text space, and 0.1 inventory slot spare.)
+                       // However, a minimum size is also set, that
+                       // the image size can't be less than 0.3 inch
+                       // multiplied by gui_scaling, even if this means
+                       // the form doesn't fit the screen.
+                       double prefer_imgsize = mydata.screensize.Y / 15 *
+                                                       gui_scaling;
+                       double fitx_imgsize = mydata.screensize.X /
+                               ((5.0/4.0) * (0.5 + mydata.invsize.X));
+                       double fity_imgsize = mydata.screensize.Y /
+                               ((15.0/13.0) * (0.85 * mydata.invsize.Y));
+                       double screen_dpi = porting::getDisplayDensity() * 96;
+                       double min_imgsize = 0.3 * screen_dpi * gui_scaling;
+                       use_imgsize = MYMAX(min_imgsize, MYMIN(prefer_imgsize,
+                               MYMIN(fitx_imgsize, fity_imgsize)));
+               }
+
+               // Everything else is scaled in proportion to the
+               // inventory image size.  The inventory slot spacing
+               // is 5/4 image size horizontally and 15/13 image size
+               // vertically.  The padding around the form (incorporating
+               // the border of the outer inventory slots) is 3/8
+               // image size.  Font height (baseline to baseline)
+               // is 2/5 vertical inventory slot spacing, and button
+               // half-height is 7/8 of font height.
+               imgsize = v2s32(use_imgsize, use_imgsize);
+               spacing = v2s32(use_imgsize*5.0/4, use_imgsize*15.0/13);
+               padding = v2s32(use_imgsize*3.0/8, use_imgsize*3.0/8);
+               m_btn_height = use_imgsize*15.0/13 * 0.35;
+
+               m_font = g_fontengine->getFont();
+
+               mydata.size = v2s32(
+                       padding.X*2+spacing.X*(mydata.invsize.X-1.0)+imgsize.X,
+                       padding.Y*2+spacing.Y*(mydata.invsize.Y-1.0)+imgsize.Y + m_btn_height*2.0/3.0
+               );
+               DesiredRect = mydata.rect = core::rect<s32>(
+                               mydata.screensize.X/2 - mydata.size.X/2 + offset.X,
+                               mydata.screensize.Y/2 - mydata.size.Y/2 + offset.Y,
+                               mydata.screensize.X/2 + mydata.size.X/2 + offset.X,
+                               mydata.screensize.Y/2 + mydata.size.Y/2 + offset.Y
+               );
+       } else {
+               // Non-size[] form must consist only of text fields and
+               // implicit "Proceed" button.  Use default font, and
+               // temporary form size which will be recalculated below.
+               m_font = g_fontengine->getFont();
+               m_btn_height = font_line_height(m_font) * 0.875;
+               DesiredRect = core::rect<s32>(
+                       mydata.screensize.X/2 - 580/2,
+                       mydata.screensize.Y/2 - 300/2,
+                       mydata.screensize.X/2 + 580/2,
+                       mydata.screensize.Y/2 + 300/2
+               );
+       }
+       recalculateAbsolutePosition(false);
+       mydata.basepos = getBasePos();
+       m_tooltip_element->setOverrideFont(m_font);
+
+       gui::IGUISkin* skin = Environment->getSkin();
+       sanity_check(skin != NULL);
+       gui::IGUIFont *old_font = skin->getFont();
+       skin->setFont(m_font);
+
        for (; i< elements.size(); i++) {
                parseElement(&mydata, elements[i]);
        }
 
-       // If there's fields, add a Proceed button
-       if (m_fields.size() && mydata.bp_set != 2) {
-               // if the size wasn't set by an invsize[] or size[] adjust it now to fit all the fields
+       // If there are fields without explicit size[], add a "Proceed"
+       // button and adjust size to fit all the fields.
+       if (m_fields.size() && !mydata.explicit_size) {
                mydata.rect = core::rect<s32>(
                                mydata.screensize.X/2 - 580/2,
                                mydata.screensize.Y/2 - 300/2,
@@ -1962,7 +2006,7 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
                        mydata.rect =
                                        core::rect<s32>(size.X/2-70, pos.Y,
                                                        (size.X/2-70)+140, pos.Y + (m_btn_height*2));
-                       wchar_t* text = wgettext("Proceed");
+                       const wchar_t *text = wgettext("Proceed");
                        Environment->addButton(mydata.rect, this, 257, text);
                        delete[] text;
                }
@@ -1975,6 +2019,8 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
                        || !isMyChild(focused_element)
                        || focused_element->getType() == gui::EGUIET_TAB_CONTROL)
                setInitialFocus();
+
+       skin->setFont(old_font);
 }
 
 #ifdef __ANDROID__
@@ -2051,12 +2097,6 @@ void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase)
 {
        video::IVideoDriver* driver = Environment->getVideoDriver();
 
-       // Get font
-       gui::IGUIFont *font = NULL;
-       gui::IGUISkin* skin = Environment->getSkin();
-       if (skin)
-               font = skin->getFont();
-
        Inventory *inv = m_invmgr->getInventory(s.inventoryloc);
        if(!inv){
                infostream<<"GUIFormSpecMenu::drawList(): WARNING: "
@@ -2133,25 +2173,38 @@ void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase)
                        }
                        if(!item.empty())
                        {
-                               drawItemStack(driver, font, item,
+                               drawItemStack(driver, m_font, item,
                                                rect, &AbsoluteClippingRect, m_gamedef);
                        }
 
                        // Draw tooltip
                        std::string tooltip_text = "";
-                       if(hovering && !m_selected_item)
+                       if (hovering && !m_selected_item)
                                tooltip_text = item.getDefinition(m_gamedef->idef()).description;
-                       if(tooltip_text != "")
-                       {
+                       if (tooltip_text != "") {
+                               std::vector<std::string> tt_rows = str_split(tooltip_text, '\n');
                                m_tooltip_element->setBackgroundColor(m_default_tooltip_bgcolor);
                                m_tooltip_element->setOverrideColor(m_default_tooltip_color);
                                m_tooltip_element->setVisible(true);
                                this->bringToFront(m_tooltip_element);
                                m_tooltip_element->setText(narrow_to_wide(tooltip_text).c_str());
-                               s32 tooltip_x = m_pointer.X + m_btn_height;
-                               s32 tooltip_y = m_pointer.Y + m_btn_height;
                                s32 tooltip_width = m_tooltip_element->getTextWidth() + m_btn_height;
-                               s32 tooltip_height = m_tooltip_element->getTextHeight() + 5;
+                               s32 tooltip_height = m_tooltip_element->getTextHeight() * tt_rows.size() + 5;
+                               v2u32 screenSize = driver->getScreenSize();
+                               int tooltip_offset_x = m_btn_height;
+                               int tooltip_offset_y = m_btn_height;
+#ifdef __ANDROID__
+                               tooltip_offset_x *= 3;
+                               tooltip_offset_y  = 0;
+                               if (m_pointer.X > (s32)screenSize.X / 2)
+                                       tooltip_offset_x = (tooltip_offset_x + tooltip_width) * -1;
+#endif
+                               s32 tooltip_x = m_pointer.X + tooltip_offset_x;
+                               s32 tooltip_y = m_pointer.Y + tooltip_offset_y;
+                               if (tooltip_x + tooltip_width > (s32)screenSize.X)
+                                       tooltip_x = (s32)screenSize.X - tooltip_width  - m_btn_height;
+                               if (tooltip_y + tooltip_height > (s32)screenSize.Y)
+                                       tooltip_y = (s32)screenSize.Y - tooltip_height - m_btn_height;
                                m_tooltip_element->setRelativePosition(core::rect<s32>(
                                                core::position2d<s32>(tooltip_x, tooltip_y),
                                                core::dimension2d<s32>(tooltip_width, tooltip_height)));
@@ -2167,22 +2220,16 @@ void GUIFormSpecMenu::drawSelectedItem()
 
        video::IVideoDriver* driver = Environment->getVideoDriver();
 
-       // Get font
-       gui::IGUIFont *font = NULL;
-       gui::IGUISkin* skin = Environment->getSkin();
-       if (skin)
-               font = skin->getFont();
-
        Inventory *inv = m_invmgr->getInventory(m_selected_item->inventoryloc);
-       assert(inv);
+       sanity_check(inv);
        InventoryList *list = inv->getList(m_selected_item->listname);
-       assert(list);
+       sanity_check(list);
        ItemStack stack = list->getItem(m_selected_item->i);
        stack.count = m_selected_amount;
 
        core::rect<s32> imgrect(0,0,imgsize.X,imgsize.Y);
        core::rect<s32> rect = imgrect + (m_pointer - imgrect.getCenter());
-       drawItemStack(driver, font, stack, rect, NULL, m_gamedef);
+       drawItemStack(driver, m_font, stack, rect, NULL, m_gamedef);
 }
 
 void GUIFormSpecMenu::drawMenu()
@@ -2195,11 +2242,13 @@ void GUIFormSpecMenu::drawMenu()
                }
        }
 
+       gui::IGUISkin* skin = Environment->getSkin();
+       sanity_check(skin != NULL);
+       gui::IGUIFont *old_font = skin->getFont();
+       skin->setFont(m_font);
+
        updateSelectedItem();
 
-       gui::IGUISkin* skin = Environment->getSkin();
-       if (!skin)
-               return;
        video::IVideoDriver* driver = Environment->getVideoDriver();
 
        v2u32 screenSize = driver->getScreenSize();
@@ -2235,7 +2284,7 @@ void GUIFormSpecMenu::drawMenu()
 
                        const video::SColor color(255,255,255,255);
                        const video::SColor colors[] = {color,color,color,color};
-                       driver->draw2DImage(texture, rect,
+                       draw2DImageFilterScaled(driver, texture, rect,
                                core::rect<s32>(core::position2d<s32>(0,0),
                                                core::dimension2di(texture->getOriginalSize())),
                                NULL/*&AbsoluteClippingRect*/, colors, true);
@@ -2285,7 +2334,7 @@ void GUIFormSpecMenu::drawMenu()
                        core::rect<s32> rect = imgrect + spec.pos;
                        const video::SColor color(255,255,255,255);
                        const video::SColor colors[] = {color,color,color,color};
-                       driver->draw2DImage(texture, rect,
+                       draw2DImageFilterScaled(driver, texture, rect,
                                core::rect<s32>(core::position2d<s32>(0,0),img_origsize),
                                NULL/*&AbsoluteClippingRect*/, colors, true);
                }
@@ -2314,7 +2363,7 @@ void GUIFormSpecMenu::drawMenu()
                core::rect<s32> rect = imgrect + spec.pos;
                const video::SColor color(255,255,255,255);
                const video::SColor colors[] = {color,color,color,color};
-               driver->draw2DImage(texture, rect,
+               draw2DImageFilterScaled(driver, texture, rect,
                        core::rect<s32>(core::position2d<s32>(0,0),
                                        core::dimension2di(texture->getOriginalSize())),
                        NULL/*&AbsoluteClippingRect*/, colors, true);
@@ -2350,34 +2399,44 @@ void GUIFormSpecMenu::drawMenu()
 
        if (hovered != NULL) {
                s32 id = hovered->getID();
+
+               u32 delta = 0;
                if (id == -1) {
                        m_old_tooltip_id = id;
                        m_old_tooltip = "";
-               } else if (id != m_old_tooltip_id) {
-                       m_hoovered_time = getTimeMs();
-                       m_old_tooltip_id = id;
-               } else if (id == m_old_tooltip_id) {
-                       u32 delta = porting::getDeltaMs(m_hoovered_time, getTimeMs());
-                       if (delta <= m_tooltip_show_delay)
-                               goto skip_tooltip;
+               } else {
+                       if (id == m_old_tooltip_id) {
+                               delta = porting::getDeltaMs(m_hovered_time, getTimeMs());
+                       } else {
+                               m_hovered_time = getTimeMs();
+                               m_old_tooltip_id = id;
+                       }
+               }
+
+               if (id != -1 && delta >= m_tooltip_show_delay) {
                        for(std::vector<FieldSpec>::iterator iter =  m_fields.begin();
                                        iter != m_fields.end(); iter++) {
                                if ( (iter->fid == id) && (m_tooltips[iter->fname].tooltip != "") ){
                                        if (m_old_tooltip != m_tooltips[iter->fname].tooltip) {
                                                m_old_tooltip = m_tooltips[iter->fname].tooltip;
                                                m_tooltip_element->setText(narrow_to_wide(m_tooltips[iter->fname].tooltip).c_str());
-                                               s32 tooltip_x = m_pointer.X + m_btn_height;
-                                               s32 tooltip_y = m_pointer.Y + m_btn_height;
+                                               std::vector<std::string> tt_rows = str_split(m_tooltips[iter->fname].tooltip, '\n');
                                                s32 tooltip_width = m_tooltip_element->getTextWidth() + m_btn_height;
+                                               s32 tooltip_height = m_tooltip_element->getTextHeight() * tt_rows.size() + 5;
+                                               int tooltip_offset_x = m_btn_height;
+                                               int tooltip_offset_y = m_btn_height;
+#ifdef __ANDROID__
+                                               tooltip_offset_x *= 3;
+                                               tooltip_offset_y  = 0;
+                                               if (m_pointer.X > (s32)screenSize.X / 2)
+                                                       tooltip_offset_x = (tooltip_offset_x + tooltip_width) * -1;
+#endif
+                                               s32 tooltip_x = m_pointer.X + tooltip_offset_x;
+                                               s32 tooltip_y = m_pointer.Y + tooltip_offset_y;
                                                if (tooltip_x + tooltip_width > (s32)screenSize.X)
-                                                       tooltip_x = (s32)screenSize.X - tooltip_width - m_btn_height;
-                                               int lines_count = 1;
-                                               size_t i = 0;
-                                               while ((i = m_tooltips[iter->fname].tooltip.find("\n", i)) != std::string::npos) {
-                                                       lines_count++;
-                                                       i += 2;
-                                               }
-                                               s32 tooltip_height = m_tooltip_element->getTextHeight() * lines_count + 5;
+                                                       tooltip_x = (s32)screenSize.X - tooltip_width  - m_btn_height;
+                                               if (tooltip_y + tooltip_height > (s32)screenSize.Y)
+                                                       tooltip_y = (s32)screenSize.Y - tooltip_height - m_btn_height;
                                                m_tooltip_element->setRelativePosition(core::rect<s32>(
                                                core::position2d<s32>(tooltip_x, tooltip_y),
                                                core::dimension2d<s32>(tooltip_width, tooltip_height)));
@@ -2392,11 +2451,12 @@ void GUIFormSpecMenu::drawMenu()
                }
        }
 
-       skip_tooltip:
        /*
                Draw dragged item stack
        */
        drawSelectedItem();
+
+       skin->setFont(old_font);
 }
 
 void GUIFormSpecMenu::updateSelectedItem()
@@ -2518,7 +2578,7 @@ void GUIFormSpecMenu::acceptInput(FormspecQuitMode quitmode=quit_mode_no)
 {
        if(m_text_dst)
        {
-               std::map<std::string, std::string> fields;
+               StringMap fields;
 
                if (quitmode == quit_mode_accept) {
                        fields["quit"] = "true";
@@ -2653,6 +2713,31 @@ static bool isChild(gui::IGUIElement * tocheck, gui::IGUIElement * parent)
 
 bool GUIFormSpecMenu::preprocessEvent(const SEvent& event)
 {
+       // The IGUITabControl renders visually using the skin's selected
+       // font, which we override for the duration of form drawing,
+       // but computes tab hotspots based on how it would have rendered
+       // using the font that is selected at the time of button release.
+       // To make these two consistent, temporarily override the skin's
+       // font while the IGUITabControl is processing the event.
+       if (event.EventType == EET_MOUSE_INPUT_EVENT &&
+                       event.MouseInput.Event == EMIE_LMOUSE_LEFT_UP) {
+               s32 x = event.MouseInput.X;
+               s32 y = event.MouseInput.Y;
+               gui::IGUIElement *hovered =
+                       Environment->getRootGUIElement()->getElementFromPoint(
+                               core::position2d<s32>(x, y));
+               if (hovered && isMyChild(hovered) &&
+                               hovered->getType() == gui::EGUIET_TAB_CONTROL) {
+                       gui::IGUISkin* skin = Environment->getSkin();
+                       sanity_check(skin != NULL);
+                       gui::IGUIFont *old_font = skin->getFont();
+                       skin->setFont(m_font);
+                       bool retval = hovered->OnEvent(event);
+                       skin->setFont(old_font);
+                       return retval;
+               }
+       }
+
        // Fix Esc/Return key being eaten by checkboxen and tables
        if(event.EventType==EET_KEY_INPUT_EVENT) {
                KeyPress kp(event.KeyInput);
@@ -2855,6 +2940,19 @@ bool GUIFormSpecMenu::preprocessEvent(const SEvent& event)
 /******************************************************************************/
 bool GUIFormSpecMenu::DoubleClickDetection(const SEvent event)
 {
+       /* The following code is for capturing double-clicks of the mouse button
+        * and translating the double-click into an EET_KEY_INPUT_EVENT event
+        * -- which closes the form -- under some circumstances.
+        *
+        * There have been many github issues reporting this as a bug even though it
+        * was an intended feature.  For this reason, remapping the double-click as
+        * an ESC must be explicitly set when creating this class via the
+        * /p remap_dbl_click parameter of the constructor.
+        */
+
+       if (!m_remap_dbl_click)
+               return false;
+
        if (event.MouseInput.Event == EMIE_LMOUSE_PRESSED_DOWN) {
                m_doubleclickdetect[0].pos  = m_doubleclickdetect[1].pos;
                m_doubleclickdetect[0].time = m_doubleclickdetect[1].time;
@@ -2893,6 +2991,7 @@ bool GUIFormSpecMenu::DoubleClickDetection(const SEvent event)
                delete translated;
                return true;
        }
+
        return false;
 }
 
@@ -2910,6 +3009,9 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                m_text_dst->gotText(narrow_to_wide("MenuQuit"));
                        }
                        return true;
+               } else if (m_client != NULL && event.KeyInput.PressedDown &&
+                       (kp == getKeySetting("keymap_screenshot"))) {
+                               m_client->makeScreenshot(m_device);
                }
                if (event.KeyInput.PressedDown &&
                        (event.KeyInput.Key==KEY_RETURN ||
@@ -2929,7 +3031,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                break;
                                default:
                                        //can't happen at all!
-                                       assert("reached a source line that can't ever been reached" == 0);
+                                       FATAL_ERROR("Reached a source line that can't ever been reached");
                                        break;
                        }
                        if (current_keys_pending.key_enter && m_allowclose) {
@@ -2943,9 +3045,14 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 
        }
 
-       if(event.EventType==EET_MOUSE_INPUT_EVENT
-                       && event.MouseInput.Event != EMIE_MOUSE_MOVED) {
-               // Mouse event other than movement
+       /* Mouse event other than movement, or crossing the border of inventory
+         field while holding right mouse button
+        */
+       if (event.EventType == EET_MOUSE_INPUT_EVENT &&
+                       (event.MouseInput.Event != EMIE_MOUSE_MOVED ||
+                        (event.MouseInput.Event == EMIE_MOUSE_MOVED &&
+                         event.MouseInput.isRightPressed() &&
+                         getItemAtPos(m_pointer).i != getItemAtPos(m_old_pointer).i))) {
 
                // Get selected item and hovered/clicked item (s)
 
@@ -2958,8 +3065,8 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 
                if(m_selected_item) {
                        inv_selected = m_invmgr->getInventory(m_selected_item->inventoryloc);
-                       assert(inv_selected);
-                       assert(inv_selected->getList(m_selected_item->listname) != NULL);
+                       sanity_check(inv_selected);
+                       sanity_check(inv_selected->getList(m_selected_item->listname) != NULL);
                }
 
                u32 s_count = 0;
@@ -3001,7 +3108,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        (m_selected_item->i == s.i);
 
                // buttons: 0 = left, 1 = right, 2 = middle
-               // up/down: 0 = down (press), 1 = up (release), 2 = unknown event
+               // up/down: 0 = down (press), 1 = up (release), 2 = unknown event, -1 movement
                int button = 0;
                int updown = 2;
                if(event.MouseInput.Event == EMIE_LMOUSE_PRESSED_DOWN)
@@ -3016,6 +3123,8 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        { button = 1; updown = 1; }
                else if(event.MouseInput.Event == EMIE_MMOUSE_LEFT_UP)
                        { button = 2; updown = 1; }
+               else if(event.MouseInput.Event == EMIE_MOUSE_MOVED)
+                       { updown = -1;}
 
                // Set this number to a positive value to generate a move action
                // from m_selected_item to s.
@@ -3053,6 +3162,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                                m_selected_amount = s_count;
 
                                        m_selected_dragging = true;
+                                       m_rmouse_auto_place = false;
                                }
                        }
                        else { // m_selected_item != NULL
@@ -3105,6 +3215,32 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        }
 
                        m_selected_dragging = false;
+                       // Keep count of how many times right mouse button has been
+                       // clicked. One click is drag without dropping. Click + release
+                       // + click changes to drop one item when moved mode
+                       if(button == 1 && m_selected_item != NULL)
+                               m_rmouse_auto_place = !m_rmouse_auto_place;
+               }
+               else if(updown == -1) {
+                       // Mouse has been moved and rmb is down and mouse pointer just
+                       // entered a new inventory field (checked in the entry-if, this
+                       // is the only action here that is generated by mouse movement)
+                       if(m_selected_item != NULL && s.isValid()){
+                               // Move 1 item
+                               // TODO: middle mouse to move 10 items might be handy
+                               if (m_rmouse_auto_place) {
+                                       // Only move an item if the destination slot is empty
+                                       // or contains the same item type as what is going to be
+                                       // moved
+                                       InventoryList *list_from = inv_selected->getList(m_selected_item->listname);
+                                       InventoryList *list_to = inv_s->getList(s.listname);
+                                       assert(list_from && list_to);
+                                       ItemStack stack_from = list_from->getItem(m_selected_item->i);
+                                       ItemStack stack_to = list_to->getItem(s.i);
+                                       if (stack_to.empty() || stack_to.name == stack_from.name)
+                                               move_amount = 1;
+                               }
+                       }
                }
 
                // Possibly send inventory action to server
@@ -3205,6 +3341,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        m_selected_dragging = false;
                        m_selected_content_guess = ItemStack();
                }
+               m_old_pointer = m_pointer;
        }
        if(event.EventType==EET_GUI_EVENT) {
 
@@ -3371,67 +3508,3 @@ std::wstring GUIFormSpecMenu::getLabelByID(s32 id)
        }
        return L"";
 }
-
-bool GUIFormSpecMenu::parseColor(const std::string &value, video::SColor &color,
-               bool quiet)
-{
-       const char *hexpattern = NULL;
-       if (value[0] == '#') {
-               if (value.size() == 9)
-                       hexpattern = "#RRGGBBAA";
-               else if (value.size() == 7)
-                       hexpattern = "#RRGGBB";
-               else if (value.size() == 5)
-                       hexpattern = "#RGBA";
-               else if (value.size() == 4)
-                       hexpattern = "#RGB";
-       }
-
-       if (hexpattern) {
-               assert(strlen(hexpattern) == value.size());
-               video::SColor outcolor(255, 255, 255, 255);
-               for (size_t pos = 0; pos < value.size(); ++pos) {
-                       // '#' in the pattern means skip that character
-                       if (hexpattern[pos] == '#')
-                               continue;
-
-                       // Else assume hexpattern[pos] is one of 'R' 'G' 'B' 'A'
-                       // Read one or two digits, depending on hexpattern
-                       unsigned char c1, c2;
-                       if (hexpattern[pos+1] == hexpattern[pos]) {
-                               // Two digits, e.g. hexpattern == "#RRGGBB"
-                               if (!hex_digit_decode(value[pos], c1) ||
-                                   !hex_digit_decode(value[pos+1], c2))
-                                       goto fail;
-                               ++pos;
-                       }
-                       else {
-                               // One digit, e.g. hexpattern == "#RGB"
-                               if (!hex_digit_decode(value[pos], c1))
-                                       goto fail;
-                               c2 = c1;
-                       }
-                       u32 colorpart = ((c1 & 0x0f) << 4) | (c2 & 0x0f);
-
-                       // Update outcolor with newly read color part
-                       if (hexpattern[pos] == 'R')
-                               outcolor.setRed(colorpart);
-                       else if (hexpattern[pos] == 'G')
-                               outcolor.setGreen(colorpart);
-                       else if (hexpattern[pos] == 'B')
-                               outcolor.setBlue(colorpart);
-                       else if (hexpattern[pos] == 'A')
-                               outcolor.setAlpha(colorpart);
-               }
-
-               color = outcolor;
-               return true;
-       }
-
-       // Optionally, named colors could be implemented here
-
-fail:
-       if (!quiet)
-               errorstream<<"Invalid color: \""<<value<<"\""<<std::endl;
-       return false;
-}