]> git.lizzy.rs Git - minetest.git/blobdiff - src/guiFormSpecMenu.cpp
Performance Improvement: Use a cache which caches result for getFacePositions.
[minetest.git] / src / guiFormSpecMenu.cpp
index edbb595c295348506038377b785d692251af03c5..3f285fa5ec7edf79db6e865a936f854eea27abbb 100644 (file)
@@ -51,6 +51,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "settings.h"
 #include "client.h"
 #include "util/string.h" // for parseColorString()
+#include "fontengine.h"
 
 #define MY_CHECKPOS(a,b)                                                                                                       \
        if (v_pos.size() != 2) {                                                                                                \
@@ -68,6 +69,11 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 /*
        GUIFormSpecMenu
 */
+static unsigned int font_line_height(gui::IGUIFont *font)
+{
+       return font->getDimension(L"Ay").Height + font->getKerningHeight();
+}
+
 GUIFormSpecMenu::GUIFormSpecMenu(irr::IrrlichtDevice* dev,
                gui::IGUIElement* parent, s32 id, IMenuManager *menumgr,
                InventoryManager *invmgr, IGameDef *gamedef,
@@ -85,12 +91,14 @@ GUIFormSpecMenu::GUIFormSpecMenu(irr::IrrlichtDevice* dev,
        m_tooltip_element(NULL),
        m_hovered_time(0),
        m_old_tooltip_id(-1),
+       m_rmouse_auto_place(false),
        m_allowclose(true),
        m_lock(false),
        m_form_src(fsrc),
        m_text_dst(tdst),
-       m_font(dev->getGUIEnvironment()->getSkin()->getFont()),
-       m_formspec_version(0)
+       m_formspec_version(0),
+       m_focused_element(L""),
+       m_font(NULL)
 #ifdef __ANDROID__
        ,m_JavaDialogFieldName(L"")
 #endif
@@ -107,9 +115,6 @@ GUIFormSpecMenu::GUIFormSpecMenu(irr::IrrlichtDevice* dev,
        m_doubleclickdetect[1].pos = v2s32(0, 0);
 
        m_tooltip_show_delay = (u32)g_settings->getS32("tooltip_show_delay");
-
-       m_btn_height = g_settings->getS32("font_size") +2;
-       assert(m_btn_height > 0);
 }
 
 GUIFormSpecMenu::~GUIFormSpecMenu()
@@ -270,13 +275,11 @@ void GUIFormSpecMenu::parseSize(parserData* data,std::string element)
        if (((parts.size() == 2) || parts.size() == 3) ||
                ((parts.size() > 3) && (m_formspec_version > FORMSPEC_API_VERSION)))
        {
-               v2f invsize;
-
                if (parts[1].find(';') != std::string::npos)
                        parts[1] = parts[1].substr(0,parts[1].find(';'));
 
-               invsize.X = stof(parts[0]);
-               invsize.Y = stof(parts[1]);
+               data->invsize.X = MYMAX(0, stof(parts[0]));
+               data->invsize.Y = MYMAX(0, stof(parts[1]));
 
                lockSize(false);
                if (parts.size() == 3) {
@@ -285,70 +288,7 @@ void GUIFormSpecMenu::parseSize(parserData* data,std::string element)
                        }
                }
 
-               double cur_scaling = porting::getDisplayDensity() *
-                               g_settings->getFloat("gui_scaling");
-
-               if (m_lock) {
-                       v2u32 current_screensize = m_device->getVideoDriver()->getScreenSize();
-                       v2u32 delta = current_screensize - m_lockscreensize;
-
-                       if (current_screensize.Y > m_lockscreensize.Y)
-                               delta.Y /= 2;
-                       else
-                               delta.Y = 0;
-
-                       if (current_screensize.X > m_lockscreensize.X)
-                               delta.X /= 2;
-                       else
-                               delta.X = 0;
-
-                       offset = v2s32(delta.X,delta.Y);
-
-                       data->screensize = m_lockscreensize;
-
-                       // fixed scaling for fixed size gui elements */
-                       cur_scaling = LEGACY_SCALING;
-               }
-               else {
-                       offset = v2s32(0,0);
-               }
-
-               /* adjust image size to dpi */
-               int y_partition = 15;
-               imgsize = v2s32(data->screensize.Y/y_partition, data->screensize.Y/y_partition);
-               int min_imgsize = DEFAULT_IMGSIZE * cur_scaling;
-               while ((min_imgsize > imgsize.Y) && (y_partition > 1)) {
-                       y_partition--;
-                       imgsize = v2s32(data->screensize.Y/y_partition, data->screensize.Y/y_partition);
-               }
-               assert(y_partition > 0);
-
-               /* adjust spacing to dpi */
-               spacing = v2s32(imgsize.X+(DEFAULT_XSPACING * cur_scaling),
-                               imgsize.Y+(DEFAULT_YSPACING * cur_scaling));
-
-               padding = v2s32(data->screensize.Y/imgsize.Y, data->screensize.Y/imgsize.Y);
-
-               /* adjust padding to dpi */
-               padding = v2s32(
-                               (padding.X/(2.0/3.0)) * cur_scaling,
-                               (padding.X/(2.0/3.0)) * cur_scaling
-                               );
-               data->size = v2s32(
-                       padding.X*2+spacing.X*(invsize.X-1.0)+imgsize.X,
-                       padding.Y*2+spacing.Y*(invsize.Y-1.0)+imgsize.Y + m_btn_height - 5
-               );
-               data->rect = core::rect<s32>(
-                               data->screensize.X/2 - data->size.X/2 + offset.X,
-                               data->screensize.Y/2 - data->size.Y/2 + offset.Y,
-                               data->screensize.X/2 + data->size.X/2 + offset.X,
-                               data->screensize.Y/2 + data->size.Y/2 + offset.Y
-               );
-
-               DesiredRect = data->rect;
-               recalculateAbsolutePosition(false);
-               data->basepos = getBasePos();
-               data->bp_set = 2;
+               data->explicit_size = true;
                return;
        }
        errorstream<< "Invalid size element (" << parts.size() << "): '" << element << "'"  << std::endl;
@@ -401,7 +341,7 @@ void GUIFormSpecMenu::parseList(parserData* data,std::string element)
                        return;
                }
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of list without a size[] element"<<std::endl;
                m_inventorylists.push_back(ListDrawSpec(loc, listname, pos, geom, start_i));
                return;
@@ -413,7 +353,7 @@ void GUIFormSpecMenu::parseCheckbox(parserData* data,std::string element)
 {
        std::vector<std::string> parts = split(element,';');
 
-       if (((parts.size() >= 3) || (parts.size() <= 4)) ||
+       if (((parts.size() >= 3) && (parts.size() <= 4)) ||
                ((parts.size() > 4) && (m_formspec_version > FORMSPEC_API_VERSION)))
        {
                std::vector<std::string> v_pos = split(parts[0],',');
@@ -435,7 +375,7 @@ void GUIFormSpecMenu::parseCheckbox(parserData* data,std::string element)
                if (selected == "true")
                        fselected = true;
 
-               std::wstring wlabel = narrow_to_wide(label.c_str());
+               std::wstring wlabel = narrow_to_wide(label);
 
                core::rect<s32> rect = core::rect<s32>(
                                pos.X, pos.Y + ((imgsize.Y/2) - m_btn_height),
@@ -443,7 +383,7 @@ void GUIFormSpecMenu::parseCheckbox(parserData* data,std::string element)
                                pos.Y + ((imgsize.Y/2) + m_btn_height));
 
                FieldSpec spec(
-                               narrow_to_wide(name.c_str()),
+                               narrow_to_wide(name),
                                wlabel, //Needed for displaying text on MSVC
                                wlabel,
                                258+m_fields.size()
@@ -495,7 +435,7 @@ void GUIFormSpecMenu::parseScrollBar(parserData* data, std::string element)
                                core::rect<s32>(pos.X, pos.Y, pos.X + dim.X, pos.Y + dim.Y);
 
                FieldSpec spec(
-                               narrow_to_wide(name.c_str()),
+                               narrow_to_wide(name),
                                L"",
                                L"",
                                258+m_fields.size()
@@ -517,35 +457,6 @@ void GUIFormSpecMenu::parseScrollBar(parserData* data, std::string element)
                e->setSmallStep(10);
                e->setLargeStep(100);
 
-               if (!m_lock) {
-                       core::rect<s32> relative_rect = e->getRelativePosition();
-
-                       if (!is_horizontal) {
-                               s32 original_width = relative_rect.getWidth();
-                               s32 width = (original_width/(2.0/3.0))
-                                               * porting::getDisplayDensity()
-                                               * g_settings->getFloat("gui_scaling");
-                               e->setRelativePosition(core::rect<s32>(
-                                               relative_rect.UpperLeftCorner.X,
-                                               relative_rect.UpperLeftCorner.Y,
-                                               relative_rect.LowerRightCorner.X + (width - original_width),
-                                               relative_rect.LowerRightCorner.Y
-                                       ));
-                       }
-                       else  {
-                               s32 original_height = relative_rect.getHeight();
-                               s32 height = (original_height/(2.0/3.0))
-                                               * porting::getDisplayDensity()
-                                               * g_settings->getFloat("gui_scaling");
-                               e->setRelativePosition(core::rect<s32>(
-                                               relative_rect.UpperLeftCorner.X,
-                                               relative_rect.UpperLeftCorner.Y,
-                                               relative_rect.LowerRightCorner.X,
-                                               relative_rect.LowerRightCorner.Y + (height - original_height)
-                                       ));
-                       }
-               }
-
                m_scrollbars.push_back(std::pair<FieldSpec,gui::IGUIScrollBar*>(spec,e));
                m_fields.push_back(spec);
                return;
@@ -575,7 +486,7 @@ void GUIFormSpecMenu::parseImage(parserData* data,std::string element)
                geom.X = stof(v_geom[0]) * (float)imgsize.X;
                geom.Y = stof(v_geom[1]) * (float)imgsize.Y;
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of image without a size[] element"<<std::endl;
                m_images.push_back(ImageDrawSpec(name, pos, geom));
                return;
@@ -591,7 +502,7 @@ void GUIFormSpecMenu::parseImage(parserData* data,std::string element)
                pos.X += stof(v_pos[0]) * (float) spacing.X;
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of image without a size[] element"<<std::endl;
                m_images.push_back(ImageDrawSpec(name, pos));
                return;
@@ -621,7 +532,7 @@ void GUIFormSpecMenu::parseItemImage(parserData* data,std::string element)
                geom.X = stof(v_geom[0]) * (float)imgsize.X;
                geom.Y = stof(v_geom[1]) * (float)imgsize.Y;
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of item_image without a size[] element"<<std::endl;
                m_itemimages.push_back(ImageDrawSpec(name, pos, geom));
                return;
@@ -657,15 +568,15 @@ void GUIFormSpecMenu::parseButton(parserData* data,std::string element,
                                core::rect<s32>(pos.X, pos.Y - m_btn_height,
                                                pos.X + geom.X, pos.Y + m_btn_height);
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of button without a size[] element"<<std::endl;
 
                label = unescape_string(label);
 
-               std::wstring wlabel = narrow_to_wide(label.c_str());
+               std::wstring wlabel = narrow_to_wide(label);
 
                FieldSpec spec(
-                       narrow_to_wide(name.c_str()),
+                       narrow_to_wide(name),
                        wlabel,
                        L"",
                        258+m_fields.size()
@@ -716,7 +627,7 @@ void GUIFormSpecMenu::parseBackground(parserData* data,std::string element)
                        }
                }
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of background without a size[] element"<<std::endl;
                m_backgrounds.push_back(ImageDrawSpec(name, pos, geom));
                return;
@@ -787,7 +698,7 @@ void GUIFormSpecMenu::parseTable(parserData* data,std::string element)
 
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
-               std::wstring fname_w = narrow_to_wide(name.c_str());
+               std::wstring fname_w = narrow_to_wide(name);
 
                FieldSpec spec(
                        fname_w,
@@ -861,7 +772,7 @@ void GUIFormSpecMenu::parseTextList(parserData* data,std::string element)
 
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
-               std::wstring fname_w = narrow_to_wide(name.c_str());
+               std::wstring fname_w = narrow_to_wide(name);
 
                FieldSpec spec(
                        fname_w,
@@ -926,7 +837,7 @@ void GUIFormSpecMenu::parseDropDown(parserData* data,std::string element)
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y,
                                pos.X + width, pos.Y + (m_btn_height * 2));
 
-               std::wstring fname_w = narrow_to_wide(name.c_str());
+               std::wstring fname_w = narrow_to_wide(name);
 
                FieldSpec spec(
                        fname_w,
@@ -989,10 +900,10 @@ void GUIFormSpecMenu::parsePwdField(parserData* data,std::string element)
 
                label = unescape_string(label);
 
-               std::wstring wlabel = narrow_to_wide(label.c_str());
+               std::wstring wlabel = narrow_to_wide(label);
 
                FieldSpec spec(
-                       narrow_to_wide(name.c_str()),
+                       narrow_to_wide(name),
                        wlabel,
                        L"",
                        258+m_fields.size()
@@ -1007,8 +918,9 @@ void GUIFormSpecMenu::parsePwdField(parserData* data,std::string element)
 
                if (label.length() >= 1)
                {
-                       rect.UpperLeftCorner.Y -= m_btn_height;
-                       rect.LowerRightCorner.Y = rect.UpperLeftCorner.Y + m_btn_height;
+                       int font_height = g_fontengine->getTextHeight();
+                       rect.UpperLeftCorner.Y -= font_height;
+                       rect.LowerRightCorner.Y = rect.UpperLeftCorner.Y + font_height;
                        Environment->addStaticText(spec.flabel.c_str(), rect, false, true, this, 0);
                }
 
@@ -1037,20 +949,7 @@ void GUIFormSpecMenu::parseSimpleField(parserData* data,
 
        core::rect<s32> rect;
 
-       if(!data->bp_set)
-       {
-               rect = core::rect<s32>(
-                       data->screensize.X/2 - 580/2,
-                       data->screensize.Y/2 - 300/2,
-                       data->screensize.X/2 + 580/2,
-                       data->screensize.Y/2 + 300/2
-               );
-               DesiredRect = rect;
-               recalculateAbsolutePosition(false);
-               data->basepos = getBasePos();
-               data->bp_set = 1;
-       }
-       else if(data->bp_set == 2)
+       if(data->explicit_size)
                errorstream<<"WARNING: invalid use of unpositioned \"field\" in inventory"<<std::endl;
 
        v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
@@ -1067,12 +966,12 @@ void GUIFormSpecMenu::parseSimpleField(parserData* data,
        default_val = unescape_string(default_val);
        label = unescape_string(label);
 
-       std::wstring wlabel = narrow_to_wide(label.c_str());
+       std::wstring wlabel = narrow_to_wide(label);
 
        FieldSpec spec(
-               narrow_to_wide(name.c_str()),
+               narrow_to_wide(name),
                wlabel,
-               narrow_to_wide(default_val.c_str()),
+               narrow_to_wide(default_val),
                258+m_fields.size()
        );
 
@@ -1102,8 +1001,9 @@ void GUIFormSpecMenu::parseSimpleField(parserData* data,
 
                if (label.length() >= 1)
                {
-                       rect.UpperLeftCorner.Y -= m_btn_height;
-                       rect.LowerRightCorner.Y = rect.UpperLeftCorner.Y + m_btn_height;
+                       int font_height = g_fontengine->getTextHeight();
+                       rect.UpperLeftCorner.Y -= font_height;
+                       rect.LowerRightCorner.Y = rect.UpperLeftCorner.Y + font_height;
                        Environment->addStaticText(spec.flabel.c_str(), rect, false, true, this, 0);
                }
        }
@@ -1146,7 +1046,7 @@ void GUIFormSpecMenu::parseTextArea(parserData* data,
 
        core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
-       if(data->bp_set != 2)
+       if(!data->explicit_size)
                errorstream<<"WARNING: invalid use of positioned "<<type<<" without a size[] element"<<std::endl;
 
        if(m_form_src)
@@ -1156,12 +1056,12 @@ void GUIFormSpecMenu::parseTextArea(parserData* data,
        default_val = unescape_string(default_val);
        label = unescape_string(label);
 
-       std::wstring wlabel = narrow_to_wide(label.c_str());
+       std::wstring wlabel = narrow_to_wide(label);
 
        FieldSpec spec(
-               narrow_to_wide(name.c_str()),
+               narrow_to_wide(name),
                wlabel,
-               narrow_to_wide(default_val.c_str()),
+               narrow_to_wide(default_val),
                258+m_fields.size()
        );
 
@@ -1198,8 +1098,9 @@ void GUIFormSpecMenu::parseTextArea(parserData* data,
 
                if (label.length() >= 1)
                {
-                       rect.UpperLeftCorner.Y -= m_btn_height;
-                       rect.LowerRightCorner.Y = rect.UpperLeftCorner.Y + m_btn_height;
+                       int font_height = g_fontengine->getTextHeight();
+                       rect.UpperLeftCorner.Y -= font_height;
+                       rect.LowerRightCorner.Y = rect.UpperLeftCorner.Y + font_height;
                        Environment->addStaticText(spec.flabel.c_str(), rect, false, true, this, 0);
                }
        }
@@ -1239,28 +1140,44 @@ void GUIFormSpecMenu::parseLabel(parserData* data,std::string element)
 
                v2s32 pos = padding;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
-               pos.Y += stof(v_pos[1]) * (float)spacing.Y;
+               pos.Y += (stof(v_pos[1]) + 7.0/30.0) * (float)spacing.Y;
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of label without a size[] element"<<std::endl;
 
                text = unescape_string(text);
-
-               std::wstring wlabel = narrow_to_wide(text.c_str());
-
-               core::rect<s32> rect = core::rect<s32>(
-                               pos.X, pos.Y+((imgsize.Y/2) - m_btn_height),
+               std::vector<std::string> lines = split(text, '\n');
+
+               for (unsigned int i = 0; i != lines.size(); i++) {
+                       // Lines are spaced at the nominal distance of
+                       // 2/5 inventory slot, even if the font doesn't
+                       // quite match that.  This provides consistent
+                       // form layout, at the expense of sometimes
+                       // having sub-optimal spacing for the font.
+                       // We multiply by 2 and then divide by 5, rather
+                       // than multiply by 0.4, to get exact results
+                       // in the integer cases: 0.4 is not exactly
+                       // representable in binary floating point.
+                       s32 posy = pos.Y + ((float)i) * spacing.Y * 2.0 / 5.0;
+                       std::wstring wlabel = narrow_to_wide(lines[i]);
+                       core::rect<s32> rect = core::rect<s32>(
+                               pos.X, posy - m_btn_height,
                                pos.X + m_font->getDimension(wlabel.c_str()).Width,
-                               pos.Y+((imgsize.Y/2) + m_btn_height));
+                               posy + m_btn_height);
+                       FieldSpec spec(
+                               L"",
+                               wlabel,
+                               L"",
+                               258+m_fields.size()
+                       );
+                       gui::IGUIStaticText *e =
+                               Environment->addStaticText(spec.flabel.c_str(),
+                                       rect, false, false, this, spec.fid);
+                       e->setTextAlignment(gui::EGUIA_UPPERLEFT,
+                                               gui::EGUIA_CENTER);
+                       m_fields.push_back(spec);
+               }
 
-               FieldSpec spec(
-                       L"",
-                       wlabel,
-                       L"",
-                       258+m_fields.size()
-               );
-               Environment->addStaticText(spec.flabel.c_str(), rect, false, false, this, spec.fid);
-               m_fields.push_back(spec);
                return;
        }
        errorstream<< "Invalid label element(" << parts.size() << "): '" << element << "'"  << std::endl;
@@ -1285,12 +1202,12 @@ void GUIFormSpecMenu::parseVertLabel(parserData* data,std::string element)
                core::rect<s32> rect = core::rect<s32>(
                                pos.X, pos.Y+((imgsize.Y/2)- m_btn_height),
                                pos.X+15, pos.Y +
-                                       (m_font->getKerningHeight() +
-                                       m_font->getDimension(text.c_str()).Height)
-                                       * (text.length()+1));
+                                       font_line_height(m_font)
+                                       * (text.length()+1)
+                                       +((imgsize.Y/2)- m_btn_height));
                //actually text.length() would be correct but adding +1 avoids to break all mods
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of label without a size[] element"<<std::endl;
 
                std::wstring label = L"";
@@ -1356,19 +1273,19 @@ void GUIFormSpecMenu::parseImageButton(parserData* data,std::string element,
 
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of image_button without a size[] element"<<std::endl;
 
                image_name = unescape_string(image_name);
                pressed_image_name = unescape_string(pressed_image_name);
                label = unescape_string(label);
 
-               std::wstring wlabel = narrow_to_wide(label.c_str());
+               std::wstring wlabel = narrow_to_wide(label);
 
                FieldSpec spec(
-                       narrow_to_wide(name.c_str()),
+                       narrow_to_wide(name),
                        wlabel,
-                       narrow_to_wide(image_name.c_str()),
+                       narrow_to_wide(image_name),
                        258+m_fields.size()
                );
                spec.ftype = f_Button;
@@ -1428,7 +1345,7 @@ void GUIFormSpecMenu::parseTabHeader(parserData* data,std::string element)
                }
 
                FieldSpec spec(
-                       narrow_to_wide(name.c_str()),
+                       narrow_to_wide(name),
                        L"",
                        L"",
                        258+m_fields.size()
@@ -1440,7 +1357,7 @@ void GUIFormSpecMenu::parseTabHeader(parserData* data,std::string element)
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y - m_btn_height * 2;
                v2s32 geom;
-               geom.X = data->screensize.Y;
+               geom.X = DesiredRect.getWidth();
                geom.Y = m_btn_height*2;
 
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X,
@@ -1507,7 +1424,7 @@ void GUIFormSpecMenu::parseItemImageButton(parserData* data,std::string element)
 
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
-               if(data->bp_set != 2)
+               if(!data->explicit_size)
                        errorstream<<"WARNING: invalid use of item_image_button without a size[] element"<<std::endl;
 
                IItemDefManager *idef = m_gamedef->idef();
@@ -1515,16 +1432,16 @@ void GUIFormSpecMenu::parseItemImageButton(parserData* data,std::string element)
                item.deSerialize(item_name, idef);
                video::ITexture *texture = idef->getInventoryTexture(item.getDefinition(idef).name, m_gamedef);
 
-               m_tooltips[narrow_to_wide(name.c_str())] =
+               m_tooltips[narrow_to_wide(name)] =
                        TooltipSpec (item.getDefinition(idef).description,
                                                m_default_tooltip_bgcolor,
                                                m_default_tooltip_color);
 
                label = unescape_string(label);
                FieldSpec spec(
-                       narrow_to_wide(name.c_str()),
-                       narrow_to_wide(label.c_str()),
-                       narrow_to_wide(item_name.c_str()),
+                       narrow_to_wide(name),
+                       narrow_to_wide(label),
+                       narrow_to_wide(item_name),
                        258+m_fields.size()
                );
 
@@ -1634,13 +1551,13 @@ void GUIFormSpecMenu::parseTooltip(parserData* data, std::string element)
        std::vector<std::string> parts = split(element,';');
        if (parts.size() == 2) {
                std::string name = parts[0];
-               m_tooltips[narrow_to_wide(name.c_str())] = TooltipSpec (parts[1], m_default_tooltip_bgcolor, m_default_tooltip_color);
+               m_tooltips[narrow_to_wide(name)] = TooltipSpec (parts[1], m_default_tooltip_bgcolor, m_default_tooltip_color);
                return;
        } else if (parts.size() == 4) {
                std::string name = parts[0];
                video::SColor tmp_color1, tmp_color2;
                if ( parseColorString(parts[2], tmp_color1, false) && parseColorString(parts[3], tmp_color2, false) ) {
-                       m_tooltips[narrow_to_wide(name.c_str())] = TooltipSpec (parts[1], tmp_color1, tmp_color2);
+                       m_tooltips[narrow_to_wide(name)] = TooltipSpec (parts[1], tmp_color1, tmp_color2);
                        return;
                }
        }
@@ -1671,6 +1588,30 @@ bool GUIFormSpecMenu::parseVersionDirect(std::string data)
        return false;
 }
 
+bool GUIFormSpecMenu::parseSizeDirect(parserData* data, std::string element)
+{
+       if (element == "")
+               return false;
+
+       std::vector<std::string> parts = split(element,'[');
+
+       if (parts.size() < 2)
+               return false;
+
+       std::string type = trim(parts[0]);
+       std::string description = trim(parts[1]);
+
+       if (type != "size" && type != "invsize")
+               return false;
+
+       if (type == "invsize")
+               log_deprecated("Deprecated formspec element \"invsize\" is used");
+
+       parseSize(data, description);
+
+       return true;
+}
+
 void GUIFormSpecMenu::parseElement(parserData* data, std::string element)
 {
        //some prechecks
@@ -1696,17 +1637,6 @@ void GUIFormSpecMenu::parseElement(parserData* data, std::string element)
        std::string type = trim(parts[0]);
        std::string description = trim(parts[1]);
 
-       if (type == "size") {
-               parseSize(data,description);
-               return;
-       }
-
-       if (type == "invsize") {
-               log_deprecated("Deprecated formspec element \"invsize\" is used");
-               parseSize(data,description);
-               return;
-       }
-
        if (type == "list") {
                parseList(data,description);
                return;
@@ -1828,8 +1758,6 @@ void GUIFormSpecMenu::parseElement(parserData* data, std::string element)
                <<std::endl;
 }
 
-
-
 void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
 {
        /* useless to regenerate without a screensize */
@@ -1846,6 +1774,10 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
                mydata.table_dyndata[tablename] = table->getDynamicData();
        }
 
+       //set focus
+       if (!m_focused_element.empty())
+               mydata.focused_fieldname = m_focused_element;
+
        //preserve focus
        gui::IGUIElement *focused_element = Environment->getFocus();
        if (focused_element && focused_element->getParent() == this) {
@@ -1875,12 +1807,6 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
        // Base position of contents of form
        mydata.basepos = getBasePos();
 
-       // State of basepos, 0 = not set, 1= set by formspec, 2 = set by size[] element
-       // Used to adjust form size automatically if needed
-       // A proceed button is added if there is no size[] element
-       mydata.bp_set = 0;
-
-
        /* Convert m_init_draw_spec to m_inventorylists */
 
        m_inventorylists.clear();
@@ -1934,13 +1860,131 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
                }
        }
 
+       /* we need size first in order to calculate image scale */
+       mydata.explicit_size = false;
+       for (; i< elements.size(); i++) {
+               if (!parseSizeDirect(&mydata, elements[i])) {
+                       break;
+               }
+       }
+
+       if (mydata.explicit_size) {
+               // compute scaling for specified form size
+               if (m_lock) {
+                       v2u32 current_screensize = m_device->getVideoDriver()->getScreenSize();
+                       v2u32 delta = current_screensize - m_lockscreensize;
+
+                       if (current_screensize.Y > m_lockscreensize.Y)
+                               delta.Y /= 2;
+                       else
+                               delta.Y = 0;
+
+                       if (current_screensize.X > m_lockscreensize.X)
+                               delta.X /= 2;
+                       else
+                               delta.X = 0;
+
+                       offset = v2s32(delta.X,delta.Y);
+
+                       mydata.screensize = m_lockscreensize;
+               } else {
+                       offset = v2s32(0,0);
+               }
+
+               double gui_scaling = g_settings->getFloat("gui_scaling");
+               double screen_dpi = porting::getDisplayDensity() * 96;
+
+               double use_imgsize;
+               if (m_lock) {
+                       // In fixed-size mode, inventory image size
+                       // is 0.53 inch multiplied by the gui_scaling
+                       // config parameter.  This magic size is chosen
+                       // to make the main menu (15.5 inventory images
+                       // wide, including border) just fit into the
+                       // default window (800 pixels wide) at 96 DPI
+                       // and default scaling (1.00).
+                       use_imgsize = 0.5555 * screen_dpi * gui_scaling;
+               } else {
+                       // In variable-size mode, we prefer to make the
+                       // inventory image size 1/15 of screen height,
+                       // multiplied by the gui_scaling config parameter.
+                       // If the preferred size won't fit the whole
+                       // form on the screen, either horizontally or
+                       // vertically, then we scale it down to fit.
+                       // (The magic numbers in the computation of what
+                       // fits arise from the scaling factors in the
+                       // following stanza, including the form border,
+                       // help text space, and 0.1 inventory slot spare.)
+                       // However, a minimum size is also set, that
+                       // the image size can't be less than 0.3 inch
+                       // multiplied by gui_scaling, even if this means
+                       // the form doesn't fit the screen.
+                       double prefer_imgsize = mydata.screensize.Y / 15 *
+                                                       gui_scaling;
+                       double fitx_imgsize = mydata.screensize.X /
+                               ((5.0/4.0) * (0.5 + mydata.invsize.X));
+                       double fity_imgsize = mydata.screensize.Y /
+                               ((15.0/13.0) * (0.85 * mydata.invsize.Y));
+                       double screen_dpi = porting::getDisplayDensity() * 96;
+                       double min_imgsize = 0.3 * screen_dpi * gui_scaling;
+                       use_imgsize = MYMAX(min_imgsize, MYMIN(prefer_imgsize,
+                               MYMIN(fitx_imgsize, fity_imgsize)));
+               }
+
+               // Everything else is scaled in proportion to the
+               // inventory image size.  The inventory slot spacing
+               // is 5/4 image size horizontally and 15/13 image size
+               // vertically.  The padding around the form (incorporating
+               // the border of the outer inventory slots) is 3/8
+               // image size.  Font height (baseline to baseline)
+               // is 2/5 vertical inventory slot spacing, and button
+               // half-height is 7/8 of font height.
+               imgsize = v2s32(use_imgsize, use_imgsize);
+               spacing = v2s32(use_imgsize*5.0/4, use_imgsize*15.0/13);
+               padding = v2s32(use_imgsize*3.0/8, use_imgsize*3.0/8);
+               m_btn_height = use_imgsize*15.0/13 * 0.35;
+
+               m_font = g_fontengine->getFont();
+
+               mydata.size = v2s32(
+                       padding.X*2+spacing.X*(mydata.invsize.X-1.0)+imgsize.X,
+                       padding.Y*2+spacing.Y*(mydata.invsize.Y-1.0)+imgsize.Y + m_btn_height*2.0/3.0
+               );
+               DesiredRect = mydata.rect = core::rect<s32>(
+                               mydata.screensize.X/2 - mydata.size.X/2 + offset.X,
+                               mydata.screensize.Y/2 - mydata.size.Y/2 + offset.Y,
+                               mydata.screensize.X/2 + mydata.size.X/2 + offset.X,
+                               mydata.screensize.Y/2 + mydata.size.Y/2 + offset.Y
+               );
+       } else {
+               // Non-size[] form must consist only of text fields and
+               // implicit "Proceed" button.  Use default font, and
+               // temporary form size which will be recalculated below.
+               m_font = g_fontengine->getFont();
+               m_btn_height = font_line_height(m_font) * 0.875;
+               DesiredRect = core::rect<s32>(
+                       mydata.screensize.X/2 - 580/2,
+                       mydata.screensize.Y/2 - 300/2,
+                       mydata.screensize.X/2 + 580/2,
+                       mydata.screensize.Y/2 + 300/2
+               );
+       }
+       recalculateAbsolutePosition(false);
+       mydata.basepos = getBasePos();
+       m_tooltip_element->setOverrideFont(m_font);
+
+       gui::IGUISkin* skin = Environment->getSkin();
+       assert(skin != NULL);
+       gui::IGUIFont *old_font = skin->getFont();
+       skin->setFont(m_font);
+
        for (; i< elements.size(); i++) {
                parseElement(&mydata, elements[i]);
        }
 
-       // If there's fields, add a Proceed button
-       if (m_fields.size() && mydata.bp_set != 2) {
-               // if the size wasn't set by an invsize[] or size[] adjust it now to fit all the fields
+       // If there are fields without explicit size[], add a "Proceed"
+       // button and adjust size to fit all the fields.
+       if (m_fields.size() && !mydata.explicit_size) {
                mydata.rect = core::rect<s32>(
                                mydata.screensize.X/2 - 580/2,
                                mydata.screensize.Y/2 - 300/2,
@@ -1959,7 +2003,7 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
                        mydata.rect =
                                        core::rect<s32>(size.X/2-70, pos.Y,
                                                        (size.X/2-70)+140, pos.Y + (m_btn_height*2));
-                       wchar_t* text = wgettext("Proceed");
+                       const wchar_t *text = wgettext("Proceed");
                        Environment->addButton(mydata.rect, this, 257, text);
                        delete[] text;
                }
@@ -1972,6 +2016,8 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
                        || !isMyChild(focused_element)
                        || focused_element->getType() == gui::EGUIET_TAB_CONTROL)
                setInitialFocus();
+
+       skin->setFont(old_font);
 }
 
 #ifdef __ANDROID__
@@ -2048,12 +2094,6 @@ void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase)
 {
        video::IVideoDriver* driver = Environment->getVideoDriver();
 
-       // Get font
-       gui::IGUIFont *font = NULL;
-       gui::IGUISkin* skin = Environment->getSkin();
-       if (skin)
-               font = skin->getFont();
-
        Inventory *inv = m_invmgr->getInventory(s.inventoryloc);
        if(!inv){
                infostream<<"GUIFormSpecMenu::drawList(): WARNING: "
@@ -2130,7 +2170,7 @@ void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase)
                        }
                        if(!item.empty())
                        {
-                               drawItemStack(driver, font, item,
+                               drawItemStack(driver, m_font, item,
                                                rect, &AbsoluteClippingRect, m_gamedef);
                        }
 
@@ -2145,10 +2185,23 @@ void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase)
                                m_tooltip_element->setVisible(true);
                                this->bringToFront(m_tooltip_element);
                                m_tooltip_element->setText(narrow_to_wide(tooltip_text).c_str());
-                               s32 tooltip_x = m_pointer.X + m_btn_height;
-                               s32 tooltip_y = m_pointer.Y + m_btn_height;
                                s32 tooltip_width = m_tooltip_element->getTextWidth() + m_btn_height;
                                s32 tooltip_height = m_tooltip_element->getTextHeight() * tt_rows.size() + 5;
+                               v2u32 screenSize = driver->getScreenSize();
+                               int tooltip_offset_x = m_btn_height;
+                               int tooltip_offset_y = m_btn_height;
+#ifdef __ANDROID__
+                               tooltip_offset_x *= 3;
+                               tooltip_offset_y  = 0;
+                               if (m_pointer.X > (s32)screenSize.X / 2)
+                                       tooltip_offset_x = (tooltip_offset_x + tooltip_width) * -1;
+#endif
+                               s32 tooltip_x = m_pointer.X + tooltip_offset_x;
+                               s32 tooltip_y = m_pointer.Y + tooltip_offset_y;
+                               if (tooltip_x + tooltip_width > (s32)screenSize.X)
+                                       tooltip_x = (s32)screenSize.X - tooltip_width  - m_btn_height;
+                               if (tooltip_y + tooltip_height > (s32)screenSize.Y)
+                                       tooltip_y = (s32)screenSize.Y - tooltip_height - m_btn_height;
                                m_tooltip_element->setRelativePosition(core::rect<s32>(
                                                core::position2d<s32>(tooltip_x, tooltip_y),
                                                core::dimension2d<s32>(tooltip_width, tooltip_height)));
@@ -2164,12 +2217,6 @@ void GUIFormSpecMenu::drawSelectedItem()
 
        video::IVideoDriver* driver = Environment->getVideoDriver();
 
-       // Get font
-       gui::IGUIFont *font = NULL;
-       gui::IGUISkin* skin = Environment->getSkin();
-       if (skin)
-               font = skin->getFont();
-
        Inventory *inv = m_invmgr->getInventory(m_selected_item->inventoryloc);
        assert(inv);
        InventoryList *list = inv->getList(m_selected_item->listname);
@@ -2179,7 +2226,7 @@ void GUIFormSpecMenu::drawSelectedItem()
 
        core::rect<s32> imgrect(0,0,imgsize.X,imgsize.Y);
        core::rect<s32> rect = imgrect + (m_pointer - imgrect.getCenter());
-       drawItemStack(driver, font, stack, rect, NULL, m_gamedef);
+       drawItemStack(driver, m_font, stack, rect, NULL, m_gamedef);
 }
 
 void GUIFormSpecMenu::drawMenu()
@@ -2192,11 +2239,13 @@ void GUIFormSpecMenu::drawMenu()
                }
        }
 
+       gui::IGUISkin* skin = Environment->getSkin();
+       assert(skin != NULL);
+       gui::IGUIFont *old_font = skin->getFont();
+       skin->setFont(m_font);
+
        updateSelectedItem();
 
-       gui::IGUISkin* skin = Environment->getSkin();
-       if (!skin)
-               return;
        video::IVideoDriver* driver = Environment->getVideoDriver();
 
        v2u32 screenSize = driver->getScreenSize();
@@ -2368,13 +2417,23 @@ void GUIFormSpecMenu::drawMenu()
                                        if (m_old_tooltip != m_tooltips[iter->fname].tooltip) {
                                                m_old_tooltip = m_tooltips[iter->fname].tooltip;
                                                m_tooltip_element->setText(narrow_to_wide(m_tooltips[iter->fname].tooltip).c_str());
-                                               s32 tooltip_x = m_pointer.X + m_btn_height;
-                                               s32 tooltip_y = m_pointer.Y + m_btn_height;
-                                               s32 tooltip_width = m_tooltip_element->getTextWidth() + m_btn_height;
-                                               if (tooltip_x + tooltip_width > (s32)screenSize.X)
-                                                       tooltip_x = (s32)screenSize.X - tooltip_width - m_btn_height;
                                                std::vector<std::string> tt_rows = str_split(m_tooltips[iter->fname].tooltip, '\n');
+                                               s32 tooltip_width = m_tooltip_element->getTextWidth() + m_btn_height;
                                                s32 tooltip_height = m_tooltip_element->getTextHeight() * tt_rows.size() + 5;
+                                               int tooltip_offset_x = m_btn_height;
+                                               int tooltip_offset_y = m_btn_height;
+#ifdef __ANDROID__
+                                               tooltip_offset_x *= 3;
+                                               tooltip_offset_y  = 0;
+                                               if (m_pointer.X > (s32)screenSize.X / 2)
+                                                       tooltip_offset_x = (tooltip_offset_x + tooltip_width) * -1;
+#endif
+                                               s32 tooltip_x = m_pointer.X + tooltip_offset_x;
+                                               s32 tooltip_y = m_pointer.Y + tooltip_offset_y;
+                                               if (tooltip_x + tooltip_width > (s32)screenSize.X)
+                                                       tooltip_x = (s32)screenSize.X - tooltip_width  - m_btn_height;
+                                               if (tooltip_y + tooltip_height > (s32)screenSize.Y)
+                                                       tooltip_y = (s32)screenSize.Y - tooltip_height - m_btn_height;
                                                m_tooltip_element->setRelativePosition(core::rect<s32>(
                                                core::position2d<s32>(tooltip_x, tooltip_y),
                                                core::dimension2d<s32>(tooltip_width, tooltip_height)));
@@ -2393,6 +2452,8 @@ void GUIFormSpecMenu::drawMenu()
                Draw dragged item stack
        */
        drawSelectedItem();
+
+       skin->setFont(old_font);
 }
 
 void GUIFormSpecMenu::updateSelectedItem()
@@ -2649,6 +2710,31 @@ static bool isChild(gui::IGUIElement * tocheck, gui::IGUIElement * parent)
 
 bool GUIFormSpecMenu::preprocessEvent(const SEvent& event)
 {
+       // The IGUITabControl renders visually using the skin's selected
+       // font, which we override for the duration of form drawing,
+       // but computes tab hotspots based on how it would have rendered
+       // using the font that is selected at the time of button release.
+       // To make these two consistent, temporarily override the skin's
+       // font while the IGUITabControl is processing the event.
+       if (event.EventType == EET_MOUSE_INPUT_EVENT &&
+                       event.MouseInput.Event == EMIE_LMOUSE_LEFT_UP) {
+               s32 x = event.MouseInput.X;
+               s32 y = event.MouseInput.Y;
+               gui::IGUIElement *hovered =
+                       Environment->getRootGUIElement()->getElementFromPoint(
+                               core::position2d<s32>(x, y));
+               if (hovered && isMyChild(hovered) &&
+                               hovered->getType() == gui::EGUIET_TAB_CONTROL) {
+                       gui::IGUISkin* skin = Environment->getSkin();
+                       assert(skin != NULL);
+                       gui::IGUIFont *old_font = skin->getFont();
+                       skin->setFont(m_font);
+                       bool retval = hovered->OnEvent(event);
+                       skin->setFont(old_font);
+                       return retval;
+               }
+       }
+
        // Fix Esc/Return key being eaten by checkboxen and tables
        if(event.EventType==EET_KEY_INPUT_EVENT) {
                KeyPress kp(event.KeyInput);
@@ -3059,6 +3145,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                                m_selected_amount = s_count;
 
                                        m_selected_dragging = true;
+                                       m_rmouse_auto_place = false;
                                }
                        }
                        else { // m_selected_item != NULL
@@ -3111,6 +3198,11 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        }
 
                        m_selected_dragging = false;
+                       // Keep count of how many times right mouse button has been
+                       // clicked. One click is drag without dropping. Click + release
+                       // + click changes to drop one item when moved mode
+                       if(button == 1 && m_selected_item != NULL)
+                               m_rmouse_auto_place = !m_rmouse_auto_place;
                }
                else if(updown == -1) {
                        // Mouse has been moved and rmb is down and mouse pointer just
@@ -3119,7 +3211,18 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        if(m_selected_item != NULL && s.isValid()){
                                // Move 1 item
                                // TODO: middle mouse to move 10 items might be handy
-                               move_amount = 1;
+                               if (m_rmouse_auto_place) {
+                                       // Only move an item if the destination slot is empty
+                                       // or contains the same item type as what is going to be
+                                       // moved
+                                       InventoryList *list_from = inv_selected->getList(m_selected_item->listname);
+                                       InventoryList *list_to = inv_s->getList(s.listname);
+                                       assert(list_from && list_to);
+                                       ItemStack stack_from = list_from->getItem(m_selected_item->i);
+                                       ItemStack stack_to = list_to->getItem(s.i);
+                                       if (stack_to.empty() || stack_to.name == stack_from.name)
+                                               move_amount = 1;
+                               }
                        }
                }