]> git.lizzy.rs Git - minetest.git/blobdiff - src/filesys.cpp
Fix path detection with --std= parameter
[minetest.git] / src / filesys.cpp
index 21ff199a874c804a03a04c27ef75b2b9cc2b2024..3630df46bf6bd6f53009f633775c925d3df8f8d8 100644 (file)
@@ -18,12 +18,14 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 */
 
 #include "filesys.h"
-#include "strfnd.h"
+#include "util/string.h"
 #include <iostream>
 #include <stdio.h>
 #include <string.h>
 #include <errno.h>
+#include <fstream>
 #include "log.h"
+#include "config.h"
 
 namespace fs
 {
@@ -32,53 +34,28 @@ namespace fs
 
 #define _WIN32_WINNT 0x0501
 #include <windows.h>
-#include <malloc.h>
-#include <tchar.h> 
-#include <wchar.h> 
+#include <shlwapi.h>
 
-#define BUFSIZE MAX_PATH
-
-std::vector<DirListNode> GetDirListing(std::string pathstring)
+std::vector<DirListNode> GetDirListing(const std::string &pathstring)
 {
        std::vector<DirListNode> listing;
 
        WIN32_FIND_DATA FindFileData;
        HANDLE hFind = INVALID_HANDLE_VALUE;
        DWORD dwError;
-       LPTSTR DirSpec;
-       INT retval;
-
-       DirSpec = (LPTSTR) malloc (BUFSIZE);
-
-       if( DirSpec == NULL )
-       {
-         errorstream<<"GetDirListing: Insufficient memory available"<<std::endl;
-         retval = 1;
-         goto Cleanup;
-       }
-
-       // Check that the input is not larger than allowed.
-       if (pathstring.size() > (BUFSIZE - 2))
-       {
-         errorstream<<"GetDirListing: Input directory is too large."<<std::endl;
-         retval = 3;
-         goto Cleanup;
-       }
-
-       //_tprintf (TEXT("Target directory is %s.\n"), pathstring.c_str());
 
-       sprintf(DirSpec, "%s", (pathstring + "\\*").c_str());
+       std::string dirSpec = pathstring + "\\*";
 
        // Find the first file in the directory.
-       hFind = FindFirstFile(DirSpec, &FindFileData);
+       hFind = FindFirstFile(dirSpec.c_str(), &FindFileData);
 
-       if (hFind == INVALID_HANDLE_VALUE) 
-       {
-               retval = (-1);
-               goto Cleanup;
-       } 
-       else 
-       {
+       if (hFind == INVALID_HANDLE_VALUE) {
+               dwError = GetLastError();
+               if (dwError != ERROR_FILE_NOT_FOUND && dwError != ERROR_PATH_NOT_FOUND) {
+                       errorstream << "GetDirListing: FindFirstFile error."
+                                       << " Error is " << dwError << std::endl;
+               }
+       } else {
                // NOTE:
                // Be very sure to not include '..' in the results, it will
                // result in an epic failure when deleting stuff.
@@ -86,12 +63,11 @@ std::vector<DirListNode> GetDirListing(std::string pathstring)
                DirListNode node;
                node.name = FindFileData.cFileName;
                node.dir = FindFileData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY;
-               if(node.name != "." && node.name != "..")
+               if (node.name != "." && node.name != "..")
                        listing.push_back(node);
 
                // List all the other files in the directory.
-               while (FindNextFile(hFind, &FindFileData) != 0) 
-               {
+               while (FindNextFile(hFind, &FindFileData) != 0) {
                        DirListNode node;
                        node.name = FindFileData.cFileName;
                        node.dir = FindFileData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY;
@@ -101,29 +77,17 @@ std::vector<DirListNode> GetDirListing(std::string pathstring)
 
                dwError = GetLastError();
                FindClose(hFind);
-               if (dwError != ERROR_NO_MORE_FILES) 
-               {
-                       errorstream<<"GetDirListing: FindNextFile error. Error is "
-                                       <<dwError<<std::endl;
-                       retval = (-1);
-                       goto Cleanup;
-               }
+               if (dwError != ERROR_NO_MORE_FILES) {
+                       errorstream << "GetDirListing: FindNextFile error."
+                                       << " Error is " << dwError << std::endl;
+                       listing.clear();
+                       return listing;
+               }
        }
-       retval  = 0;
-
-Cleanup:
-       free(DirSpec);
-
-       if(retval != 0) listing.clear();
-
-       //for(unsigned int i=0; i<listing.size(); i++){
-       //      infostream<<listing[i].name<<(listing[i].dir?" (dir)":" (file)")<<std::endl;
-       //}
-       
        return listing;
 }
 
-bool CreateDir(std::string path)
+bool CreateDir(const std::string &path)
 {
        bool r = CreateDirectory(path.c_str(), NULL);
        if(r == true)
@@ -133,12 +97,17 @@ bool CreateDir(std::string path)
        return false;
 }
 
-bool PathExists(std::string path)
+bool PathExists(const std::string &path)
 {
        return (GetFileAttributes(path.c_str()) != INVALID_FILE_ATTRIBUTES);
 }
 
-bool IsDir(std::string path)
+bool IsPathAbsolute(const std::string &path)
+{
+       return !PathIsRelative(path.c_str());
+}
+
+bool IsDir(const std::string &path)
 {
        DWORD attr = GetFileAttributes(path.c_str());
        return (attr != INVALID_FILE_ATTRIBUTES &&
@@ -150,7 +119,7 @@ bool IsDirDelimiter(char c)
        return c == '/' || c == '\\';
 }
 
-bool RecursiveDelete(std::string path)
+bool RecursiveDelete(const std::string &path)
 {
        infostream<<"Recursively deleting \""<<path<<"\""<<std::endl;
 
@@ -195,7 +164,7 @@ bool RecursiveDelete(std::string path)
        return true;
 }
 
-bool DeleteSingleFileOrEmptyDirectory(std::string path)
+bool DeleteSingleFileOrEmptyDirectory(const std::string &path)
 {
        DWORD attr = GetFileAttributes(path.c_str());
        bool is_directory = (attr != INVALID_FILE_ATTRIBUTES &&
@@ -236,62 +205,60 @@ std::string TempPath()
 #include <sys/wait.h>
 #include <unistd.h>
 
-std::vector<DirListNode> GetDirListing(std::string pathstring)
+std::vector<DirListNode> GetDirListing(const std::string &pathstring)
 {
        std::vector<DirListNode> listing;
 
-    DIR *dp;
-    struct dirent *dirp;
-    if((dp  = opendir(pathstring.c_str())) == NULL) {
+       DIR *dp;
+       struct dirent *dirp;
+       if((dp = opendir(pathstring.c_str())) == NULL) {
                //infostream<<"Error("<<errno<<") opening "<<pathstring<<std::endl;
-        return listing;
-    }
+               return listing;
+       }
 
-    while ((dirp = readdir(dp)) != NULL) {
+       while ((dirp = readdir(dp)) != NULL) {
                // NOTE:
                // Be very sure to not include '..' in the results, it will
                // result in an epic failure when deleting stuff.
-               if(dirp->d_name[0]!='.'){
-                       DirListNode node;
-                       node.name = dirp->d_name;
-                       if(node.name == "." || node.name == "..")
-                               continue;
+               if(strcmp(dirp->d_name, ".") == 0 || strcmp(dirp->d_name, "..") == 0)
+                       continue;
 
-                       int isdir = -1; // -1 means unknown
+               DirListNode node;
+               node.name = dirp->d_name;
+
+               int isdir = -1; // -1 means unknown
 
-                       /*
-                               POSIX doesn't define d_type member of struct dirent and
-                               certain filesystems on glibc/Linux will only return
-                               DT_UNKNOWN for the d_type member.
+               /*
+                       POSIX doesn't define d_type member of struct dirent and
+                       certain filesystems on glibc/Linux will only return
+                       DT_UNKNOWN for the d_type member.
 
-                               Also we don't know whether symlinks are directories or not.
-                       */
+                       Also we don't know whether symlinks are directories or not.
+               */
 #ifdef _DIRENT_HAVE_D_TYPE
-                       if(dirp->d_type != DT_UNKNOWN && dirp->d_type != DT_LNK)
-                               isdir = (dirp->d_type == DT_DIR);
+               if(dirp->d_type != DT_UNKNOWN && dirp->d_type != DT_LNK)
+                       isdir = (dirp->d_type == DT_DIR);
 #endif /* _DIRENT_HAVE_D_TYPE */
 
-                       /*
-                               Was d_type DT_UNKNOWN, DT_LNK or nonexistent?
-                               If so, try stat().
-                       */
-                       if(isdir == -1)
-                       {
-                               struct stat statbuf;
-                               if (stat((pathstring + "/" + node.name).c_str(), &statbuf))
-                                       continue;
-                               isdir = ((statbuf.st_mode & S_IFDIR) == S_IFDIR);
-                       }
-                       node.dir = isdir;
-                       listing.push_back(node);
+               /*
+                       Was d_type DT_UNKNOWN, DT_LNK or nonexistent?
+                       If so, try stat().
+               */
+               if(isdir == -1) {
+                       struct stat statbuf;
+                       if (stat((pathstring + "/" + node.name).c_str(), &statbuf))
+                               continue;
+                       isdir = ((statbuf.st_mode & S_IFDIR) == S_IFDIR);
                }
-    }
-    closedir(dp);
+               node.dir = isdir;
+               listing.push_back(node);
+       }
+       closedir(dp);
 
        return listing;
 }
 
-bool CreateDir(std::string path)
+bool CreateDir(const std::string &path)
 {
        int r = mkdir(path.c_str(), S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH);
        if(r == 0)
@@ -307,13 +274,18 @@ bool CreateDir(std::string path)
        }
 }
 
-bool PathExists(std::string path)
+bool PathExists(const std::string &path)
 {
        struct stat st;
        return (stat(path.c_str(),&st) == 0);
 }
 
-bool IsDir(std::string path)
+bool IsPathAbsolute(const std::string &path)
+{
+       return path[0] == '/';
+}
+
+bool IsDir(const std::string &path)
 {
        struct stat statbuf;
        if(stat(path.c_str(), &statbuf))
@@ -326,16 +298,16 @@ bool IsDirDelimiter(char c)
        return c == '/';
 }
 
-bool RecursiveDelete(std::string path)
+bool RecursiveDelete(const std::string &path)
 {
        /*
                Execute the 'rm' command directly, by fork() and execve()
        */
-       
+
        infostream<<"Removing \""<<path<<"\""<<std::endl;
 
        //return false;
-       
+
        pid_t child_pid = fork();
 
        if(child_pid == 0)
@@ -353,9 +325,9 @@ bool RecursiveDelete(std::string path)
 
                verbosestream<<"Executing '"<<argv[0]<<"' '"<<argv[1]<<"' '"
                                <<argv[2]<<"'"<<std::endl;
-               
+
                execv(argv[0], argv);
-               
+
                // Execv shouldn't return. Failed.
                _exit(1);
        }
@@ -372,7 +344,7 @@ bool RecursiveDelete(std::string path)
        }
 }
 
-bool DeleteSingleFileOrEmptyDirectory(std::string path)
+bool DeleteSingleFileOrEmptyDirectory(const std::string &path)
 {
        if(IsDir(path)){
                bool did = (rmdir(path.c_str()) == 0);
@@ -400,19 +372,25 @@ std::string TempPath()
                compatible with lua's os.tmpname which under the default
                configuration hardcodes mkstemp("/tmp/lua_XXXXXX").
        */
-       return std::string(DIR_DELIM) + "tmp";
+#ifdef __ANDROID__
+       return DIR_DELIM "sdcard" DIR_DELIM PROJECT_NAME DIR_DELIM "tmp";
+#else
+       return DIR_DELIM "tmp";
+#endif
 }
 
 #endif
 
-void GetRecursiveSubPaths(std::string path, std::vector<std::string> &dst)
+void GetRecursiveSubPaths(const std::string &path, std::vector<std::string> &dst)
 {
        std::vector<DirListNode> content = GetDirListing(path);
        for(unsigned int  i=0; i<content.size(); i++){
                const DirListNode &n = content[i];
                std::string fullpath = path + DIR_DELIM + n.name;
                dst.push_back(fullpath);
-               GetRecursiveSubPaths(fullpath, dst);
+               if (n.dir) {
+                       GetRecursiveSubPaths(fullpath, dst);
+               }
        }
 }
 
@@ -431,7 +409,7 @@ bool DeletePaths(const std::vector<std::string> &paths)
        return success;
 }
 
-bool RecursiveDeleteContent(std::string path)
+bool RecursiveDeleteContent(const std::string &path)
 {
        infostream<<"Removing content of \""<<path<<"\""<<std::endl;
        std::vector<DirListNode> list = GetDirListing(path);
@@ -450,7 +428,7 @@ bool RecursiveDeleteContent(std::string path)
        return true;
 }
 
-bool CreateAllDirs(std::string path)
+bool CreateAllDirs(const std::string &path)
 {
 
        std::vector<std::string> tocreate;
@@ -468,7 +446,7 @@ bool CreateAllDirs(std::string path)
        return true;
 }
 
-bool CopyFileContents(std::string source, std::string target)
+bool CopyFileContents(const std::string &source, const std::string &target)
 {
        FILE *sourcefile = fopen(source.c_str(), "rb");
        if(sourcefile == NULL){
@@ -522,7 +500,7 @@ bool CopyFileContents(std::string source, std::string target)
        return retval;
 }
 
-bool CopyDir(std::string source, std::string target)
+bool CopyDir(const std::string &source, const std::string &target)
 {
        if(PathExists(source)){
                if(!PathExists(target)){
@@ -552,7 +530,7 @@ bool CopyDir(std::string source, std::string target)
        }
 }
 
-bool PathStartsWith(std::string path, std::string prefix)
+bool PathStartsWith(const std::string &path, const std::string &prefix)
 {
        size_t pathsize = path.size();
        size_t pathpos = 0;
@@ -595,14 +573,14 @@ bool PathStartsWith(std::string path, std::string prefix)
                                        && !IsDirDelimiter(path[pathpos+len])
                                        && prefixpos+len < prefixsize
                                        && !IsDirDelimiter(
-                                               prefix[prefixsize+len]));
+                                               prefix[prefixpos+len]));
                        pathpos += len;
                        prefixpos += len;
                }
        }
 }
 
-std::string RemoveLastPathComponent(std::string path,
+std::string RemoveLastPathComponent(const std::string &path,
                std::string *removed, int count)
 {
        if(removed)
@@ -684,5 +662,31 @@ std::string RemoveRelativePathComponents(std::string path)
        return path.substr(0, pos);
 }
 
+bool safeWriteToFile(const std::string &path, const std::string &content)
+{
+       std::string tmp_file = path + ".~mt";
+
+       // Write to a tmp file
+       std::ofstream os(tmp_file.c_str(), std::ios::binary);
+       if (!os.good())
+               return false;
+       os << content;
+       os.flush();
+       os.close();
+       if (os.fail()) {
+               remove(tmp_file.c_str());
+               return false;
+       }
+
+       // Copy file
+       remove(path.c_str());
+       if(rename(tmp_file.c_str(), path.c_str())) {
+               remove(tmp_file.c_str());
+               return false;
+       } else {
+               return true;
+       }
+}
+
 } // namespace fs