]> git.lizzy.rs Git - dragonfireclient.git/blobdiff - src/emerge.cpp
RemotePlayer/LocalPlayer Player base class proper separation (code cleanup) (patch...
[dragonfireclient.git] / src / emerge.cpp
index dc2bb3e994f6412973f33be7c48978df9b8e3de5..bdb5e0729f5825f195119d3bb673b1f63fd8673b 100644 (file)
@@ -1,6 +1,7 @@
 /*
-Minetest-c55
-Copyright (C) 2010-2011 celeron55, Perttu Ahola <celeron55@gmail.com>
+Minetest
+Copyright (C) 2010-2013 celeron55, Perttu Ahola <celeron55@gmail.com>
+Copyright (C) 2010-2013 kwolekr, Ryan Kwolek <kwolekr@minetest.net>
 
 This program is free software; you can redistribute it and/or modify
 it under the terms of the GNU Lesser General Public License as published by
@@ -18,718 +19,638 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 */
 
 
-#include "server.h"
+#include "emerge.h"
+
 #include <iostream>
 #include <queue>
-#include "clientserver.h"
-#include "map.h"
-#include "jmutexautolock.h"
-#include "main.h"
-#include "constants.h"
-#include "voxel.h"
+
+#include "util/container.h"
+#include "util/thread.h"
+#include "threading/event.h"
+
 #include "config.h"
+#include "constants.h"
+#include "environment.h"
+#include "log.h"
+#include "map.h"
 #include "mapblock.h"
+#include "mg_biome.h"
+#include "mg_ore.h"
+#include "mg_decoration.h"
+#include "mg_schematic.h"
+#include "nodedef.h"
+#include "profiler.h"
+#include "scripting_game.h"
+#include "server.h"
 #include "serverobject.h"
 #include "settings.h"
-#include "script.h"
-#include "scriptapi.h"
-#include "profiler.h"
-#include "log.h"
-#include "nodedef.h"
-#include "biome.h"
-#include "emerge.h"
-#include "mapgen_v6.h"
+#include "voxel.h"
 
+class EmergeThread : public Thread {
+public:
+       bool enable_mapgen_debug_info;
+       int id;
 
-EmergeManager::EmergeManager(IGameDef *gamedef, BiomeDefManager *bdef) {
-       //register built-in mapgens
-       registerMapgen("v6", new MapgenFactoryV6());
+       EmergeThread(Server *server, int ethreadid);
+       ~EmergeThread();
 
-       this->biomedef = bdef ? bdef : new BiomeDefManager(gamedef);
-       this->params   = NULL;
-       
-       mapgen_debug_info = g_settings->getBool("enable_mapgen_debug_info");
+       void *run();
+       void signal();
 
-       queuemutex.Init();
-       
-       int nthreads;
-       if (g_settings->get("num_emerge_threads").empty()) {
-               int nprocs = porting::getNumberOfProcessors();
-               // leave a proc for the main thread and one for some other misc threads
-               nthreads =  (nprocs > 2) ? nthreads = nprocs - 2 : 1;
-       } else {
-               nthreads = g_settings->getU16("num_emerge_threads");
-       }
+       // Requires queue mutex held
+       bool pushBlock(v3s16 pos);
+
+       void cancelPendingItems();
+
+       static void runCompletionCallbacks(
+               v3s16 pos, EmergeAction action,
+               const EmergeCallbackList &callbacks);
+
+private:
+       Server *m_server;
+       ServerMap *m_map;
+       EmergeManager *m_emerge;
+       Mapgen *m_mapgen;
+
+       Event m_queue_event;
+       std::queue<v3s16> m_block_queue;
+
+       bool popBlockEmerge(v3s16 *pos, BlockEmergeData *bedata);
+
+       EmergeAction getBlockOrStartGen(
+               v3s16 pos, bool allow_gen, MapBlock **block, BlockMakeData *data);
+       MapBlock *finishGen(v3s16 pos, BlockMakeData *bmdata,
+               std::map<v3s16, MapBlock *> *modified_blocks);
+
+       friend class EmergeManager;
+};
+
+////
+//// EmergeManager
+////
+
+EmergeManager::EmergeManager(IGameDef *gamedef)
+{
+       this->ndef      = gamedef->getNodeDefManager();
+       this->biomemgr  = new BiomeManager(gamedef);
+       this->oremgr    = new OreManager(gamedef);
+       this->decomgr   = new DecorationManager(gamedef);
+       this->schemmgr  = new SchematicManager(gamedef);
+       this->gen_notify_on = 0;
+
+       // Note that accesses to this variable are not synchronized.
+       // This is because the *only* thread ever starting or stopping
+       // EmergeThreads should be the ServerThread.
+       this->m_threads_active = false;
+
+       enable_mapgen_debug_info = g_settings->getBool("enable_mapgen_debug_info");
+
+       // If unspecified, leave a proc for the main thread and one for
+       // some other misc thread
+       s16 nthreads = 0;
+       if (!g_settings->getS16NoEx("num_emerge_threads", nthreads))
+               nthreads = Thread::getNumberOfProcessors() - 2;
        if (nthreads < 1)
                nthreads = 1;
-       
-       qlimit_total    = g_settings->getU16("emergequeue_limit_total");
-       qlimit_diskonly = g_settings->get("emergequeue_limit_diskonly").empty() ?
-               nthreads * 5 + 1 :
-               g_settings->getU16("emergequeue_limit_diskonly");
-       qlimit_generate = g_settings->get("emergequeue_limit_generate").empty() ?
-               nthreads + 1 :
-               g_settings->getU16("emergequeue_limit_generate");
-       
-       for (int i = 0; i != nthreads; i++)
-               emergethread.push_back(new EmergeThread((Server *)gamedef, i));
-               
+
+       m_qlimit_total = g_settings->getU16("emergequeue_limit_total");
+       if (!g_settings->getU16NoEx("emergequeue_limit_diskonly", m_qlimit_diskonly))
+               m_qlimit_diskonly = nthreads * 5 + 1;
+       if (!g_settings->getU16NoEx("emergequeue_limit_generate", m_qlimit_generate))
+               m_qlimit_generate = nthreads + 1;
+
+       // don't trust user input for something very important like this
+       if (m_qlimit_total < 1)
+               m_qlimit_total = 1;
+       if (m_qlimit_diskonly < 1)
+               m_qlimit_diskonly = 1;
+       if (m_qlimit_generate < 1)
+               m_qlimit_generate = 1;
+
+       for (s16 i = 0; i < nthreads; i++)
+               m_threads.push_back(new EmergeThread((Server *)gamedef, i));
+
        infostream << "EmergeManager: using " << nthreads << " threads" << std::endl;
 }
 
 
-EmergeManager::~EmergeManager() {
-       for (int i = 0; i != emergethread.size(); i++) {
-               emergethread[i]->setRun(false);
-               emergethread[i]->qevent.signal();
-               emergethread[i]->stop();
-               delete emergethread[i];
-               delete mapgen[i];
+EmergeManager::~EmergeManager()
+{
+       for (u32 i = 0; i != m_threads.size(); i++) {
+               EmergeThread *thread = m_threads[i];
+
+               if (m_threads_active) {
+                       thread->stop();
+                       thread->signal();
+                       thread->wait();
+               }
+
+               delete thread;
+               delete m_mapgens[i];
        }
-       
-       delete biomedef;
-       delete params;
+
+       delete biomemgr;
+       delete oremgr;
+       delete decomgr;
+       delete schemmgr;
+}
+
+
+bool EmergeManager::initMapgens(MapgenParams *params)
+{
+       if (m_mapgens.size())
+               return false;
+
+       this->mgparams = params;
+
+       for (u32 i = 0; i != m_threads.size(); i++) {
+               Mapgen *mg = Mapgen::createMapgen(params->mgtype, i, params, this);
+               m_mapgens.push_back(mg);
+       }
+
+       return true;
+}
+
+
+Mapgen *EmergeManager::getCurrentMapgen()
+{
+       for (u32 i = 0; i != m_threads.size(); i++) {
+               if (m_threads[i]->isCurrentThread())
+                       return m_threads[i]->m_mapgen;
+       }
+
+       return NULL;
 }
 
 
-void EmergeManager::initMapgens(MapgenParams *mgparams) {
-       Mapgen *mg;
-       
-       if (mapgen.size())
+void EmergeManager::startThreads()
+{
+       if (m_threads_active)
                return;
-       
-       this->params = mgparams;
-       for (int i = 0; i != emergethread.size(); i++) {
-               mg = createMapgen(params->mg_name, 0, params);
-               if (!mg) {
-                       infostream << "EmergeManager: falling back to mapgen v6" << std::endl;
-                       delete params;
-                       params = createMapgenParams("v6");
-                       mg = createMapgen("v6", 0, params);
-               }
-               mapgen.push_back(mg);
+
+       for (u32 i = 0; i != m_threads.size(); i++)
+               m_threads[i]->start();
+
+       m_threads_active = true;
+}
+
+
+void EmergeManager::stopThreads()
+{
+       if (!m_threads_active)
+               return;
+
+       // Request thread stop in parallel
+       for (u32 i = 0; i != m_threads.size(); i++) {
+               m_threads[i]->stop();
+               m_threads[i]->signal();
        }
+
+       // Then do the waiting for each
+       for (u32 i = 0; i != m_threads.size(); i++)
+               m_threads[i]->wait();
+
+       m_threads_active = false;
+}
+
+
+bool EmergeManager::isRunning()
+{
+       return m_threads_active;
 }
 
 
-bool EmergeManager::enqueueBlockEmerge(u16 peer_id, v3s16 p, bool allow_generate) {
-       std::map<v3s16, BlockEmergeData *>::const_iterator iter;
-       BlockEmergeData *bedata;
-       u16 count;
-       u8 flags = 0;
-       int idx = 0;
-       
+bool EmergeManager::enqueueBlockEmerge(
+       u16 peer_id,
+       v3s16 blockpos,
+       bool allow_generate,
+       bool ignore_queue_limits)
+{
+       u16 flags = 0;
        if (allow_generate)
-               flags |= BLOCK_EMERGE_ALLOWGEN;
+               flags |= BLOCK_EMERGE_ALLOW_GEN;
+       if (ignore_queue_limits)
+               flags |= BLOCK_EMERGE_FORCE_QUEUE;
+
+       return enqueueBlockEmergeEx(blockpos, peer_id, flags, NULL, NULL);
+}
+
+
+bool EmergeManager::enqueueBlockEmergeEx(
+       v3s16 blockpos,
+       u16 peer_id,
+       u16 flags,
+       EmergeCompletionCallback callback,
+       void *callback_param)
+{
+       EmergeThread *thread = NULL;
+       bool entry_already_exists = false;
 
        {
-               JMutexAutoLock queuelock(queuemutex);
-               
-               count = blocks_enqueued.size();
-               if (count >= qlimit_total)
-                       return false;
+               MutexAutoLock queuelock(m_queue_mutex);
 
-               count = peer_queue_count[peer_id];
-               u16 qlimit_peer = allow_generate ? qlimit_generate : qlimit_diskonly;
-               if (count >= qlimit_peer)
+               if (!pushBlockEmergeData(blockpos, peer_id, flags,
+                               callback, callback_param, &entry_already_exists))
                        return false;
-               
-               iter = blocks_enqueued.find(p);
-               if (iter != blocks_enqueued.end()) {
-                       bedata = iter->second;
-                       bedata->flags |= flags;
+
+               if (entry_already_exists)
                        return true;
-               }
 
-               bedata = new BlockEmergeData;
-               bedata->flags = flags;
-               bedata->peer_requested = peer_id;
-               blocks_enqueued.insert(std::make_pair(p, bedata));
-               
-               peer_queue_count[peer_id] = count + 1;
-               
-               // insert into the EmergeThread queue with the least items
-               int lowestitems = emergethread[0]->blockqueue.size();
-               for (int i = 1; i != emergethread.size(); i++) {
-                       int nitems = emergethread[i]->blockqueue.size();
-                       if (nitems < lowestitems) {
-                               idx = i;
-                               lowestitems = nitems;
-                       }
-               }
-               
-               emergethread[idx]->blockqueue.push(p);
+               thread = getOptimalThread();
+               thread->pushBlock(blockpos);
        }
-       emergethread[idx]->qevent.signal();
-       
+
+       thread->signal();
+
        return true;
 }
 
 
-bool EmergeThread::popBlockEmerge(v3s16 *pos, u8 *flags) {
-       std::map<v3s16, BlockEmergeData *>::iterator iter;
-       JMutexAutoLock queuelock(emerge->queuemutex);
+//
+// Mapgen-related helper functions
+//
 
-       if (blockqueue.empty())
-               return false;
-       v3s16 p = blockqueue.front();
-       blockqueue.pop();
-       
-       *pos = p;
-       
-       iter = emerge->blocks_enqueued.find(p);
-       if (iter == emerge->blocks_enqueued.end()) 
-               return false; //uh oh, queue and map out of sync!!
-
-       BlockEmergeData *bedata = iter->second;
-       *flags = bedata->flags;
-       
-       emerge->peer_queue_count[bedata->peer_requested]--;
-
-       delete bedata;
-       emerge->blocks_enqueued.erase(iter);
-       
-       return true;
+
+// TODO(hmmmm): Move this to ServerMap
+v3s16 EmergeManager::getContainingChunk(v3s16 blockpos)
+{
+       return getContainingChunk(blockpos, mgparams->chunksize);
 }
 
+// TODO(hmmmm): Move this to ServerMap
+v3s16 EmergeManager::getContainingChunk(v3s16 blockpos, s16 chunksize)
+{
+       s16 coff = -chunksize / 2;
+       v3s16 chunk_offset(coff, coff, coff);
 
-int EmergeManager::getGroundLevelAtPoint(v2s16 p) {
-       if (mapgen.size() == 0 || !mapgen[0]) {
-               errorstream << "EmergeManager: getGroundLevelAtPoint() called"
-               " before mapgen initialized" << std::endl;
+       return getContainerPos(blockpos - chunk_offset, chunksize)
+               * chunksize + chunk_offset;
+}
+
+
+int EmergeManager::getSpawnLevelAtPoint(v2s16 p)
+{
+       if (m_mapgens.size() == 0 || !m_mapgens[0]) {
+               errorstream << "EmergeManager: getSpawnLevelAtPoint() called"
+                       " before mapgen init" << std::endl;
                return 0;
        }
-       
-       return mapgen[0]->getGroundLevelAtPoint(p);
+
+       return m_mapgens[0]->getSpawnLevelAtPoint(p);
 }
 
 
-bool EmergeManager::isBlockUnderground(v3s16 blockpos) {
-       /*
+int EmergeManager::getGroundLevelAtPoint(v2s16 p)
+{
+       if (m_mapgens.size() == 0 || !m_mapgens[0]) {
+               errorstream << "EmergeManager: getGroundLevelAtPoint() called"
+                       " before mapgen init" << std::endl;
+               return 0;
+       }
+
+       return m_mapgens[0]->getGroundLevelAtPoint(p);
+}
+
+// TODO(hmmmm): Move this to ServerMap
+bool EmergeManager::isBlockUnderground(v3s16 blockpos)
+{
+#if 0
        v2s16 p = v2s16((blockpos.X * MAP_BLOCKSIZE) + MAP_BLOCKSIZE / 2,
                                        (blockpos.Y * MAP_BLOCKSIZE) + MAP_BLOCKSIZE / 2);
        int ground_level = getGroundLevelAtPoint(p);
        return blockpos.Y * (MAP_BLOCKSIZE + 1) <= min(water_level, ground_level);
-       */
+#endif
 
-       //yuck, but then again, should i bother being accurate?
-       //the height of the nodes in a single block is quite variable
-       return blockpos.Y * (MAP_BLOCKSIZE + 1) <= params->water_level;
+       // Use a simple heuristic; the above method is wildly inaccurate anyway.
+       return blockpos.Y * (MAP_BLOCKSIZE + 1) <= mgparams->water_level;
 }
 
+bool EmergeManager::pushBlockEmergeData(
+       v3s16 pos,
+       u16 peer_requested,
+       u16 flags,
+       EmergeCompletionCallback callback,
+       void *callback_param,
+       bool *entry_already_exists)
+{
+       u16 &count_peer = m_peer_queue_count[peer_requested];
 
-u32 EmergeManager::getBlockSeed(v3s16 p) {
-       return (u32)(params->seed & 0xFFFFFFFF) +
-               p.Z * 38134234 +
-               p.Y * 42123 +
-               p.X * 23;
-}
+       if ((flags & BLOCK_EMERGE_FORCE_QUEUE) == 0) {
+               if (m_blocks_enqueued.size() >= m_qlimit_total)
+                       return false;
 
+               if (peer_requested != PEER_ID_INEXISTENT) {
+                       u16 qlimit_peer = (flags & BLOCK_EMERGE_ALLOW_GEN) ?
+                               m_qlimit_generate : m_qlimit_diskonly;
+                       if (count_peer >= qlimit_peer)
+                               return false;
+               }
+       }
 
-Mapgen *EmergeManager::createMapgen(std::string mgname, int mgid,
-                                                                        MapgenParams *mgparams) {
-       std::map<std::string, MapgenFactory *>::const_iterator iter;
-       iter = mglist.find(mgname);
-       if (iter == mglist.end()) {
-               errorstream << "EmergeManager; mapgen " << mgname <<
-                " not registered" << std::endl;
-               return NULL;
+       std::pair<std::map<v3s16, BlockEmergeData>::iterator, bool> findres;
+       findres = m_blocks_enqueued.insert(std::make_pair(pos, BlockEmergeData()));
+
+       BlockEmergeData &bedata = findres.first->second;
+       *entry_already_exists   = !findres.second;
+
+       if (callback)
+               bedata.callbacks.push_back(std::make_pair(callback, callback_param));
+
+       if (*entry_already_exists) {
+               bedata.flags |= flags;
+       } else {
+               bedata.flags = flags;
+               bedata.peer_requested = peer_requested;
+
+               count_peer++;
        }
-       
-       MapgenFactory *mgfactory = iter->second;
-       return mgfactory->createMapgen(mgid, mgparams, this);
+
+       return true;
 }
 
 
-MapgenParams *EmergeManager::createMapgenParams(std::string mgname) {
-       std::map<std::string, MapgenFactory *>::const_iterator iter;
-       iter = mglist.find(mgname);
-       if (iter == mglist.end()) {
-               errorstream << "EmergeManager: mapgen " << mgname <<
-                " not registered" << std::endl;
-               return NULL;
-       }
-       
-       MapgenFactory *mgfactory = iter->second;
-       return mgfactory->createMapgenParams();
+bool EmergeManager::popBlockEmergeData(v3s16 pos, BlockEmergeData *bedata)
+{
+       std::map<v3s16, BlockEmergeData>::iterator it;
+       UNORDERED_MAP<u16, u16>::iterator it2;
+
+       it = m_blocks_enqueued.find(pos);
+       if (it == m_blocks_enqueued.end())
+               return false;
+
+       *bedata = it->second;
+
+       it2 = m_peer_queue_count.find(bedata->peer_requested);
+       if (it2 == m_peer_queue_count.end())
+               return false;
+
+       u16 &count_peer = it2->second;
+       assert(count_peer != 0);
+       count_peer--;
+
+       m_blocks_enqueued.erase(it);
+
+       return true;
 }
 
 
-MapgenParams *EmergeManager::getParamsFromSettings(Settings *settings) {
-       std::string mg_name = settings->get("mg_name");
-       MapgenParams *mgparams = createMapgenParams(mg_name);
-       
-       mgparams->mg_name     = mg_name;
-       mgparams->seed        = settings->getU64(settings == g_settings ? "fixed_map_seed" : "seed");
-       mgparams->water_level = settings->getS16("water_level");
-       mgparams->chunksize   = settings->getS16("chunksize");
-       mgparams->flags       = settings->getFlagStr("mg_flags", flagdesc_mapgen);
+EmergeThread *EmergeManager::getOptimalThread()
+{
+       size_t nthreads = m_threads.size();
+
+       FATAL_ERROR_IF(nthreads == 0, "No emerge threads!");
 
-       if (!mgparams->readParams(settings)) {
-               delete mgparams;
-               return NULL;
+       size_t index = 0;
+       size_t nitems_lowest = m_threads[0]->m_block_queue.size();
+
+       for (size_t i = 1; i < nthreads; i++) {
+               size_t nitems = m_threads[i]->m_block_queue.size();
+               if (nitems < nitems_lowest) {
+                       index = i;
+                       nitems_lowest = nitems;
+               }
        }
-       return mgparams;
+
+       return m_threads[index];
 }
 
 
-void EmergeManager::setParamsToSettings(Settings *settings) {
-       settings->set("mg_name",         params->mg_name);
-       settings->setU64("seed",         params->seed);
-       settings->setS16("water_level",  params->water_level);
-       settings->setS16("chunksize",    params->chunksize);
-       settings->setFlagStr("mg_flags", params->flags, flagdesc_mapgen);
+////
+//// EmergeThread
+////
 
-       params->writeParams(settings);
+EmergeThread::EmergeThread(Server *server, int ethreadid) :
+       enable_mapgen_debug_info(false),
+       id(ethreadid),
+       m_server(server),
+       m_map(NULL),
+       m_emerge(NULL),
+       m_mapgen(NULL)
+{
+       m_name = "Emerge-" + itos(ethreadid);
 }
 
 
-bool EmergeManager::registerMapgen(std::string mgname, MapgenFactory *mgfactory) {
-       mglist.insert(std::make_pair(mgname, mgfactory));
-       infostream << "EmergeManager: registered mapgen " << mgname << std::endl;
+EmergeThread::~EmergeThread()
+{
+       //cancelPendingItems();
 }
 
 
-
-class MapEditEventIgnorer
+void EmergeThread::signal()
 {
-public:
-       MapEditEventIgnorer(bool *flag):
-               m_flag(flag)
-       {
-               if(*m_flag == false)
-                       *m_flag = true;
-               else
-                       m_flag = NULL;
-       }
-
-       ~MapEditEventIgnorer()
-       {
-               if(m_flag)
-               {
-                       assert(*m_flag);
-                       *m_flag = false;
-               }
-       }
+       m_queue_event.signal();
+}
 
-private:
-       bool *m_flag;
-};
 
-class MapEditEventAreaIgnorer
+bool EmergeThread::pushBlock(v3s16 pos)
 {
-public:
-       MapEditEventAreaIgnorer(VoxelArea *ignorevariable, const VoxelArea &a):
-               m_ignorevariable(ignorevariable)
-       {
-               if(m_ignorevariable->getVolume() == 0)
-                       *m_ignorevariable = a;
-               else
-                       m_ignorevariable = NULL;
-       }
+       m_block_queue.push(pos);
+       return true;
+}
 
-       ~MapEditEventAreaIgnorer()
-       {
-               if(m_ignorevariable)
-               {
-                       assert(m_ignorevariable->getVolume() != 0);
-                       *m_ignorevariable = VoxelArea();
-               }
-       }
 
-private:
-       VoxelArea *m_ignorevariable;
-};
+void EmergeThread::cancelPendingItems()
+{
+       MutexAutoLock queuelock(m_emerge->m_queue_mutex);
 
+       while (!m_block_queue.empty()) {
+               BlockEmergeData bedata;
+               v3s16 pos;
 
-#if 1
+               pos = m_block_queue.front();
+               m_block_queue.pop();
 
-bool EmergeThread::getBlockOrStartGen(v3s16 p, MapBlock **b, 
-                                                                       BlockMakeData *data, bool allow_gen) {
-       v2s16 p2d(p.X, p.Z);
-       //envlock: usually takes <=1ms, sometimes 90ms or ~400ms to acquire
-       JMutexAutoLock envlock(m_server->m_env_mutex); 
-       
-       // Load sector if it isn't loaded
-       if (map->getSectorNoGenerateNoEx(p2d) == NULL)
-               map->loadSectorMeta(p2d);
+               m_emerge->popBlockEmergeData(pos, &bedata);
 
-       // Attempt to load block
-       MapBlock *block = map->getBlockNoCreateNoEx(p);
-       if (!block || block->isDummy() || !block->isGenerated()) {
-               EMERGE_DBG_OUT("not in memory, attempting to load from disk");
-               block = map->loadBlock(p);
+               runCompletionCallbacks(pos, EMERGE_CANCELLED, bedata.callbacks);
        }
+}
+
+
+void EmergeThread::runCompletionCallbacks(
+       v3s16 pos,
+       EmergeAction action,
+       const EmergeCallbackList &callbacks)
+{
+       for (size_t i = 0; i != callbacks.size(); i++) {
+               EmergeCompletionCallback callback;
+               void *param;
 
-       // If could not load and allowed to generate,
-       // start generation inside this same envlock
-       if (allow_gen && (block == NULL || !block->isGenerated())) {
-               EMERGE_DBG_OUT("generating");
-               *b = block;
-               return map->initBlockMake(data, p);
+               callback = callbacks[i].first;
+               param    = callbacks[i].second;
+
+               callback(pos, action, param);
        }
-       
-       *b = block;
-       return false;
 }
 
 
-void *EmergeThread::Thread() {
-       ThreadStarted();
-       log_register_thread("EmergeThread" + id);
-       DSTACK(__FUNCTION_NAME);
-       BEGIN_DEBUG_EXCEPTION_HANDLER
+bool EmergeThread::popBlockEmerge(v3s16 *pos, BlockEmergeData *bedata)
+{
+       MutexAutoLock queuelock(m_emerge->m_queue_mutex);
 
-       v3s16 last_tried_pos(-32768,-32768,-32768); // For error output
-       v3s16 p;
-       u8 flags;
-       
-       map    = (ServerMap *)&(m_server->m_env->getMap());
-       emerge = m_server->m_emerge;
-       mapgen = emerge->mapgen[id];
-       enable_mapgen_debug_info = emerge->mapgen_debug_info;
-       
-       while (getRun())
-       try {
-               if (!popBlockEmerge(&p, &flags)) {
-                       qevent.wait();
-                       continue;
-               }
+       if (m_block_queue.empty())
+               return false;
 
-               last_tried_pos = p;
-               if (blockpos_over_limit(p))
-                       continue;
+       *pos = m_block_queue.front();
+       m_block_queue.pop();
 
-               bool allow_generate = flags & BLOCK_EMERGE_ALLOWGEN;
-               EMERGE_DBG_OUT("p=" PP(p) " allow_generate=" << allow_generate);
-               
-               /*
-                       Try to fetch block from memory or disk.
-                       If not found and asked to generate, initialize generator.
-               */
-               BlockMakeData data;
-               MapBlock *block = NULL;
-               core::map<v3s16, MapBlock *> modified_blocks;
-               
-               if (getBlockOrStartGen(p, &block, &data, allow_generate)) {
-                       {
-                               ScopeProfiler sp(g_profiler, "EmergeThread: Mapgen::makeChunk", SPT_AVG);
-                               TimeTaker t("mapgen::make_block()");
+       m_emerge->popBlockEmergeData(*pos, bedata);
 
-                               mapgen->makeChunk(&data);
+       return true;
+}
 
-                               if (enable_mapgen_debug_info == false)
-                                       t.stop(true); // Hide output
-                       }
 
-                       {
-                               //envlock: usually 0ms, but can take either 30 or 400ms to acquire
-                               JMutexAutoLock envlock(m_server->m_env_mutex); 
-                               ScopeProfiler sp(g_profiler, "EmergeThread: after "
-                                               "Mapgen::makeChunk (envlock)", SPT_AVG);
-
-                               map->finishBlockMake(&data, modified_blocks);
-                               
-                               block = map->getBlockNoCreateNoEx(p);
-                               if (block) {
-                                       /*
-                                               Do some post-generate stuff
-                                       */
-                                       v3s16 minp = data.blockpos_min * MAP_BLOCKSIZE;
-                                       v3s16 maxp = data.blockpos_max * MAP_BLOCKSIZE +
-                                                                v3s16(1,1,1) * (MAP_BLOCKSIZE - 1);
-
-                                       // Ignore map edit events, they will not need to be sent
-                                       // to anybody because the block hasn't been sent to anybody
-                                       MapEditEventAreaIgnorer 
-                                               ign(&m_server->m_ignore_map_edit_events_area,
-                                               VoxelArea(minp, maxp));
-                                       {  // takes about 90ms with -O1 on an e3-1230v2
-                                               scriptapi_environment_on_generated(m_server->m_lua,
-                                                               minp, maxp, emerge->getBlockSeed(minp));
-                                       }
-
-                                       EMERGE_DBG_OUT("ended up with: " << analyze_block(block));
-                                       
-                                       m_server->m_env->activateBlock(block, 0);
-                               }
-                       }
-               }
+EmergeAction EmergeThread::getBlockOrStartGen(
+       v3s16 pos, bool allow_gen, MapBlock **block, BlockMakeData *bmdata)
+{
+       MutexAutoLock envlock(m_server->m_env_mutex);
 
-               /*
-                       Set sent status of modified blocks on clients
-               */
+       // 1). Attempt to fetch block from memory
+       *block = m_map->getBlockNoCreateNoEx(pos);
+       if (*block && !(*block)->isDummy() && (*block)->isGenerated())
+               return EMERGE_FROM_MEMORY;
 
-               // NOTE: Server's clients are also behind the connection mutex
-               //conlock: consistently takes 30-40ms to acquire
-               JMutexAutoLock lock(m_server->m_con_mutex);
-               // Add the originally fetched block to the modified list
-               if (block)
-                       modified_blocks.insert(p, block);
-
-               // Set the modified blocks unsent for all the clients
-               for (core::map<u16, RemoteClient*>::Iterator
-                        i = m_server->m_clients.getIterator();
-                        i.atEnd() == false; i++) {
-                       RemoteClient *client = i.getNode()->getValue();
-                       if (modified_blocks.size() > 0) {
-                               // Remove block from sent history
-                               client->SetBlocksNotSent(modified_blocks);
-                       }
-               }
-       }
-       catch (VersionMismatchException &e) {
-               std::ostringstream err;
-               err << "World data version mismatch in MapBlock "<<PP(last_tried_pos)<<std::endl;
-               err << "----"<<std::endl;
-               err << "\""<<e.what()<<"\""<<std::endl;
-               err << "See debug.txt."<<std::endl;
-               err << "World probably saved by a newer version of Minetest."<<std::endl;
-               m_server->setAsyncFatalError(err.str());
-       }
-       catch (SerializationError &e) {
-               std::ostringstream err;
-               err << "Invalid data in MapBlock "<<PP(last_tried_pos)<<std::endl;
-               err << "----"<<std::endl;
-               err << "\""<<e.what()<<"\""<<std::endl;
-               err << "See debug.txt."<<std::endl;
-               err << "You can ignore this using [ignore_world_load_errors = true]."<<std::endl;
-               m_server->setAsyncFatalError(err.str());
-       }
-       
-       END_DEBUG_EXCEPTION_HANDLER(errorstream)
-       log_deregister_thread();
-       return NULL;
+       // 2). Attempt to load block from disk
+       *block = m_map->loadBlock(pos);
+       if (*block && (*block)->isGenerated())
+               return EMERGE_FROM_DISK;
+
+       // 3). Attempt to start generation
+       if (allow_gen && m_map->initBlockMake(pos, bmdata))
+               return EMERGE_GENERATED;
+
+       // All attempts failed; cancel this block emerge
+       return EMERGE_CANCELLED;
 }
 
-#else
 
-void *EmergeThread::Thread() {
-       ThreadStarted();
-       log_register_thread("EmergeThread");
-       DSTACK(__FUNCTION_NAME);
-       BEGIN_DEBUG_EXCEPTION_HANDLER
+MapBlock *EmergeThread::finishGen(v3s16 pos, BlockMakeData *bmdata,
+       std::map<v3s16, MapBlock *> *modified_blocks)
+{
+       MutexAutoLock envlock(m_server->m_env_mutex);
+       ScopeProfiler sp(g_profiler,
+               "EmergeThread: after Mapgen::makeChunk", SPT_AVG);
 
-       bool enable_mapgen_debug_info = g_settings->getBool("enable_mapgen_debug_info");
+       /*
+               Perform post-processing on blocks (invalidate lighting, queue liquid
+               transforms, etc.) to finish block make
+       */
+       m_map->finishBlockMake(bmdata, modified_blocks);
 
-       v3s16 last_tried_pos(-32768,-32768,-32768); // For error output
-       ServerMap &map = ((ServerMap&)m_server->m_env->getMap());
-       EmergeManager *emerge = m_server->m_emerge;
-       Mapgen *mapgen = emerge->getMapgen();
+       MapBlock *block = m_map->getBlockNoCreateNoEx(pos);
+       if (!block) {
+               errorstream << "EmergeThread::finishGen: Couldn't grab block we "
+                       "just generated: " << PP(pos) << std::endl;
+               return NULL;
+       }
 
-       while(getRun())
-       try {
-               QueuedBlockEmerge *qptr = m_server->m_emerge_queue.pop();
-               if(qptr == NULL)
-                       break;
-               SharedPtr<QueuedBlockEmerge> q(qptr);
+       v3s16 minp = bmdata->blockpos_min * MAP_BLOCKSIZE;
+       v3s16 maxp = bmdata->blockpos_max * MAP_BLOCKSIZE +
+                                v3s16(1,1,1) * (MAP_BLOCKSIZE - 1);
 
-               v3s16 &p = q->pos;
-               v2s16 p2d(p.X,p.Z);
+       // Ignore map edit events, they will not need to be sent
+       // to anybody because the block hasn't been sent to anybody
+       MapEditEventAreaIgnorer ign(
+               &m_server->m_ignore_map_edit_events_area,
+               VoxelArea(minp, maxp));
 
-               last_tried_pos = p;
+       /*
+               Run Lua on_generated callbacks
+       */
+       try {
+               m_server->getScriptIface()->environment_OnGenerated(
+                       minp, maxp, m_mapgen->blockseed);
+       } catch (LuaError &e) {
+               m_server->setAsyncFatalError("Lua: " + std::string(e.what()));
+       }
 
-               /*
-                       Do not generate over-limit
-               */
-               if (blockpos_over_limit(p))
-                       continue;
+       EMERGE_DBG_OUT("ended up with: " << analyze_block(block));
 
-               //infostream<<"EmergeThread::Thread(): running"<<std::endl;
+       /*
+               Activate the block
+       */
+       m_server->m_env->activateBlock(block, 0);
 
-               //TimeTaker timer("block emerge");
+       return block;
+}
 
-               /*
-                       Try to emerge it from somewhere.
 
-                       If it is only wanted as optional, only loading from disk
-                       will be allowed.
-               */
+void *EmergeThread::run()
+{
+       DSTACK(FUNCTION_NAME);
+       BEGIN_DEBUG_EXCEPTION_HANDLER
 
-               /*
-                       Check if any peer wants it as non-optional. In that case it
-                       will be generated.
+       v3s16 pos;
 
-                       Also decrement the emerge queue count in clients.
-               */
+       m_map    = (ServerMap *)&(m_server->m_env->getMap());
+       m_emerge = m_server->m_emerge;
+       m_mapgen = m_emerge->m_mapgens[id];
+       enable_mapgen_debug_info = m_emerge->enable_mapgen_debug_info;
 
-               bool only_from_disk = true;
-               {
-                       core::map<u16, u8>::Iterator i;
-                       for (i=q->s.getIterator(); !i.atEnd(); i++) {
-                               u8 flags = i.getNode()->getValue();
-                               if (!(flags & BLOCK_EMERGE_FLAG_FROMDISK)) {
-                                       only_from_disk = false;
-                                       break;
-                               }
-                       }
+       try {
+       while (!stopRequested()) {
+               std::map<v3s16, MapBlock *> modified_blocks;
+               BlockEmergeData bedata;
+               BlockMakeData bmdata;
+               EmergeAction action;
+               MapBlock *block;
+
+               if (!popBlockEmerge(&pos, &bedata)) {
+                       m_queue_event.wait();
+                       continue;
                }
 
-               if (enable_mapgen_debug_info)
-                       infostream<<"EmergeThread: p="
-                                       <<"("<<p.X<<","<<p.Y<<","<<p.Z<<") "
-                                       <<"only_from_disk="<<only_from_disk<<std::endl;
-                                       
-               MapBlock *block = NULL;
-               bool got_block = true;
-               core::map<v3s16, MapBlock*> modified_blocks;
-
-               /*
-                       Try to fetch block from memory or disk.
-                       If not found and asked to generate, initialize generator.
-               */
-
-               bool started_generate = false;
-               BlockMakeData data;
-               {
-                       JMutexAutoLock envlock(m_server->m_env_mutex);
-                       
-                       // Load sector if it isn't loaded
-                       if(map.getSectorNoGenerateNoEx(p2d) == NULL)
-                               map.loadSectorMeta(p2d);
-
-                       // Attempt to load block
-                       block = map.getBlockNoCreateNoEx(p);
-                       if(!block || block->isDummy() || !block->isGenerated()) {
-                               if(enable_mapgen_debug_info)
-                                       infostream<<"EmergeThread: not in memory, "
-                                                       <<"attempting to load from disk"<<std::endl;
-
-                               block = map.loadBlock(p);
-                       }
+               if (blockpos_over_limit(pos))
+                       continue;
 
-                       // If could not load and allowed to generate, start generation
-                       // inside this same envlock
-                       if(only_from_disk == false &&
-                                       (block == NULL || block->isGenerated() == false)){
-                               if(enable_mapgen_debug_info)
-                                       infostream<<"EmergeThread: generating"<<std::endl;
-                               started_generate = true;
+               bool allow_gen = bedata.flags & BLOCK_EMERGE_ALLOW_GEN;
+               EMERGE_DBG_OUT("pos=" PP(pos) " allow_gen=" << allow_gen);
 
-                               map.initBlockMake(&data, p);
-                       }
-               }
-
-               /*
-                       If generator was initialized, generate now when envlock is free.
-               */
-               if(started_generate) {
+               action = getBlockOrStartGen(pos, allow_gen, &block, &bmdata);
+               if (action == EMERGE_GENERATED) {
                        {
-                               ScopeProfiler sp(g_profiler, "EmergeThread: mapgen::make_block",
-                                               SPT_AVG);
+                               ScopeProfiler sp(g_profiler,
+                                       "EmergeThread: Mapgen::makeChunk", SPT_AVG);
                                TimeTaker t("mapgen::make_block()");
 
-                               mapgen->makeChunk(&data);
+                               m_mapgen->makeChunk(&bmdata);
 
                                if (enable_mapgen_debug_info == false)
                                        t.stop(true); // Hide output
                        }
 
-                       do{ // enable break
-                               // Lock environment again to access the map
-                               JMutexAutoLock envlock(m_server->m_env_mutex);
-
-                               ScopeProfiler sp(g_profiler, "EmergeThread: after "
-                                               "mapgen::make_block (envlock)", SPT_AVG);
-
-                               // Blit data back on map, update lighting, add mobs and
-                               // whatever this does
-                               map.finishBlockMake(&data, modified_blocks);
-                               
-                               // Get central block
-                               block = map.getBlockNoCreateNoEx(p);
-
-                               // If block doesn't exist, don't try doing anything with it
-                               // This happens if the block is not in generation boundaries
-                               if(!block)
-                                       break;
-
-                               /*
-                                       Do some post-generate stuff
-                               */
-                               v3s16 minp = data.blockpos_min * MAP_BLOCKSIZE;
-                               v3s16 maxp = data.blockpos_max * MAP_BLOCKSIZE +
-                                               v3s16(1,1,1) * (MAP_BLOCKSIZE - 1);
-
-                               /*
-                                       Ignore map edit events, they will not need to be
-                                       sent to anybody because the block hasn't been sent
-                                       to anybody
-                               */
-                               MapEditEventAreaIgnorer ign(
-                                               &m_server->m_ignore_map_edit_events_area,
-                                               VoxelArea(minp, maxp));
-                               {
-                                       TimeTaker timer("on_generated");
-                                       scriptapi_environment_on_generated(m_server->m_lua,
-                                                       minp, maxp, emerge->getBlockSeed(minp));
-                                       //int t = timer.stop(true);
-                                       //dstream<<"on_generated took "<<t<<"ms"<<std::endl;
-                               }
-
-                               if (enable_mapgen_debug_info)
-                                       infostream << "EmergeThread: ended up with: "
-                                                       << analyze_block(block) << std::endl;
-
-                               // Activate objects and stuff
-                               m_server->m_env->activateBlock(block, 0);
-                       }while(false);
+                       block = finishGen(pos, &bmdata, &modified_blocks);
                }
 
-               if(block == NULL)
-                       got_block = false;
-
-               /*
-                       Set sent status of modified blocks on clients
-               */
-
-               // NOTE: Server's clients are also behind the connection mutex
-               JMutexAutoLock lock(m_server->m_con_mutex);
-
-               /*
-                       Add the originally fetched block to the modified list
-               */
-               if(got_block)
-                       modified_blocks.insert(p, block);
-
-               /*
-                       Set the modified blocks unsent for all the clients
-               */
-               for(core::map<u16, RemoteClient*>::Iterator
-                               i = m_server->m_clients.getIterator();
-                               i.atEnd() == false; i++) {
-                       RemoteClient *client = i.getNode()->getValue();
-                       if(modified_blocks.size() > 0) {
-                               // Remove block from sent history
-                               client->SetBlocksNotSent(modified_blocks);
-                       }
-               }
-                                                       
+               runCompletionCallbacks(pos, action, bedata.callbacks);
+
+               if (block)
+                       modified_blocks[pos] = block;
 
-niters++;
+               if (modified_blocks.size() > 0)
+                       m_server->SetBlocksNotSent(modified_blocks);
        }
-       catch (VersionMismatchException &e) {
+       catch (VersionMismatchException &e) {
                std::ostringstream err;
-               err << "World data version mismatch in MapBlock "<<PP(last_tried_pos)<<std::endl;
-               err << "----"<<std::endl;
-               err << "\""<<e.what()<<"\""<<std::endl;
-               err << "See debug.txt."<<std::endl;
-               err << "World probably saved by a newer version of Minetest."<<std::endl;
+               err << "World data version mismatch in MapBlock " << PP(pos) << std::endl
+                       << "----" << std::endl
+                       << "\"" << e.what() << "\"" << std::endl
+                       << "See debug.txt." << std::endl
+                       << "World probably saved by a newer version of " PROJECT_NAME_C "."
+                       << std::endl;
                m_server->setAsyncFatalError(err.str());
-       }
-       catch (SerializationError &e) {
+       } catch (SerializationError &e) {
                std::ostringstream err;
-               err << "Invalid data in MapBlock "<<PP(last_tried_pos)<<std::endl;
-               err << "----"<<std::endl;
-               err << "\""<<e.what()<<"\""<<std::endl;
-               err << "See debug.txt."<<std::endl;
-               err << "You can ignore this using [ignore_world_load_errors = true]."<<std::endl;
+               err << "Invalid data in MapBlock " << PP(pos) << std::endl
+                       << "----" << std::endl
+                       << "\"" << e.what() << "\"" << std::endl
+                       << "See debug.txt." << std::endl
+                       << "You can ignore this using [ignore_world_load_errors = true]."
+                       << std::endl;
                m_server->setAsyncFatalError(err.str());
        }
-printf("emergethread iterated %d times\n", niters);
-       END_DEBUG_EXCEPTION_HANDLER(errorstream)
-       log_deregister_thread();
+
+       END_DEBUG_EXCEPTION_HANDLER
        return NULL;
 }
-
-#endif