]> git.lizzy.rs Git - minetest.git/blobdiff - src/emerge.cpp
Don't erase modified_blocks
[minetest.git] / src / emerge.cpp
index 728ea7196b29cbefa4630da9e54655104e54ec9a..5311c1210e7876ed563cf9257b5bc92a399c33e4 100644 (file)
@@ -39,111 +39,145 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "biome.h"
 #include "emerge.h"
 #include "mapgen_v6.h"
+#include "mapgen_indev.h"
 
 
+/////////////////////////////// Emerge Manager ////////////////////////////////
+
 EmergeManager::EmergeManager(IGameDef *gamedef, BiomeDefManager *bdef) {
        //register built-in mapgens
        registerMapgen("v6", new MapgenFactoryV6());
+       registerMapgen("indev", new MapgenFactoryIndev());
 
        this->biomedef = bdef ? bdef : new BiomeDefManager(gamedef);
        this->params   = NULL;
-       this->mapgen   = NULL;
        
+       mapgen_debug_info = g_settings->getBool("enable_mapgen_debug_info");
+
        queuemutex.Init();
-       emergethread = new EmergeThread((Server *)gamedef);
+       
+       int nthreads;
+       if (g_settings->get("num_emerge_threads").empty()) {
+               int nprocs = porting::getNumberOfProcessors();
+               // leave a proc for the main thread and one for some other misc threads
+               nthreads = (nprocs > 2) ? nprocs - 2 : 1;
+       } else {
+               nthreads = g_settings->getU16("num_emerge_threads");
+       }
+       if (nthreads < 1)
+               nthreads = 1;
+       
+       qlimit_total    = g_settings->getU16("emergequeue_limit_total");
+       qlimit_diskonly = g_settings->get("emergequeue_limit_diskonly").empty() ?
+               nthreads * 5 + 1 :
+               g_settings->getU16("emergequeue_limit_diskonly");
+       qlimit_generate = g_settings->get("emergequeue_limit_generate").empty() ?
+               nthreads + 1 :
+               g_settings->getU16("emergequeue_limit_generate");
+       
+       for (int i = 0; i != nthreads; i++)
+               emergethread.push_back(new EmergeThread((Server *)gamedef, i));
+               
+       infostream << "EmergeManager: using " << nthreads << " threads" << std::endl;
 }
 
 
 EmergeManager::~EmergeManager() {
-       emergethread->setRun(false);
-       emergethread->stop();
+       for (unsigned int i = 0; i != emergethread.size(); i++) {
+               emergethread[i]->setRun(false);
+               emergethread[i]->qevent.signal();
+               emergethread[i]->stop();
+               delete emergethread[i];
+               delete mapgen[i];
+       }
        
-       delete emergethread;
        delete biomedef;
-       delete mapgen;
        delete params;
 }
 
 
 void EmergeManager::initMapgens(MapgenParams *mgparams) {
-       if (mapgen)
+       Mapgen *mg;
+       
+       if (mapgen.size())
                return;
        
        this->params = mgparams;
-       this->mapgen = getMapgen(); //only one mapgen for now!
-}
-
-
-Mapgen *EmergeManager::getMapgen() {
-       if (!mapgen) {
-               mapgen = createMapgen(params->mg_name, 0, params, this);
-               if (!mapgen) {
+       for (unsigned int i = 0; i != emergethread.size(); i++) {
+               mg = createMapgen(params->mg_name, 0, params);
+               if (!mg) {
                        infostream << "EmergeManager: falling back to mapgen v6" << std::endl;
                        delete params;
                        params = createMapgenParams("v6");
-                       mapgen = createMapgen("v6", 0, params, this);
+                       mg = createMapgen("v6", 0, params);
                }
+               mapgen.push_back(mg);
        }
-       return mapgen;
 }
 
 
-bool EmergeManager::enqueueBlockEmerge(u16 peer_id, v3s16 p, bool allow_generate) { ///return false if adding failed, or queue full!
+bool EmergeManager::enqueueBlockEmerge(u16 peer_id, v3s16 p, bool allow_generate) {
+       std::map<v3s16, BlockEmergeData *>::const_iterator iter;
+       BlockEmergeData *bedata;
+       u16 count;
        u8 flags = 0;
+       int idx = 0;
        
        if (allow_generate)
                flags |= BLOCK_EMERGE_ALLOWGEN;
 
-       //TODO:
-       // add logic to select which emergethread to add it to
-       //  - one with the least queue contents?
-       //  - if a queue is too full, move onto another one
-       //  - use the peer id sometime
-
        {
                JMutexAutoLock queuelock(queuemutex);
                
-               std::map<v3s16, u8>::const_iterator iter = blocks_enqueued.find(p);
+               count = blocks_enqueued.size();
+               if (count >= qlimit_total)
+                       return false;
+
+               count = peer_queue_count[peer_id];
+               u16 qlimit_peer = allow_generate ? qlimit_generate : qlimit_diskonly;
+               if (count >= qlimit_peer)
+                       return false;
+               
+               iter = blocks_enqueued.find(p);
                if (iter != blocks_enqueued.end()) {
-                       flags |= iter->second;
-                       blocks_enqueued[p] = flags;
+                       bedata = iter->second;
+                       bedata->flags |= flags;
                        return true;
                }
+
+               bedata = new BlockEmergeData;
+               bedata->flags = flags;
+               bedata->peer_requested = peer_id;
+               blocks_enqueued.insert(std::make_pair(p, bedata));
+               
+               peer_queue_count[peer_id] = count + 1;
                
-               blocks_enqueued.insert(std::make_pair(p, flags));
-               emergethread->blockqueue.push(p);
+               // insert into the EmergeThread queue with the least items
+               int lowestitems = emergethread[0]->blockqueue.size();
+               for (unsigned int i = 1; i != emergethread.size(); i++) {
+                       int nitems = emergethread[i]->blockqueue.size();
+                       if (nitems < lowestitems) {
+                               idx = i;
+                               lowestitems = nitems;
+                       }
+               }
+               
+               emergethread[idx]->blockqueue.push(p);
        }
-       emergethread->qevent.signal();
-       
-       return true;
-}
-
-
-bool EmergeManager::popBlockEmerge(v3s16 *pos, u8 *flags) {
-       JMutexAutoLock queuelock(queuemutex);
-
-       if (emergethread->blockqueue.empty())
-               return false;
-       v3s16 p = emergethread->blockqueue.front();
-       emergethread->blockqueue.pop();
-       
-       *pos = p;
-
-       std::map<v3s16, u8>::iterator iter = blocks_enqueued.find(p);
-       if (iter == blocks_enqueued.end()) //uh oh, this isn't right!!!!!!!!!!!!!!!!!!
-               return false;
-
-       *flags = iter->second;
-       blocks_enqueued.erase(iter);
+       emergethread[idx]->qevent.signal();
        
        return true;
 }
 
 
 int EmergeManager::getGroundLevelAtPoint(v2s16 p) {
-       if (!mapgen)
+       if (mapgen.size() == 0 || !mapgen[0]) {
+               errorstream << "EmergeManager: getGroundLevelAtPoint() called"
+               " before mapgen initialized" << std::endl;
                return 0;
-       return mapgen->getGroundLevelAtPoint(p);
+       }
+       
+       return mapgen[0]->getGroundLevelAtPoint(p);
 }
 
 
@@ -165,13 +199,14 @@ u32 EmergeManager::getBlockSeed(v3s16 p) {
        return (u32)(params->seed & 0xFFFFFFFF) +
                p.Z * 38134234 +
                p.Y * 42123 +
-               p.Y * 23;
+               p.X * 23;
 }
 
 
 Mapgen *EmergeManager::createMapgen(std::string mgname, int mgid,
-                                                                       MapgenParams *mgparams, EmergeManager *emerge) {
-       std::map<std::string, MapgenFactory *>::const_iterator iter = mglist.find(mgname);
+                                                                        MapgenParams *mgparams) {
+       std::map<std::string, MapgenFactory *>::const_iterator iter;
+       iter = mglist.find(mgname);
        if (iter == mglist.end()) {
                errorstream << "EmergeManager; mapgen " << mgname <<
                 " not registered" << std::endl;
@@ -179,12 +214,13 @@ Mapgen *EmergeManager::createMapgen(std::string mgname, int mgid,
        }
        
        MapgenFactory *mgfactory = iter->second;
-       return mgfactory->createMapgen(mgid, mgparams, emerge);
+       return mgfactory->createMapgen(mgid, mgparams, this);
 }
 
 
 MapgenParams *EmergeManager::createMapgenParams(std::string mgname) {
-       std::map<std::string, MapgenFactory *>::const_iterator iter = mglist.find(mgname);
+       std::map<std::string, MapgenFactory *>::const_iterator iter;
+       iter = mglist.find(mgname);
        if (iter == mglist.end()) {
                errorstream << "EmergeManager: mapgen " << mgname <<
                 " not registered" << std::endl;
@@ -204,7 +240,7 @@ MapgenParams *EmergeManager::getParamsFromSettings(Settings *settings) {
        mgparams->seed        = settings->getU64(settings == g_settings ? "fixed_map_seed" : "seed");
        mgparams->water_level = settings->getS16("water_level");
        mgparams->chunksize   = settings->getS16("chunksize");
-       mgparams->flags       = settings->getS32("mg_flags");
+       mgparams->flags       = settings->getFlagStr("mg_flags", flagdesc_mapgen);
 
        if (!mgparams->readParams(settings)) {
                delete mgparams;
@@ -225,69 +261,40 @@ void EmergeManager::setParamsToSettings(Settings *settings) {
 }
 
 
-bool EmergeManager::registerMapgen(std::string mgname, MapgenFactory *mgfactory) {
+void EmergeManager::registerMapgen(std::string mgname, MapgenFactory *mgfactory) {
        mglist.insert(std::make_pair(mgname, mgfactory));
        infostream << "EmergeManager: registered mapgen " << mgname << std::endl;
 }
 
 
+////////////////////////////// Emerge Thread ////////////////////////////////// 
 
-class MapEditEventIgnorer
-{
-public:
-       MapEditEventIgnorer(bool *flag):
-               m_flag(flag)
-       {
-               if(*m_flag == false)
-                       *m_flag = true;
-               else
-                       m_flag = NULL;
-       }
-
-       ~MapEditEventIgnorer()
-       {
-               if(m_flag)
-               {
-                       assert(*m_flag);
-                       *m_flag = false;
-               }
-       }
-
-private:
-       bool *m_flag;
-};
-
-class MapEditEventAreaIgnorer
-{
-public:
-       MapEditEventAreaIgnorer(VoxelArea *ignorevariable, const VoxelArea &a):
-               m_ignorevariable(ignorevariable)
-       {
-               if(m_ignorevariable->getVolume() == 0)
-                       *m_ignorevariable = a;
-               else
-                       m_ignorevariable = NULL;
-       }
+bool EmergeThread::popBlockEmerge(v3s16 *pos, u8 *flags) {
+       std::map<v3s16, BlockEmergeData *>::iterator iter;
+       JMutexAutoLock queuelock(emerge->queuemutex);
 
-       ~MapEditEventAreaIgnorer()
-       {
-               if(m_ignorevariable)
-               {
-                       assert(m_ignorevariable->getVolume() != 0);
-                       *m_ignorevariable = VoxelArea();
-               }
-       }
-
-private:
-       VoxelArea *m_ignorevariable;
-};
+       if (blockqueue.empty())
+               return false;
+       v3s16 p = blockqueue.front();
+       blockqueue.pop();
+       
+       *pos = p;
+       
+       iter = emerge->blocks_enqueued.find(p);
+       if (iter == emerge->blocks_enqueued.end()) 
+               return false; //uh oh, queue and map out of sync!!
 
+       BlockEmergeData *bedata = iter->second;
+       *flags = bedata->flags;
+       
+       emerge->peer_queue_count[bedata->peer_requested]--;
 
-#if 1
+       delete bedata;
+       emerge->blocks_enqueued.erase(iter);
+       
+       return true;
+}
 
-#define EMERGE_DBG_OUT(x) \
-       { if (enable_mapgen_debug_info) \
-       infostream << "EmergeThread: " x << std::endl; }
 
 bool EmergeThread::getBlockOrStartGen(v3s16 p, MapBlock **b, 
                                                                        BlockMakeData *data, bool allow_gen) {
@@ -310,8 +317,8 @@ bool EmergeThread::getBlockOrStartGen(v3s16 p, MapBlock **b,
        // start generation inside this same envlock
        if (allow_gen && (block == NULL || !block->isGenerated())) {
                EMERGE_DBG_OUT("generating");
-               map->initBlockMake(data, p);
-               return true;
+               *b = block;
+               return map->initBlockMake(data, p);
        }
        
        *b = block;
@@ -321,7 +328,7 @@ bool EmergeThread::getBlockOrStartGen(v3s16 p, MapBlock **b,
 
 void *EmergeThread::Thread() {
        ThreadStarted();
-       log_register_thread("EmergeThread");
+       log_register_thread("EmergeThread" + id);
        DSTACK(__FUNCTION_NAME);
        BEGIN_DEBUG_EXCEPTION_HANDLER
 
@@ -331,12 +338,15 @@ void *EmergeThread::Thread() {
        
        map    = (ServerMap *)&(m_server->m_env->getMap());
        emerge = m_server->m_emerge;
-       mapgen = emerge->getMapgen();
+       mapgen = emerge->mapgen[id];
+       enable_mapgen_debug_info = emerge->mapgen_debug_info;
        
        while (getRun())
        try {
-               while (!emerge->popBlockEmerge(&p, &flags))
+               if (!popBlockEmerge(&p, &flags)) {
                        qevent.wait();
+                       continue;
+               }
 
                last_tried_pos = p;
                if (blockpos_over_limit(p))
@@ -351,7 +361,7 @@ void *EmergeThread::Thread() {
                */
                BlockMakeData data;
                MapBlock *block = NULL;
-               core::map<v3s16, MapBlock *> modified_blocks;
+               std::map<v3s16, MapBlock *> modified_blocks;
                
                if (getBlockOrStartGen(p, &block, &data, allow_generate)) {
                        {
@@ -368,7 +378,7 @@ void *EmergeThread::Thread() {
                                //envlock: usually 0ms, but can take either 30 or 400ms to acquire
                                JMutexAutoLock envlock(m_server->m_env_mutex); 
                                ScopeProfiler sp(g_profiler, "EmergeThread: after "
-                                               "mapgen::make_block (envlock)", SPT_AVG);
+                                               "Mapgen::makeChunk (envlock)", SPT_AVG);
 
                                map->finishBlockMake(&data, modified_blocks);
                                
@@ -407,13 +417,13 @@ void *EmergeThread::Thread() {
                JMutexAutoLock lock(m_server->m_con_mutex);
                // Add the originally fetched block to the modified list
                if (block)
-                       modified_blocks.insert(p, block);
+                       modified_blocks[p] = block;
 
                // Set the modified blocks unsent for all the clients
-               for (core::map<u16, RemoteClient*>::Iterator
-                        i = m_server->m_clients.getIterator();
-                        i.atEnd() == false; i++) {
-                       RemoteClient *client = i.getNode()->getValue();
+               for (std::map<u16, RemoteClient*>::iterator
+                        i = m_server->m_clients.begin();
+                        i != m_server->m_clients.end(); ++i) {
+                       RemoteClient *client = i->second;
                        if (modified_blocks.size() > 0) {
                                // Remove block from sent history
                                client->SetBlocksNotSent(modified_blocks);
@@ -443,235 +453,3 @@ void *EmergeThread::Thread() {
        log_deregister_thread();
        return NULL;
 }
-
-#else
-
-void *EmergeThread::Thread() {
-       ThreadStarted();
-       log_register_thread("EmergeThread");
-       DSTACK(__FUNCTION_NAME);
-       BEGIN_DEBUG_EXCEPTION_HANDLER
-
-       bool enable_mapgen_debug_info = g_settings->getBool("enable_mapgen_debug_info");
-
-       v3s16 last_tried_pos(-32768,-32768,-32768); // For error output
-       ServerMap &map = ((ServerMap&)m_server->m_env->getMap());
-       EmergeManager *emerge = m_server->m_emerge;
-       Mapgen *mapgen = emerge->getMapgen();
-
-       while(getRun())
-       try {
-               QueuedBlockEmerge *qptr = m_server->m_emerge_queue.pop();
-               if(qptr == NULL)
-                       break;
-               SharedPtr<QueuedBlockEmerge> q(qptr);
-
-               v3s16 &p = q->pos;
-               v2s16 p2d(p.X,p.Z);
-
-               last_tried_pos = p;
-
-               /*
-                       Do not generate over-limit
-               */
-               if (blockpos_over_limit(p))
-                       continue;
-
-               //infostream<<"EmergeThread::Thread(): running"<<std::endl;
-
-               //TimeTaker timer("block emerge");
-
-               /*
-                       Try to emerge it from somewhere.
-
-                       If it is only wanted as optional, only loading from disk
-                       will be allowed.
-               */
-
-               /*
-                       Check if any peer wants it as non-optional. In that case it
-                       will be generated.
-
-                       Also decrement the emerge queue count in clients.
-               */
-
-               bool only_from_disk = true;
-               {
-                       core::map<u16, u8>::Iterator i;
-                       for (i=q->s.getIterator(); !i.atEnd(); i++) {
-                               u8 flags = i.getNode()->getValue();
-                               if (!(flags & BLOCK_EMERGE_FLAG_FROMDISK)) {
-                                       only_from_disk = false;
-                                       break;
-                               }
-                       }
-               }
-
-               if (enable_mapgen_debug_info)
-                       infostream<<"EmergeThread: p="
-                                       <<"("<<p.X<<","<<p.Y<<","<<p.Z<<") "
-                                       <<"only_from_disk="<<only_from_disk<<std::endl;
-                                       
-               MapBlock *block = NULL;
-               bool got_block = true;
-               core::map<v3s16, MapBlock*> modified_blocks;
-
-               /*
-                       Try to fetch block from memory or disk.
-                       If not found and asked to generate, initialize generator.
-               */
-
-               bool started_generate = false;
-               BlockMakeData data;
-               {
-                       JMutexAutoLock envlock(m_server->m_env_mutex);
-                       
-                       // Load sector if it isn't loaded
-                       if(map.getSectorNoGenerateNoEx(p2d) == NULL)
-                               map.loadSectorMeta(p2d);
-
-                       // Attempt to load block
-                       block = map.getBlockNoCreateNoEx(p);
-                       if(!block || block->isDummy() || !block->isGenerated()) {
-                               if(enable_mapgen_debug_info)
-                                       infostream<<"EmergeThread: not in memory, "
-                                                       <<"attempting to load from disk"<<std::endl;
-
-                               block = map.loadBlock(p);
-                       }
-
-                       // If could not load and allowed to generate, start generation
-                       // inside this same envlock
-                       if(only_from_disk == false &&
-                                       (block == NULL || block->isGenerated() == false)){
-                               if(enable_mapgen_debug_info)
-                                       infostream<<"EmergeThread: generating"<<std::endl;
-                               started_generate = true;
-
-                               map.initBlockMake(&data, p);
-                       }
-               }
-
-               /*
-                       If generator was initialized, generate now when envlock is free.
-               */
-               if(started_generate) {
-                       {
-                               ScopeProfiler sp(g_profiler, "EmergeThread: mapgen::make_block",
-                                               SPT_AVG);
-                               TimeTaker t("mapgen::make_block()");
-
-                               mapgen->makeChunk(&data);
-
-                               if (enable_mapgen_debug_info == false)
-                                       t.stop(true); // Hide output
-                       }
-
-                       do{ // enable break
-                               // Lock environment again to access the map
-                               JMutexAutoLock envlock(m_server->m_env_mutex);
-
-                               ScopeProfiler sp(g_profiler, "EmergeThread: after "
-                                               "mapgen::make_block (envlock)", SPT_AVG);
-
-                               // Blit data back on map, update lighting, add mobs and
-                               // whatever this does
-                               map.finishBlockMake(&data, modified_blocks);
-                               
-                               // Get central block
-                               block = map.getBlockNoCreateNoEx(p);
-
-                               // If block doesn't exist, don't try doing anything with it
-                               // This happens if the block is not in generation boundaries
-                               if(!block)
-                                       break;
-
-                               /*
-                                       Do some post-generate stuff
-                               */
-                               v3s16 minp = data.blockpos_min * MAP_BLOCKSIZE;
-                               v3s16 maxp = data.blockpos_max * MAP_BLOCKSIZE +
-                                               v3s16(1,1,1) * (MAP_BLOCKSIZE - 1);
-
-                               /*
-                                       Ignore map edit events, they will not need to be
-                                       sent to anybody because the block hasn't been sent
-                                       to anybody
-                               */
-                               MapEditEventAreaIgnorer ign(
-                                               &m_server->m_ignore_map_edit_events_area,
-                                               VoxelArea(minp, maxp));
-                               {
-                                       TimeTaker timer("on_generated");
-                                       scriptapi_environment_on_generated(m_server->m_lua,
-                                                       minp, maxp, emerge->getBlockSeed(minp));
-                                       //int t = timer.stop(true);
-                                       //dstream<<"on_generated took "<<t<<"ms"<<std::endl;
-                               }
-
-                               if (enable_mapgen_debug_info)
-                                       infostream << "EmergeThread: ended up with: "
-                                                       << analyze_block(block) << std::endl;
-
-                               // Activate objects and stuff
-                               m_server->m_env->activateBlock(block, 0);
-                       }while(false);
-               }
-
-               if(block == NULL)
-                       got_block = false;
-
-               /*
-                       Set sent status of modified blocks on clients
-               */
-
-               // NOTE: Server's clients are also behind the connection mutex
-               JMutexAutoLock lock(m_server->m_con_mutex);
-
-               /*
-                       Add the originally fetched block to the modified list
-               */
-               if(got_block)
-                       modified_blocks.insert(p, block);
-
-               /*
-                       Set the modified blocks unsent for all the clients
-               */
-               for(core::map<u16, RemoteClient*>::Iterator
-                               i = m_server->m_clients.getIterator();
-                               i.atEnd() == false; i++) {
-                       RemoteClient *client = i.getNode()->getValue();
-                       if(modified_blocks.size() > 0) {
-                               // Remove block from sent history
-                               client->SetBlocksNotSent(modified_blocks);
-                       }
-               }
-                                                       
-
-niters++;
-       }
-       catch (VersionMismatchException &e) {
-               std::ostringstream err;
-               err << "World data version mismatch in MapBlock "<<PP(last_tried_pos)<<std::endl;
-               err << "----"<<std::endl;
-               err << "\""<<e.what()<<"\""<<std::endl;
-               err << "See debug.txt."<<std::endl;
-               err << "World probably saved by a newer version of Minetest."<<std::endl;
-               m_server->setAsyncFatalError(err.str());
-       }
-       catch (SerializationError &e) {
-               std::ostringstream err;
-               err << "Invalid data in MapBlock "<<PP(last_tried_pos)<<std::endl;
-               err << "----"<<std::endl;
-               err << "\""<<e.what()<<"\""<<std::endl;
-               err << "See debug.txt."<<std::endl;
-               err << "You can ignore this using [ignore_world_load_errors = true]."<<std::endl;
-               m_server->setAsyncFatalError(err.str());
-       }
-printf("emergethread iterated %d times\n", niters);
-       END_DEBUG_EXCEPTION_HANDLER(errorstream)
-       log_deregister_thread();
-       return NULL;
-}
-
-#endif