]> git.lizzy.rs Git - dragonfireclient.git/blobdiff - src/content_sao.cpp
Update Android defaults for modern H/W. (#7572)
[dragonfireclient.git] / src / content_sao.cpp
index f0973082d7d90656e2fad020b6617ac1bf19e874..b67a63e3b8c9f823131c9d774c73a6900e286b4c 100644 (file)
@@ -26,8 +26,11 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "nodedef.h"
 #include "remoteplayer.h"
 #include "server.h"
-#include "scripting_game.h"
+#include "scripting_server.h"
 #include "genericobject.h"
+#include "settings.h"
+#include <algorithm>
+#include <cmath>
 
 std::map<u16, ServerActiveObject::Factory> ServerActiveObject::m_types;
 
@@ -59,7 +62,7 @@ class TestSAO : public ServerActiveObject
                m_age += dtime;
                if(m_age > 10)
                {
-                       m_removed = true;
+                       m_pending_removal = true;
                        return;
                }
 
@@ -67,7 +70,7 @@ class TestSAO : public ServerActiveObject
                if(m_base_position.Y > 8*BS)
                        m_base_position.Y = 2*BS;
 
-               if(send_recommended == false)
+               if (!send_recommended)
                        return;
 
                m_timer1 -= dtime;
@@ -91,6 +94,9 @@ class TestSAO : public ServerActiveObject
        }
 
        bool getCollisionBox(aabb3f *toset) const { return false; }
+
+       virtual bool getSelectionBox(aabb3f *toset) const { return false; }
+
        bool collideWithObjects() const { return false; }
 
 private:
@@ -106,19 +112,7 @@ TestSAO proto_TestSAO(NULL, v3f(0,0,0));
  */
 
 UnitSAO::UnitSAO(ServerEnvironment *env, v3f pos):
-       ServerActiveObject(env, pos),
-       m_hp(-1),
-       m_yaw(0),
-       m_properties_sent(true),
-       m_armor_groups_sent(false),
-       m_animation_range(0,0),
-       m_animation_speed(0),
-       m_animation_blend(0),
-       m_animation_loop(true),
-       m_animation_sent(false),
-       m_bone_position_sent(false),
-       m_attachment_parent_id(0),
-       m_attachment_sent(false)
+       ServerActiveObject(env, pos)
 {
        // Initialize something to armor groups
        m_armor_groups["fleshy"] = 100;
@@ -164,6 +158,12 @@ void UnitSAO::getAnimation(v2f *frame_range, float *frame_speed, float *frame_bl
        *frame_loop = m_animation_loop;
 }
 
+void UnitSAO::setAnimationSpeed(float frame_speed)
+{
+       m_animation_speed = frame_speed;
+       m_animation_speed_sent = false;
+}
+
 void UnitSAO::setBonePosition(const std::string &bone, v3f position, v3f rotation)
 {
        // store these so they can be updated to clients
@@ -187,11 +187,17 @@ void UnitSAO::setAttachment(int parent_id, const std::string &bone, v3f position
        // This breaks some things so we also give the server the most accurate representation
        // even if players only see the client changes.
 
+       int old_parent = m_attachment_parent_id;
        m_attachment_parent_id = parent_id;
        m_attachment_bone = bone;
        m_attachment_position = position;
        m_attachment_rotation = rotation;
        m_attachment_sent = false;
+
+       if (parent_id != old_parent) {
+               onDetach(old_parent);
+               onAttach(parent_id);
+       }
 }
 
 void UnitSAO::getAttachment(int *parent_id, std::string *bone, v3f *position,
@@ -203,13 +209,27 @@ void UnitSAO::getAttachment(int *parent_id, std::string *bone, v3f *position,
        *rotation = m_attachment_rotation;
 }
 
-void UnitSAO::detachFromParent()
+void UnitSAO::clearChildAttachments()
+{
+       for (int child_id : m_attachment_child_ids) {
+               // Child can be NULL if it was deleted earlier
+               if (ServerActiveObject *child = m_env->getActiveObject(child_id))
+                       child->setAttachment(0, "", v3f(0, 0, 0), v3f(0, 0, 0));
+       }
+       m_attachment_child_ids.clear();
+}
+
+void UnitSAO::clearParentAttachment()
 {
-       ServerActiveObject *parent = NULL;
-       if (m_attachment_parent_id)
+       ServerActiveObject *parent = nullptr;
+       if (m_attachment_parent_id) {
                parent = m_env->getActiveObject(m_attachment_parent_id);
-       setAttachment(NULL, "", v3f(0, 0, 0), v3f(0, 0, 0));
-       if (parent != NULL)
+               setAttachment(0, "", m_attachment_position, m_attachment_rotation);
+       } else {
+               setAttachment(0, "", v3f(0, 0, 0), v3f(0, 0, 0));
+       }
+       // Do it
+       if (parent)
                parent->removeAttachmentChild(m_id);
 }
 
@@ -223,11 +243,43 @@ void UnitSAO::removeAttachmentChild(int child_id)
        m_attachment_child_ids.erase(child_id);
 }
 
-const UNORDERED_SET<int> &UnitSAO::getAttachmentChildIds()
+const std::unordered_set<int> &UnitSAO::getAttachmentChildIds()
 {
        return m_attachment_child_ids;
 }
 
+void UnitSAO::onAttach(int parent_id)
+{
+       if (!parent_id)
+               return;
+
+       ServerActiveObject *parent = m_env->getActiveObject(parent_id);
+
+       if (!parent || parent->isGone())
+               return; // Do not try to notify soon gone parent
+
+       if (parent->getType() == ACTIVEOBJECT_TYPE_LUAENTITY) {
+               // Call parent's on_attach field
+               m_env->getScriptIface()->luaentity_on_attach_child(parent_id, this);
+       }
+}
+
+void UnitSAO::onDetach(int parent_id)
+{
+       if (!parent_id)
+               return;
+
+       ServerActiveObject *parent = m_env->getActiveObject(parent_id);
+       if (getType() == ACTIVEOBJECT_TYPE_LUAENTITY)
+               m_env->getScriptIface()->luaentity_on_detach(m_id, parent);
+
+       if (!parent || parent->isGone())
+               return; // Do not try to notify soon gone parent
+
+       if (parent->getType() == ACTIVEOBJECT_TYPE_LUAENTITY)
+               m_env->getScriptIface()->luaentity_on_detach_child(parent_id, this);
+}
+
 ObjectProperties* UnitSAO::accessObjectProperties()
 {
        return &m_prop;
@@ -249,16 +301,7 @@ LuaEntitySAO::LuaEntitySAO(ServerEnvironment *env, v3f pos,
                const std::string &name, const std::string &state):
        UnitSAO(env, pos),
        m_init_name(name),
-       m_init_state(state),
-       m_registered(false),
-       m_velocity(0,0,0),
-       m_acceleration(0,0,0),
-       m_last_sent_yaw(0),
-       m_last_sent_position(0,0,0),
-       m_last_sent_velocity(0,0,0),
-       m_last_sent_position_timer(0),
-       m_last_sent_move_precision(0),
-       m_current_texture_modifier("")
+       m_init_state(state)
 {
        // Only register type if no environment supplied
        if(env == NULL){
@@ -273,9 +316,8 @@ LuaEntitySAO::~LuaEntitySAO()
                m_env->getScriptIface()->luaentity_Remove(m_id);
        }
 
-       for (UNORDERED_SET<u32>::iterator it = m_attached_particle_spawners.begin();
-               it != m_attached_particle_spawners.end(); ++it) {
-               m_env->deleteParticleSpawner(*it, false);
+       for (u32 attached_particle_spawner : m_attached_particle_spawners) {
+               m_env->deleteParticleSpawner(attached_particle_spawner, false);
        }
 }
 
@@ -295,7 +337,7 @@ void LuaEntitySAO::addedToEnvironment(u32 dtime_s)
                m_hp = m_prop.hp_max;
                // Activate entity, supplying serialized state
                m_env->getScriptIface()->
-                       luaentity_Activate(m_id, m_init_state.c_str(), dtime_s);
+                       luaentity_Activate(m_id, m_init_state, dtime_s);
        } else {
                m_prop.infotext = m_init_name;
        }
@@ -309,7 +351,7 @@ ServerActiveObject* LuaEntitySAO::create(ServerEnvironment *env, v3f pos,
        s16 hp = 1;
        v3f velocity;
        float yaw = 0;
-       if(data != ""){
+       if (!data.empty()) {
                std::istringstream is(data, std::ios::binary);
                // read version
                u8 version = readU8(is);
@@ -394,20 +436,20 @@ void LuaEntitySAO::step(float dtime, bool send_recommended)
                        m_velocity += dtime * m_acceleration;
                }
 
-               if((m_prop.automatic_face_movement_dir) &&
-                               (fabs(m_velocity.Z) > 0.001 || fabs(m_velocity.X) > 0.001))
-               {
-                       float optimal_yaw = atan2(m_velocity.Z,m_velocity.X) * 180 / M_PI
-                                       + m_prop.automatic_face_movement_dir_offset;
+               if (m_prop.automatic_face_movement_dir &&
+                               (fabs(m_velocity.Z) > 0.001 || fabs(m_velocity.X) > 0.001)) {
+
+                       float target_yaw = atan2(m_velocity.Z, m_velocity.X) * 180 / M_PI
+                               + m_prop.automatic_face_movement_dir_offset;
                        float max_rotation_delta =
                                        dtime * m_prop.automatic_face_movement_max_rotation_per_sec;
+                       float delta = wrapDegrees_0_360(target_yaw - m_yaw);
 
-                       if ((m_prop.automatic_face_movement_max_rotation_per_sec > 0) &&
-                               (fabs(m_yaw - optimal_yaw) > max_rotation_delta)) {
-
-                               m_yaw = optimal_yaw < m_yaw ? m_yaw - max_rotation_delta : m_yaw + max_rotation_delta;
+                       if (delta > max_rotation_delta && 360 - delta > max_rotation_delta) {
+                               m_yaw += (delta < 180) ? max_rotation_delta : -max_rotation_delta;
+                               m_yaw = wrapDegrees_0_360(m_yaw);
                        } else {
-                               m_yaw = optimal_yaw;
+                               m_yaw = target_yaw;
                        }
                }
        }
@@ -416,7 +458,7 @@ void LuaEntitySAO::step(float dtime, bool send_recommended)
                m_env->getScriptIface()->luaentity_Step(m_id, dtime);
        }
 
-       if(send_recommended == false)
+       if (!send_recommended)
                return;
 
        if(!isAttached())
@@ -431,13 +473,13 @@ void LuaEntitySAO::step(float dtime, bool send_recommended)
                float move_d = m_base_position.getDistanceFrom(m_last_sent_position);
                move_d += m_last_sent_move_precision;
                float vel_d = m_velocity.getDistanceFrom(m_last_sent_velocity);
-               if(move_d > minchange || vel_d > minchange ||
-                               fabs(m_yaw - m_last_sent_yaw) > 1.0){
+               if (move_d > minchange || vel_d > minchange ||
+                               std::fabs(m_yaw - m_last_sent_yaw) > 1.0) {
                        sendPosition(true, false);
                }
        }
 
-       if(m_armor_groups_sent == false){
+       if (!m_armor_groups_sent) {
                m_armor_groups_sent = true;
                std::string str = gob_cmd_update_armor_groups(
                                m_armor_groups);
@@ -446,7 +488,7 @@ void LuaEntitySAO::step(float dtime, bool send_recommended)
                m_messages_out.push(aom);
        }
 
-       if(m_animation_sent == false){
+       if (!m_animation_sent) {
                m_animation_sent = true;
                std::string str = gob_cmd_update_animation(
                        m_animation_range, m_animation_speed, m_animation_blend, m_animation_loop);
@@ -455,9 +497,17 @@ void LuaEntitySAO::step(float dtime, bool send_recommended)
                m_messages_out.push(aom);
        }
 
-       if(m_bone_position_sent == false){
+       if (!m_animation_speed_sent) {
+               m_animation_speed_sent = true;
+               std::string str = gob_cmd_update_animation_speed(m_animation_speed);
+               // create message and add to list
+               ActiveObjectMessage aom(getId(), true, str);
+               m_messages_out.push(aom);
+       }
+
+       if (!m_bone_position_sent) {
                m_bone_position_sent = true;
-               for (UNORDERED_MAP<std::string, core::vector2d<v3f> >::const_iterator
+               for (std::unordered_map<std::string, core::vector2d<v3f>>::const_iterator
                                ii = m_bone_position.begin(); ii != m_bone_position.end(); ++ii){
                        std::string str = gob_cmd_update_bone_position((*ii).first,
                                        (*ii).second.X, (*ii).second.Y);
@@ -467,7 +517,7 @@ void LuaEntitySAO::step(float dtime, bool send_recommended)
                }
        }
 
-       if(m_attachment_sent == false){
+       if (!m_attachment_sent) {
                m_attachment_sent = true;
                std::string str = gob_cmd_update_attachment(m_attachment_parent_id, m_attachment_bone, m_attachment_position, m_attachment_rotation);
                // create message and add to list
@@ -480,57 +530,43 @@ std::string LuaEntitySAO::getClientInitializationData(u16 protocol_version)
 {
        std::ostringstream os(std::ios::binary);
 
-       if(protocol_version >= 14)
-       {
-               writeU8(os, 1); // version
-               os<<serializeString(""); // name
-               writeU8(os, 0); // is_player
-               writeS16(os, getId()); //id
-               writeV3F1000(os, m_base_position);
-               writeF1000(os, m_yaw);
-               writeS16(os, m_hp);
-
-               std::ostringstream msg_os(std::ios::binary);
-               msg_os << serializeLongString(getPropertyPacket()); // message 1
-               msg_os << serializeLongString(gob_cmd_update_armor_groups(m_armor_groups)); // 2
-               msg_os << serializeLongString(gob_cmd_update_animation(
-                       m_animation_range, m_animation_speed, m_animation_blend, m_animation_loop)); // 3
-               for (UNORDERED_MAP<std::string, core::vector2d<v3f> >::const_iterator
-                               ii = m_bone_position.begin(); ii != m_bone_position.end(); ++ii) {
-                       msg_os << serializeLongString(gob_cmd_update_bone_position((*ii).first,
-                                       (*ii).second.X, (*ii).second.Y)); // m_bone_position.size
-               }
-               msg_os << serializeLongString(gob_cmd_update_attachment(m_attachment_parent_id,
-                       m_attachment_bone, m_attachment_position, m_attachment_rotation)); // 4
-               int message_count = 4 + m_bone_position.size();
-               for (UNORDERED_SET<int>::const_iterator ii = m_attachment_child_ids.begin();
-                               (ii != m_attachment_child_ids.end()); ++ii) {
-                       if (ServerActiveObject *obj = m_env->getActiveObject(*ii)) {
-                               message_count++;
-                               msg_os << serializeLongString(gob_cmd_update_infant(*ii, obj->getSendType(),
-                                       obj->getClientInitializationData(protocol_version)));
-                       }
-               }
-
-               msg_os << serializeLongString(gob_cmd_set_texture_mod(m_current_texture_modifier));
-               message_count++;
+       // protocol >= 14
+       writeU8(os, 1); // version
+       os << serializeString(""); // name
+       writeU8(os, 0); // is_player
+       writeS16(os, getId()); //id
+       writeV3F1000(os, m_base_position);
+       writeF1000(os, m_yaw);
+       writeS16(os, m_hp);
 
-               writeU8(os, message_count);
-               os.write(msg_os.str().c_str(), msg_os.str().size());
+       std::ostringstream msg_os(std::ios::binary);
+       msg_os << serializeLongString(getPropertyPacket()); // message 1
+       msg_os << serializeLongString(gob_cmd_update_armor_groups(m_armor_groups)); // 2
+       msg_os << serializeLongString(gob_cmd_update_animation(
+               m_animation_range, m_animation_speed, m_animation_blend, m_animation_loop)); // 3
+       for (std::unordered_map<std::string, core::vector2d<v3f>>::const_iterator
+                       ii = m_bone_position.begin(); ii != m_bone_position.end(); ++ii) {
+               msg_os << serializeLongString(gob_cmd_update_bone_position((*ii).first,
+                               (*ii).second.X, (*ii).second.Y)); // m_bone_position.size
        }
-       else
-       {
-               writeU8(os, 0); // version
-               os<<serializeString(""); // name
-               writeU8(os, 0); // is_player
-               writeV3F1000(os, m_base_position);
-               writeF1000(os, m_yaw);
-               writeS16(os, m_hp);
-               writeU8(os, 2); // number of messages stuffed in here
-               os<<serializeLongString(getPropertyPacket()); // message 1
-               os<<serializeLongString(gob_cmd_update_armor_groups(m_armor_groups)); // 2
+       msg_os << serializeLongString(gob_cmd_update_attachment(m_attachment_parent_id,
+               m_attachment_bone, m_attachment_position, m_attachment_rotation)); // 4
+       int message_count = 4 + m_bone_position.size();
+       for (std::unordered_set<int>::const_iterator ii = m_attachment_child_ids.begin();
+                       (ii != m_attachment_child_ids.end()); ++ii) {
+               if (ServerActiveObject *obj = m_env->getActiveObject(*ii)) {
+                       message_count++;
+                       msg_os << serializeLongString(gob_cmd_update_infant(*ii, obj->getSendType(),
+                               obj->getClientInitializationData(protocol_version)));
+               }
        }
 
+       msg_os << serializeLongString(gob_cmd_set_texture_mod(m_current_texture_modifier));
+       message_count++;
+
+       writeU8(os, message_count);
+       os.write(msg_os.str().c_str(), msg_os.str().size());
+
        // return result
        return os.str();
 }
@@ -565,16 +601,12 @@ int LuaEntitySAO::punch(v3f dir,
                ServerActiveObject *puncher,
                float time_from_last_punch)
 {
-       if (!m_registered){
+       if (!m_registered) {
                // Delete unknown LuaEntities when punched
-               m_removed = true;
+               m_pending_removal = true;
                return 0;
        }
 
-       // It's best that attachments cannot be punched
-       if (isAttached())
-               return 0;
-
        ItemStack *punchitem = NULL;
        ItemStack punchitem_static;
        if (puncher) {
@@ -588,28 +620,35 @@ int LuaEntitySAO::punch(v3f dir,
                        punchitem,
                        time_from_last_punch);
 
-       if (result.did_punch) {
-               setHP(getHP() - result.damage);
+       bool damage_handled = m_env->getScriptIface()->luaentity_Punch(m_id, puncher,
+                       time_from_last_punch, toolcap, dir, result.did_punch ? result.damage : 0);
 
-               if (result.damage > 0) {
-                       std::string punchername = puncher ? puncher->getDescription() : "nil";
+       if (!damage_handled) {
+               if (result.did_punch) {
+                       setHP(getHP() - result.damage,
+                               PlayerHPChangeReason(PlayerHPChangeReason::SET_HP));
 
-                       actionstream << getDescription() << " punched by "
-                                       << punchername << ", damage " << result.damage
-                                       << " hp, health now " << getHP() << " hp" << std::endl;
-               }
+                       if (result.damage > 0) {
+                               std::string punchername = puncher ? puncher->getDescription() : "nil";
 
-               std::string str = gob_cmd_punched(result.damage, getHP());
-               // create message and add to list
-               ActiveObjectMessage aom(getId(), true, str);
-               m_messages_out.push(aom);
-       }
+                               actionstream << getDescription() << " punched by "
+                                               << punchername << ", damage " << result.damage
+                                               << " hp, health now " << getHP() << " hp" << std::endl;
+                       }
 
-       if (getHP() == 0)
-               m_removed = true;
+                       std::string str = gob_cmd_punched(result.damage, getHP());
+                       // create message and add to list
+                       ActiveObjectMessage aom(getId(), true, str);
+                       m_messages_out.push(aom);
+               }
+       }
 
-       m_env->getScriptIface()->luaentity_Punch(m_id, puncher,
-                       time_from_last_punch, toolcap, dir);
+       if (getHP() == 0 && !isGone()) {
+               m_pending_removal = true;
+               clearParentAttachment();
+               clearChildAttachments();
+               m_env->getScriptIface()->luaentity_on_death(m_id, puncher);
+       }
 
        return result.wear;
 }
@@ -618,9 +657,7 @@ void LuaEntitySAO::rightClick(ServerActiveObject *clicker)
 {
        if (!m_registered)
                return;
-       // It's best that attachments cannot be clicked
-       if (isAttached())
-               return;
+
        m_env->getScriptIface()->luaentity_Rightclick(m_id, clicker);
 }
 
@@ -657,9 +694,10 @@ std::string LuaEntitySAO::getDescription()
        return os.str();
 }
 
-void LuaEntitySAO::setHP(s16 hp)
+void LuaEntitySAO::setHP(s16 hp, const PlayerHPChangeReason &reason)
 {
-       if(hp < 0) hp = 0;
+       if (hp < 0)
+               hp = 0;
        m_hp = hp;
 }
 
@@ -773,6 +811,18 @@ bool LuaEntitySAO::getCollisionBox(aabb3f *toset) const
        return false;
 }
 
+bool LuaEntitySAO::getSelectionBox(aabb3f *toset) const
+{
+       if (!m_prop.is_visible || !m_prop.pointable) {
+               return false;
+       }
+
+       toset->MinEdge = m_prop.selectionbox.MinEdge * BS;
+       toset->MaxEdge = m_prop.selectionbox.MaxEdge * BS;
+
+       return true;
+}
+
 bool LuaEntitySAO::collideWithObjects() const
 {
        return m_prop.collideWithObjects;
@@ -784,50 +834,41 @@ bool LuaEntitySAO::collideWithObjects() const
 
 // No prototype, PlayerSAO does not need to be deserialized
 
-PlayerSAO::PlayerSAO(ServerEnvironment *env_, u16 peer_id_, bool is_singleplayer):
+PlayerSAO::PlayerSAO(ServerEnvironment *env_, RemotePlayer *player_, session_t peer_id_,
+               bool is_singleplayer):
        UnitSAO(env_, v3f(0,0,0)),
-       m_player(NULL),
+       m_player(player_),
        m_peer_id(peer_id_),
-       m_inventory(NULL),
-       m_damage(0),
-       m_last_good_position(0,0,0),
-       m_time_from_last_punch(0),
-       m_nocheat_dig_pos(32767, 32767, 32767),
-       m_nocheat_dig_time(0),
-       m_wield_index(0),
-       m_position_not_sent(false),
-       m_is_singleplayer(is_singleplayer),
-       m_breath(PLAYER_MAX_BREATH),
-       m_pitch(0),
-       m_fov(0),
-       m_wanted_range(0),
-       // public
-       m_physics_override_speed(1),
-       m_physics_override_jump(1),
-       m_physics_override_gravity(1),
-       m_physics_override_sneak(true),
-       m_physics_override_sneak_glitch(true),
-       m_physics_override_sent(false)
+       m_is_singleplayer(is_singleplayer)
 {
        assert(m_peer_id != 0); // pre-condition
 
-       m_prop.hp_max = PLAYER_MAX_HP;
+       m_prop.hp_max = PLAYER_MAX_HP_DEFAULT;
+       m_prop.breath_max = PLAYER_MAX_BREATH_DEFAULT;
        m_prop.physical = false;
        m_prop.weight = 75;
-       m_prop.collisionbox = aabb3f(-1/3.,-1.0,-1/3., 1/3.,1.0,1/3.);
-       // start of default appearance, this should be overwritten by LUA
+       m_prop.collisionbox = aabb3f(-0.3f, 0.0f, -0.3f, 0.3f, 1.77f, 0.3f);
+       m_prop.selectionbox = aabb3f(-0.3f, 0.0f, -0.3f, 0.3f, 1.77f, 0.3f);
+       m_prop.pointable = true;
+       // Start of default appearance, this should be overwritten by Lua
        m_prop.visual = "upright_sprite";
        m_prop.visual_size = v2f(1, 2);
        m_prop.textures.clear();
-       m_prop.textures.push_back("player.png");
-       m_prop.textures.push_back("player_back.png");
+       m_prop.textures.emplace_back("player.png");
+       m_prop.textures.emplace_back("player_back.png");
        m_prop.colors.clear();
-       m_prop.colors.push_back(video::SColor(255, 255, 255, 255));
+       m_prop.colors.emplace_back(255, 255, 255, 255);
        m_prop.spritediv = v2s16(1,1);
-       // end of default appearance
+       m_prop.eye_height = 1.625f;
+       // End of default appearance
        m_prop.is_visible = true;
+       m_prop.backface_culling = false;
        m_prop.makes_footstep_sound = true;
-       m_hp = PLAYER_MAX_HP;
+       m_prop.stepheight = PLAYER_DEFAULT_STEPHEIGHT * BS;
+       m_hp = m_prop.hp_max;
+       m_breath = m_prop.breath_max;
+       // Disable zoom in survival mode using a value of 0
+       m_prop.zoom_fov = g_settings->getBool("creative_mode") ? 15.0f : 0.0f;
 }
 
 PlayerSAO::~PlayerSAO()
@@ -836,7 +877,7 @@ PlayerSAO::~PlayerSAO()
                delete m_inventory;
 }
 
-void PlayerSAO::initialize(RemotePlayer *player, const std::set<std::string> &privs)
+void PlayerSAO::finalize(RemotePlayer *player, const std::set<std::string> &privs)
 {
        assert(player);
        m_player = player;
@@ -846,7 +887,7 @@ void PlayerSAO::initialize(RemotePlayer *player, const std::set<std::string> &pr
 
 v3f PlayerSAO::getEyeOffset() const
 {
-       return v3f(0, BS * 1.625f, 0);
+       return v3f(0, BS * m_prop.eye_height, 0);
 }
 
 std::string PlayerSAO::getDescription()
@@ -860,7 +901,7 @@ void PlayerSAO::addedToEnvironment(u32 dtime_s)
        ServerActiveObject::addedToEnvironment(dtime_s);
        ServerActiveObject::setBasePosition(m_base_position);
        m_player->setPlayerSAO(this);
-       m_player->peer_id = m_peer_id;
+       m_player->setPeerId(m_peer_id);
        m_last_good_position = m_base_position;
 }
 
@@ -870,9 +911,8 @@ void PlayerSAO::removingFromEnvironment()
        ServerActiveObject::removingFromEnvironment();
        if (m_player->getPlayerSAO() == this) {
                unlinkPlayerSessionAndSave();
-               for (UNORDERED_SET<u32>::iterator it = m_attached_particle_spawners.begin();
-                       it != m_attached_particle_spawners.end(); ++it) {
-                       m_env->deleteParticleSpawner(*it, false);
+               for (u32 attached_particle_spawner : m_attached_particle_spawners) {
+                       m_env->deleteParticleSpawner(attached_particle_spawner, false);
                }
        }
 }
@@ -881,98 +921,115 @@ std::string PlayerSAO::getClientInitializationData(u16 protocol_version)
 {
        std::ostringstream os(std::ios::binary);
 
-       if(protocol_version >= 15)
-       {
-               writeU8(os, 1); // version
-               os<<serializeString(m_player->getName()); // name
-               writeU8(os, 1); // is_player
-               writeS16(os, getId()); //id
-               writeV3F1000(os, m_base_position + v3f(0,BS*1,0));
-               writeF1000(os, m_yaw);
-               writeS16(os, getHP());
-
-               std::ostringstream msg_os(std::ios::binary);
-               msg_os << serializeLongString(getPropertyPacket()); // message 1
-               msg_os << serializeLongString(gob_cmd_update_armor_groups(m_armor_groups)); // 2
-               msg_os << serializeLongString(gob_cmd_update_animation(
-                       m_animation_range, m_animation_speed, m_animation_blend, m_animation_loop)); // 3
-               for (UNORDERED_MAP<std::string, core::vector2d<v3f> >::const_iterator
-                               ii = m_bone_position.begin(); ii != m_bone_position.end(); ++ii) {
-                       msg_os << serializeLongString(gob_cmd_update_bone_position((*ii).first,
-                               (*ii).second.X, (*ii).second.Y)); // m_bone_position.size
-               }
-               msg_os << serializeLongString(gob_cmd_update_attachment(m_attachment_parent_id,
-                       m_attachment_bone, m_attachment_position, m_attachment_rotation)); // 4
-               msg_os << serializeLongString(gob_cmd_update_physics_override(m_physics_override_speed,
-                               m_physics_override_jump, m_physics_override_gravity, m_physics_override_sneak,
-                               m_physics_override_sneak_glitch)); // 5
-               // (GENERIC_CMD_UPDATE_NAMETAG_ATTRIBUTES) : Deprecated, for backwards compatibility only.
-               msg_os << serializeLongString(gob_cmd_update_nametag_attributes(m_prop.nametag_color)); // 6
-               int message_count = 6 + m_bone_position.size();
-               for (UNORDERED_SET<int>::const_iterator ii = m_attachment_child_ids.begin();
-                               ii != m_attachment_child_ids.end(); ++ii) {
-                       if (ServerActiveObject *obj = m_env->getActiveObject(*ii)) {
-                               message_count++;
-                               msg_os << serializeLongString(gob_cmd_update_infant(*ii, obj->getSendType(),
-                                       obj->getClientInitializationData(protocol_version)));
-                       }
-               }
-
-               writeU8(os, message_count);
-               os.write(msg_os.str().c_str(), msg_os.str().size());
+       // Protocol >= 15
+       writeU8(os, 1); // version
+       os << serializeString(m_player->getName()); // name
+       writeU8(os, 1); // is_player
+       writeS16(os, getId()); //id
+       writeV3F1000(os, m_base_position);
+       writeF1000(os, m_yaw);
+       writeS16(os, getHP());
+
+       std::ostringstream msg_os(std::ios::binary);
+       msg_os << serializeLongString(getPropertyPacket()); // message 1
+       msg_os << serializeLongString(gob_cmd_update_armor_groups(m_armor_groups)); // 2
+       msg_os << serializeLongString(gob_cmd_update_animation(
+               m_animation_range, m_animation_speed, m_animation_blend, m_animation_loop)); // 3
+       for (std::unordered_map<std::string, core::vector2d<v3f>>::const_iterator
+                       ii = m_bone_position.begin(); ii != m_bone_position.end(); ++ii) {
+               msg_os << serializeLongString(gob_cmd_update_bone_position((*ii).first,
+                       (*ii).second.X, (*ii).second.Y)); // m_bone_position.size
        }
-       else
-       {
-               writeU8(os, 0); // version
-               os<<serializeString(m_player->getName()); // name
-               writeU8(os, 1); // is_player
-               writeV3F1000(os, m_base_position + v3f(0,BS*1,0));
-               writeF1000(os, m_yaw);
-               writeS16(os, getHP());
-               writeU8(os, 2); // number of messages stuffed in here
-               os<<serializeLongString(getPropertyPacket()); // message 1
-               os<<serializeLongString(gob_cmd_update_armor_groups(m_armor_groups)); // 2
+       msg_os << serializeLongString(gob_cmd_update_attachment(m_attachment_parent_id,
+               m_attachment_bone, m_attachment_position, m_attachment_rotation)); // 4
+       msg_os << serializeLongString(gob_cmd_update_physics_override(m_physics_override_speed,
+                       m_physics_override_jump, m_physics_override_gravity, m_physics_override_sneak,
+                       m_physics_override_sneak_glitch, m_physics_override_new_move)); // 5
+       // (GENERIC_CMD_UPDATE_NAMETAG_ATTRIBUTES) : Deprecated, for backwards compatibility only.
+       msg_os << serializeLongString(gob_cmd_update_nametag_attributes(m_prop.nametag_color)); // 6
+       int message_count = 6 + m_bone_position.size();
+       for (std::unordered_set<int>::const_iterator ii = m_attachment_child_ids.begin();
+                       ii != m_attachment_child_ids.end(); ++ii) {
+               if (ServerActiveObject *obj = m_env->getActiveObject(*ii)) {
+                       message_count++;
+                       msg_os << serializeLongString(gob_cmd_update_infant(*ii, obj->getSendType(),
+                               obj->getClientInitializationData(protocol_version)));
+               }
        }
 
+       writeU8(os, message_count);
+       os.write(msg_os.str().c_str(), msg_os.str().size());
+
        // return result
        return os.str();
 }
 
-void PlayerSAO::getStaticData(std::string *result) const
+void PlayerSAO::getStaticData(std::string * result) const
 {
        FATAL_ERROR("Deprecated function");
 }
 
 void PlayerSAO::step(float dtime, bool send_recommended)
 {
-       if (m_drowning_interval.step(dtime, 2.0)) {
-               // get head position
-               v3s16 p = floatToInt(m_base_position + v3f(0, BS * 1.6, 0), BS);
+       if (m_drowning_interval.step(dtime, 2.0f)) {
+               // Get nose/mouth position, approximate with eye position
+               v3s16 p = floatToInt(getEyePosition(), BS);
                MapNode n = m_env->getMap().getNodeNoEx(p);
                const ContentFeatures &c = m_env->getGameDef()->ndef()->get(n);
                // If node generates drown
-               if (c.drowning > 0) {
-                       if (m_hp > 0 && m_breath > 0)
+               if (c.drowning > 0 && m_hp > 0) {
+                       if (m_breath > 0)
                                setBreath(m_breath - 1);
 
                        // No more breath, damage player
                        if (m_breath == 0) {
-                               setHP(m_hp - c.drowning);
-                               m_env->getGameDef()->SendPlayerHPOrDie(this);
+                               PlayerHPChangeReason reason(PlayerHPChangeReason::DROWNING);
+                               setHP(m_hp - c.drowning, reason);
+                               m_env->getGameDef()->SendPlayerHPOrDie(this, reason);
                        }
                }
        }
 
-       if (m_breathing_interval.step(dtime, 0.5)) {
-               // get head position
-               v3s16 p = floatToInt(m_base_position + v3f(0, BS * 1.6, 0), BS);
+       if (m_breathing_interval.step(dtime, 0.5f)) {
+               // Get nose/mouth position, approximate with eye position
+               v3s16 p = floatToInt(getEyePosition(), BS);
                MapNode n = m_env->getMap().getNodeNoEx(p);
                const ContentFeatures &c = m_env->getGameDef()->ndef()->get(n);
-               // If player is alive & no drowning, breath
-               if (m_hp > 0 && c.drowning == 0)
+               // If player is alive & no drowning, breathe
+               if (m_hp > 0 && m_breath < m_prop.breath_max && c.drowning == 0)
                        setBreath(m_breath + 1);
        }
 
+       if (m_node_hurt_interval.step(dtime, 1.0f)) {
+               u32 damage_per_second = 0;
+               // Lowest and highest damage points are 0.1 within collisionbox
+               float dam_top = m_prop.collisionbox.MaxEdge.Y - 0.1f;
+
+               // Sequence of damage points, starting 0.1 above feet and progressing
+               // upwards in 1 node intervals, stopping below top damage point.
+               for (float dam_height = 0.1f; dam_height < dam_top; dam_height++) {
+                       v3s16 p = floatToInt(m_base_position +
+                               v3f(0.0f, dam_height * BS, 0.0f), BS);
+                       MapNode n = m_env->getMap().getNodeNoEx(p);
+                       damage_per_second = std::max(damage_per_second,
+                               m_env->getGameDef()->ndef()->get(n).damage_per_second);
+               }
+
+               // Top damage point
+               v3s16 ptop = floatToInt(m_base_position +
+                       v3f(0.0f, dam_top * BS, 0.0f), BS);
+               MapNode ntop = m_env->getMap().getNodeNoEx(ptop);
+               damage_per_second = std::max(damage_per_second,
+                       m_env->getGameDef()->ndef()->get(ntop).damage_per_second);
+
+               if (damage_per_second != 0 && m_hp > 0) {
+                       s16 newhp = ((s32) damage_per_second > m_hp ? 0 : m_hp - damage_per_second);
+                       PlayerHPChangeReason reason(PlayerHPChangeReason::NODE_DAMAGE);
+                       setHP(newhp, reason);
+                       m_env->getGameDef()->SendPlayerHPOrDie(this, reason);
+               }
+       }
+
        if (!m_properties_sent) {
                m_properties_sent = true;
                std::string str = getPropertyPacket();
@@ -982,12 +1039,11 @@ void PlayerSAO::step(float dtime, bool send_recommended)
        }
 
        // If attached, check that our parent is still there. If it isn't, detach.
-       if(m_attachment_parent_id && !isAttached())
-       {
+       if (m_attachment_parent_id && !isAttached()) {
                m_attachment_parent_id = 0;
                m_attachment_bone = "";
-               m_attachment_position = v3f(0,0,0);
-               m_attachment_rotation = v3f(0,0,0);
+               m_attachment_position = v3f(0.0f, 0.0f, 0.0f);
+               m_attachment_rotation = v3f(0.0f, 0.0f, 0.0f);
                setBasePosition(m_last_good_position);
                m_env->getGameDef()->SendMovePlayer(m_peer_id);
        }
@@ -995,8 +1051,8 @@ void PlayerSAO::step(float dtime, bool send_recommended)
        //dstream<<"PlayerSAO::step: dtime: "<<dtime<<std::endl;
 
        // Set lag pool maximums based on estimated lag
-       const float LAG_POOL_MIN = 5.0;
-       float lag_pool_max = m_env->getMaxLagEstimate() * 2.0;
+       const float LAG_POOL_MIN = 5.0f;
+       float lag_pool_max = m_env->getMaxLagEstimate() * 2.0f;
        if(lag_pool_max < LAG_POOL_MIN)
                lag_pool_max = LAG_POOL_MIN;
        m_dig_pool.setMax(lag_pool_max);
@@ -1005,11 +1061,14 @@ void PlayerSAO::step(float dtime, bool send_recommended)
        // Increment cheat prevention timers
        m_dig_pool.add(dtime);
        m_move_pool.add(dtime);
+       m_time_from_last_teleport += dtime;
        m_time_from_last_punch += dtime;
        m_nocheat_dig_time += dtime;
 
-       // Each frame, parent position is copied if the object is attached, otherwise it's calculated normally
-       // If the object gets detached this comes into effect automatically from the last known origin
+       // Each frame, parent position is copied if the object is attached,
+       // otherwise it's calculated normally.
+       // If the object gets detached this comes into effect automatically from
+       // the last known origin.
        if (isAttached()) {
                v3f pos = m_env->getActiveObject(m_attachment_parent_id)->getBasePosition();
                m_last_good_position = pos;
@@ -1019,20 +1078,21 @@ void PlayerSAO::step(float dtime, bool send_recommended)
        if (!send_recommended)
                return;
 
-       // If the object is attached client-side, don't waste bandwidth sending its position to clients
-       if(m_position_not_sent && !isAttached())
-       {
+       // If the object is attached client-side, don't waste bandwidth sending its
+       // position to clients.
+       if (m_position_not_sent && !isAttached()) {
                m_position_not_sent = false;
                float update_interval = m_env->getSendRecommendedInterval();
                v3f pos;
-               if(isAttached()) // Just in case we ever do send attachment position too
+               if (isAttached()) // Just in case we ever do send attachment position too
                        pos = m_env->getActiveObject(m_attachment_parent_id)->getBasePosition();
                else
-                       pos = m_base_position + v3f(0,BS*1,0);
+                       pos = m_base_position;
+
                std::string str = gob_cmd_update_position(
                        pos,
-                       v3f(0,0,0),
-                       v3f(0,0,0),
+                       v3f(0.0f, 0.0f, 0.0f),
+                       v3f(0.0f, 0.0f, 0.0f),
                        m_yaw,
                        true,
                        false,
@@ -1056,7 +1116,8 @@ void PlayerSAO::step(float dtime, bool send_recommended)
                m_physics_override_sent = true;
                std::string str = gob_cmd_update_physics_override(m_physics_override_speed,
                                m_physics_override_jump, m_physics_override_gravity,
-                               m_physics_override_sneak, m_physics_override_sneak_glitch);
+                               m_physics_override_sneak, m_physics_override_sneak_glitch,
+                               m_physics_override_new_move);
                // create message and add to list
                ActiveObjectMessage aom(getId(), true, str);
                m_messages_out.push(aom);
@@ -1073,7 +1134,7 @@ void PlayerSAO::step(float dtime, bool send_recommended)
 
        if (!m_bone_position_sent) {
                m_bone_position_sent = true;
-               for (UNORDERED_MAP<std::string, core::vector2d<v3f> >::const_iterator
+               for (std::unordered_map<std::string, core::vector2d<v3f>>::const_iterator
                                ii = m_bone_position.begin(); ii != m_bone_position.end(); ++ii) {
                        std::string str = gob_cmd_update_bone_position((*ii).first,
                                        (*ii).second.X, (*ii).second.Y);
@@ -1083,7 +1144,7 @@ void PlayerSAO::step(float dtime, bool send_recommended)
                }
        }
 
-       if (!m_attachment_sent){
+       if (!m_attachment_sent) {
                m_attachment_sent = true;
                std::string str = gob_cmd_update_attachment(m_attachment_parent_id,
                                m_attachment_bone, m_attachment_position, m_attachment_rotation);
@@ -1100,7 +1161,11 @@ void PlayerSAO::setBasePosition(const v3f &position)
 
        // This needs to be ran for attachments too
        ServerActiveObject::setBasePosition(position);
-       m_position_not_sent = true;
+
+       // Updating is not wanted/required for player migration
+       if (m_env) {
+               m_position_not_sent = true;
+       }
 }
 
 void PlayerSAO::setPos(const v3f &pos)
@@ -1111,6 +1176,8 @@ void PlayerSAO::setPos(const v3f &pos)
        setBasePosition(pos);
        // Movement caused by this command is always valid
        m_last_good_position = pos;
+       m_move_pool.empty();
+       m_time_from_last_teleport = 0.0;
        m_env->getGameDef()->SendMovePlayer(m_peer_id);
 }
 
@@ -1122,6 +1189,8 @@ void PlayerSAO::moveTo(v3f pos, bool continuous)
        setBasePosition(pos);
        // Movement caused by this command is always valid
        m_last_good_position = pos;
+       m_move_pool.empty();
+       m_time_from_last_teleport = 0.0;
        m_env->getGameDef()->SendMovePlayer(m_peer_id);
 }
 
@@ -1174,15 +1243,11 @@ int PlayerSAO::punch(v3f dir,
        ServerActiveObject *puncher,
        float time_from_last_punch)
 {
-       // It's best that attachments cannot be punched
-       if (isAttached())
-               return 0;
-
        if (!toolcap)
                return 0;
 
        // No effect if PvP disabled
-       if (g_settings->getBool("enable_pvp") == false) {
+       if (!g_settings->getBool("enable_pvp")) {
                if (puncher->getType() == ACTIVEOBJECT_TYPE_PLAYER) {
                        std::string str = gob_cmd_punched(0, getHP());
                        // create message and add to list
@@ -1207,7 +1272,8 @@ int PlayerSAO::punch(v3f dir,
                                hitparams.hp);
 
        if (!damage_handled) {
-               setHP(getHP() - hitparams.hp);
+               setHP(getHP() - hitparams.hp,
+                               PlayerHPChangeReason(PlayerHPChangeReason::PLAYER_PUNCH, puncher));
        } else { // override client prediction
                if (puncher->getType() == ACTIVEOBJECT_TYPE_PLAYER) {
                        std::string str = gob_cmd_punched(0, getHP());
@@ -1237,19 +1303,19 @@ s16 PlayerSAO::readDamage()
        return damage;
 }
 
-void PlayerSAO::setHP(s16 hp)
+void PlayerSAO::setHP(s16 hp, const PlayerHPChangeReason &reason)
 {
        s16 oldhp = m_hp;
 
-       s16 hp_change = m_env->getScriptIface()->on_player_hpchange(this, hp - oldhp);
+       s16 hp_change = m_env->getScriptIface()->on_player_hpchange(this, hp - oldhp, reason);
        if (hp_change == 0)
                return;
        hp = oldhp + hp_change;
 
        if (hp < 0)
                hp = 0;
-       else if (hp > PLAYER_MAX_HP)
-               hp = PLAYER_MAX_HP;
+       else if (hp > m_prop.hp_max)
+               hp = m_prop.hp_max;
 
        if (hp < oldhp && !g_settings->getBool("enable_damage")) {
                return;
@@ -1270,7 +1336,7 @@ void PlayerSAO::setBreath(const u16 breath, bool send)
        if (m_player && breath != m_breath)
                m_player->setDirty(true);
 
-       m_breath = MYMIN(breath, PLAYER_MAX_BREATH);
+       m_breath = MYMIN(breath, m_prop.breath_max);
 
        if (send)
                m_env->getGameDef()->SendPlayerBreath(this);
@@ -1298,6 +1364,16 @@ std::string PlayerSAO::getWieldList() const
 }
 
 ItemStack PlayerSAO::getWieldedItem() const
+{
+       const Inventory *inv = getInventory();
+       ItemStack ret;
+       const InventoryList *mlist = inv->getList(getWieldList());
+       if (mlist && getWieldIndex() < (s32)mlist->getSize())
+               ret = mlist->getItem(getWieldIndex());
+       return ret;
+}
+
+ItemStack PlayerSAO::getWieldedItemOrHand() const
 {
        const Inventory *inv = getInventory();
        ItemStack ret;
@@ -1318,14 +1394,6 @@ bool PlayerSAO::setWieldedItem(const ItemStack &item)
        if (inv) {
                InventoryList *mlist = inv->getList(getWieldList());
                if (mlist) {
-                       ItemStack olditem = mlist->getItem(getWieldIndex());
-                       if (olditem.name.empty()) {
-                               InventoryList *hlist = inv->getList("hand");
-                               if (hlist) {
-                                       hlist->changeItem(0, item);
-                                       return true;
-                               }
-                       }
                        mlist->changeItem(getWieldIndex(), item);
                        return true;
                }
@@ -1345,17 +1413,16 @@ void PlayerSAO::setWieldIndex(int i)
        }
 }
 
-// Erase the peer id and make the object for removal
 void PlayerSAO::disconnected()
 {
        m_peer_id = 0;
-       m_removed = true;
+       m_pending_removal = true;
 }
 
 void PlayerSAO::unlinkPlayerSessionAndSave()
 {
        assert(m_player->getPlayerSAO() == this);
-       m_player->peer_id = 0;
+       m_player->setPeerId(PEER_ID_INEXISTENT);
        m_env->savePlayer(m_player);
        m_player->setPlayerSAO(NULL);
        m_env->removePlayer(m_player);
@@ -1386,43 +1453,80 @@ bool PlayerSAO::checkMovementCheat()
                too, and much more lightweight.
        */
 
-       float player_max_speed = 0;
+       float player_max_walk = 0; // horizontal movement
+       float player_max_jump = 0; // vertical upwards movement
 
-       if (m_privs.count("fast") != 0) {
-               // Fast speed
-               player_max_speed = m_player->movement_speed_fast * m_physics_override_speed;
-       } else {
-               // Normal speed
-               player_max_speed = m_player->movement_speed_walk * m_physics_override_speed;
-       }
-       // Tolerance. The lag pool does this a bit.
-       //player_max_speed *= 2.5;
+       if (m_privs.count("fast") != 0)
+               player_max_walk = m_player->movement_speed_fast; // Fast speed
+       else
+               player_max_walk = m_player->movement_speed_walk; // Normal speed
+       player_max_walk *= m_physics_override_speed;
+       player_max_jump = m_player->movement_speed_jump * m_physics_override_jump;
+       // FIXME: Bouncy nodes cause practically unbound increase in Y speed,
+       //        until this can be verified correctly, tolerate higher jumping speeds
+       player_max_jump *= 2.0;
+
+       // Don't divide by zero!
+       if (player_max_walk < 0.0001f)
+               player_max_walk = 0.0001f;
+       if (player_max_jump < 0.0001f)
+               player_max_jump = 0.0001f;
 
        v3f diff = (m_base_position - m_last_good_position);
        float d_vert = diff.Y;
        diff.Y = 0;
        float d_horiz = diff.getLength();
-       float required_time = d_horiz / player_max_speed;
-
-       if (d_vert > 0 && d_vert / player_max_speed > required_time)
-               required_time = d_vert / player_max_speed; // Moving upwards
+       float required_time = d_horiz / player_max_walk;
+
+       // FIXME: Checking downwards movement is not easily possible currently,
+       //        the server could calculate speed differences to examine the gravity
+       if (d_vert > 0) {
+               // In certain cases (water, ladders) walking speed is applied vertically
+               float s = MYMAX(player_max_jump, player_max_walk);
+               required_time = MYMAX(required_time, d_vert / s);
+       }
 
        if (m_move_pool.grab(required_time)) {
                m_last_good_position = m_base_position;
        } else {
-               actionstream << "Player " << m_player->getName()
-                               << " moved too fast; resetting position"
-                               << std::endl;
+               const float LAG_POOL_MIN = 5.0;
+               float lag_pool_max = m_env->getMaxLagEstimate() * 2.0;
+               lag_pool_max = MYMAX(lag_pool_max, LAG_POOL_MIN);
+               if (m_time_from_last_teleport > lag_pool_max) {
+                       actionstream << "Player " << m_player->getName()
+                                       << " moved too fast; resetting position"
+                                       << std::endl;
+                       cheated = true;
+               }
                setBasePosition(m_last_good_position);
-               cheated = true;
        }
        return cheated;
 }
 
 bool PlayerSAO::getCollisionBox(aabb3f *toset) const
 {
-       *toset = aabb3f(-BS * 0.30, 0.0, -BS * 0.30, BS * 0.30, BS * 1.75, BS * 0.30);
+       //update collision box
+       toset->MinEdge = m_prop.collisionbox.MinEdge * BS;
+       toset->MaxEdge = m_prop.collisionbox.MaxEdge * BS;
+
        toset->MinEdge += m_base_position;
        toset->MaxEdge += m_base_position;
        return true;
 }
+
+bool PlayerSAO::getSelectionBox(aabb3f *toset) const
+{
+       if (!m_prop.is_visible || !m_prop.pointable) {
+               return false;
+       }
+
+       toset->MinEdge = m_prop.selectionbox.MinEdge * BS;
+       toset->MaxEdge = m_prop.selectionbox.MaxEdge * BS;
+
+       return true;
+}
+
+float PlayerSAO::getZoomFOV() const
+{
+       return m_prop.zoom_fov;
+}