]> git.lizzy.rs Git - minetest.git/blobdiff - src/content_cao.cpp
Optimize headers (part 2) (#6272)
[minetest.git] / src / content_cao.cpp
index a5376814955a232f89daf751552875fd31e61fd9..d87c905bcf5047684e59be08bbb6a74a2ad22eca 100644 (file)
@@ -22,17 +22,15 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include <IBillboardSceneNode.h>
 #include <IMeshManipulator.h>
 #include <IAnimatedMeshSceneNode.h>
-#include <IBoneSceneNode.h>
 #include "content_cao.h"
 #include "util/numeric.h" // For IntervalLimiter
 #include "util/serialize.h"
-#include "util/mathconstants.h"
+#include "util/basic_macros.h"
 #include "client/tile.h"
 #include "environment.h"
 #include "collision.h"
 #include "settings.h"
 #include "serialization.h" // For decompressZlib
-#include "gamedef.h"
 #include "clientobject.h"
 #include "mesh.h"
 #include "itemdef.h"
@@ -43,25 +41,15 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "localplayer.h"
 #include "map.h"
 #include "camera.h" // CameraModes
+#include "client.h"
 #include "wieldmesh.h"
-#include "log.h"
+#include <algorithm>
+#include "client/renderingengine.h"
 
 class Settings;
 struct ToolCapabilities;
 
-#define PP(x) "("<<(x).X<<","<<(x).Y<<","<<(x).Z<<")"
-
-UNORDERED_MAP<u16, ClientActiveObject::Factory> ClientActiveObject::m_types;
-
-SmoothTranslator::SmoothTranslator():
-       vect_old(0,0,0),
-       vect_show(0,0,0),
-       vect_aim(0,0,0),
-       anim_counter(0),
-       anim_time(0),
-       anim_time_counter(0),
-       aim_is_end(true)
-{}
+std::unordered_map<u16, ClientActiveObject::Factory> ClientActiveObject::m_types;
 
 void SmoothTranslator::init(v3f vect)
 {
@@ -74,11 +62,6 @@ void SmoothTranslator::init(v3f vect)
        aim_is_end = true;
 }
 
-void SmoothTranslator::sharpen()
-{
-       init(vect_show);
-}
-
 void SmoothTranslator::update(v3f vect_new, bool is_end_position, float update_interval)
 {
        aim_is_end = is_end_position;
@@ -115,11 +98,6 @@ void SmoothTranslator::translate(f32 dtime)
        vect_show = vect_old + vect_move * moveratio;
 }
 
-bool SmoothTranslator::is_moving()
-{
-       return ((anim_time_counter / anim_time) < 1.4);
-}
-
 /*
        Other stuff
 */
@@ -140,18 +118,17 @@ static void setBillboardTextureMatrix(scene::IBillboardSceneNode *bill,
 class TestCAO : public ClientActiveObject
 {
 public:
-       TestCAO(IGameDef *gamedef, ClientEnvironment *env);
-       virtual ~TestCAO();
+       TestCAO(Client *client, ClientEnvironment *env);
+       virtual ~TestCAO() = default;
 
        ActiveObjectType getType() const
        {
                return ACTIVEOBJECT_TYPE_TEST;
        }
 
-       static ClientActiveObject* create(IGameDef *gamedef, ClientEnvironment *env);
+       static ClientActiveObject* create(Client *client, ClientEnvironment *env);
 
-       void addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
-                       IrrlichtDevice *irr);
+       void addToScene(ITextureSource *tsrc);
        void removeFromScene(bool permanent);
        void updateLight(u8 light_at_pos);
        v3s16 getLightPosition();
@@ -161,7 +138,7 @@ class TestCAO : public ClientActiveObject
 
        void processMessage(const std::string &data);
 
-       bool getCollisionBox(aabb3f *toset) { return false; }
+       bool getCollisionBox(aabb3f *toset) const { return false; }
 private:
        scene::IMeshSceneNode *m_node;
        v3f m_position;
@@ -170,25 +147,20 @@ class TestCAO : public ClientActiveObject
 // Prototype
 TestCAO proto_TestCAO(NULL, NULL);
 
-TestCAO::TestCAO(IGameDef *gamedef, ClientEnvironment *env):
-       ClientActiveObject(0, gamedef, env),
+TestCAO::TestCAO(Client *client, ClientEnvironment *env):
+       ClientActiveObject(0, client, env),
        m_node(NULL),
        m_position(v3f(0,10*BS,0))
 {
        ClientActiveObject::registerType(getType(), create);
 }
 
-TestCAO::~TestCAO()
-{
-}
-
-ClientActiveObject* TestCAO::create(IGameDef *gamedef, ClientEnvironment *env)
+ClientActiveObject* TestCAO::create(Client *client, ClientEnvironment *env)
 {
-       return new TestCAO(gamedef, env);
+       return new TestCAO(client, env);
 }
 
-void TestCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
-                       IrrlichtDevice *irr)
+void TestCAO::addToScene(ITextureSource *tsrc)
 {
        if(m_node != NULL)
                return;
@@ -217,14 +189,14 @@ void TestCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
        // Add to mesh
        mesh->addMeshBuffer(buf);
        buf->drop();
-       m_node = smgr->addMeshSceneNode(mesh, NULL);
+       m_node = RenderingEngine::get_scene_manager()->addMeshSceneNode(mesh, NULL);
        mesh->drop();
        updateNodePos();
 }
 
 void TestCAO::removeFromScene(bool permanent)
 {
-       if(m_node == NULL)
+       if (!m_node)
                return;
 
        m_node->remove();
@@ -242,7 +214,7 @@ v3s16 TestCAO::getLightPosition()
 
 void TestCAO::updateNodePos()
 {
-       if(m_node == NULL)
+       if (!m_node)
                return;
 
        m_node->setPosition(m_position);
@@ -284,18 +256,17 @@ void TestCAO::processMessage(const std::string &data)
 class ItemCAO : public ClientActiveObject
 {
 public:
-       ItemCAO(IGameDef *gamedef, ClientEnvironment *env);
-       virtual ~ItemCAO();
+       ItemCAO(Client *client, ClientEnvironment *env);
+       virtual ~ItemCAO() = default;
 
        ActiveObjectType getType() const
        {
                return ACTIVEOBJECT_TYPE_ITEM;
        }
 
-       static ClientActiveObject* create(IGameDef *gamedef, ClientEnvironment *env);
+       static ClientActiveObject* create(Client *client, ClientEnvironment *env);
 
-       void addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
-                       IrrlichtDevice *irr);
+       void addToScene(ITextureSource *tsrc);
        void removeFromScene(bool permanent);
        void updateLight(u8 light_at_pos);
        v3s16 getLightPosition();
@@ -309,15 +280,22 @@ class ItemCAO : public ClientActiveObject
 
        void initialize(const std::string &data);
 
-       aabb3f *getSelectionBox()
-               {return &m_selection_box;}
+
+       virtual bool getSelectionBox(aabb3f *toset) const
+       {
+               *toset = m_selection_box;
+               return true;
+       }
+
+
        v3f getPosition()
                {return m_position;}
-
+       inline float getYaw() const
+               {return 0;}
        std::string infoText()
                {return m_infotext;}
 
-       bool getCollisionBox(aabb3f *toset) { return false; }
+       bool getCollisionBox(aabb3f *toset) const { return false; }
 private:
        aabb3f m_selection_box;
        scene::IMeshSceneNode *m_node;
@@ -326,34 +304,27 @@ class ItemCAO : public ClientActiveObject
        std::string m_infotext;
 };
 
-#include "inventory.h"
-
 // Prototype
 ItemCAO proto_ItemCAO(NULL, NULL);
 
-ItemCAO::ItemCAO(IGameDef *gamedef, ClientEnvironment *env):
-       ClientActiveObject(0, gamedef, env),
+ItemCAO::ItemCAO(Client *client, ClientEnvironment *env):
+       ClientActiveObject(0, client, env),
        m_selection_box(-BS/3.,0.0,-BS/3., BS/3.,BS*2./3.,BS/3.),
        m_node(NULL),
        m_position(v3f(0,10*BS,0))
 {
-       if(!gamedef && !env)
+       if(!client && !env)
        {
                ClientActiveObject::registerType(getType(), create);
        }
 }
 
-ItemCAO::~ItemCAO()
+ClientActiveObject* ItemCAO::create(Client *client, ClientEnvironment *env)
 {
+       return new ItemCAO(client, env);
 }
 
-ClientActiveObject* ItemCAO::create(IGameDef *gamedef, ClientEnvironment *env)
-{
-       return new ItemCAO(gamedef, env);
-}
-
-void ItemCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
-                       IrrlichtDevice *irr)
+void ItemCAO::addToScene(ITextureSource *tsrc)
 {
        if(m_node != NULL)
                return;
@@ -387,7 +358,7 @@ void ItemCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
        // Add to mesh
        mesh->addMeshBuffer(buf);
        buf->drop();
-       m_node = smgr->addMeshSceneNode(mesh, NULL);
+       m_node = RenderingEngine::get_scene_manager()->addMeshSceneNode(mesh, NULL);
        mesh->drop();
        updateNodePos();
 
@@ -400,16 +371,16 @@ void ItemCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
 
 void ItemCAO::removeFromScene(bool permanent)
 {
-       if(m_node == NULL)
+       if (!m_node)
                return;
 
        m_node->remove();
-       m_node = NULL;
+       m_node = nullptr;
 }
 
 void ItemCAO::updateLight(u8 light_at_pos)
 {
-       if(m_node == NULL)
+       if (!m_node)
                return;
 
        u8 li = decode_light(light_at_pos);
@@ -424,7 +395,7 @@ v3s16 ItemCAO::getLightPosition()
 
 void ItemCAO::updateNodePos()
 {
-       if(m_node == NULL)
+       if (!m_node)
                return;
 
        m_node->setPosition(m_position);
@@ -433,7 +404,7 @@ void ItemCAO::updateNodePos()
 void ItemCAO::updateInfoText()
 {
        try{
-               IItemDefManager *idef = m_gamedef->idef();
+               IItemDefManager *idef = m_client->idef();
                ItemStack item;
                item.deSerialize(m_itemstring, idef);
                if(item.isKnown(idef))
@@ -451,17 +422,17 @@ void ItemCAO::updateInfoText()
 
 void ItemCAO::updateTexture()
 {
-       if(m_node == NULL)
+       if (!m_node)
                return;
 
        // Create an inventory item to see what is its image
        std::istringstream is(m_itemstring, std::ios_base::binary);
        video::ITexture *texture = NULL;
        try{
-               IItemDefManager *idef = m_gamedef->idef();
+               IItemDefManager *idef = m_client->idef();
                ItemStack item;
                item.deSerialize(is, idef);
-               texture = idef->getInventoryTexture(item.getDefinition(idef).name, m_gamedef);
+               texture = idef->getInventoryTexture(item.getDefinition(idef).name, m_client);
        }
        catch(SerializationError &e)
        {
@@ -538,57 +509,17 @@ void ItemCAO::initialize(const std::string &data)
 
 #include "genericobject.h"
 
-GenericCAO::GenericCAO(IGameDef *gamedef, ClientEnvironment *env):
-               ClientActiveObject(0, gamedef, env),
-               //
-               m_is_player(false),
-               m_is_local_player(false),
-               //
-               m_smgr(NULL),
-               m_irr(NULL),
-               m_gamedef(NULL),
-               m_selection_box(-BS/3.,-BS/3.,-BS/3., BS/3.,BS/3.,BS/3.),
-               m_meshnode(NULL),
-               m_animated_meshnode(NULL),
-               m_wield_meshnode(NULL),
-               m_spritenode(NULL),
-               m_nametag(NULL),
-               m_position(v3f(0,10*BS,0)),
-               m_velocity(v3f(0,0,0)),
-               m_acceleration(v3f(0,0,0)),
-               m_yaw(0),
-               m_hp(1),
-               m_tx_size(1,1),
-               m_tx_basepos(0,0),
-               m_initial_tx_basepos_set(false),
-               m_tx_select_horiz_by_yawpitch(false),
-               m_animation_range(v2s32(0,0)),
-               m_animation_speed(15),
-               m_animation_blend(0),
-               m_animation_loop(true),
-               m_bone_position(UNORDERED_MAP<std::string, core::vector2d<v3f> >()),
-               m_attachment_bone(""),
-               m_attachment_position(v3f(0,0,0)),
-               m_attachment_rotation(v3f(0,0,0)),
-               m_attached_to_local(false),
-               m_anim_frame(0),
-               m_anim_num_frames(1),
-               m_anim_framelength(0.2),
-               m_anim_timer(0),
-               m_reset_textures_timer(-1),
-               m_visuals_expired(false),
-               m_step_distance_counter(0),
-               m_last_light(255),
-               m_is_visible(false)
+GenericCAO::GenericCAO(Client *client, ClientEnvironment *env):
+               ClientActiveObject(0, client, env)
 {
-       if (gamedef == NULL) {
+       if (client == NULL) {
                ClientActiveObject::registerType(getType(), create);
        } else {
-               m_gamedef = gamedef;
+               m_client = client;
        }
 }
 
-bool GenericCAO::getCollisionBox(aabb3f *toset)
+bool GenericCAO::getCollisionBox(aabb3f *toset) const
 {
        if (m_prop.physical)
        {
@@ -605,7 +536,7 @@ bool GenericCAO::getCollisionBox(aabb3f *toset)
        return false;
 }
 
-bool GenericCAO::collideWithObjects()
+bool GenericCAO::collideWithObjects() const
 {
        return m_prop.collideWithObjects;
 }
@@ -613,74 +544,74 @@ bool GenericCAO::collideWithObjects()
 void GenericCAO::initialize(const std::string &data)
 {
        infostream<<"GenericCAO: Got init data"<<std::endl;
+       processInitData(data);
+
+       if (m_is_player) {
+               // Check if it's the current player
+               LocalPlayer *player = m_env->getLocalPlayer();
+               if (player && strcmp(player->getName(), m_name.c_str()) == 0) {
+                       m_is_local_player = true;
+                       m_is_visible = false;
+                       player->setCAO(this);
+               }
+               if (m_client->getProtoVersion() < 33)
+                       m_env->addPlayerName(m_name);
+       }
+}
+
+void GenericCAO::processInitData(const std::string &data)
+{
        std::istringstream is(data, std::ios::binary);
        int num_messages = 0;
        // version
        u8 version = readU8(is);
        // check version
-       if(version == 1) // In PROTOCOL_VERSION 14
-       {
+       if (version == 1) { // In PROTOCOL_VERSION 14
                m_name = deSerializeString(is);
                m_is_player = readU8(is);
-               m_id = readS16(is);
+               m_id = readU16(is);
                m_position = readV3F1000(is);
                m_yaw = readF1000(is);
                m_hp = readS16(is);
                num_messages = readU8(is);
-       }
-       else if(version == 0) // In PROTOCOL_VERSION 13
-       {
+       } else if (version == 0) { // In PROTOCOL_VERSION 13
                m_name = deSerializeString(is);
                m_is_player = readU8(is);
                m_position = readV3F1000(is);
                m_yaw = readF1000(is);
                m_hp = readS16(is);
                num_messages = readU8(is);
-       }
-       else
-       {
+       } else {
                errorstream<<"GenericCAO: Unsupported init data version"
                                <<std::endl;
                return;
        }
 
-       for(int i=0; i<num_messages; i++)
-       {
+       for (int i = 0; i < num_messages; i++) {
                std::string message = deSerializeLongString(is);
                processMessage(message);
        }
 
        pos_translator.init(m_position);
        updateNodePos();
-
-       if(m_is_player)
-       {
-               LocalPlayer *player = m_env->getPlayer(m_name.c_str());
-               if (player && player->isLocal()) {
-                       m_is_local_player = true;
-                       m_is_visible = false;
-                       LocalPlayer* localplayer = player;
-
-                       assert( localplayer != NULL );
-                       localplayer->setCAO(this);
-               }
-               m_env->addPlayerName(m_name.c_str());
-       }
 }
 
 GenericCAO::~GenericCAO()
 {
-       if (m_is_player) {
-               m_env->removePlayerName(m_name.c_str());
+       if (m_is_player && m_client->getProtoVersion() < 33) {
+               m_env->removePlayerName(m_name);
        }
        removeFromScene(true);
 }
 
-aabb3f *GenericCAO::getSelectionBox()
+bool GenericCAO::getSelectionBox(aabb3f *toset) const
 {
-       if(!m_prop.is_visible || !m_is_visible || m_is_local_player || getParent() != NULL)
-               return NULL;
-       return &m_selection_box;
+       if (!m_prop.is_visible || !m_is_visible || m_is_local_player
+                       || getParent() != NULL){
+               return false;
+       }
+       *toset = m_selection_box;
+       return true;
 }
 
 v3f GenericCAO::getPosition()
@@ -689,8 +620,8 @@ v3f GenericCAO::getPosition()
                scene::ISceneNode *node = getSceneNode();
                if (node)
                        return node->getAbsolutePosition();
-               else
-                       return m_position;
+
+               return m_position;
        }
        return pos_translator.vect_show;
 }
@@ -699,40 +630,31 @@ scene::ISceneNode* GenericCAO::getSceneNode()
 {
        if (m_meshnode) {
                return m_meshnode;
-       } else if (m_animated_meshnode) {
+       }
+
+       if (m_animated_meshnode) {
                return m_animated_meshnode;
-       } else if (m_wield_meshnode) {
+       }
+
+       if (m_wield_meshnode) {
                return m_wield_meshnode;
-       } else if (m_spritenode) {
+       }
+
+       if (m_spritenode) {
                return m_spritenode;
        }
        return NULL;
 }
 
-scene::IMeshSceneNode* GenericCAO::getMeshSceneNode()
-{
-       return m_meshnode;
-}
-
 scene::IAnimatedMeshSceneNode* GenericCAO::getAnimatedMeshSceneNode()
 {
        return m_animated_meshnode;
 }
 
-WieldMeshSceneNode* GenericCAO::getWieldMeshSceneNode()
-{
-       return m_wield_meshnode;
-}
-
-scene::IBillboardSceneNode* GenericCAO::getSpriteSceneNode()
-{
-       return m_spritenode;
-}
-
 void GenericCAO::setChildrenVisible(bool toset)
 {
-       for (std::vector<u16>::size_type i = 0; i < m_children.size(); i++) {
-               GenericCAO *obj = m_env->getGenericCAO(m_children[i]);
+       for (u16 cao_id : m_children) {
+               GenericCAO *obj = m_env->getGenericCAO(cao_id);
                if (obj) {
                        obj->setVisible(toset);
                }
@@ -744,7 +666,7 @@ void GenericCAO::setAttachments()
        updateAttachments();
 }
 
-ClientActiveObject* GenericCAO::getParent()
+ClientActiveObject* GenericCAO::getParent() const
 {
        ClientActiveObject *obj = NULL;
 
@@ -762,8 +684,7 @@ void GenericCAO::removeFromScene(bool permanent)
        // Should be true when removing the object permanently and false when refreshing (eg: updating visuals)
        if((m_env != NULL) && (permanent))
        {
-               for (std::vector<u16>::size_type i = 0; i < m_children.size(); i++) {
-                       u16 ci = m_children[i];
+               for (u16 ci : m_children) {
                        if (m_env->attachement_parent_ids[ci] == getId()) {
                                m_env->attachement_parent_ids[ci] = 0;
                        }
@@ -797,16 +718,14 @@ void GenericCAO::removeFromScene(bool permanent)
        }
 
        if (m_nametag) {
-               m_gamedef->getCamera()->removeNametag(m_nametag);
+               m_client->getCamera()->removeNametag(m_nametag);
                m_nametag = NULL;
        }
 }
 
-void GenericCAO::addToScene(scene::ISceneManager *smgr,
-               ITextureSource *tsrc, IrrlichtDevice *irr)
+void GenericCAO::addToScene(ITextureSource *tsrc)
 {
-       m_smgr = smgr;
-       m_irr = irr;
+       m_smgr = RenderingEngine::get_scene_manager();
 
        if (getSceneNode() != NULL) {
                return;
@@ -820,7 +739,7 @@ void GenericCAO::addToScene(scene::ISceneManager *smgr,
 
        if (m_prop.visual == "sprite") {
                infostream<<"GenericCAO::addToScene(): single_sprite"<<std::endl;
-               m_spritenode = smgr->addBillboardSceneNode(
+               m_spritenode = RenderingEngine::get_scene_manager()->addBillboardSceneNode(
                                NULL, v2f(1, 1), v3f(0,0,0), -1);
                m_spritenode->grab();
                m_spritenode->setMaterialTexture(0,
@@ -883,7 +802,7 @@ void GenericCAO::addToScene(scene::ISceneManager *smgr,
                        mesh->addMeshBuffer(buf);
                        buf->drop();
                }
-               m_meshnode = smgr->addMeshSceneNode(mesh, NULL);
+               m_meshnode = RenderingEngine::get_scene_manager()->addMeshSceneNode(mesh, NULL);
                m_meshnode->grab();
                mesh->drop();
                // Set it to use the materials of the meshbuffers directly.
@@ -893,7 +812,7 @@ void GenericCAO::addToScene(scene::ISceneManager *smgr,
        else if(m_prop.visual == "cube") {
                infostream<<"GenericCAO::addToScene(): cube"<<std::endl;
                scene::IMesh *mesh = createCubeMesh(v3f(BS,BS,BS));
-               m_meshnode = smgr->addMeshSceneNode(mesh, NULL);
+               m_meshnode = RenderingEngine::get_scene_manager()->addMeshSceneNode(mesh, NULL);
                m_meshnode->grab();
                mesh->drop();
 
@@ -910,10 +829,11 @@ void GenericCAO::addToScene(scene::ISceneManager *smgr,
        }
        else if(m_prop.visual == "mesh") {
                infostream<<"GenericCAO::addToScene(): mesh"<<std::endl;
-               scene::IAnimatedMesh *mesh = m_gamedef->getMesh(m_prop.mesh);
+               scene::IAnimatedMesh *mesh = m_client->getMesh(m_prop.mesh);
                if(mesh)
                {
-                       m_animated_meshnode = smgr->addAnimatedMeshSceneNode(mesh, NULL);
+                       m_animated_meshnode = RenderingEngine::get_scene_manager()->
+                               addAnimatedMeshSceneNode(mesh, NULL);
                        m_animated_meshnode->grab();
                        mesh->drop(); // The scene node took hold of it
                        m_animated_meshnode->animateJoints(); // Needed for some animations
@@ -935,36 +855,48 @@ void GenericCAO::addToScene(scene::ISceneManager *smgr,
                }
                else
                        errorstream<<"GenericCAO::addToScene(): Could not load mesh "<<m_prop.mesh<<std::endl;
-       }
-       else if(m_prop.visual == "wielditem") {
-               infostream<<"GenericCAO::addToScene(): wielditem"<<std::endl;
-               infostream<<"textures: "<<m_prop.textures.size()<<std::endl;
-               if(m_prop.textures.size() >= 1){
-                       infostream<<"textures[0]: "<<m_prop.textures[0]<<std::endl;
-                       IItemDefManager *idef = m_gamedef->idef();
-                       ItemStack item(m_prop.textures[0], 1, 0, "", idef);
-
-                       m_wield_meshnode = new WieldMeshSceneNode(
-                                       smgr->getRootSceneNode(), smgr, -1);
-                       m_wield_meshnode->setItem(item, m_gamedef);
-
-                       m_wield_meshnode->setScale(v3f(m_prop.visual_size.X/2,
-                                       m_prop.visual_size.Y/2,
-                                       m_prop.visual_size.X/2));
-                       u8 li = m_last_light;
-                       m_wield_meshnode->setColor(video::SColor(255,li,li,li));
+       } else if (m_prop.visual == "wielditem") {
+               ItemStack item;
+               infostream << "GenericCAO::addToScene(): wielditem" << std::endl;
+               if (m_prop.wield_item.empty()) {
+                       // Old format, only textures are specified.
+                       infostream << "textures: " << m_prop.textures.size() << std::endl;
+                       if (!m_prop.textures.empty()) {
+                               infostream << "textures[0]: " << m_prop.textures[0]
+                                       << std::endl;
+                               IItemDefManager *idef = m_client->idef();
+                               item = ItemStack(m_prop.textures[0], 1, 0, idef);
+                       }
+               } else {
+                       infostream << "serialized form: " << m_prop.wield_item << std::endl;
+                       item.deSerialize(m_prop.wield_item, m_client->idef());
                }
+               m_wield_meshnode = new WieldMeshSceneNode(
+                       RenderingEngine::get_scene_manager(), -1);
+               m_wield_meshnode->setItem(item, m_client);
+
+               m_wield_meshnode->setScale(
+                       v3f(m_prop.visual_size.X / 2, m_prop.visual_size.Y / 2,
+                               m_prop.visual_size.X / 2));
+               u8 li = m_last_light;
+               m_wield_meshnode->setColor(video::SColor(255, li, li, li));
        } else {
                infostream<<"GenericCAO::addToScene(): \""<<m_prop.visual
                                <<"\" not supported"<<std::endl;
        }
-       updateTextures("");
+
+       /* don't update while punch texture modifier is active */
+       if (m_reset_textures_timer < 0)
+               updateTextures(m_current_texture_modifier);
 
        scene::ISceneNode *node = getSceneNode();
-       if (node && m_prop.nametag != "" && !m_is_local_player) {
+       if (node && !m_prop.nametag.empty() && !m_is_local_player) {
                // Add nametag
-               m_nametag = m_gamedef->getCamera()->addNametag(node,
-                       m_prop.nametag, m_prop.nametag_color);
+               v3f pos;
+               pos.Y = m_prop.collisionbox.MaxEdge.Y + 0.3f;
+               m_nametag = m_client->getCamera()->addNametag(node,
+                       m_prop.nametag, m_prop.nametag_color,
+                       pos);
        }
 
        updateNodePos();
@@ -983,8 +915,8 @@ void GenericCAO::updateLight(u8 light_at_pos)
        updateLightNoCheck(light_at_pos);
 
        // Update light of all children
-       for (std::vector<u16>::size_type i = 0; i < m_children.size(); i++) {
-               ClientActiveObject *obj = m_env->getActiveObject(m_children[i]);
+       for (u16 i : m_children) {
+               ClientActiveObject *obj = m_env->getActiveObject(i);
                if (obj) {
                        obj->updateLightNoCheck(light_at_pos);
                }
@@ -1011,7 +943,7 @@ void GenericCAO::updateLightNoCheck(u8 light_at_pos)
 
 v3s16 GenericCAO::getLightPosition()
 {
-       return floatToInt(m_position, BS);
+       return floatToInt(m_position + v3f(0, 0.5 * BS, 0), BS);
 }
 
 void GenericCAO::updateNodePos()
@@ -1035,20 +967,17 @@ void GenericCAO::updateNodePos()
 void GenericCAO::step(float dtime, ClientEnvironment *env)
 {
        // Handel model of local player instantly to prevent lags
-       if(m_is_local_player)
-       {
+       if (m_is_local_player) {
                LocalPlayer *player = m_env->getLocalPlayer();
-
-               if (m_is_visible)
-               {
+               if (m_is_visible) {
                        int old_anim = player->last_animation;
                        float old_anim_speed = player->last_animation_speed;
-                       m_position = player->getPosition() + v3f(0,BS,0);
+                       m_position = player->getPosition();
                        m_velocity = v3f(0,0,0);
                        m_acceleration = v3f(0,0,0);
                        pos_translator.vect_show = m_position;
                        m_yaw = player->getYaw();
-                       PlayerControl controls = player->getPlayerControl();
+                       const PlayerControl &controls = player->getPlayerControl();
 
                        bool walking = false;
                        if (controls.up || controls.down || controls.left || controls.right ||
@@ -1062,18 +991,17 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
 
                        // increase speed if using fast or flying fast
                        if((g_settings->getBool("fast_move") &&
-                                       m_gamedef->checkLocalPrivilege("fast")) &&
+                                       m_client->checkLocalPrivilege("fast")) &&
                                        (controls.aux1 ||
                                        (!player->touching_ground &&
                                        g_settings->getBool("free_move") &&
-                                       m_gamedef->checkLocalPrivilege("fly"))))
+                                       m_client->checkLocalPrivilege("fly"))))
                                        new_speed *= 1.5;
                        // slowdown speed if sneeking
-                       if(controls.sneak && walking)
+                       if (controls.sneak && walking)
                                new_speed /= 2;
 
-                       if(walking && (controls.LMB || controls.RMB))
-                       {
+                       if (walking && (controls.LMB || controls.RMB)) {
                                new_anim = player->local_animations[3];
                                player->last_animation = WD_ANIM;
                        } else if(walking) {
@@ -1086,8 +1014,7 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
 
                        // Apply animations if input detected and not attached
                        // or set idle animation
-                       if ((new_anim.X + new_anim.Y) > 0 && !player->isAttached)
-                       {
+                       if ((new_anim.X + new_anim.Y) > 0 && !player->isAttached) {
                                allow_update = true;
                                m_animation_range = new_anim;
                                m_animation_speed = new_speed;
@@ -1095,8 +1022,7 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
                        } else {
                                player->last_animation = NO_ANIM;
 
-                               if (old_anim != NO_ANIM)
-                               {
+                               if (old_anim != NO_ANIM) {
                                        m_animation_range = player->local_animations[0];
                                        updateAnimation();
                                }
@@ -1111,14 +1037,12 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
                }
        }
 
-       if(m_visuals_expired && m_smgr && m_irr){
+       if (m_visuals_expired && m_smgr) {
                m_visuals_expired = false;
 
                // Attachments, part 1: All attached objects must be unparented first,
                // or Irrlicht causes a segmentation fault
-               for(std::vector<u16>::iterator ci = m_children.begin();
-                               ci != m_children.end();)
-               {
+               for (auto ci = m_children.begin(); ci != m_children.end();) {
                        if (m_env->attachement_parent_ids[*ci] != getId()) {
                                ci = m_children.erase(ci);
                                continue;
@@ -1133,12 +1057,12 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
                }
 
                removeFromScene(false);
-               addToScene(m_smgr, m_gamedef->tsrc(), m_irr);
+               addToScene(m_client->tsrc());
 
                // Attachments, part 2: Now that the parent has been refreshed, put its attachments back
-               for (std::vector<u16>::size_type i = 0; i < m_children.size(); i++) {
+               for (u16 cao_id : m_children) {
                        // Get the object of the child
-                       ClientActiveObject *obj = m_env->getActiveObject(m_children[i]);
+                       ClientActiveObject *obj = m_env->getActiveObject(cao_id);
                        if (obj)
                                obj->setAttachments();
                }
@@ -1203,12 +1127,12 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
                        m_step_distance_counter = 0;
                        if(!m_is_local_player && m_prop.makes_footstep_sound)
                        {
-                               INodeDefManager *ndef = m_gamedef->ndef();
+                               INodeDefManager *ndef = m_client->ndef();
                                v3s16 p = floatToInt(getPosition() + v3f(0,
                                                (m_prop.collisionbox.MinEdge.Y-0.5)*BS, 0), BS);
                                MapNode n = m_env->getMap().getNodeNoEx(p);
                                SimpleSoundSpec spec = ndef->get(n).sound_footstep;
-                               m_gamedef->sound()->playSoundAt(spec, false, getPosition());
+                               m_client->sound()->playSoundAt(spec, false, getPosition());
                        }
                }
        }
@@ -1227,18 +1151,18 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
        if(m_reset_textures_timer >= 0)
        {
                m_reset_textures_timer -= dtime;
-               if(m_reset_textures_timer <= 0){
+               if(m_reset_textures_timer <= 0) {
                        m_reset_textures_timer = -1;
-                       updateTextures("");
+                       updateTextures(m_previous_texture_modifier);
                }
        }
-       if(getParent() == NULL && fabs(m_prop.automatic_rotate) > 0.001)
+       if(!getParent() && fabs(m_prop.automatic_rotate) > 0.001)
        {
                m_yaw += dtime * m_prop.automatic_rotate * 180 / M_PI;
                updateNodePos();
        }
 
-       if (getParent() == NULL && m_prop.automatic_face_movement_dir &&
+       if (!getParent() && m_prop.automatic_face_movement_dir &&
                        (fabs(m_velocity.Z) > 0.001 || fabs(m_velocity.X) > 0.001))
        {
                float optimal_yaw = atan2(m_velocity.Z,m_velocity.X) * 180 / M_PI
@@ -1307,20 +1231,21 @@ void GenericCAO::updateTexturePos()
        }
 }
 
-void GenericCAO::updateTextures(const std::string &mod)
+void GenericCAO::updateTextures(std::string mod)
 {
-       ITextureSource *tsrc = m_gamedef->tsrc();
+       ITextureSource *tsrc = m_client->tsrc();
 
        bool use_trilinear_filter = g_settings->getBool("trilinear_filter");
        bool use_bilinear_filter = g_settings->getBool("bilinear_filter");
        bool use_anisotropic_filter = g_settings->getBool("anisotropic_filter");
 
-       if(m_spritenode)
-       {
-               if(m_prop.visual == "sprite")
-               {
+       m_previous_texture_modifier = m_current_texture_modifier;
+       m_current_texture_modifier = mod;
+
+       if (m_spritenode) {
+               if (m_prop.visual == "sprite") {
                        std::string texturestring = "unknown_node.png";
-                       if(m_prop.textures.size() >= 1)
+                       if (!m_prop.textures.empty())
                                texturestring = m_prop.textures[0];
                        texturestring += mod;
                        m_spritenode->setMaterialTexture(0,
@@ -1329,8 +1254,7 @@ void GenericCAO::updateTextures(const std::string &mod)
                        // This allows setting per-material colors. However, until a real lighting
                        // system is added, the code below will have no effect. Once MineTest
                        // has directional lighting, it should work automatically.
-                       if(m_prop.colors.size() >= 1)
-                       {
+                       if (!m_prop.colors.empty()) {
                                m_spritenode->getMaterial(0).AmbientColor = m_prop.colors[0];
                                m_spritenode->getMaterial(0).DiffuseColor = m_prop.colors[0];
                                m_spritenode->getMaterial(0).SpecularColor = m_prop.colors[0];
@@ -1341,20 +1265,17 @@ void GenericCAO::updateTextures(const std::string &mod)
                        m_spritenode->getMaterial(0).setFlag(video::EMF_ANISOTROPIC_FILTER, use_anisotropic_filter);
                }
        }
-       if(m_animated_meshnode)
-       {
-               if(m_prop.visual == "mesh")
-               {
+
+       if (m_animated_meshnode) {
+               if (m_prop.visual == "mesh") {
                        for (u32 i = 0; i < m_prop.textures.size() &&
-                                       i < m_animated_meshnode->getMaterialCount(); ++i)
-                       {
+                                       i < m_animated_meshnode->getMaterialCount(); ++i) {
                                std::string texturestring = m_prop.textures[i];
-                               if(texturestring == "")
+                               if (texturestring.empty())
                                        continue; // Empty texture string means don't modify that material
                                texturestring += mod;
                                video::ITexture* texture = tsrc->getTextureForMesh(texturestring);
-                               if(!texture)
-                               {
+                               if (!texture) {
                                        errorstream<<"GenericCAO::updateTextures(): Could not load texture "<<texturestring<<std::endl;
                                        continue;
                                }
@@ -1418,13 +1339,11 @@ void GenericCAO::updateTextures(const std::string &mod)
                                m_meshnode->getMaterial(i).setFlag(video::EMF_BILINEAR_FILTER, use_bilinear_filter);
                                m_meshnode->getMaterial(i).setFlag(video::EMF_ANISOTROPIC_FILTER, use_anisotropic_filter);
                        }
-               }
-               else if(m_prop.visual == "upright_sprite")
-               {
+               } else if (m_prop.visual == "upright_sprite") {
                        scene::IMesh *mesh = m_meshnode->getMesh();
                        {
                                std::string tname = "unknown_object.png";
-                               if(m_prop.textures.size() >= 1)
+                               if (!m_prop.textures.empty())
                                        tname = m_prop.textures[0];
                                tname += mod;
                                scene::IMeshBuffer *buf = mesh->getMeshBuffer(0);
@@ -1434,8 +1353,7 @@ void GenericCAO::updateTextures(const std::string &mod)
                                // This allows setting per-material colors. However, until a real lighting
                                // system is added, the code below will have no effect. Once MineTest
                                // has directional lighting, it should work automatically.
-                               if(m_prop.colors.size() >= 1)
-                               {
+                               if(!m_prop.colors.empty()) {
                                        buf->getMaterial().AmbientColor = m_prop.colors[0];
                                        buf->getMaterial().DiffuseColor = m_prop.colors[0];
                                        buf->getMaterial().SpecularColor = m_prop.colors[0];
@@ -1447,9 +1365,9 @@ void GenericCAO::updateTextures(const std::string &mod)
                        }
                        {
                                std::string tname = "unknown_object.png";
-                               if(m_prop.textures.size() >= 2)
+                               if (m_prop.textures.size() >= 2)
                                        tname = m_prop.textures[1];
-                               else if(m_prop.textures.size() >= 1)
+                               else if (!m_prop.textures.empty())
                                        tname = m_prop.textures[0];
                                tname += mod;
                                scene::IMeshBuffer *buf = mesh->getMeshBuffer(1);
@@ -1459,14 +1377,11 @@ void GenericCAO::updateTextures(const std::string &mod)
                                // This allows setting per-material colors. However, until a real lighting
                                // system is added, the code below will have no effect. Once MineTest
                                // has directional lighting, it should work automatically.
-                               if(m_prop.colors.size() >= 2)
-                               {
+                               if (m_prop.colors.size() >= 2) {
                                        buf->getMaterial().AmbientColor = m_prop.colors[1];
                                        buf->getMaterial().DiffuseColor = m_prop.colors[1];
                                        buf->getMaterial().SpecularColor = m_prop.colors[1];
-                               }
-                               else if(m_prop.colors.size() >= 1)
-                               {
+                               } else if (!m_prop.colors.empty()) {
                                        buf->getMaterial().AmbientColor = m_prop.colors[0];
                                        buf->getMaterial().DiffuseColor = m_prop.colors[0];
                                        buf->getMaterial().SpecularColor = m_prop.colors[0];
@@ -1482,7 +1397,7 @@ void GenericCAO::updateTextures(const std::string &mod)
 
 void GenericCAO::updateAnimation()
 {
-       if(m_animated_meshnode == NULL)
+       if (!m_animated_meshnode)
                return;
 
        if (m_animated_meshnode->getStartFrame() != m_animation_range.X ||
@@ -1500,11 +1415,11 @@ void GenericCAO::updateAnimation()
 
 void GenericCAO::updateBonePosition()
 {
-       if(m_bone_position.empty() || m_animated_meshnode == NULL)
+       if(m_bone_position.empty() || !m_animated_meshnode)
                return;
 
        m_animated_meshnode->setJointMode(irr::scene::EJUOR_CONTROL); // To write positions to the mesh on render
-       for(UNORDERED_MAP<std::string, core::vector2d<v3f> >::const_iterator
+       for(std::unordered_map<std::string, core::vector2d<v3f>>::const_iterator
                        ii = m_bone_position.begin(); ii != m_bone_position.end(); ++ii) {
                std::string bone_name = (*ii).first;
                v3f bone_pos = (*ii).second.X;
@@ -1521,7 +1436,7 @@ void GenericCAO::updateBonePosition()
 void GenericCAO::updateAttachments()
 {
 
-       if (getParent() == NULL) { // Detach or don't attach
+       if (!getParent()) { // Detach or don't attach
                scene::ISceneNode *node = getSceneNode();
                if (node) {
                        v3f old_position = node->getAbsolutePosition();
@@ -1543,7 +1458,7 @@ void GenericCAO::updateAttachments()
                scene::ISceneNode *parent_node = getParent()->getSceneNode();
                scene::IAnimatedMeshSceneNode *parent_animated_mesh_node =
                                getParent()->getAnimatedMeshSceneNode();
-               if (parent_animated_mesh_node && m_attachment_bone != "") {
+               if (parent_animated_mesh_node && !m_attachment_bone.empty()) {
                        parent_node = parent_animated_mesh_node->getJointNode(m_attachment_bone.c_str());
                }
 
@@ -1580,8 +1495,13 @@ void GenericCAO::processMessage(const std::string &data)
                        m_initial_tx_basepos_set = true;
                        m_tx_basepos = m_prop.initial_sprite_basepos;
                }
+               if (m_is_local_player) {
+                       LocalPlayer *player = m_env->getLocalPlayer();
+                       player->makes_footstep_sound = m_prop.makes_footstep_sound;
+                       player->setCollisionbox(m_selection_box);
+               }
 
-               if ((m_is_player && !m_is_local_player) && m_prop.nametag == "")
+               if ((m_is_player && !m_is_local_player) && m_prop.nametag.empty())
                        m_prop.nametag = m_name;
 
                expireVisuals();
@@ -1617,6 +1537,12 @@ void GenericCAO::processMessage(const std::string &data)
                updateNodePos();
        } else if (cmd == GENERIC_CMD_SET_TEXTURE_MOD) {
                std::string mod = deSerializeString(is);
+
+               // immediatly reset a engine issued texture modifier if a mod sends a different one
+               if (m_reset_textures_timer > 0) {
+                       m_reset_textures_timer = -1;
+                       updateTextures(m_previous_texture_modifier);
+               }
                updateTextures(mod);
        } else if (cmd == GENERIC_CMD_SET_SPRITE) {
                v2s16 p = readV2S16(is);
@@ -1637,6 +1563,7 @@ void GenericCAO::processMessage(const std::string &data)
                // these are sent inverted so we get true when the server sends nothing
                bool sneak = !readU8(is);
                bool sneak_glitch = !readU8(is);
+               bool new_move = !readU8(is);
 
 
                if(m_is_local_player)
@@ -1647,6 +1574,7 @@ void GenericCAO::processMessage(const std::string &data)
                        player->physics_override_gravity = override_gravity;
                        player->physics_override_sneak = sneak;
                        player->physics_override_sneak_glitch = sneak_glitch;
+                       player->physics_override_new_move = new_move;
                }
        } else if (cmd == GENERIC_CMD_SET_ANIMATION) {
                // TODO: change frames send as v2s32 value
@@ -1734,13 +1662,13 @@ void GenericCAO::processMessage(const std::string &data)
                                                m_smgr, m_env, m_position,
                                                m_prop.visual_size * BS);
                                m_env->addSimpleObject(simple);
-                       } else {
+                       } else if (m_reset_textures_timer < 0) {
                                // TODO: Execute defined fast response
                                // Flashing shall suffice as there is no definition
                                m_reset_textures_timer = 0.05;
                                if(damage >= 2)
                                        m_reset_textures_timer += 0.05 * damage;
-                               updateTextures("^[brighten");
+                               updateTextures(m_current_texture_modifier + "^[brighten");
                        }
                }
        } else if (cmd == GENERIC_CMD_UPDATE_ARMOR_GROUPS) {
@@ -1758,20 +1686,23 @@ void GenericCAO::processMessage(const std::string &data)
                m_prop.nametag_color = readARGB8(is);
                if (m_nametag != NULL) {
                        m_nametag->nametag_color = m_prop.nametag_color;
+                       v3f pos;
+                       pos.Y = m_prop.collisionbox.MaxEdge.Y + 0.3f;
+                       m_nametag->nametag_pos = pos;
                }
        } else if (cmd == GENERIC_CMD_SPAWN_INFANT) {
                u16 child_id = readU16(is);
                u8 type = readU8(is);
 
                if (GenericCAO *childobj = m_env->getGenericCAO(child_id)) {
-                       childobj->initialize(deSerializeLongString(is));
+                       childobj->processInitData(deSerializeLongString(is));
                } else {
                        m_env->addActiveObject(child_id, type, deSerializeLongString(is));
                }
        } else {
                warningstream << FUNCTION_NAME
                        << ": unknown command or outdated client \""
-                       << cmd << std::endl;
+                       << +cmd << "\"" << std::endl;
        }
 }
 
@@ -1782,7 +1713,7 @@ bool GenericCAO::directReportPunch(v3f dir, const ItemStack *punchitem,
 {
        assert(punchitem);      // pre-condition
        const ToolCapabilities *toolcap =
-                       &punchitem->getToolCapabilities(m_gamedef->idef());
+                       &punchitem->getToolCapabilities(m_client->idef());
        PunchDamageResult result = getPunchDamage(
                        m_armor_groups,
                        toolcap,
@@ -1805,10 +1736,12 @@ bool GenericCAO::directReportPunch(v3f dir, const ItemStack *punchitem,
                }
                // TODO: Execute defined fast response
                // Flashing shall suffice as there is no definition
-               m_reset_textures_timer = 0.05;
-               if(result.damage >= 2)
-                       m_reset_textures_timer += 0.05 * result.damage;
-               updateTextures("^[brighten");
+               if (m_reset_textures_timer < 0) {
+                       m_reset_textures_timer = 0.05;
+                       if (result.damage >= 2)
+                               m_reset_textures_timer += 0.05 * result.damage;
+                       updateTextures(m_current_texture_modifier + "^[brighten");
+               }
        }
 
        return false;