]> git.lizzy.rs Git - minetest.git/blobdiff - src/clientiface.cpp
dofile error reporting for syntax errors
[minetest.git] / src / clientiface.cpp
index 2841b212f95877cd02133d84b9f6cf4b18004ba2..6944e56db756c63e754795d2cf391cdc5d9dbb9d 100644 (file)
@@ -20,19 +20,18 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include <sstream>
 
 #include "clientiface.h"
+#include "util/numeric.h"
+#include "util/mathconstants.h"
 #include "player.h"
 #include "settings.h"
 #include "mapblock.h"
-#include "connection.h"
+#include "network/connection.h"
 #include "environment.h"
 #include "map.h"
 #include "emerge.h"
 #include "serverobject.h"              // TODO this is used for cleanup of only
-
-#include "util/numeric.h"
-#include "util/mathconstants.h"
-
-#include "main.h"                      // for g_settings
+#include "log.h"
+#include "util/srp.h"
 
 const char *ClientInterface::statenames[] = {
        "Invalid",
@@ -52,8 +51,15 @@ std::string ClientInterface::state2Name(ClientState state)
        return statenames[state];
 }
 
+void RemoteClient::ResendBlockIfOnWire(v3s16 p)
+{
+       // if this block is on wire, mark it for sending again as soon as possible
+       if (m_blocks_sending.find(p) != m_blocks_sending.end()) {
+               SetBlockNotSent(p);
+       }
+}
 
-void RemoteClient::GetNextBlocks(
+void RemoteClient::GetNextBlocks (
                ServerEnvironment *env,
                EmergeManager * emerge,
                float dtime,
@@ -173,21 +179,18 @@ void RemoteClient::GetNextBlocks(
        s32 nearest_emerged_d = -1;
        s32 nearest_emergefull_d = -1;
        s32 nearest_sent_d = -1;
-       bool queue_is_full = false;
+       //bool queue_is_full = false;
 
        s16 d;
-       for(d = d_start; d <= d_max; d++)
-       {
+       for(d = d_start; d <= d_max; d++) {
                /*
                        Get the border/face dot coordinates of a "d-radiused"
                        box
                */
-               std::list<v3s16> list;
-               getFacePositions(list, d);
+               std::vector<v3s16> list = FacePositionCache::getFacePositions(d);
 
-               std::list<v3s16>::iterator li;
-               for(li=list.begin(); li!=list.end(); ++li)
-               {
+               std::vector<v3s16>::iterator li;
+               for(li = list.begin(); li != list.end(); ++li) {
                        v3s16 p = *li + center;
 
                        /*
@@ -208,7 +211,7 @@ void RemoteClient::GetNextBlocks(
                        // Don't select too many blocks for sending
                        if(num_blocks_selected >= max_simul_dynamic)
                        {
-                               queue_is_full = true;
+                               //queue_is_full = true;
                                goto queue_full_break;
                        }
 
@@ -425,10 +428,12 @@ void RemoteClient::notifyEvent(ClientStateEvent event)
                //intentionally do nothing
                break;
        case CS_Created:
-               switch(event)
-               {
-               case CSE_Init:
-                       m_state = CS_InitSent;
+               switch (event) {
+               case CSE_Hello:
+                       m_state = CS_HelloSent;
+                       break;
+               case CSE_InitLegacy:
+                       m_state = CS_AwaitingInit2;
                        break;
                case CSE_Disconnect:
                        m_state = CS_Disconnecting;
@@ -445,7 +450,32 @@ void RemoteClient::notifyEvent(ClientStateEvent event)
        case CS_Denied:
                /* don't do anything if in denied state */
                break;
-       case CS_InitSent:
+       case CS_HelloSent:
+               switch(event)
+               {
+               case CSE_AuthAccept:
+                       m_state = CS_AwaitingInit2;
+                       if ((chosen_mech == AUTH_MECHANISM_SRP)
+                                       || (chosen_mech == AUTH_MECHANISM_LEGACY_PASSWORD))
+                               srp_verifier_delete((SRPVerifier *) auth_data);
+                       chosen_mech = AUTH_MECHANISM_NONE;
+                       break;
+               case CSE_Disconnect:
+                       m_state = CS_Disconnecting;
+                       break;
+               case CSE_SetDenied:
+                       m_state = CS_Denied;
+                       if ((chosen_mech == AUTH_MECHANISM_SRP)
+                                       || (chosen_mech == AUTH_MECHANISM_LEGACY_PASSWORD))
+                               srp_verifier_delete((SRPVerifier *) auth_data);
+                       chosen_mech = AUTH_MECHANISM_NONE;
+                       break;
+               default:
+                       myerror << "HelloSent: Invalid client state transition! " << event;
+                       throw ClientStateError(myerror.str());
+               }
+               break;
+       case CS_AwaitingInit2:
                switch(event)
                {
                case CSE_GotInit2:
@@ -512,6 +542,13 @@ void RemoteClient::notifyEvent(ClientStateEvent event)
                case CSE_Disconnect:
                        m_state = CS_Disconnecting;
                        break;
+               case CSE_SudoSuccess:
+                       m_state = CS_SudoMode;
+                       if ((chosen_mech == AUTH_MECHANISM_SRP)
+                                       || (chosen_mech == AUTH_MECHANISM_LEGACY_PASSWORD))
+                               srp_verifier_delete((SRPVerifier *) auth_data);
+                       chosen_mech = AUTH_MECHANISM_NONE;
+                       break;
                /* Init GotInit2 SetDefinitionsSent SetMediaSent SetDenied */
                default:
                        myerror << "Active: Invalid client state transition! " << event;
@@ -519,6 +556,24 @@ void RemoteClient::notifyEvent(ClientStateEvent event)
                        break;
                }
                break;
+       case CS_SudoMode:
+               switch(event)
+               {
+               case CSE_SetDenied:
+                       m_state = CS_Denied;
+                       break;
+               case CSE_Disconnect:
+                       m_state = CS_Disconnecting;
+                       break;
+               case CSE_SudoLeave:
+                       m_state = CS_Active;
+                       break;
+               default:
+                       myerror << "Active: Invalid client state transition! " << event;
+                       throw ClientStateError(myerror.str());
+                       break;
+               }
+               break;
        case CS_Disconnecting:
                /* we are already disconnecting */
                break;
@@ -557,9 +612,9 @@ ClientInterface::~ClientInterface()
        }
 }
 
-std::list<u16> ClientInterface::getClientIDs(ClientState min_state)
+std::vector<u16> ClientInterface::getClientIDs(ClientState min_state)
 {
-       std::list<u16> reply;
+       std::vector<u16> reply;
        JMutexAutoLock clientslock(m_clients_mutex);
 
        for(std::map<u16, RemoteClient*>::iterator
@@ -593,20 +648,22 @@ void ClientInterface::UpdatePlayerList()
 {
        if (m_env != NULL)
                {
-               std::list<u16> clients = getClientIDs();
+               std::vector<u16> clients = getClientIDs();
                m_clients_names.clear();
 
 
-               if(clients.size() != 0)
+               if(!clients.empty())
                        infostream<<"Players:"<<std::endl;
-               for(std::list<u16>::iterator
+
+               for(std::vector<u16>::iterator
                        i = clients.begin();
-                       i != clients.end(); ++i)
-               {
+                       i != clients.end(); ++i) {
                        Player *player = m_env->getPlayer(*i);
-                       if(player==NULL)
+
+                       if (player == NULL)
                                continue;
-                       infostream<<"* "<<player->getName()<<"\t";
+
+                       infostream << "* " << player->getName() << "\t";
 
                        {
                                JMutexAutoLock clientslock(m_clients_mutex);
@@ -614,30 +671,29 @@ void ClientInterface::UpdatePlayerList()
                                if(client != NULL)
                                        client->PrintInfo(infostream);
                        }
+
                        m_clients_names.push_back(player->getName());
                }
        }
 }
 
-void ClientInterface::send(u16 peer_id,u8 channelnum,
-               SharedBuffer<u8> data, bool reliable)
+void ClientInterface::send(u16 peer_id, u8 channelnum,
+               NetworkPacket* pkt, bool reliable)
 {
-       m_con->Send(peer_id, channelnum, data, reliable);
+       m_con->Send(peer_id, channelnum, pkt, reliable);
 }
 
 void ClientInterface::sendToAll(u16 channelnum,
-               SharedBuffer<u8> data, bool reliable)
+               NetworkPacket* pkt, bool reliable)
 {
        JMutexAutoLock clientslock(m_clients_mutex);
        for(std::map<u16, RemoteClient*>::iterator
                i = m_clients.begin();
-               i != m_clients.end(); ++i)
-       {
+               i != m_clients.end(); ++i) {
                RemoteClient *client = i->second;
 
-               if (client->net_proto_version != 0)
-               {
-                       m_con->Send(client->peer_id, channelnum, data, reliable);
+               if (client->net_proto_version != 0) {
+                       m_con->Send(client->peer_id, channelnum, pkt, reliable);
                }
        }
 }