]> git.lizzy.rs Git - minetest.git/blobdiff - src/client.cpp
Fix naming conventions of noise userdata
[minetest.git] / src / client.cpp
index 3269c573a638666be7565d62595eab212e519049..e6af5c324589e3052004a42a836cb5191cfc1fa7 100644 (file)
@@ -22,31 +22,40 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include <sstream>
 #include <cmath>
 #include <IFileSystem.h>
+#include "client.h"
+#include "network/clientopcodes.h"
+#include "network/connection.h"
+#include "network/networkpacket.h"
 #include "threading/mutex_auto_lock.h"
+#include "client/clientevent.h"
+#include "client/gameui.h"
+#include "client/renderingengine.h"
+#include "client/tile.h"
 #include "util/auth.h"
 #include "util/directiontables.h"
 #include "util/pointedthing.h"
 #include "util/serialize.h"
 #include "util/string.h"
 #include "util/srp.h"
-#include "client.h"
-#include "network/clientopcodes.h"
 #include "filesys.h"
 #include "mapblock_mesh.h"
 #include "mapblock.h"
 #include "minimap.h"
+#include "modchannels.h"
 #include "mods.h"
 #include "profiler.h"
+#include "shader.h"
 #include "gettext.h"
 #include "clientmap.h"
 #include "clientmedia.h"
 #include "version.h"
-#include "drawscene.h"
-#include "database-sqlite3.h"
+#include "database/database-sqlite3.h"
 #include "serialization.h"
 #include "guiscalingfilter.h"
 #include "script/scripting_client.h"
 #include "game.h"
+#include "chatmessage.h"
+#include "translation.h"
 
 extern gui::IGUIEnvironment* guienv;
 
@@ -55,9 +64,9 @@ extern gui::IGUIEnvironment* guienv;
 */
 
 Client::Client(
-               IrrlichtDevice *device,
                const char *playername,
                const std::string &password,
+               const std::string &address_name,
                MapDrawControl &control,
                IWritableTextureSource *tsrc,
                IWritableShaderSource *shsrc,
@@ -66,13 +75,8 @@ Client::Client(
                ISoundManager *sound,
                MtEventManager *event,
                bool ipv6,
-               GameUIFlags *game_ui_flags
+               GameUI *game_ui
 ):
-       m_packetcounter_timer(0.0),
-       m_connection_reinit_timer(0.1),
-       m_avg_rtt_timer(0.0),
-       m_playerpos_send_timer(0.0),
-       m_ignore_damage_timer(0.0),
        m_tsrc(tsrc),
        m_shsrc(shsrc),
        m_itemdef(itemdef),
@@ -81,51 +85,27 @@ Client::Client(
        m_event(event),
        m_mesh_update_thread(this),
        m_env(
-               new ClientMap(this, control,
-                       device->getSceneManager()->getRootSceneNode(),
-                       device->getSceneManager(), 666),
-               device->getSceneManager(),
-               tsrc, this, device
+               new ClientMap(this, control, 666),
+               tsrc, this
        ),
        m_particle_manager(&m_env),
-       m_con(PROTOCOL_ID, 512, CONNECTION_TIMEOUT, ipv6, this),
-       m_device(device),
-       m_camera(NULL),
-       m_minimap_disabled_by_server(false),
+       m_con(new con::Connection(PROTOCOL_ID, 512, CONNECTION_TIMEOUT, ipv6, this)),
+       m_address_name(address_name),
        m_server_ser_ver(SER_FMT_VER_INVALID),
-       m_proto_ver(0),
-       m_playeritem(0),
-       m_inventory_updated(false),
-       m_inventory_from_server(NULL),
-       m_inventory_from_server_age(0.0),
-       m_animation_time(0),
-       m_crack_level(-1),
-       m_crack_pos(0,0,0),
-       m_map_seed(0),
+       m_last_chat_message_sent(time(NULL)),
        m_password(password),
        m_chosen_auth_mech(AUTH_MECHANISM_NONE),
-       m_auth_data(NULL),
-       m_access_denied(false),
-       m_access_denied_reconnect(false),
-       m_itemdef_received(false),
-       m_nodedef_received(false),
        m_media_downloader(new ClientMediaDownloader()),
-       m_time_of_day_set(false),
-       m_last_time_of_day_f(-1),
-       m_time_of_day_update_timer(0),
-       m_recommended_send_interval(0.1),
-       m_removed_sounds_check_timer(0),
        m_state(LC_Created),
-       m_localdb(NULL),
-       m_script(NULL),
-       m_mod_storage_save_timer(10.0f),
-       m_game_ui_flags(game_ui_flags),
-       m_shutdown(false)
+       m_game_ui(game_ui),
+       m_modchannel_mgr(new ModChannelMgr())
 {
        // Add local player
        m_env.setLocalPlayer(new LocalPlayer(this, playername));
 
-       m_minimap = new Minimap(device, this);
+       if (g_settings->getBool("enable_minimap")) {
+               m_minimap = new Minimap(this);
+       }
        m_cache_save_interval = g_settings->getU16("server_map_save_interval");
 
        m_modding_enabled = g_settings->getBool("enable_client_modding");
@@ -134,18 +114,38 @@ Client::Client(
        m_script->setEnv(&m_env);
 }
 
-void Client::initMods()
+void Client::loadBuiltin()
 {
-       m_script->loadMod(getBuiltinLuaPath() + DIR_DELIM "init.lua", BUILTIN_MOD_NAME);
+       // Load builtin
+       scanModIntoMemory(BUILTIN_MOD_NAME, getBuiltinLuaPath());
+
+       m_script->loadModFromMemory(BUILTIN_MOD_NAME);
+}
+
+void Client::loadMods()
+{
+       // Don't permit to load mods twice
+       if (m_mods_loaded) {
+               return;
+       }
 
-       // If modding is not enabled, don't load mods, just builtin
+       // If modding is not enabled or flavour disable it, don't load mods, just builtin
        if (!m_modding_enabled) {
+               warningstream << "Client side mods are disabled by configuration." << std::endl;
+               return;
+       }
+
+       if (checkCSMFlavourLimit(CSMFlavourLimit::CSM_FL_LOAD_CLIENT_MODS)) {
+               warningstream << "Client side mods are disabled by server." << std::endl;
+               // If mods loading is disabled and builtin integrity is wrong, disconnect user.
+               if (!checkBuiltinIntegrity()) {
+                       // @TODO disconnect user
+               }
                return;
        }
 
        ClientModConfiguration modconf(getClientModsLuaPath());
-       std::vector<ModSpec> mods = modconf.getMods();
-       std::vector<ModSpec> unsatisfied_mods = modconf.getUnsatisfiedMods();
+       m_mods = modconf.getMods();
        // complain about mods with unsatisfied dependencies
        if (!modconf.isConsistent()) {
                modconf.printUnsatisfiedModsError();
@@ -153,25 +153,47 @@ void Client::initMods()
 
        // Print mods
        infostream << "Client Loading mods: ";
-       for (std::vector<ModSpec>::const_iterator i = mods.begin();
-               i != mods.end(); ++i) {
-               infostream << (*i).name << " ";
-       }
-
+       for (const ModSpec &mod : m_mods)
+               infostream << mod.name << " ";
        infostream << std::endl;
+
        // Load and run "mod" scripts
-       for (std::vector<ModSpec>::const_iterator it = mods.begin();
-               it != mods.end(); ++it) {
-               const ModSpec &mod = *it;
+       for (const ModSpec &mod : m_mods) {
                if (!string_allowed(mod.name, MODNAME_ALLOWED_CHARS)) {
                        throw ModError("Error loading mod \"" + mod.name +
                                "\": Mod name does not follow naming conventions: "
-                                       "Only chararacters [a-z0-9_] are allowed.");
+                                       "Only characters [a-z0-9_] are allowed.");
+               }
+               scanModIntoMemory(mod.name, mod.path);
+       }
+
+       // Load and run "mod" scripts
+       for (const ModSpec &mod : m_mods)
+               m_script->loadModFromMemory(mod.name);
+
+       m_mods_loaded = true;
+}
+
+bool Client::checkBuiltinIntegrity()
+{
+       // @TODO
+       return true;
+}
+
+void Client::scanModSubfolder(const std::string &mod_name, const std::string &mod_path,
+                       std::string mod_subpath)
+{
+       std::string full_path = mod_path + DIR_DELIM + mod_subpath;
+       std::vector<fs::DirListNode> mod = fs::GetDirListing(full_path);
+       for (const fs::DirListNode &j : mod) {
+               std::string filename = j.name;
+               if (j.dir) {
+                       scanModSubfolder(mod_name, mod_path, mod_subpath
+                                       + filename + DIR_DELIM);
+                       continue;
                }
-               std::string script_path = mod.path + DIR_DELIM + "init.lua";
-               infostream << "  [" << padStringRight(mod.name, 12) << "] [\""
-                       << script_path << "\"]" << std::endl;
-               m_script->loadMod(script_path, mod.name);
+               std::replace( mod_subpath.begin(), mod_subpath.end(), DIR_DELIM_CHAR, '/');
+               m_mod_files[mod_name + ":" + mod_subpath + filename] = full_path  + filename;
        }
 }
 
@@ -222,7 +244,7 @@ bool Client::isShutdown()
 Client::~Client()
 {
        m_shutdown = true;
-       m_con.Disconnect();
+       m_con->Disconnect();
 
        m_mesh_update_thread.stop();
        m_mesh_update_thread.wait();
@@ -235,49 +257,35 @@ Client::~Client()
        delete m_inventory_from_server;
 
        // Delete detached inventories
-       for (UNORDERED_MAP<std::string, Inventory*>::iterator
-                       i = m_detached_inventories.begin();
-                       i != m_detached_inventories.end(); ++i) {
-               delete i->second;
+       for (auto &m_detached_inventorie : m_detached_inventories) {
+               delete m_detached_inventorie.second;
        }
 
        // cleanup 3d model meshes on client shutdown
-       while (m_device->getSceneManager()->getMeshCache()->getMeshCount() != 0) {
-               scene::IAnimatedMesh *mesh =
-                       m_device->getSceneManager()->getMeshCache()->getMeshByIndex(0);
+       while (RenderingEngine::get_mesh_cache()->getMeshCount() != 0) {
+               scene::IAnimatedMesh *mesh = RenderingEngine::get_mesh_cache()->getMeshByIndex(0);
 
-               if (mesh != NULL)
-                       m_device->getSceneManager()->getMeshCache()->removeMesh(mesh);
+               if (mesh)
+                       RenderingEngine::get_mesh_cache()->removeMesh(mesh);
        }
 
        delete m_minimap;
 }
 
-void Client::connect(Address address,
-               const std::string &address_name,
-               bool is_local_server)
+void Client::connect(Address address, bool is_local_server)
 {
-       DSTACK(FUNCTION_NAME);
-
-       initLocalMapSaving(address, address_name, is_local_server);
+       initLocalMapSaving(address, m_address_name, is_local_server);
 
-       m_con.SetTimeoutMs(0);
-       m_con.Connect(address);
+       m_con->SetTimeoutMs(0);
+       m_con->Connect(address);
 }
 
 void Client::step(float dtime)
 {
-       DSTACK(FUNCTION_NAME);
-
        // Limit a bit
-       if(dtime > 2.0)
+       if (dtime > 2.0)
                dtime = 2.0;
 
-       if(m_ignore_damage_timer > dtime)
-               m_ignore_damage_timer -= dtime;
-       else
-               m_ignore_damage_timer = 0.0;
-
        m_animation_time += dtime;
        if(m_animation_time > 60.0)
                m_animation_time -= 60.0;
@@ -318,31 +326,7 @@ void Client::step(float dtime)
                        LocalPlayer *myplayer = m_env.getLocalPlayer();
                        FATAL_ERROR_IF(myplayer == NULL, "Local player not found in environment.");
 
-                       u16 proto_version_min = g_settings->getFlag("send_pre_v25_init") ?
-                               CLIENT_PROTOCOL_VERSION_MIN_LEGACY : CLIENT_PROTOCOL_VERSION_MIN;
-
-                       if (proto_version_min < 25) {
-                               // Send TOSERVER_INIT_LEGACY
-                               // [0] u16 TOSERVER_INIT_LEGACY
-                               // [2] u8 SER_FMT_VER_HIGHEST_READ
-                               // [3] u8[20] player_name
-                               // [23] u8[28] password (new in some version)
-                               // [51] u16 minimum supported network protocol version (added sometime)
-                               // [53] u16 maximum supported network protocol version (added later than the previous one)
-
-                               char pName[PLAYERNAME_SIZE];
-                               char pPassword[PASSWORD_SIZE];
-                               memset(pName, 0, PLAYERNAME_SIZE * sizeof(char));
-                               memset(pPassword, 0, PASSWORD_SIZE * sizeof(char));
-
-                               std::string hashed_password = translate_password(myplayer->getName(), m_password);
-                               snprintf(pName, PLAYERNAME_SIZE, "%s", myplayer->getName());
-                               snprintf(pPassword, PASSWORD_SIZE, "%s", hashed_password.c_str());
-
-                               sendLegacyInit(pName, pPassword);
-                       }
-                       if (CLIENT_PROTOCOL_VERSION_MAX >= 25)
-                               sendInit(myplayer->getName());
+                       sendInit(myplayer->getName());
                }
 
                // Not connected, return
@@ -397,13 +381,21 @@ void Client::step(float dtime)
                }
        }
 
+       /*
+               Send pending messages on out chat queue
+       */
+       if (!m_out_chat_queue.empty() && canSendChatMessage()) {
+               sendChatMessage(m_out_chat_queue.front());
+               m_out_chat_queue.pop();
+       }
+
        /*
                Handle environment
        */
        // Control local player (0ms)
        LocalPlayer *player = m_env.getLocalPlayer();
-       assert(player != NULL);
-       player->applyControl(dtime);
+       assert(player);
+       player->applyControl(dtime, &m_env);
 
        // Step environment
        m_env.step(dtime);
@@ -416,23 +408,16 @@ void Client::step(float dtime)
                ClientEnvEvent envEvent = m_env.getClientEnvEvent();
 
                if (envEvent.type == CEE_PLAYER_DAMAGE) {
-                       if (m_ignore_damage_timer <= 0) {
-                               u8 damage = envEvent.player_damage.amount;
+                       u8 damage = envEvent.player_damage.amount;
 
-                               if (envEvent.player_damage.send_to_server)
-                                       sendDamage(damage);
+                       if (envEvent.player_damage.send_to_server)
+                               sendDamage(damage);
 
-                               // Add to ClientEvent queue
-                               ClientEvent event;
-                               event.type = CE_PLAYER_DAMAGE;
-                               event.player_damage.amount = damage;
-                               m_client_event_queue.push(event);
-                       }
-               }
-               // Protocol v29 or greater obsoleted this event
-               else if (envEvent.type == CEE_PLAYER_BREATH && m_proto_ver < 29) {
-                       u16 breath = envEvent.player_breath.amount;
-                       sendBreath(breath);
+                       // Add to ClientEvent queue
+                       ClientEvent *event = new ClientEvent();
+                       event->type = CE_PLAYER_DAMAGE;
+                       event->player_damage.amount = damage;
+                       m_client_event_queue.push(event);
                }
        }
 
@@ -477,10 +462,8 @@ void Client::step(float dtime)
                        MapBlock *block = m_env.getMap().getBlockNoCreateNoEx(r.p);
                        if (block) {
                                // Delete the old mesh
-                               if (block->mesh != NULL) {
-                                       delete block->mesh;
-                                       block->mesh = NULL;
-                               }
+                               delete block->mesh;
+                               block->mesh = nullptr;
 
                                if (r.mesh) {
                                        minimap_mapblock = r.mesh->moveMinimapMapblock();
@@ -502,7 +485,7 @@ void Client::step(float dtime)
                                delete r.mesh;
                        }
 
-                       if (do_mapper_update)
+                       if (m_minimap && do_mapper_update)
                                m_minimap->addBlock(r.p, minimap_mapblock);
 
                        if (r.ack_block_to_server) {
@@ -558,15 +541,13 @@ void Client::step(float dtime)
                Update positions of sounds attached to objects
        */
        {
-               for(UNORDERED_MAP<int, u16>::iterator i = m_sounds_to_objects.begin();
-                               i != m_sounds_to_objects.end(); ++i) {
-                       int client_id = i->first;
-                       u16 object_id = i->second;
+               for (auto &m_sounds_to_object : m_sounds_to_objects) {
+                       int client_id = m_sounds_to_object.first;
+                       u16 object_id = m_sounds_to_object.second;
                        ClientActiveObject *cao = m_env.getActiveObject(object_id);
-                       if(!cao)
+                       if (!cao)
                                continue;
-                       v3f pos = cao->getPosition();
-                       m_sound->updateSoundPosition(client_id, pos);
+                       m_sound->updateSoundPosition(client_id, cao->getPosition());
                }
        }
 
@@ -578,7 +559,7 @@ void Client::step(float dtime)
                m_removed_sounds_check_timer = 0;
                // Find removed sounds and clear references to them
                std::vector<s32> removed_server_ids;
-               for(UNORDERED_MAP<s32, int>::iterator i = m_sounds_server_to_client.begin();
+               for (std::unordered_map<s32, int>::iterator i = m_sounds_server_to_client.begin();
                                i != m_sounds_server_to_client.end();) {
                        s32 server_id = i->first;
                        int client_id = i->second;
@@ -601,7 +582,7 @@ void Client::step(float dtime)
        if (m_mod_storage_save_timer <= 0.0f) {
                verbosestream << "Saving registered mod storages." << std::endl;
                m_mod_storage_save_timer = g_settings->getFloat("server_map_save_interval");
-               for (UNORDERED_MAP<std::string, ModMetadata *>::const_iterator
+               for (std::unordered_map<std::string, ModMetadata *>::const_iterator
                                it = m_mod_storages.begin(); it != m_mod_storages.end(); ++it) {
                        if (it->second->isModified()) {
                                it->second->save(getModStoragePath());
@@ -630,13 +611,12 @@ bool Client::loadMedia(const std::string &data, const std::string &filename)
                NULL
        };
        name = removeStringEnd(filename, image_ext);
-       if(name != "")
-       {
+       if (!name.empty()) {
                verbosestream<<"Client: Attempting to load image "
                <<"file \""<<filename<<"\""<<std::endl;
 
-               io::IFileSystem *irrfs = m_device->getFileSystem();
-               video::IVideoDriver *vdrv = m_device->getVideoDriver();
+               io::IFileSystem *irrfs = RenderingEngine::get_filesystem();
+               video::IVideoDriver *vdrv = RenderingEngine::get_video_driver();
 
                // Create an irrlicht memory file
                io::IReadFile *rfile = irrfs->createMemoryReadFile(
@@ -646,18 +626,17 @@ bool Client::loadMedia(const std::string &data, const std::string &filename)
 
                // Read image
                video::IImage *img = vdrv->createImageFromFile(rfile);
-               if(!img){
+               if (!img) {
                        errorstream<<"Client: Cannot create image from data of "
                                        <<"file \""<<filename<<"\""<<std::endl;
                        rfile->drop();
                        return false;
                }
-               else {
-                       m_tsrc->insertSourceImage(filename, img);
-                       img->drop();
-                       rfile->drop();
-                       return true;
-               }
+
+               m_tsrc->insertSourceImage(filename, img);
+               img->drop();
+               rfile->drop();
+               return true;
        }
 
        const char *sound_ext[] = {
@@ -666,8 +645,7 @@ bool Client::loadMedia(const std::string &data, const std::string &filename)
                ".ogg", NULL
        };
        name = removeStringEnd(filename, sound_ext);
-       if(name != "")
-       {
+       if (!name.empty()) {
                verbosestream<<"Client: Attempting to load sound "
                <<"file \""<<filename<<"\""<<std::endl;
                m_sound->loadSoundData(name, data);
@@ -678,9 +656,9 @@ bool Client::loadMedia(const std::string &data, const std::string &filename)
                ".x", ".b3d", ".md2", ".obj",
                NULL
        };
+
        name = removeStringEnd(filename, model_ext);
-       if(name != "")
-       {
+       if (!name.empty()) {
                verbosestream<<"Client: Storing model into memory: "
                                <<"\""<<filename<<"\""<<std::endl;
                if(m_mesh_data.count(filename))
@@ -690,8 +668,19 @@ bool Client::loadMedia(const std::string &data, const std::string &filename)
                return true;
        }
 
-       errorstream<<"Client: Don't know how to load file \""
-                       <<filename<<"\""<<std::endl;
+       const char *translate_ext[] = {
+               ".tr", NULL
+       };
+       name = removeStringEnd(filename, translate_ext);
+       if (!name.empty()) {
+               verbosestream << "Client: Loading translation: "
+                               << "\"" << filename << "\"" << std::endl;
+               g_translations->loadTranslation(data);
+               return true;
+       }
+
+       errorstream << "Client: Don't know how to load file \""
+               << filename << "\"" << std::endl;
        return false;
 }
 
@@ -734,9 +723,8 @@ void Client::request_media(const std::vector<std::string> &file_requests)
 
        pkt << (u16) (file_requests_size & 0xFFFF);
 
-       for(std::vector<std::string>::const_iterator i = file_requests.begin();
-                       i != file_requests.end(); ++i) {
-               pkt << (*i);
+       for (const std::string &file_request : file_requests) {
+               pkt << file_request;
        }
 
        Send(&pkt);
@@ -767,7 +755,6 @@ void Client::initLocalMapSaving(const Address &address,
 
 void Client::ReceiveAll()
 {
-       DSTACK(FUNCTION_NAME);
        u64 start_ms = porting::getTimeMs();
        for(;;)
        {
@@ -793,9 +780,8 @@ void Client::ReceiveAll()
 
 void Client::Receive()
 {
-       DSTACK(FUNCTION_NAME);
        NetworkPacket pkt;
-       m_con.Receive(&pkt);
+       m_con->Receive(&pkt);
        ProcessData(&pkt);
 }
 
@@ -810,8 +796,6 @@ inline void Client::handleCommand(NetworkPacket* pkt)
 */
 void Client::ProcessData(NetworkPacket *pkt)
 {
-       DSTACK(FUNCTION_NAME);
-
        ToClientCommand command = (ToClientCommand) pkt->getCommand();
        u32 sender_peer_id = pkt->getPeerId();
 
@@ -862,7 +846,7 @@ void Client::ProcessData(NetworkPacket *pkt)
 
 void Client::Send(NetworkPacket* pkt)
 {
-       m_con.Send(PEER_ID_SERVER,
+       m_con->Send(PEER_ID_SERVER,
                serverCommandFactoryTable[pkt->getCommand()].channel,
                pkt,
                serverCommandFactoryTable[pkt->getCommand()].reliable);
@@ -976,22 +960,6 @@ AuthMechanism Client::choseAuthMech(const u32 mechs)
        return AUTH_MECHANISM_NONE;
 }
 
-void Client::sendLegacyInit(const char* playerName, const char* playerPassword)
-{
-       NetworkPacket pkt(TOSERVER_INIT_LEGACY,
-                       1 + PLAYERNAME_SIZE + PASSWORD_SIZE + 2 + 2);
-
-       u16 proto_version_min = g_settings->getFlag("send_pre_v25_init") ?
-               CLIENT_PROTOCOL_VERSION_MIN_LEGACY : CLIENT_PROTOCOL_VERSION_MIN;
-
-       pkt << (u8) SER_FMT_VER_HIGHEST_READ;
-       pkt.putRawString(playerName,PLAYERNAME_SIZE);
-       pkt.putRawString(playerPassword, PASSWORD_SIZE);
-       pkt << (u16) proto_version_min << (u16) CLIENT_PROTOCOL_VERSION_MAX;
-
-       Send(&pkt);
-}
-
 void Client::sendInit(const std::string &playerName)
 {
        NetworkPacket pkt(TOSERVER_INIT, 1 + 2 + 2 + (1 + playerName.size()));
@@ -999,11 +967,8 @@ void Client::sendInit(const std::string &playerName)
        // we don't support network compression yet
        u16 supp_comp_modes = NETPROTO_COMPRESSION_NONE;
 
-       u16 proto_version_min = g_settings->getFlag("send_pre_v25_init") ?
-               CLIENT_PROTOCOL_VERSION_MIN_LEGACY : CLIENT_PROTOCOL_VERSION_MIN;
-
        pkt << (u8) SER_FMT_VER_HIGHEST_READ << (u16) supp_comp_modes;
-       pkt << (u16) proto_version_min << (u16) CLIENT_PROTOCOL_VERSION_MAX;
+       pkt << (u16) CLIENT_PROTOCOL_VERSION_MIN << (u16) CLIENT_PROTOCOL_VERSION_MAX;
        pkt << playerName;
 
        Send(&pkt);
@@ -1022,7 +987,7 @@ void Client::startAuth(AuthMechanism chosen_auth_mechanism)
                                &verifier, &salt);
 
                        NetworkPacket resp_pkt(TOSERVER_FIRST_SRP, 0);
-                       resp_pkt << salt << verifier << (u8)((m_password == "") ? 1 : 0);
+                       resp_pkt << salt << verifier << (u8)((m_password.empty()) ? 1 : 0);
 
                        Send(&resp_pkt);
                        break;
@@ -1064,12 +1029,8 @@ void Client::sendDeletedBlocks(std::vector<v3s16> &blocks)
 
        pkt << (u8) blocks.size();
 
-       u32 k = 0;
-       for(std::vector<v3s16>::iterator
-                       j = blocks.begin();
-                       j != blocks.end(); ++j) {
-               pkt << *j;
-               k++;
+       for (const v3s16 &block : blocks) {
+               pkt << block;
        }
 
        Send(&pkt);
@@ -1091,9 +1052,8 @@ void Client::sendRemovedSounds(std::vector<s32> &soundList)
 
        pkt << (u16) (server_ids & 0xFFFF);
 
-       for(std::vector<s32>::iterator i = soundList.begin();
-                       i != soundList.end(); ++i)
-               pkt << *i;
+       for (int sound_id : soundList)
+               pkt << sound_id;
 
        Send(&pkt);
 }
@@ -1155,80 +1115,81 @@ void Client::sendInventoryAction(InventoryAction *a)
        Send(&pkt);
 }
 
-void Client::sendChatMessage(const std::wstring &message)
+bool Client::canSendChatMessage() const
 {
-       NetworkPacket pkt(TOSERVER_CHAT_MESSAGE, 2 + message.size() * sizeof(u16));
+       u32 now = time(NULL);
+       float time_passed = now - m_last_chat_message_sent;
 
-       pkt << message;
+       float virt_chat_message_allowance = m_chat_message_allowance + time_passed *
+                       (CLIENT_CHAT_MESSAGE_LIMIT_PER_10S / 8.0f);
 
-       Send(&pkt);
+       if (virt_chat_message_allowance < 1.0f)
+               return false;
+
+       return true;
 }
 
-void Client::sendChangePassword(const std::string &oldpassword,
-        const std::string &newpassword)
+void Client::sendChatMessage(const std::wstring &message)
 {
-       LocalPlayer *player = m_env.getLocalPlayer();
-       if (player == NULL)
-               return;
+       const s16 max_queue_size = g_settings->getS16("max_out_chat_queue_size");
+       if (canSendChatMessage()) {
+               u32 now = time(NULL);
+               float time_passed = now - m_last_chat_message_sent;
+               m_last_chat_message_sent = time(NULL);
 
-       std::string playername = player->getName();
-       if (m_proto_ver >= 25) {
-               // get into sudo mode and then send new password to server
-               m_password = oldpassword;
-               m_new_password = newpassword;
-               startAuth(choseAuthMech(m_sudo_auth_methods));
-       } else {
-               std::string oldpwd = translate_password(playername, oldpassword);
-               std::string newpwd = translate_password(playername, newpassword);
+               m_chat_message_allowance += time_passed * (CLIENT_CHAT_MESSAGE_LIMIT_PER_10S / 8.0f);
+               if (m_chat_message_allowance > CLIENT_CHAT_MESSAGE_LIMIT_PER_10S)
+                       m_chat_message_allowance = CLIENT_CHAT_MESSAGE_LIMIT_PER_10S;
 
-               NetworkPacket pkt(TOSERVER_PASSWORD_LEGACY, 2 * PASSWORD_SIZE);
+               m_chat_message_allowance -= 1.0f;
 
-               for (u8 i = 0; i < PASSWORD_SIZE; i++) {
-                       pkt << (u8) (i < oldpwd.length() ? oldpwd[i] : 0);
-               }
+               NetworkPacket pkt(TOSERVER_CHAT_MESSAGE, 2 + message.size() * sizeof(u16));
+
+               pkt << message;
 
-               for (u8 i = 0; i < PASSWORD_SIZE; i++) {
-                       pkt << (u8) (i < newpwd.length() ? newpwd[i] : 0);
-               }
                Send(&pkt);
+       } else if (m_out_chat_queue.size() < (u16) max_queue_size || max_queue_size == -1) {
+               m_out_chat_queue.push(message);
+       } else {
+               infostream << "Could not queue chat message because maximum out chat queue size ("
+                               << max_queue_size << ") is reached." << std::endl;
        }
 }
 
-
-void Client::sendDamage(u8 damage)
+void Client::clearOutChatQueue()
 {
-       DSTACK(FUNCTION_NAME);
-
-       NetworkPacket pkt(TOSERVER_DAMAGE, sizeof(u8));
-       pkt << damage;
-       Send(&pkt);
+       m_out_chat_queue = std::queue<std::wstring>();
 }
 
-void Client::sendBreath(u16 breath)
+void Client::sendChangePassword(const std::string &oldpassword,
+        const std::string &newpassword)
 {
-       DSTACK(FUNCTION_NAME);
-
-       // Protocol v29 make this obsolete
-       if (m_proto_ver >= 29)
+       LocalPlayer *player = m_env.getLocalPlayer();
+       if (player == NULL)
                return;
 
-       NetworkPacket pkt(TOSERVER_BREATH, sizeof(u16));
-       pkt << breath;
+       // get into sudo mode and then send new password to server
+       m_password = oldpassword;
+       m_new_password = newpassword;
+       startAuth(choseAuthMech(m_sudo_auth_methods));
+}
+
+
+void Client::sendDamage(u8 damage)
+{
+       NetworkPacket pkt(TOSERVER_DAMAGE, sizeof(u8));
+       pkt << damage;
        Send(&pkt);
 }
 
 void Client::sendRespawn()
 {
-       DSTACK(FUNCTION_NAME);
-
        NetworkPacket pkt(TOSERVER_RESPAWN, 0);
        Send(&pkt);
 }
 
 void Client::sendReady()
 {
-       DSTACK(FUNCTION_NAME);
-
        NetworkPacket pkt(TOSERVER_CLIENT_READY,
                        1 + 1 + 1 + 1 + 2 + sizeof(char) * strlen(g_version_hash));
 
@@ -1242,7 +1203,7 @@ void Client::sendReady()
 void Client::sendPlayerPos()
 {
        LocalPlayer *myplayer = m_env.getLocalPlayer();
-       if(myplayer == NULL)
+       if (!myplayer)
                return;
 
        ClientMap &map = m_env.getClientMap();
@@ -1268,20 +1229,6 @@ void Client::sendPlayerPos()
        myplayer->last_camera_fov   = camera_fov;
        myplayer->last_wanted_range = wanted_range;
 
-       //infostream << "Sending Player Position information" << std::endl;
-
-       u16 our_peer_id;
-       {
-               //MutexAutoLock lock(m_con_mutex); //bulk comment-out
-               our_peer_id = m_con.GetPeerID();
-       }
-
-       // Set peer id if not set already
-       if(myplayer->peer_id == PEER_ID_INEXISTENT)
-               myplayer->peer_id = our_peer_id;
-
-       assert(myplayer->peer_id == our_peer_id);
-
        NetworkPacket pkt(TOSERVER_PLAYERPOS, 12 + 12 + 4 + 4 + 4 + 1 + 1);
 
        writePlayerPos(myplayer, &map, &pkt);
@@ -1292,16 +1239,9 @@ void Client::sendPlayerPos()
 void Client::sendPlayerItem(u16 item)
 {
        LocalPlayer *myplayer = m_env.getLocalPlayer();
-       if(myplayer == NULL)
+       if (!myplayer)
                return;
 
-       u16 our_peer_id = m_con.GetPeerID();
-
-       // Set peer id if not set already
-       if(myplayer->peer_id == PEER_ID_INEXISTENT)
-               myplayer->peer_id = our_peer_id;
-       assert(myplayer->peer_id == our_peer_id);
-
        NetworkPacket pkt(TOSERVER_PLAYERITEM, 2);
 
        pkt << item;
@@ -1319,15 +1259,27 @@ void Client::removeNode(v3s16 p)
        catch(InvalidPositionException &e) {
        }
 
-       for(std::map<v3s16, MapBlock *>::iterator
-                       i = modified_blocks.begin();
-                       i != modified_blocks.end(); ++i) {
-               addUpdateMeshTaskWithEdge(i->first, false, true);
+       for (const auto &modified_block : modified_blocks) {
+               addUpdateMeshTaskWithEdge(modified_block.first, false, true);
        }
 }
 
+/**
+ * Helper function for Client Side Modding
+ * Flavour is applied there, this should not be used for core engine
+ * @param p
+ * @param is_valid_position
+ * @return
+ */
 MapNode Client::getNode(v3s16 p, bool *is_valid_position)
 {
+       if (checkCSMFlavourLimit(CSMFlavourLimit::CSM_FL_LOOKUP_NODES)) {
+               v3s16 ppos = floatToInt(m_env.getLocalPlayer()->getPosition(), BS);
+               if ((u32) ppos.getDistanceFrom(p) > m_csm_noderange_limit) {
+                       *is_valid_position = false;
+                       return {};
+               }
+       }
        return m_env.getMap().getNodeNoEx(p, is_valid_position);
 }
 
@@ -1344,17 +1296,15 @@ void Client::addNode(v3s16 p, MapNode n, bool remove_metadata)
        catch(InvalidPositionException &e) {
        }
 
-       for(std::map<v3s16, MapBlock *>::iterator
-                       i = modified_blocks.begin();
-                       i != modified_blocks.end(); ++i) {
-               addUpdateMeshTaskWithEdge(i->first, false, true);
+       for (const auto &modified_block : modified_blocks) {
+               addUpdateMeshTaskWithEdge(modified_block.first, false, true);
        }
 }
 
 void Client::setPlayerControl(PlayerControl &control)
 {
        LocalPlayer *player = m_env.getLocalPlayer();
-       assert(player != NULL);
+       assert(player);
        player->control = control;
 }
 
@@ -1378,7 +1328,7 @@ bool Client::getLocalInventoryUpdated()
 void Client::getLocalInventory(Inventory &dst)
 {
        LocalPlayer *player = m_env.getLocalPlayer();
-       assert(player != NULL);
+       assert(player);
        dst = player->inventory;
 }
 
@@ -1391,7 +1341,7 @@ Inventory* Client::getInventory(const InventoryLocation &loc)
        case InventoryLocation::CURRENT_PLAYER:
        {
                LocalPlayer *player = m_env.getLocalPlayer();
-               assert(player != NULL);
+               assert(player);
                return &player->inventory;
        }
        break;
@@ -1480,23 +1430,45 @@ void Client::setCrack(int level, v3s16 pos)
 u16 Client::getHP()
 {
        LocalPlayer *player = m_env.getLocalPlayer();
-       assert(player != NULL);
+       assert(player);
        return player->hp;
 }
 
-bool Client::getChatMessage(std::wstring &message)
+bool Client::getChatMessage(std::wstring &res)
 {
-       if(m_chat_queue.size() == 0)
+       if (m_chat_queue.empty())
                return false;
-       message = m_chat_queue.front();
+
+       ChatMessage *chatMessage = m_chat_queue.front();
        m_chat_queue.pop();
+
+       res = L"";
+
+       switch (chatMessage->type) {
+               case CHATMESSAGE_TYPE_RAW:
+               case CHATMESSAGE_TYPE_ANNOUNCE:
+               case CHATMESSAGE_TYPE_SYSTEM:
+                       res = chatMessage->message;
+                       break;
+               case CHATMESSAGE_TYPE_NORMAL: {
+                       if (!chatMessage->sender.empty())
+                               res = L"<" + chatMessage->sender + L"> " + chatMessage->message;
+                       else
+                               res = chatMessage->message;
+                       break;
+               }
+               default:
+                       break;
+       }
+
+       delete chatMessage;
        return true;
 }
 
 void Client::typeChatMessage(const std::wstring &message)
 {
        // Discard empty line
-       if(message == L"")
+       if (message.empty())
                return;
 
        // If message was ate by script API, don't send it to server
@@ -1508,14 +1480,13 @@ void Client::typeChatMessage(const std::wstring &message)
        sendChatMessage(message);
 
        // Show locally
-       if (message[0] != L'/')
-       {
+       if (message[0] != L'/') {
                // compatibility code
                if (m_proto_ver < 29) {
                        LocalPlayer *player = m_env.getLocalPlayer();
-                       assert(player != NULL);
+                       assert(player);
                        std::wstring name = narrow_to_wide(player->getName());
-                       pushToChatQueue((std::wstring)L"<" + name + L"> " + message);
+                       pushToChatQueue(new ChatMessage(CHATMESSAGE_TYPE_NORMAL, message, name));
                }
        }
 }
@@ -1593,26 +1564,35 @@ void Client::addUpdateMeshTaskForNode(v3s16 nodepos, bool ack_to_server, bool ur
        }
 }
 
-ClientEvent Client::getClientEvent()
+ClientEvent *Client::getClientEvent()
 {
        FATAL_ERROR_IF(m_client_event_queue.empty(),
                        "Cannot getClientEvent, queue is empty.");
 
-       ClientEvent event = m_client_event_queue.front();
+       ClientEvent *event = m_client_event_queue.front();
        m_client_event_queue.pop();
        return event;
 }
 
+bool Client::connectedToServer()
+{
+       return m_con->Connected();
+}
+
+const Address Client::getServerAddress()
+{
+       return m_con->GetPeerAddress(PEER_ID_SERVER);
+}
+
 float Client::mediaReceiveProgress()
 {
        if (m_media_downloader)
                return m_media_downloader->getProgress();
-       else
-               return 1.0; // downloader only exists when not yet done
+
+       return 1.0; // downloader only exists when not yet done
 }
 
 typedef struct TextureUpdateArgs {
-       IrrlichtDevice *device;
        gui::IGUIEnvironment *guienv;
        u64 last_time_ms;
        u16 last_percent;
@@ -1639,12 +1619,12 @@ void texture_update_progress(void *args, u32 progress, u32 max_progress)
                        targs->last_time_ms = time_ms;
                        std::basic_stringstream<wchar_t> strm;
                        strm << targs->text_base << " " << targs->last_percent << "%...";
-                       draw_load_screen(strm.str(), targs->device, targs->guienv, targs->tsrc, 0,
+                       RenderingEngine::draw_load_screen(strm.str(), targs->guienv, targs->tsrc, 0,
                                72 + (u16) ((18. / 100.) * (double) targs->last_percent), true);
                }
 }
 
-void Client::afterContentReceived(IrrlichtDevice *device)
+void Client::afterContentReceived()
 {
        infostream<<"Client::afterContentReceived() started"<<std::endl;
        assert(m_itemdef_received); // pre-condition
@@ -1656,29 +1636,28 @@ void Client::afterContentReceived(IrrlichtDevice *device)
        // Clear cached pre-scaled 2D GUI images, as this cache
        // might have images with the same name but different
        // content from previous sessions.
-       guiScalingCacheClear(device->getVideoDriver());
+       guiScalingCacheClear();
 
        // Rebuild inherited images and recreate textures
        infostream<<"- Rebuilding images and textures"<<std::endl;
-       draw_load_screen(text,device, guienv, m_tsrc, 0, 70);
+       RenderingEngine::draw_load_screen(text, guienv, m_tsrc, 0, 70);
        m_tsrc->rebuildImagesAndTextures();
        delete[] text;
 
        // Rebuild shaders
        infostream<<"- Rebuilding shaders"<<std::endl;
        text = wgettext("Rebuilding shaders...");
-       draw_load_screen(text, device, guienv, m_tsrc, 0, 71);
+       RenderingEngine::draw_load_screen(text, guienv, m_tsrc, 0, 71);
        m_shsrc->rebuildShaders();
        delete[] text;
 
        // Update node aliases
        infostream<<"- Updating node aliases"<<std::endl;
        text = wgettext("Initializing nodes...");
-       draw_load_screen(text, device, guienv, m_tsrc, 0, 72);
+       RenderingEngine::draw_load_screen(text, guienv, m_tsrc, 0, 72);
        m_nodedef->updateAliases(m_itemdef);
-       std::string texture_path = g_settings->get("texture_path");
-       if (texture_path != "" && fs::IsDir(texture_path))
-               m_nodedef->applyTextureOverrides(texture_path + DIR_DELIM + "override.txt");
+       for (const auto &path : getTextureDirs())
+               m_nodedef->applyTextureOverrides(path + DIR_DELIM + "override.txt");
        m_nodedef->setNodeRegistrationStatus(true);
        m_nodedef->runNodeResolveCallbacks();
        delete[] text;
@@ -1686,7 +1665,6 @@ void Client::afterContentReceived(IrrlichtDevice *device)
        // Update node textures and assign shaders to each tile
        infostream<<"- Updating node textures"<<std::endl;
        TextureUpdateArgs tu_args;
-       tu_args.device = device;
        tu_args.guienv = guienv;
        tu_args.last_time_ms = porting::getTimeMs();
        tu_args.last_percent = 0;
@@ -1708,25 +1686,25 @@ void Client::afterContentReceived(IrrlichtDevice *device)
        }
 
        text = wgettext("Done!");
-       draw_load_screen(text, device, guienv, m_tsrc, 0, 100);
+       RenderingEngine::draw_load_screen(text, guienv, m_tsrc, 0, 100);
        infostream<<"Client::afterContentReceived() done"<<std::endl;
        delete[] text;
 }
 
 float Client::getRTT()
 {
-       return m_con.getPeerStat(PEER_ID_SERVER,con::AVG_RTT);
+       return m_con->getPeerStat(PEER_ID_SERVER,con::AVG_RTT);
 }
 
 float Client::getCurRate()
 {
-       return ( m_con.getLocalStat(con::CUR_INC_RATE) +
-                       m_con.getLocalStat(con::CUR_DL_RATE));
+       return (m_con->getLocalStat(con::CUR_INC_RATE) +
+                       m_con->getLocalStat(con::CUR_DL_RATE));
 }
 
-void Client::makeScreenshot(IrrlichtDevice *device)
+void Client::makeScreenshot()
 {
-       irr::video::IVideoDriver *driver = device->getVideoDriver();
+       irr::video::IVideoDriver *driver = RenderingEngine::get_video_driver();
        irr::video::IImage* const raw_image = driver->createScreenShot();
 
        if (!raw_image)
@@ -1774,7 +1752,8 @@ void Client::makeScreenshot(IrrlichtDevice *device)
                        } else {
                                sstr << "Failed to save screenshot '" << filename << "'";
                        }
-                       pushToChatQueue(narrow_to_wide(sstr.str()));
+                       pushToChatQueue(new ChatMessage(CHATMESSAGE_TYPE_SYSTEM,
+                                       narrow_to_wide(sstr.str())));
                        infostream << sstr.str() << std::endl;
                        image->drop();
                }
@@ -1788,34 +1767,14 @@ bool Client::shouldShowMinimap() const
        return !m_minimap_disabled_by_server;
 }
 
-void Client::showGameChat(const bool show)
+void Client::pushToEventQueue(ClientEvent *event)
 {
-       m_game_ui_flags->show_chat = show;
-}
-
-void Client::showGameHud(const bool show)
-{
-       m_game_ui_flags->show_hud = show;
+       m_client_event_queue.push(event);
 }
 
 void Client::showMinimap(const bool show)
 {
-       m_game_ui_flags->show_minimap = show;
-}
-
-void Client::showProfiler(const bool show)
-{
-       m_game_ui_flags->show_profiler_graph = show;
-}
-
-void Client::showGameFog(const bool show)
-{
-       m_game_ui_flags->force_fog_off = !show;
-}
-
-void Client::showGameDebug(const bool show)
-{
-       m_game_ui_flags->show_debug = show;
+       m_game_ui->showMinimap(show);
 }
 
 // IGameDef interface
@@ -1841,10 +1800,7 @@ IShaderSource* Client::getShaderSource()
 {
        return m_shsrc;
 }
-scene::ISceneManager* Client::getSceneManager()
-{
-       return m_device->getSceneManager();
-}
+
 u16 Client::allocateUnknownNodeId(const std::string &name)
 {
        errorstream << "Client::allocateUnknownNodeId(): "
@@ -1867,7 +1823,7 @@ ParticleManager* Client::getParticleManager()
        return &m_particle_manager;
 }
 
-scene::IAnimatedMesh* Client::getMesh(const std::string &filename)
+scene::IAnimatedMesh* Client::getMesh(const std::string &filename, bool cache)
 {
        StringMap::const_iterator it = m_mesh_data.find(filename);
        if (it == m_mesh_data.end()) {
@@ -1876,25 +1832,33 @@ scene::IAnimatedMesh* Client::getMesh(const std::string &filename)
                return NULL;
        }
        const std::string &data    = it->second;
-       scene::ISceneManager *smgr = m_device->getSceneManager();
 
        // Create the mesh, remove it from cache and return it
        // This allows unique vertex colors and other properties for each instance
        Buffer<char> data_rw(data.c_str(), data.size()); // Const-incorrect Irrlicht
-       io::IFileSystem *irrfs = m_device->getFileSystem();
-       io::IReadFile *rfile   = irrfs->createMemoryReadFile(
+       io::IReadFile *rfile   = RenderingEngine::get_filesystem()->createMemoryReadFile(
                        *data_rw, data_rw.getSize(), filename.c_str());
        FATAL_ERROR_IF(!rfile, "Could not create/open RAM file");
 
-       scene::IAnimatedMesh *mesh = smgr->getMesh(rfile);
+       scene::IAnimatedMesh *mesh = RenderingEngine::get_scene_manager()->getMesh(rfile);
        rfile->drop();
-       // NOTE: By playing with Irrlicht refcounts, maybe we could cache a bunch
-       // of uniquely named instances and re-use them
        mesh->grab();
-       smgr->getMeshCache()->removeMesh(mesh);
+       if (!cache)
+               RenderingEngine::get_mesh_cache()->removeMesh(mesh);
        return mesh;
 }
 
+const std::string* Client::getModFile(const std::string &filename)
+{
+       StringMap::const_iterator it = m_mod_files.find(filename);
+       if (it == m_mod_files.end()) {
+               errorstream << "Client::getModFile(): File not found: \"" << filename
+                       << "\"" << std::endl;
+               return NULL;
+       }
+       return &it->second;
+}
+
 bool Client::registerModStorage(ModMetadata *storage)
 {
        if (m_mod_storages.find(storage->getModName()) != m_mod_storages.end()) {
@@ -1909,7 +1873,8 @@ bool Client::registerModStorage(ModMetadata *storage)
 
 void Client::unregisterModStorage(const std::string &name)
 {
-       UNORDERED_MAP<std::string, ModMetadata *>::const_iterator it = m_mod_storages.find(name);
+       std::unordered_map<std::string, ModMetadata *>::const_iterator it =
+               m_mod_storages.find(name);
        if (it != m_mod_storages.end()) {
                // Save unconditionaly on unregistration
                it->second->save(getModStoragePath());
@@ -1922,3 +1887,56 @@ std::string Client::getModStoragePath() const
        return porting::path_user + DIR_DELIM + "client" + DIR_DELIM + "mod_storage";
 }
 
+/*
+ * Mod channels
+ */
+
+bool Client::joinModChannel(const std::string &channel)
+{
+       if (m_modchannel_mgr->channelRegistered(channel))
+               return false;
+
+       NetworkPacket pkt(TOSERVER_MODCHANNEL_JOIN, 2 + channel.size());
+       pkt << channel;
+       Send(&pkt);
+
+       m_modchannel_mgr->joinChannel(channel, 0);
+       return true;
+}
+
+bool Client::leaveModChannel(const std::string &channel)
+{
+       if (!m_modchannel_mgr->channelRegistered(channel))
+               return false;
+
+       NetworkPacket pkt(TOSERVER_MODCHANNEL_LEAVE, 2 + channel.size());
+       pkt << channel;
+       Send(&pkt);
+
+       m_modchannel_mgr->leaveChannel(channel, 0);
+       return true;
+}
+
+bool Client::sendModChannelMessage(const std::string &channel, const std::string &message)
+{
+       if (!m_modchannel_mgr->canWriteOnChannel(channel))
+               return false;
+
+       if (message.size() > STRING_MAX_LEN) {
+               warningstream << "ModChannel message too long, dropping before sending "
+                               << " (" << message.size() << " > " << STRING_MAX_LEN << ", channel: "
+                               << channel << ")" << std::endl;
+               return false;
+       }
+
+       // @TODO: do some client rate limiting
+       NetworkPacket pkt(TOSERVER_MODCHANNEL_MSG, 2 + channel.size() + 2 + message.size());
+       pkt << channel << message;
+       Send(&pkt);
+       return true;
+}
+
+ModChannel* Client::getModChannel(const std::string &channel)
+{
+       return m_modchannel_mgr->getModChannel(channel);
+}