]> git.lizzy.rs Git - minetest.git/blobdiff - src/client/inputhandler.h
Fix '[combine' when EVDF_TEXTURE_NPOT is disabled. (#12187)
[minetest.git] / src / client / inputhandler.h
index fc7998f2035df953500b081719b17b87864522a8..3db105c518ecf6d066d1436247b6f558e3f1f21c 100644 (file)
@@ -144,8 +144,22 @@ class MyEventReceiver : public IEventReceiver
                return b;
        }
 
-       void listenForKey(const KeyPress &keyCode) { keysListenedFor.set(keyCode); }
-       void dontListenForKeys() { keysListenedFor.clear(); }
+       // Checks whether a key was just pressed. State will be cleared
+       // in the subsequent iteration of Game::processPlayerInteraction
+       bool WasKeyPressed(const KeyPress &keycode) const { return keyWasPressed[keycode]; }
+
+       // Checks whether a key was just released. State will be cleared
+       // in the subsequent iteration of Game::processPlayerInteraction
+       bool WasKeyReleased(const KeyPress &keycode) const { return keyWasReleased[keycode]; }
+
+       void listenForKey(const KeyPress &keyCode)
+       {
+               keysListenedFor.set(keyCode);
+       }
+       void dontListenForKeys()
+       {
+               keysListenedFor.clear();
+       }
 
        s32 getMouseWheel()
        {
@@ -158,17 +172,20 @@ class MyEventReceiver : public IEventReceiver
        {
                keyIsDown.clear();
                keyWasDown.clear();
+               keyWasPressed.clear();
+               keyWasReleased.clear();
 
-               leftclicked = false;
-               rightclicked = false;
-               leftreleased = false;
-               rightreleased = false;
+               mouse_wheel = 0;
+       }
 
-               left_active = false;
-               middle_active = false;
-               right_active = false;
+       void clearWasKeyPressed()
+       {
+               keyWasPressed.clear();
+       }
 
-               mouse_wheel = 0;
+       void clearWasKeyReleased()
+       {
+               keyWasReleased.clear();
        }
 
        MyEventReceiver()
@@ -178,17 +195,6 @@ class MyEventReceiver : public IEventReceiver
 #endif
        }
 
-       bool leftclicked = false;
-       bool rightclicked = false;
-       bool leftreleased = false;
-       bool rightreleased = false;
-
-       bool left_active = false;
-       bool middle_active = false;
-       bool right_active = false;
-
-       s32 mouse_wheel = 0;
-
        JoystickController *joystick = nullptr;
 
 #ifdef HAVE_TOUCHSCREENGUI
@@ -196,10 +202,20 @@ class MyEventReceiver : public IEventReceiver
 #endif
 
 private:
+       s32 mouse_wheel = 0;
+
        // The current state of keys
        KeyList keyIsDown;
-       // Whether a key has been pressed or not
+
+       // Like keyIsDown but only reset when that key is read
        KeyList keyWasDown;
+
+       // Whether a key has just been pressed
+       KeyList keyWasPressed;
+
+       // Whether a key has just been released
+       KeyList keyWasReleased;
+
        // List of keys we listen for
        // TODO perhaps the type of this is not really
        // performant as KeyList is designed for few but
@@ -226,27 +242,22 @@ class InputHandler
 
        virtual bool isKeyDown(GameKeyType k) = 0;
        virtual bool wasKeyDown(GameKeyType k) = 0;
+       virtual bool wasKeyPressed(GameKeyType k) = 0;
+       virtual bool wasKeyReleased(GameKeyType k) = 0;
        virtual bool cancelPressed() = 0;
 
+       virtual float getMovementSpeed() = 0;
+       virtual float getMovementDirection() = 0;
+
+       virtual void clearWasKeyPressed() {}
+       virtual void clearWasKeyReleased() {}
+
        virtual void listenForKey(const KeyPress &keyCode) {}
        virtual void dontListenForKeys() {}
 
        virtual v2s32 getMousePos() = 0;
        virtual void setMousePos(s32 x, s32 y) = 0;
 
-       virtual bool getLeftState() = 0;
-       virtual bool getRightState() = 0;
-
-       virtual bool getLeftClicked() = 0;
-       virtual bool getRightClicked() = 0;
-       virtual void resetLeftClicked() = 0;
-       virtual void resetRightClicked() = 0;
-
-       virtual bool getLeftReleased() = 0;
-       virtual bool getRightReleased() = 0;
-       virtual void resetLeftReleased() = 0;
-       virtual void resetRightReleased() = 0;
-
        virtual s32 getMouseWheel() = 0;
 
        virtual void step(float dtime) {}
@@ -267,6 +278,12 @@ class RealInputHandler : public InputHandler
        {
                m_receiver->joystick = &joystick;
        }
+
+       virtual ~RealInputHandler()
+       {
+               m_receiver->joystick = nullptr;
+       }
+
        virtual bool isKeyDown(GameKeyType k)
        {
                return m_receiver->IsKeyDown(keycache.key[k]) || joystick.isKeyDown(k);
@@ -275,92 +292,103 @@ class RealInputHandler : public InputHandler
        {
                return m_receiver->WasKeyDown(keycache.key[k]) || joystick.wasKeyDown(k);
        }
-       virtual bool cancelPressed()
+       virtual bool wasKeyPressed(GameKeyType k)
        {
-               return wasKeyDown(KeyType::ESC) || m_receiver->WasKeyDown(CancelKey);
+               return m_receiver->WasKeyPressed(keycache.key[k]) || joystick.wasKeyPressed(k);
        }
-       virtual void listenForKey(const KeyPress &keyCode)
-       {
-               m_receiver->listenForKey(keyCode);
-       }
-       virtual void dontListenForKeys() { m_receiver->dontListenForKeys(); }
-       virtual v2s32 getMousePos()
+       virtual bool wasKeyReleased(GameKeyType k)
        {
-               if (RenderingEngine::get_raw_device()->getCursorControl()) {
-                       return RenderingEngine::get_raw_device()
-                                       ->getCursorControl()
-                                       ->getPosition();
-               }
-
-               return m_mousepos;
+               return m_receiver->WasKeyReleased(keycache.key[k]) || joystick.wasKeyReleased(k);
        }
 
-       virtual void setMousePos(s32 x, s32 y)
+       virtual float getMovementSpeed()
        {
-               if (RenderingEngine::get_raw_device()->getCursorControl()) {
-                       RenderingEngine::get_raw_device()
-                                       ->getCursorControl()
-                                       ->setPosition(x, y);
-               } else {
-                       m_mousepos = v2s32(x, y);
+               bool f = m_receiver->IsKeyDown(keycache.key[KeyType::FORWARD]),
+                       b = m_receiver->IsKeyDown(keycache.key[KeyType::BACKWARD]),
+                       l = m_receiver->IsKeyDown(keycache.key[KeyType::LEFT]),
+                       r = m_receiver->IsKeyDown(keycache.key[KeyType::RIGHT]);
+               if (f || b || l || r)
+               {
+                       // if contradictory keys pressed, stay still
+                       if (f && b && l && r)
+                               return 0.0f;
+                       else if (f && b && !l && !r)
+                               return 0.0f;
+                       else if (!f && !b && l && r)
+                               return 0.0f;
+                       return 1.0f; // If there is a keyboard event, assume maximum speed
                }
+               return joystick.getMovementSpeed();
        }
 
-       virtual bool getLeftState()
+       virtual float getMovementDirection()
        {
-               return m_receiver->left_active || joystick.isKeyDown(KeyType::MOUSE_L);
+               float x = 0, z = 0;
+
+               /* Check keyboard for input */
+               if (m_receiver->IsKeyDown(keycache.key[KeyType::FORWARD]))
+                       z += 1;
+               if (m_receiver->IsKeyDown(keycache.key[KeyType::BACKWARD]))
+                       z -= 1;
+               if (m_receiver->IsKeyDown(keycache.key[KeyType::RIGHT]))
+                       x += 1;
+               if (m_receiver->IsKeyDown(keycache.key[KeyType::LEFT]))
+                       x -= 1;
+
+               if (x != 0 || z != 0) /* If there is a keyboard event, it takes priority */
+                       return atan2(x, z);
+               else
+                       return joystick.getMovementDirection();
        }
-       virtual bool getRightState()
+
+       virtual bool cancelPressed()
        {
-               return m_receiver->right_active || joystick.isKeyDown(KeyType::MOUSE_R);
+               return wasKeyDown(KeyType::ESC) || m_receiver->WasKeyDown(CancelKey);
        }
 
-       virtual bool getLeftClicked()
+       virtual void clearWasKeyPressed()
        {
-               return m_receiver->leftclicked ||
-                      joystick.getWasKeyDown(KeyType::MOUSE_L);
+               m_receiver->clearWasKeyPressed();
        }
-       virtual bool getRightClicked()
+       virtual void clearWasKeyReleased()
        {
-               return m_receiver->rightclicked ||
-                      joystick.getWasKeyDown(KeyType::MOUSE_R);
+               m_receiver->clearWasKeyReleased();
        }
 
-       virtual void resetLeftClicked()
+       virtual void listenForKey(const KeyPress &keyCode)
        {
-               m_receiver->leftclicked = false;
-               joystick.clearWasKeyDown(KeyType::MOUSE_L);
+               m_receiver->listenForKey(keyCode);
        }
-       virtual void resetRightClicked()
+       virtual void dontListenForKeys()
        {
-               m_receiver->rightclicked = false;
-               joystick.clearWasKeyDown(KeyType::MOUSE_R);
+               m_receiver->dontListenForKeys();
        }
 
-       virtual bool getLeftReleased()
-       {
-               return m_receiver->leftreleased ||
-                      joystick.wasKeyReleased(KeyType::MOUSE_L);
-       }
-       virtual bool getRightReleased()
+       virtual v2s32 getMousePos()
        {
-               return m_receiver->rightreleased ||
-                      joystick.wasKeyReleased(KeyType::MOUSE_R);
+               auto control = RenderingEngine::get_raw_device()->getCursorControl();
+               if (control) {
+                       return control->getPosition();
+               }
+
+               return m_mousepos;
        }
 
-       virtual void resetLeftReleased()
+       virtual void setMousePos(s32 x, s32 y)
        {
-               m_receiver->leftreleased = false;
-               joystick.clearWasKeyReleased(KeyType::MOUSE_L);
+               auto control = RenderingEngine::get_raw_device()->getCursorControl();
+               if (control) {
+                       control->setPosition(x, y);
+               } else {
+                       m_mousepos = v2s32(x, y);
+               }
        }
-       virtual void resetRightReleased()
+
+       virtual s32 getMouseWheel()
        {
-               m_receiver->rightreleased = false;
-               joystick.clearWasKeyReleased(KeyType::MOUSE_R);
+               return m_receiver->getMouseWheel();
        }
 
-       virtual s32 getMouseWheel() { return m_receiver->getMouseWheel(); }
-
        void clear()
        {
                joystick.clear();
@@ -384,23 +412,14 @@ class RandomInputHandler : public InputHandler
 
        virtual bool isKeyDown(GameKeyType k) { return keydown[keycache.key[k]]; }
        virtual bool wasKeyDown(GameKeyType k) { return false; }
+       virtual bool wasKeyPressed(GameKeyType k) { return false; }
+       virtual bool wasKeyReleased(GameKeyType k) { return false; }
        virtual bool cancelPressed() { return false; }
+       virtual float getMovementSpeed() { return movementSpeed; }
+       virtual float getMovementDirection() { return movementDirection; }
        virtual v2s32 getMousePos() { return mousepos; }
        virtual void setMousePos(s32 x, s32 y) { mousepos = v2s32(x, y); }
 
-       virtual bool getLeftState() { return leftdown; }
-       virtual bool getRightState() { return rightdown; }
-
-       virtual bool getLeftClicked() { return leftclicked; }
-       virtual bool getRightClicked() { return rightclicked; }
-       virtual void resetLeftClicked() { leftclicked = false; }
-       virtual void resetRightClicked() { rightclicked = false; }
-
-       virtual bool getLeftReleased() { return leftreleased; }
-       virtual bool getRightReleased() { return rightreleased; }
-       virtual void resetLeftReleased() { leftreleased = false; }
-       virtual void resetRightReleased() { rightreleased = false; }
-
        virtual s32 getMouseWheel() { return 0; }
 
        virtual void step(float dtime);
@@ -411,10 +430,6 @@ class RandomInputHandler : public InputHandler
        KeyList keydown;
        v2s32 mousepos;
        v2s32 mousespeed;
-       bool leftdown = false;
-       bool rightdown = false;
-       bool leftclicked = false;
-       bool rightclicked = false;
-       bool leftreleased = false;
-       bool rightreleased = false;
+       float movementSpeed;
+       float movementDirection;
 };