]> git.lizzy.rs Git - minetest.git/blobdiff - src/client/fontengine.cpp
fontengine: Fix crash loading PNG/XML fonts from paths without dot
[minetest.git] / src / client / fontengine.cpp
index 59e5bedee90accba1eaa0eb74eb5331f4c67bdb6..f64315db476a9f3355f17cc7ebd8a1ca9689b28e 100644 (file)
@@ -23,9 +23,9 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "config.h"
 #include "porting.h"
 #include "filesys.h"
+#include "gettext.h"
 
 #if USE_FREETYPE
-#include "gettext.h"
 #include "irrlicht_changes/CGUITTFont.h"
 #endif
 
@@ -42,8 +42,7 @@ static void font_setting_changed(const std::string &name, void *userdata)
 }
 
 /******************************************************************************/
-FontEngine::FontEngine(Settings* main_settings, gui::IGUIEnvironment* env) :
-       m_settings(main_settings),
+FontEngine::FontEngine(gui::IGUIEnvironment* env) :
        m_env(env)
 {
 
@@ -51,58 +50,29 @@ FontEngine::FontEngine(Settings* main_settings, gui::IGUIEnvironment* env) :
                i = (FontMode) FONT_SIZE_UNSPECIFIED;
        }
 
-       assert(m_settings != NULL); // pre-condition
+       assert(g_settings != NULL); // pre-condition
        assert(m_env != NULL); // pre-condition
        assert(m_env->getSkin() != NULL); // pre-condition
 
-       m_currentMode = FM_Simple;
-
-#if USE_FREETYPE
-       if (g_settings->getBool("freetype")) {
-               m_default_size[FM_Standard] = m_settings->getU16("font_size");
-               m_default_size[FM_Fallback] = m_settings->getU16("fallback_font_size");
-               m_default_size[FM_Mono]     = m_settings->getU16("mono_font_size");
-
-               if (is_yes(gettext("needs_fallback_font"))) {
-                       m_currentMode = FM_Fallback;
-               }
-               else {
-                       m_currentMode = FM_Standard;
-               }
+       readSettings();
+
+       if (m_currentMode != FM_Simple) {
+               g_settings->registerChangedCallback("font_size", font_setting_changed, NULL);
+               g_settings->registerChangedCallback("font_bold", font_setting_changed, NULL);
+               g_settings->registerChangedCallback("font_italic", font_setting_changed, NULL);
+               g_settings->registerChangedCallback("font_path", font_setting_changed, NULL);
+               g_settings->registerChangedCallback("font_path_bold", font_setting_changed, NULL);
+               g_settings->registerChangedCallback("font_path_italic", font_setting_changed, NULL);
+               g_settings->registerChangedCallback("font_path_bolditalic", font_setting_changed, NULL);
+               g_settings->registerChangedCallback("font_shadow", font_setting_changed, NULL);
+               g_settings->registerChangedCallback("font_shadow_alpha", font_setting_changed, NULL);
+               g_settings->registerChangedCallback("fallback_font_path", font_setting_changed, NULL);
        }
 
-       // having freetype but not using it is quite a strange case so we need to do
-       // special handling for it
-       if (m_currentMode == FM_Simple) {
-               std::stringstream fontsize;
-               fontsize << DEFAULT_FONT_SIZE;
-               m_settings->setDefault("font_size", fontsize.str());
-               m_settings->setDefault("mono_font_size", fontsize.str());
-       }
-#endif
-
-       m_default_size[FM_Simple]       = m_settings->getU16("font_size");
-       m_default_size[FM_SimpleMono]   = m_settings->getU16("mono_font_size");
-
-       updateSkin();
-
-       if (m_currentMode == FM_Standard) {
-               m_settings->registerChangedCallback("font_size", font_setting_changed, NULL);
-               m_settings->registerChangedCallback("font_path", font_setting_changed, NULL);
-               m_settings->registerChangedCallback("font_shadow", font_setting_changed, NULL);
-               m_settings->registerChangedCallback("font_shadow_alpha", font_setting_changed, NULL);
-       }
-       else if (m_currentMode == FM_Fallback) {
-               m_settings->registerChangedCallback("fallback_font_size", font_setting_changed, NULL);
-               m_settings->registerChangedCallback("fallback_font_path", font_setting_changed, NULL);
-               m_settings->registerChangedCallback("fallback_font_shadow", font_setting_changed, NULL);
-               m_settings->registerChangedCallback("fallback_font_shadow_alpha", font_setting_changed, NULL);
-       }
-
-       m_settings->registerChangedCallback("mono_font_path", font_setting_changed, NULL);
-       m_settings->registerChangedCallback("mono_font_size", font_setting_changed, NULL);
-       m_settings->registerChangedCallback("screen_dpi", font_setting_changed, NULL);
-       m_settings->registerChangedCallback("gui_scaling", font_setting_changed, NULL);
+       g_settings->registerChangedCallback("mono_font_path", font_setting_changed, NULL);
+       g_settings->registerChangedCallback("mono_font_size", font_setting_changed, NULL);
+       g_settings->registerChangedCallback("screen_dpi", font_setting_changed, NULL);
+       g_settings->registerChangedCallback("gui_scaling", font_setting_changed, NULL);
 }
 
 /******************************************************************************/
@@ -125,42 +95,61 @@ void FontEngine::cleanCache()
 }
 
 /******************************************************************************/
-irr::gui::IGUIFont* FontEngine::getFont(unsigned int font_size, FontMode mode)
+irr::gui::IGUIFont *FontEngine::getFont(FontSpec spec)
 {
-       if (mode == FM_Unspecified) {
-               mode = m_currentMode;
-       }
-       else if ((mode == FM_Mono) && (m_currentMode == FM_Simple)) {
-               mode = FM_SimpleMono;
-       }
+       return getFont(spec, false);
+}
 
-       if (font_size == FONT_SIZE_UNSPECIFIED) {
-               font_size = m_default_size[mode];
+irr::gui::IGUIFont *FontEngine::getFont(FontSpec spec, bool may_fail)
+{
+       if (spec.mode == FM_Unspecified) {
+               spec.mode = m_currentMode;
+       } else if (m_currentMode == FM_Simple) {
+               // Freetype disabled -> Force simple mode
+               spec.mode = (spec.mode == FM_Mono ||
+                               spec.mode == FM_SimpleMono) ?
+                               FM_SimpleMono : FM_Simple;
+               // Support for those could be added, but who cares?
+               spec.bold = false;
+               spec.italic = false;
+       } else if (spec.mode == _FM_Fallback) {
+               // Fallback font doesn't support these either
+               spec.bold = false;
+               spec.italic = false;
        }
 
-       if ((font_size == m_lastSize) && (mode == m_lastMode)) {
-               return m_lastFont;
-       }
+       // Fallback to default size
+       if (spec.size == FONT_SIZE_UNSPECIFIED)
+               spec.size = m_default_size[spec.mode];
 
-       if (m_font_cache[mode].find(font_size) == m_font_cache[mode].end()) {
-               initFont(font_size, mode);
-       }
+       const auto &cache = m_font_cache[spec.getHash()];
+       auto it = cache.find(spec.size);
+       if (it != cache.end())
+               return it->second;
+
+       // Font does not yet exist
+       gui::IGUIFont *font = nullptr;
+       if (spec.mode == FM_Simple || spec.mode == FM_SimpleMono)
+               font = initSimpleFont(spec);
+       else
+               font = initFont(spec);
 
-       if (m_font_cache[mode].find(font_size) == m_font_cache[mode].end()) {
-               return NULL;
+       if (!font && !may_fail) {
+               errorstream << "Minetest cannot continue without a valid font. "
+                       "Please correct the 'font_path' setting or install the font "
+                       "file in the proper location." << std::endl;
+               abort();
        }
 
-       m_lastSize = font_size;
-       m_lastMode = mode;
-       m_lastFont = m_font_cache[mode][font_size];
+       m_font_cache[spec.getHash()][spec.size] = font;
 
-       return m_font_cache[mode][font_size];
+       return font;
 }
 
 /******************************************************************************/
-unsigned int FontEngine::getTextHeight(unsigned int font_size, FontMode mode)
+unsigned int FontEngine::getTextHeight(const FontSpec &spec)
 {
-       irr::gui::IGUIFont* font = getFont(font_size, mode);
+       irr::gui::IGUIFont *font = getFont(spec);
 
        // use current skin font as fallback
        if (font == NULL) {
@@ -172,10 +161,9 @@ unsigned int FontEngine::getTextHeight(unsigned int font_size, FontMode mode)
 }
 
 /******************************************************************************/
-unsigned int FontEngine::getTextWidth(const std::wstring& text,
-               unsigned int font_size, FontMode mode)
+unsigned int FontEngine::getTextWidth(const std::wstring &text, const FontSpec &spec)
 {
-       irr::gui::IGUIFont* font = getFont(font_size, mode);
+       irr::gui::IGUIFont *font = getFont(spec);
 
        // use current skin font as fallback
        if (font == NULL) {
@@ -188,9 +176,9 @@ unsigned int FontEngine::getTextWidth(const std::wstring& text,
 
 
 /** get line height for a specific font (including empty room between lines) */
-unsigned int FontEngine::getLineHeight(unsigned int font_size, FontMode mode)
+unsigned int FontEngine::getLineHeight(const FontSpec &spec)
 {
-       irr::gui::IGUIFont* font = getFont(font_size, mode);
+       irr::gui::IGUIFont *font = getFont(spec);
 
        // use current skin font as fallback
        if (font == NULL) {
@@ -208,25 +196,38 @@ unsigned int FontEngine::getDefaultFontSize()
        return m_default_size[m_currentMode];
 }
 
+unsigned int FontEngine::getFontSize(FontMode mode)
+{
+       if (m_currentMode == FM_Simple) {
+               if (mode == FM_Mono || mode == FM_SimpleMono)
+                       return m_default_size[FM_SimpleMono];
+               else
+                       return m_default_size[FM_Simple];
+       }
+
+       if (mode == FM_Unspecified)
+               return m_default_size[FM_Standard];
+
+       return m_default_size[mode];
+}
+
 /******************************************************************************/
 void FontEngine::readSettings()
 {
-#if USE_FREETYPE
-       if (g_settings->getBool("freetype")) {
-               m_default_size[FM_Standard] = m_settings->getU16("font_size");
-               m_default_size[FM_Fallback] = m_settings->getU16("fallback_font_size");
-               m_default_size[FM_Mono]     = m_settings->getU16("mono_font_size");
+       if (USE_FREETYPE && g_settings->getBool("freetype")) {
+               m_default_size[FM_Standard]  = g_settings->getU16("font_size");
+               m_default_size[_FM_Fallback] = g_settings->getU16("font_size");
+               m_default_size[FM_Mono]      = g_settings->getU16("mono_font_size");
 
-               if (is_yes(gettext("needs_fallback_font"))) {
-                       m_currentMode = FM_Fallback;
-               }
-               else {
-                       m_currentMode = FM_Standard;
-               }
+               m_default_bold = g_settings->getBool("font_bold");
+               m_default_italic = g_settings->getBool("font_italic");
+
+       } else {
+               m_currentMode = FM_Simple;
        }
-#endif
-       m_default_size[FM_Simple]       = m_settings->getU16("font_size");
-       m_default_size[FM_SimpleMono]   = m_settings->getU16("mono_font_size");
+
+       m_default_size[FM_Simple]       = g_settings->getU16("font_size");
+       m_default_size[FM_SimpleMono]   = g_settings->getU16("mono_font_size");
 
        cleanCache();
        updateFontCache();
@@ -242,7 +243,7 @@ void FontEngine::updateSkin()
                m_env->getSkin()->setFont(font);
        else
                errorstream << "FontEngine: Default font file: " <<
-                               "\n\t\"" << m_settings->get("font_path") << "\"" <<
+                               "\n\t\"" << g_settings->get("font_path") << "\"" <<
                                "\n\trequired for current screen configuration was not found" <<
                                " or was invalid file format." <<
                                "\n\tUsing irrlicht default font." << std::endl;
@@ -252,7 +253,7 @@ void FontEngine::updateSkin()
        FATAL_ERROR_IF(font == NULL, "Could not create/get font");
 
        u32 text_height = font->getDimension(L"Hello, world!").Height;
-       infostream << "text_height=" << text_height << std::endl;
+       infostream << "FontEngine: measured text_height=" << text_height << std::endl;
 }
 
 /******************************************************************************/
@@ -260,238 +261,134 @@ void FontEngine::updateFontCache()
 {
        /* the only font to be initialized is default one,
         * all others are re-initialized on demand */
-       initFont(m_default_size[m_currentMode], m_currentMode);
-
-       /* reset font quick access */
-       m_lastMode = FM_Unspecified;
-       m_lastSize = 0;
-       m_lastFont = NULL;
+       getFont(FONT_SIZE_UNSPECIFIED, FM_Unspecified);
 }
 
 /******************************************************************************/
-void FontEngine::initFont(unsigned int basesize, FontMode mode)
+gui::IGUIFont *FontEngine::initFont(const FontSpec &spec)
 {
+       assert(spec.mode != FM_Unspecified);
+       assert(spec.size != FONT_SIZE_UNSPECIFIED);
 
-       std::string font_config_prefix;
-
-       if (mode == FM_Unspecified) {
-               mode = m_currentMode;
-       }
-
-       switch (mode) {
+       std::string setting_prefix = "";
+       if (spec.mode == FM_Mono)
+               setting_prefix = "mono_";
 
-               case FM_Standard:
-                       font_config_prefix = "";
-                       break;
-
-               case FM_Fallback:
-                       font_config_prefix = "fallback_";
-                       break;
+       std::string setting_suffix = "";
+       if (spec.bold)
+               setting_suffix.append("_bold");
+       if (spec.italic)
+               setting_suffix.append("_italic");
 
-               case FM_Mono:
-                       font_config_prefix = "mono_";
-                       if (m_currentMode == FM_Simple)
-                               mode = FM_SimpleMono;
-                       break;
-
-               case FM_Simple: /* Fallthrough */
-               case FM_SimpleMono: /* Fallthrough */
-               default:
-                       font_config_prefix = "";
+       u32 size = std::floor(RenderingEngine::getDisplayDensity() *
+                       g_settings->getFloat("gui_scaling") * spec.size);
 
+       if (size == 0) {
+               errorstream << "FontEngine: attempt to use font size 0" << std::endl;
+               errorstream << "  display density: " << RenderingEngine::getDisplayDensity() << std::endl;
+               abort();
        }
 
-       if (m_font_cache[mode].find(basesize) != m_font_cache[mode].end())
-               return;
+       u16 font_shadow       = 0;
+       u16 font_shadow_alpha = 0;
+       g_settings->getU16NoEx(setting_prefix + "font_shadow", font_shadow);
+       g_settings->getU16NoEx(setting_prefix + "font_shadow_alpha",
+                       font_shadow_alpha);
 
-       if ((mode == FM_Simple) || (mode == FM_SimpleMono)) {
-               initSimpleFont(basesize, mode);
-               return;
-       }
-#if USE_FREETYPE
-       else {
-               if (!is_yes(m_settings->get("freetype"))) {
-                       return;
-               }
-               u32 size = std::floor(RenderingEngine::getDisplayDensity() *
-                               m_settings->getFloat("gui_scaling") * basesize);
-               if (size == 0) {
-                       errorstream << "FontEngine: attempt to use font size 0" << std::endl;
-                       errorstream << "  display density: " << RenderingEngine::getDisplayDensity() << std::endl;
-                       abort();
-               }
-               u32 font_shadow       = 0;
-               u32 font_shadow_alpha = 0;
-
-               try {
-                       font_shadow =
-                                       g_settings->getU16(font_config_prefix + "font_shadow");
-               } catch (SettingNotFoundException&) {}
-               try {
-                       font_shadow_alpha =
-                                       g_settings->getU16(font_config_prefix + "font_shadow_alpha");
-               } catch (SettingNotFoundException&) {}
+       std::string path_setting;
+       if (spec.mode == _FM_Fallback)
+               path_setting = "fallback_font_path";
+       else
+               path_setting = setting_prefix + "font_path" + setting_suffix;
 
-               std::string font_path = g_settings->get(font_config_prefix + "font_path");
+       std::string fallback_settings[] = {
+               g_settings->get(path_setting),
+               Settings::getLayer(SL_DEFAULTS)->get(path_setting)
+       };
 
-               irr::gui::IGUIFont* font = gui::CGUITTFont::createTTFont(m_env,
+#if USE_FREETYPE
+       for (const std::string &font_path : fallback_settings) {
+               gui::CGUITTFont *font = gui::CGUITTFont::createTTFont(m_env,
                                font_path.c_str(), size, true, true, font_shadow,
                                font_shadow_alpha);
 
-               if (font) {
-                       m_font_cache[mode][basesize] = font;
-                       return;
+               if (!font) {
+                       errorstream << "FontEngine: Cannot load '" << font_path <<
+                               "'. Trying to fall back to another path." << std::endl;
+                       continue;
                }
 
-               if (font_config_prefix == "mono_") {
-                       const std::string &mono_font_path = m_settings->getDefault("mono_font_path");
-
-                       if (font_path != mono_font_path) {
-                               // try original mono font
-                               errorstream << "FontEngine: failed to load custom mono "
-                                               "font: " << font_path << ", trying to fall back to "
-                                               "original mono font" << std::endl;
-
-                               font = gui::CGUITTFont::createTTFont(m_env,
-                                       mono_font_path.c_str(), size, true, true,
-                                       font_shadow, font_shadow_alpha);
-
-                               if (font) {
-                                       m_font_cache[mode][basesize] = font;
-                                       return;
-                               }
-                       }
-               } else {
-                       // try fallback font
-                       errorstream << "FontEngine: failed to load: " << font_path <<
-                                       ", trying to fall back to fallback font" << std::endl;
-
-                       font_path = g_settings->get(font_config_prefix + "fallback_font_path");
-
-                       font = gui::CGUITTFont::createTTFont(m_env,
-                               font_path.c_str(), size, true, true, font_shadow,
-                               font_shadow_alpha);
-
-                       if (font) {
-                               m_font_cache[mode][basesize] = font;
-                               return;
-                       }
-
-                       const std::string &fallback_font_path = m_settings->getDefault("fallback_font_path");
-
-                       if (font_path != fallback_font_path) {
-                               // try original fallback font
-                               errorstream << "FontEngine: failed to load custom fallback "
-                                               "font: " << font_path << ", trying to fall back to "
-                                               "original fallback font" << std::endl;
-
-                               font = gui::CGUITTFont::createTTFont(m_env,
-                                       fallback_font_path.c_str(), size, true, true,
-                                       font_shadow, font_shadow_alpha);
-
-                               if (font) {
-                                       m_font_cache[mode][basesize] = font;
-                                       return;
-                               }
-                       }
+               if (spec.mode != _FM_Fallback) {
+                       FontSpec spec2(spec);
+                       spec2.mode = _FM_Fallback;
+                       font->setFallback(getFont(spec2, true));
                }
-
-               // give up
-               errorstream << "FontEngine: failed to load freetype font: "
-                               << font_path << std::endl;
-               errorstream << "minetest can not continue without a valid font. "
-                               "Please correct the 'font_path' setting or install the font "
-                               "file in the proper location" << std::endl;
-               abort();
+               return font;
        }
+#else
+       errorstream << "FontEngine: Tried to load TTF font but Minetest was"
+                       " compiled without Freetype." << std::endl;
 #endif
+       return nullptr;
 }
 
 /** initialize a font without freetype */
-void FontEngine::initSimpleFont(unsigned int basesize, FontMode mode)
+gui::IGUIFont *FontEngine::initSimpleFont(const FontSpec &spec)
 {
-       assert(mode == FM_Simple || mode == FM_SimpleMono); // pre-condition
+       assert(spec.mode == FM_Simple || spec.mode == FM_SimpleMono);
+       assert(spec.size != FONT_SIZE_UNSPECIFIED);
 
-       std::string font_path;
-       if (mode == FM_Simple) {
-               font_path = m_settings->get("font_path");
-       } else {
-               font_path = m_settings->get("mono_font_path");
-       }
-       std::string basename = font_path;
-       std::string ending = font_path.substr(font_path.length() -4);
+       const std::string &font_path = g_settings->get(
+                       (spec.mode == FM_SimpleMono) ? "mono_font_path" : "font_path");
 
-       if (ending == ".ttf") {
-               errorstream << "FontEngine: Not trying to open \"" << font_path
-                               << "\" which seems to be a truetype font." << std::endl;
-               return;
-       }
+       size_t pos_dot = font_path.find_last_of('.');
+       std::string basename = font_path, ending;
+       if (pos_dot != std::string::npos)
+               ending = lowercase(font_path.substr(pos_dot));
 
-       if ((ending == ".xml") || (ending == ".png")) {
-               basename = font_path.substr(0,font_path.length()-4);
+       if (ending == ".ttf") {
+               errorstream << "FontEngine: Found font \"" << font_path
+                               << "\" but freetype is not available." << std::endl;
+               return nullptr;
        }
 
-       if (basesize == FONT_SIZE_UNSPECIFIED)
-               basesize = DEFAULT_FONT_SIZE;
+       if (ending == ".xml" || ending == ".png")
+               basename = font_path.substr(0, pos_dot);
 
        u32 size = std::floor(
                        RenderingEngine::getDisplayDensity() *
-                       m_settings->getFloat("gui_scaling") *
-                       basesize);
+                       g_settings->getFloat("gui_scaling") *
+                       spec.size);
 
-       irr::gui::IGUIFont* font = NULL;
+       irr::gui::IGUIFont *font = nullptr;
+       std::string font_extensions[] = { ".png", ".xml" };
 
-       for(unsigned int offset = 0; offset < MAX_FONT_SIZE_OFFSET; offset++) {
+       // Find nearest matching font scale
+       // Does a "zig-zag motion" (positibe/negative), from 0 to MAX_FONT_SIZE_OFFSET
+       for (s32 zoffset = 0; zoffset < MAX_FONT_SIZE_OFFSET * 2; zoffset++) {
+               std::stringstream path;
 
-               // try opening positive offset
-               std::stringstream fontsize_plus_png;
-               fontsize_plus_png << basename << "_" << (size + offset) << ".png";
+               // LSB to sign
+               s32 sign = (zoffset & 1) ? -1 : 1;
+               s32 offset = zoffset >> 1;
 
-               if (fs::PathExists(fontsize_plus_png.str())) {
-                       font = m_env->getFont(fontsize_plus_png.str().c_str());
+               for (const std::string &ext : font_extensions) {
+                       path.str(""); // Clear
+                       path << basename << "_" << (size + offset * sign) << ext;
 
-                       if (font) {
-                               verbosestream << "FontEngine: found font: " << fontsize_plus_png.str() << std::endl;
-                               break;
-                       }
-               }
-
-               std::stringstream fontsize_plus_xml;
-               fontsize_plus_xml << basename << "_" << (size + offset) << ".xml";
+                       if (!fs::PathExists(path.str()))
+                               continue;
 
-               if (fs::PathExists(fontsize_plus_xml.str())) {
-                       font = m_env->getFont(fontsize_plus_xml.str().c_str());
+                       font = m_env->getFont(path.str().c_str());
 
                        if (font) {
-                               verbosestream << "FontEngine: found font: " << fontsize_plus_xml.str() << std::endl;
+                               verbosestream << "FontEngine: found font: " << path.str() << std::endl;
                                break;
                        }
                }
 
-               // try negative offset
-               std::stringstream fontsize_minus_png;
-               fontsize_minus_png << basename << "_" << (size - offset) << ".png";
-
-               if (fs::PathExists(fontsize_minus_png.str())) {
-                       font = m_env->getFont(fontsize_minus_png.str().c_str());
-
-                       if (font) {
-                               verbosestream << "FontEngine: found font: " << fontsize_minus_png.str() << std::endl;
-                               break;
-                       }
-               }
-
-               std::stringstream fontsize_minus_xml;
-               fontsize_minus_xml << basename << "_" << (size - offset) << ".xml";
-
-               if (fs::PathExists(fontsize_minus_xml.str())) {
-                       font = m_env->getFont(fontsize_minus_xml.str().c_str());
-
-                       if (font) {
-                               verbosestream << "FontEngine: found font: " << fontsize_minus_xml.str() << std::endl;
-                               break;
-                       }
-               }
+               if (font)
+                       break;
        }
 
        // try name direct
@@ -503,8 +400,5 @@ void FontEngine::initSimpleFont(unsigned int basesize, FontMode mode)
                }
        }
 
-       if (font) {
-               font->grab();
-               m_font_cache[mode][basesize] = font;
-       }
+       return font;
 }