]> git.lizzy.rs Git - dragonfireclient.git/blobdiff - src/client/content_cao.cpp
Recalculate normals before adding mesh to the scene
[dragonfireclient.git] / src / client / content_cao.cpp
index 97ae9afc4019de44b3f773964c9e74345cdb5e8d..db01945eb565fa28e92e9a76e1df33ea7ea65150 100644 (file)
@@ -20,7 +20,6 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "content_cao.h"
 #include <IBillboardSceneNode.h>
 #include <ICameraSceneNode.h>
-#include <ITextSceneNode.h>
 #include <IMeshManipulator.h>
 #include <IAnimatedMeshSceneNode.h>
 #include "client/client.h"
@@ -28,7 +27,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "client/sound.h"
 #include "client/tile.h"
 #include "util/basic_macros.h"
-#include "util/numeric.h" // For IntervalLimiter & setPitchYawRoll
+#include "util/numeric.h"
 #include "util/serialize.h"
 #include "camera.h" // CameraModes
 #include "collision.h"
@@ -172,6 +171,20 @@ static void updatePositionRecursive(scene::ISceneNode *node)
        node->updateAbsolutePosition();
 }
 
+static bool logOnce(const std::ostringstream &from, std::ostream &log_to)
+{
+       thread_local std::vector<u64> logged;
+
+       std::string message = from.str();
+       u64 hash = murmur_hash_64_ua(message.data(), message.length(), 0xBADBABE);
+
+       if (std::find(logged.begin(), logged.end(), hash) != logged.end())
+               return false;
+       logged.push_back(hash);
+       log_to << message << std::endl;
+       return true;
+}
+
 /*
        TestCAO
 */
@@ -189,7 +202,7 @@ class TestCAO : public ClientActiveObject
 
        static ClientActiveObject* create(Client *client, ClientEnvironment *env);
 
-       void addToScene(ITextureSource *tsrc);
+       void addToScene(ITextureSource *tsrc, scene::ISceneManager *smgr);
        void removeFromScene(bool permanent);
        void updateLight(u32 day_night_ratio);
        void updateNodePos();
@@ -220,7 +233,7 @@ ClientActiveObject* TestCAO::create(Client *client, ClientEnvironment *env)
        return new TestCAO(client, env);
 }
 
-void TestCAO::addToScene(ITextureSource *tsrc)
+void TestCAO::addToScene(ITextureSource *tsrc, scene::ISceneManager *smgr)
 {
        if(m_node != NULL)
                return;
@@ -249,7 +262,7 @@ void TestCAO::addToScene(ITextureSource *tsrc)
        // Add to mesh
        mesh->addMeshBuffer(buf);
        buf->drop();
-       m_node = RenderingEngine::get_scene_manager()->addMeshSceneNode(mesh, NULL);
+       m_node = smgr->addMeshSceneNode(mesh, NULL);
        mesh->drop();
        updateNodePos();
 }
@@ -347,18 +360,6 @@ void GenericCAO::initialize(const std::string &data)
        infostream<<"GenericCAO: Got init data"<<std::endl;
        processInitData(data);
 
-       if (m_is_player) {
-               // Check if it's the current player
-               LocalPlayer *player = m_env->getLocalPlayer();
-               if (player && strcmp(player->getName(), m_name.c_str()) == 0) {
-                       m_is_local_player = true;
-                       m_is_visible = false;
-                       player->setCAO(this);
-
-                       m_prop.show_on_minimap = false;
-               }
-       }
-
        m_enable_shaders = g_settings->getBool("enable_shaders");
 }
 
@@ -381,6 +382,16 @@ void GenericCAO::processInitData(const std::string &data)
        m_rotation = readV3F32(is);
        m_hp = readU16(is);
 
+       if (m_is_player) {
+               // Check if it's the current player
+               LocalPlayer *player = m_env->getLocalPlayer();
+               if (player && strcmp(player->getName(), m_name.c_str()) == 0) {
+                       m_is_local_player = true;
+                       m_is_visible = false;
+                       player->setCAO(this);
+               }
+       }
+
        const u8 num_messages = readU8(is);
 
        for (int i = 0; i < num_messages; i++) {
@@ -558,6 +569,9 @@ void GenericCAO::removeFromScene(bool permanent)
                clearParentAttachment();
        }
 
+       if (auto shadow = RenderingEngine::get_shadow_renderer())
+               shadow->removeNodeFromShadowList(getSceneNode());
+
        if (m_meshnode) {
                m_meshnode->remove();
                m_meshnode->drop();
@@ -591,9 +605,9 @@ void GenericCAO::removeFromScene(bool permanent)
                m_client->getMinimap()->removeMarker(&m_marker);
 }
 
-void GenericCAO::addToScene(ITextureSource *tsrc)
+void GenericCAO::addToScene(ITextureSource *tsrc, scene::ISceneManager *smgr)
 {
-       m_smgr = RenderingEngine::get_scene_manager();
+       m_smgr = smgr;
 
        if (getSceneNode() != NULL) {
                return;
@@ -625,8 +639,7 @@ void GenericCAO::addToScene(ITextureSource *tsrc)
        }
 
        auto grabMatrixNode = [this] {
-               m_matrixnode = RenderingEngine::get_scene_manager()->
-                               addDummyTransformationSceneNode();
+               m_matrixnode = m_smgr->addDummyTransformationSceneNode();
                m_matrixnode->grab();
        };
 
@@ -644,11 +657,11 @@ void GenericCAO::addToScene(ITextureSource *tsrc)
 
        if (m_prop.visual == "sprite") {
                grabMatrixNode();
-               m_spritenode = RenderingEngine::get_scene_manager()->addBillboardSceneNode(
+               m_spritenode = m_smgr->addBillboardSceneNode(
                                m_matrixnode, v2f(1, 1), v3f(0,0,0), -1);
                m_spritenode->grab();
                m_spritenode->setMaterialTexture(0,
-                               tsrc->getTextureForMesh("unknown_node.png"));
+                               tsrc->getTextureForMesh("no_texture.png"));
 
                setSceneNodeMaterial(m_spritenode);
 
@@ -729,8 +742,7 @@ void GenericCAO::addToScene(ITextureSource *tsrc)
                        mesh->addMeshBuffer(buf);
                        buf->drop();
                }
-               m_meshnode = RenderingEngine::get_scene_manager()->
-                       addMeshSceneNode(mesh, m_matrixnode);
+               m_meshnode = m_smgr->addMeshSceneNode(mesh, m_matrixnode);
                m_meshnode->grab();
                mesh->drop();
                // Set it to use the materials of the meshbuffers directly.
@@ -739,8 +751,7 @@ void GenericCAO::addToScene(ITextureSource *tsrc)
        } else if (m_prop.visual == "cube") {
                grabMatrixNode();
                scene::IMesh *mesh = createCubeMesh(v3f(BS,BS,BS));
-               m_meshnode = RenderingEngine::get_scene_manager()->
-                       addMeshSceneNode(mesh, m_matrixnode);
+               m_meshnode = m_smgr->addMeshSceneNode(mesh, m_matrixnode);
                m_meshnode->grab();
                mesh->drop();
 
@@ -753,11 +764,6 @@ void GenericCAO::addToScene(ITextureSource *tsrc)
                grabMatrixNode();
                scene::IAnimatedMesh *mesh = m_client->getMesh(m_prop.mesh, true);
                if (mesh) {
-                       m_animated_meshnode = RenderingEngine::get_scene_manager()->
-                               addAnimatedMeshSceneNode(mesh, m_matrixnode);
-                       m_animated_meshnode->grab();
-                       mesh->drop(); // The scene node took hold of it
-
                        if (!checkMeshNormals(mesh)) {
                                infostream << "GenericCAO: recalculating normals for mesh "
                                        << m_prop.mesh << std::endl;
@@ -765,6 +771,9 @@ void GenericCAO::addToScene(ITextureSource *tsrc)
                                                recalculateNormals(mesh, true, false);
                        }
 
+                       m_animated_meshnode = m_smgr->addAnimatedMeshSceneNode(mesh, m_matrixnode);
+                       m_animated_meshnode->grab();
+                       mesh->drop(); // The scene node took hold of it
                        m_animated_meshnode->animateJoints(); // Needed for some animations
                        m_animated_meshnode->setScale(m_prop.visual_size);
 
@@ -795,8 +804,7 @@ void GenericCAO::addToScene(ITextureSource *tsrc)
                        infostream << "serialized form: " << m_prop.wield_item << std::endl;
                        item.deSerialize(m_prop.wield_item, m_client->idef());
                }
-               m_wield_meshnode = new WieldMeshSceneNode(
-                       RenderingEngine::get_scene_manager(), -1);
+               m_wield_meshnode = new WieldMeshSceneNode(m_smgr, -1);
                m_wield_meshnode->setItem(item, m_client,
                        (m_prop.visual == "wielditem"));
 
@@ -811,10 +819,13 @@ void GenericCAO::addToScene(ITextureSource *tsrc)
        if (m_reset_textures_timer < 0)
                updateTextures(m_current_texture_modifier);
 
-       scene::ISceneNode *node = getSceneNode();
+       if (scene::ISceneNode *node = getSceneNode()) {
+               if (m_matrixnode)
+                       node->setParent(m_matrixnode);
 
-       if (node && m_matrixnode)
-               node->setParent(m_matrixnode);
+               if (auto shadow = RenderingEngine::get_shadow_renderer())
+                       shadow->addNodeToShadowList(node);
+       }
 
        updateNametag();
        updateMarker();
@@ -824,6 +835,28 @@ void GenericCAO::addToScene(ITextureSource *tsrc)
        updateAttachments();
        setNodeLight(m_last_light);
        updateMeshCulling();
+
+       if (m_animated_meshnode) {
+               u32 mat_count = m_animated_meshnode->getMaterialCount();
+               if (mat_count == 0 || m_prop.textures.empty()) {
+                       // nothing
+               } else if (mat_count > m_prop.textures.size()) {
+                       std::ostringstream oss;
+                       oss << "GenericCAO::addToScene(): Model "
+                               << m_prop.mesh << " loaded with " << mat_count
+                               << " mesh buffers but only " << m_prop.textures.size()
+                               << " texture(s) specifed, this is deprecated.";
+                       logOnce(oss, warningstream);
+
+                       video::ITexture *last = m_animated_meshnode->getMaterial(0).TextureLayer[0].Texture;
+                       for (u32 i = 1; i < mat_count; i++) {
+                               auto &layer = m_animated_meshnode->getMaterial(i).TextureLayer[0];
+                               if (!layer.Texture)
+                                       layer.Texture = last;
+                               last = layer.Texture;
+                       }
+               }
+       }
 }
 
 void GenericCAO::updateLight(u32 day_night_ratio)
@@ -998,14 +1031,14 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
                        m_velocity = v3f(0,0,0);
                        m_acceleration = v3f(0,0,0);
                        const PlayerControl &controls = player->getPlayerControl();
+                       f32 new_speed = player->local_animation_speed;
 
                        bool walking = false;
-                       if (controls.up || controls.down || controls.left || controls.right ||
-                                       controls.forw_move_joystick_axis != 0.f ||
-                                       controls.sidew_move_joystick_axis != 0.f)
+                       if (controls.movement_speed > 0.001f) {
+                               new_speed *= controls.movement_speed;
                                walking = true;
+                       }
 
-                       f32 new_speed = player->local_animation_speed;
                        v2s32 new_anim = v2s32(0,0);
                        bool allow_update = false;
 
@@ -1017,7 +1050,7 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
                                        g_settings->getBool("free_move") &&
                                        m_client->checkLocalPrivilege("fly"))))
                                        new_speed *= 1.5;
-                       // slowdown speed if sneeking
+                       // slowdown speed if sneaking
                        if (controls.sneak && walking)
                                new_speed /= 2;
 
@@ -1074,7 +1107,7 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
                }
 
                removeFromScene(false);
-               addToScene(m_client->tsrc());
+               addToScene(m_client->tsrc(), m_smgr);
 
                // Attachments, part 2: Now that the parent has been refreshed, put its attachments back
                for (u16 cao_id : m_attachment_child_ids) {
@@ -1291,7 +1324,7 @@ void GenericCAO::updateTextures(std::string mod)
 
        if (m_spritenode) {
                if (m_prop.visual == "sprite") {
-                       std::string texturestring = "unknown_node.png";
+                       std::string texturestring = "no_texture.png";
                        if (!m_prop.textures.empty())
                                texturestring = m_prop.textures[0];
                        texturestring += mod;
@@ -1370,7 +1403,7 @@ void GenericCAO::updateTextures(std::string mod)
                {
                        for (u32 i = 0; i < 6; ++i)
                        {
-                               std::string texturestring = "unknown_node.png";
+                               std::string texturestring = "no_texture.png";
                                if(m_prop.textures.size() > i)
                                        texturestring = m_prop.textures[i];
                                texturestring += mod;
@@ -1403,7 +1436,7 @@ void GenericCAO::updateTextures(std::string mod)
                } else if (m_prop.visual == "upright_sprite") {
                        scene::IMesh *mesh = m_meshnode->getMesh();
                        {
-                               std::string tname = "unknown_object.png";
+                               std::string tname = "no_texture.png";
                                if (!m_prop.textures.empty())
                                        tname = m_prop.textures[0];
                                tname += mod;
@@ -1425,7 +1458,7 @@ void GenericCAO::updateTextures(std::string mod)
                                buf->getMaterial().setFlag(video::EMF_ANISOTROPIC_FILTER, use_anisotropic_filter);
                        }
                        {
-                               std::string tname = "unknown_object.png";
+                               std::string tname = "no_texture.png";
                                if (m_prop.textures.size() >= 2)
                                        tname = m_prop.textures[1];
                                else if (!m_prop.textures.empty())
@@ -1473,11 +1506,8 @@ void GenericCAO::updateAnimation()
        if (m_animated_meshnode->getAnimationSpeed() != m_animation_speed)
                m_animated_meshnode->setAnimationSpeed(m_animation_speed);
        m_animated_meshnode->setTransitionTime(m_animation_blend);
-// Requires Irrlicht 1.8 or greater
-#if (IRRLICHT_VERSION_MAJOR == 1 && IRRLICHT_VERSION_MINOR >= 8) || IRRLICHT_VERSION_MAJOR > 1
        if (m_animated_meshnode->getLoopMode() != m_animation_loop)
                m_animated_meshnode->setLoopMode(m_animation_loop);
-#endif
 }
 
 void GenericCAO::updateAnimationSpeed()
@@ -1493,10 +1523,10 @@ void GenericCAO::updateBonePosition()
        if (m_bone_position.empty() || !m_animated_meshnode)
                return;
 
-       m_animated_meshnode->setJointMode(irr::scene::EJUOR_CONTROL); // To write positions to the mesh on render
+       m_animated_meshnode->setJointMode(scene::EJUOR_CONTROL); // To write positions to the mesh on render
        for (auto &it : m_bone_position) {
                std::string bone_name = it.first;
-               irr::scene::IBoneSceneNode* bone = m_animated_meshnode->getJointNode(bone_name.c_str());
+               scene::IBoneSceneNode* bone = m_animated_meshnode->getJointNode(bone_name.c_str());
                if (bone) {
                        bone->setPosition(it.second.X);
                        bone->setRotation(it.second.Y);
@@ -1505,7 +1535,7 @@ void GenericCAO::updateBonePosition()
 
        // search through bones to find mistakenly rotated bones due to bug in Irrlicht
        for (u32 i = 0; i < m_animated_meshnode->getJointCount(); ++i) {
-               irr::scene::IBoneSceneNode *bone = m_animated_meshnode->getJointNode(i);
+               scene::IBoneSceneNode *bone = m_animated_meshnode->getJointNode(i);
                if (!bone)
                        continue;
 
@@ -1727,6 +1757,7 @@ void GenericCAO::processMessage(const std::string &data)
 
                m_tx_basepos = p;
                m_anim_num_frames = num_frames;
+               m_anim_frame = 0;
                m_anim_framelength = framelength;
                m_tx_select_horiz_by_yawpitch = select_horiz_by_yawpitch;
 
@@ -1875,7 +1906,8 @@ bool GenericCAO::directReportPunch(v3f dir, const ItemStack *punchitem,
                        m_armor_groups,
                        toolcap,
                        punchitem,
-                       time_from_last_punch);
+                       time_from_last_punch,
+                       punchitem->wear);
 
        if(result.did_punch && result.damage != 0)
        {
@@ -1933,7 +1965,7 @@ void GenericCAO::updateMeshCulling()
                return;
        }
 
-       irr::scene::ISceneNode *node = getSceneNode();
+       scene::ISceneNode *node = getSceneNode();
        if (!node)
                return;