]> git.lizzy.rs Git - rust.git/blobdiff - src/bootstrap/dist.rs
Rollup merge of #68093 - GuillaumeGomez:fix-deref-impl-typedef, r=oli-obk
[rust.git] / src / bootstrap / dist.rs
index d0c9e0dbaf458eaca013794d91645b636114d3d9..8d13df3ee21a49e2f179a68ae999d8cb041dca59 100644 (file)
 use std::env;
 use std::fs;
 use std::io::Write;
-use std::path::{PathBuf, Path};
+use std::path::{Path, PathBuf};
 use std::process::{Command, Stdio};
 
 use build_helper::{output, t};
 
-use crate::{Compiler, Mode, LLVM_TOOLS};
-use crate::channel;
-use crate::util::{is_dylib, exe, timeit};
 use crate::builder::{Builder, RunConfig, ShouldRun, Step};
+use crate::cache::{Interned, INTERNER};
+use crate::channel;
 use crate::compile;
 use crate::tool::{self, Tool};
-use crate::cache::{INTERNER, Interned};
+use crate::util::{exe, is_dylib, timeit};
+use crate::{Compiler, Mode, LLVM_TOOLS};
 use time::{self, Timespec};
 
 pub fn pkgname(builder: &Builder<'_>, component: &str) -> String {
@@ -80,9 +80,7 @@ fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
     }
 
     fn make_run(run: RunConfig<'_>) {
-        run.builder.ensure(Docs {
-            host: run.target,
-        });
+        run.builder.ensure(Docs { host: run.target });
     }
 
     /// Builds the `rust-docs` installer component.
@@ -110,16 +108,19 @@ fn run(self, builder: &Builder<'_>) -> PathBuf {
 
         let mut cmd = rust_installer(builder);
         cmd.arg("generate")
-           .arg("--product-name=Rust-Documentation")
-           .arg("--rel-manifest-dir=rustlib")
-           .arg("--success-message=Rust-documentation-is-installed.")
-           .arg("--image-dir").arg(&image)
-           .arg("--work-dir").arg(&tmpdir(builder))
-           .arg("--output-dir").arg(&distdir(builder))
-           .arg(format!("--package-name={}-{}", name, host))
-           .arg("--component-name=rust-docs")
-           .arg("--legacy-manifest-dirs=rustlib,cargo")
-           .arg("--bulk-dirs=share/doc/rust/html");
+            .arg("--product-name=Rust-Documentation")
+            .arg("--rel-manifest-dir=rustlib")
+            .arg("--success-message=Rust-documentation-is-installed.")
+            .arg("--image-dir")
+            .arg(&image)
+            .arg("--work-dir")
+            .arg(&tmpdir(builder))
+            .arg("--output-dir")
+            .arg(&distdir(builder))
+            .arg(format!("--package-name={}-{}", name, host))
+            .arg("--component-name=rust-docs")
+            .arg("--legacy-manifest-dirs=rustlib,cargo")
+            .arg("--bulk-dirs=share/doc/rust/html");
         builder.run(&mut cmd);
         builder.remove_dir(&image);
 
@@ -141,9 +142,7 @@ fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
     }
 
     fn make_run(run: RunConfig<'_>) {
-        run.builder.ensure(RustcDocs {
-            host: run.target,
-        });
+        run.builder.ensure(RustcDocs { host: run.target });
     }
 
     /// Builds the `rustc-docs` installer component.
@@ -168,16 +167,19 @@ fn run(self, builder: &Builder<'_>) -> PathBuf {
 
         let mut cmd = rust_installer(builder);
         cmd.arg("generate")
-           .arg("--product-name=Rustc-Documentation")
-           .arg("--rel-manifest-dir=rustlib")
-           .arg("--success-message=Rustc-documentation-is-installed.")
-           .arg("--image-dir").arg(&image)
-           .arg("--work-dir").arg(&tmpdir(builder))
-           .arg("--output-dir").arg(&distdir(builder))
-           .arg(format!("--package-name={}-{}", name, host))
-           .arg("--component-name=rustc-docs")
-           .arg("--legacy-manifest-dirs=rustlib,cargo")
-           .arg("--bulk-dirs=share/doc/rust/html");
+            .arg("--product-name=Rustc-Documentation")
+            .arg("--rel-manifest-dir=rustlib")
+            .arg("--success-message=Rustc-documentation-is-installed.")
+            .arg("--image-dir")
+            .arg(&image)
+            .arg("--work-dir")
+            .arg(&tmpdir(builder))
+            .arg("--output-dir")
+            .arg(&distdir(builder))
+            .arg(format!("--package-name={}-{}", name, host))
+            .arg("--component-name=rustc-docs")
+            .arg("--legacy-manifest-dirs=rustlib,cargo")
+            .arg("--bulk-dirs=share/doc/rust/html");
 
         builder.info(&format!("Dist compiler docs ({})", host));
         let _time = timeit(builder);
@@ -192,10 +194,7 @@ fn find_files(files: &[&str], path: &[PathBuf]) -> Vec<PathBuf> {
     let mut found = Vec::with_capacity(files.len());
 
     for file in files {
-        let file_path =
-            path.iter()
-                .map(|dir| dir.join(file))
-                .find(|p| p.exists());
+        let file_path = path.iter().map(|dir| dir.join(file)).find(|p| p.exists());
 
         if let Some(file_path) = file_path {
             found.push(file_path);
@@ -208,7 +207,10 @@ fn find_files(files: &[&str], path: &[PathBuf]) -> Vec<PathBuf> {
 }
 
 fn make_win_dist(
-    rust_root: &Path, plat_root: &Path, target_triple: Interned<String>, builder: &Builder<'_>
+    rust_root: &Path,
+    plat_root: &Path,
+    target_triple: Interned<String>,
+    builder: &Builder<'_>,
 ) {
     //Ask gcc where it keeps its stuff
     let mut cmd = Command::new(builder.cc(target_triple));
@@ -222,11 +224,7 @@ fn make_win_dist(
         let idx = line.find(':').unwrap();
         let key = &line[..idx];
         let trim_chars: &[_] = &[' ', '='];
-        let value =
-            line[(idx + 1)..]
-                .trim_start_matches(trim_chars)
-                .split(';')
-                .map(PathBuf::from);
+        let value = line[(idx + 1)..].trim_start_matches(trim_chars).split(';').map(PathBuf::from);
 
         if key == "programs" {
             bin_path.extend(value);
@@ -243,7 +241,8 @@ fn make_win_dist(
         rustc_dlls.push("libgcc_s_seh-1.dll");
     }
 
-    let target_libs = [ //MinGW libs
+    let target_libs = [
+        //MinGW libs
         "libgcc.a",
         "libgcc_eh.a",
         "libgcc_s.a",
@@ -312,7 +311,7 @@ fn make_win_dist(
         &target_bin_dir.join("GCC-WARNING.txt"),
         "gcc.exe contained in this folder cannot be used for compiling C files - it is only\
          used as a linker. In order to be able to compile projects containing C code use\
-         the GCC provided by MinGW or Cygwin."
+         the GCC provided by MinGW or Cygwin.",
     );
 
     //Copy platform libs to platform-specific lib directory
@@ -366,15 +365,18 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
 
         let mut cmd = rust_installer(builder);
         cmd.arg("generate")
-           .arg("--product-name=Rust-MinGW")
-           .arg("--rel-manifest-dir=rustlib")
-           .arg("--success-message=Rust-MinGW-is-installed.")
-           .arg("--image-dir").arg(&image)
-           .arg("--work-dir").arg(&tmpdir(builder))
-           .arg("--output-dir").arg(&distdir(builder))
-           .arg(format!("--package-name={}-{}", name, host))
-           .arg("--component-name=rust-mingw")
-           .arg("--legacy-manifest-dirs=rustlib,cargo");
+            .arg("--product-name=Rust-MinGW")
+            .arg("--rel-manifest-dir=rustlib")
+            .arg("--success-message=Rust-MinGW-is-installed.")
+            .arg("--image-dir")
+            .arg(&image)
+            .arg("--work-dir")
+            .arg(&tmpdir(builder))
+            .arg("--output-dir")
+            .arg(&distdir(builder))
+            .arg(format!("--package-name={}-{}", name, host))
+            .arg("--component-name=rust-mingw")
+            .arg("--legacy-manifest-dirs=rustlib,cargo");
         builder.run(&mut cmd);
         t!(fs::remove_dir_all(&image));
         Some(distdir(builder).join(format!("{}-{}.tar.gz", name, host)))
@@ -396,9 +398,8 @@ fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
     }
 
     fn make_run(run: RunConfig<'_>) {
-        run.builder.ensure(Rustc {
-            compiler: run.builder.compiler(run.builder.top_stage, run.target),
-        });
+        run.builder
+            .ensure(Rustc { compiler: run.builder.compiler(run.builder.top_stage, run.target) });
     }
 
     /// Creates the `rustc` installer component.
@@ -452,16 +453,20 @@ fn run(self, builder: &Builder<'_>) -> PathBuf {
         // Finally, wrap everything up in a nice tarball!
         let mut cmd = rust_installer(builder);
         cmd.arg("generate")
-           .arg("--product-name=Rust")
-           .arg("--rel-manifest-dir=rustlib")
-           .arg("--success-message=Rust-is-ready-to-roll.")
-           .arg("--image-dir").arg(&image)
-           .arg("--work-dir").arg(&tmpdir(builder))
-           .arg("--output-dir").arg(&distdir(builder))
-           .arg("--non-installed-overlay").arg(&overlay)
-           .arg(format!("--package-name={}-{}", name, host))
-           .arg("--component-name=rustc")
-           .arg("--legacy-manifest-dirs=rustlib,cargo");
+            .arg("--product-name=Rust")
+            .arg("--rel-manifest-dir=rustlib")
+            .arg("--success-message=Rust-is-ready-to-roll.")
+            .arg("--image-dir")
+            .arg(&image)
+            .arg("--work-dir")
+            .arg(&tmpdir(builder))
+            .arg("--output-dir")
+            .arg(&distdir(builder))
+            .arg("--non-installed-overlay")
+            .arg(&overlay)
+            .arg(format!("--package-name={}-{}", name, host))
+            .arg("--component-name=rustc")
+            .arg("--legacy-manifest-dirs=rustlib,cargo");
 
         builder.info(&format!("Dist rustc stage{} ({})", compiler.stage, host));
         let _time = timeit(builder);
@@ -498,16 +503,6 @@ fn prepare_image(builder: &Builder<'_>, compiler: Compiler, image: &Path) {
                 }
             }
 
-            // Copy over the codegen backends
-            let backends_src = builder.sysroot_codegen_backends(compiler);
-            let backends_rel = backends_src.strip_prefix(&src).unwrap()
-                .strip_prefix(builder.sysroot_libdir_relative(compiler)).unwrap();
-            // Don't use custom libdir here because ^lib/ will be resolved again with installer
-            let backends_dst = image.join("lib").join(&backends_rel);
-
-            t!(fs::create_dir_all(&backends_dst));
-            builder.cp_r(&backends_src, &backends_dst);
-
             // Copy libLLVM.so to the lib dir as well, if needed. While not
             // technically needed by rustc itself it's needed by lots of other
             // components like the llvm tools and LLD. LLD is included below and
@@ -518,16 +513,10 @@ fn prepare_image(builder: &Builder<'_>, compiler: Compiler, image: &Path) {
             // Copy over lld if it's there
             if builder.config.lld_enabled {
                 let exe = exe("rust-lld", &compiler.host);
-                let src = builder.sysroot_libdir(compiler, host)
-                    .parent()
-                    .unwrap()
-                    .join("bin")
-                    .join(&exe);
+                let src =
+                    builder.sysroot_libdir(compiler, host).parent().unwrap().join("bin").join(&exe);
                 // for the rationale about this rename check `compile::copy_lld_to_sysroot`
-                let dst = image.join("lib/rustlib")
-                    .join(&*host)
-                    .join("bin")
-                    .join(&exe);
+                let dst = image.join("lib/rustlib").join(&*host).join("bin").join(&exe);
                 t!(fs::create_dir_all(&dst.parent().unwrap()));
                 builder.copy(&src, &dst);
             }
@@ -540,9 +529,10 @@ fn prepare_image(builder: &Builder<'_>, compiler: Compiler, image: &Path) {
             // Reproducible builds: If SOURCE_DATE_EPOCH is set, use that as the time.
             let time = env::var("SOURCE_DATE_EPOCH")
                 .map(|timestamp| {
-                    let epoch = timestamp.parse().map_err(|err| {
-                        format!("could not parse SOURCE_DATE_EPOCH: {}", err)
-                    }).unwrap();
+                    let epoch = timestamp
+                        .parse()
+                        .map_err(|err| format!("could not parse SOURCE_DATE_EPOCH: {}", err))
+                        .unwrap();
 
                     time::at(Timespec::new(epoch, 0))
                 })
@@ -556,16 +546,18 @@ fn prepare_image(builder: &Builder<'_>, compiler: Compiler, image: &Path) {
                 let page_dst = man_dst.join(file_entry.file_name());
                 t!(fs::copy(&page_src, &page_dst));
                 // template in month/year and version number
-                builder.replace_in_file(&page_dst,
-                                &[("<INSERT DATE HERE>", &month_year),
-                                  ("<INSERT VERSION HERE>", channel::CFG_RELEASE_NUM)]);
+                builder.replace_in_file(
+                    &page_dst,
+                    &[
+                        ("<INSERT DATE HERE>", &month_year),
+                        ("<INSERT VERSION HERE>", channel::CFG_RELEASE_NUM),
+                    ],
+                );
             }
 
             // Debugger scripts
-            builder.ensure(DebuggerScripts {
-                sysroot: INTERNER.intern_path(image.to_owned()),
-                host,
-            });
+            builder
+                .ensure(DebuggerScripts { sysroot: INTERNER.intern_path(image.to_owned()), host });
 
             // Misc license info
             let cp = |file: &str| {
@@ -610,8 +602,11 @@ fn run(self, builder: &Builder<'_>) {
         };
         if host.contains("windows-msvc") {
             // windbg debugger scripts
-            builder.install(&builder.src.join("src/etc/rust-windbg.cmd"), &sysroot.join("bin"),
-                0o755);
+            builder.install(
+                &builder.src.join("src/etc/rust-windbg.cmd"),
+                &sysroot.join("bin"),
+                0o755,
+            );
 
             cp_debugger_script("natvis/intrinsic.natvis");
             cp_debugger_script("natvis/liballoc.natvis");
@@ -621,17 +616,14 @@ fn run(self, builder: &Builder<'_>) {
             cp_debugger_script("debugger_pretty_printers_common.py");
 
             // gdb debugger scripts
-            builder.install(&builder.src.join("src/etc/rust-gdb"), &sysroot.join("bin"),
-                    0o755);
-            builder.install(&builder.src.join("src/etc/rust-gdbgui"), &sysroot.join("bin"),
-                    0o755);
+            builder.install(&builder.src.join("src/etc/rust-gdb"), &sysroot.join("bin"), 0o755);
+            builder.install(&builder.src.join("src/etc/rust-gdbgui"), &sysroot.join("bin"), 0o755);
 
             cp_debugger_script("gdb_load_rust_pretty_printers.py");
             cp_debugger_script("gdb_rust_pretty_printing.py");
 
             // lldb debugger scripts
-            builder.install(&builder.src.join("src/etc/rust-lldb"), &sysroot.join("bin"),
-                    0o755);
+            builder.install(&builder.src.join("src/etc/rust-lldb"), &sysroot.join("bin"), 0o755);
 
             cp_debugger_script("lldb_rust_formatters.py");
         }
@@ -706,18 +698,21 @@ fn run(self, builder: &Builder<'_>) -> PathBuf {
 
         let mut cmd = rust_installer(builder);
         cmd.arg("generate")
-           .arg("--product-name=Rust")
-           .arg("--rel-manifest-dir=rustlib")
-           .arg("--success-message=std-is-standing-at-the-ready.")
-           .arg("--image-dir").arg(&image)
-           .arg("--work-dir").arg(&tmpdir(builder))
-           .arg("--output-dir").arg(&distdir(builder))
-           .arg(format!("--package-name={}-{}", name, target))
-           .arg(format!("--component-name=rust-std-{}", target))
-           .arg("--legacy-manifest-dirs=rustlib,cargo");
-
-        builder.info(&format!("Dist std stage{} ({} -> {})",
-            compiler.stage, &compiler.host, target));
+            .arg("--product-name=Rust")
+            .arg("--rel-manifest-dir=rustlib")
+            .arg("--success-message=std-is-standing-at-the-ready.")
+            .arg("--image-dir")
+            .arg(&image)
+            .arg("--work-dir")
+            .arg(&tmpdir(builder))
+            .arg("--output-dir")
+            .arg(&distdir(builder))
+            .arg(format!("--package-name={}-{}", name, target))
+            .arg(format!("--component-name=rust-std-{}", target))
+            .arg("--legacy-manifest-dirs=rustlib,cargo");
+
+        builder
+            .info(&format!("Dist std stage{} ({} -> {})", compiler.stage, &compiler.host, target));
         let _time = timeit(builder);
         builder.run(&mut cmd);
         builder.remove_dir(&image);
@@ -772,18 +767,23 @@ fn run(self, builder: &Builder<'_>) -> PathBuf {
 
         let mut cmd = rust_installer(builder);
         cmd.arg("generate")
-           .arg("--product-name=Rust")
-           .arg("--rel-manifest-dir=rustlib")
-           .arg("--success-message=Rust-is-ready-to-develop.")
-           .arg("--image-dir").arg(&image)
-           .arg("--work-dir").arg(&tmpdir(builder))
-           .arg("--output-dir").arg(&distdir(builder))
-           .arg(format!("--package-name={}-{}", name, target))
-           .arg(format!("--component-name=rustc-dev-{}", target))
-           .arg("--legacy-manifest-dirs=rustlib,cargo");
-
-        builder.info(&format!("Dist rustc-dev stage{} ({} -> {})",
-            compiler.stage, &compiler.host, target));
+            .arg("--product-name=Rust")
+            .arg("--rel-manifest-dir=rustlib")
+            .arg("--success-message=Rust-is-ready-to-develop.")
+            .arg("--image-dir")
+            .arg(&image)
+            .arg("--work-dir")
+            .arg(&tmpdir(builder))
+            .arg("--output-dir")
+            .arg(&distdir(builder))
+            .arg(format!("--package-name={}-{}", name, target))
+            .arg(format!("--component-name=rustc-dev-{}", target))
+            .arg("--legacy-manifest-dirs=rustlib,cargo");
+
+        builder.info(&format!(
+            "Dist rustc-dev stage{} ({} -> {})",
+            compiler.stage, &compiler.host, target
+        ));
         let _time = timeit(builder);
         builder.run(&mut cmd);
         builder.remove_dir(&image);
@@ -835,8 +835,11 @@ fn run(self, builder: &Builder<'_>) -> PathBuf {
 
         let image = tmpdir(builder).join(format!("{}-{}-image", name, target));
 
-        let src = builder.stage_out(compiler, Mode::Std)
-            .join(target).join(builder.cargo_dir()).join("deps");
+        let src = builder
+            .stage_out(compiler, Mode::Std)
+            .join(target)
+            .join(builder.cargo_dir())
+            .join("deps");
 
         let image_src = src.join("save-analysis");
         let dst = image.join("lib/rustlib").join(target).join("analysis");
@@ -846,15 +849,18 @@ fn run(self, builder: &Builder<'_>) -> PathBuf {
 
         let mut cmd = rust_installer(builder);
         cmd.arg("generate")
-           .arg("--product-name=Rust")
-           .arg("--rel-manifest-dir=rustlib")
-           .arg("--success-message=save-analysis-saved.")
-           .arg("--image-dir").arg(&image)
-           .arg("--work-dir").arg(&tmpdir(builder))
-           .arg("--output-dir").arg(&distdir(builder))
-           .arg(format!("--package-name={}-{}", name, target))
-           .arg(format!("--component-name=rust-analysis-{}", target))
-           .arg("--legacy-manifest-dirs=rustlib,cargo");
+            .arg("--product-name=Rust")
+            .arg("--rel-manifest-dir=rustlib")
+            .arg("--success-message=save-analysis-saved.")
+            .arg("--image-dir")
+            .arg(&image)
+            .arg("--work-dir")
+            .arg(&tmpdir(builder))
+            .arg("--output-dir")
+            .arg(&distdir(builder))
+            .arg(format!("--package-name={}-{}", name, target))
+            .arg(format!("--component-name=rust-analysis-{}", target))
+            .arg("--legacy-manifest-dirs=rustlib,cargo");
 
         builder.info("Dist analysis");
         let _time = timeit(builder);
@@ -871,31 +877,35 @@ fn filter_fn(exclude_dirs: &[&str], dir: &str, path: &Path) -> bool {
             None => return false,
         };
         if spath.ends_with("~") || spath.ends_with(".pyc") {
-            return false
+            return false;
         }
 
         const LLVM_PROJECTS: &[&str] = &[
-            "llvm-project/clang", "llvm-project\\clang",
-            "llvm-project/libunwind", "llvm-project\\libunwind",
-            "llvm-project/lld", "llvm-project\\lld",
-            "llvm-project/lldb", "llvm-project\\lldb",
-            "llvm-project/llvm", "llvm-project\\llvm",
-            "llvm-project/compiler-rt", "llvm-project\\compiler-rt",
+            "llvm-project/clang",
+            "llvm-project\\clang",
+            "llvm-project/libunwind",
+            "llvm-project\\libunwind",
+            "llvm-project/lld",
+            "llvm-project\\lld",
+            "llvm-project/lldb",
+            "llvm-project\\lldb",
+            "llvm-project/llvm",
+            "llvm-project\\llvm",
+            "llvm-project/compiler-rt",
+            "llvm-project\\compiler-rt",
         ];
-        if spath.contains("llvm-project") && !spath.ends_with("llvm-project")
+        if spath.contains("llvm-project")
+            && !spath.ends_with("llvm-project")
             && !LLVM_PROJECTS.iter().any(|path| spath.contains(path))
         {
             return false;
         }
 
-        const LLVM_TEST: &[&str] = &[
-            "llvm-project/llvm/test", "llvm-project\\llvm\\test",
-        ];
-        if LLVM_TEST.iter().any(|path| spath.contains(path)) &&
-            (spath.ends_with(".ll") ||
-             spath.ends_with(".td") ||
-             spath.ends_with(".s")) {
-            return false
+        const LLVM_TEST: &[&str] = &["llvm-project/llvm/test", "llvm-project\\llvm\\test"];
+        if LLVM_TEST.iter().any(|path| spath.contains(path))
+            && (spath.ends_with(".ll") || spath.ends_with(".td") || spath.ends_with(".s"))
+        {
+            return false;
         }
 
         let full_path = Path::new(dir).join(path);
@@ -904,22 +914,37 @@ fn filter_fn(exclude_dirs: &[&str], dir: &str, path: &Path) -> bool {
         }
 
         let excludes = [
-            "CVS", "RCS", "SCCS", ".git", ".gitignore", ".gitmodules",
-            ".gitattributes", ".cvsignore", ".svn", ".arch-ids", "{arch}",
-            "=RELEASE-ID", "=meta-update", "=update", ".bzr", ".bzrignore",
-            ".bzrtags", ".hg", ".hgignore", ".hgrags", "_darcs",
+            "CVS",
+            "RCS",
+            "SCCS",
+            ".git",
+            ".gitignore",
+            ".gitmodules",
+            ".gitattributes",
+            ".cvsignore",
+            ".svn",
+            ".arch-ids",
+            "{arch}",
+            "=RELEASE-ID",
+            "=meta-update",
+            "=update",
+            ".bzr",
+            ".bzrignore",
+            ".bzrtags",
+            ".hg",
+            ".hgignore",
+            ".hgrags",
+            "_darcs",
         ];
-        !path.iter()
-             .map(|s| s.to_str().unwrap())
-             .any(|s| excludes.contains(&s))
+        !path.iter().map(|s| s.to_str().unwrap()).any(|s| excludes.contains(&s))
     }
 
     // Copy the directories using our filter
     for item in src_dirs {
         let dst = &dst_dir.join(item);
         t!(fs::create_dir_all(dst));
-        builder.cp_filtered(
-            &builder.src.join(item), dst, &|path| filter_fn(exclude_dirs, item, path));
+        builder
+            .cp_filtered(&builder.src.join(item), dst, &|path| filter_fn(exclude_dirs, item, path));
     }
 }
 
@@ -950,9 +975,7 @@ fn run(self, builder: &Builder<'_>) -> PathBuf {
         let dst_src = dst.join("rust");
         t!(fs::create_dir_all(&dst_src));
 
-        let src_files = [
-            "Cargo.lock",
-        ];
+        let src_files = ["Cargo.lock"];
         // This is the reduced set of paths which will become the rust-src component
         // (essentially libstd and all of its path dependencies)
         let std_src_dirs = [
@@ -961,10 +984,6 @@ fn run(self, builder: &Builder<'_>) -> PathBuf {
             "src/libcore",
             "src/libpanic_abort",
             "src/libpanic_unwind",
-            "src/librustc_asan",
-            "src/librustc_lsan",
-            "src/librustc_msan",
-            "src/librustc_tsan",
             "src/libstd",
             "src/libunwind",
             "src/libtest",
@@ -987,15 +1006,18 @@ fn run(self, builder: &Builder<'_>) -> PathBuf {
         // Create source tarball in rust-installer format
         let mut cmd = rust_installer(builder);
         cmd.arg("generate")
-           .arg("--product-name=Rust")
-           .arg("--rel-manifest-dir=rustlib")
-           .arg("--success-message=Awesome-Source.")
-           .arg("--image-dir").arg(&image)
-           .arg("--work-dir").arg(&tmpdir(builder))
-           .arg("--output-dir").arg(&distdir(builder))
-           .arg(format!("--package-name={}", name))
-           .arg("--component-name=rust-src")
-           .arg("--legacy-manifest-dirs=rustlib,cargo");
+            .arg("--product-name=Rust")
+            .arg("--rel-manifest-dir=rustlib")
+            .arg("--success-message=Awesome-Source.")
+            .arg("--image-dir")
+            .arg(&image)
+            .arg("--work-dir")
+            .arg(&tmpdir(builder))
+            .arg("--output-dir")
+            .arg(&distdir(builder))
+            .arg(format!("--package-name={}", name))
+            .arg("--component-name=rust-src")
+            .arg("--legacy-manifest-dirs=rustlib,cargo");
 
         builder.info("Dist src");
         let _time = timeit(builder);
@@ -1046,9 +1068,7 @@ fn run(self, builder: &Builder<'_>) -> PathBuf {
             "Cargo.toml",
             "Cargo.lock",
         ];
-        let src_dirs = [
-            "src",
-        ];
+        let src_dirs = ["src"];
 
         copy_src_dirs(builder, &src_dirs[..], &[], &plain_dst_src);
 
@@ -1067,8 +1087,7 @@ fn run(self, builder: &Builder<'_>) -> PathBuf {
         if builder.rust_info.is_git() {
             // Vendor all Cargo dependencies
             let mut cmd = Command::new(&builder.initial_cargo);
-            cmd.arg("vendor")
-               .current_dir(&plain_dst_src);
+            cmd.arg("vendor").current_dir(&plain_dst_src);
             builder.run(&mut cmd);
         }
 
@@ -1083,10 +1102,12 @@ fn run(self, builder: &Builder<'_>) -> PathBuf {
         builder.info("running installer");
         let mut cmd = rust_installer(builder);
         cmd.arg("tarball")
-           .arg("--input").arg(&plain_name)
-           .arg("--output").arg(&tarball)
-           .arg("--work-dir=.")
-           .current_dir(tmpdir(builder));
+            .arg("--input")
+            .arg(&plain_name)
+            .arg("--output")
+            .arg(&tarball)
+            .arg("--work-dir=.")
+            .current_dir(tmpdir(builder));
 
         builder.info("Create plain source tarball");
         let _time = timeit(builder);
@@ -1105,10 +1126,10 @@ fn change_drive(s: &str) -> Option<String> {
         let mut ch = s.chars();
         let drive = ch.next().unwrap_or('C');
         if ch.next() != Some(':') {
-            return None
+            return None;
         }
         if ch.next() != Some('/') {
-            return None
+            return None;
         }
         Some(format!("/{}/{}", drive, &s[drive.len_utf8() + 2..]))
     }
@@ -1164,8 +1185,7 @@ fn run(self, builder: &Builder<'_>) -> PathBuf {
             builder.install(&man.path(), &image.join("share/man/man1"), 0o644);
         }
         builder.install(&etc.join("_cargo"), &image.join("share/zsh/site-functions"), 0o644);
-        builder.copy(&etc.join("cargo.bashcomp.sh"),
-             &image.join("etc/bash_completion.d/cargo"));
+        builder.copy(&etc.join("cargo.bashcomp.sh"), &image.join("etc/bash_completion.d/cargo"));
         let doc = image.join("share/doc/cargo");
         builder.install(&src.join("README.md"), &doc, 0o644);
         builder.install(&src.join("LICENSE-MIT"), &doc, 0o644);
@@ -1185,16 +1205,20 @@ fn run(self, builder: &Builder<'_>) -> PathBuf {
         // Generate the installer tarball
         let mut cmd = rust_installer(builder);
         cmd.arg("generate")
-           .arg("--product-name=Rust")
-           .arg("--rel-manifest-dir=rustlib")
-           .arg("--success-message=Rust-is-ready-to-roll.")
-           .arg("--image-dir").arg(&image)
-           .arg("--work-dir").arg(&tmpdir(builder))
-           .arg("--output-dir").arg(&distdir(builder))
-           .arg("--non-installed-overlay").arg(&overlay)
-           .arg(format!("--package-name={}-{}", name, target))
-           .arg("--component-name=cargo")
-           .arg("--legacy-manifest-dirs=rustlib,cargo");
+            .arg("--product-name=Rust")
+            .arg("--rel-manifest-dir=rustlib")
+            .arg("--success-message=Rust-is-ready-to-roll.")
+            .arg("--image-dir")
+            .arg(&image)
+            .arg("--work-dir")
+            .arg(&tmpdir(builder))
+            .arg("--output-dir")
+            .arg(&distdir(builder))
+            .arg("--non-installed-overlay")
+            .arg(&overlay)
+            .arg(format!("--package-name={}-{}", name, target))
+            .arg("--component-name=cargo")
+            .arg("--legacy-manifest-dirs=rustlib,cargo");
 
         builder.info(&format!("Dist cargo stage{} ({})", compiler.stage, target));
         let _time = timeit(builder);
@@ -1246,11 +1270,12 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
         // Prepare the image directory
         // We expect RLS to build, because we've exited this step above if tool
         // state for RLS isn't testing.
-        let rls = builder.ensure(tool::Rls {
-            compiler,
-            target,
-            extra_features: Vec::new(),
-        }).or_else(|| { missing_tool("RLS", builder.build.config.missing_tools); None })?;
+        let rls = builder
+            .ensure(tool::Rls { compiler, target, extra_features: Vec::new() })
+            .or_else(|| {
+                missing_tool("RLS", builder.build.config.missing_tools);
+                None
+            })?;
 
         builder.install(&rls, &image.join("bin"), 0o755);
         let doc = image.join("share/doc/rls");
@@ -1270,16 +1295,20 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
         // Generate the installer tarball
         let mut cmd = rust_installer(builder);
         cmd.arg("generate")
-           .arg("--product-name=Rust")
-           .arg("--rel-manifest-dir=rustlib")
-           .arg("--success-message=RLS-ready-to-serve.")
-           .arg("--image-dir").arg(&image)
-           .arg("--work-dir").arg(&tmpdir(builder))
-           .arg("--output-dir").arg(&distdir(builder))
-           .arg("--non-installed-overlay").arg(&overlay)
-           .arg(format!("--package-name={}-{}", name, target))
-           .arg("--legacy-manifest-dirs=rustlib,cargo")
-           .arg("--component-name=rls-preview");
+            .arg("--product-name=Rust")
+            .arg("--rel-manifest-dir=rustlib")
+            .arg("--success-message=RLS-ready-to-serve.")
+            .arg("--image-dir")
+            .arg(&image)
+            .arg("--work-dir")
+            .arg(&tmpdir(builder))
+            .arg("--output-dir")
+            .arg(&distdir(builder))
+            .arg("--non-installed-overlay")
+            .arg(&overlay)
+            .arg(format!("--package-name={}-{}", name, target))
+            .arg("--legacy-manifest-dirs=rustlib,cargo")
+            .arg("--component-name=rls-preview");
 
         builder.info(&format!("Dist RLS stage{} ({})", compiler.stage, target));
         let _time = timeit(builder);
@@ -1331,15 +1360,18 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
         // Prepare the image directory
         // We expect clippy to build, because we've exited this step above if tool
         // state for clippy isn't testing.
-        let clippy = builder.ensure(tool::Clippy {
-            compiler,
-            target,
-            extra_features: Vec::new(),
-        }).or_else(|| { missing_tool("clippy", builder.build.config.missing_tools); None })?;
-        let cargoclippy = builder.ensure(tool::CargoClippy {
-            compiler,
-            target, extra_features: Vec::new()
-        }).or_else(|| { missing_tool("cargo clippy", builder.build.config.missing_tools); None })?;
+        let clippy = builder
+            .ensure(tool::Clippy { compiler, target, extra_features: Vec::new() })
+            .or_else(|| {
+                missing_tool("clippy", builder.build.config.missing_tools);
+                None
+            })?;
+        let cargoclippy = builder
+            .ensure(tool::CargoClippy { compiler, target, extra_features: Vec::new() })
+            .or_else(|| {
+                missing_tool("cargo clippy", builder.build.config.missing_tools);
+                None
+            })?;
 
         builder.install(&clippy, &image.join("bin"), 0o755);
         builder.install(&cargoclippy, &image.join("bin"), 0o755);
@@ -1360,16 +1392,20 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
         // Generate the installer tarball
         let mut cmd = rust_installer(builder);
         cmd.arg("generate")
-           .arg("--product-name=Rust")
-           .arg("--rel-manifest-dir=rustlib")
-           .arg("--success-message=clippy-ready-to-serve.")
-           .arg("--image-dir").arg(&image)
-           .arg("--work-dir").arg(&tmpdir(builder))
-           .arg("--output-dir").arg(&distdir(builder))
-           .arg("--non-installed-overlay").arg(&overlay)
-           .arg(format!("--package-name={}-{}", name, target))
-           .arg("--legacy-manifest-dirs=rustlib,cargo")
-           .arg("--component-name=clippy-preview");
+            .arg("--product-name=Rust")
+            .arg("--rel-manifest-dir=rustlib")
+            .arg("--success-message=clippy-ready-to-serve.")
+            .arg("--image-dir")
+            .arg(&image)
+            .arg("--work-dir")
+            .arg(&tmpdir(builder))
+            .arg("--output-dir")
+            .arg(&distdir(builder))
+            .arg("--non-installed-overlay")
+            .arg(&overlay)
+            .arg(format!("--package-name={}-{}", name, target))
+            .arg("--legacy-manifest-dirs=rustlib,cargo")
+            .arg("--component-name=clippy-preview");
 
         builder.info(&format!("Dist clippy stage{} ({})", compiler.stage, target));
         let _time = timeit(builder);
@@ -1421,16 +1457,18 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
         // Prepare the image directory
         // We expect miri to build, because we've exited this step above if tool
         // state for miri isn't testing.
-        let miri = builder.ensure(tool::Miri {
-            compiler,
-            target,
-            extra_features: Vec::new(),
-        }).or_else(|| { missing_tool("miri", builder.build.config.missing_tools); None })?;
-        let cargomiri = builder.ensure(tool::CargoMiri {
-            compiler,
-            target,
-            extra_features: Vec::new()
-        }).or_else(|| { missing_tool("cargo miri", builder.build.config.missing_tools); None })?;
+        let miri = builder
+            .ensure(tool::Miri { compiler, target, extra_features: Vec::new() })
+            .or_else(|| {
+                missing_tool("miri", builder.build.config.missing_tools);
+                None
+            })?;
+        let cargomiri = builder
+            .ensure(tool::CargoMiri { compiler, target, extra_features: Vec::new() })
+            .or_else(|| {
+                missing_tool("cargo miri", builder.build.config.missing_tools);
+                None
+            })?;
 
         builder.install(&miri, &image.join("bin"), 0o755);
         builder.install(&cargomiri, &image.join("bin"), 0o755);
@@ -1451,16 +1489,20 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
         // Generate the installer tarball
         let mut cmd = rust_installer(builder);
         cmd.arg("generate")
-           .arg("--product-name=Rust")
-           .arg("--rel-manifest-dir=rustlib")
-           .arg("--success-message=miri-ready-to-serve.")
-           .arg("--image-dir").arg(&image)
-           .arg("--work-dir").arg(&tmpdir(builder))
-           .arg("--output-dir").arg(&distdir(builder))
-           .arg("--non-installed-overlay").arg(&overlay)
-           .arg(format!("--package-name={}-{}", name, target))
-           .arg("--legacy-manifest-dirs=rustlib,cargo")
-           .arg("--component-name=miri-preview");
+            .arg("--product-name=Rust")
+            .arg("--rel-manifest-dir=rustlib")
+            .arg("--success-message=miri-ready-to-serve.")
+            .arg("--image-dir")
+            .arg(&image)
+            .arg("--work-dir")
+            .arg(&tmpdir(builder))
+            .arg("--output-dir")
+            .arg(&distdir(builder))
+            .arg("--non-installed-overlay")
+            .arg(&overlay)
+            .arg(format!("--package-name={}-{}", name, target))
+            .arg("--legacy-manifest-dirs=rustlib,cargo")
+            .arg("--component-name=miri-preview");
 
         builder.info(&format!("Dist miri stage{} ({})", compiler.stage, target));
         let _time = timeit(builder);
@@ -1509,16 +1551,18 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
         builder.create_dir(&image);
 
         // Prepare the image directory
-        let rustfmt = builder.ensure(tool::Rustfmt {
-            compiler,
-            target,
-            extra_features: Vec::new(),
-        }).or_else(|| { missing_tool("Rustfmt", builder.build.config.missing_tools); None })?;
-        let cargofmt = builder.ensure(tool::Cargofmt {
-            compiler,
-            target,
-            extra_features: Vec::new(),
-        }).or_else(|| { missing_tool("Cargofmt", builder.build.config.missing_tools); None })?;
+        let rustfmt = builder
+            .ensure(tool::Rustfmt { compiler, target, extra_features: Vec::new() })
+            .or_else(|| {
+                missing_tool("Rustfmt", builder.build.config.missing_tools);
+                None
+            })?;
+        let cargofmt = builder
+            .ensure(tool::Cargofmt { compiler, target, extra_features: Vec::new() })
+            .or_else(|| {
+                missing_tool("Cargofmt", builder.build.config.missing_tools);
+                None
+            })?;
 
         builder.install(&rustfmt, &image.join("bin"), 0o755);
         builder.install(&cargofmt, &image.join("bin"), 0o755);
@@ -1539,16 +1583,20 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
         // Generate the installer tarball
         let mut cmd = rust_installer(builder);
         cmd.arg("generate")
-           .arg("--product-name=Rust")
-           .arg("--rel-manifest-dir=rustlib")
-           .arg("--success-message=rustfmt-ready-to-fmt.")
-           .arg("--image-dir").arg(&image)
-           .arg("--work-dir").arg(&tmpdir(builder))
-           .arg("--output-dir").arg(&distdir(builder))
-           .arg("--non-installed-overlay").arg(&overlay)
-           .arg(format!("--package-name={}-{}", name, target))
-           .arg("--legacy-manifest-dirs=rustlib,cargo")
-           .arg("--component-name=rustfmt-preview");
+            .arg("--product-name=Rust")
+            .arg("--rel-manifest-dir=rustlib")
+            .arg("--success-message=rustfmt-ready-to-fmt.")
+            .arg("--image-dir")
+            .arg(&image)
+            .arg("--work-dir")
+            .arg(&tmpdir(builder))
+            .arg("--output-dir")
+            .arg(&distdir(builder))
+            .arg("--non-installed-overlay")
+            .arg(&overlay)
+            .arg(format!("--package-name={}-{}", name, target))
+            .arg("--legacy-manifest-dirs=rustlib,cargo")
+            .arg("--component-name=rustfmt-preview");
 
         builder.info(&format!("Dist Rustfmt stage{} ({})", compiler.stage, target));
         let _time = timeit(builder);
@@ -1590,9 +1638,7 @@ fn run(self, builder: &Builder<'_>) {
 
         builder.info(&format!("Dist extended stage{} ({})", compiler.stage, target));
 
-        let rustc_installer = builder.ensure(Rustc {
-            compiler: builder.compiler(stage, target),
-        });
+        let rustc_installer = builder.ensure(Rustc { compiler: builder.compiler(stage, target) });
         let cargo_installer = builder.ensure(Cargo { compiler, target });
         let rustfmt_installer = builder.ensure(Rustfmt { compiler, target });
         let rls_installer = builder.ensure(Rls { compiler, target });
@@ -1603,11 +1649,9 @@ fn run(self, builder: &Builder<'_>) {
         let mingw_installer = builder.ensure(Mingw { host: target });
         let analysis_installer = builder.ensure(Analysis { compiler, target });
 
-        let docs_installer = builder.ensure(Docs { host: target, });
-        let std_installer = builder.ensure(Std {
-            compiler: builder.compiler(stage, target),
-            target,
-        });
+        let docs_installer = builder.ensure(Docs { host: target });
+        let std_installer =
+            builder.ensure(Std { compiler: builder.compiler(stage, target), target });
 
         let tmp = tmpdir(builder);
         let overlay = tmp.join("extended-overlay");
@@ -1658,12 +1702,16 @@ fn run(self, builder: &Builder<'_>) {
             .arg("--product-name=Rust")
             .arg("--rel-manifest-dir=rustlib")
             .arg("--success-message=Rust-is-ready-to-roll.")
-            .arg("--work-dir").arg(&work)
-            .arg("--output-dir").arg(&distdir(builder))
+            .arg("--work-dir")
+            .arg(&work)
+            .arg("--output-dir")
+            .arg(&distdir(builder))
             .arg(format!("--package-name={}-{}", pkgname(builder, "rust"), target))
             .arg("--legacy-manifest-dirs=rustlib,cargo")
-            .arg("--input-tarballs").arg(input_tarballs)
-            .arg("--non-installed-overlay").arg(&overlay);
+            .arg("--input-tarballs")
+            .arg(input_tarballs)
+            .arg("--non-installed-overlay")
+            .arg(&overlay);
         let time = timeit(&builder);
         builder.run(&mut cmd);
         drop(time);
@@ -1728,8 +1776,10 @@ fn filter(contents: &str, marker: &str) -> String {
 
             let pkgbuild = |component: &str| {
                 let mut cmd = Command::new("pkgbuild");
-                cmd.arg("--identifier").arg(format!("org.rust-lang.{}", component))
-                    .arg("--scripts").arg(pkg.join(component))
+                cmd.arg("--identifier")
+                    .arg(format!("org.rust-lang.{}", component))
+                    .arg("--scripts")
+                    .arg(pkg.join(component))
                     .arg("--nopayload")
                     .arg(pkg.join(component).with_extension("pkg"));
                 builder.run(&mut cmd);
@@ -1737,8 +1787,10 @@ fn filter(contents: &str, marker: &str) -> String {
 
             let prepare = |name: &str| {
                 builder.create_dir(&pkg.join(name));
-                builder.cp_r(&work.join(&format!("{}-{}", pkgname(builder, name), target)),
-                        &pkg.join(name));
+                builder.cp_r(
+                    &work.join(&format!("{}-{}", pkgname(builder, name), target)),
+                    &pkg.join(name),
+                );
                 builder.install(&etc.join("pkg/postinstall"), &pkg.join(name), 0o755);
                 pkgbuild(name);
             };
@@ -1766,12 +1818,13 @@ fn filter(contents: &str, marker: &str) -> String {
             builder.create(&pkg.join("res/LICENSE.txt"), &license);
             builder.install(&etc.join("gfx/rust-logo.png"), &pkg.join("res"), 0o644);
             let mut cmd = Command::new("productbuild");
-            cmd.arg("--distribution").arg(xform(&etc.join("pkg/Distribution.xml")))
-                .arg("--resources").arg(pkg.join("res"))
-                .arg(distdir(builder).join(format!("{}-{}.pkg",
-                                                    pkgname(builder, "rust"),
-                                                    target)))
-                .arg("--package-path").arg(&pkg);
+            cmd.arg("--distribution")
+                .arg(xform(&etc.join("pkg/Distribution.xml")))
+                .arg("--resources")
+                .arg(pkg.join("res"))
+                .arg(distdir(builder).join(format!("{}-{}.pkg", pkgname(builder, "rust"), target)))
+                .arg("--package-path")
+                .arg(&pkg);
             let _time = timeit(builder);
             builder.run(&mut cmd);
         }
@@ -1793,9 +1846,10 @@ fn filter(contents: &str, marker: &str) -> String {
                 } else {
                     name.to_string()
                 };
-                builder.cp_r(&work.join(&format!("{}-{}", pkgname(builder, name), target))
-                            .join(dir),
-                        &exe.join(name));
+                builder.cp_r(
+                    &work.join(&format!("{}-{}", pkgname(builder, name), target)).join(dir),
+                    &exe.join(name),
+                );
                 builder.remove(&exe.join(name).join("manifest.in"));
             };
             prepare("rustc");
@@ -1825,9 +1879,7 @@ fn filter(contents: &str, marker: &str) -> String {
             // Generate exe installer
             builder.info("building `exe` installer with `iscc`");
             let mut cmd = Command::new("iscc");
-            cmd.arg("rust.iss")
-                .arg("/Q")
-                .current_dir(&exe);
+            cmd.arg("rust.iss").arg("/Q").current_dir(&exe);
             if target.contains("windows-gnu") {
                 cmd.arg("/dMINGW");
             }
@@ -1835,9 +1887,11 @@ fn filter(contents: &str, marker: &str) -> String {
             let time = timeit(builder);
             builder.run(&mut cmd);
             drop(time);
-            builder.install(&exe.join(format!("{}-{}.exe", pkgname(builder, "rust"), target)),
-                    &distdir(builder),
-                    0o755);
+            builder.install(
+                &exe.join(format!("{}-{}.exe", pkgname(builder, "rust"), target)),
+                &distdir(builder),
+                0o755,
+            );
 
             // Generate msi installer
             let wix = PathBuf::from(env::var_os("WIX").unwrap());
@@ -1846,106 +1900,165 @@ fn filter(contents: &str, marker: &str) -> String {
             let light = wix.join("bin/light.exe");
 
             let heat_flags = ["-nologo", "-gg", "-sfrag", "-srd", "-sreg"];
-            builder.run(Command::new(&heat)
-                            .current_dir(&exe)
-                            .arg("dir")
-                            .arg("rustc")
-                            .args(&heat_flags)
-                            .arg("-cg").arg("RustcGroup")
-                            .arg("-dr").arg("Rustc")
-                            .arg("-var").arg("var.RustcDir")
-                            .arg("-out").arg(exe.join("RustcGroup.wxs")));
-            builder.run(Command::new(&heat)
-                            .current_dir(&exe)
-                            .arg("dir")
-                            .arg("rust-docs")
-                            .args(&heat_flags)
-                            .arg("-cg").arg("DocsGroup")
-                            .arg("-dr").arg("Docs")
-                            .arg("-var").arg("var.DocsDir")
-                            .arg("-out").arg(exe.join("DocsGroup.wxs"))
-                            .arg("-t").arg(etc.join("msi/squash-components.xsl")));
-            builder.run(Command::new(&heat)
-                            .current_dir(&exe)
-                            .arg("dir")
-                            .arg("cargo")
-                            .args(&heat_flags)
-                            .arg("-cg").arg("CargoGroup")
-                            .arg("-dr").arg("Cargo")
-                            .arg("-var").arg("var.CargoDir")
-                            .arg("-out").arg(exe.join("CargoGroup.wxs"))
-                            .arg("-t").arg(etc.join("msi/remove-duplicates.xsl")));
-            builder.run(Command::new(&heat)
-                            .current_dir(&exe)
-                            .arg("dir")
-                            .arg("rust-std")
-                            .args(&heat_flags)
-                            .arg("-cg").arg("StdGroup")
-                            .arg("-dr").arg("Std")
-                            .arg("-var").arg("var.StdDir")
-                            .arg("-out").arg(exe.join("StdGroup.wxs")));
+            builder.run(
+                Command::new(&heat)
+                    .current_dir(&exe)
+                    .arg("dir")
+                    .arg("rustc")
+                    .args(&heat_flags)
+                    .arg("-cg")
+                    .arg("RustcGroup")
+                    .arg("-dr")
+                    .arg("Rustc")
+                    .arg("-var")
+                    .arg("var.RustcDir")
+                    .arg("-out")
+                    .arg(exe.join("RustcGroup.wxs")),
+            );
+            builder.run(
+                Command::new(&heat)
+                    .current_dir(&exe)
+                    .arg("dir")
+                    .arg("rust-docs")
+                    .args(&heat_flags)
+                    .arg("-cg")
+                    .arg("DocsGroup")
+                    .arg("-dr")
+                    .arg("Docs")
+                    .arg("-var")
+                    .arg("var.DocsDir")
+                    .arg("-out")
+                    .arg(exe.join("DocsGroup.wxs"))
+                    .arg("-t")
+                    .arg(etc.join("msi/squash-components.xsl")),
+            );
+            builder.run(
+                Command::new(&heat)
+                    .current_dir(&exe)
+                    .arg("dir")
+                    .arg("cargo")
+                    .args(&heat_flags)
+                    .arg("-cg")
+                    .arg("CargoGroup")
+                    .arg("-dr")
+                    .arg("Cargo")
+                    .arg("-var")
+                    .arg("var.CargoDir")
+                    .arg("-out")
+                    .arg(exe.join("CargoGroup.wxs"))
+                    .arg("-t")
+                    .arg(etc.join("msi/remove-duplicates.xsl")),
+            );
+            builder.run(
+                Command::new(&heat)
+                    .current_dir(&exe)
+                    .arg("dir")
+                    .arg("rust-std")
+                    .args(&heat_flags)
+                    .arg("-cg")
+                    .arg("StdGroup")
+                    .arg("-dr")
+                    .arg("Std")
+                    .arg("-var")
+                    .arg("var.StdDir")
+                    .arg("-out")
+                    .arg(exe.join("StdGroup.wxs")),
+            );
             if rls_installer.is_some() {
-                builder.run(Command::new(&heat)
-                                .current_dir(&exe)
-                                .arg("dir")
-                                .arg("rls")
-                                .args(&heat_flags)
-                                .arg("-cg").arg("RlsGroup")
-                                .arg("-dr").arg("Rls")
-                                .arg("-var").arg("var.RlsDir")
-                                .arg("-out").arg(exe.join("RlsGroup.wxs"))
-                                .arg("-t").arg(etc.join("msi/remove-duplicates.xsl")));
+                builder.run(
+                    Command::new(&heat)
+                        .current_dir(&exe)
+                        .arg("dir")
+                        .arg("rls")
+                        .args(&heat_flags)
+                        .arg("-cg")
+                        .arg("RlsGroup")
+                        .arg("-dr")
+                        .arg("Rls")
+                        .arg("-var")
+                        .arg("var.RlsDir")
+                        .arg("-out")
+                        .arg(exe.join("RlsGroup.wxs"))
+                        .arg("-t")
+                        .arg(etc.join("msi/remove-duplicates.xsl")),
+                );
             }
             if clippy_installer.is_some() {
-                builder.run(Command::new(&heat)
-                                .current_dir(&exe)
-                                .arg("dir")
-                                .arg("clippy")
-                                .args(&heat_flags)
-                                .arg("-cg").arg("ClippyGroup")
-                                .arg("-dr").arg("Clippy")
-                                .arg("-var").arg("var.ClippyDir")
-                                .arg("-out").arg(exe.join("ClippyGroup.wxs"))
-                                .arg("-t").arg(etc.join("msi/remove-duplicates.xsl")));
+                builder.run(
+                    Command::new(&heat)
+                        .current_dir(&exe)
+                        .arg("dir")
+                        .arg("clippy")
+                        .args(&heat_flags)
+                        .arg("-cg")
+                        .arg("ClippyGroup")
+                        .arg("-dr")
+                        .arg("Clippy")
+                        .arg("-var")
+                        .arg("var.ClippyDir")
+                        .arg("-out")
+                        .arg(exe.join("ClippyGroup.wxs"))
+                        .arg("-t")
+                        .arg(etc.join("msi/remove-duplicates.xsl")),
+                );
             }
             if miri_installer.is_some() {
-                builder.run(Command::new(&heat)
-                                .current_dir(&exe)
-                                .arg("dir")
-                                .arg("miri")
-                                .args(&heat_flags)
-                                .arg("-cg").arg("MiriGroup")
-                                .arg("-dr").arg("Miri")
-                                .arg("-var").arg("var.MiriDir")
-                                .arg("-out").arg(exe.join("MiriGroup.wxs"))
-                                .arg("-t").arg(etc.join("msi/remove-duplicates.xsl")));
+                builder.run(
+                    Command::new(&heat)
+                        .current_dir(&exe)
+                        .arg("dir")
+                        .arg("miri")
+                        .args(&heat_flags)
+                        .arg("-cg")
+                        .arg("MiriGroup")
+                        .arg("-dr")
+                        .arg("Miri")
+                        .arg("-var")
+                        .arg("var.MiriDir")
+                        .arg("-out")
+                        .arg(exe.join("MiriGroup.wxs"))
+                        .arg("-t")
+                        .arg(etc.join("msi/remove-duplicates.xsl")),
+                );
             }
-            builder.run(Command::new(&heat)
-                            .current_dir(&exe)
-                            .arg("dir")
-                            .arg("rust-analysis")
-                            .args(&heat_flags)
-                            .arg("-cg").arg("AnalysisGroup")
-                            .arg("-dr").arg("Analysis")
-                            .arg("-var").arg("var.AnalysisDir")
-                            .arg("-out").arg(exe.join("AnalysisGroup.wxs"))
-                            .arg("-t").arg(etc.join("msi/remove-duplicates.xsl")));
+            builder.run(
+                Command::new(&heat)
+                    .current_dir(&exe)
+                    .arg("dir")
+                    .arg("rust-analysis")
+                    .args(&heat_flags)
+                    .arg("-cg")
+                    .arg("AnalysisGroup")
+                    .arg("-dr")
+                    .arg("Analysis")
+                    .arg("-var")
+                    .arg("var.AnalysisDir")
+                    .arg("-out")
+                    .arg(exe.join("AnalysisGroup.wxs"))
+                    .arg("-t")
+                    .arg(etc.join("msi/remove-duplicates.xsl")),
+            );
             if target.contains("windows-gnu") {
-                builder.run(Command::new(&heat)
-                                .current_dir(&exe)
-                                .arg("dir")
-                                .arg("rust-mingw")
-                                .args(&heat_flags)
-                                .arg("-cg").arg("GccGroup")
-                                .arg("-dr").arg("Gcc")
-                                .arg("-var").arg("var.GccDir")
-                                .arg("-out").arg(exe.join("GccGroup.wxs")));
+                builder.run(
+                    Command::new(&heat)
+                        .current_dir(&exe)
+                        .arg("dir")
+                        .arg("rust-mingw")
+                        .args(&heat_flags)
+                        .arg("-cg")
+                        .arg("GccGroup")
+                        .arg("-dr")
+                        .arg("Gcc")
+                        .arg("-var")
+                        .arg("var.GccDir")
+                        .arg("-out")
+                        .arg(exe.join("GccGroup.wxs")),
+                );
             }
 
             let candle = |input: &Path| {
-                let output = exe.join(input.file_stem().unwrap())
-                                .with_extension("wixobj");
-                let arch = if target.contains("x86_64") {"x64"} else {"x86"};
+                let output = exe.join(input.file_stem().unwrap()).with_extension("wixobj");
+                let arch = if target.contains("x86_64") { "x64" } else { "x86" };
                 let mut cmd = Command::new(&candle);
                 cmd.current_dir(&exe)
                     .arg("-nologo")
@@ -1954,8 +2067,10 @@ fn filter(contents: &str, marker: &str) -> String {
                     .arg("-dCargoDir=cargo")
                     .arg("-dStdDir=rust-std")
                     .arg("-dAnalysisDir=rust-analysis")
-                    .arg("-arch").arg(&arch)
-                    .arg("-out").arg(&output)
+                    .arg("-arch")
+                    .arg(&arch)
+                    .arg("-out")
+                    .arg(&output)
                     .arg(&input);
                 add_env(builder, &mut cmd, target);
 
@@ -2003,9 +2118,12 @@ fn filter(contents: &str, marker: &str) -> String {
             let filename = format!("{}-{}.msi", pkgname(builder, "rust"), target);
             let mut cmd = Command::new(&light);
             cmd.arg("-nologo")
-                .arg("-ext").arg("WixUIExtension")
-                .arg("-ext").arg("WixUtilExtension")
-                .arg("-out").arg(exe.join(&filename))
+                .arg("-ext")
+                .arg("WixUIExtension")
+                .arg("-ext")
+                .arg("WixUtilExtension")
+                .arg("-out")
+                .arg(exe.join(&filename))
                 .arg("rust.wixobj")
                 .arg("ui.wixobj")
                 .arg("rustwelcomedlg.wixobj")
@@ -2045,29 +2163,27 @@ fn filter(contents: &str, marker: &str) -> String {
 fn add_env(builder: &Builder<'_>, cmd: &mut Command, target: Interned<String>) {
     let mut parts = channel::CFG_RELEASE_NUM.split('.');
     cmd.env("CFG_RELEASE_INFO", builder.rust_version())
-       .env("CFG_RELEASE_NUM", channel::CFG_RELEASE_NUM)
-       .env("CFG_RELEASE", builder.rust_release())
-       .env("CFG_VER_MAJOR", parts.next().unwrap())
-       .env("CFG_VER_MINOR", parts.next().unwrap())
-       .env("CFG_VER_PATCH", parts.next().unwrap())
-       .env("CFG_VER_BUILD", "0") // just needed to build
-       .env("CFG_PACKAGE_VERS", builder.rust_package_vers())
-       .env("CFG_PACKAGE_NAME", pkgname(builder, "rust"))
-       .env("CFG_BUILD", target)
-       .env("CFG_CHANNEL", &builder.config.channel);
+        .env("CFG_RELEASE_NUM", channel::CFG_RELEASE_NUM)
+        .env("CFG_RELEASE", builder.rust_release())
+        .env("CFG_VER_MAJOR", parts.next().unwrap())
+        .env("CFG_VER_MINOR", parts.next().unwrap())
+        .env("CFG_VER_PATCH", parts.next().unwrap())
+        .env("CFG_VER_BUILD", "0") // just needed to build
+        .env("CFG_PACKAGE_VERS", builder.rust_package_vers())
+        .env("CFG_PACKAGE_NAME", pkgname(builder, "rust"))
+        .env("CFG_BUILD", target)
+        .env("CFG_CHANNEL", &builder.config.channel);
 
     if target.contains("windows-gnu") {
-       cmd.env("CFG_MINGW", "1")
-          .env("CFG_ABI", "GNU");
+        cmd.env("CFG_MINGW", "1").env("CFG_ABI", "GNU");
     } else {
-       cmd.env("CFG_MINGW", "0")
-          .env("CFG_ABI", "MSVC");
+        cmd.env("CFG_MINGW", "0").env("CFG_ABI", "MSVC");
     }
 
     if target.contains("x86_64") {
-       cmd.env("CFG_PLATFORM", "x64");
+        cmd.env("CFG_PLATFORM", "x64");
     } else {
-       cmd.env("CFG_PLATFORM", "x86");
+        cmd.env("CFG_PLATFORM", "x86");
     }
 }
 
@@ -2134,23 +2250,27 @@ fn run(self, builder: &Builder<'_>) {
 
 // Maybe add libLLVM.so to the lib-dir. It will only have been built if
 // LLVM tools are linked dynamically.
+//
+// We add this to both the libdir of the rustc binary itself (for it to load at
+// runtime) and also to the target directory so it can find it at link-time.
+//
 // Note: This function does no yet support Windows but we also don't support
 //       linking LLVM tools dynamically on Windows yet.
-pub fn maybe_install_llvm_dylib(builder: &Builder<'_>,
-                                target: Interned<String>,
-                                sysroot: &Path) {
-    let src_libdir = builder
-        .llvm_out(target)
-        .join("lib");
-    let dst_libdir = sysroot.join("lib/rustlib").join(&*target).join("lib");
-    t!(fs::create_dir_all(&dst_libdir));
+pub fn maybe_install_llvm_dylib(builder: &Builder<'_>, target: Interned<String>, sysroot: &Path) {
+    let src_libdir = builder.llvm_out(target).join("lib");
+    let dst_libdir1 = sysroot.join("lib/rustlib").join(&*target).join("lib");
+    let dst_libdir2 =
+        sysroot.join(builder.sysroot_libdir_relative(Compiler { stage: 1, host: target }));
+    t!(fs::create_dir_all(&dst_libdir1));
+    t!(fs::create_dir_all(&dst_libdir2));
 
     if target.contains("apple-darwin") {
         let llvm_dylib_path = src_libdir.join("libLLVM.dylib");
         if llvm_dylib_path.exists() {
-            builder.install(&llvm_dylib_path, &dst_libdir, 0o644);
+            builder.install(&llvm_dylib_path, &dst_libdir1, 0o644);
+            builder.install(&llvm_dylib_path, &dst_libdir2, 0o644);
         }
-        return
+        return;
     }
 
     // Usually libLLVM.so is a symlink to something like libLLVM-6.0.so.
@@ -2159,12 +2279,11 @@ pub fn maybe_install_llvm_dylib(builder: &Builder<'_>,
     let llvm_dylib_path = src_libdir.join("libLLVM.so");
     if llvm_dylib_path.exists() {
         let llvm_dylib_path = llvm_dylib_path.canonicalize().unwrap_or_else(|e| {
-            panic!("dist: Error calling canonicalize path `{}`: {}",
-                   llvm_dylib_path.display(), e);
+            panic!("dist: Error calling canonicalize path `{}`: {}", llvm_dylib_path.display(), e);
         });
 
-
-        builder.install(&llvm_dylib_path, &dst_libdir, 0o644);
+        builder.install(&llvm_dylib_path, &dst_libdir1, 0o644);
+        builder.install(&llvm_dylib_path, &dst_libdir2, 0o644);
     }
 }
 
@@ -2182,9 +2301,7 @@ fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
     }
 
     fn make_run(run: RunConfig<'_>) {
-        run.builder.ensure(LlvmTools {
-            target: run.target,
-        });
+        run.builder.ensure(LlvmTools { target: run.target });
     }
 
     fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
@@ -2194,8 +2311,7 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
         /* run only if llvm-config isn't used */
         if let Some(config) = builder.config.target_config.get(&target) {
             if let Some(ref _s) = config.llvm_config {
-                builder.info(&format!("Skipping LlvmTools ({}): external LLVM",
-                    target));
+                builder.info(&format!("Skipping LlvmTools ({}): external LLVM", target));
                 return None;
             }
         }
@@ -2210,12 +2326,8 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
         drop(fs::remove_dir_all(&image));
 
         // Prepare the image directory
-        let src_bindir = builder
-            .llvm_out(target)
-            .join("bin");
-        let dst_bindir = image.join("lib/rustlib")
-            .join(&*target)
-            .join("bin");
+        let src_bindir = builder.llvm_out(target).join("bin");
+        let dst_bindir = image.join("lib/rustlib").join(&*target).join("bin");
         t!(fs::create_dir_all(&dst_bindir));
         for tool in LLVM_TOOLS {
             let exe = src_bindir.join(exe(tool, &target));
@@ -2236,15 +2348,18 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
             .arg("--product-name=Rust")
             .arg("--rel-manifest-dir=rustlib")
             .arg("--success-message=llvm-tools-installed.")
-            .arg("--image-dir").arg(&image)
-            .arg("--work-dir").arg(&tmpdir(builder))
-            .arg("--output-dir").arg(&distdir(builder))
-            .arg("--non-installed-overlay").arg(&overlay)
+            .arg("--image-dir")
+            .arg(&image)
+            .arg("--work-dir")
+            .arg(&tmpdir(builder))
+            .arg("--output-dir")
+            .arg(&distdir(builder))
+            .arg("--non-installed-overlay")
+            .arg(&overlay)
             .arg(format!("--package-name={}-{}", name, target))
             .arg("--legacy-manifest-dirs=rustlib,cargo")
             .arg("--component-name=llvm-tools-preview");
 
-
         builder.run(&mut cmd);
         Some(distdir(builder).join(format!("{}-{}.tar.gz", name, target)))
     }
@@ -2265,9 +2380,7 @@ fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
     }
 
     fn make_run(run: RunConfig<'_>) {
-        run.builder.ensure(Lldb {
-            target: run.target,
-        });
+        run.builder.ensure(Lldb { target: run.target });
     }
 
     fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
@@ -2277,9 +2390,7 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
             return None;
         }
 
-        let bindir = builder
-            .llvm_out(target)
-            .join("bin");
+        let bindir = builder.llvm_out(target).join("bin");
         let lldb_exe = bindir.join(exe("lldb", &target));
         if !lldb_exe.exists() {
             return None;
@@ -2313,7 +2424,7 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
                     if t!(entry.file_type()).is_symlink() {
                         builder.copy_to_folder(&entry.path(), &dst);
                     } else {
-                       builder.install(&entry.path(), &dst, 0o755);
+                        builder.install(&entry.path(), &dst, 0o755);
                     }
                 }
             }
@@ -2332,8 +2443,7 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
             let entry = t!(entry);
             if let Ok(name) = entry.file_name().into_string() {
                 if name.starts_with("python") {
-                    let dst = root.join(libdir_name)
-                        .join(entry.file_name());
+                    let dst = root.join(libdir_name).join(entry.file_name());
                     t!(fs::create_dir_all(&dst));
                     builder.cp_r(&entry.path(), &dst);
                     break;
@@ -2354,15 +2464,18 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
             .arg("--product-name=Rust")
             .arg("--rel-manifest-dir=rustlib")
             .arg("--success-message=lldb-installed.")
-            .arg("--image-dir").arg(&image)
-            .arg("--work-dir").arg(&tmpdir(builder))
-            .arg("--output-dir").arg(&distdir(builder))
-            .arg("--non-installed-overlay").arg(&overlay)
+            .arg("--image-dir")
+            .arg(&image)
+            .arg("--work-dir")
+            .arg(&tmpdir(builder))
+            .arg("--output-dir")
+            .arg(&distdir(builder))
+            .arg("--non-installed-overlay")
+            .arg(&overlay)
             .arg(format!("--package-name={}-{}", name, target))
             .arg("--legacy-manifest-dirs=rustlib,cargo")
             .arg("--component-name=lldb-preview");
 
-
         builder.run(&mut cmd);
         Some(distdir(builder).join(format!("{}-{}.tar.gz", name, target)))
     }