]> git.lizzy.rs Git - rust.git/blobdiff - src/base.rs
Implement isize -> raw-ptr cast
[rust.git] / src / base.rs
index 66bd3e995234fd1bcd2f9a386574e309fa43c3b8..556e01aa3a2198855888cef7f86603d203b0b324 100644 (file)
@@ -9,13 +9,12 @@ fn drop(&mut self) {
     }
 }
 
-pub fn trans_mono_item<'a, 'tcx: 'a>(
-    tcx: TyCtxt<'a, 'tcx, 'tcx>,
-    module: &mut Module<impl Backend>,
-    caches: &mut Caches<'tcx>,
-    ccx: &mut crate::constant::ConstantCx,
+pub fn trans_mono_item<'a, 'clif, 'tcx: 'a, B: Backend + 'static>(
+    cx: &mut crate::CodegenCx<'a, 'clif, 'tcx, B>,
     mono_item: MonoItem<'tcx>,
+    linkage: Linkage,
 ) {
+    let tcx = cx.tcx;
     match mono_item {
         MonoItem::Fn(inst) => {
             let _inst_guard =
@@ -44,10 +43,10 @@ pub fn trans_mono_item<'a, 'tcx: 'a>(
                 }
             });
 
-            trans_fn(tcx, module, ccx, caches, inst);
+            trans_fn(cx, inst, linkage);
         }
         MonoItem::Static(def_id) => {
-            crate::constant::codegen_static(ccx, def_id);
+            crate::constant::codegen_static(&mut cx.ccx, def_id);
         }
         MonoItem::GlobalAsm(node_id) => tcx
             .sess
@@ -55,21 +54,28 @@ pub fn trans_mono_item<'a, 'tcx: 'a>(
     }
 }
 
-fn trans_fn<'a, 'tcx: 'a>(
-    tcx: TyCtxt<'a, 'tcx, 'tcx>,
-    module: &mut Module<impl Backend>,
-    constants: &mut crate::constant::ConstantCx,
-    caches: &mut Caches<'tcx>,
+fn trans_fn<'a, 'clif, 'tcx: 'a, B: Backend + 'static>(
+    cx: &mut crate::CodegenCx<'a, 'clif, 'tcx, B>,
     instance: Instance<'tcx>,
+    linkage: Linkage,
 ) {
+    let tcx = cx.tcx;
+
     // Step 1. Get mir
     let mir = tcx.instance_mir(instance.def);
 
     // Step 2. Declare function
-    let (name, sig) = get_function_name_and_sig(tcx, instance);
-    let func_id = module
-        .declare_function(&name, Linkage::Export, &sig)
+    let (name, sig) = get_function_name_and_sig(tcx, instance, false);
+    let func_id = cx.module
+        .declare_function(&name, linkage, &sig)
         .unwrap();
+    let mut debug_context = cx.debug_context.as_mut().map(|debug_context| FunctionDebugContext::new(
+        tcx,
+        debug_context,
+        mir,
+        &name,
+        &sig,
+    ));
 
     // Step 3. Make FunctionBuilder
     let mut func = Function::with_name_signature(ExternalName::user(0, 0), sig);
@@ -84,10 +90,12 @@ fn trans_fn<'a, 'tcx: 'a>(
     }
 
     // Step 5. Make FunctionCx
-    let pointer_type = module.target_config().pointer_type();
+    let pointer_type = cx.module.target_config().pointer_type();
+    let clif_comments = crate::pretty_clif::CommentWriter::new(tcx, instance);
+
     let mut fx = FunctionCx {
         tcx,
-        module,
+        module: cx.module,
         pointer_type,
 
         instance,
@@ -97,11 +105,10 @@ fn trans_fn<'a, 'tcx: 'a>(
         ebb_map,
         local_map: HashMap::new(),
 
-        comments: HashMap::new(),
-        constants,
-        caches,
-
-        top_nop: None,
+        clif_comments,
+        constants: &mut cx.ccx,
+        caches: &mut cx.caches,
+        source_info_set: indexmap::IndexSet::new(),
     };
 
     // Step 6. Codegen function
@@ -109,34 +116,25 @@ fn trans_fn<'a, 'tcx: 'a>(
         crate::abi::codegen_fn_prelude(&mut fx, start_ebb);
         codegen_fn_content(&mut fx);
     });
+    let source_info_set = fx.source_info_set.clone();
 
     // Step 7. Write function to file for debugging
-    let mut writer = crate::pretty_clif::CommentWriter(fx.comments);
-
-    let mut clif = String::new();
-    if cfg!(debug_assertions) {
-        ::cranelift::codegen::write::decorate_function(&mut writer, &mut clif, &func, None)
-            .unwrap();
-        let clif_file_name = format!(
-            "{}/{}__{}.clif",
-            concat!(env!("CARGO_MANIFEST_DIR"), "/target/out/clif"),
-            tcx.crate_name(LOCAL_CRATE),
-            tcx.symbol_name(instance).as_str(),
-        );
-        if let Err(e) = ::std::fs::write(clif_file_name, clif.as_bytes()) {
-            tcx.sess.warn(&format!("err writing clif file: {:?}", e));
-        }
-    }
+    #[cfg(debug_assertions)]
+    fx.write_clif_file();
 
     // Step 8. Verify function
-    verify_func(tcx, writer, &func);
+    verify_func(tcx, fx.clif_comments, &func);
 
     // Step 9. Define function
-    caches.context.func = func;
-    module
-        .define_function(func_id, &mut caches.context)
+    cx.caches.context.func = func;
+    cx.module
+        .define_function_peek_compiled(func_id, &mut cx.caches.context, |size, context, isa| {
+            debug_context.as_mut().map(|x| x.define(tcx, size, context, isa, &source_info_set));
+        })
         .unwrap();
-    caches.context.clear();
+    //let module = &mut cx.module;
+    //let caches = &cx.caches;
+    cx.caches.context.clear();
 }
 
 fn verify_func(tcx: TyCtxt, writer: crate::pretty_clif::CommentWriter, func: &Function) {
@@ -148,7 +146,7 @@ fn verify_func(tcx: TyCtxt, writer: crate::pretty_clif::CommentWriter, func: &Fu
             let pretty_error = ::cranelift::codegen::print_errors::pretty_verifier_error(
                 &func,
                 None,
-                Some(Box::new(writer)),
+                Some(Box::new(&writer)),
                 err,
             );
             tcx.sess
@@ -169,17 +167,23 @@ fn codegen_fn_content<'a, 'tcx: 'a>(fx: &mut FunctionCx<'a, 'tcx, impl Backend>)
 
         fx.bcx.ins().nop();
         for stmt in &bb_data.statements {
+            fx.set_debug_loc(stmt.source_info);
             trans_stmt(fx, ebb, stmt);
         }
 
-        let mut terminator_head = "\n".to_string();
-        bb_data
-            .terminator()
-            .kind
-            .fmt_head(&mut terminator_head)
-            .unwrap();
-        let inst = fx.bcx.func.layout.last_inst(ebb).unwrap();
-        fx.add_comment(inst, terminator_head);
+        #[cfg(debug_assertions)]
+        {
+            let mut terminator_head = "\n".to_string();
+            bb_data
+                .terminator()
+                .kind
+                .fmt_head(&mut terminator_head)
+                .unwrap();
+            let inst = fx.bcx.func.layout.last_inst(ebb).unwrap();
+            fx.add_comment(inst, terminator_head);
+        }
+
+        fx.set_debug_loc(bb_data.terminator().source_info);
 
         match &bb_data.terminator().kind {
             TerminatorKind::Goto { target } => {
@@ -196,7 +200,7 @@ fn codegen_fn_content<'a, 'tcx: 'a>(fx: &mut FunctionCx<'a, 'tcx, impl Backend>)
                 target,
                 cleanup: _,
             } => {
-                let cond = trans_operand(fx, cond).load_value(fx);
+                let cond = trans_operand(fx, cond).load_scalar(fx);
                 // TODO HACK brz/brnz for i8/i16 is not yet implemented
                 let cond = fx.bcx.ins().uextend(types::I32, cond);
                 let target = fx.get_ebb(*target);
@@ -214,7 +218,7 @@ fn codegen_fn_content<'a, 'tcx: 'a>(fx: &mut FunctionCx<'a, 'tcx, impl Backend>)
                 values,
                 targets,
             } => {
-                let discr = trans_operand(fx, discr).load_value(fx);
+                let discr = trans_operand(fx, discr).load_scalar(fx);
                 let mut switch = ::cranelift::frontend::Switch::new();
                 for (i, value) in values.iter().enumerate() {
                     let ebb = fx.get_ebb(targets[i]);
@@ -238,7 +242,8 @@ fn codegen_fn_content<'a, 'tcx: 'a>(fx: &mut FunctionCx<'a, 'tcx, impl Backend>)
             TerminatorKind::Yield { .. }
             | TerminatorKind::FalseEdges { .. }
             | TerminatorKind::FalseUnwind { .. }
-            | TerminatorKind::DropAndReplace { .. } => {
+            | TerminatorKind::DropAndReplace { .. }
+            | TerminatorKind::GeneratorDrop => {
                 bug!("shouldn't exist at trans {:?}", bb_data.terminator());
             }
             TerminatorKind::Drop {
@@ -254,23 +259,23 @@ fn codegen_fn_content<'a, 'tcx: 'a>(fx: &mut FunctionCx<'a, 'tcx, impl Backend>)
                     // we don't actually need to drop anything
                 } else {
                     let drop_place = trans_place(fx, location);
-                    let arg_place = CPlace::temp(
-                        fx,
-                        fx.tcx.mk_ref(
-                            &ty::RegionKind::ReErased,
-                            TypeAndMut {
-                                ty,
-                                mutbl: crate::rustc::hir::Mutability::MutMutable,
-                            },
-                        ),
-                    );
-                    drop_place.write_place_ref(fx, arg_place);
+                    let drop_fn_ty = drop_fn.ty(fx.tcx);
                     match ty.sty {
                         ty::Dynamic(..) => {
-                            unimpl!("Drop for trait object");
+                            crate::abi::codegen_drop(fx, drop_place, drop_fn_ty);
                         }
                         _ => {
-                            let drop_fn_ty = drop_fn.ty(fx.tcx);
+                            let arg_place = CPlace::new_stack_slot(
+                                fx,
+                                fx.tcx.mk_ref(
+                                    &ty::RegionKind::ReErased,
+                                    TypeAndMut {
+                                        ty,
+                                        mutbl: crate::rustc::hir::Mutability::MutMutable,
+                                    },
+                                ),
+                            );
+                            drop_place.write_place_ref(fx, arg_place);
                             let arg_value = arg_place.to_cvalue(fx);
                             crate::abi::codegen_call_inner(
                                 fx,
@@ -281,45 +286,11 @@ fn codegen_fn_content<'a, 'tcx: 'a>(fx: &mut FunctionCx<'a, 'tcx, impl Backend>)
                             );
                         }
                     }
-                    /*
-                    let (args1, args2);
-                    /*let mut args = if let Some(llextra) = place.llextra {
-                        args2 = [place.llval, llextra];
-                        &args2[..]
-                    } else {
-                        args1 = [place.llval];
-                        &args1[..]
-                    };*/
-                    let (drop_fn, fn_ty) = match ty.sty {
-                    ty::Dynamic(..) => {
-                    let fn_ty = drop_fn.ty(bx.cx.tcx);
-                    let sig = common::ty_fn_sig(bx.cx, fn_ty);
-                    let sig = bx.tcx().normalize_erasing_late_bound_regions(
-                    ty::ParamEnv::reveal_all(),
-                    &sig,
-                    );
-                    let fn_ty = FnType::new_vtable(bx.cx, sig, &[]);
-                    let vtable = args[1];
-                    args = &args[..1];
-                    (meth::DESTRUCTOR.get_fn(&bx, vtable, &fn_ty), fn_ty)
-                    }
-                    _ => {
-                    let value = place.to_cvalue(fx);
-                    (callee::get_fn(bx.cx, drop_fn),
-                    FnType::of_instance(bx.cx, &drop_fn))
-                    }
-                    };
-                    do_call(self, bx, fn_ty, drop_fn, args,
-                    Some((ReturnDest::Nothing, target)),
-                    unwind);*/
                 }
 
                 let target_ebb = fx.get_ebb(*target);
                 fx.bcx.ins().jump(target_ebb, &[]);
             }
-            TerminatorKind::GeneratorDrop => {
-                unimplemented!("terminator GeneratorDrop");
-            }
         };
     }
 
@@ -334,6 +305,9 @@ fn trans_stmt<'a, 'tcx: 'a>(
 ) {
     let _print_guard = PrintOnPanic(|| format!("stmt {:?}", stmt));
 
+    fx.set_debug_loc(stmt.source_info);
+
+    #[cfg(debug_assertions)]
     match &stmt.kind {
         StatementKind::StorageLive(..) | StatementKind::StorageDead(..) => {} // Those are not very useful
         _ => {
@@ -418,6 +392,7 @@ fn trans_stmt<'a, 'tcx: 'a>(
                         ty::Float(_) => trans_float_binop(fx, *bin_op, lhs, rhs, lval.layout().ty),
                         ty::Char => trans_char_binop(fx, *bin_op, lhs, rhs, lval.layout().ty),
                         ty::RawPtr(..) => trans_ptr_binop(fx, *bin_op, lhs, rhs, lval.layout().ty),
+                        ty::FnPtr(..) => trans_ptr_binop(fx, *bin_op, lhs, rhs, lval.layout().ty),
                         _ => unimplemented!("binop {:?} for {:?}", bin_op, ty),
                     };
                     lval.write_cvalue(fx, res);
@@ -441,7 +416,7 @@ fn trans_stmt<'a, 'tcx: 'a>(
                 Rvalue::UnaryOp(un_op, operand) => {
                     let operand = trans_operand(fx, operand);
                     let layout = operand.layout();
-                    let val = operand.load_value(fx);
+                    let val = operand.load_scalar(fx);
                     let res = match un_op {
                         UnOp::Not => {
                             match layout.ty.sty {
@@ -467,9 +442,17 @@ fn trans_stmt<'a, 'tcx: 'a>(
                     lval.write_cvalue(fx, CValue::ByVal(res, layout));
                 }
                 Rvalue::Cast(CastKind::ReifyFnPointer, operand, ty) => {
-                    let operand = trans_operand(fx, operand);
                     let layout = fx.layout_of(ty);
-                    lval.write_cvalue(fx, operand.unchecked_cast_to(layout));
+                    match fx.monomorphize(&operand.ty(&fx.mir.local_decls, fx.tcx)).sty {
+                        ty::FnDef(def_id, substs) => {
+                            let func_ref = fx.get_function_ref(
+                                Instance::resolve(fx.tcx, ParamEnv::reveal_all(), def_id, substs).unwrap(),
+                            );
+                            let func_addr = fx.bcx.ins().func_addr(fx.pointer_type, func_ref);
+                            lval.write_cvalue(fx, CValue::ByVal(func_addr, layout));
+                        }
+                        _ => bug!("Trying to ReifyFnPointer on non FnDef {:?}", ty),
+                    }
                 }
                 Rvalue::Cast(CastKind::UnsafeFnPointer, operand, ty) => {
                     let operand = trans_operand(fx, operand);
@@ -499,11 +482,14 @@ fn trans_stmt<'a, 'tcx: 'a>(
                         (ty::Uint(_), ty::RawPtr(..)) if from_ty.sty == fx.tcx.types.usize.sty => {
                             lval.write_cvalue(fx, operand.unchecked_cast_to(dest_layout));
                         }
+                        (ty::Int(_), ty::RawPtr(..)) if from_ty.sty == fx.tcx.types.isize.sty => {
+                            lval.write_cvalue(fx, operand.unchecked_cast_to(dest_layout));
+                        }
                         (ty::Char, ty::Uint(_))
                         | (ty::Uint(_), ty::Char)
                         | (ty::Uint(_), ty::Int(_))
                         | (ty::Uint(_), ty::Uint(_)) => {
-                            let from = operand.load_value(fx);
+                            let from = operand.load_scalar(fx);
                             let res = crate::common::clif_intcast(
                                 fx,
                                 from,
@@ -513,7 +499,7 @@ fn trans_stmt<'a, 'tcx: 'a>(
                             lval.write_cvalue(fx, CValue::ByVal(res, dest_layout));
                         }
                         (ty::Int(_), ty::Int(_)) | (ty::Int(_), ty::Uint(_)) => {
-                            let from = operand.load_value(fx);
+                            let from = operand.load_scalar(fx);
                             let res = crate::common::clif_intcast(
                                 fx,
                                 from,
@@ -523,7 +509,7 @@ fn trans_stmt<'a, 'tcx: 'a>(
                             lval.write_cvalue(fx, CValue::ByVal(res, dest_layout));
                         }
                         (ty::Float(from_flt), ty::Float(to_flt)) => {
-                            let from = operand.load_value(fx);
+                            let from = operand.load_scalar(fx);
                             let res = match (from_flt, to_flt) {
                                 (FloatTy::F32, FloatTy::F64) => {
                                     fx.bcx.ins().fpromote(types::F64, from)
@@ -535,9 +521,21 @@ fn trans_stmt<'a, 'tcx: 'a>(
                             };
                             lval.write_cvalue(fx, CValue::ByVal(res, dest_layout));
                         }
+                        (ty::Float(_), ty::Int(_)) => {
+                            let from = operand.load_scalar(fx);
+                            let i_type = fx.clif_type(to_ty).unwrap();
+                            let res = fx.bcx.ins().fcvt_to_sint_sat(i_type, from);
+                            lval.write_cvalue(fx, CValue::ByVal(res, dest_layout));
+                        }
+                        (ty::Float(_), ty::Uint(_)) => {
+                            let from = operand.load_scalar(fx);
+                            let i_type = fx.clif_type(to_ty).unwrap();
+                            let res = fx.bcx.ins().fcvt_to_uint_sat(i_type, from);
+                            lval.write_cvalue(fx, CValue::ByVal(res, dest_layout));
+                        }
                         (ty::Int(_), ty::Float(_)) => {
                             let from_ty = fx.clif_type(from_ty).unwrap();
-                            let from = operand.load_value(fx);
+                            let from = operand.load_scalar(fx);
                             // FIXME missing encoding for fcvt_from_sint.f32.i8
                             let from = if from_ty == types::I8 || from_ty == types::I16 {
                                 fx.bcx.ins().sextend(types::I32, from)
@@ -550,7 +548,7 @@ fn trans_stmt<'a, 'tcx: 'a>(
                         }
                         (ty::Uint(_), ty::Float(_)) => {
                             let from_ty = fx.clif_type(from_ty).unwrap();
-                            let from = operand.load_value(fx);
+                            let from = operand.load_scalar(fx);
                             // FIXME missing encoding for fcvt_from_uint.f32.i8
                             let from = if from_ty == types::I8 || from_ty == types::I16 {
                                 fx.bcx.ins().uextend(types::I32, from)
@@ -563,7 +561,7 @@ fn trans_stmt<'a, 'tcx: 'a>(
                         }
                         (ty::Bool, ty::Uint(_)) | (ty::Bool, ty::Int(_)) => {
                             let to_ty = fx.clif_type(to_ty).unwrap();
-                            let from = operand.load_value(fx);
+                            let from = operand.load_scalar(fx);
                             let res = if to_ty != types::I8 {
                                 fx.bcx.ins().uextend(to_ty, from)
                             } else {
@@ -658,8 +656,7 @@ fn trans_stmt<'a, 'tcx: 'a>(
         | StatementKind::Nop
         | StatementKind::FakeRead(..)
         | StatementKind::Retag { .. }
-        | StatementKind::AscribeUserType(..)
-        | StatementKind::EscapeToRaw(..) => {}
+        | StatementKind::AscribeUserType(..) => {}
 
         StatementKind::InlineAsm { .. } => unimpl!("Inline assembly is not supported"),
     }
@@ -674,10 +671,9 @@ fn codegen_array_len<'a, 'tcx: 'a>(
             let len = crate::constant::force_eval_const(fx, len).unwrap_usize(fx.tcx) as i64;
             fx.bcx.ins().iconst(fx.pointer_type, len)
         }
-        ty::Slice(_elem_ty) => match place {
-            CPlace::Addr(_, size, _) => size.unwrap(),
-            CPlace::Var(_, _) => unreachable!(),
-        },
+        ty::Slice(_elem_ty) => {
+            place.to_addr_maybe_unsized(fx).1.expect("Length metadata for slice place")
+        }
         _ => bug!("Rvalue::Len({:?})", place),
     }
 }
@@ -707,7 +703,7 @@ pub fn trans_get_discriminant<'a, 'tcx: 'a>(
 
     let discr = value.value_field(fx, mir::Field::new(0));
     let discr_ty = discr.layout().ty;
-    let lldiscr = discr.load_value(fx);
+    let lldiscr = discr.load_scalar(fx);
     match layout.variants {
         layout::Variants::Single { .. } => bug!(),
         layout::Variants::Tagged { ref tag, .. } => {
@@ -794,8 +790,8 @@ macro_rules! binop_match {
             $var:ident ($sign:pat) $name:tt $( ( $($next:tt)* ) )? ;
         )*
     ) => {{
-        let lhs = $lhs.load_value($fx);
-        let rhs = $rhs.load_value($fx);
+        let lhs = $lhs.load_scalar($fx);
+        let rhs = $rhs.load_scalar($fx);
         match ($bin_op, $signed) {
             $(
                 (BinOp::$var, $sign) => binop_match!(@single $fx, $bug_fmt, $var, $signed, lhs, rhs, $ret_ty, $name $( ( $($next)* ) )?),
@@ -899,8 +895,8 @@ pub fn trans_checked_int_binop<'a, 'tcx: 'a>(
         );
     }
 
-    let lhs = in_lhs.load_value(fx);
-    let rhs = in_rhs.load_value(fx);
+    let lhs = in_lhs.load_scalar(fx);
+    let rhs = in_rhs.load_scalar(fx);
     let res = match bin_op {
         BinOp::Add => fx.bcx.ins().iadd(lhs, rhs),
         BinOp::Sub => fx.bcx.ins().isub(lhs, rhs),
@@ -924,7 +920,7 @@ pub fn trans_checked_int_binop<'a, 'tcx: 'a>(
     // TODO: check for overflow
     let has_overflow = fx.bcx.ins().iconst(types::I8, 0);
 
-    let out_place = CPlace::temp(fx, out_ty);
+    let out_place = CPlace::new_stack_slot(fx, out_ty);
     let out_layout = out_place.layout();
     out_place.write_cvalue(fx, CValue::ByValPair(res, has_overflow, out_layout));
 
@@ -1012,49 +1008,67 @@ fn trans_ptr_binop<'a, 'tcx: 'a>(
     rhs: CValue<'tcx>,
     ret_ty: Ty<'tcx>,
 ) -> CValue<'tcx> {
-    match lhs.layout().ty.sty {
-        ty::RawPtr(TypeAndMut { ty, mutbl: _ }) => {
-            if ty.is_sized(fx.tcx.at(DUMMY_SP), ParamEnv::reveal_all()) {
-                binop_match! {
-                    fx, bin_op, false, lhs, rhs, ret_ty, "ptr";
-                    Add (_) bug;
-                    Sub (_) bug;
-                    Mul (_) bug;
-                    Div (_) bug;
-                    Rem (_) bug;
-                    BitXor (_) bug;
-                    BitAnd (_) bug;
-                    BitOr (_) bug;
-                    Shl (_) bug;
-                    Shr (_) bug;
-
-                    Eq (_) icmp(Equal);
-                    Lt (_) icmp(UnsignedLessThan);
-                    Le (_) icmp(UnsignedLessThanOrEqual);
-                    Ne (_) icmp(NotEqual);
-                    Ge (_) icmp(UnsignedGreaterThanOrEqual);
-                    Gt (_) icmp(UnsignedGreaterThan);
-
-                    Offset (_) iadd;
-                }
-            } else {
-                let lhs = lhs.load_value_pair(fx).0;
-                let rhs = rhs.load_value_pair(fx).0;
-                let res = match bin_op {
-                    BinOp::Eq => fx.bcx.ins().icmp(IntCC::Equal, lhs, rhs),
-                    BinOp::Ne => fx.bcx.ins().icmp(IntCC::NotEqual, lhs, rhs),
-                    _ => unimplemented!(
-                        "trans_ptr_binop({:?}, <fat ptr>, <fat ptr>) not implemented",
-                        bin_op
-                    ),
-                };
+    let not_fat = match lhs.layout().ty.sty {
+        ty::RawPtr(TypeAndMut { ty, mutbl: _ }) => ty.is_sized(fx.tcx.at(DUMMY_SP), ParamEnv::reveal_all()),
+        ty::FnPtr(..) => true,
+        _ => bug!("trans_ptr_binop on non ptr"),
+    };
+    if not_fat {
+        if let BinOp::Offset = bin_op {
+            let (base, offset) = (lhs, rhs.load_scalar(fx));
+            let pointee_ty = base.layout().ty.builtin_deref(true).unwrap().ty;
+            let pointee_size = fx.layout_of(pointee_ty).size.bytes();
+            let ptr_diff = fx.bcx.ins().imul_imm(offset, pointee_size as i64);
+            let base_val = base.load_scalar(fx);
+            let res = fx.bcx.ins().iadd(base_val, ptr_diff);
+            return CValue::ByVal(res, base.layout());
+        }
 
-                assert_eq!(fx.tcx.types.bool, ret_ty);
-                let ret_layout = fx.layout_of(ret_ty);
-                CValue::ByVal(fx.bcx.ins().bint(types::I8, res), ret_layout)
-            }
+        binop_match! {
+            fx, bin_op, false, lhs, rhs, ret_ty, "ptr";
+            Add (_) bug;
+            Sub (_) bug;
+            Mul (_) bug;
+            Div (_) bug;
+            Rem (_) bug;
+            BitXor (_) bug;
+            BitAnd (_) bug;
+            BitOr (_) bug;
+            Shl (_) bug;
+            Shr (_) bug;
+
+            Eq (_) icmp(Equal);
+            Lt (_) icmp(UnsignedLessThan);
+            Le (_) icmp(UnsignedLessThanOrEqual);
+            Ne (_) icmp(NotEqual);
+            Ge (_) icmp(UnsignedGreaterThanOrEqual);
+            Gt (_) icmp(UnsignedGreaterThan);
+
+            Offset (_) bug; // Handled above
         }
-        _ => bug!("trans_ptr_binop on non ptr"),
+    } else {
+        let (lhs_ptr, lhs_extra) = lhs.load_value_pair(fx);
+        let (rhs_ptr, rhs_extra) = rhs.load_value_pair(fx);
+        let res = match bin_op {
+            BinOp::Eq => {
+                let ptr_eq = fx.bcx.ins().icmp(IntCC::Equal, lhs_ptr, rhs_ptr);
+                let extra_eq = fx.bcx.ins().icmp(IntCC::Equal, lhs_extra, rhs_extra);
+                fx.bcx.ins().band(ptr_eq, extra_eq)
+            }
+            BinOp::Ne => {
+                let ptr_ne = fx.bcx.ins().icmp(IntCC::NotEqual, lhs_ptr, rhs_ptr);
+                let extra_ne = fx.bcx.ins().icmp(IntCC::NotEqual, lhs_extra, rhs_extra);
+                fx.bcx.ins().bor(ptr_ne, extra_ne)
+            }
+            _ => unimplemented!(
+                "trans_ptr_binop({:?}, <fat ptr>, <fat ptr>) not implemented",
+                bin_op
+            ),
+        };
+
+        assert_eq!(fx.tcx.types.bool, ret_ty);
+        let ret_layout = fx.layout_of(ret_ty);
+        CValue::ByVal(fx.bcx.ins().bint(types::I8, res), ret_layout)
     }
 }
 
@@ -1072,7 +1086,7 @@ pub fn trans_place<'a, 'tcx: 'a>(
                 ProjectionElem::Deref => base.place_deref(fx),
                 ProjectionElem::Field(field, _ty) => base.place_field(fx, field),
                 ProjectionElem::Index(local) => {
-                    let index = fx.get_local_place(local).to_cvalue(fx).load_value(fx);
+                    let index = fx.get_local_place(local).to_cvalue(fx).load_scalar(fx);
                     base.place_index(fx, index)
                 }
                 ProjectionElem::ConstantIndex {