+//! Abstraction around the object writing crate
+
use std::convert::{TryFrom, TryInto};
use rustc_data_structures::fx::FxHashMap;
use rustc_session::Session;
-use cranelift_module::{FuncId, Module};
+use cranelift_codegen::isa::TargetIsa;
+use cranelift_module::FuncId;
+use cranelift_object::{ObjectBuilder, ObjectModule, ObjectProduct};
-use object::{SectionKind, SymbolFlags, RelocationKind, RelocationEncoding};
use object::write::*;
-
-use cranelift_object::*;
+use object::{RelocationEncoding, SectionKind, SymbolFlags};
use gimli::SectionId;
use crate::debuginfo::{DebugReloc, DebugRelocName};
pub(crate) trait WriteMetadata {
- fn add_rustc_section(&mut self, symbol_name: String, data: Vec<u8>, is_like_osx: bool);
+ fn add_rustc_section(&mut self, symbol_name: String, data: Vec<u8>);
}
impl WriteMetadata for object::write::Object {
- fn add_rustc_section(&mut self, symbol_name: String, data: Vec<u8>, _is_like_osx: bool) {
+ fn add_rustc_section(&mut self, symbol_name: String, data: Vec<u8>) {
let segment = self.segment_name(object::write::StandardSegment::Data).to_vec();
let section_id = self.add_section(segment, b".rustc".to_vec(), object::SectionKind::Data);
let offset = self.append_section_data(section_id, &data, 1);
id.name().replace('.', "__") // machO expects __debug_info instead of .debug_info
} else {
id.name().to_string()
- }.into_bytes();
+ }
+ .into_bytes();
let segment = self.object.segment_name(StandardSegment::Debug).to_vec();
- let section_id = self.object.add_section(segment, name, SectionKind::Debug);
- self.object.section_mut(section_id).set_data(data, 1);
+ // FIXME use SHT_X86_64_UNWIND for .eh_frame
+ let section_id = self.object.add_section(
+ segment,
+ name,
+ if id == SectionId::EhFrame { SectionKind::ReadOnlyData } else { SectionKind::Debug },
+ );
+ self.object
+ .section_mut(section_id)
+ .set_data(data, if id == SectionId::EhFrame { 8 } else { 1 });
let symbol_id = self.object.section_symbol(section_id);
(section_id, symbol_id)
}
reloc: &DebugReloc,
) {
let (symbol, symbol_offset) = match reloc.name {
- DebugRelocName::Section(id) => {
- (section_map.get(&id).unwrap().1, 0)
- }
+ DebugRelocName::Section(id) => (section_map.get(&id).unwrap().1, 0),
DebugRelocName::Symbol(id) => {
let symbol_id = self.function_symbol(FuncId::from_u32(id.try_into().unwrap()));
- self.object.symbol_section_and_offset(symbol_id).expect("Debug reloc for undef sym???")
+ self.object
+ .symbol_section_and_offset(symbol_id)
+ .expect("Debug reloc for undef sym???")
}
};
- self.object.add_relocation(from.0, Relocation {
- offset: u64::from(reloc.offset),
- symbol,
- kind: RelocationKind::Absolute,
- encoding: RelocationEncoding::Generic,
- size: reloc.size * 8,
- addend: i64::try_from(symbol_offset).unwrap() + reloc.addend,
- }).unwrap();
- }
-}
-
-pub(crate) trait Emit {
- fn emit(self) -> Vec<u8>;
-}
-
-impl Emit for ObjectProduct {
- fn emit(self) -> Vec<u8> {
- self.object.write().unwrap()
+ self.object
+ .add_relocation(
+ from.0,
+ Relocation {
+ offset: u64::from(reloc.offset),
+ symbol,
+ kind: reloc.kind,
+ encoding: RelocationEncoding::Generic,
+ size: reloc.size * 8,
+ addend: i64::try_from(symbol_offset).unwrap() + reloc.addend,
+ },
+ )
+ .unwrap();
}
}
pub(crate) fn with_object(sess: &Session, name: &str, f: impl FnOnce(&mut Object)) -> Vec<u8> {
- let triple = crate::build_isa(sess, true).triple().clone();
+ let triple = crate::target_triple(sess);
let binary_format = match triple.binary_format {
target_lexicon::BinaryFormat::Elf => object::BinaryFormat::Elf,
target_lexicon::BinaryFormat::Coff => object::BinaryFormat::Coff,
target_lexicon::BinaryFormat::Macho => object::BinaryFormat::MachO,
- target_lexicon::BinaryFormat::Wasm => sess.fatal("binary format wasm is unsupported"),
- target_lexicon::BinaryFormat::Unknown => sess.fatal("binary format is unknown"),
+ binary_format => sess.fatal(&format!("binary format {} is unsupported", binary_format)),
};
let architecture = match triple.architecture {
- target_lexicon::Architecture::I386
- | target_lexicon::Architecture::I586
- | target_lexicon::Architecture::I686 => object::Architecture::I386,
+ target_lexicon::Architecture::X86_32(_) => object::Architecture::I386,
target_lexicon::Architecture::X86_64 => object::Architecture::X86_64,
target_lexicon::Architecture::Arm(_) => object::Architecture::Arm,
target_lexicon::Architecture::Aarch64(_) => object::Architecture::Aarch64,
- architecture => sess.fatal(&format!(
- "target architecture {:?} is unsupported",
- architecture,
- ))
+ architecture => {
+ sess.fatal(&format!("target architecture {:?} is unsupported", architecture,))
+ }
};
let endian = match triple.endianness().unwrap() {
target_lexicon::Endianness::Little => object::Endianness::Little,
metadata_object.write().unwrap()
}
-pub(crate) type Backend = impl cranelift_module::Backend<Product: Emit + WriteDebugInfo>;
-
-pub(crate) fn make_module(sess: &Session, name: String) -> Module<Backend> {
- let module: Module<ObjectBackend> = Module::new(
- ObjectBuilder::new(
- crate::build_isa(sess, true),
- name + ".o",
- cranelift_module::default_libcall_names(),
- ).unwrap(),
- );
- module
+pub(crate) fn make_module(sess: &Session, isa: Box<dyn TargetIsa>, name: String) -> ObjectModule {
+ let mut builder =
+ ObjectBuilder::new(isa, name + ".o", cranelift_module::default_libcall_names()).unwrap();
+ // Unlike cg_llvm, cg_clif defaults to disabling -Zfunction-sections. For cg_llvm binary size
+ // is important, while cg_clif cares more about compilation times. Enabling -Zfunction-sections
+ // can easily double the amount of time necessary to perform linking.
+ builder.per_function_section(sess.opts.debugging_opts.function_sections.unwrap_or(false));
+ ObjectModule::new(builder)
}
projects / rust.git / blobdiff