Don't trust WM_PROTOCOLS

[bspwm.git] / rules.c

diff --git a/rules.c b/rules.c
index e3de8031583c32bdb87e2d614feb2d16b6f8f341..b5a96fd417a2be7d142e56fe1b10bf0fea4a66c3 100644 (file)
--- a/rules.c
+++ b/rules.c
@@ -1,3 +1,4 @@
+#include <stdio.h>
 #include <string.h>
 #include <xcb/xcb_icccm.h>
 #include <xcb/xcb_ewmh.h>
@@ -5,34 +6,62 @@
 #include "bspwm.h"
 #include "ewmh.h"
 #include "rules.h"
+#include "query.h"
 
-rule_t *next_match(rule_t *rule, xcb_window_t win)
+void add_rule(rule_t *r)
 {
-    if (rule == NULL)
-        return NULL;
-    rule_t *r = rule;
-    rule_t *found = NULL;
-    while (r != NULL && found == NULL) {
-        if (is_match(r, win))
-            found = r;
-        r = r->next;
+    if (rule_head == NULL) {
+        rule_head = rule_tail = r;
+    } else {
+        rule_tail->next = r;
+        r->prev = rule_tail;
+        rule_tail = r;
     }
-    return found;
+}
+
+void remove_rule(rule_t *r)
+{
+    if (r == NULL)
+        return;
+    rule_t *prev = r->prev;
+    rule_t *next = r->next;
+    if (prev != NULL)
+        prev->next = next;
+    if (next != NULL)
+        next->prev = prev;
+    if (r == rule_head)
+        rule_head = next;
+    if (r == rule_tail)
+        rule_tail = prev;
+    free(r);
+}
+
+void remove_rule_by_uid(unsigned int uid)
+{
+    remove_rule(find_rule(uid));
+}
+
+rule_t *find_rule(unsigned int uid)
+{
+    for (rule_t *r = rule_head; r != NULL; r = r->next)
+        if (r->uid == uid)
+            return r;
+    return NULL;
 }
 
 bool is_match(rule_t *r, xcb_window_t win)
 {
-    xcb_icccm_get_wm_class_reply_t reply; 
+    xcb_icccm_get_wm_class_reply_t reply;
     if (xcb_icccm_get_wm_class_reply(dpy, xcb_icccm_get_wm_class(dpy, win), &reply, NULL) == 1
-            && (strcmp(reply.class_name, r->cause.name) == 0
-                || strcmp(reply.instance_name, r->cause.name) == 0)) {
+            && (streq(reply.class_name, r->cause.name)
+                || streq(reply.instance_name, r->cause.name))) {
         xcb_icccm_get_wm_class_reply_wipe(&reply);
         return true;
     }
     return false;
 }
 
-void handle_rules(xcb_window_t win, bool *floating, bool *transient, bool *fullscreen, bool *takes_focus)
+void handle_rules(xcb_window_t win, monitor_t **m, desktop_t **d, bool *floating, bool *follow, bool *transient, bool *fullscreen, bool *takes_focus, bool *manage)
 {
     xcb_ewmh_get_atoms_reply_t win_type;
 
@@ -44,8 +73,20 @@ void handle_rules(xcb_window_t win, bool *floating, bool *transient, bool *fulls
                 *takes_focus = false;
             } else if (a == ewmh->_NET_WM_WINDOW_TYPE_DIALOG) {
                 *floating = true;
+            } else if (a == ewmh->_NET_WM_WINDOW_TYPE_DOCK || a == ewmh->_NET_WM_WINDOW_TYPE_NOTIFICATION) {
+                *manage = false;
             }
         }
+        xcb_ewmh_get_atoms_reply_wipe(&win_type);
+    }
+
+    xcb_size_hints_t size_hints;
+
+    if (xcb_icccm_get_wm_normal_hints_reply(dpy, xcb_icccm_get_wm_normal_hints(dpy, win), &size_hints, NULL) == 1) {
+        if (size_hints.min_width > 0 && size_hints.min_height > 0
+                && size_hints.min_width == size_hints.max_width
+                && size_hints.min_height == size_hints.max_height)
+            *floating = true;
     }
 
     xcb_ewmh_get_atoms_reply_t win_state;
@@ -57,10 +98,9 @@ void handle_rules(xcb_window_t win, bool *floating, bool *transient, bool *fulls
                 *fullscreen = true;
             }
         }
+        xcb_ewmh_get_atoms_reply_wipe(&win_state);
     }
 
-    /* xcb_ewmh_get_atoms_reply_wipe(&win_type); */
-
     xcb_window_t transient_for = XCB_NONE;
     xcb_icccm_get_wm_transient_for_reply(dpy, xcb_icccm_get_wm_transient_for(dpy, win), &transient_for, NULL);
     *transient = (transient_for == XCB_NONE ? false : true);
@@ -71,10 +111,45 @@ void handle_rules(xcb_window_t win, bool *floating, bool *transient, bool *fulls
 
     while (rule != NULL) {
         if (is_match(rule, win)) {
-            if (rule->effect.floating) {
+            rule_effect_t efc = rule->effect;
+            if (efc.floating)
                 *floating = true;
+            if (efc.follow)
+                *follow = true;
+            if (efc.focus)
+                *takes_focus = true;
+            if (efc.desc[0] != '\0') {
+                coordinates_t ref = {*m, *d, NULL};
+                coordinates_t loc;
+                if (desktop_from_desc(efc.desc, &ref, &loc)) {
+                    *m = loc.monitor;
+                    *d = loc.desktop;
+                }
             }
         }
         rule = rule->next;
     }
 }
+
+void list_rules(char *pattern, char *rsp)
+{
+    char line[MAXLEN];
+
+    for (rule_t *r = rule_head; r != NULL; r = r->next) {
+        if (pattern != NULL && !streq(pattern, r->cause.name))
+            continue;
+        snprintf(line, sizeof(line), "%2X %s", r->uid, r->cause.name);
+        strncat(rsp, line, REMLEN(rsp));
+        if (r->effect.floating)
+            strncat(rsp, " --floating", REMLEN(rsp));
+        if (r->effect.follow)
+            strncat(rsp, " --follow", REMLEN(rsp));
+        if (r->effect.focus)
+            strncat(rsp, " --focus", REMLEN(rsp));
+        if (r->effect.desc[0] != '\0') {
+            snprintf(line, sizeof(line), " -d %s", r->effect.desc);
+            strncat(rsp, line, REMLEN(rsp));
+        }
+        strncat(rsp, "\n", REMLEN(rsp));
+    }
+}