]> git.lizzy.rs Git - bspwm.git/blobdiff - events.c
Mention the default reference
[bspwm.git] / events.c
index cd2aa23f776fe8c70f5e5fd62373f1ac855844c5..b368eee9519425587dac4ec61a00d0f100488c18 100644 (file)
--- a/events.c
+++ b/events.c
  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#include <stdlib.h>
+#include <stdbool.h>
 #include "bspwm.h"
 #include "ewmh.h"
 #include "monitor.h"
 #include "query.h"
 #include "settings.h"
+#include "subscribe.h"
 #include "tree.h"
 #include "window.h"
+#include "pointer.h"
 #include "events.h"
 
 void handle_event(xcb_generic_event_t *evt)
@@ -57,11 +59,8 @@ void handle_event(xcb_generic_event_t *evt)
                case XCB_ENTER_NOTIFY:
                        enter_notify(evt);
                        break;
-               case XCB_LEAVE_NOTIFY:
-                       leave_notify(evt);
-                       break;
-               case XCB_MOTION_NOTIFY:
-                       motion_notify(evt);
+               case XCB_BUTTON_PRESS:
+                       button_press(evt);
                        break;
                case XCB_FOCUS_IN:
                        focus_in(evt);
@@ -70,8 +69,9 @@ void handle_event(xcb_generic_event_t *evt)
                        process_error(evt);
                        break;
                default:
-                       if (randr && resp_type == randr_base + XCB_RANDR_SCREEN_CHANGE_NOTIFY)
+                       if (randr && resp_type == randr_base + XCB_RANDR_SCREEN_CHANGE_NOTIFY) {
                                update_monitors();
+                       }
                        break;
        }
 }
@@ -80,8 +80,6 @@ void map_request(xcb_generic_event_t *evt)
 {
        xcb_map_request_event_t *e = (xcb_map_request_event_t *) evt;
 
-       PRINTF("map request %X\n", e->window);
-
        schedule_window(e->window);
 }
 
@@ -89,59 +87,12 @@ void configure_request(xcb_generic_event_t *evt)
 {
        xcb_configure_request_event_t *e = (xcb_configure_request_event_t *) evt;
 
-       PRINTF("configure request %X\n", e->window);
-
        coordinates_t loc;
        bool is_managed = locate_window(e->window, &loc);
        client_t *c = (is_managed ? loc.node->client : NULL);
-       int w = 0, h = 0;
-
-       if (is_managed && !is_floating(c)) {
-               if (e->value_mask & XCB_CONFIG_WINDOW_X)
-                       c->floating_rectangle.x = e->x;
-               if (e->value_mask & XCB_CONFIG_WINDOW_Y)
-                       c->floating_rectangle.y = e->y;
-               if (e->value_mask & XCB_CONFIG_WINDOW_WIDTH)
-                       w = e->width;
-               if (e->value_mask & XCB_CONFIG_WINDOW_HEIGHT)
-                       h = e->height;
-
-               if (w != 0) {
-                       restrain_floating_width(c, &w);
-                       c->floating_rectangle.width = w;
-               }
+       uint16_t width, height;
 
-               if (h != 0) {
-                       restrain_floating_height(c, &h);
-                       c->floating_rectangle.height = h;
-               }
-
-               xcb_configure_notify_event_t evt;
-               xcb_rectangle_t rect;
-               xcb_window_t win = c->window;
-               unsigned int bw = c->border_width;
-
-               if (c->fullscreen)
-                       rect = loc.monitor->rectangle;
-               else
-                       rect = c->tiled_rectangle;
-
-               evt.response_type = XCB_CONFIGURE_NOTIFY;
-               evt.event = win;
-               evt.window = win;
-               evt.above_sibling = XCB_NONE;
-               evt.x = rect.x;
-               evt.y = rect.y;
-               evt.width = rect.width;
-               evt.height = rect.height;
-               evt.border_width = bw;
-               evt.override_redirect = false;
-
-               xcb_send_event(dpy, false, win, XCB_EVENT_MASK_STRUCTURE_NOTIFY, (const char *) &evt);
-
-               if (c->pseudo_tiled)
-                       arrange(loc.monitor, loc.desktop);
-       } else {
+       if (!is_managed) {
                uint16_t mask = 0;
                uint32_t values[7];
                unsigned short i = 0;
@@ -149,38 +100,24 @@ void configure_request(xcb_generic_event_t *evt)
                if (e->value_mask & XCB_CONFIG_WINDOW_X) {
                        mask |= XCB_CONFIG_WINDOW_X;
                        values[i++] = e->x;
-                       if (is_managed)
-                               c->floating_rectangle.x = e->x;
                }
 
                if (e->value_mask & XCB_CONFIG_WINDOW_Y) {
                        mask |= XCB_CONFIG_WINDOW_Y;
                        values[i++] = e->y;
-                       if (is_managed)
-                               c->floating_rectangle.y = e->y;
                }
 
                if (e->value_mask & XCB_CONFIG_WINDOW_WIDTH) {
                        mask |= XCB_CONFIG_WINDOW_WIDTH;
-                       w = e->width;
-                       if (is_managed) {
-                               restrain_floating_width(c, &w);
-                               c->floating_rectangle.width = w;
-                       }
-                       values[i++] = w;
+                       values[i++] = e->width;
                }
 
                if (e->value_mask & XCB_CONFIG_WINDOW_HEIGHT) {
                        mask |= XCB_CONFIG_WINDOW_HEIGHT;
-                       h = e->height;
-                       if (is_managed) {
-                               restrain_floating_height(c, &h);
-                               c->floating_rectangle.height = h;
-                       }
-                       values[i++] = h;
+                       values[i++] = e->height;
                }
 
-               if (!is_managed && e->value_mask & XCB_CONFIG_WINDOW_BORDER_WIDTH) {
+               if (e->value_mask & XCB_CONFIG_WINDOW_BORDER_WIDTH) {
                        mask |= XCB_CONFIG_WINDOW_BORDER_WIDTH;
                        values[i++] = e->border_width;
                }
@@ -196,18 +133,91 @@ void configure_request(xcb_generic_event_t *evt)
                }
 
                xcb_configure_window(dpy, e->window, mask, values);
-       }
 
-       if (is_managed)
-               translate_client(monitor_from_client(c), loc.monitor, c);
+       } else if (IS_FLOATING(c)) {
+               width = c->floating_rectangle.width;
+               height = c->floating_rectangle.height;
+
+               if (e->value_mask & XCB_CONFIG_WINDOW_X) {
+                       c->floating_rectangle.x = e->x;
+               }
+
+               if (e->value_mask & XCB_CONFIG_WINDOW_Y) {
+                       c->floating_rectangle.y = e->y;
+               }
+
+               if (e->value_mask & XCB_CONFIG_WINDOW_WIDTH) {
+                       width = e->width;
+               }
+
+               if (e->value_mask & XCB_CONFIG_WINDOW_HEIGHT) {
+                       height = e->height;
+               }
+
+               apply_size_hints(c, &width, &height);
+               c->floating_rectangle.width = width;
+               c->floating_rectangle.height = height;
+               xcb_rectangle_t r = c->floating_rectangle;
+
+               if (focus_follows_pointer) {
+                       listen_enter_notify(loc.desktop->root, false);
+               }
+
+               window_move_resize(e->window, r.x, r.y, r.width, r.height);
+
+               if (focus_follows_pointer) {
+                       listen_enter_notify(loc.desktop->root, true);
+               }
+
+               put_status(SBSC_MASK_NODE_GEOMETRY, "node_geometry 0x%08X 0x%08X 0x%08X %ux%u+%i+%i\n", loc.monitor->id, loc.desktop->id, e->window, r.width, r.height, r.x, r.y);
+
+               monitor_t *m = monitor_from_client(c);
+               if (m != loc.monitor) {
+                       transfer_node(loc.monitor, loc.desktop, loc.node, m, m->desk, m->desk->focus);
+               }
+       } else {
+               if (c->state == STATE_PSEUDO_TILED) {
+                       width = c->floating_rectangle.width;
+                       height = c->floating_rectangle.height;
+                       if (e->value_mask & XCB_CONFIG_WINDOW_WIDTH) {
+                               width = e->width;
+                       }
+                       if (e->value_mask & XCB_CONFIG_WINDOW_HEIGHT) {
+                               height = e->height;
+                       }
+                       apply_size_hints(c, &width, &height);
+                       if (width != c->floating_rectangle.width || height != c->floating_rectangle.height) {
+                               c->floating_rectangle.width = width;
+                               c->floating_rectangle.height = height;
+                               arrange(loc.monitor, loc.desktop);
+                       }
+               }
+
+
+               xcb_configure_notify_event_t evt;
+               unsigned int bw = c->border_width;
+
+               xcb_rectangle_t r = IS_FULLSCREEN(c) ? loc.monitor->rectangle : c->tiled_rectangle;
+
+               evt.response_type = XCB_CONFIGURE_NOTIFY;
+               evt.event = e->window;
+               evt.window = e->window;
+               evt.above_sibling = XCB_NONE;
+               evt.x = r.x;
+               evt.y = r.y;
+               evt.width = r.width;
+               evt.height = r.height;
+               evt.border_width = bw;
+               evt.override_redirect = false;
+
+               xcb_send_event(dpy, false, e->window, XCB_EVENT_MASK_STRUCTURE_NOTIFY, (const char *) &evt);
+       }
 }
 
 void destroy_notify(xcb_generic_event_t *evt)
 {
        xcb_destroy_notify_event_t *e = (xcb_destroy_notify_event_t *) evt;
 
-       PRINTF("destroy notify %X\n", e->window);
-
        unmanage_window(e->window);
 }
 
@@ -215,8 +225,6 @@ void unmap_notify(xcb_generic_event_t *evt)
 {
        xcb_unmap_notify_event_t *e = (xcb_unmap_notify_event_t *) evt;
 
-       PRINTF("unmap notify %X\n", e->window);
-
        unmanage_window(e->window);
 }
 
@@ -224,34 +232,23 @@ void property_notify(xcb_generic_event_t *evt)
 {
        xcb_property_notify_event_t *e = (xcb_property_notify_event_t *) evt;
 
-       /* PRINTF("property notify %X\n", e->window); */
-
-       if (e->atom != XCB_ATOM_WM_HINTS && e->atom != XCB_ATOM_WM_NORMAL_HINTS)
+       if (e->atom != XCB_ATOM_WM_HINTS && e->atom != XCB_ATOM_WM_NORMAL_HINTS) {
                return;
+       }
 
        coordinates_t loc;
-       if (!locate_window(e->window, &loc))
+       if (!locate_window(e->window, &loc)) {
                        return;
+       }
 
        if (e->atom == XCB_ATOM_WM_HINTS) {
                xcb_icccm_wm_hints_t hints;
                if (xcb_icccm_get_wm_hints_reply(dpy, xcb_icccm_get_wm_hints(dpy, e->window), &hints, NULL) == 1 &&
                    (hints.flags & XCB_ICCCM_WM_HINT_X_URGENCY))
-                       set_urgency(loc.monitor, loc.desktop, loc.node, xcb_icccm_wm_hints_get_urgency(&hints));
+                       set_urgent(loc.monitor, loc.desktop, loc.node, xcb_icccm_wm_hints_get_urgency(&hints));
        } else if (e->atom == XCB_ATOM_WM_NORMAL_HINTS) {
                client_t *c = loc.node->client;
-               xcb_size_hints_t size_hints;
-               if (xcb_icccm_get_wm_normal_hints_reply(dpy, xcb_icccm_get_wm_normal_hints(dpy, e->window), &size_hints, NULL) == 1 &&
-                   (size_hints.flags & (XCB_ICCCM_SIZE_HINT_P_MIN_SIZE | XCB_ICCCM_SIZE_HINT_P_MAX_SIZE))) {
-                       c->min_width = size_hints.min_width;
-                       c->max_width = size_hints.max_width;
-                       c->min_height = size_hints.min_height;
-                       c->max_height = size_hints.max_height;
-                       int w = c->floating_rectangle.width;
-                       int h = c->floating_rectangle.height;
-                       restrain_floating_size(c, &w, &h);
-                       c->floating_rectangle.width = w;
-                       c->floating_rectangle.height = h;
+               if (xcb_icccm_get_wm_normal_hints_reply(dpy, xcb_icccm_get_wm_normal_hints(dpy, e->window), &c->size_hints, NULL) == 1) {
                        arrange(loc.monitor, loc.desktop);
                }
        }
@@ -261,37 +258,35 @@ void client_message(xcb_generic_event_t *evt)
 {
        xcb_client_message_event_t *e = (xcb_client_message_event_t *) evt;
 
-       PRINTF("client message %X %u\n", e->window, e->type);
-
        if (e->type == ewmh->_NET_CURRENT_DESKTOP) {
                coordinates_t loc;
-               if (ewmh_locate_desktop(e->data.data32[0], &loc))
+               if (ewmh_locate_desktop(e->data.data32[0], &loc)) {
                        focus_node(loc.monitor, loc.desktop, loc.desktop->focus);
+               }
                return;
        }
 
        coordinates_t loc;
-       if (!locate_window(e->window, &loc))
+       if (!locate_window(e->window, &loc)) {
                return;
+       }
 
        if (e->type == ewmh->_NET_WM_STATE) {
                handle_state(loc.monitor, loc.desktop, loc.node, e->data.data32[1], e->data.data32[0]);
                handle_state(loc.monitor, loc.desktop, loc.node, e->data.data32[2], e->data.data32[0]);
        } else if (e->type == ewmh->_NET_ACTIVE_WINDOW) {
                if ((ignore_ewmh_focus && e->data.data32[0] == XCB_EWMH_CLIENT_SOURCE_TYPE_NORMAL) ||
-                   loc.node == mon->desk->focus)
+                   loc.node == mon->desk->focus) {
                        return;
-               if (loc.desktop->focus->client->fullscreen && loc.desktop->focus != loc.node) {
-                       set_fullscreen(loc.desktop->focus, false);
-                       arrange(loc.monitor, loc.desktop);
                }
                focus_node(loc.monitor, loc.desktop, loc.node);
        } else if (e->type == ewmh->_NET_WM_DESKTOP) {
                coordinates_t dloc;
-               if (ewmh_locate_desktop(e->data.data32[0], &dloc))
+               if (ewmh_locate_desktop(e->data.data32[0], &dloc)) {
                        transfer_node(loc.monitor, loc.desktop, loc.node, dloc.monitor, dloc.desktop, dloc.desktop->focus);
+               }
        } else if (e->type == ewmh->_NET_CLOSE_WINDOW) {
-               window_close(loc.node);
+               close_node(loc.node);
        }
 }
 
@@ -299,126 +294,176 @@ void focus_in(xcb_generic_event_t *evt)
 {
        xcb_focus_in_event_t *e = (xcb_focus_in_event_t *) evt;
 
-       /* PRINTF("focus in %X %d %d\n", e->event, e->mode, e->detail); */
-
-       if (e->mode == XCB_NOTIFY_MODE_GRAB ||
-           e->mode == XCB_NOTIFY_MODE_UNGRAB)
+       if (e->mode == XCB_NOTIFY_MODE_GRAB || e->mode == XCB_NOTIFY_MODE_UNGRAB
+           || e->detail == XCB_NOTIFY_DETAIL_POINTER || e->detail == XCB_NOTIFY_DETAIL_POINTER_ROOT
+           || e->detail == XCB_NOTIFY_DETAIL_NONE) {
                return;
-       /* prevent focus stealing */
-       if ((e->detail == XCB_NOTIFY_DETAIL_ANCESTOR ||
-            e->detail == XCB_NOTIFY_DETAIL_INFERIOR ||
-            e->detail == XCB_NOTIFY_DETAIL_NONLINEAR_VIRTUAL ||
-            e->detail == XCB_NOTIFY_DETAIL_NONLINEAR) &&
-           (mon->desk->focus == NULL ||
-            mon->desk->focus->client->window != e->event))
-               update_input_focus();
-}
-
-void enter_notify(xcb_generic_event_t *evt)
-{
-       xcb_enter_notify_event_t *e = (xcb_enter_notify_event_t *) evt;
-       xcb_window_t win = e->event;
-
-       PRINTF("enter notify %X %d %d\n", win, e->mode, e->detail);
+       }
 
-       if (e->mode != XCB_NOTIFY_MODE_NORMAL ||
-           (mon->desk->focus != NULL &&
-            mon->desk->focus->client->window == win)) {
+       if (mon->desk->focus != NULL && e->event == mon->desk->focus->id) {
                return;
        }
 
-       uint32_t values[] = {CLIENT_EVENT_MASK|FFP_MASK|XCB_EVENT_MASK_POINTER_MOTION};
-       xcb_change_window_attributes(dpy, win, XCB_CW_EVENT_MASK, values);
+       coordinates_t loc;
+       if (locate_window(e->event, &loc)) {
+               // prevent input focus stealing
+               update_input_focus();
+       }
 }
 
-void leave_notify(xcb_generic_event_t *evt)
+void button_press(xcb_generic_event_t *evt)
 {
-       xcb_leave_notify_event_t *e = (xcb_leave_notify_event_t *) evt;
-       xcb_window_t win = e->event;
-
-       PRINTF("leave notify %X %d %d\n", win, e->mode, e->detail);
-
-       if (e->mode != XCB_NOTIFY_MODE_NORMAL) {
-               return;
+       xcb_button_press_event_t *e = (xcb_button_press_event_t *) evt;
+       bool replay = false;
+       switch (e->detail) {
+               case XCB_BUTTON_INDEX_1:
+                       if (click_to_focus && cleaned_mask(e->state) == XCB_NONE) {
+                               replay = true;
+                               bool pff = pointer_follows_focus;
+                               bool pfm = pointer_follows_monitor;
+                               pointer_follows_focus = false;
+                               pointer_follows_monitor = false;
+                               grab_pointer(ACTION_FOCUS);
+                               pointer_follows_focus = pff;
+                               pointer_follows_monitor = pfm;
+                       } else {
+                               grab_pointer(pointer_actions[0]);
+                       }
+                       break;
+               case XCB_BUTTON_INDEX_2:
+                       grab_pointer(pointer_actions[1]);
+                       break;
+               case XCB_BUTTON_INDEX_3:
+                       grab_pointer(pointer_actions[2]);
+                       break;
        }
-
-       uint32_t values[] = {CLIENT_EVENT_MASK|FFP_MASK};
-       xcb_change_window_attributes(dpy, win, XCB_CW_EVENT_MASK, values);
+       xcb_allow_events(dpy, replay ? XCB_ALLOW_REPLAY_POINTER : XCB_ALLOW_SYNC_POINTER, e->time);
+       xcb_flush(dpy);
 }
 
-void motion_notify(xcb_generic_event_t *evt)
+void enter_notify(xcb_generic_event_t *evt)
 {
-       PUTS("motion notify");
-
-       xcb_motion_notify_event_t *e = (xcb_motion_notify_event_t *) evt;
+       xcb_enter_notify_event_t *e = (xcb_enter_notify_event_t *) evt;
        xcb_window_t win = e->event;
 
-       int dtime = e->time - last_motion_time;
-       if (dtime > 1000) {
-               last_motion_time = e->time;
-               last_motion_x = e->event_x;
-               last_motion_y = e->event_y;
+       if (e->mode != XCB_NOTIFY_MODE_NORMAL || e->detail == XCB_NOTIFY_DETAIL_INFERIOR) {
                return;
        }
 
-       int mdist = abs(e->event_x - last_motion_x) + abs(e->event_y - last_motion_y);
-       if (mdist < 10) {
+       xcb_point_t pt = {e->root_x, e->root_y};
+       monitor_t *m = monitor_from_point(pt);
+
+       if (m == NULL) {
                return;
        }
 
-       bool pfm_backup = pointer_follows_monitor;
-       bool pff_backup = pointer_follows_focus;
-       auto_raise = false;
-       pointer_follows_monitor = false;
+       bool pff = pointer_follows_focus;
+       bool pfm = pointer_follows_monitor;
        pointer_follows_focus = false;
-       coordinates_t loc;
-       if (locate_window(win, &loc)) {
-               if (loc.node != mon->desk->focus) {
-                       focus_node(loc.monitor, loc.desktop, loc.node);
-                       uint32_t values[] = {CLIENT_EVENT_MASK|FFP_MASK};
-                       xcb_change_window_attributes(dpy, win, XCB_CW_EVENT_MASK, values);
+       pointer_follows_monitor = false;
+       auto_raise = false;
+
+       desktop_t *d = m->desk;
+       node_t *n = NULL;
+
+       for (n = first_extrema(d->root); n != NULL; n = next_leaf(n, d->root)) {
+               if (n->id == win || (n->presel != NULL && n->presel->feedback == win)) {
+                       break;
                }
-       } else {
-               xcb_point_t pt = {e->root_x, e->root_y};
-               monitor_t *m = monitor_from_point(pt);
-               if (m != NULL && m != mon) {
+       }
+
+       if (n != mon->desk->focus) {
+               if (n != NULL) {
+                       focus_node(m, d, n);
+               } else if (m != mon) {
                        focus_node(m, m->desk, m->desk->focus);
                }
        }
-       pointer_follows_monitor = pfm_backup;
-       pointer_follows_focus = pff_backup;
+
+       pointer_follows_focus = pff;
+       pointer_follows_monitor = pfm;
        auto_raise = true;
 }
 
 void handle_state(monitor_t *m, desktop_t *d, node_t *n, xcb_atom_t state, unsigned int action)
 {
        if (state == ewmh->_NET_WM_STATE_FULLSCREEN) {
-               if (action == XCB_EWMH_WM_STATE_ADD)
-                       set_fullscreen(n, true);
-               else if (action == XCB_EWMH_WM_STATE_REMOVE)
-                       set_fullscreen(n, false);
-               else if (action == XCB_EWMH_WM_STATE_TOGGLE)
-                       set_fullscreen(n, !n->client->fullscreen);
+               if (action == XCB_EWMH_WM_STATE_ADD) {
+                       set_state(m, d, n, STATE_FULLSCREEN);
+               } else if (action == XCB_EWMH_WM_STATE_REMOVE) {
+                       if (n->client->state == STATE_FULLSCREEN) {
+                               set_state(m, d, n, n->client->last_state);
+                       }
+               } else if (action == XCB_EWMH_WM_STATE_TOGGLE) {
+                       set_state(m, d, n, IS_FULLSCREEN(n->client) ? n->client->last_state : STATE_FULLSCREEN);
+               }
                arrange(m, d);
+       } else if (state == ewmh->_NET_WM_STATE_BELOW) {
+               if (action == XCB_EWMH_WM_STATE_ADD) {
+                       set_layer(m, d, n, LAYER_BELOW);
+               } else if (action == XCB_EWMH_WM_STATE_REMOVE) {
+                       if (n->client->layer == LAYER_BELOW) {
+                               set_layer(m, d, n, n->client->last_layer);
+                       }
+               } else if (action == XCB_EWMH_WM_STATE_TOGGLE) {
+                       set_layer(m, d, n, n->client->layer == LAYER_BELOW ? n->client->last_layer : LAYER_BELOW);
+               }
+       } else if (state == ewmh->_NET_WM_STATE_ABOVE) {
+               if (action == XCB_EWMH_WM_STATE_ADD) {
+                       set_layer(m, d, n, LAYER_ABOVE);
+               } else if (action == XCB_EWMH_WM_STATE_REMOVE) {
+                       if (n->client->layer == LAYER_ABOVE) {
+                               set_layer(m, d, n, n->client->last_layer);
+                       }
+               } else if (action == XCB_EWMH_WM_STATE_TOGGLE) {
+                       set_layer(m, d, n, n->client->layer == LAYER_ABOVE ? n->client->last_layer : LAYER_ABOVE);
+               }
+       } else if (state == ewmh->_NET_WM_STATE_HIDDEN) {
+               if (action == XCB_EWMH_WM_STATE_ADD) {
+                       set_hidden(m, d, n, true);
+               } else if (action == XCB_EWMH_WM_STATE_REMOVE) {
+                       set_hidden(m, d, n, false);
+               } else if (action == XCB_EWMH_WM_STATE_TOGGLE) {
+                       set_hidden(m, d, n, !n->hidden);
+               }
        } else if (state == ewmh->_NET_WM_STATE_STICKY) {
-               if (action == XCB_EWMH_WM_STATE_ADD)
+               if (action == XCB_EWMH_WM_STATE_ADD) {
                        set_sticky(m, d, n, true);
-               else if (action == XCB_EWMH_WM_STATE_REMOVE)
+               } else if (action == XCB_EWMH_WM_STATE_REMOVE) {
                        set_sticky(m, d, n, false);
-               else if (action == XCB_EWMH_WM_STATE_TOGGLE)
-                       set_sticky(m, d, n, !n->client->sticky);
+               } else if (action == XCB_EWMH_WM_STATE_TOGGLE) {
+                       set_sticky(m, d, n, !n->sticky);
+               }
        } else if (state == ewmh->_NET_WM_STATE_DEMANDS_ATTENTION) {
-               if (action == XCB_EWMH_WM_STATE_ADD)
-                       set_urgency(m, d, n, true);
-               else if (action == XCB_EWMH_WM_STATE_REMOVE)
-                       set_urgency(m, d, n, false);
-               else if (action == XCB_EWMH_WM_STATE_TOGGLE)
-                       set_urgency(m, d, n, !n->client->urgent);
+               if (action == XCB_EWMH_WM_STATE_ADD) {
+                       set_urgent(m, d, n, true);
+               } else if (action == XCB_EWMH_WM_STATE_REMOVE) {
+                       set_urgent(m, d, n, false);
+               } else if (action == XCB_EWMH_WM_STATE_TOGGLE) {
+                       set_urgent(m, d, n, !n->client->urgent);
+               }
+#define HANDLE_WM_STATE(s)  \
+       } else if (state == ewmh->_NET_WM_STATE_##s) { \
+               if (action == XCB_EWMH_WM_STATE_ADD) { \
+                       n->client->wm_flags |= WM_FLAG_##s; \
+               } else if (action == XCB_EWMH_WM_STATE_REMOVE) { \
+                       n->client->wm_flags &= ~WM_FLAG_##s; \
+               } else if (action == XCB_EWMH_WM_STATE_TOGGLE) { \
+                       n->client->wm_flags ^= WM_FLAG_##s; \
+               } \
+               ewmh_wm_state_update(n);
+       HANDLE_WM_STATE(MODAL)
+       HANDLE_WM_STATE(MAXIMIZED_VERT)
+       HANDLE_WM_STATE(MAXIMIZED_HORZ)
+       HANDLE_WM_STATE(SHADED)
+       HANDLE_WM_STATE(SKIP_TASKBAR)
+       HANDLE_WM_STATE(SKIP_PAGER)
        }
+#undef HANDLE_WM_STATE
 }
 
 void process_error(xcb_generic_event_t *evt)
 {
        xcb_request_error_t *e = (xcb_request_error_t *) evt;
-       warn("Failed request: %s, %s: %d.\n", xcb_event_get_request_label(e->major_opcode), xcb_event_get_error_label(e->error_code), e->bad_value);
+       warn("Failed request: %s, %s: 0x%08X.\n", xcb_event_get_request_label(e->major_opcode), xcb_event_get_error_label(e->error_code), e->bad_value);
 }