use hir::{Name, Semantics};
use ra_ide_db::{
- defs::{classify_name, NameClass, NameDefinition},
+ defs::{classify_name, classify_name_ref, Definition, NameClass, NameRefClass},
RootDatabase,
};
use ra_prof::profile;
use ra_syntax::{
- ast::{self, HasQuotes, HasStringValue},
+ ast::{self, HasFormatSpecifier, HasQuotes, HasStringValue},
AstNode, AstToken, Direction, NodeOrToken, SyntaxElement,
SyntaxKind::*,
SyntaxToken, TextRange, WalkEvent, T,
};
use rustc_hash::FxHashMap;
-use crate::{
- call_info::call_info_for_token,
- references::{classify_name_ref, NameRefClass},
- Analysis, FileId,
-};
+use crate::{call_info::ActiveParameter, Analysis, FileId};
+use ast::FormatSpecifier;
pub(crate) use html::highlight_as_html;
pub use tags::{Highlight, HighlightModifier, HighlightModifiers, HighlightTag};
-#[derive(Debug)]
+#[derive(Debug, Clone)]
pub struct HighlightedRange {
pub range: TextRange,
pub highlight: Highlight,
pub binding_hash: Option<u64>,
}
+#[derive(Debug)]
+struct HighlightedRangeStack {
+ stack: Vec<Vec<HighlightedRange>>,
+}
+
+/// We use a stack to implement the flattening logic for the highlighted
+/// syntax ranges.
+impl HighlightedRangeStack {
+ fn new() -> Self {
+ Self { stack: vec![Vec::new()] }
+ }
+
+ fn push(&mut self) {
+ self.stack.push(Vec::new());
+ }
+
+ /// Flattens the highlighted ranges.
+ ///
+ /// For example `#[cfg(feature = "foo")]` contains the nested ranges:
+ /// 1) parent-range: Attribute [0, 23)
+ /// 2) child-range: String [16, 21)
+ ///
+ /// The following code implements the flattening, for our example this results to:
+ /// `[Attribute [0, 16), String [16, 21), Attribute [21, 23)]`
+ fn pop(&mut self) {
+ let children = self.stack.pop().unwrap();
+ let prev = self.stack.last_mut().unwrap();
+ let needs_flattening = !children.is_empty()
+ && !prev.is_empty()
+ && prev.last().unwrap().range.contains_range(children.first().unwrap().range);
+ if !needs_flattening {
+ prev.extend(children);
+ } else {
+ let mut parent = prev.pop().unwrap();
+ for ele in children {
+ assert!(parent.range.contains_range(ele.range));
+ let mut cloned = parent.clone();
+ parent.range = TextRange::new(parent.range.start(), ele.range.start());
+ cloned.range = TextRange::new(ele.range.end(), cloned.range.end());
+ if !parent.range.is_empty() {
+ prev.push(parent);
+ }
+ prev.push(ele);
+ parent = cloned;
+ }
+ if !parent.range.is_empty() {
+ prev.push(parent);
+ }
+ }
+ }
+
+ fn add(&mut self, range: HighlightedRange) {
+ self.stack
+ .last_mut()
+ .expect("during DFS traversal, the stack must not be empty")
+ .push(range)
+ }
+
+ fn flattened(mut self) -> Vec<HighlightedRange> {
+ assert_eq!(
+ self.stack.len(),
+ 1,
+ "after DFS traversal, the stack should only contain a single element"
+ );
+ let mut res = self.stack.pop().unwrap();
+ res.sort_by_key(|range| range.range.start());
+ // Check that ranges are sorted and disjoint
+ assert!(res
+ .iter()
+ .zip(res.iter().skip(1))
+ .all(|(left, right)| left.range.end() <= right.range.start()));
+ res
+ }
+}
+
pub(crate) fn highlight(
db: &RootDatabase,
file_id: FileId,
};
let mut bindings_shadow_count: FxHashMap<Name, u32> = FxHashMap::default();
- let mut res = Vec::new();
+ // We use a stack for the DFS traversal below.
+ // When we leave a node, the we use it to flatten the highlighted ranges.
+ let mut stack = HighlightedRangeStack::new();
let mut current_macro_call: Option<ast::MacroCall> = None;
+ let mut format_string: Option<SyntaxElement> = None;
// Walk all nodes, keeping track of whether we are inside a macro or not.
// If in macro, expand it first and highlight the expanded code.
for event in root.preorder_with_tokens() {
+ match &event {
+ WalkEvent::Enter(_) => stack.push(),
+ WalkEvent::Leave(_) => stack.pop(),
+ };
+
let event_range = match &event {
WalkEvent::Enter(it) => it.text_range(),
WalkEvent::Leave(it) => it.text_range(),
};
// Element outside of the viewport, no need to highlight
- if range_to_highlight.intersection(&event_range).is_none() {
+ if range_to_highlight.intersect(event_range).is_none() {
continue;
}
WalkEvent::Enter(Some(mc)) => {
current_macro_call = Some(mc.clone());
if let Some(range) = macro_call_range(&mc) {
- res.push(HighlightedRange {
+ stack.add(HighlightedRange {
range,
highlight: HighlightTag::Macro.into(),
binding_hash: None,
});
}
+ if let Some(name) = mc.is_macro_rules() {
+ if let Some((highlight, binding_hash)) = highlight_element(
+ &sema,
+ &mut bindings_shadow_count,
+ name.syntax().clone().into(),
+ ) {
+ stack.add(HighlightedRange {
+ range: name.syntax().text_range(),
+ highlight,
+ binding_hash,
+ });
+ }
+ }
continue;
}
WalkEvent::Leave(Some(mc)) => {
assert!(current_macro_call == Some(mc));
current_macro_call = None;
+ format_string = None;
continue;
}
_ => (),
};
let token = sema.descend_into_macros(token.clone());
let parent = token.parent();
+
+ // Check if macro takes a format string and remember it for highlighting later.
+ // The macros that accept a format string expand to a compiler builtin macros
+ // `format_args` and `format_args_nl`.
+ if let Some(fmt_macro_call) = parent.parent().and_then(ast::MacroCall::cast) {
+ if let Some(name) =
+ fmt_macro_call.path().and_then(|p| p.segment()).and_then(|s| s.name_ref())
+ {
+ match name.text().as_str() {
+ "format_args" | "format_args_nl" => {
+ format_string = parent
+ .children_with_tokens()
+ .filter(|t| t.kind() != WHITESPACE)
+ .nth(1)
+ .filter(|e| {
+ ast::String::can_cast(e.kind())
+ || ast::RawString::can_cast(e.kind())
+ })
+ }
+ _ => {}
+ }
+ }
+ }
+
// We only care Name and Name_ref
match (token.kind(), parent.kind()) {
(IDENT, NAME) | (IDENT, NAME_REF) => parent.into(),
if let Some(token) = element.as_token().cloned().and_then(ast::RawString::cast) {
let expanded = element_to_highlight.as_token().unwrap().clone();
- if highlight_injection(&mut res, &sema, token, expanded).is_some() {
+ if highlight_injection(&mut stack, &sema, token, expanded).is_some() {
continue;
}
}
+ let is_format_string = format_string.as_ref() == Some(&element_to_highlight);
+
if let Some((highlight, binding_hash)) =
- highlight_element(&sema, &mut bindings_shadow_count, element_to_highlight)
+ highlight_element(&sema, &mut bindings_shadow_count, element_to_highlight.clone())
{
- res.push(HighlightedRange { range, highlight, binding_hash });
+ stack.add(HighlightedRange { range, highlight, binding_hash });
+ if let Some(string) =
+ element_to_highlight.as_token().cloned().and_then(ast::String::cast)
+ {
+ stack.push();
+ if is_format_string {
+ string.lex_format_specifier(|piece_range, kind| {
+ if let Some(highlight) = highlight_format_specifier(kind) {
+ stack.add(HighlightedRange {
+ range: piece_range + range.start(),
+ highlight: highlight.into(),
+ binding_hash: None,
+ });
+ }
+ });
+ }
+ stack.pop();
+ } else if let Some(string) =
+ element_to_highlight.as_token().cloned().and_then(ast::RawString::cast)
+ {
+ stack.push();
+ if is_format_string {
+ string.lex_format_specifier(|piece_range, kind| {
+ if let Some(highlight) = highlight_format_specifier(kind) {
+ stack.add(HighlightedRange {
+ range: piece_range + range.start(),
+ highlight: highlight.into(),
+ binding_hash: None,
+ });
+ }
+ });
+ }
+ stack.pop();
+ }
}
}
- res
+ stack.flattened()
+}
+
+fn highlight_format_specifier(kind: FormatSpecifier) -> Option<HighlightTag> {
+ Some(match kind {
+ FormatSpecifier::Open
+ | FormatSpecifier::Close
+ | FormatSpecifier::Colon
+ | FormatSpecifier::Fill
+ | FormatSpecifier::Align
+ | FormatSpecifier::Sign
+ | FormatSpecifier::NumberSign
+ | FormatSpecifier::DollarSign
+ | FormatSpecifier::Dot
+ | FormatSpecifier::Asterisk
+ | FormatSpecifier::QuestionMark => HighlightTag::FormatSpecifier,
+ FormatSpecifier::Integer | FormatSpecifier::Zero => HighlightTag::NumericLiteral,
+ FormatSpecifier::Identifier => HighlightTag::Local,
+ })
}
fn macro_call_range(macro_call: &ast::MacroCall) -> Option<TextRange> {
}
}
- Some(TextRange::from_to(range_start, range_end))
+ Some(TextRange::new(range_start, range_end))
}
fn highlight_element(
let name = element.into_node().and_then(ast::Name::cast).unwrap();
let name_kind = classify_name(sema, &name);
- if let Some(NameClass::NameDefinition(NameDefinition::Local(local))) = &name_kind {
+ if let Some(NameClass::Definition(Definition::Local(local))) = &name_kind {
if let Some(name) = local.name(db) {
let shadow_count = bindings_shadow_count.entry(name.clone()).or_default();
*shadow_count += 1;
};
match name_kind {
- Some(NameClass::NameDefinition(def)) => {
+ Some(NameClass::Definition(def)) => {
highlight_name(db, def) | HighlightModifier::Definition
}
Some(NameClass::ConstReference(def)) => highlight_name(db, def),
}
// Highlight references like the definitions they resolve to
- NAME_REF if element.ancestors().any(|it| it.kind() == ATTR) => return None,
+ NAME_REF if element.ancestors().any(|it| it.kind() == ATTR) => {
+ Highlight::from(HighlightTag::Function) | HighlightModifier::Attribute
+ }
NAME_REF => {
let name_ref = element.into_node().and_then(ast::NameRef::cast).unwrap();
- let name_kind = classify_name_ref(sema, &name_ref)?;
-
- match name_kind {
- NameRefClass::NameDefinition(def) => {
- if let NameDefinition::Local(local) = &def {
- if let Some(name) = local.name(db) {
- let shadow_count =
- bindings_shadow_count.entry(name.clone()).or_default();
- binding_hash = Some(calc_binding_hash(&name, *shadow_count))
- }
- };
- highlight_name(db, def)
- }
- NameRefClass::FieldShorthand { .. } => HighlightTag::Field.into(),
+ match classify_name_ref(sema, &name_ref) {
+ Some(name_kind) => match name_kind {
+ NameRefClass::Definition(def) => {
+ if let Definition::Local(local) = &def {
+ if let Some(name) = local.name(db) {
+ let shadow_count =
+ bindings_shadow_count.entry(name.clone()).or_default();
+ binding_hash = Some(calc_binding_hash(&name, *shadow_count))
+ }
+ };
+ highlight_name(db, def)
+ }
+ NameRefClass::FieldShorthand { .. } => HighlightTag::Field.into(),
+ },
+ None => HighlightTag::UnresolvedReference.into(),
}
}
CHAR => HighlightTag::CharLiteral.into(),
LIFETIME => {
let h = Highlight::new(HighlightTag::Lifetime);
- dbg!(match element.parent().map(|it| it.kind()) {
+ match element.parent().map(|it| it.kind()) {
Some(LIFETIME_PARAM) | Some(LABEL) => h | HighlightModifier::Definition,
_ => h,
- })
+ }
}
k if k.is_keyword() => {
T![break]
| T![continue]
| T![else]
- | T![for]
| T![if]
| T![loop]
| T![match]
| T![return]
- | T![while] => h | HighlightModifier::Control,
+ | T![while]
+ | T![in] => h | HighlightModifier::ControlFlow,
+ T![for] if !is_child_of_impl(element) => h | HighlightModifier::ControlFlow,
T![unsafe] => h | HighlightModifier::Unsafe,
+ T![true] | T![false] => HighlightTag::BoolLiteral.into(),
+ T![self] => HighlightTag::SelfKeyword.into(),
_ => h,
}
}
}
}
-fn highlight_name(db: &RootDatabase, def: NameDefinition) -> Highlight {
+fn is_child_of_impl(element: SyntaxElement) -> bool {
+ match element.parent() {
+ Some(e) => e.kind() == IMPL_DEF,
+ _ => false,
+ }
+}
+
+fn highlight_name(db: &RootDatabase, def: Definition) -> Highlight {
match def {
- NameDefinition::Macro(_) => HighlightTag::Macro,
- NameDefinition::StructField(_) => HighlightTag::Field,
- NameDefinition::ModuleDef(def) => match def {
+ Definition::Macro(_) => HighlightTag::Macro,
+ Definition::Field(_) => HighlightTag::Field,
+ Definition::ModuleDef(def) => match def {
hir::ModuleDef::Module(_) => HighlightTag::Module,
hir::ModuleDef::Function(_) => HighlightTag::Function,
hir::ModuleDef::Adt(hir::Adt::Struct(_)) => HighlightTag::Struct,
hir::ModuleDef::Adt(hir::Adt::Union(_)) => HighlightTag::Union,
hir::ModuleDef::EnumVariant(_) => HighlightTag::EnumVariant,
hir::ModuleDef::Const(_) => HighlightTag::Constant,
- hir::ModuleDef::Static(_) => HighlightTag::Static,
hir::ModuleDef::Trait(_) => HighlightTag::Trait,
hir::ModuleDef::TypeAlias(_) => HighlightTag::TypeAlias,
hir::ModuleDef::BuiltinType(_) => HighlightTag::BuiltinType,
+ hir::ModuleDef::Static(s) => {
+ let mut h = Highlight::new(HighlightTag::Static);
+ if s.is_mut(db) {
+ h |= HighlightModifier::Mutable;
+ }
+ return h;
+ }
},
- NameDefinition::SelfType(_) => HighlightTag::SelfType,
- NameDefinition::TypeParam(_) => HighlightTag::TypeParam,
+ Definition::SelfType(_) => HighlightTag::SelfType,
+ Definition::TypeParam(_) => HighlightTag::TypeParam,
// FIXME: distinguish between locals and parameters
- NameDefinition::Local(local) => {
+ Definition::Local(local) => {
let mut h = Highlight::new(HighlightTag::Local);
if local.is_mut(db) || local.ty(db).is_mutable_reference() {
h |= HighlightModifier::Mutable;
}
fn highlight_name_by_syntax(name: ast::Name) -> Highlight {
- let default = HighlightTag::Function.into();
+ let default = HighlightTag::UnresolvedReference;
let parent = match name.syntax().parent() {
Some(it) => it,
- _ => return default,
+ _ => return default.into(),
};
- match parent.kind() {
- STRUCT_DEF => HighlightTag::Struct.into(),
- ENUM_DEF => HighlightTag::Enum.into(),
- UNION_DEF => HighlightTag::Union.into(),
- TRAIT_DEF => HighlightTag::Trait.into(),
- TYPE_ALIAS_DEF => HighlightTag::TypeAlias.into(),
- TYPE_PARAM => HighlightTag::TypeParam.into(),
- RECORD_FIELD_DEF => HighlightTag::Field.into(),
+ let tag = match parent.kind() {
+ STRUCT_DEF => HighlightTag::Struct,
+ ENUM_DEF => HighlightTag::Enum,
+ UNION_DEF => HighlightTag::Union,
+ TRAIT_DEF => HighlightTag::Trait,
+ TYPE_ALIAS_DEF => HighlightTag::TypeAlias,
+ TYPE_PARAM => HighlightTag::TypeParam,
+ RECORD_FIELD_DEF => HighlightTag::Field,
+ MODULE => HighlightTag::Module,
+ FN_DEF => HighlightTag::Function,
+ CONST_DEF => HighlightTag::Constant,
+ STATIC_DEF => HighlightTag::Static,
+ ENUM_VARIANT => HighlightTag::EnumVariant,
+ BIND_PAT => HighlightTag::Local,
_ => default,
- }
+ };
+
+ tag.into()
}
fn highlight_injection(
- acc: &mut Vec<HighlightedRange>,
+ acc: &mut HighlightedRangeStack,
sema: &Semantics<RootDatabase>,
literal: ast::RawString,
expanded: SyntaxToken,
) -> Option<()> {
- let call_info = call_info_for_token(&sema, expanded)?;
- let idx = call_info.active_parameter?;
- let name = call_info.signature.parameter_names.get(idx)?;
- if name != "ra_fixture" {
+ let active_parameter = ActiveParameter::at_token(&sema, expanded)?;
+ if !active_parameter.name.starts_with("ra_fixture") {
return None;
}
let value = literal.value()?;
let (analysis, tmp_file_id) = Analysis::from_single_file(value);
if let Some(range) = literal.open_quote_text_range() {
- acc.push(HighlightedRange {
+ acc.add(HighlightedRange {
range,
highlight: HighlightTag::StringLiteral.into(),
binding_hash: None,
for mut h in analysis.highlight(tmp_file_id).unwrap() {
if let Some(r) = literal.map_range_up(h.range) {
h.range = r;
- acc.push(h)
+ acc.add(h)
}
}
if let Some(range) = literal.close_quote_text_range() {
- acc.push(HighlightedRange {
+ acc.add(HighlightedRange {
range,
highlight: HighlightTag::StringLiteral.into(),
binding_hash: None,