-use std::iter;
-
use hir::Semantics;
-use ide_db::{helpers::pick_best_token, RootDatabase};
+use ide_db::{
+ helpers::{insert_whitespace_into_node::insert_ws_into, pick_best_token},
+ RootDatabase,
+};
use itertools::Itertools;
-use syntax::{ast, ted, AstNode, NodeOrToken, SyntaxKind, SyntaxNode, WalkEvent, T};
+use syntax::{ast, ted, AstNode, SyntaxKind, SyntaxNode};
use crate::FilePosition;
SyntaxKind::IDENT => 1,
_ => 0,
})?;
- let descended = sema.descend_into_macros(tok.clone());
- if let Some(attr) = descended.ancestors().find_map(ast::Attr::cast) {
- if let Some((path, tt)) = attr.as_simple_call() {
- if path == "derive" {
- let mut tt = tt.syntax().children_with_tokens().skip(1).join("");
- tt.pop();
- return sema
- .expand_derive_macro(&attr)
- .map(insert_whitespaces)
- .map(|expansion| ExpandedMacro { name: tt, expansion });
- }
+
+ // due to how Rust Analyzer works internally, we need to special case derive attributes,
+ // otherwise they might not get found, e.g. here with the cursor at $0 `#[attr]` would expand:
+ // ```
+ // #[attr]
+ // #[derive($0Foo)]
+ // struct Bar;
+ // ```
+
+ let derive = sema.descend_into_macros(tok.clone()).iter().find_map(|descended| {
+ let attr = descended.ancestors().find_map(ast::Attr::cast)?;
+ let (path, tt) = attr.as_simple_call()?;
+ if path == "derive" {
+ let mut tt = tt.syntax().children_with_tokens().skip(1).join("");
+ tt.pop();
+ let expansions = sema.expand_derive_macro(&attr)?;
+ Some(ExpandedMacro {
+ name: tt,
+ expansion: expansions.into_iter().map(insert_ws_into).join(""),
+ })
+ } else {
+ None
}
+ });
+
+ if derive.is_some() {
+ return derive;
}
+
+ // FIXME: Intermix attribute and bang! expansions
+ // currently we only recursively expand one of the two types
let mut expanded = None;
let mut name = None;
for node in tok.ancestors() {
// FIXME:
// macro expansion may lose all white space information
// But we hope someday we can use ra_fmt for that
- let expansion = insert_whitespaces(expanded?);
+ let expansion = insert_ws_into(expanded?).to_string();
Some(ExpandedMacro { name: name.unwrap_or_else(|| "???".to_owned()), expansion })
}
Some(expanded)
}
-// FIXME: It would also be cool to share logic here and in the mbe tests,
-// which are pretty unreadable at the moment.
-fn insert_whitespaces(syn: SyntaxNode) -> String {
- use SyntaxKind::*;
- let mut res = String::new();
-
- let mut indent = 0;
- let mut last: Option<SyntaxKind> = None;
-
- for event in syn.preorder_with_tokens() {
- let token = match event {
- WalkEvent::Enter(NodeOrToken::Token(token)) => token,
- WalkEvent::Leave(NodeOrToken::Node(node))
- if matches!(node.kind(), ATTR | MATCH_ARM | STRUCT | ENUM | UNION | FN | IMPL) =>
- {
- res.push('\n');
- res.extend(iter::repeat(" ").take(2 * indent));
- continue;
- }
- _ => continue,
- };
- let is_next = |f: fn(SyntaxKind) -> bool, default| -> bool {
- token.next_token().map(|it| f(it.kind())).unwrap_or(default)
- };
- let is_last =
- |f: fn(SyntaxKind) -> bool, default| -> bool { last.map(f).unwrap_or(default) };
-
- match token.kind() {
- k if is_text(k) && is_next(|it| !it.is_punct(), true) => {
- res.push_str(token.text());
- res.push(' ');
- }
- L_CURLY if is_next(|it| it != R_CURLY, true) => {
- indent += 1;
- if is_last(is_text, false) {
- res.push(' ');
- }
- res.push_str("{\n");
- res.extend(iter::repeat(" ").take(2 * indent));
- }
- R_CURLY if is_last(|it| it != L_CURLY, true) => {
- indent = indent.saturating_sub(1);
- res.push('\n');
- res.extend(iter::repeat(" ").take(2 * indent));
- res.push_str("}");
- }
- R_CURLY => {
- res.push_str("}\n");
- res.extend(iter::repeat(" ").take(2 * indent));
- }
- LIFETIME_IDENT if is_next(|it| it == IDENT, true) => {
- res.push_str(token.text());
- res.push(' ');
- }
- T![;] => {
- res.push_str(";\n");
- res.extend(iter::repeat(" ").take(2 * indent));
- }
- T![->] => res.push_str(" -> "),
- T![=] => res.push_str(" = "),
- T![=>] => res.push_str(" => "),
- _ => res.push_str(token.text()),
- }
-
- last = Some(token.kind());
- }
-
- return res;
-
- fn is_text(k: SyntaxKind) -> bool {
- k.is_keyword() || k.is_literal() || k == IDENT
- }
-}
-
#[cfg(test)]
mod tests {
use expect_test::{expect, Expect};
expect.assert_eq(&actual);
}
+ #[test]
+ fn macro_expand_as_keyword() {
+ check(
+ r#"
+macro_rules! bar {
+ ($i:tt) => { $i as _ }
+}
+fn main() {
+ let x: u64 = ba$0r!(5i64);
+}
+"#,
+ expect![[r#"
+ bar
+ 5i64 as _"#]],
+ );
+ }
+
#[test]
fn macro_expand_recursive_expansion() {
check(
fn macro_expand_derive() {
check(
r#"
-#[rustc_builtin_macro]
-pub macro Clone {}
+//- proc_macros: identity
+//- minicore: clone, derive
+#[proc_macros::identity]
#[derive(C$0lone)]
struct Foo {}
"#,
expect![[r#"
Clone
- impl< >crate::clone::Clone for Foo< >{}
+ impl< >core::clone::Clone for Foo< >{}
"#]],
);
fn macro_expand_derive2() {
check(
r#"
-#[rustc_builtin_macro]
-pub macro Clone {}
-#[rustc_builtin_macro]
-pub macro Copy {}
+//- minicore: copy, clone, derive
#[derive(Cop$0y)]
#[derive(Clone)]
"#,
expect![[r#"
Copy
- impl< >crate::marker::Copy for Foo< >{}
+ impl< >core::marker::Copy for Foo< >{}
+
+ "#]],
+ );
+ }
+
+ #[test]
+ fn macro_expand_derive_multi() {
+ check(
+ r#"
+//- minicore: copy, clone, derive
+
+#[derive(Cop$0y, Clone)]
+struct Foo {}
+"#,
+ expect![[r#"
+ Copy, Clone
+ impl< >core::marker::Copy for Foo< >{}
+
+ impl< >core::clone::Clone for Foo< >{}
"#]],
);
projects / rust.git / blobdiff