Merge commit 'e228f0c16ea8c34794a6285bf57aab627c26b147' into libgccjit-codegen

[rust.git] / compiler / rustc_codegen_gcc / src / mono_item.rs

diff --git a/compiler/rustc_codegen_gcc/src/mono_item.rs b/compiler/rustc_codegen_gcc/src/mono_item.rs
index c261efbbc559ffc8628d6f9d18338e9802b07c67..f9ec933dd3abc24e46075c8a8ff29e016d3530e0 100644 (file)
--- a/compiler/rustc_codegen_gcc/src/mono_item.rs
+++ b/compiler/rustc_codegen_gcc/src/mono_item.rs
@@ -26,12 +26,7 @@ fn predefine_static(&self, def_id: DefId, _linkage: Linkage, _visibility: Visibi
             )
         });
 
-        // TODO
-        /*unsafe {
-            llvm::LLVMRustSetLinkage(global, base::linkage_to_llvm(linkage));
-            llvm::LLVMRustSetVisibility(global, base::visibility_to_llvm(visibility));
-        }*/
-
+        // TODO(antoyo): set linkage and visibility.
         self.instances.borrow_mut().insert(instance, global);
     }
 
@@ -43,17 +38,8 @@ fn predefine_fn(&self, instance: Instance<'tcx>, linkage: Linkage, _visibility:
         let _decl = self.declare_fn(symbol_name, &fn_abi);
         //let attrs = self.tcx.codegen_fn_attrs(instance.def_id());
 
-        // TODO: call set_link_section() to allow initializing argc/argv.
-        //base::set_link_section(decl, &attrs);
-        /*if linkage == Linkage::LinkOnceODR || linkage == Linkage::WeakODR {
-            llvm::SetUniqueComdat(self.llmod, decl);
-        }*/
-
-        //debug!("predefine_fn: instance = {:?}", instance);
-
-        // TODO: use inline attribute from there in linkage.set() above:
-        //attributes::from_fn_attrs(self, decl, instance);
-
-        //self.instances.borrow_mut().insert(instance, decl);
+        // TODO(antoyo): call set_link_section() to allow initializing argc/argv.
+        // TODO(antoyo): set unique comdat.
+        // TODO(antoyo): use inline attribute from there in linkage.set() above.
     }
 }