///
/// ### Example
/// ```rust
- /// // Bad
/// // format!() returns a `String`
/// let s: String = format!("hello").into();
+ /// ```
///
- /// // Good
+ /// Use instead:
+ /// ```rust
/// let s: String = format!("hello");
/// ```
+ #[clippy::version = "1.45.0"]
pub USELESS_CONVERSION,
complexity,
"calls to `Into`, `TryInto`, `From`, `TryFrom`, or `IntoIter` which perform useless conversions to the same type"
impl_lint_pass!(UselessConversion => [USELESS_CONVERSION]);
-#[allow(clippy::too_many_lines)]
+#[expect(clippy::too_many_lines)]
impl<'tcx> LateLintPass<'tcx> for UselessConversion {
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) {
if e.span.from_expansion() {
},
ExprKind::MethodCall(name, .., args, _) => {
- if is_trait_method(cx, e, sym::into_trait) && &*name.ident.as_str() == "into" {
+ if is_trait_method(cx, e, sym::Into) && name.ident.as_str() == "into" {
let a = cx.typeck_results().expr_ty(e);
let b = cx.typeck_results().expr_ty(&args[0]);
if same_type_and_consts(a, b) {
}
}
if_chain! {
- if is_trait_method(cx, e, sym::try_into_trait) && name.ident.name == sym::try_into;
+ if is_trait_method(cx, e, sym::TryInto) && name.ident.name == sym::try_into;
let a = cx.typeck_results().expr_ty(e);
let b = cx.typeck_results().expr_ty(&args[0]);
- if is_type_diagnostic_item(cx, a, sym::result_type);
+ if is_type_diagnostic_item(cx, a, sym::Result);
if let ty::Adt(_, substs) = a.kind();
if let Some(a_type) = substs.types().next();
if same_type_and_consts(a_type, b);
let b = cx.typeck_results().expr_ty(&args[0]);
if_chain! {
if match_def_path(cx, def_id, &paths::TRY_FROM);
- if is_type_diagnostic_item(cx, a, sym::result_type);
+ if is_type_diagnostic_item(cx, a, sym::Result);
if let ty::Adt(_, substs) = a.kind();
if let Some(a_type) = substs.types().next();
if same_type_and_consts(a_type, b);