-use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
-use rustc::{declare_lint, lint_array};
+use crate::utils::{get_trait_def_id, span_lint, trait_ref_of_method};
use if_chain::if_chain;
use rustc::hir;
use rustc::hir::intravisit::{walk_expr, NestedVisitorMap, Visitor};
-use syntax::ast;
-use crate::utils::{get_trait_def_id, span_lint};
-
-/// **What it does:** Lints for suspicious operations in impls of arithmetic operators, e.g.
-/// subtracting elements in an Add impl.
-///
-/// **Why this is bad?** This is probably a typo or copy-and-paste error and not intended.
-///
-/// **Known problems:** None.
-///
-/// **Example:**
-/// ```rust
-/// impl Add for Foo {
-/// type Output = Foo;
-///
-/// fn add(self, other: Foo) -> Foo {
-/// Foo(self.0 - other.0)
-/// }
-/// }
-/// ```
+use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
+use rustc::{declare_tool_lint, lint_array};
+
declare_clippy_lint! {
+ /// **What it does:** Lints for suspicious operations in impls of arithmetic operators, e.g.
+ /// subtracting elements in an Add impl.
+ ///
+ /// **Why this is bad?** This is probably a typo or copy-and-paste error and not intended.
+ ///
+ /// **Known problems:** None.
+ ///
+ /// **Example:**
+ /// ```ignore
+ /// impl Add for Foo {
+ /// type Output = Foo;
+ ///
+ /// fn add(self, other: Foo) -> Foo {
+ /// Foo(self.0 - other.0)
+ /// }
+ /// }
+ /// ```
pub SUSPICIOUS_ARITHMETIC_IMPL,
correctness,
"suspicious use of operators in impl of arithmetic trait"
}
-/// **What it does:** Lints for suspicious operations in impls of OpAssign, e.g.
-/// subtracting elements in an AddAssign impl.
-///
-/// **Why this is bad?** This is probably a typo or copy-and-paste error and not intended.
-///
-/// **Known problems:** None.
-///
-/// **Example:**
-/// ```rust
-/// impl AddAssign for Foo {
-/// fn add_assign(&mut self, other: Foo) {
-/// *self = *self - other;
-/// }
-/// }
-/// ```
declare_clippy_lint! {
+ /// **What it does:** Lints for suspicious operations in impls of OpAssign, e.g.
+ /// subtracting elements in an AddAssign impl.
+ ///
+ /// **Why this is bad?** This is probably a typo or copy-and-paste error and not intended.
+ ///
+ /// **Known problems:** None.
+ ///
+ /// **Example:**
+ /// ```ignore
+ /// impl AddAssign for Foo {
+ /// fn add_assign(&mut self, other: Foo) {
+ /// *self = *self - other;
+ /// }
+ /// }
+ /// ```
pub SUSPICIOUS_OP_ASSIGN_IMPL,
correctness,
"suspicious use of operators in impl of OpAssign trait"
fn get_lints(&self) -> LintArray {
lint_array![SUSPICIOUS_ARITHMETIC_IMPL, SUSPICIOUS_OP_ASSIGN_IMPL]
}
+
+ fn name(&self) -> &'static str {
+ "SuspiciousImpl"
+ }
}
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for SuspiciousImpl {
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx hir::Expr) {
if let hir::ExprKind::Binary(binop, _, _) = expr.node {
match binop.node {
- | hir::BinOpKind::Eq
+ hir::BinOpKind::Eq
| hir::BinOpKind::Lt
| hir::BinOpKind::Le
| hir::BinOpKind::Ne
| hir::BinOpKind::Ge
- | hir::BinOpKind::Gt
- => return,
+ | hir::BinOpKind::Gt => return,
_ => {},
}
// Check if the binary expression is part of another bi/unary expression
// as a child node
- let mut parent_expr = cx.tcx.hir.get_parent_node(expr.id);
- while parent_expr != ast::CRATE_NODE_ID {
- if let hir::Node::Expr(e) = cx.tcx.hir.get(parent_expr) {
+ let mut parent_expr = cx.tcx.hir().get_parent_node_by_hir_id(expr.hir_id);
+ while parent_expr != hir::CRATE_HIR_ID {
+ if let hir::Node::Expr(e) = cx.tcx.hir().get_by_hir_id(parent_expr) {
match e.node {
hir::ExprKind::Binary(..)
| hir::ExprKind::Unary(hir::UnOp::UnNot, _)
_ => {},
}
}
- parent_expr = cx.tcx.hir.get_parent_node(parent_expr);
+ parent_expr = cx.tcx.hir().get_parent_node_by_hir_id(parent_expr);
}
// as a parent node
- let mut visitor = BinaryExprVisitor {
- in_binary_expr: false,
- };
+ let mut visitor = BinaryExprVisitor { in_binary_expr: false };
walk_expr(&mut visitor, expr);
if visitor.in_binary_expr {
cx,
SUSPICIOUS_ARITHMETIC_IMPL,
binop.span,
- &format!(
- r#"Suspicious use of binary operator in `{}` impl"#,
- impl_trait
- ),
+ &format!(r#"Suspicious use of binary operator in `{}` impl"#, impl_trait),
);
}
cx,
SUSPICIOUS_OP_ASSIGN_IMPL,
binop.span,
- &format!(
- r#"Suspicious use of binary operator in `{}` impl"#,
- impl_trait
- ),
+ &format!(r#"Suspicious use of binary operator in `{}` impl"#, impl_trait),
);
}
}
}
// Get the actually implemented trait
- let parent_fn = cx.tcx.hir.get_parent(expr.id);
- let parent_impl = cx.tcx.hir.get_parent(parent_fn);
+ let parent_fn = cx.tcx.hir().get_parent_item(expr.hir_id);
if_chain! {
- if parent_impl != ast::CRATE_NODE_ID;
- if let hir::Node::Item(item) = cx.tcx.hir.get(parent_impl);
- if let hir::ItemKind::Impl(_, _, _, _, Some(ref trait_ref), _, _) = item.node;
+ if let Some(trait_ref) = trait_ref_of_method(cx, parent_fn);
if let Some(idx) = trait_ids.iter().position(|&tid| tid == trait_ref.path.def.def_id());
if binop != expected_ops[idx];
then{
match expr.node {
hir::ExprKind::Binary(..)
| hir::ExprKind::Unary(hir::UnOp::UnNot, _)
- | hir::ExprKind::Unary(hir::UnOp::UnNeg, _) => {
- self.in_binary_expr = true
- },
+ | hir::ExprKind::Unary(hir::UnOp::UnNeg, _) => self.in_binary_expr = true,
_ => {},
}
projects / rust.git / blobdiff