-use crate::utils::span_lint_and_sugg;
+use crate::utils::{in_macro, span_lint_and_sugg};
use if_chain::if_chain;
+use rustc_ast::{Item, ItemKind, UseTreeKind};
use rustc_errors::Applicability;
use rustc_lint::{EarlyContext, EarlyLintPass};
use rustc_session::{declare_lint_pass, declare_tool_lint};
use rustc_span::edition::Edition;
-use syntax::ast::{Item, ItemKind, UseTreeKind};
declare_clippy_lint! {
/// **What it does:** Checking for imports with single component use path.
///
/// **Example:**
///
- /// ```rust, ignore
+ /// ```rust,ignore
/// use regex;
///
/// fn main() {
/// }
/// ```
/// Better as
- /// ```rust, ignore
+ /// ```rust,ignore
/// fn main() {
/// regex::Regex::new(r"^\d{4}-\d{2}-\d{2}$").unwrap();
/// }
impl EarlyLintPass for SingleComponentPathImports {
fn check_item(&mut self, cx: &EarlyContext<'_>, item: &Item) {
if_chain! {
- if cx.sess.opts.edition == Edition::Edition2018;
- if !item.vis.node.is_pub();
+ if !in_macro(item.span);
+ if cx.sess.opts.edition >= Edition::Edition2018;
+ if !item.vis.kind.is_pub();
if let ItemKind::Use(use_tree) = &item.kind;
if let segments = &use_tree.prefix.segments;
if segments.len() == 1;