use crate::utils::{get_trait_def_id, paths, span_lint};
-use rustc::hir::*;
-use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
-use rustc::{declare_tool_lint, lint_array};
+use rustc_hir::{Impl, Item, ItemKind};
+use rustc_lint::{LateContext, LateLintPass};
+use rustc_session::{declare_lint_pass, declare_tool_lint};
-/// **What it does:** Checks for mis-uses of the serde API.
-///
-/// **Why is this bad?** Serde is very finnicky about how its API should be
-/// used, but the type system can't be used to enforce it (yet?).
-///
-/// **Known problems:** None.
-///
-/// **Example:** Implementing `Visitor::visit_string` but not
-/// `Visitor::visit_str`.
declare_clippy_lint! {
+ /// **What it does:** Checks for mis-uses of the serde API.
+ ///
+ /// **Why is this bad?** Serde is very finnicky about how its API should be
+ /// used, but the type system can't be used to enforce it (yet?).
+ ///
+ /// **Known problems:** None.
+ ///
+ /// **Example:** Implementing `Visitor::visit_string` but not
+ /// `Visitor::visit_str`.
pub SERDE_API_MISUSE,
correctness,
"various things that will negatively affect your serde experience"
}
-#[derive(Copy, Clone)]
-pub struct Serde;
+declare_lint_pass!(SerdeApi => [SERDE_API_MISUSE]);
-impl LintPass for Serde {
- fn get_lints(&self) -> LintArray {
- lint_array!(SERDE_API_MISUSE)
- }
-}
-
-impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Serde {
- fn check_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx Item) {
- if let ItemKind::Impl(_, _, _, _, Some(ref trait_ref), _, ref items) = item.node {
- let did = trait_ref.path.def.def_id();
+impl<'tcx> LateLintPass<'tcx> for SerdeApi {
+ fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx Item<'_>) {
+ if let ItemKind::Impl(Impl {
+ of_trait: Some(ref trait_ref),
+ items,
+ ..
+ }) = item.kind
+ {
+ let did = trait_ref.path.res.def_id();
if let Some(visit_did) = get_trait_def_id(cx, &paths::SERDE_DE_VISITOR) {
if did == visit_did {
let mut seen_str = None;