-use crate::utils::{snippet_with_applicability, span_lint_and_sugg};
+use crate::utils::{in_macro, snippet_with_applicability, span_lint_and_sugg};
use if_chain::if_chain;
-use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
-use rustc::{declare_lint_pass, declare_tool_lint};
use rustc_errors::Applicability;
+use rustc_lint::{EarlyContext, EarlyLintPass};
+use rustc_session::{declare_lint_pass, declare_tool_lint};
use syntax::ast::{Expr, ExprKind, UnOp};
declare_clippy_lint! {
/// the suggested fix for `x = **&&y` is `x = *&y`, which is still incorrect.
///
/// **Example:**
- /// ```rust
+ /// ```rust,ignore
/// let a = f(*&mut b);
/// let c = *&d;
/// ```
declare_lint_pass!(DerefAddrOf => [DEREF_ADDROF]);
fn without_parens(mut e: &Expr) -> &Expr {
- while let ExprKind::Paren(ref child_e) = e.node {
+ while let ExprKind::Paren(ref child_e) = e.kind {
e = child_e;
}
e
impl EarlyLintPass for DerefAddrOf {
fn check_expr(&mut self, cx: &EarlyContext<'_>, e: &Expr) {
if_chain! {
- if let ExprKind::Unary(UnOp::Deref, ref deref_target) = e.node;
- if let ExprKind::AddrOf(_, ref addrof_target) = without_parens(deref_target).node;
+ if let ExprKind::Unary(UnOp::Deref, ref deref_target) = e.kind;
+ if let ExprKind::AddrOf(_, _, ref addrof_target) = without_parens(deref_target).kind;
+ if !in_macro(addrof_target.span);
then {
let mut applicability = Applicability::MachineApplicable;
span_lint_and_sugg(
/// **Example:**
/// ```rust
/// struct Point(u32, u32);
- /// let point = Foo(30, 20);
- /// let x = (&point).x;
+ /// let point = Point(30, 20);
+ /// let x = (&point).0;
/// ```
pub REF_IN_DEREF,
complexity,
impl EarlyLintPass for RefInDeref {
fn check_expr(&mut self, cx: &EarlyContext<'_>, e: &Expr) {
if_chain! {
- if let ExprKind::Field(ref object, _) = e.node;
- if let ExprKind::Paren(ref parened) = object.node;
- if let ExprKind::AddrOf(_, ref inner) = parened.node;
+ if let ExprKind::Field(ref object, _) = e.kind;
+ if let ExprKind::Paren(ref parened) = object.kind;
+ if let ExprKind::AddrOf(_, _, ref inner) = parened.kind;
then {
let mut applicability = Applicability::MachineApplicable;
span_lint_and_sugg(