-use crate::utils::{snippet_with_applicability, span_lint_and_sugg};
+use crate::utils::{in_macro, snippet_with_applicability, span_lint_and_sugg};
use if_chain::if_chain;
use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
-use rustc::{declare_tool_lint, lint_array};
+use rustc::{declare_lint_pass, declare_tool_lint};
use rustc_errors::Applicability;
use syntax::ast::{Expr, ExprKind, UnOp};
/// the suggested fix for `x = **&&y` is `x = *&y`, which is still incorrect.
///
/// **Example:**
- /// ```rust
+ /// ```rust,ignore
/// let a = f(*&mut b);
/// let c = *&d;
/// ```
"use of `*&` or `*&mut` in an expression"
}
-pub struct Pass;
-
-impl LintPass for Pass {
- fn get_lints(&self) -> LintArray {
- lint_array!(DEREF_ADDROF)
- }
-
- fn name(&self) -> &'static str {
- "DerefAddrOf"
- }
-}
+declare_lint_pass!(DerefAddrOf => [DEREF_ADDROF]);
fn without_parens(mut e: &Expr) -> &Expr {
while let ExprKind::Paren(ref child_e) = e.node {
e
}
-impl EarlyLintPass for Pass {
+impl EarlyLintPass for DerefAddrOf {
fn check_expr(&mut self, cx: &EarlyContext<'_>, e: &Expr) {
if_chain! {
if let ExprKind::Unary(UnOp::Deref, ref deref_target) = e.node;
if let ExprKind::AddrOf(_, ref addrof_target) = without_parens(deref_target).node;
+ if !in_macro(addrof_target.span);
then {
let mut applicability = Applicability::MachineApplicable;
span_lint_and_sugg(
/// **Example:**
/// ```rust
/// struct Point(u32, u32);
- /// let point = Foo(30, 20);
- /// let x = (&point).x;
+ /// let point = Point(30, 20);
+ /// let x = (&point).0;
/// ```
pub REF_IN_DEREF,
complexity,
"Use of reference in auto dereference expression."
}
-pub struct DerefPass;
-
-impl LintPass for DerefPass {
- fn get_lints(&self) -> LintArray {
- lint_array!(REF_IN_DEREF)
- }
-
- fn name(&self) -> &'static str {
- "RefInDeref"
- }
-}
+declare_lint_pass!(RefInDeref => [REF_IN_DEREF]);
-impl EarlyLintPass for DerefPass {
+impl EarlyLintPass for RefInDeref {
fn check_expr(&mut self, cx: &EarlyContext<'_>, e: &Expr) {
if_chain! {
if let ExprKind::Field(ref object, _) = e.node;