-use crate::utils::{last_path_segment, match_def_path, paths, snippet, span_lint_and_sugg};
+use crate::utils::{last_path_segment, snippet, span_lint_and_sugg};
use rustc_hir::{GenericArg, Mutability, Ty, TyKind};
use rustc_lint::{LateContext, LateLintPass};
use rustc_session::{declare_lint_pass, declare_tool_lint};
/// **Why is this bad?** Since `&` is Copy, it's useless to have a
/// reference on `Option<&T>`.
///
- /// **Known problems:** None.
+ /// **Known problems:** It may be irrevelent to use this lint on
+ /// public API code as it will make a breaking change to apply it.
///
/// **Example:**
///
/// let x: Option<&u32> = Some(&0u32);
/// ```
pub REF_OPTION_REF,
- style,
+ pedantic,
"use `Option<&T>` instead of `&Option<&T>`"
}
cx,
REF_OPTION_REF,
ty.span,
- "since & implements Copy trait, &Option<&T> can be simplifyied into Option<&T>",
+ "since `&` implements the `Copy` trait, `&Option<&T>` can be simplified to `Option<&T>`",
"try",
format!("Option<{}>", &snippet(cx, inner_ty.span, "..")),
- Applicability::Unspecified,
+ Applicability::MaybeIncorrect,
);
}
}