/// pub fn internal_fn() { }
/// }
/// ```
+ #[clippy::version = "1.44.0"]
pub REDUNDANT_PUB_CRATE,
nursery,
"Using `pub(crate)` visibility on items that are not crate visible due to the visibility of the module that contains them."
impl<'tcx> LateLintPass<'tcx> for RedundantPubCrate {
fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx Item<'tcx>) {
if let VisibilityKind::Crate { .. } = item.vis.node {
- if !cx.access_levels.is_exported(item.hir_id()) {
- if let Some(false) = self.is_exported.last() {
- let span = item.span.with_hi(item.ident.span.hi());
- let descr = cx.tcx.def_kind(item.def_id).descr(item.def_id.to_def_id());
- span_lint_and_then(
- cx,
- REDUNDANT_PUB_CRATE,
- span,
- &format!("pub(crate) {} inside private module", descr),
- |diag| {
- diag.span_suggestion(
- item.vis.span,
- "consider using",
- "pub".to_string(),
- Applicability::MachineApplicable,
- );
- },
- );
- }
+ if !cx.access_levels.is_exported(item.def_id) && self.is_exported.last() == Some(&false) {
+ let span = item.span.with_hi(item.ident.span.hi());
+ let descr = cx.tcx.def_kind(item.def_id).descr(item.def_id.to_def_id());
+ span_lint_and_then(
+ cx,
+ REDUNDANT_PUB_CRATE,
+ span,
+ &format!("pub(crate) {} inside private module", descr),
+ |diag| {
+ diag.span_suggestion(
+ item.vis.span,
+ "consider using",
+ "pub".to_string(),
+ Applicability::MachineApplicable,
+ );
+ },
+ );
}
}
if let ItemKind::Mod { .. } = item.kind {
- self.is_exported.push(cx.access_levels.is_exported(item.hir_id()));
+ self.is_exported.push(cx.access_levels.is_exported(item.def_id));
}
}