Auto merge of #4551 - mikerite:fix-ice-reporting, r=llogiq

[rust.git] / clippy_lints / src / question_mark.rs

diff --git a/clippy_lints/src/question_mark.rs b/clippy_lints/src/question_mark.rs
index b2e8315716abcd92a6dabb2cf0950d61b16a572f..7e3453e260c4da2f1bb49a3b919ad89021e079c9 100644 (file)
--- a/clippy_lints/src/question_mark.rs
+++ b/clippy_lints/src/question_mark.rs
@@ -1,14 +1,14 @@
 use if_chain::if_chain;
-use rustc::hir::def::Def;
+use rustc::hir::def::{DefKind, Res};
+use rustc::hir::ptr::P;
 use rustc::hir::*;
 use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
-use rustc::{declare_tool_lint, lint_array};
+use rustc::{declare_lint_pass, declare_tool_lint};
 use rustc_errors::Applicability;
-use syntax::ptr::P;
 
 use crate::utils::paths::*;
 use crate::utils::sugg::Sugg;
-use crate::utils::{match_type, span_lint_and_then, SpanlessEq};
+use crate::utils::{higher, match_def_path, match_type, span_lint_and_then, SpanlessEq};
 
 declare_clippy_lint! {
     /// **What it does:** Checks for expressions that could be replaced by the question mark operator.
@@ -34,20 +34,9 @@
     "checks for expressions that could be replaced by the question mark operator"
 }
 
-#[derive(Copy, Clone)]
-pub struct Pass;
+declare_lint_pass!(QuestionMark => [QUESTION_MARK]);
 
-impl LintPass for Pass {
-    fn get_lints(&self) -> LintArray {
-        lint_array!(QUESTION_MARK)
-    }
-
-    fn name(&self) -> &'static str {
-        "QuestionMark"
-    }
-}
-
-impl Pass {
+impl QuestionMark {
     /// Checks if the given expression on the given context matches the following structure:
     ///
     /// ```ignore
@@ -59,9 +48,9 @@ impl Pass {
     /// If it matches, it will suggest to use the question mark operator instead
     fn check_is_none_and_early_return_none(cx: &LateContext<'_, '_>, expr: &Expr) {
         if_chain! {
-            if let ExprKind::If(if_expr, body, else_) = &expr.node;
+            if let Some((if_expr, body, else_)) = higher::if_block(&expr);
             if let ExprKind::MethodCall(segment, _, args) = &if_expr.node;
-            if segment.ident.name == "is_none";
+            if segment.ident.name == sym!(is_none);
             if Self::expression_returns_none(cx, body);
             if let Some(subject) = args.get(0);
             if Self::is_option(cx, subject);
@@ -128,8 +117,10 @@ fn expression_returns_none(cx: &LateContext<'_, '_>, expression: &Expr) -> bool
             },
             ExprKind::Ret(Some(ref expr)) => Self::expression_returns_none(cx, expr),
             ExprKind::Path(ref qp) => {
-                if let Def::Ctor(def_id, def::CtorOf::Variant, _) = cx.tables.qpath_def(qp, expression.hir_id) {
-                    return cx.match_def_path(def_id, &OPTION_NONE);
+                if let Res::Def(DefKind::Ctor(def::CtorOf::Variant, def::CtorKind::Const), def_id) =
+                    cx.tables.qpath_res(qp, expression.hir_id)
+                {
+                    return match_def_path(cx, def_id, &OPTION_NONE);
                 }
 
                 false
@@ -138,7 +129,7 @@ fn expression_returns_none(cx: &LateContext<'_, '_>, expression: &Expr) -> bool
         }
     }
 
-    fn return_expression(block: &Block) -> Option<P<Expr>> {
+    fn return_expression(block: &Block) -> Option<&P<Expr>> {
         // Check if last expression is a return statement. Then, return the expression
         if_chain! {
             if block.stmts.len() == 1;
@@ -148,7 +139,7 @@ fn return_expression(block: &Block) -> Option<P<Expr>> {
             if let &Some(ref ret_expr) = ret_expr;
 
             then {
-                return Some(ret_expr.clone());
+                return Some(ret_expr);
             }
         }
 
@@ -157,7 +148,7 @@ fn return_expression(block: &Block) -> Option<P<Expr>> {
             if block.stmts.len() == 0;
             if let Some(ExprKind::Ret(Some(ret_expr))) = block.expr.as_ref().map(|e| &e.node);
             then {
-                return Some(ret_expr.clone());
+                return Some(ret_expr);
             }
         }
 
@@ -165,7 +156,7 @@ fn return_expression(block: &Block) -> Option<P<Expr>> {
     }
 }
 
-impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
+impl<'a, 'tcx> LateLintPass<'a, 'tcx> for QuestionMark {
     fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
         Self::check_is_none_and_early_return_none(cx, expr);
     }