-use crate::utils::{is_direct_expn_of, span_lint_and_help};
+use clippy_utils::diagnostics::span_lint_and_help;
+use clippy_utils::is_direct_expn_of;
use if_chain::if_chain;
+use rustc_ast::ast::{Expr, ExprKind};
use rustc_lint::{EarlyContext, EarlyLintPass};
use rustc_session::{declare_lint_pass, declare_tool_lint};
-use syntax::ast::{Expr, ExprKind};
+use rustc_span::sym;
declare_clippy_lint! {
- /// **What it does:** Checks for usage of `option_env!(...).unwrap()` and
+ /// ### What it does
+ /// Checks for usage of `option_env!(...).unwrap()` and
/// suggests usage of the `env!` macro.
///
- /// **Why is this bad?** Unwrapping the result of `option_env!` will panic
+ /// ### Why is this bad?
+ /// Unwrapping the result of `option_env!` will panic
/// at run-time if the environment variable doesn't exist, whereas `env!`
/// catches it at compile-time.
///
- /// **Known problems:** None.
- ///
- /// **Example:**
- ///
+ /// ### Example
/// ```rust,no_run
/// let _ = option_env!("HOME").unwrap();
/// ```
impl EarlyLintPass for OptionEnvUnwrap {
fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &Expr) {
if_chain! {
- if let ExprKind::MethodCall(path_segment, args) = &expr.kind;
- let method_name = path_segment.ident.as_str();
- if method_name == "expect" || method_name == "unwrap";
+ if let ExprKind::MethodCall(path_segment, args, _) = &expr.kind;
+ if matches!(path_segment.ident.name, sym::expect | sym::unwrap);
if let ExprKind::Call(caller, _) = &args[0].kind;
if is_direct_expn_of(caller.span, "option_env").is_some();
then {
OPTION_ENV_UNWRAP,
expr.span,
"this will panic at run-time if the environment variable doesn't exist at compile-time",
+ None,
"consider using the `env!` macro instead"
);
}