//! This lint is **warn** by default
use crate::utils::sugg::Sugg;
-use crate::utils::{in_macro, span_lint, span_lint_and_sugg};
-use rustc::hir::*;
-use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
-use rustc::{declare_lint_pass, declare_tool_lint};
+use crate::utils::{higher, parent_node_is_if_expr, span_lint, span_lint_and_sugg};
use rustc_errors::Applicability;
+use rustc_hir::*;
+use rustc_lint::{LateContext, LateLintPass};
+use rustc_session::{declare_lint_pass, declare_tool_lint};
+use rustc_span::source_map::Spanned;
use syntax::ast::LitKind;
-use syntax::source_map::Spanned;
declare_clippy_lint! {
/// **What it does:** Checks for expressions of the form `if c { true } else {
/// **Why is this bad?** Redundant code.
///
/// **Known problems:** Maybe false positives: Sometimes, the two branches are
- /// painstakingly documented (which we of course do not detect), so they *may*
+ /// painstakingly documented (which we, of course, do not detect), so they *may*
/// have some value. Even then, the documentation can be rewritten to match the
/// shorter code.
///
/// **Example:**
- /// ```rust
+ /// ```rust,ignore
/// if x {
/// false
/// } else {
/// true
/// }
/// ```
+ /// Could be written as
+ /// ```rust,ignore
+ /// !x
+ /// ```
pub NEEDLESS_BOOL,
complexity,
"if-statements with plain booleans in the then- and else-clause, e.g., `if p { true } else { false }`"
/// **Known problems:** None.
///
/// **Example:**
- /// ```rust
+ /// ```rust,ignore
/// if x == true {} // could be `if x { }`
/// ```
pub BOOL_COMPARISON,
declare_lint_pass!(NeedlessBool => [NEEDLESS_BOOL]);
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessBool {
- fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) {
+ fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr<'_>) {
use self::Expression::*;
- if let ExprKind::If(ref pred, ref then_block, Some(ref else_expr)) = e.node {
+ if let Some((ref pred, ref then_block, Some(ref else_expr))) = higher::if_block(&e) {
let reduce = |ret, not| {
let mut applicability = Applicability::MachineApplicable;
let snip = Sugg::hir_with_applicability(cx, pred, "<predicate>", &mut applicability);
applicability,
);
};
- if let ExprKind::Block(ref then_block, _) = then_block.node {
+ if let ExprKind::Block(ref then_block, _) = then_block.kind {
match (fetch_bool_block(then_block), fetch_bool_expr(else_expr)) {
(RetBool(true), RetBool(true)) | (Bool(true), Bool(true)) => {
span_lint(
_ => (),
}
} else {
- panic!("IfExpr 'then' node is not an ExprKind::Block");
+ panic!("IfExpr `then` node is not an `ExprKind::Block`");
}
}
}
}
-fn parent_node_is_if_expr<'a, 'b>(expr: &Expr, cx: &LateContext<'a, 'b>) -> bool {
- let parent_id = cx.tcx.hir().get_parent_node_by_hir_id(expr.hir_id);
- let parent_node = cx.tcx.hir().get_by_hir_id(parent_id);
-
- if let rustc::hir::Node::Expr(e) = parent_node {
- if let ExprKind::If(_, _, _) = e.node {
- return true;
- }
- }
-
- false
-}
-
declare_lint_pass!(BoolComparison => [BOOL_COMPARISON]);
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for BoolComparison {
- fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) {
- if in_macro(e.span) {
+ fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr<'_>) {
+ if e.span.from_expansion() {
return;
}
- if let ExprKind::Binary(Spanned { node, .. }, ..) = e.node {
+ if let ExprKind::Binary(Spanned { node, .. }, ..) = e.kind {
let ignore_case = None::<(fn(_) -> _, &str)>;
let ignore_no_literal = None::<(fn(_, _) -> _, &str)>;
match node {
fn check_comparison<'a, 'tcx>(
cx: &LateContext<'a, 'tcx>,
- e: &'tcx Expr,
+ e: &'tcx Expr<'_>,
left_true: Option<(impl FnOnce(Sugg<'a>) -> Sugg<'a>, &str)>,
left_false: Option<(impl FnOnce(Sugg<'a>) -> Sugg<'a>, &str)>,
right_true: Option<(impl FnOnce(Sugg<'a>) -> Sugg<'a>, &str)>,
) {
use self::Expression::*;
- if let ExprKind::Binary(_, ref left_side, ref right_side) = e.node {
+ if let ExprKind::Binary(_, ref left_side, ref right_side) = e.kind {
let (l_ty, r_ty) = (cx.tables.expr_ty(left_side), cx.tables.expr_ty(right_side));
if l_ty.is_bool() && r_ty.is_bool() {
let mut applicability = Applicability::MachineApplicable;
fn suggest_bool_comparison<'a, 'tcx>(
cx: &LateContext<'a, 'tcx>,
- e: &'tcx Expr,
- expr: &Expr,
+ e: &'tcx Expr<'_>,
+ expr: &Expr<'_>,
mut applicability: Applicability,
message: &str,
conv_hint: impl FnOnce(Sugg<'a>) -> Sugg<'a>,
Other,
}
-fn fetch_bool_block(block: &Block) -> Expression {
+fn fetch_bool_block(block: &Block<'_>) -> Expression {
match (&*block.stmts, block.expr.as_ref()) {
(&[], Some(e)) => fetch_bool_expr(&**e),
(&[ref e], None) => {
- if let StmtKind::Semi(ref e) = e.node {
- if let ExprKind::Ret(_) = e.node {
+ if let StmtKind::Semi(ref e) = e.kind {
+ if let ExprKind::Ret(_) = e.kind {
fetch_bool_expr(&**e)
} else {
Expression::Other
}
}
-fn fetch_bool_expr(expr: &Expr) -> Expression {
- match expr.node {
+fn fetch_bool_expr(expr: &Expr<'_>) -> Expression {
+ match expr.kind {
ExprKind::Block(ref block, _) => fetch_bool_block(block),
ExprKind::Lit(ref lit_ptr) => {
if let LitKind::Bool(value) = lit_ptr.node {
projects / rust.git / blobdiff