use std::iter;
declare_clippy_lint! {
- /// **What it does:** Detects passing a mutable reference to a function that only
+ /// ### What it does
+ /// Detects passing a mutable reference to a function that only
/// requires an immutable reference.
///
- /// **Why is this bad?** The mutable reference rules out all other references to
+ /// ### Why is this bad?
+ /// The mutable reference rules out all other references to
/// the value. Also the code misleads about the intent of the call site.
///
- /// **Known problems:** None.
- ///
- /// **Example:**
+ /// ### Example
/// ```ignore
/// // Bad
/// my_vec.push(&mut value)
/// // Good
/// my_vec.push(&value)
/// ```
+ #[clippy::version = "pre 1.29.0"]
pub UNNECESSARY_MUT_PASSED,
style,
"an argument passed as a mutable reference although the callee only demands an immutable reference"
);
}
},
- ExprKind::MethodCall(path, _, arguments, _) => {
+ ExprKind::MethodCall(path, arguments, _) => {
let def_id = cx.typeck_results().type_dependent_def_id(e.hir_id).unwrap();
let substs = cx.typeck_results().node_substs(e.hir_id);
let method_type = cx.tcx.type_of(def_id).subst(cx.tcx, substs);
- check_arguments(cx, arguments, method_type, &path.ident.as_str(), "method");
+ check_arguments(cx, arguments, method_type, path.ident.as_str(), "method");
},
_ => (),
}