//! lint when there is a large size difference between variants on an enum
use crate::utils::{snippet_opt, span_lint_and_then};
-use rustc::hir::*;
-use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
use rustc::ty::layout::LayoutOf;
-use rustc::{declare_tool_lint, lint_array};
use rustc_errors::Applicability;
+use rustc_hir::*;
+use rustc_lint::{LateContext, LateLintPass};
+use rustc_session::{declare_tool_lint, impl_lint_pass};
declare_clippy_lint! {
/// **What it does:** Checks for large size differences between variants on
}
impl LargeEnumVariant {
+ #[must_use]
pub fn new(maximum_size_difference_allowed: u64) -> Self {
Self {
maximum_size_difference_allowed,
}
}
-impl LintPass for LargeEnumVariant {
- fn get_lints(&self) -> LintArray {
- lint_array!(LARGE_ENUM_VARIANT)
- }
-
- fn name(&self) -> &'static str {
- "LargeEnumVariant"
- }
-}
+impl_lint_pass!(LargeEnumVariant => [LARGE_ENUM_VARIANT]);
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for LargeEnumVariant {
- fn check_item(&mut self, cx: &LateContext<'_, '_>, item: &Item) {
- let did = cx.tcx.hir().local_def_id_from_hir_id(item.hir_id);
- if let ItemKind::Enum(ref def, _) = item.node {
+ fn check_item(&mut self, cx: &LateContext<'_, '_>, item: &Item<'_>) {
+ let did = cx.tcx.hir().local_def_id(item.hir_id);
+ if let ItemKind::Enum(ref def, _) = item.kind {
let ty = cx.tcx.type_of(did);
let adt = ty.ty_adt_def().expect("already checked whether this is an enum");
"large size difference between variants",
|db| {
if variant.fields.len() == 1 {
- let span = match def.variants[i].node.data {
+ let span = match def.variants[i].data {
VariantData::Struct(ref fields, ..) | VariantData::Tuple(ref fields, ..) => {
fields[0].ty.span
},