//! lint when items are used after statements
+use matches::matches;
use rustc::lint::*;
+use rustc::{declare_lint, lint_array};
use syntax::ast::*;
-use utils::{in_macro, span_lint};
+use crate::utils::{in_macro, span_lint};
-/// **What it does:** This lints checks for items declared after some statement in a block
+/// **What it does:** Checks for items declared after some statement in a block.
///
-/// **Why is this bad?** Items live for the entire scope they are declared in. But statements are
-/// processed in order. This might cause confusion as it's hard to figure out which item is meant
-/// in a statement.
+/// **Why is this bad?** Items live for the entire scope they are declared
+/// in. But statements are processed in order. This might cause confusion as
+/// it's hard to figure out which item is meant in a statement.
///
-/// **Known problems:** None
+/// **Known problems:** None.
///
/// **Example:**
/// ```rust
/// foo(); // prints "foo"
/// }
/// ```
-declare_lint! {
+declare_clippy_lint! {
pub ITEMS_AFTER_STATEMENTS,
- Allow,
- "finds blocks where an item comes after a statement"
+ pedantic,
+ "blocks where an item comes after a statement"
}
pub struct ItemsAfterStatements;
impl EarlyLintPass for ItemsAfterStatements {
fn check_block(&mut self, cx: &EarlyContext, item: &Block) {
- if in_macro(cx, item.span) {
+ if in_macro(item.span) {
return;
}
// skip initial items
- let stmts = item.stmts.iter()
- .map(|stmt| &stmt.node)
- .skip_while(|s| matches!(**s, StmtKind::Item(..)));
+ let stmts = item.stmts
+ .iter()
+ .map(|stmt| &stmt.node)
+ .skip_while(|s| matches!(**s, StmtKind::Item(..)));
// lint on all further items
for stmt in stmts {
if let StmtKind::Item(ref it) = *stmt {
- if in_macro(cx, it.span) {
+ if in_macro(it.span) {
return;
}
- span_lint(cx,
- ITEMS_AFTER_STATEMENTS,
- it.span,
- "adding items after statements is confusing, since items exist from the \
- start of the scope");
+ if let ItemKind::MacroDef(..) = it.node {
+ // do not lint `macro_rules`, but continue processing further statements
+ continue;
+ }
+ span_lint(
+ cx,
+ ITEMS_AFTER_STATEMENTS,
+ it.span,
+ "adding items after statements is confusing, since items exist from the \
+ start of the scope",
+ );
}
}
}